HSI: omap_ssi_port: fix debugfs_simple_attr.cocci warnings

[sfrench/cifs-2.6.git] / drivers / hsi / controllers / omap_ssi_port.c

diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
index 2ada82d2ec8cc4d3b5a390b76d6dd388cbc35263..afbf1345709da0d9cf7df2958ff6ba41a6002963 100644 (file)
--- a/drivers/hsi/controllers/omap_ssi_port.c
+++ b/drivers/hsi/controllers/omap_ssi_port.c
@@ -57,7 +57,7 @@ static void ssi_debug_remove_port(struct hsi_port *port)
        debugfs_remove_recursive(omap_port->dir);
 }
 
-static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)
+static int ssi_port_regs_show(struct seq_file *m, void *p __maybe_unused)
 {
        struct hsi_port *port = m->private;
        struct omap_ssi_port *omap_port = hsi_port_drvdata(port);
@@ -132,17 +132,7 @@ static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)
        return 0;
 }
 
-static int ssi_port_regs_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, ssi_debug_port_show, inode->i_private);
-}
-
-static const struct file_operations ssi_port_regs_fops = {
-       .open           = ssi_port_regs_open,
-       .read           = seq_read,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ssi_port_regs);
 
 static int ssi_div_get(void *data, u64 *val)
 {
@@ -172,7 +162,7 @@ static int ssi_div_set(void *data, u64 val)
        return 0;
 }
 
-DEFINE_SIMPLE_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(ssi_sst_div_fops, ssi_div_get, ssi_div_set, "%llu\n");
 
 static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
                                     struct dentry *dir)
@@ -187,8 +177,8 @@ static int ssi_debug_add_port(struct omap_ssi_port *omap_port,
        dir = debugfs_create_dir("sst", dir);
        if (!dir)
                return -ENOMEM;
-       debugfs_create_file("divisor", S_IRUGO | S_IWUSR, dir, port,
-                           &ssi_sst_div_fops);
+       debugfs_create_file_unsafe("divisor", 0644, dir, port,
+                                  &ssi_sst_div_fops);
 
        return 0;
 }