Merge remote branch 'nouveau/for-airlied' of ../drm-nouveau-next into drm-core-next
[sfrench/cifs-2.6.git] / drivers / gpu / drm / nouveau / nouveau_connector.c
index 149ed224c3cb48c86c56e2f4b9bb18a599190d10..734e92635e83f103885cecbf8674d077a9df5cd9 100644 (file)
@@ -102,63 +102,15 @@ nouveau_connector_destroy(struct drm_connector *drm_connector)
        kfree(drm_connector);
 }
 
-static void
-nouveau_connector_ddc_prepare(struct drm_connector *connector, int *flags)
-{
-       struct drm_nouveau_private *dev_priv = connector->dev->dev_private;
-
-       if (dev_priv->card_type >= NV_50)
-               return;
-
-       *flags = 0;
-       if (NVLockVgaCrtcs(dev_priv->dev, false))
-               *flags |= 1;
-       if (nv_heads_tied(dev_priv->dev))
-               *flags |= 2;
-
-       if (*flags & 2)
-               NVSetOwner(dev_priv->dev, 0); /* necessary? */
-}
-
-static void
-nouveau_connector_ddc_finish(struct drm_connector *connector, int flags)
-{
-       struct drm_nouveau_private *dev_priv = connector->dev->dev_private;
-
-       if (dev_priv->card_type >= NV_50)
-               return;
-
-       if (flags & 2)
-               NVSetOwner(dev_priv->dev, 4);
-       if (flags & 1)
-               NVLockVgaCrtcs(dev_priv->dev, true);
-}
-
 static struct nouveau_i2c_chan *
 nouveau_connector_ddc_detect(struct drm_connector *connector,
                             struct nouveau_encoder **pnv_encoder)
 {
        struct drm_device *dev = connector->dev;
-       uint8_t out_buf[] = { 0x0, 0x0}, buf[2];
-       int ret, flags, i;
-
-       struct i2c_msg msgs[] = {
-               {
-                       .addr = 0x50,
-                       .flags = 0,
-                       .len = 1,
-                       .buf = out_buf,
-               },
-               {
-                       .addr = 0x50,
-                       .flags = I2C_M_RD,
-                       .len = 1,
-                       .buf = buf,
-               }
-       };
+       int i;
 
        for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
-               struct nouveau_i2c_chan *i2c = NULL;
+               struct nouveau_i2c_chan *i2c;
                struct nouveau_encoder *nv_encoder;
                struct drm_mode_object *obj;
                int id;
@@ -171,17 +123,9 @@ nouveau_connector_ddc_detect(struct drm_connector *connector,
                if (!obj)
                        continue;
                nv_encoder = nouveau_encoder(obj_to_encoder(obj));
+               i2c = nouveau_i2c_find(dev, nv_encoder->dcb->i2c_index);
 
-               if (nv_encoder->dcb->i2c_index < 0xf)
-                       i2c = nouveau_i2c_find(dev, nv_encoder->dcb->i2c_index);
-               if (!i2c)
-                       continue;
-
-               nouveau_connector_ddc_prepare(connector, &flags);
-               ret = i2c_transfer(&i2c->adapter, msgs, 2);
-               nouveau_connector_ddc_finish(connector, flags);
-
-               if (ret == 2) {
+               if (i2c && nouveau_probe_i2c_addr(i2c, 0x50)) {
                        *pnv_encoder = nv_encoder;
                        return i2c;
                }
@@ -234,21 +178,7 @@ nouveau_connector_detect(struct drm_connector *connector)
        struct nouveau_connector *nv_connector = nouveau_connector(connector);
        struct nouveau_encoder *nv_encoder = NULL;
        struct nouveau_i2c_chan *i2c;
-       int type, flags;
-
-       if (nv_connector->dcb->type == DCB_CONNECTOR_LVDS)
-               nv_encoder = find_encoder_by_type(connector, OUTPUT_LVDS);
-       if (nv_encoder && nv_connector->native_mode) {
-               unsigned status = connector_status_connected;
-
-#if defined(CONFIG_ACPI_BUTTON) || \
-       (defined(CONFIG_ACPI_BUTTON_MODULE) && defined(MODULE))
-               if (!nouveau_ignorelid && !acpi_lid_open())
-                       status = connector_status_unknown;
-#endif
-               nouveau_connector_set_encoder(connector, nv_encoder);
-               return status;
-       }
+       int type;
 
        /* Cleanup the previous EDID block. */
        if (nv_connector->edid) {
@@ -259,9 +189,7 @@ nouveau_connector_detect(struct drm_connector *connector)
 
        i2c = nouveau_connector_ddc_detect(connector, &nv_encoder);
        if (i2c) {
-               nouveau_connector_ddc_prepare(connector, &flags);
                nv_connector->edid = drm_get_edid(connector, &i2c->adapter);
-               nouveau_connector_ddc_finish(connector, flags);
                drm_mode_connector_update_edid_property(connector,
                                                        nv_connector->edid);
                if (!nv_connector->edid) {
@@ -321,6 +249,85 @@ detect_analog:
        return connector_status_disconnected;
 }
 
+static enum drm_connector_status
+nouveau_connector_detect_lvds(struct drm_connector *connector)
+{
+       struct drm_device *dev = connector->dev;
+       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct nouveau_connector *nv_connector = nouveau_connector(connector);
+       struct nouveau_encoder *nv_encoder = NULL;
+       enum drm_connector_status status = connector_status_disconnected;
+
+       /* Cleanup the previous EDID block. */
+       if (nv_connector->edid) {
+               drm_mode_connector_update_edid_property(connector, NULL);
+               kfree(nv_connector->edid);
+               nv_connector->edid = NULL;
+       }
+
+       nv_encoder = find_encoder_by_type(connector, OUTPUT_LVDS);
+       if (!nv_encoder)
+               return connector_status_disconnected;
+
+       /* Try retrieving EDID via DDC */
+       if (!dev_priv->vbios.fp_no_ddc) {
+               status = nouveau_connector_detect(connector);
+               if (status == connector_status_connected)
+                       goto out;
+       }
+
+       /* On some laptops (Sony, i'm looking at you) there appears to
+        * be no direct way of accessing the panel's EDID.  The only
+        * option available to us appears to be to ask ACPI for help..
+        *
+        * It's important this check's before trying straps, one of the
+        * said manufacturer's laptops are configured in such a way
+        * the nouveau decides an entry in the VBIOS FP mode table is
+        * valid - it's not (rh#613284)
+        */
+       if (nv_encoder->dcb->lvdsconf.use_acpi_for_edid) {
+               if (!nouveau_acpi_edid(dev, connector)) {
+                       status = connector_status_connected;
+                       goto out;
+               }
+       }
+
+       /* If no EDID found above, and the VBIOS indicates a hardcoded
+        * modeline is avalilable for the panel, set it as the panel's
+        * native mode and exit.
+        */
+       if (nouveau_bios_fp_mode(dev, NULL) && (dev_priv->vbios.fp_no_ddc ||
+           nv_encoder->dcb->lvdsconf.use_straps_for_mode)) {
+               status = connector_status_connected;
+               goto out;
+       }
+
+       /* Still nothing, some VBIOS images have a hardcoded EDID block
+        * stored for the panel stored in them.
+        */
+       if (!dev_priv->vbios.fp_no_ddc) {
+               struct edid *edid =
+                       (struct edid *)nouveau_bios_embedded_edid(dev);
+               if (edid) {
+                       nv_connector->edid = kmalloc(EDID_LENGTH, GFP_KERNEL);
+                       *(nv_connector->edid) = *edid;
+                       status = connector_status_connected;
+               }
+       }
+
+out:
+#if defined(CONFIG_ACPI_BUTTON) || \
+       (defined(CONFIG_ACPI_BUTTON_MODULE) && defined(MODULE))
+       if (status == connector_status_connected &&
+           !nouveau_ignorelid && !acpi_lid_open())
+               status = connector_status_unknown;
+#endif
+
+       drm_mode_connector_update_edid_property(connector, nv_connector->edid);
+       nouveau_connector_set_encoder(connector, nv_encoder);
+       return status;
+}
+
 static void
 nouveau_connector_force(struct drm_connector *connector)
 {
@@ -441,7 +448,8 @@ nouveau_connector_native_mode(struct drm_connector *connector)
        int high_w = 0, high_h = 0, high_v = 0;
 
        list_for_each_entry(mode, &nv_connector->base.probed_modes, head) {
-               if (helper->mode_valid(connector, mode) != MODE_OK)
+               if (helper->mode_valid(connector, mode) != MODE_OK ||
+                   (mode->flags & DRM_MODE_FLAG_INTERLACE))
                        continue;
 
                /* Use preferred mode if there is one.. */
@@ -534,21 +542,27 @@ static int
 nouveau_connector_get_modes(struct drm_connector *connector)
 {
        struct drm_device *dev = connector->dev;
+       struct drm_nouveau_private *dev_priv = dev->dev_private;
        struct nouveau_connector *nv_connector = nouveau_connector(connector);
        struct nouveau_encoder *nv_encoder = nv_connector->detected_encoder;
        int ret = 0;
 
-       /* If we're not LVDS, destroy the previous native mode, the attached
-        * monitor could have changed.
+       /* destroy the native mode, the attached monitor could have changed.
         */
-       if (nv_connector->dcb->type != DCB_CONNECTOR_LVDS &&
-           nv_connector->native_mode) {
+       if (nv_connector->native_mode) {
                drm_mode_destroy(dev, nv_connector->native_mode);
                nv_connector->native_mode = NULL;
        }
 
        if (nv_connector->edid)
                ret = drm_add_edid_modes(connector, nv_connector->edid);
+       else
+       if (nv_encoder->dcb->type == OUTPUT_LVDS &&
+           (nv_encoder->dcb->lvdsconf.use_straps_for_mode ||
+            dev_priv->vbios.fp_no_ddc) && nouveau_bios_fp_mode(dev, NULL)) {
+               nv_connector->native_mode = drm_mode_create(dev);
+               nouveau_bios_fp_mode(dev, nv_connector->native_mode);
+       }
 
        /* Find the native mode if this is a digital panel, if we didn't
         * find any modes through DDC previously add the native mode to
@@ -569,7 +583,8 @@ nouveau_connector_get_modes(struct drm_connector *connector)
                ret = get_slave_funcs(nv_encoder)->
                        get_modes(to_drm_encoder(nv_encoder), connector);
 
-       if (nv_encoder->dcb->type == OUTPUT_LVDS)
+       if (nv_connector->dcb->type == DCB_CONNECTOR_LVDS ||
+           nv_connector->dcb->type == DCB_CONNECTOR_eDP)
                ret += nouveau_connector_scaler_modes_add(connector);
 
        return ret;
@@ -643,6 +658,44 @@ nouveau_connector_best_encoder(struct drm_connector *connector)
        return NULL;
 }
 
+void
+nouveau_connector_set_polling(struct drm_connector *connector)
+{
+       struct drm_device *dev = connector->dev;
+       struct drm_nouveau_private *dev_priv = dev->dev_private;
+       struct drm_crtc *crtc;
+       bool spare_crtc = false;
+
+       list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
+               spare_crtc |= !crtc->enabled;
+
+       connector->polled = 0;
+
+       switch (connector->connector_type) {
+       case DRM_MODE_CONNECTOR_VGA:
+       case DRM_MODE_CONNECTOR_TV:
+               if (dev_priv->card_type >= NV_50 ||
+                   (nv_gf4_disp_arch(dev) && spare_crtc))
+                       connector->polled = DRM_CONNECTOR_POLL_CONNECT;
+               break;
+
+       case DRM_MODE_CONNECTOR_DVII:
+       case DRM_MODE_CONNECTOR_DVID:
+       case DRM_MODE_CONNECTOR_HDMIA:
+       case DRM_MODE_CONNECTOR_DisplayPort:
+       case DRM_MODE_CONNECTOR_eDP:
+               if (dev_priv->card_type >= NV_50)
+                       connector->polled = DRM_CONNECTOR_POLL_HPD;
+               else if (connector->connector_type == DRM_MODE_CONNECTOR_DVID ||
+                        spare_crtc)
+                       connector->polled = DRM_CONNECTOR_POLL_CONNECT;
+               break;
+
+       default:
+               break;
+       }
+}
+
 static const struct drm_connector_helper_funcs
 nouveau_connector_helper_funcs = {
        .get_modes = nouveau_connector_get_modes,
@@ -662,148 +715,74 @@ nouveau_connector_funcs = {
        .force = nouveau_connector_force
 };
 
-static int
-nouveau_connector_create_lvds(struct drm_device *dev,
-                             struct drm_connector *connector)
-{
-       struct nouveau_connector *nv_connector = nouveau_connector(connector);
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-       struct nouveau_i2c_chan *i2c = NULL;
-       struct nouveau_encoder *nv_encoder;
-       struct drm_display_mode native, *mode, *temp;
-       bool dummy, if_is_24bit = false;
-       int ret, flags;
-
-       nv_encoder = find_encoder_by_type(connector, OUTPUT_LVDS);
-       if (!nv_encoder)
-               return -ENODEV;
-
-       ret = nouveau_bios_parse_lvds_table(dev, 0, &dummy, &if_is_24bit);
-       if (ret) {
-               NV_ERROR(dev, "Error parsing LVDS table, disabling LVDS\n");
-               return ret;
-       }
-       nv_connector->use_dithering = !if_is_24bit;
-
-       /* Firstly try getting EDID over DDC, if allowed and I2C channel
-        * is available.
-        */
-       if (!dev_priv->vbios.fp_no_ddc && nv_encoder->dcb->i2c_index < 0xf)
-               i2c = nouveau_i2c_find(dev, nv_encoder->dcb->i2c_index);
-
-       if (i2c) {
-               nouveau_connector_ddc_prepare(connector, &flags);
-               nv_connector->edid = drm_get_edid(connector, &i2c->adapter);
-               nouveau_connector_ddc_finish(connector, flags);
-       }
-
-       /* If no EDID found above, and the VBIOS indicates a hardcoded
-        * modeline is avalilable for the panel, set it as the panel's
-        * native mode and exit.
-        */
-       if (!nv_connector->edid && nouveau_bios_fp_mode(dev, &native) &&
-            (nv_encoder->dcb->lvdsconf.use_straps_for_mode ||
-             dev_priv->vbios.fp_no_ddc)) {
-               nv_connector->native_mode = drm_mode_duplicate(dev, &native);
-               goto out;
-       }
-
-       /* Still nothing, some VBIOS images have a hardcoded EDID block
-        * stored for the panel stored in them.
-        */
-       if (!nv_connector->edid && !nv_connector->native_mode &&
-           !dev_priv->vbios.fp_no_ddc) {
-               struct edid *edid =
-                       (struct edid *)nouveau_bios_embedded_edid(dev);
-               if (edid) {
-                       nv_connector->edid = kmalloc(EDID_LENGTH, GFP_KERNEL);
-                       *(nv_connector->edid) = *edid;
-               }
-       }
-
-       if (!nv_connector->edid)
-               goto out;
-
-       /* We didn't find/use a panel mode from the VBIOS, so parse the EDID
-        * block and look for the preferred mode there.
-        */
-       ret = drm_add_edid_modes(connector, nv_connector->edid);
-       if (ret == 0)
-               goto out;
-       nv_connector->detected_encoder = nv_encoder;
-       nv_connector->native_mode = nouveau_connector_native_mode(connector);
-       list_for_each_entry_safe(mode, temp, &connector->probed_modes, head)
-               drm_mode_remove(connector, mode);
-
-out:
-       if (!nv_connector->native_mode) {
-               NV_ERROR(dev, "LVDS present in DCB table, but couldn't "
-                             "determine its native mode.  Disabling.\n");
-               return -ENODEV;
-       }
-
-       drm_mode_connector_update_edid_property(connector, nv_connector->edid);
-       return 0;
-}
+static const struct drm_connector_funcs
+nouveau_connector_funcs_lvds = {
+       .dpms = drm_helper_connector_dpms,
+       .save = NULL,
+       .restore = NULL,
+       .detect = nouveau_connector_detect_lvds,
+       .destroy = nouveau_connector_destroy,
+       .fill_modes = drm_helper_probe_single_connector_modes,
+       .set_property = nouveau_connector_set_property,
+       .force = nouveau_connector_force
+};
 
-int
-nouveau_connector_create(struct drm_device *dev,
-                        struct dcb_connector_table_entry *dcb)
+struct drm_connector *
+nouveau_connector_create(struct drm_device *dev, int index)
 {
+       const struct drm_connector_funcs *funcs = &nouveau_connector_funcs;
        struct drm_nouveau_private *dev_priv = dev->dev_private;
        struct nouveau_connector *nv_connector = NULL;
+       struct dcb_connector_table_entry *dcb = NULL;
        struct drm_connector *connector;
-       struct drm_encoder *encoder;
-       int ret, type;
+       int type, ret = 0;
 
        NV_DEBUG_KMS(dev, "\n");
 
+       if (index >= dev_priv->vbios.dcb.connector.entries)
+               return ERR_PTR(-EINVAL);
+
+       dcb = &dev_priv->vbios.dcb.connector.entry[index];
+       if (dcb->drm)
+               return dcb->drm;
+
        switch (dcb->type) {
-       case DCB_CONNECTOR_NONE:
-               return 0;
        case DCB_CONNECTOR_VGA:
-               NV_INFO(dev, "Detected a VGA connector\n");
                type = DRM_MODE_CONNECTOR_VGA;
                break;
        case DCB_CONNECTOR_TV_0:
        case DCB_CONNECTOR_TV_1:
        case DCB_CONNECTOR_TV_3:
-               NV_INFO(dev, "Detected a TV connector\n");
                type = DRM_MODE_CONNECTOR_TV;
                break;
        case DCB_CONNECTOR_DVI_I:
-               NV_INFO(dev, "Detected a DVI-I connector\n");
                type = DRM_MODE_CONNECTOR_DVII;
                break;
        case DCB_CONNECTOR_DVI_D:
-               NV_INFO(dev, "Detected a DVI-D connector\n");
                type = DRM_MODE_CONNECTOR_DVID;
                break;
        case DCB_CONNECTOR_HDMI_0:
        case DCB_CONNECTOR_HDMI_1:
-               NV_INFO(dev, "Detected a HDMI connector\n");
                type = DRM_MODE_CONNECTOR_HDMIA;
                break;
        case DCB_CONNECTOR_LVDS:
-               NV_INFO(dev, "Detected a LVDS connector\n");
                type = DRM_MODE_CONNECTOR_LVDS;
+               funcs = &nouveau_connector_funcs_lvds;
                break;
        case DCB_CONNECTOR_DP:
-               NV_INFO(dev, "Detected a DisplayPort connector\n");
                type = DRM_MODE_CONNECTOR_DisplayPort;
                break;
        case DCB_CONNECTOR_eDP:
-               NV_INFO(dev, "Detected an eDP connector\n");
                type = DRM_MODE_CONNECTOR_eDP;
                break;
        default:
                NV_ERROR(dev, "unknown connector type: 0x%02x!!\n", dcb->type);
-               return -EINVAL;
+               return ERR_PTR(-EINVAL);
        }
 
        nv_connector = kzalloc(sizeof(*nv_connector), GFP_KERNEL);
        if (!nv_connector)
-               return -ENOMEM;
+               return ERR_PTR(-ENOMEM);
        nv_connector->dcb = dcb;
        connector = &nv_connector->base;
 
@@ -811,27 +790,21 @@ nouveau_connector_create(struct drm_device *dev,
        connector->interlace_allowed = false;
        connector->doublescan_allowed = false;
 
-       drm_connector_init(dev, connector, &nouveau_connector_funcs, type);
+       drm_connector_init(dev, connector, funcs, type);
        drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
 
-       /* attach encoders */
-       list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
-               struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-
-               if (nv_encoder->dcb->connector != dcb->index)
-                       continue;
-
-               if (get_slave_funcs(nv_encoder))
-                       get_slave_funcs(nv_encoder)->create_resources(encoder, connector);
+       /* Check if we need dithering enabled */
+       if (dcb->type == DCB_CONNECTOR_LVDS) {
+               bool dummy, is_24bit = false;
 
-               drm_mode_connector_attach_encoder(connector, encoder);
-       }
+               ret = nouveau_bios_parse_lvds_table(dev, 0, &dummy, &is_24bit);
+               if (ret) {
+                       NV_ERROR(dev, "Error parsing LVDS table, disabling "
+                                "LVDS\n");
+                       goto fail;
+               }
 
-       if (!connector->encoder_ids[0]) {
-               NV_WARN(dev, "  no encoders, ignoring\n");
-               drm_connector_cleanup(connector);
-               kfree(connector);
-               return 0;
+               nv_connector->use_dithering = !is_24bit;
        }
 
        /* Init DVI-I specific properties */
@@ -841,12 +814,8 @@ nouveau_connector_create(struct drm_device *dev,
                drm_connector_attach_property(connector, dev->mode_config.dvi_i_select_subconnector_property, 0);
        }
 
-       if (dcb->type != DCB_CONNECTOR_LVDS)
-               nv_connector->use_dithering = false;
-
        switch (dcb->type) {
        case DCB_CONNECTOR_VGA:
-               connector->polled = DRM_CONNECTOR_POLL_CONNECT;
                if (dev_priv->card_type >= NV_50) {
                        drm_connector_attach_property(connector,
                                        dev->mode_config.scaling_mode_property,
@@ -858,17 +827,6 @@ nouveau_connector_create(struct drm_device *dev,
        case DCB_CONNECTOR_TV_3:
                nv_connector->scaling_mode = DRM_MODE_SCALE_NONE;
                break;
-       case DCB_CONNECTOR_DP:
-       case DCB_CONNECTOR_eDP:
-       case DCB_CONNECTOR_HDMI_0:
-       case DCB_CONNECTOR_HDMI_1:
-       case DCB_CONNECTOR_DVI_I:
-       case DCB_CONNECTOR_DVI_D:
-               if (dev_priv->card_type >= NV_50)
-                       connector->polled = DRM_CONNECTOR_POLL_HPD;
-               else
-                       connector->polled = DRM_CONNECTOR_POLL_CONNECT;
-               /* fall-through */
        default:
                nv_connector->scaling_mode = DRM_MODE_SCALE_FULLSCREEN;
 
@@ -882,15 +840,15 @@ nouveau_connector_create(struct drm_device *dev,
                break;
        }
 
+       nouveau_connector_set_polling(connector);
+
        drm_sysfs_connector_add(connector);
+       dcb->drm = connector;
+       return dcb->drm;
 
-       if (dcb->type == DCB_CONNECTOR_LVDS) {
-               ret = nouveau_connector_create_lvds(dev, connector);
-               if (ret) {
-                       connector->funcs->destroy(connector);
-                       return ret;
-               }
-       }
+fail:
+       drm_connector_cleanup(connector);
+       kfree(connector);
+       return ERR_PTR(ret);
 
-       return 0;
 }