drivers/gpu/drm/sun4i/sun4i_tcon.c

   1 /*
   2  * Copyright (C) 2015 Free Electrons
   3  * Copyright (C) 2015 NextThing Co
   4  *
   5  * Maxime Ripard <maxime.ripard@free-electrons.com>
   6  *
   7  * This program is free software; you can redistribute it and/or
   8  * modify it under the terms of the GNU General Public License as
   9  * published by the Free Software Foundation; either version 2 of
  10  * the License, or (at your option) any later version.
  11  */
  12
  13 #include <drm/drmP.h>
  14 #include <drm/drm_atomic_helper.h>
  15 #include <drm/drm_connector.h>
  16 #include <drm/drm_crtc.h>
  17 #include <drm/drm_crtc_helper.h>
  18 #include <drm/drm_encoder.h>
  19 #include <drm/drm_modes.h>
  20 #include <drm/drm_of.h>
  21 #include <drm/drm_panel.h>
  22
  23 #include <uapi/drm/drm_mode.h>
  24
  25 #include <linux/component.h>
  26 #include <linux/ioport.h>
  27 #include <linux/of_address.h>
  28 #include <linux/of_device.h>
  29 #include <linux/of_irq.h>
  30 #include <linux/regmap.h>
  31 #include <linux/reset.h>
  32
  33 #include "sun4i_crtc.h"
  34 #include "sun4i_dotclock.h"
  35 #include "sun4i_drv.h"
  36 #include "sun4i_lvds.h"
  37 #include "sun4i_rgb.h"
  38 #include "sun4i_tcon.h"
  39 #include "sun6i_mipi_dsi.h"
  40 #include "sun8i_tcon_top.h"
  41 #include "sunxi_engine.h"
  42
  43 static struct drm_connector *sun4i_tcon_get_connector(const struct drm_encoder *encoder)
  44 {
  45         struct drm_connector *connector;
  46         struct drm_connector_list_iter iter;
  47
  48         drm_connector_list_iter_begin(encoder->dev, &iter);
  49         drm_for_each_connector_iter(connector, &iter)
  50                 if (connector->encoder == encoder) {
  51                         drm_connector_list_iter_end(&iter);
  52                         return connector;
  53                 }
  54         drm_connector_list_iter_end(&iter);
  55
  56         return NULL;
  57 }
  58
  59 static int sun4i_tcon_get_pixel_depth(const struct drm_encoder *encoder)
  60 {
  61         struct drm_connector *connector;
  62         struct drm_display_info *info;
  63
  64         connector = sun4i_tcon_get_connector(encoder);
  65         if (!connector)
  66                 return -EINVAL;
  67
  68         info = &connector->display_info;
  69         if (info->num_bus_formats != 1)
  70                 return -EINVAL;
  71
  72         switch (info->bus_formats[0]) {
  73         case MEDIA_BUS_FMT_RGB666_1X7X3_SPWG:
  74                 return 18;
  75
  76         case MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA:
  77         case MEDIA_BUS_FMT_RGB888_1X7X4_SPWG:
  78                 return 24;
  79         }
  80
  81         return -EINVAL;
  82 }
  83
  84 static void sun4i_tcon_channel_set_status(struct sun4i_tcon *tcon, int channel,
  85                                           bool enabled)
  86 {
  87         struct clk *clk;
  88
  89         switch (channel) {
  90         case 0:
  91                 WARN_ON(!tcon->quirks->has_channel_0);
  92                 regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
  93                                    SUN4I_TCON0_CTL_TCON_ENABLE,
  94                                    enabled ? SUN4I_TCON0_CTL_TCON_ENABLE : 0);
  95                 clk = tcon->dclk;
  96                 break;
  97         case 1:
  98                 WARN_ON(!tcon->quirks->has_channel_1);
  99                 regmap_update_bits(tcon->regs, SUN4I_TCON1_CTL_REG,
 100                                    SUN4I_TCON1_CTL_TCON_ENABLE,
 101                                    enabled ? SUN4I_TCON1_CTL_TCON_ENABLE : 0);
 102                 clk = tcon->sclk1;
 103                 break;
 104         default:
 105                 DRM_WARN("Unknown channel... doing nothing\n");
 106                 return;
 107         }
 108
 109         if (enabled) {
 110                 clk_prepare_enable(clk);
 111                 clk_rate_exclusive_get(clk);
 112         } else {
 113                 clk_rate_exclusive_put(clk);
 114                 clk_disable_unprepare(clk);
 115         }
 116 }
 117
 118 static void sun4i_tcon_lvds_set_status(struct sun4i_tcon *tcon,
 119                                        const struct drm_encoder *encoder,
 120                                        bool enabled)
 121 {
 122         if (enabled) {
 123                 u8 val;
 124
 125                 regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_IF_REG,
 126                                    SUN4I_TCON0_LVDS_IF_EN,
 127                                    SUN4I_TCON0_LVDS_IF_EN);
 128
 129                 /*
 130                  * As their name suggest, these values only apply to the A31
 131                  * and later SoCs. We'll have to rework this when merging
 132                  * support for the older SoCs.
 133                  */
 134                 regmap_write(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG,
 135                              SUN6I_TCON0_LVDS_ANA0_C(2) |
 136                              SUN6I_TCON0_LVDS_ANA0_V(3) |
 137                              SUN6I_TCON0_LVDS_ANA0_PD(2) |
 138                              SUN6I_TCON0_LVDS_ANA0_EN_LDO);
 139                 udelay(2);
 140
 141                 regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG,
 142                                    SUN6I_TCON0_LVDS_ANA0_EN_MB,
 143                                    SUN6I_TCON0_LVDS_ANA0_EN_MB);
 144                 udelay(2);
 145
 146                 regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG,
 147                                    SUN6I_TCON0_LVDS_ANA0_EN_DRVC,
 148                                    SUN6I_TCON0_LVDS_ANA0_EN_DRVC);
 149
 150                 if (sun4i_tcon_get_pixel_depth(encoder) == 18)
 151                         val = 7;
 152                 else
 153                         val = 0xf;
 154
 155                 regmap_write_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA0_REG,
 156                                   SUN6I_TCON0_LVDS_ANA0_EN_DRVD(0xf),
 157                                   SUN6I_TCON0_LVDS_ANA0_EN_DRVD(val));
 158         } else {
 159                 regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_IF_REG,
 160                                    SUN4I_TCON0_LVDS_IF_EN, 0);
 161         }
 162 }
 163
 164 void sun4i_tcon_set_status(struct sun4i_tcon *tcon,
 165                            const struct drm_encoder *encoder,
 166                            bool enabled)
 167 {
 168         bool is_lvds = false;
 169         int channel;
 170
 171         switch (encoder->encoder_type) {
 172         case DRM_MODE_ENCODER_LVDS:
 173                 is_lvds = true;
 174                 /* Fallthrough */
 175         case DRM_MODE_ENCODER_DSI:
 176         case DRM_MODE_ENCODER_NONE:
 177                 channel = 0;
 178                 break;
 179         case DRM_MODE_ENCODER_TMDS:
 180         case DRM_MODE_ENCODER_TVDAC:
 181                 channel = 1;
 182                 break;
 183         default:
 184                 DRM_DEBUG_DRIVER("Unknown encoder type, doing nothing...\n");
 185                 return;
 186         }
 187
 188         if (is_lvds && !enabled)
 189                 sun4i_tcon_lvds_set_status(tcon, encoder, false);
 190
 191         regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
 192                            SUN4I_TCON_GCTL_TCON_ENABLE,
 193                            enabled ? SUN4I_TCON_GCTL_TCON_ENABLE : 0);
 194
 195         if (is_lvds && enabled)
 196                 sun4i_tcon_lvds_set_status(tcon, encoder, true);
 197
 198         sun4i_tcon_channel_set_status(tcon, channel, enabled);
 199 }
 200
 201 void sun4i_tcon_enable_vblank(struct sun4i_tcon *tcon, bool enable)
 202 {
 203         u32 mask, val = 0;
 204
 205         DRM_DEBUG_DRIVER("%sabling VBLANK interrupt\n", enable ? "En" : "Dis");
 206
 207         mask = SUN4I_TCON_GINT0_VBLANK_ENABLE(0) |
 208                 SUN4I_TCON_GINT0_VBLANK_ENABLE(1) |
 209                 SUN4I_TCON_GINT0_TCON0_TRI_FINISH_ENABLE;
 210
 211         if (enable)
 212                 val = mask;
 213
 214         regmap_update_bits(tcon->regs, SUN4I_TCON_GINT0_REG, mask, val);
 215 }
 216 EXPORT_SYMBOL(sun4i_tcon_enable_vblank);
 217
 218 /*
 219  * This function is a helper for TCON output muxing. The TCON output
 220  * muxing control register in earlier SoCs (without the TCON TOP block)
 221  * are located in TCON0. This helper returns a pointer to TCON0's
 222  * sun4i_tcon structure, or NULL if not found.
 223  */
 224 static struct sun4i_tcon *sun4i_get_tcon0(struct drm_device *drm)
 225 {
 226         struct sun4i_drv *drv = drm->dev_private;
 227         struct sun4i_tcon *tcon;
 228
 229         list_for_each_entry(tcon, &drv->tcon_list, list)
 230                 if (tcon->id == 0)
 231                         return tcon;
 232
 233         dev_warn(drm->dev,
 234                  "TCON0 not found, display output muxing may not work\n");
 235
 236         return NULL;
 237 }
 238
 239 void sun4i_tcon_set_mux(struct sun4i_tcon *tcon, int channel,
 240                         const struct drm_encoder *encoder)
 241 {
 242         int ret = -ENOTSUPP;
 243
 244         if (tcon->quirks->set_mux)
 245                 ret = tcon->quirks->set_mux(tcon, encoder);
 246
 247         DRM_DEBUG_DRIVER("Muxing encoder %s to CRTC %s: %d\n",
 248                          encoder->name, encoder->crtc->name, ret);
 249 }
 250
 251 static int sun4i_tcon_get_clk_delay(const struct drm_display_mode *mode,
 252                                     int channel)
 253 {
 254         int delay = mode->vtotal - mode->vdisplay;
 255
 256         if (mode->flags & DRM_MODE_FLAG_INTERLACE)
 257                 delay /= 2;
 258
 259         if (channel == 1)
 260                 delay -= 2;
 261
 262         delay = min(delay, 30);
 263
 264         DRM_DEBUG_DRIVER("TCON %d clock delay %u\n", channel, delay);
 265
 266         return delay;
 267 }
 268
 269 static void sun4i_tcon0_mode_set_common(struct sun4i_tcon *tcon,
 270                                         const struct drm_display_mode *mode)
 271 {
 272         /* Configure the dot clock */
 273         clk_set_rate(tcon->dclk, mode->crtc_clock * 1000);
 274
 275         /* Set the resolution */
 276         regmap_write(tcon->regs, SUN4I_TCON0_BASIC0_REG,
 277                      SUN4I_TCON0_BASIC0_X(mode->crtc_hdisplay) |
 278                      SUN4I_TCON0_BASIC0_Y(mode->crtc_vdisplay));
 279 }
 280
 281 static void sun4i_tcon0_mode_set_dithering(struct sun4i_tcon *tcon,
 282                                            const struct drm_connector *connector)
 283 {
 284         u32 bus_format = 0;
 285         u32 val = 0;
 286
 287         /* XXX Would this ever happen? */
 288         if (!connector)
 289                 return;
 290
 291         /*
 292          * FIXME: Undocumented bits
 293          *
 294          * The whole dithering process and these parameters are not
 295          * explained in the vendor documents or BSP kernel code.
 296          */
 297         regmap_write(tcon->regs, SUN4I_TCON0_FRM_SEED_PR_REG, 0x11111111);
 298         regmap_write(tcon->regs, SUN4I_TCON0_FRM_SEED_PG_REG, 0x11111111);
 299         regmap_write(tcon->regs, SUN4I_TCON0_FRM_SEED_PB_REG, 0x11111111);
 300         regmap_write(tcon->regs, SUN4I_TCON0_FRM_SEED_LR_REG, 0x11111111);
 301         regmap_write(tcon->regs, SUN4I_TCON0_FRM_SEED_LG_REG, 0x11111111);
 302         regmap_write(tcon->regs, SUN4I_TCON0_FRM_SEED_LB_REG, 0x11111111);
 303         regmap_write(tcon->regs, SUN4I_TCON0_FRM_TBL0_REG, 0x01010000);
 304         regmap_write(tcon->regs, SUN4I_TCON0_FRM_TBL1_REG, 0x15151111);
 305         regmap_write(tcon->regs, SUN4I_TCON0_FRM_TBL2_REG, 0x57575555);
 306         regmap_write(tcon->regs, SUN4I_TCON0_FRM_TBL3_REG, 0x7f7f7777);
 307
 308         /* Do dithering if panel only supports 6 bits per color */
 309         if (connector->display_info.bpc == 6)
 310                 val |= SUN4I_TCON0_FRM_CTL_EN;
 311
 312         if (connector->display_info.num_bus_formats == 1)
 313                 bus_format = connector->display_info.bus_formats[0];
 314
 315         /* Check the connection format */
 316         switch (bus_format) {
 317         case MEDIA_BUS_FMT_RGB565_1X16:
 318                 /* R and B components are only 5 bits deep */
 319                 val |= SUN4I_TCON0_FRM_CTL_MODE_R;
 320                 val |= SUN4I_TCON0_FRM_CTL_MODE_B;
 321         case MEDIA_BUS_FMT_RGB666_1X18:
 322         case MEDIA_BUS_FMT_RGB666_1X7X3_SPWG:
 323                 /* Fall through: enable dithering */
 324                 val |= SUN4I_TCON0_FRM_CTL_EN;
 325                 break;
 326         }
 327
 328         /* Write dithering settings */
 329         regmap_write(tcon->regs, SUN4I_TCON_FRM_CTL_REG, val);
 330 }
 331
 332 static void sun4i_tcon0_mode_set_cpu(struct sun4i_tcon *tcon,
 333                                      const struct drm_encoder *encoder,
 334                                      const struct drm_display_mode *mode)
 335 {
 336         /* TODO support normal CPU interface modes */
 337         struct sun6i_dsi *dsi = encoder_to_sun6i_dsi(encoder);
 338         struct mipi_dsi_device *device = dsi->device;
 339         u8 bpp = mipi_dsi_pixel_format_to_bpp(device->format);
 340         u8 lanes = device->lanes;
 341         u32 block_space, start_delay;
 342         u32 tcon_div;
 343
 344         tcon->dclk_min_div = 4;
 345         tcon->dclk_max_div = 127;
 346
 347         sun4i_tcon0_mode_set_common(tcon, mode);
 348
 349         /* Set dithering if needed */
 350         sun4i_tcon0_mode_set_dithering(tcon, sun4i_tcon_get_connector(encoder));
 351
 352         regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
 353                            SUN4I_TCON0_CTL_IF_MASK,
 354                            SUN4I_TCON0_CTL_IF_8080);
 355
 356         regmap_write(tcon->regs, SUN4I_TCON_ECC_FIFO_REG,
 357                      SUN4I_TCON_ECC_FIFO_EN);
 358
 359         regmap_write(tcon->regs, SUN4I_TCON0_CPU_IF_REG,
 360                      SUN4I_TCON0_CPU_IF_MODE_DSI |
 361                      SUN4I_TCON0_CPU_IF_TRI_FIFO_FLUSH |
 362                      SUN4I_TCON0_CPU_IF_TRI_FIFO_EN |
 363                      SUN4I_TCON0_CPU_IF_TRI_EN);
 364
 365         /*
 366          * This looks suspicious, but it works...
 367          *
 368          * The datasheet says that this should be set higher than 20 *
 369          * pixel cycle, but it's not clear what a pixel cycle is.
 370          */
 371         regmap_read(tcon->regs, SUN4I_TCON0_DCLK_REG, &tcon_div);
 372         tcon_div &= GENMASK(6, 0);
 373         block_space = mode->htotal * bpp / (tcon_div * lanes);
 374         block_space -= mode->hdisplay + 40;
 375
 376         regmap_write(tcon->regs, SUN4I_TCON0_CPU_TRI0_REG,
 377                      SUN4I_TCON0_CPU_TRI0_BLOCK_SPACE(block_space) |
 378                      SUN4I_TCON0_CPU_TRI0_BLOCK_SIZE(mode->hdisplay));
 379
 380         regmap_write(tcon->regs, SUN4I_TCON0_CPU_TRI1_REG,
 381                      SUN4I_TCON0_CPU_TRI1_BLOCK_NUM(mode->vdisplay));
 382
 383         start_delay = (mode->crtc_vtotal - mode->crtc_vdisplay - 10 - 1);
 384         start_delay = start_delay * mode->crtc_htotal * 149;
 385         start_delay = start_delay / (mode->crtc_clock / 1000) / 8;
 386         regmap_write(tcon->regs, SUN4I_TCON0_CPU_TRI2_REG,
 387                      SUN4I_TCON0_CPU_TRI2_TRANS_START_SET(10) |
 388                      SUN4I_TCON0_CPU_TRI2_START_DELAY(start_delay));
 389
 390         /*
 391          * The Allwinner BSP has a comment that the period should be
 392          * the display clock * 15, but uses an hardcoded 3000...
 393          */
 394         regmap_write(tcon->regs, SUN4I_TCON_SAFE_PERIOD_REG,
 395                      SUN4I_TCON_SAFE_PERIOD_NUM(3000) |
 396                      SUN4I_TCON_SAFE_PERIOD_MODE(3));
 397
 398         /* Enable the output on the pins */
 399         regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG,
 400                      0xe0000000);
 401 }
 402
 403 static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon,
 404                                       const struct drm_encoder *encoder,
 405                                       const struct drm_display_mode *mode)
 406 {
 407         unsigned int bp;
 408         u8 clk_delay;
 409         u32 reg, val = 0;
 410
 411         WARN_ON(!tcon->quirks->has_channel_0);
 412
 413         tcon->dclk_min_div = 7;
 414         tcon->dclk_max_div = 7;
 415         sun4i_tcon0_mode_set_common(tcon, mode);
 416
 417         /* Set dithering if needed */
 418         sun4i_tcon0_mode_set_dithering(tcon, sun4i_tcon_get_connector(encoder));
 419
 420         /* Adjust clock delay */
 421         clk_delay = sun4i_tcon_get_clk_delay(mode, 0);
 422         regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
 423                            SUN4I_TCON0_CTL_CLK_DELAY_MASK,
 424                            SUN4I_TCON0_CTL_CLK_DELAY(clk_delay));
 425
 426         /*
 427          * This is called a backporch in the register documentation,
 428          * but it really is the back porch + hsync
 429          */
 430         bp = mode->crtc_htotal - mode->crtc_hsync_start;
 431         DRM_DEBUG_DRIVER("Setting horizontal total %d, backporch %d\n",
 432                          mode->crtc_htotal, bp);
 433
 434         /* Set horizontal display timings */
 435         regmap_write(tcon->regs, SUN4I_TCON0_BASIC1_REG,
 436                      SUN4I_TCON0_BASIC1_H_TOTAL(mode->htotal) |
 437                      SUN4I_TCON0_BASIC1_H_BACKPORCH(bp));
 438
 439         /*
 440          * This is called a backporch in the register documentation,
 441          * but it really is the back porch + hsync
 442          */
 443         bp = mode->crtc_vtotal - mode->crtc_vsync_start;
 444         DRM_DEBUG_DRIVER("Setting vertical total %d, backporch %d\n",
 445                          mode->crtc_vtotal, bp);
 446
 447         /* Set vertical display timings */
 448         regmap_write(tcon->regs, SUN4I_TCON0_BASIC2_REG,
 449                      SUN4I_TCON0_BASIC2_V_TOTAL(mode->crtc_vtotal * 2) |
 450                      SUN4I_TCON0_BASIC2_V_BACKPORCH(bp));
 451
 452         reg = SUN4I_TCON0_LVDS_IF_CLK_SEL_TCON0 |
 453                 SUN4I_TCON0_LVDS_IF_DATA_POL_NORMAL |
 454                 SUN4I_TCON0_LVDS_IF_CLK_POL_NORMAL;
 455         if (sun4i_tcon_get_pixel_depth(encoder) == 24)
 456                 reg |= SUN4I_TCON0_LVDS_IF_BITWIDTH_24BITS;
 457         else
 458                 reg |= SUN4I_TCON0_LVDS_IF_BITWIDTH_18BITS;
 459
 460         regmap_write(tcon->regs, SUN4I_TCON0_LVDS_IF_REG, reg);
 461
 462         /* Setup the polarity of the various signals */
 463         if (!(mode->flags & DRM_MODE_FLAG_PHSYNC))
 464                 val |= SUN4I_TCON0_IO_POL_HSYNC_POSITIVE;
 465
 466         if (!(mode->flags & DRM_MODE_FLAG_PVSYNC))
 467                 val |= SUN4I_TCON0_IO_POL_VSYNC_POSITIVE;
 468
 469         regmap_write(tcon->regs, SUN4I_TCON0_IO_POL_REG, val);
 470
 471         /* Map output pins to channel 0 */
 472         regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
 473                            SUN4I_TCON_GCTL_IOMAP_MASK,
 474                            SUN4I_TCON_GCTL_IOMAP_TCON0);
 475
 476         /* Enable the output on the pins */
 477         regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, 0xe0000000);
 478 }
 479
 480 static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon,
 481                                      const struct drm_display_mode *mode)
 482 {
 483         unsigned int bp, hsync, vsync;
 484         u8 clk_delay;
 485         u32 val = 0;
 486
 487         WARN_ON(!tcon->quirks->has_channel_0);
 488
 489         tcon->dclk_min_div = 6;
 490         tcon->dclk_max_div = 127;
 491         sun4i_tcon0_mode_set_common(tcon, mode);
 492
 493         /* Set dithering if needed */
 494         sun4i_tcon0_mode_set_dithering(tcon, tcon->panel->connector);
 495
 496         /* Adjust clock delay */
 497         clk_delay = sun4i_tcon_get_clk_delay(mode, 0);
 498         regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
 499                            SUN4I_TCON0_CTL_CLK_DELAY_MASK,
 500                            SUN4I_TCON0_CTL_CLK_DELAY(clk_delay));
 501
 502         /*
 503          * This is called a backporch in the register documentation,
 504          * but it really is the back porch + hsync
 505          */
 506         bp = mode->crtc_htotal - mode->crtc_hsync_start;
 507         DRM_DEBUG_DRIVER("Setting horizontal total %d, backporch %d\n",
 508                          mode->crtc_htotal, bp);
 509
 510         /* Set horizontal display timings */
 511         regmap_write(tcon->regs, SUN4I_TCON0_BASIC1_REG,
 512                      SUN4I_TCON0_BASIC1_H_TOTAL(mode->crtc_htotal) |
 513                      SUN4I_TCON0_BASIC1_H_BACKPORCH(bp));
 514
 515         /*
 516          * This is called a backporch in the register documentation,
 517          * but it really is the back porch + hsync
 518          */
 519         bp = mode->crtc_vtotal - mode->crtc_vsync_start;
 520         DRM_DEBUG_DRIVER("Setting vertical total %d, backporch %d\n",
 521                          mode->crtc_vtotal, bp);
 522
 523         /* Set vertical display timings */
 524         regmap_write(tcon->regs, SUN4I_TCON0_BASIC2_REG,
 525                      SUN4I_TCON0_BASIC2_V_TOTAL(mode->crtc_vtotal * 2) |
 526                      SUN4I_TCON0_BASIC2_V_BACKPORCH(bp));
 527
 528         /* Set Hsync and Vsync length */
 529         hsync = mode->crtc_hsync_end - mode->crtc_hsync_start;
 530         vsync = mode->crtc_vsync_end - mode->crtc_vsync_start;
 531         DRM_DEBUG_DRIVER("Setting HSYNC %d, VSYNC %d\n", hsync, vsync);
 532         regmap_write(tcon->regs, SUN4I_TCON0_BASIC3_REG,
 533                      SUN4I_TCON0_BASIC3_V_SYNC(vsync) |
 534                      SUN4I_TCON0_BASIC3_H_SYNC(hsync));
 535
 536         /* Setup the polarity of the various signals */
 537         if (mode->flags & DRM_MODE_FLAG_PHSYNC)
 538                 val |= SUN4I_TCON0_IO_POL_HSYNC_POSITIVE;
 539
 540         if (mode->flags & DRM_MODE_FLAG_PVSYNC)
 541                 val |= SUN4I_TCON0_IO_POL_VSYNC_POSITIVE;
 542
 543         /*
 544          * On A20 and similar SoCs, the only way to achieve Positive Edge
 545          * (Rising Edge), is setting dclk clock phase to 2/3(240°).
 546          * By default TCON works in Negative Edge(Falling Edge),
 547          * this is why phase is set to 0 in that case.
 548          * Unfortunately there's no way to logically invert dclk through
 549          * IO_POL register.
 550          * The only acceptable way to work, triple checked with scope,
 551          * is using clock phase set to 0° for Negative Edge and set to 240°
 552          * for Positive Edge.
 553          * On A33 and similar SoCs there would be a 90° phase option,
 554          * but it divides also dclk by 2.
 555          * Following code is a way to avoid quirks all around TCON
 556          * and DOTCLOCK drivers.
 557          */
 558         if (tcon->panel) {
 559                 struct drm_panel *panel = tcon->panel;
 560                 struct drm_connector *connector = panel->connector;
 561                 struct drm_display_info display_info = connector->display_info;
 562
 563                 if (display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_POSEDGE)
 564                         clk_set_phase(tcon->dclk, 240);
 565
 566                 if (display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_NEGEDGE)
 567                         clk_set_phase(tcon->dclk, 0);
 568         }
 569
 570         regmap_update_bits(tcon->regs, SUN4I_TCON0_IO_POL_REG,
 571                            SUN4I_TCON0_IO_POL_HSYNC_POSITIVE | SUN4I_TCON0_IO_POL_VSYNC_POSITIVE,
 572                            val);
 573
 574         /* Map output pins to channel 0 */
 575         regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
 576                            SUN4I_TCON_GCTL_IOMAP_MASK,
 577                            SUN4I_TCON_GCTL_IOMAP_TCON0);
 578
 579         /* Enable the output on the pins */
 580         regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, 0);
 581 }
 582
 583 static void sun4i_tcon1_mode_set(struct sun4i_tcon *tcon,
 584                                  const struct drm_display_mode *mode)
 585 {
 586         unsigned int bp, hsync, vsync, vtotal;
 587         u8 clk_delay;
 588         u32 val;
 589
 590         WARN_ON(!tcon->quirks->has_channel_1);
 591
 592         /* Configure the dot clock */
 593         clk_set_rate(tcon->sclk1, mode->crtc_clock * 1000);
 594
 595         /* Adjust clock delay */
 596         clk_delay = sun4i_tcon_get_clk_delay(mode, 1);
 597         regmap_update_bits(tcon->regs, SUN4I_TCON1_CTL_REG,
 598                            SUN4I_TCON1_CTL_CLK_DELAY_MASK,
 599                            SUN4I_TCON1_CTL_CLK_DELAY(clk_delay));
 600
 601         /* Set interlaced mode */
 602         if (mode->flags & DRM_MODE_FLAG_INTERLACE)
 603                 val = SUN4I_TCON1_CTL_INTERLACE_ENABLE;
 604         else
 605                 val = 0;
 606         regmap_update_bits(tcon->regs, SUN4I_TCON1_CTL_REG,
 607                            SUN4I_TCON1_CTL_INTERLACE_ENABLE,
 608                            val);
 609
 610         /* Set the input resolution */
 611         regmap_write(tcon->regs, SUN4I_TCON1_BASIC0_REG,
 612                      SUN4I_TCON1_BASIC0_X(mode->crtc_hdisplay) |
 613                      SUN4I_TCON1_BASIC0_Y(mode->crtc_vdisplay));
 614
 615         /* Set the upscaling resolution */
 616         regmap_write(tcon->regs, SUN4I_TCON1_BASIC1_REG,
 617                      SUN4I_TCON1_BASIC1_X(mode->crtc_hdisplay) |
 618                      SUN4I_TCON1_BASIC1_Y(mode->crtc_vdisplay));
 619
 620         /* Set the output resolution */
 621         regmap_write(tcon->regs, SUN4I_TCON1_BASIC2_REG,
 622                      SUN4I_TCON1_BASIC2_X(mode->crtc_hdisplay) |
 623                      SUN4I_TCON1_BASIC2_Y(mode->crtc_vdisplay));
 624
 625         /* Set horizontal display timings */
 626         bp = mode->crtc_htotal - mode->crtc_hsync_start;
 627         DRM_DEBUG_DRIVER("Setting horizontal total %d, backporch %d\n",
 628                          mode->htotal, bp);
 629         regmap_write(tcon->regs, SUN4I_TCON1_BASIC3_REG,
 630                      SUN4I_TCON1_BASIC3_H_TOTAL(mode->crtc_htotal) |
 631                      SUN4I_TCON1_BASIC3_H_BACKPORCH(bp));
 632
 633         bp = mode->crtc_vtotal - mode->crtc_vsync_start;
 634         DRM_DEBUG_DRIVER("Setting vertical total %d, backporch %d\n",
 635                          mode->crtc_vtotal, bp);
 636
 637         /*
 638          * The vertical resolution needs to be doubled in all
 639          * cases. We could use crtc_vtotal and always multiply by two,
 640          * but that leads to a rounding error in interlace when vtotal
 641          * is odd.
 642          *
 643          * This happens with TV's PAL for example, where vtotal will
 644          * be 625, crtc_vtotal 312, and thus crtc_vtotal * 2 will be
 645          * 624, which apparently confuses the hardware.
 646          *
 647          * To work around this, we will always use vtotal, and
 648          * multiply by two only if we're not in interlace.
 649          */
 650         vtotal = mode->vtotal;
 651         if (!(mode->flags & DRM_MODE_FLAG_INTERLACE))
 652                 vtotal = vtotal * 2;
 653
 654         /* Set vertical display timings */
 655         regmap_write(tcon->regs, SUN4I_TCON1_BASIC4_REG,
 656                      SUN4I_TCON1_BASIC4_V_TOTAL(vtotal) |
 657                      SUN4I_TCON1_BASIC4_V_BACKPORCH(bp));
 658
 659         /* Set Hsync and Vsync length */
 660         hsync = mode->crtc_hsync_end - mode->crtc_hsync_start;
 661         vsync = mode->crtc_vsync_end - mode->crtc_vsync_start;
 662         DRM_DEBUG_DRIVER("Setting HSYNC %d, VSYNC %d\n", hsync, vsync);
 663         regmap_write(tcon->regs, SUN4I_TCON1_BASIC5_REG,
 664                      SUN4I_TCON1_BASIC5_V_SYNC(vsync) |
 665                      SUN4I_TCON1_BASIC5_H_SYNC(hsync));
 666
 667         /* Map output pins to channel 1 */
 668         regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
 669                            SUN4I_TCON_GCTL_IOMAP_MASK,
 670                            SUN4I_TCON_GCTL_IOMAP_TCON1);
 671 }
 672
 673 void sun4i_tcon_mode_set(struct sun4i_tcon *tcon,
 674                          const struct drm_encoder *encoder,
 675                          const struct drm_display_mode *mode)
 676 {
 677         switch (encoder->encoder_type) {
 678         case DRM_MODE_ENCODER_DSI:
 679                 /* DSI is tied to special case of CPU interface */
 680                 sun4i_tcon0_mode_set_cpu(tcon, encoder, mode);
 681                 break;
 682         case DRM_MODE_ENCODER_LVDS:
 683                 sun4i_tcon0_mode_set_lvds(tcon, encoder, mode);
 684                 break;
 685         case DRM_MODE_ENCODER_NONE:
 686                 sun4i_tcon0_mode_set_rgb(tcon, mode);
 687                 sun4i_tcon_set_mux(tcon, 0, encoder);
 688                 break;
 689         case DRM_MODE_ENCODER_TVDAC:
 690         case DRM_MODE_ENCODER_TMDS:
 691                 sun4i_tcon1_mode_set(tcon, mode);
 692                 sun4i_tcon_set_mux(tcon, 1, encoder);
 693                 break;
 694         default:
 695                 DRM_DEBUG_DRIVER("Unknown encoder type, doing nothing...\n");
 696         }
 697 }
 698 EXPORT_SYMBOL(sun4i_tcon_mode_set);
 699
 700 static void sun4i_tcon_finish_page_flip(struct drm_device *dev,
 701                                         struct sun4i_crtc *scrtc)
 702 {
 703         unsigned long flags;
 704
 705         spin_lock_irqsave(&dev->event_lock, flags);
 706         if (scrtc->event) {
 707                 drm_crtc_send_vblank_event(&scrtc->crtc, scrtc->event);
 708                 drm_crtc_vblank_put(&scrtc->crtc);
 709                 scrtc->event = NULL;
 710         }
 711         spin_unlock_irqrestore(&dev->event_lock, flags);
 712 }
 713
 714 static irqreturn_t sun4i_tcon_handler(int irq, void *private)
 715 {
 716         struct sun4i_tcon *tcon = private;
 717         struct drm_device *drm = tcon->drm;
 718         struct sun4i_crtc *scrtc = tcon->crtc;
 719         struct sunxi_engine *engine = scrtc->engine;
 720         unsigned int status;
 721
 722         regmap_read(tcon->regs, SUN4I_TCON_GINT0_REG, &status);
 723
 724         if (!(status & (SUN4I_TCON_GINT0_VBLANK_INT(0) |
 725                         SUN4I_TCON_GINT0_VBLANK_INT(1) |
 726                         SUN4I_TCON_GINT0_TCON0_TRI_FINISH_INT)))
 727                 return IRQ_NONE;
 728
 729         drm_crtc_handle_vblank(&scrtc->crtc);
 730         sun4i_tcon_finish_page_flip(drm, scrtc);
 731
 732         /* Acknowledge the interrupt */
 733         regmap_update_bits(tcon->regs, SUN4I_TCON_GINT0_REG,
 734                            SUN4I_TCON_GINT0_VBLANK_INT(0) |
 735                            SUN4I_TCON_GINT0_VBLANK_INT(1) |
 736                            SUN4I_TCON_GINT0_TCON0_TRI_FINISH_INT,
 737                            0);
 738
 739         if (engine->ops->vblank_quirk)
 740                 engine->ops->vblank_quirk(engine);
 741
 742         return IRQ_HANDLED;
 743 }
 744
 745 static int sun4i_tcon_init_clocks(struct device *dev,
 746                                   struct sun4i_tcon *tcon)
 747 {
 748         tcon->clk = devm_clk_get(dev, "ahb");
 749         if (IS_ERR(tcon->clk)) {
 750                 dev_err(dev, "Couldn't get the TCON bus clock\n");
 751                 return PTR_ERR(tcon->clk);
 752         }
 753         clk_prepare_enable(tcon->clk);
 754
 755         if (tcon->quirks->has_channel_0) {
 756                 tcon->sclk0 = devm_clk_get(dev, "tcon-ch0");
 757                 if (IS_ERR(tcon->sclk0)) {
 758                         dev_err(dev, "Couldn't get the TCON channel 0 clock\n");
 759                         return PTR_ERR(tcon->sclk0);
 760                 }
 761         }
 762
 763         if (tcon->quirks->has_channel_1) {
 764                 tcon->sclk1 = devm_clk_get(dev, "tcon-ch1");
 765                 if (IS_ERR(tcon->sclk1)) {
 766                         dev_err(dev, "Couldn't get the TCON channel 1 clock\n");
 767                         return PTR_ERR(tcon->sclk1);
 768                 }
 769         }
 770
 771         return 0;
 772 }
 773
 774 static void sun4i_tcon_free_clocks(struct sun4i_tcon *tcon)
 775 {
 776         clk_disable_unprepare(tcon->clk);
 777 }
 778
 779 static int sun4i_tcon_init_irq(struct device *dev,
 780                                struct sun4i_tcon *tcon)
 781 {
 782         struct platform_device *pdev = to_platform_device(dev);
 783         int irq, ret;
 784
 785         irq = platform_get_irq(pdev, 0);
 786         if (irq < 0) {
 787                 dev_err(dev, "Couldn't retrieve the TCON interrupt\n");
 788                 return irq;
 789         }
 790
 791         ret = devm_request_irq(dev, irq, sun4i_tcon_handler, 0,
 792                                dev_name(dev), tcon);
 793         if (ret) {
 794                 dev_err(dev, "Couldn't request the IRQ\n");
 795                 return ret;
 796         }
 797
 798         return 0;
 799 }
 800
 801 static struct regmap_config sun4i_tcon_regmap_config = {
 802         .reg_bits       = 32,
 803         .val_bits       = 32,
 804         .reg_stride     = 4,
 805         .max_register   = 0x800,
 806 };
 807
 808 static int sun4i_tcon_init_regmap(struct device *dev,
 809                                   struct sun4i_tcon *tcon)
 810 {
 811         struct platform_device *pdev = to_platform_device(dev);
 812         struct resource *res;
 813         void __iomem *regs;
 814
 815         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 816         regs = devm_ioremap_resource(dev, res);
 817         if (IS_ERR(regs))
 818                 return PTR_ERR(regs);
 819
 820         tcon->regs = devm_regmap_init_mmio(dev, regs,
 821                                            &sun4i_tcon_regmap_config);
 822         if (IS_ERR(tcon->regs)) {
 823                 dev_err(dev, "Couldn't create the TCON regmap\n");
 824                 return PTR_ERR(tcon->regs);
 825         }
 826
 827         /* Make sure the TCON is disabled and all IRQs are off */
 828         regmap_write(tcon->regs, SUN4I_TCON_GCTL_REG, 0);
 829         regmap_write(tcon->regs, SUN4I_TCON_GINT0_REG, 0);
 830         regmap_write(tcon->regs, SUN4I_TCON_GINT1_REG, 0);
 831
 832         /* Disable IO lines and set them to tristate */
 833         regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, ~0);
 834         regmap_write(tcon->regs, SUN4I_TCON1_IO_TRI_REG, ~0);
 835
 836         return 0;
 837 }
 838
 839 /*
 840  * On SoCs with the old display pipeline design (Display Engine 1.0),
 841  * the TCON is always tied to just one backend. Hence we can traverse
 842  * the of_graph upwards to find the backend our tcon is connected to,
 843  * and take its ID as our own.
 844  *
 845  * We can either identify backends from their compatible strings, which
 846  * means maintaining a large list of them. Or, since the backend is
 847  * registered and binded before the TCON, we can just go through the
 848  * list of registered backends and compare the device node.
 849  *
 850  * As the structures now store engines instead of backends, here this
 851  * function in fact searches the corresponding engine, and the ID is
 852  * requested via the get_id function of the engine.
 853  */
 854 static struct sunxi_engine *
 855 sun4i_tcon_find_engine_traverse(struct sun4i_drv *drv,
 856                                 struct device_node *node,
 857                                 u32 port_id)
 858 {
 859         struct device_node *port, *ep, *remote;
 860         struct sunxi_engine *engine = ERR_PTR(-EINVAL);
 861         u32 reg = 0;
 862
 863         port = of_graph_get_port_by_id(node, port_id);
 864         if (!port)
 865                 return ERR_PTR(-EINVAL);
 866
 867         /*
 868          * This only works if there is only one path from the TCON
 869          * to any display engine. Otherwise the probe order of the
 870          * TCONs and display engines is not guaranteed. They may
 871          * either bind to the wrong one, or worse, bind to the same
 872          * one if additional checks are not done.
 873          *
 874          * Bail out if there are multiple input connections.
 875          */
 876         if (of_get_available_child_count(port) != 1)
 877                 goto out_put_port;
 878
 879         /* Get the first connection without specifying an ID */
 880         ep = of_get_next_available_child(port, NULL);
 881         if (!ep)
 882                 goto out_put_port;
 883
 884         remote = of_graph_get_remote_port_parent(ep);
 885         if (!remote)
 886                 goto out_put_ep;
 887
 888         /* does this node match any registered engines? */
 889         list_for_each_entry(engine, &drv->engine_list, list)
 890                 if (remote == engine->node)
 891                         goto out_put_remote;
 892
 893         /*
 894          * According to device tree binding input ports have even id
 895          * number and output ports have odd id. Since component with
 896          * more than one input and one output (TCON TOP) exits, correct
 897          * remote input id has to be calculated by subtracting 1 from
 898          * remote output id. If this for some reason can't be done, 0
 899          * is used as input port id.
 900          */
 901         of_node_put(port);
 902         port = of_graph_get_remote_port(ep);
 903         if (!of_property_read_u32(port, "reg", &reg) && reg > 0)
 904                 reg -= 1;
 905
 906         /* keep looking through upstream ports */
 907         engine = sun4i_tcon_find_engine_traverse(drv, remote, reg);
 908
 909 out_put_remote:
 910         of_node_put(remote);
 911 out_put_ep:
 912         of_node_put(ep);
 913 out_put_port:
 914         of_node_put(port);
 915
 916         return engine;
 917 }
 918
 919 /*
 920  * The device tree binding says that the remote endpoint ID of any
 921  * connection between components, up to and including the TCON, of
 922  * the display pipeline should be equal to the actual ID of the local
 923  * component. Thus we can look at any one of the input connections of
 924  * the TCONs, and use that connection's remote endpoint ID as our own.
 925  *
 926  * Since the user of this function already finds the input port,
 927  * the port is passed in directly without further checks.
 928  */
 929 static int sun4i_tcon_of_get_id_from_port(struct device_node *port)
 930 {
 931         struct device_node *ep;
 932         int ret = -EINVAL;
 933
 934         /* try finding an upstream endpoint */
 935         for_each_available_child_of_node(port, ep) {
 936                 struct device_node *remote;
 937                 u32 reg;
 938
 939                 remote = of_graph_get_remote_endpoint(ep);
 940                 if (!remote)
 941                         continue;
 942
 943                 ret = of_property_read_u32(remote, "reg", &reg);
 944                 if (ret)
 945                         continue;
 946
 947                 ret = reg;
 948         }
 949
 950         return ret;
 951 }
 952
 953 /*
 954  * Once we know the TCON's id, we can look through the list of
 955  * engines to find a matching one. We assume all engines have
 956  * been probed and added to the list.
 957  */
 958 static struct sunxi_engine *sun4i_tcon_get_engine_by_id(struct sun4i_drv *drv,
 959                                                         int id)
 960 {
 961         struct sunxi_engine *engine;
 962
 963         list_for_each_entry(engine, &drv->engine_list, list)
 964                 if (engine->id == id)
 965                         return engine;
 966
 967         return ERR_PTR(-EINVAL);
 968 }
 969
 970 static bool sun4i_tcon_connected_to_tcon_top(struct device_node *node)
 971 {
 972         struct device_node *remote;
 973         bool ret = false;
 974
 975         remote = of_graph_get_remote_node(node, 0, -1);
 976         if (remote) {
 977                 ret = !!(IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP) &&
 978                          of_match_node(sun8i_tcon_top_of_table, remote));
 979                 of_node_put(remote);
 980         }
 981
 982         return ret;
 983 }
 984
 985 static int sun4i_tcon_get_index(struct sun4i_drv *drv)
 986 {
 987         struct list_head *pos;
 988         int size = 0;
 989
 990         /*
 991          * Because TCON is added to the list at the end of the probe
 992          * (after this function is called), index of the current TCON
 993          * will be same as current TCON list size.
 994          */
 995         list_for_each(pos, &drv->tcon_list)
 996                 ++size;
 997
 998         return size;
 999 }
1000
1001 /*
1002  * On SoCs with the old display pipeline design (Display Engine 1.0),
1003  * we assumed the TCON was always tied to just one backend. However
1004  * this proved not to be the case. On the A31, the TCON can select
1005  * either backend as its source. On the A20 (and likely on the A10),
1006  * the backend can choose which TCON to output to.
1007  *
1008  * The device tree binding says that the remote endpoint ID of any
1009  * connection between components, up to and including the TCON, of
1010  * the display pipeline should be equal to the actual ID of the local
1011  * component. Thus we should be able to look at any one of the input
1012  * connections of the TCONs, and use that connection's remote endpoint
1013  * ID as our own.
1014  *
1015  * However  the connections between the backend and TCON were assumed
1016  * to be always singular, and their endpoit IDs were all incorrectly
1017  * set to 0. This means for these old device trees, we cannot just look
1018  * up the remote endpoint ID of a TCON input endpoint. TCON1 would be
1019  * incorrectly identified as TCON0.
1020  *
1021  * This function first checks if the TCON node has 2 input endpoints.
1022  * If so, then the device tree is a corrected version, and it will use
1023  * sun4i_tcon_of_get_id() and sun4i_tcon_get_engine_by_id() from above
1024  * to fetch the ID and engine directly. If not, then it is likely an
1025  * old device trees, where the endpoint IDs were incorrect, but did not
1026  * have endpoint connections between the backend and TCON across
1027  * different display pipelines. It will fall back to the old method of
1028  * traversing the  of_graph to try and find a matching engine by device
1029  * node.
1030  *
1031  * In the case of single display pipeline device trees, either method
1032  * works.
1033  */
1034 static struct sunxi_engine *sun4i_tcon_find_engine(struct sun4i_drv *drv,
1035                                                    struct device_node *node)
1036 {
1037         struct device_node *port;
1038         struct sunxi_engine *engine;
1039
1040         port = of_graph_get_port_by_id(node, 0);
1041         if (!port)
1042                 return ERR_PTR(-EINVAL);
1043
1044         /*
1045          * Is this a corrected device tree with cross pipeline
1046          * connections between the backend and TCON?
1047          */
1048         if (of_get_child_count(port) > 1) {
1049                 int id;
1050
1051                 /*
1052                  * When pipeline has the same number of TCONs and engines which
1053                  * are represented by frontends/backends (DE1) or mixers (DE2),
1054                  * we match them by their respective IDs. However, if pipeline
1055                  * contains TCON TOP, chances are that there are either more
1056                  * TCONs than engines (R40) or TCONs with non-consecutive ids.
1057                  * (H6). In that case it's easier just use TCON index in list
1058                  * as an id. That means that on R40, any 2 TCONs can be enabled
1059                  * in DT out of 4 (there are 2 mixers). Due to the design of
1060                  * TCON TOP, remaining 2 TCONs can't be connected to anything
1061                  * anyway.
1062                  */
1063                 if (sun4i_tcon_connected_to_tcon_top(node))
1064                         id = sun4i_tcon_get_index(drv);
1065                 else
1066                         id = sun4i_tcon_of_get_id_from_port(port);
1067
1068                 /* Get our engine by matching our ID */
1069                 engine = sun4i_tcon_get_engine_by_id(drv, id);
1070
1071                 of_node_put(port);
1072                 return engine;
1073         }
1074
1075         /* Fallback to old method by traversing input endpoints */
1076         of_node_put(port);
1077         return sun4i_tcon_find_engine_traverse(drv, node, 0);
1078 }
1079
1080 static int sun4i_tcon_bind(struct device *dev, struct device *master,
1081                            void *data)
1082 {
1083         struct drm_device *drm = data;
1084         struct sun4i_drv *drv = drm->dev_private;
1085         struct sunxi_engine *engine;
1086         struct device_node *remote;
1087         struct sun4i_tcon *tcon;
1088         struct reset_control *edp_rstc;
1089         bool has_lvds_rst, has_lvds_alt, can_lvds;
1090         int ret;
1091
1092         engine = sun4i_tcon_find_engine(drv, dev->of_node);
1093         if (IS_ERR(engine)) {
1094                 dev_err(dev, "Couldn't find matching engine\n");
1095                 return -EPROBE_DEFER;
1096         }
1097
1098         tcon = devm_kzalloc(dev, sizeof(*tcon), GFP_KERNEL);
1099         if (!tcon)
1100                 return -ENOMEM;
1101         dev_set_drvdata(dev, tcon);
1102         tcon->drm = drm;
1103         tcon->dev = dev;
1104         tcon->id = engine->id;
1105         tcon->quirks = of_device_get_match_data(dev);
1106
1107         tcon->lcd_rst = devm_reset_control_get(dev, "lcd");
1108         if (IS_ERR(tcon->lcd_rst)) {
1109                 dev_err(dev, "Couldn't get our reset line\n");
1110                 return PTR_ERR(tcon->lcd_rst);
1111         }
1112
1113         if (tcon->quirks->needs_edp_reset) {
1114                 edp_rstc = devm_reset_control_get_shared(dev, "edp");
1115                 if (IS_ERR(edp_rstc)) {
1116                         dev_err(dev, "Couldn't get edp reset line\n");
1117                         return PTR_ERR(edp_rstc);
1118                 }
1119
1120                 ret = reset_control_deassert(edp_rstc);
1121                 if (ret) {
1122                         dev_err(dev, "Couldn't deassert edp reset line\n");
1123                         return ret;
1124                 }
1125         }
1126
1127         /* Make sure our TCON is reset */
1128         ret = reset_control_reset(tcon->lcd_rst);
1129         if (ret) {
1130                 dev_err(dev, "Couldn't deassert our reset line\n");
1131                 return ret;
1132         }
1133
1134         if (tcon->quirks->supports_lvds) {
1135                 /*
1136                  * This can only be made optional since we've had DT
1137                  * nodes without the LVDS reset properties.
1138                  *
1139                  * If the property is missing, just disable LVDS, and
1140                  * print a warning.
1141                  */
1142                 tcon->lvds_rst = devm_reset_control_get_optional(dev, "lvds");
1143                 if (IS_ERR(tcon->lvds_rst)) {
1144                         dev_err(dev, "Couldn't get our reset line\n");
1145                         return PTR_ERR(tcon->lvds_rst);
1146                 } else if (tcon->lvds_rst) {
1147                         has_lvds_rst = true;
1148                         reset_control_reset(tcon->lvds_rst);
1149                 } else {
1150                         has_lvds_rst = false;
1151                 }
1152
1153                 /*
1154                  * This can only be made optional since we've had DT
1155                  * nodes without the LVDS reset properties.
1156                  *
1157                  * If the property is missing, just disable LVDS, and
1158                  * print a warning.
1159                  */
1160                 if (tcon->quirks->has_lvds_alt) {
1161                         tcon->lvds_pll = devm_clk_get(dev, "lvds-alt");
1162                         if (IS_ERR(tcon->lvds_pll)) {
1163                                 if (PTR_ERR(tcon->lvds_pll) == -ENOENT) {
1164                                         has_lvds_alt = false;
1165                                 } else {
1166                                         dev_err(dev, "Couldn't get the LVDS PLL\n");
1167                                         return PTR_ERR(tcon->lvds_pll);
1168                                 }
1169                         } else {
1170                                 has_lvds_alt = true;
1171                         }
1172                 }
1173
1174                 if (!has_lvds_rst ||
1175                     (tcon->quirks->has_lvds_alt && !has_lvds_alt)) {
1176                         dev_warn(dev, "Missing LVDS properties, Please upgrade your DT\n");
1177                         dev_warn(dev, "LVDS output disabled\n");
1178                         can_lvds = false;
1179                 } else {
1180                         can_lvds = true;
1181                 }
1182         } else {
1183                 can_lvds = false;
1184         }
1185
1186         ret = sun4i_tcon_init_clocks(dev, tcon);
1187         if (ret) {
1188                 dev_err(dev, "Couldn't init our TCON clocks\n");
1189                 goto err_assert_reset;
1190         }
1191
1192         ret = sun4i_tcon_init_regmap(dev, tcon);
1193         if (ret) {
1194                 dev_err(dev, "Couldn't init our TCON regmap\n");
1195                 goto err_free_clocks;
1196         }
1197
1198         if (tcon->quirks->has_channel_0) {
1199                 ret = sun4i_dclk_create(dev, tcon);
1200                 if (ret) {
1201                         dev_err(dev, "Couldn't create our TCON dot clock\n");
1202                         goto err_free_clocks;
1203                 }
1204         }
1205
1206         ret = sun4i_tcon_init_irq(dev, tcon);
1207         if (ret) {
1208                 dev_err(dev, "Couldn't init our TCON interrupts\n");
1209                 goto err_free_dotclock;
1210         }
1211
1212         tcon->crtc = sun4i_crtc_init(drm, engine, tcon);
1213         if (IS_ERR(tcon->crtc)) {
1214                 dev_err(dev, "Couldn't create our CRTC\n");
1215                 ret = PTR_ERR(tcon->crtc);
1216                 goto err_free_dotclock;
1217         }
1218
1219         if (tcon->quirks->has_channel_0) {
1220                 /*
1221                  * If we have an LVDS panel connected to the TCON, we should
1222                  * just probe the LVDS connector. Otherwise, just probe RGB as
1223                  * we used to.
1224                  */
1225                 remote = of_graph_get_remote_node(dev->of_node, 1, 0);
1226                 if (of_device_is_compatible(remote, "panel-lvds"))
1227                         if (can_lvds)
1228                                 ret = sun4i_lvds_init(drm, tcon);
1229                         else
1230                                 ret = -EINVAL;
1231                 else
1232                         ret = sun4i_rgb_init(drm, tcon);
1233                 of_node_put(remote);
1234
1235                 if (ret < 0)
1236                         goto err_free_dotclock;
1237         }
1238
1239         if (tcon->quirks->needs_de_be_mux) {
1240                 /*
1241                  * We assume there is no dynamic muxing of backends
1242                  * and TCONs, so we select the backend with same ID.
1243                  *
1244                  * While dynamic selection might be interesting, since
1245                  * the CRTC is tied to the TCON, while the layers are
1246                  * tied to the backends, this means, we will need to
1247                  * switch between groups of layers. There might not be
1248                  * a way to represent this constraint in DRM.
1249                  */
1250                 regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
1251                                    SUN4I_TCON0_CTL_SRC_SEL_MASK,
1252                                    tcon->id);
1253                 regmap_update_bits(tcon->regs, SUN4I_TCON1_CTL_REG,
1254                                    SUN4I_TCON1_CTL_SRC_SEL_MASK,
1255                                    tcon->id);
1256         }
1257
1258         list_add_tail(&tcon->list, &drv->tcon_list);
1259
1260         return 0;
1261
1262 err_free_dotclock:
1263         if (tcon->quirks->has_channel_0)
1264                 sun4i_dclk_free(tcon);
1265 err_free_clocks:
1266         sun4i_tcon_free_clocks(tcon);
1267 err_assert_reset:
1268         reset_control_assert(tcon->lcd_rst);
1269         return ret;
1270 }
1271
1272 static void sun4i_tcon_unbind(struct device *dev, struct device *master,
1273                               void *data)
1274 {
1275         struct sun4i_tcon *tcon = dev_get_drvdata(dev);
1276
1277         list_del(&tcon->list);
1278         if (tcon->quirks->has_channel_0)
1279                 sun4i_dclk_free(tcon);
1280         sun4i_tcon_free_clocks(tcon);
1281 }
1282
1283 static const struct component_ops sun4i_tcon_ops = {
1284         .bind   = sun4i_tcon_bind,
1285         .unbind = sun4i_tcon_unbind,
1286 };
1287
1288 static int sun4i_tcon_probe(struct platform_device *pdev)
1289 {
1290         struct device_node *node = pdev->dev.of_node;
1291         const struct sun4i_tcon_quirks *quirks;
1292         struct drm_bridge *bridge;
1293         struct drm_panel *panel;
1294         int ret;
1295
1296         quirks = of_device_get_match_data(&pdev->dev);
1297
1298         /* panels and bridges are present only on TCONs with channel 0 */
1299         if (quirks->has_channel_0) {
1300                 ret = drm_of_find_panel_or_bridge(node, 1, 0, &panel, &bridge);
1301                 if (ret == -EPROBE_DEFER)
1302                         return ret;
1303         }
1304
1305         return component_add(&pdev->dev, &sun4i_tcon_ops);
1306 }
1307
1308 static int sun4i_tcon_remove(struct platform_device *pdev)
1309 {
1310         component_del(&pdev->dev, &sun4i_tcon_ops);
1311
1312         return 0;
1313 }
1314
1315 /* platform specific TCON muxing callbacks */
1316 static int sun4i_a10_tcon_set_mux(struct sun4i_tcon *tcon,
1317                                   const struct drm_encoder *encoder)
1318 {
1319         struct sun4i_tcon *tcon0 = sun4i_get_tcon0(encoder->dev);
1320         u32 shift;
1321
1322         if (!tcon0)
1323                 return -EINVAL;
1324
1325         switch (encoder->encoder_type) {
1326         case DRM_MODE_ENCODER_TMDS:
1327                 /* HDMI */
1328                 shift = 8;
1329                 break;
1330         default:
1331                 return -EINVAL;
1332         }
1333
1334         regmap_update_bits(tcon0->regs, SUN4I_TCON_MUX_CTRL_REG,
1335                            0x3 << shift, tcon->id << shift);
1336
1337         return 0;
1338 }
1339
1340 static int sun5i_a13_tcon_set_mux(struct sun4i_tcon *tcon,
1341                                   const struct drm_encoder *encoder)
1342 {
1343         u32 val;
1344
1345         if (encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1346                 val = 1;
1347         else
1348                 val = 0;
1349
1350         /*
1351          * FIXME: Undocumented bits
1352          */
1353         return regmap_write(tcon->regs, SUN4I_TCON_MUX_CTRL_REG, val);
1354 }
1355
1356 static int sun6i_tcon_set_mux(struct sun4i_tcon *tcon,
1357                               const struct drm_encoder *encoder)
1358 {
1359         struct sun4i_tcon *tcon0 = sun4i_get_tcon0(encoder->dev);
1360         u32 shift;
1361
1362         if (!tcon0)
1363                 return -EINVAL;
1364
1365         switch (encoder->encoder_type) {
1366         case DRM_MODE_ENCODER_TMDS:
1367                 /* HDMI */
1368                 shift = 8;
1369                 break;
1370         default:
1371                 /* TODO A31 has MIPI DSI but A31s does not */
1372                 return -EINVAL;
1373         }
1374
1375         regmap_update_bits(tcon0->regs, SUN4I_TCON_MUX_CTRL_REG,
1376                            0x3 << shift, tcon->id << shift);
1377
1378         return 0;
1379 }
1380
1381 static int sun8i_r40_tcon_tv_set_mux(struct sun4i_tcon *tcon,
1382                                      const struct drm_encoder *encoder)
1383 {
1384         struct device_node *port, *remote;
1385         struct platform_device *pdev;
1386         int id, ret;
1387
1388         /* find TCON TOP platform device and TCON id */
1389
1390         port = of_graph_get_port_by_id(tcon->dev->of_node, 0);
1391         if (!port)
1392                 return -EINVAL;
1393
1394         id = sun4i_tcon_of_get_id_from_port(port);
1395         of_node_put(port);
1396
1397         remote = of_graph_get_remote_node(tcon->dev->of_node, 0, -1);
1398         if (!remote)
1399                 return -EINVAL;
1400
1401         pdev = of_find_device_by_node(remote);
1402         of_node_put(remote);
1403         if (!pdev)
1404                 return -EINVAL;
1405
1406         if (IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP) &&
1407             encoder->encoder_type == DRM_MODE_ENCODER_TMDS) {
1408                 ret = sun8i_tcon_top_set_hdmi_src(&pdev->dev, id);
1409                 if (ret)
1410                         return ret;
1411         }
1412
1413         if (IS_ENABLED(CONFIG_DRM_SUN8I_TCON_TOP)) {
1414                 ret = sun8i_tcon_top_de_config(&pdev->dev, tcon->id, id);
1415                 if (ret)
1416                         return ret;
1417         }
1418
1419         return 0;
1420 }
1421
1422 static const struct sun4i_tcon_quirks sun4i_a10_quirks = {
1423         .has_channel_0          = true,
1424         .has_channel_1          = true,
1425         .set_mux                = sun4i_a10_tcon_set_mux,
1426 };
1427
1428 static const struct sun4i_tcon_quirks sun5i_a13_quirks = {
1429         .has_channel_0          = true,
1430         .has_channel_1          = true,
1431         .set_mux                = sun5i_a13_tcon_set_mux,
1432 };
1433
1434 static const struct sun4i_tcon_quirks sun6i_a31_quirks = {
1435         .has_channel_0          = true,
1436         .has_channel_1          = true,
1437         .has_lvds_alt           = true,
1438         .needs_de_be_mux        = true,
1439         .set_mux                = sun6i_tcon_set_mux,
1440 };
1441
1442 static const struct sun4i_tcon_quirks sun6i_a31s_quirks = {
1443         .has_channel_0          = true,
1444         .has_channel_1          = true,
1445         .needs_de_be_mux        = true,
1446 };
1447
1448 static const struct sun4i_tcon_quirks sun7i_a20_quirks = {
1449         .has_channel_0          = true,
1450         .has_channel_1          = true,
1451         /* Same display pipeline structure as A10 */
1452         .set_mux                = sun4i_a10_tcon_set_mux,
1453 };
1454
1455 static const struct sun4i_tcon_quirks sun8i_a33_quirks = {
1456         .has_channel_0          = true,
1457         .has_lvds_alt           = true,
1458 };
1459
1460 static const struct sun4i_tcon_quirks sun8i_a83t_lcd_quirks = {
1461         .supports_lvds          = true,
1462         .has_channel_0          = true,
1463 };
1464
1465 static const struct sun4i_tcon_quirks sun8i_a83t_tv_quirks = {
1466         .has_channel_1          = true,
1467 };
1468
1469 static const struct sun4i_tcon_quirks sun8i_r40_tv_quirks = {
1470         .has_channel_1          = true,
1471         .set_mux                = sun8i_r40_tcon_tv_set_mux,
1472 };
1473
1474 static const struct sun4i_tcon_quirks sun8i_v3s_quirks = {
1475         .has_channel_0          = true,
1476 };
1477
1478 static const struct sun4i_tcon_quirks sun9i_a80_tcon_lcd_quirks = {
1479         .has_channel_0  = true,
1480         .needs_edp_reset = true,
1481 };
1482
1483 static const struct sun4i_tcon_quirks sun9i_a80_tcon_tv_quirks = {
1484         .has_channel_1  = true,
1485         .needs_edp_reset = true,
1486 };
1487
1488 /* sun4i_drv uses this list to check if a device node is a TCON */
1489 const struct of_device_id sun4i_tcon_of_table[] = {
1490         { .compatible = "allwinner,sun4i-a10-tcon", .data = &sun4i_a10_quirks },
1491         { .compatible = "allwinner,sun5i-a13-tcon", .data = &sun5i_a13_quirks },
1492         { .compatible = "allwinner,sun6i-a31-tcon", .data = &sun6i_a31_quirks },
1493         { .compatible = "allwinner,sun6i-a31s-tcon", .data = &sun6i_a31s_quirks },
1494         { .compatible = "allwinner,sun7i-a20-tcon", .data = &sun7i_a20_quirks },
1495         { .compatible = "allwinner,sun8i-a33-tcon", .data = &sun8i_a33_quirks },
1496         { .compatible = "allwinner,sun8i-a83t-tcon-lcd", .data = &sun8i_a83t_lcd_quirks },
1497         { .compatible = "allwinner,sun8i-a83t-tcon-tv", .data = &sun8i_a83t_tv_quirks },
1498         { .compatible = "allwinner,sun8i-r40-tcon-tv", .data = &sun8i_r40_tv_quirks },
1499         { .compatible = "allwinner,sun8i-v3s-tcon", .data = &sun8i_v3s_quirks },
1500         { .compatible = "allwinner,sun9i-a80-tcon-lcd", .data = &sun9i_a80_tcon_lcd_quirks },
1501         { .compatible = "allwinner,sun9i-a80-tcon-tv", .data = &sun9i_a80_tcon_tv_quirks },
1502         { }
1503 };
1504 MODULE_DEVICE_TABLE(of, sun4i_tcon_of_table);
1505 EXPORT_SYMBOL(sun4i_tcon_of_table);
1506
1507 static struct platform_driver sun4i_tcon_platform_driver = {
1508         .probe          = sun4i_tcon_probe,
1509         .remove         = sun4i_tcon_remove,
1510         .driver         = {
1511                 .name           = "sun4i-tcon",
1512                 .of_match_table = sun4i_tcon_of_table,
1513         },
1514 };
1515 module_platform_driver(sun4i_tcon_platform_driver);
1516
1517 MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com>");
1518 MODULE_DESCRIPTION("Allwinner A10 Timing Controller Driver");
1519 MODULE_LICENSE("GPL");