2 * Copyright 2007-8 Advanced Micro Devices, Inc.
3 * Copyright 2008 Red Hat Inc.
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
12 * The above copyright notice and this permission notice shall be included in
13 * all copies or substantial portions of the Software.
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21 * OTHER DEALINGS IN THE SOFTWARE.
23 * Authors: Dave Airlie
27 #include <drm/drm_edid.h>
28 #include <drm/drm_crtc_helper.h>
29 #include <drm/drm_fb_helper.h>
30 #include <drm/amdgpu_drm.h>
33 #include "atombios_encoders.h"
34 #include "atombios_dp.h"
35 #include "amdgpu_connectors.h"
36 #include "amdgpu_i2c.h"
38 #include <linux/pm_runtime.h>
40 void amdgpu_connector_hotplug(struct drm_connector *connector)
42 struct drm_device *dev = connector->dev;
43 struct amdgpu_device *adev = dev->dev_private;
44 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
46 /* bail if the connector does not have hpd pin, e.g.,
49 if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE)
52 amdgpu_display_hpd_set_polarity(adev, amdgpu_connector->hpd.hpd);
54 /* if the connector is already off, don't turn it back on */
55 if (connector->dpms != DRM_MODE_DPMS_ON)
58 /* just deal with DP (not eDP) here. */
59 if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
60 struct amdgpu_connector_atom_dig *dig_connector =
61 amdgpu_connector->con_priv;
63 /* if existing sink type was not DP no need to retrain */
64 if (dig_connector->dp_sink_type != CONNECTOR_OBJECT_ID_DISPLAYPORT)
67 /* first get sink type as it may be reset after (un)plug */
68 dig_connector->dp_sink_type = amdgpu_atombios_dp_get_sinktype(amdgpu_connector);
69 /* don't do anything if sink is not display port, i.e.,
70 * passive dp->(dvi|hdmi) adaptor
72 if (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
73 int saved_dpms = connector->dpms;
74 /* Only turn off the display if it's physically disconnected */
75 if (!amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
76 drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
77 } else if (amdgpu_atombios_dp_needs_link_train(amdgpu_connector)) {
78 /* Don't try to start link training before we
80 if (amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
83 /* set it to OFF so that drm_helper_connector_dpms()
84 * won't return immediately since the current state
85 * is ON at this point.
87 connector->dpms = DRM_MODE_DPMS_OFF;
88 drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
90 connector->dpms = saved_dpms;
95 static void amdgpu_connector_property_change_mode(struct drm_encoder *encoder)
97 struct drm_crtc *crtc = encoder->crtc;
99 if (crtc && crtc->enabled) {
100 drm_crtc_helper_set_mode(crtc, &crtc->mode,
101 crtc->x, crtc->y, crtc->primary->fb);
105 int amdgpu_connector_get_monitor_bpc(struct drm_connector *connector)
107 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
108 struct amdgpu_connector_atom_dig *dig_connector;
110 unsigned mode_clock, max_tmds_clock;
112 switch (connector->connector_type) {
113 case DRM_MODE_CONNECTOR_DVII:
114 case DRM_MODE_CONNECTOR_HDMIB:
115 if (amdgpu_connector->use_digital) {
116 if (drm_detect_hdmi_monitor(amdgpu_connector_edid(connector))) {
117 if (connector->display_info.bpc)
118 bpc = connector->display_info.bpc;
122 case DRM_MODE_CONNECTOR_DVID:
123 case DRM_MODE_CONNECTOR_HDMIA:
124 if (drm_detect_hdmi_monitor(amdgpu_connector_edid(connector))) {
125 if (connector->display_info.bpc)
126 bpc = connector->display_info.bpc;
129 case DRM_MODE_CONNECTOR_DisplayPort:
130 dig_connector = amdgpu_connector->con_priv;
131 if ((dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
132 (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) ||
133 drm_detect_hdmi_monitor(amdgpu_connector_edid(connector))) {
134 if (connector->display_info.bpc)
135 bpc = connector->display_info.bpc;
138 case DRM_MODE_CONNECTOR_eDP:
139 case DRM_MODE_CONNECTOR_LVDS:
140 if (connector->display_info.bpc)
141 bpc = connector->display_info.bpc;
143 const struct drm_connector_helper_funcs *connector_funcs =
144 connector->helper_private;
145 struct drm_encoder *encoder = connector_funcs->best_encoder(connector);
146 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
147 struct amdgpu_encoder_atom_dig *dig = amdgpu_encoder->enc_priv;
149 if (dig->lcd_misc & ATOM_PANEL_MISC_V13_6BIT_PER_COLOR)
151 else if (dig->lcd_misc & ATOM_PANEL_MISC_V13_8BIT_PER_COLOR)
157 if (drm_detect_hdmi_monitor(amdgpu_connector_edid(connector))) {
159 * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
160 * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
161 * 12 bpc is always supported on hdmi deep color sinks, as this is
162 * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
165 DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
166 connector->name, bpc);
170 /* Any defined maximum tmds clock limit we must not exceed? */
171 if (connector->display_info.max_tmds_clock > 0) {
172 /* mode_clock is clock in kHz for mode to be modeset on this connector */
173 mode_clock = amdgpu_connector->pixelclock_for_modeset;
175 /* Maximum allowable input clock in kHz */
176 max_tmds_clock = connector->display_info.max_tmds_clock;
178 DRM_DEBUG("%s: hdmi mode dotclock %d kHz, max tmds input clock %d kHz.\n",
179 connector->name, mode_clock, max_tmds_clock);
181 /* Check if bpc is within clock limit. Try to degrade gracefully otherwise */
182 if ((bpc == 12) && (mode_clock * 3/2 > max_tmds_clock)) {
183 if ((connector->display_info.edid_hdmi_dc_modes & DRM_EDID_HDMI_DC_30) &&
184 (mode_clock * 5/4 <= max_tmds_clock))
189 DRM_DEBUG("%s: HDMI deep color 12 bpc exceeds max tmds clock. Using %d bpc.\n",
190 connector->name, bpc);
193 if ((bpc == 10) && (mode_clock * 5/4 > max_tmds_clock)) {
195 DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
196 connector->name, bpc);
198 } else if (bpc > 8) {
199 /* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
200 DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
206 if ((amdgpu_deep_color == 0) && (bpc > 8)) {
207 DRM_DEBUG("%s: Deep color disabled. Set amdgpu module param deep_color=1 to enable.\n",
212 DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
213 connector->name, connector->display_info.bpc, bpc);
219 amdgpu_connector_update_scratch_regs(struct drm_connector *connector,
220 enum drm_connector_status status)
222 struct drm_encoder *best_encoder = NULL;
223 struct drm_encoder *encoder = NULL;
224 const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
228 best_encoder = connector_funcs->best_encoder(connector);
230 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
231 if (connector->encoder_ids[i] == 0)
234 encoder = drm_encoder_find(connector->dev, NULL,
235 connector->encoder_ids[i]);
239 if ((encoder == best_encoder) && (status == connector_status_connected))
244 amdgpu_atombios_encoder_set_bios_scratch_regs(connector, encoder, connected);
249 static struct drm_encoder *
250 amdgpu_connector_find_encoder(struct drm_connector *connector,
253 struct drm_encoder *encoder;
256 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
257 if (connector->encoder_ids[i] == 0)
259 encoder = drm_encoder_find(connector->dev, NULL,
260 connector->encoder_ids[i]);
264 if (encoder->encoder_type == encoder_type)
270 struct edid *amdgpu_connector_edid(struct drm_connector *connector)
272 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
273 struct drm_property_blob *edid_blob = connector->edid_blob_ptr;
275 if (amdgpu_connector->edid) {
276 return amdgpu_connector->edid;
277 } else if (edid_blob) {
278 struct edid *edid = kmemdup(edid_blob->data, edid_blob->length, GFP_KERNEL);
280 amdgpu_connector->edid = edid;
282 return amdgpu_connector->edid;
286 amdgpu_connector_get_hardcoded_edid(struct amdgpu_device *adev)
290 if (adev->mode_info.bios_hardcoded_edid) {
291 edid = kmalloc(adev->mode_info.bios_hardcoded_edid_size, GFP_KERNEL);
293 memcpy((unsigned char *)edid,
294 (unsigned char *)adev->mode_info.bios_hardcoded_edid,
295 adev->mode_info.bios_hardcoded_edid_size);
302 static void amdgpu_connector_get_edid(struct drm_connector *connector)
304 struct drm_device *dev = connector->dev;
305 struct amdgpu_device *adev = dev->dev_private;
306 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
308 if (amdgpu_connector->edid)
311 /* on hw with routers, select right port */
312 if (amdgpu_connector->router.ddc_valid)
313 amdgpu_i2c_router_select_ddc_port(amdgpu_connector);
315 if ((amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
316 ENCODER_OBJECT_ID_NONE) &&
317 amdgpu_connector->ddc_bus->has_aux) {
318 amdgpu_connector->edid = drm_get_edid(connector,
319 &amdgpu_connector->ddc_bus->aux.ddc);
320 } else if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
321 (connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
322 struct amdgpu_connector_atom_dig *dig = amdgpu_connector->con_priv;
324 if ((dig->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT ||
325 dig->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) &&
326 amdgpu_connector->ddc_bus->has_aux)
327 amdgpu_connector->edid = drm_get_edid(connector,
328 &amdgpu_connector->ddc_bus->aux.ddc);
329 else if (amdgpu_connector->ddc_bus)
330 amdgpu_connector->edid = drm_get_edid(connector,
331 &amdgpu_connector->ddc_bus->adapter);
332 } else if (amdgpu_connector->ddc_bus) {
333 amdgpu_connector->edid = drm_get_edid(connector,
334 &amdgpu_connector->ddc_bus->adapter);
337 if (!amdgpu_connector->edid) {
338 /* some laptops provide a hardcoded edid in rom for LCDs */
339 if (((connector->connector_type == DRM_MODE_CONNECTOR_LVDS) ||
340 (connector->connector_type == DRM_MODE_CONNECTOR_eDP)))
341 amdgpu_connector->edid = amdgpu_connector_get_hardcoded_edid(adev);
345 static void amdgpu_connector_free_edid(struct drm_connector *connector)
347 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
349 kfree(amdgpu_connector->edid);
350 amdgpu_connector->edid = NULL;
353 static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector)
355 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
358 if (amdgpu_connector->edid) {
359 drm_mode_connector_update_edid_property(connector, amdgpu_connector->edid);
360 ret = drm_add_edid_modes(connector, amdgpu_connector->edid);
361 drm_edid_to_eld(connector, amdgpu_connector->edid);
364 drm_mode_connector_update_edid_property(connector, NULL);
368 static struct drm_encoder *
369 amdgpu_connector_best_single_encoder(struct drm_connector *connector)
371 int enc_id = connector->encoder_ids[0];
373 /* pick the encoder ids */
375 return drm_encoder_find(connector->dev, NULL, enc_id);
379 static void amdgpu_get_native_mode(struct drm_connector *connector)
381 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
382 struct amdgpu_encoder *amdgpu_encoder;
387 amdgpu_encoder = to_amdgpu_encoder(encoder);
389 if (!list_empty(&connector->probed_modes)) {
390 struct drm_display_mode *preferred_mode =
391 list_first_entry(&connector->probed_modes,
392 struct drm_display_mode, head);
394 amdgpu_encoder->native_mode = *preferred_mode;
396 amdgpu_encoder->native_mode.clock = 0;
400 static struct drm_display_mode *
401 amdgpu_connector_lcd_native_mode(struct drm_encoder *encoder)
403 struct drm_device *dev = encoder->dev;
404 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
405 struct drm_display_mode *mode = NULL;
406 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
408 if (native_mode->hdisplay != 0 &&
409 native_mode->vdisplay != 0 &&
410 native_mode->clock != 0) {
411 mode = drm_mode_duplicate(dev, native_mode);
412 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
413 drm_mode_set_name(mode);
415 DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
416 } else if (native_mode->hdisplay != 0 &&
417 native_mode->vdisplay != 0) {
418 /* mac laptops without an edid */
419 /* Note that this is not necessarily the exact panel mode,
420 * but an approximation based on the cvt formula. For these
421 * systems we should ideally read the mode info out of the
422 * registers or add a mode table, but this works and is much
425 mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
426 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
427 DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
432 static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder,
433 struct drm_connector *connector)
435 struct drm_device *dev = encoder->dev;
436 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
437 struct drm_display_mode *mode = NULL;
438 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
440 static const struct mode_size {
443 } common_modes[17] = {
463 for (i = 0; i < 17; i++) {
464 if (amdgpu_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
465 if (common_modes[i].w > 1024 ||
466 common_modes[i].h > 768)
469 if (amdgpu_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
470 if (common_modes[i].w > native_mode->hdisplay ||
471 common_modes[i].h > native_mode->vdisplay ||
472 (common_modes[i].w == native_mode->hdisplay &&
473 common_modes[i].h == native_mode->vdisplay))
476 if (common_modes[i].w < 320 || common_modes[i].h < 200)
479 mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
480 drm_mode_probed_add(connector, mode);
484 static int amdgpu_connector_set_property(struct drm_connector *connector,
485 struct drm_property *property,
488 struct drm_device *dev = connector->dev;
489 struct amdgpu_device *adev = dev->dev_private;
490 struct drm_encoder *encoder;
491 struct amdgpu_encoder *amdgpu_encoder;
493 if (property == adev->mode_info.coherent_mode_property) {
494 struct amdgpu_encoder_atom_dig *dig;
495 bool new_coherent_mode;
497 /* need to find digital encoder on connector */
498 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
502 amdgpu_encoder = to_amdgpu_encoder(encoder);
504 if (!amdgpu_encoder->enc_priv)
507 dig = amdgpu_encoder->enc_priv;
508 new_coherent_mode = val ? true : false;
509 if (dig->coherent_mode != new_coherent_mode) {
510 dig->coherent_mode = new_coherent_mode;
511 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
515 if (property == adev->mode_info.audio_property) {
516 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
517 /* need to find digital encoder on connector */
518 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
522 amdgpu_encoder = to_amdgpu_encoder(encoder);
524 if (amdgpu_connector->audio != val) {
525 amdgpu_connector->audio = val;
526 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
530 if (property == adev->mode_info.dither_property) {
531 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
532 /* need to find digital encoder on connector */
533 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
537 amdgpu_encoder = to_amdgpu_encoder(encoder);
539 if (amdgpu_connector->dither != val) {
540 amdgpu_connector->dither = val;
541 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
545 if (property == adev->mode_info.underscan_property) {
546 /* need to find digital encoder on connector */
547 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
551 amdgpu_encoder = to_amdgpu_encoder(encoder);
553 if (amdgpu_encoder->underscan_type != val) {
554 amdgpu_encoder->underscan_type = val;
555 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
559 if (property == adev->mode_info.underscan_hborder_property) {
560 /* need to find digital encoder on connector */
561 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
565 amdgpu_encoder = to_amdgpu_encoder(encoder);
567 if (amdgpu_encoder->underscan_hborder != val) {
568 amdgpu_encoder->underscan_hborder = val;
569 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
573 if (property == adev->mode_info.underscan_vborder_property) {
574 /* need to find digital encoder on connector */
575 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
579 amdgpu_encoder = to_amdgpu_encoder(encoder);
581 if (amdgpu_encoder->underscan_vborder != val) {
582 amdgpu_encoder->underscan_vborder = val;
583 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
587 if (property == adev->mode_info.load_detect_property) {
588 struct amdgpu_connector *amdgpu_connector =
589 to_amdgpu_connector(connector);
592 amdgpu_connector->dac_load_detect = false;
594 amdgpu_connector->dac_load_detect = true;
597 if (property == dev->mode_config.scaling_mode_property) {
598 enum amdgpu_rmx_type rmx_type;
600 if (connector->encoder) {
601 amdgpu_encoder = to_amdgpu_encoder(connector->encoder);
603 const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
604 amdgpu_encoder = to_amdgpu_encoder(connector_funcs->best_encoder(connector));
609 case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
610 case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
611 case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
612 case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
614 if (amdgpu_encoder->rmx_type == rmx_type)
617 if ((rmx_type != DRM_MODE_SCALE_NONE) &&
618 (amdgpu_encoder->native_mode.clock == 0))
621 amdgpu_encoder->rmx_type = rmx_type;
623 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
630 amdgpu_connector_fixup_lcd_native_mode(struct drm_encoder *encoder,
631 struct drm_connector *connector)
633 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
634 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
635 struct drm_display_mode *t, *mode;
637 /* If the EDID preferred mode doesn't match the native mode, use it */
638 list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
639 if (mode->type & DRM_MODE_TYPE_PREFERRED) {
640 if (mode->hdisplay != native_mode->hdisplay ||
641 mode->vdisplay != native_mode->vdisplay)
642 memcpy(native_mode, mode, sizeof(*mode));
646 /* Try to get native mode details from EDID if necessary */
647 if (!native_mode->clock) {
648 list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
649 if (mode->hdisplay == native_mode->hdisplay &&
650 mode->vdisplay == native_mode->vdisplay) {
651 *native_mode = *mode;
652 drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
653 DRM_DEBUG_KMS("Determined LVDS native mode details from EDID\n");
659 if (!native_mode->clock) {
660 DRM_DEBUG_KMS("No LVDS native mode details, disabling RMX\n");
661 amdgpu_encoder->rmx_type = RMX_OFF;
665 static int amdgpu_connector_lvds_get_modes(struct drm_connector *connector)
667 struct drm_encoder *encoder;
669 struct drm_display_mode *mode;
671 amdgpu_connector_get_edid(connector);
672 ret = amdgpu_connector_ddc_get_modes(connector);
674 encoder = amdgpu_connector_best_single_encoder(connector);
676 amdgpu_connector_fixup_lcd_native_mode(encoder, connector);
677 /* add scaled modes */
678 amdgpu_connector_add_common_modes(encoder, connector);
683 encoder = amdgpu_connector_best_single_encoder(connector);
687 /* we have no EDID modes */
688 mode = amdgpu_connector_lcd_native_mode(encoder);
691 drm_mode_probed_add(connector, mode);
692 /* add the width/height from vbios tables if available */
693 connector->display_info.width_mm = mode->width_mm;
694 connector->display_info.height_mm = mode->height_mm;
695 /* add scaled modes */
696 amdgpu_connector_add_common_modes(encoder, connector);
702 static int amdgpu_connector_lvds_mode_valid(struct drm_connector *connector,
703 struct drm_display_mode *mode)
705 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
707 if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
711 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
712 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
714 /* AVIVO hardware supports downscaling modes larger than the panel
715 * to the panel size, but I'm not sure this is desirable.
717 if ((mode->hdisplay > native_mode->hdisplay) ||
718 (mode->vdisplay > native_mode->vdisplay))
721 /* if scaling is disabled, block non-native modes */
722 if (amdgpu_encoder->rmx_type == RMX_OFF) {
723 if ((mode->hdisplay != native_mode->hdisplay) ||
724 (mode->vdisplay != native_mode->vdisplay))
732 static enum drm_connector_status
733 amdgpu_connector_lvds_detect(struct drm_connector *connector, bool force)
735 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
736 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
737 enum drm_connector_status ret = connector_status_disconnected;
740 if (!drm_kms_helper_is_poll_worker()) {
741 r = pm_runtime_get_sync(connector->dev->dev);
743 return connector_status_disconnected;
747 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
748 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
750 /* check if panel is valid */
751 if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
752 ret = connector_status_connected;
756 /* check for edid as well */
757 amdgpu_connector_get_edid(connector);
758 if (amdgpu_connector->edid)
759 ret = connector_status_connected;
760 /* check acpi lid status ??? */
762 amdgpu_connector_update_scratch_regs(connector, ret);
764 if (!drm_kms_helper_is_poll_worker()) {
765 pm_runtime_mark_last_busy(connector->dev->dev);
766 pm_runtime_put_autosuspend(connector->dev->dev);
772 static void amdgpu_connector_unregister(struct drm_connector *connector)
774 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
776 if (amdgpu_connector->ddc_bus && amdgpu_connector->ddc_bus->has_aux) {
777 drm_dp_aux_unregister(&amdgpu_connector->ddc_bus->aux);
778 amdgpu_connector->ddc_bus->has_aux = false;
782 static void amdgpu_connector_destroy(struct drm_connector *connector)
784 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
786 amdgpu_connector_free_edid(connector);
787 kfree(amdgpu_connector->con_priv);
788 drm_connector_unregister(connector);
789 drm_connector_cleanup(connector);
793 static int amdgpu_connector_set_lcd_property(struct drm_connector *connector,
794 struct drm_property *property,
797 struct drm_device *dev = connector->dev;
798 struct amdgpu_encoder *amdgpu_encoder;
799 enum amdgpu_rmx_type rmx_type;
802 if (property != dev->mode_config.scaling_mode_property)
805 if (connector->encoder)
806 amdgpu_encoder = to_amdgpu_encoder(connector->encoder);
808 const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
809 amdgpu_encoder = to_amdgpu_encoder(connector_funcs->best_encoder(connector));
813 case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
814 case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
815 case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
817 case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
819 if (amdgpu_encoder->rmx_type == rmx_type)
822 amdgpu_encoder->rmx_type = rmx_type;
824 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
829 static const struct drm_connector_helper_funcs amdgpu_connector_lvds_helper_funcs = {
830 .get_modes = amdgpu_connector_lvds_get_modes,
831 .mode_valid = amdgpu_connector_lvds_mode_valid,
832 .best_encoder = amdgpu_connector_best_single_encoder,
835 static const struct drm_connector_funcs amdgpu_connector_lvds_funcs = {
836 .dpms = drm_helper_connector_dpms,
837 .detect = amdgpu_connector_lvds_detect,
838 .fill_modes = drm_helper_probe_single_connector_modes,
839 .early_unregister = amdgpu_connector_unregister,
840 .destroy = amdgpu_connector_destroy,
841 .set_property = amdgpu_connector_set_lcd_property,
844 static int amdgpu_connector_vga_get_modes(struct drm_connector *connector)
848 amdgpu_connector_get_edid(connector);
849 ret = amdgpu_connector_ddc_get_modes(connector);
854 static int amdgpu_connector_vga_mode_valid(struct drm_connector *connector,
855 struct drm_display_mode *mode)
857 struct drm_device *dev = connector->dev;
858 struct amdgpu_device *adev = dev->dev_private;
860 /* XXX check mode bandwidth */
862 if ((mode->clock / 10) > adev->clock.max_pixel_clock)
863 return MODE_CLOCK_HIGH;
868 static enum drm_connector_status
869 amdgpu_connector_vga_detect(struct drm_connector *connector, bool force)
871 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
872 struct drm_encoder *encoder;
873 const struct drm_encoder_helper_funcs *encoder_funcs;
875 enum drm_connector_status ret = connector_status_disconnected;
878 if (!drm_kms_helper_is_poll_worker()) {
879 r = pm_runtime_get_sync(connector->dev->dev);
881 return connector_status_disconnected;
884 encoder = amdgpu_connector_best_single_encoder(connector);
886 ret = connector_status_disconnected;
888 if (amdgpu_connector->ddc_bus)
889 dret = amdgpu_ddc_probe(amdgpu_connector, false);
891 amdgpu_connector->detected_by_load = false;
892 amdgpu_connector_free_edid(connector);
893 amdgpu_connector_get_edid(connector);
895 if (!amdgpu_connector->edid) {
896 DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
898 ret = connector_status_connected;
900 amdgpu_connector->use_digital =
901 !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
903 /* some oems have boards with separate digital and analog connectors
904 * with a shared ddc line (often vga + hdmi)
906 if (amdgpu_connector->use_digital && amdgpu_connector->shared_ddc) {
907 amdgpu_connector_free_edid(connector);
908 ret = connector_status_disconnected;
910 ret = connector_status_connected;
915 /* if we aren't forcing don't do destructive polling */
917 /* only return the previous status if we last
918 * detected a monitor via load.
920 if (amdgpu_connector->detected_by_load)
921 ret = connector->status;
925 if (amdgpu_connector->dac_load_detect && encoder) {
926 encoder_funcs = encoder->helper_private;
927 ret = encoder_funcs->detect(encoder, connector);
928 if (ret != connector_status_disconnected)
929 amdgpu_connector->detected_by_load = true;
933 amdgpu_connector_update_scratch_regs(connector, ret);
936 if (!drm_kms_helper_is_poll_worker()) {
937 pm_runtime_mark_last_busy(connector->dev->dev);
938 pm_runtime_put_autosuspend(connector->dev->dev);
944 static const struct drm_connector_helper_funcs amdgpu_connector_vga_helper_funcs = {
945 .get_modes = amdgpu_connector_vga_get_modes,
946 .mode_valid = amdgpu_connector_vga_mode_valid,
947 .best_encoder = amdgpu_connector_best_single_encoder,
950 static const struct drm_connector_funcs amdgpu_connector_vga_funcs = {
951 .dpms = drm_helper_connector_dpms,
952 .detect = amdgpu_connector_vga_detect,
953 .fill_modes = drm_helper_probe_single_connector_modes,
954 .early_unregister = amdgpu_connector_unregister,
955 .destroy = amdgpu_connector_destroy,
956 .set_property = amdgpu_connector_set_property,
960 amdgpu_connector_check_hpd_status_unchanged(struct drm_connector *connector)
962 struct drm_device *dev = connector->dev;
963 struct amdgpu_device *adev = dev->dev_private;
964 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
965 enum drm_connector_status status;
967 if (amdgpu_connector->hpd.hpd != AMDGPU_HPD_NONE) {
968 if (amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd))
969 status = connector_status_connected;
971 status = connector_status_disconnected;
972 if (connector->status == status)
981 * Do a DDC probe, if DDC probe passes, get the full EDID so
982 * we can do analog/digital monitor detection at this point.
983 * If the monitor is an analog monitor or we got no DDC,
984 * we need to find the DAC encoder object for this connector.
985 * If we got no DDC, we do load detection on the DAC encoder object.
986 * If we got analog DDC or load detection passes on the DAC encoder
987 * we have to check if this analog encoder is shared with anyone else (TV)
988 * if its shared we have to set the other connector to disconnected.
990 static enum drm_connector_status
991 amdgpu_connector_dvi_detect(struct drm_connector *connector, bool force)
993 struct drm_device *dev = connector->dev;
994 struct amdgpu_device *adev = dev->dev_private;
995 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
996 struct drm_encoder *encoder = NULL;
997 const struct drm_encoder_helper_funcs *encoder_funcs;
999 enum drm_connector_status ret = connector_status_disconnected;
1000 bool dret = false, broken_edid = false;
1002 if (!drm_kms_helper_is_poll_worker()) {
1003 r = pm_runtime_get_sync(connector->dev->dev);
1005 return connector_status_disconnected;
1008 if (!force && amdgpu_connector_check_hpd_status_unchanged(connector)) {
1009 ret = connector->status;
1013 if (amdgpu_connector->ddc_bus)
1014 dret = amdgpu_ddc_probe(amdgpu_connector, false);
1016 amdgpu_connector->detected_by_load = false;
1017 amdgpu_connector_free_edid(connector);
1018 amdgpu_connector_get_edid(connector);
1020 if (!amdgpu_connector->edid) {
1021 DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
1023 ret = connector_status_connected;
1024 broken_edid = true; /* defer use_digital to later */
1026 amdgpu_connector->use_digital =
1027 !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
1029 /* some oems have boards with separate digital and analog connectors
1030 * with a shared ddc line (often vga + hdmi)
1032 if ((!amdgpu_connector->use_digital) && amdgpu_connector->shared_ddc) {
1033 amdgpu_connector_free_edid(connector);
1034 ret = connector_status_disconnected;
1036 ret = connector_status_connected;
1039 /* This gets complicated. We have boards with VGA + HDMI with a
1040 * shared DDC line and we have boards with DVI-D + HDMI with a shared
1041 * DDC line. The latter is more complex because with DVI<->HDMI adapters
1042 * you don't really know what's connected to which port as both are digital.
1044 if (amdgpu_connector->shared_ddc && (ret == connector_status_connected)) {
1045 struct drm_connector *list_connector;
1046 struct amdgpu_connector *list_amdgpu_connector;
1047 list_for_each_entry(list_connector, &dev->mode_config.connector_list, head) {
1048 if (connector == list_connector)
1050 list_amdgpu_connector = to_amdgpu_connector(list_connector);
1051 if (list_amdgpu_connector->shared_ddc &&
1052 (list_amdgpu_connector->ddc_bus->rec.i2c_id ==
1053 amdgpu_connector->ddc_bus->rec.i2c_id)) {
1054 /* cases where both connectors are digital */
1055 if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
1056 /* hpd is our only option in this case */
1057 if (!amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
1058 amdgpu_connector_free_edid(connector);
1059 ret = connector_status_disconnected;
1068 if ((ret == connector_status_connected) && (amdgpu_connector->use_digital == true))
1071 /* DVI-D and HDMI-A are digital only */
1072 if ((connector->connector_type == DRM_MODE_CONNECTOR_DVID) ||
1073 (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA))
1076 /* if we aren't forcing don't do destructive polling */
1078 /* only return the previous status if we last
1079 * detected a monitor via load.
1081 if (amdgpu_connector->detected_by_load)
1082 ret = connector->status;
1086 /* find analog encoder */
1087 if (amdgpu_connector->dac_load_detect) {
1088 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1089 if (connector->encoder_ids[i] == 0)
1092 encoder = drm_encoder_find(connector->dev, NULL, connector->encoder_ids[i]);
1096 if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
1097 encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
1100 encoder_funcs = encoder->helper_private;
1101 if (encoder_funcs->detect) {
1103 if (ret != connector_status_connected) {
1104 /* deal with analog monitors without DDC */
1105 ret = encoder_funcs->detect(encoder, connector);
1106 if (ret == connector_status_connected) {
1107 amdgpu_connector->use_digital = false;
1109 if (ret != connector_status_disconnected)
1110 amdgpu_connector->detected_by_load = true;
1113 enum drm_connector_status lret;
1114 /* assume digital unless load detected otherwise */
1115 amdgpu_connector->use_digital = true;
1116 lret = encoder_funcs->detect(encoder, connector);
1117 DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
1118 if (lret == connector_status_connected)
1119 amdgpu_connector->use_digital = false;
1127 /* updated in get modes as well since we need to know if it's analog or digital */
1128 amdgpu_connector_update_scratch_regs(connector, ret);
1131 if (!drm_kms_helper_is_poll_worker()) {
1132 pm_runtime_mark_last_busy(connector->dev->dev);
1133 pm_runtime_put_autosuspend(connector->dev->dev);
1139 /* okay need to be smart in here about which encoder to pick */
1140 static struct drm_encoder *
1141 amdgpu_connector_dvi_encoder(struct drm_connector *connector)
1143 int enc_id = connector->encoder_ids[0];
1144 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1145 struct drm_encoder *encoder;
1147 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1148 if (connector->encoder_ids[i] == 0)
1151 encoder = drm_encoder_find(connector->dev, NULL, connector->encoder_ids[i]);
1155 if (amdgpu_connector->use_digital == true) {
1156 if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
1159 if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
1160 encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1165 /* see if we have a default encoder TODO */
1167 /* then check use digitial */
1168 /* pick the first one */
1170 return drm_encoder_find(connector->dev, NULL, enc_id);
1174 static void amdgpu_connector_dvi_force(struct drm_connector *connector)
1176 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1177 if (connector->force == DRM_FORCE_ON)
1178 amdgpu_connector->use_digital = false;
1179 if (connector->force == DRM_FORCE_ON_DIGITAL)
1180 amdgpu_connector->use_digital = true;
1183 static int amdgpu_connector_dvi_mode_valid(struct drm_connector *connector,
1184 struct drm_display_mode *mode)
1186 struct drm_device *dev = connector->dev;
1187 struct amdgpu_device *adev = dev->dev_private;
1188 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1190 /* XXX check mode bandwidth */
1192 if (amdgpu_connector->use_digital && (mode->clock > 165000)) {
1193 if ((amdgpu_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
1194 (amdgpu_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
1195 (amdgpu_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B)) {
1197 } else if (drm_detect_hdmi_monitor(amdgpu_connector_edid(connector))) {
1198 /* HDMI 1.3+ supports max clock of 340 Mhz */
1199 if (mode->clock > 340000)
1200 return MODE_CLOCK_HIGH;
1204 return MODE_CLOCK_HIGH;
1208 /* check against the max pixel clock */
1209 if ((mode->clock / 10) > adev->clock.max_pixel_clock)
1210 return MODE_CLOCK_HIGH;
1215 static const struct drm_connector_helper_funcs amdgpu_connector_dvi_helper_funcs = {
1216 .get_modes = amdgpu_connector_vga_get_modes,
1217 .mode_valid = amdgpu_connector_dvi_mode_valid,
1218 .best_encoder = amdgpu_connector_dvi_encoder,
1221 static const struct drm_connector_funcs amdgpu_connector_dvi_funcs = {
1222 .dpms = drm_helper_connector_dpms,
1223 .detect = amdgpu_connector_dvi_detect,
1224 .fill_modes = drm_helper_probe_single_connector_modes,
1225 .set_property = amdgpu_connector_set_property,
1226 .early_unregister = amdgpu_connector_unregister,
1227 .destroy = amdgpu_connector_destroy,
1228 .force = amdgpu_connector_dvi_force,
1231 static int amdgpu_connector_dp_get_modes(struct drm_connector *connector)
1233 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1234 struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1235 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1238 if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1239 (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1240 struct drm_display_mode *mode;
1242 if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
1243 if (!amdgpu_dig_connector->edp_on)
1244 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1245 ATOM_TRANSMITTER_ACTION_POWER_ON);
1246 amdgpu_connector_get_edid(connector);
1247 ret = amdgpu_connector_ddc_get_modes(connector);
1248 if (!amdgpu_dig_connector->edp_on)
1249 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1250 ATOM_TRANSMITTER_ACTION_POWER_OFF);
1252 /* need to setup ddc on the bridge */
1253 if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1254 ENCODER_OBJECT_ID_NONE) {
1256 amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1258 amdgpu_connector_get_edid(connector);
1259 ret = amdgpu_connector_ddc_get_modes(connector);
1264 amdgpu_connector_fixup_lcd_native_mode(encoder, connector);
1265 /* add scaled modes */
1266 amdgpu_connector_add_common_modes(encoder, connector);
1274 /* we have no EDID modes */
1275 mode = amdgpu_connector_lcd_native_mode(encoder);
1278 drm_mode_probed_add(connector, mode);
1279 /* add the width/height from vbios tables if available */
1280 connector->display_info.width_mm = mode->width_mm;
1281 connector->display_info.height_mm = mode->height_mm;
1282 /* add scaled modes */
1283 amdgpu_connector_add_common_modes(encoder, connector);
1286 /* need to setup ddc on the bridge */
1287 if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1288 ENCODER_OBJECT_ID_NONE) {
1290 amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1292 amdgpu_connector_get_edid(connector);
1293 ret = amdgpu_connector_ddc_get_modes(connector);
1295 amdgpu_get_native_mode(connector);
1301 u16 amdgpu_connector_encoder_get_dp_bridge_encoder_id(struct drm_connector *connector)
1303 struct drm_encoder *encoder;
1304 struct amdgpu_encoder *amdgpu_encoder;
1307 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1308 if (connector->encoder_ids[i] == 0)
1311 encoder = drm_encoder_find(connector->dev, NULL,
1312 connector->encoder_ids[i]);
1316 amdgpu_encoder = to_amdgpu_encoder(encoder);
1318 switch (amdgpu_encoder->encoder_id) {
1319 case ENCODER_OBJECT_ID_TRAVIS:
1320 case ENCODER_OBJECT_ID_NUTMEG:
1321 return amdgpu_encoder->encoder_id;
1327 return ENCODER_OBJECT_ID_NONE;
1330 static bool amdgpu_connector_encoder_is_hbr2(struct drm_connector *connector)
1332 struct drm_encoder *encoder;
1333 struct amdgpu_encoder *amdgpu_encoder;
1337 for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
1338 if (connector->encoder_ids[i] == 0)
1340 encoder = drm_encoder_find(connector->dev, NULL,
1341 connector->encoder_ids[i]);
1345 amdgpu_encoder = to_amdgpu_encoder(encoder);
1346 if (amdgpu_encoder->caps & ATOM_ENCODER_CAP_RECORD_HBR2)
1353 bool amdgpu_connector_is_dp12_capable(struct drm_connector *connector)
1355 struct drm_device *dev = connector->dev;
1356 struct amdgpu_device *adev = dev->dev_private;
1358 if ((adev->clock.default_dispclk >= 53900) &&
1359 amdgpu_connector_encoder_is_hbr2(connector)) {
1366 static enum drm_connector_status
1367 amdgpu_connector_dp_detect(struct drm_connector *connector, bool force)
1369 struct drm_device *dev = connector->dev;
1370 struct amdgpu_device *adev = dev->dev_private;
1371 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1372 enum drm_connector_status ret = connector_status_disconnected;
1373 struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1374 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1377 if (!drm_kms_helper_is_poll_worker()) {
1378 r = pm_runtime_get_sync(connector->dev->dev);
1380 return connector_status_disconnected;
1383 if (!force && amdgpu_connector_check_hpd_status_unchanged(connector)) {
1384 ret = connector->status;
1388 amdgpu_connector_free_edid(connector);
1390 if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1391 (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1393 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
1394 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
1396 /* check if panel is valid */
1397 if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
1398 ret = connector_status_connected;
1400 /* eDP is always DP */
1401 amdgpu_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1402 if (!amdgpu_dig_connector->edp_on)
1403 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1404 ATOM_TRANSMITTER_ACTION_POWER_ON);
1405 if (!amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
1406 ret = connector_status_connected;
1407 if (!amdgpu_dig_connector->edp_on)
1408 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1409 ATOM_TRANSMITTER_ACTION_POWER_OFF);
1410 } else if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1411 ENCODER_OBJECT_ID_NONE) {
1412 /* DP bridges are always DP */
1413 amdgpu_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1414 /* get the DPCD from the bridge */
1415 amdgpu_atombios_dp_get_dpcd(amdgpu_connector);
1418 /* setup ddc on the bridge */
1419 amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1420 /* bridge chips are always aux */
1421 if (amdgpu_ddc_probe(amdgpu_connector, true)) /* try DDC */
1422 ret = connector_status_connected;
1423 else if (amdgpu_connector->dac_load_detect) { /* try load detection */
1424 const struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
1425 ret = encoder_funcs->detect(encoder, connector);
1429 amdgpu_dig_connector->dp_sink_type =
1430 amdgpu_atombios_dp_get_sinktype(amdgpu_connector);
1431 if (amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
1432 ret = connector_status_connected;
1433 if (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT)
1434 amdgpu_atombios_dp_get_dpcd(amdgpu_connector);
1436 if (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1437 if (!amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
1438 ret = connector_status_connected;
1440 /* try non-aux ddc (DP to DVI/HDMI/etc. adapter) */
1441 if (amdgpu_ddc_probe(amdgpu_connector, false))
1442 ret = connector_status_connected;
1447 amdgpu_connector_update_scratch_regs(connector, ret);
1449 if (!drm_kms_helper_is_poll_worker()) {
1450 pm_runtime_mark_last_busy(connector->dev->dev);
1451 pm_runtime_put_autosuspend(connector->dev->dev);
1457 static int amdgpu_connector_dp_mode_valid(struct drm_connector *connector,
1458 struct drm_display_mode *mode)
1460 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1461 struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1463 /* XXX check mode bandwidth */
1465 if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1466 (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1467 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1469 if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
1473 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
1474 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
1476 /* AVIVO hardware supports downscaling modes larger than the panel
1477 * to the panel size, but I'm not sure this is desirable.
1479 if ((mode->hdisplay > native_mode->hdisplay) ||
1480 (mode->vdisplay > native_mode->vdisplay))
1483 /* if scaling is disabled, block non-native modes */
1484 if (amdgpu_encoder->rmx_type == RMX_OFF) {
1485 if ((mode->hdisplay != native_mode->hdisplay) ||
1486 (mode->vdisplay != native_mode->vdisplay))
1492 if ((amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1493 (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP)) {
1494 return amdgpu_atombios_dp_mode_valid_helper(connector, mode);
1496 if (drm_detect_hdmi_monitor(amdgpu_connector_edid(connector))) {
1497 /* HDMI 1.3+ supports max clock of 340 Mhz */
1498 if (mode->clock > 340000)
1499 return MODE_CLOCK_HIGH;
1501 if (mode->clock > 165000)
1502 return MODE_CLOCK_HIGH;
1510 static const struct drm_connector_helper_funcs amdgpu_connector_dp_helper_funcs = {
1511 .get_modes = amdgpu_connector_dp_get_modes,
1512 .mode_valid = amdgpu_connector_dp_mode_valid,
1513 .best_encoder = amdgpu_connector_dvi_encoder,
1516 static const struct drm_connector_funcs amdgpu_connector_dp_funcs = {
1517 .dpms = drm_helper_connector_dpms,
1518 .detect = amdgpu_connector_dp_detect,
1519 .fill_modes = drm_helper_probe_single_connector_modes,
1520 .set_property = amdgpu_connector_set_property,
1521 .early_unregister = amdgpu_connector_unregister,
1522 .destroy = amdgpu_connector_destroy,
1523 .force = amdgpu_connector_dvi_force,
1526 static const struct drm_connector_funcs amdgpu_connector_edp_funcs = {
1527 .dpms = drm_helper_connector_dpms,
1528 .detect = amdgpu_connector_dp_detect,
1529 .fill_modes = drm_helper_probe_single_connector_modes,
1530 .set_property = amdgpu_connector_set_lcd_property,
1531 .early_unregister = amdgpu_connector_unregister,
1532 .destroy = amdgpu_connector_destroy,
1533 .force = amdgpu_connector_dvi_force,
1537 amdgpu_connector_add(struct amdgpu_device *adev,
1538 uint32_t connector_id,
1539 uint32_t supported_device,
1541 struct amdgpu_i2c_bus_rec *i2c_bus,
1542 uint16_t connector_object_id,
1543 struct amdgpu_hpd *hpd,
1544 struct amdgpu_router *router)
1546 struct drm_device *dev = adev->ddev;
1547 struct drm_connector *connector;
1548 struct amdgpu_connector *amdgpu_connector;
1549 struct amdgpu_connector_atom_dig *amdgpu_dig_connector;
1550 struct drm_encoder *encoder;
1551 struct amdgpu_encoder *amdgpu_encoder;
1552 uint32_t subpixel_order = SubPixelNone;
1553 bool shared_ddc = false;
1554 bool is_dp_bridge = false;
1555 bool has_aux = false;
1557 if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1560 /* see if we already added it */
1561 list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1562 amdgpu_connector = to_amdgpu_connector(connector);
1563 if (amdgpu_connector->connector_id == connector_id) {
1564 amdgpu_connector->devices |= supported_device;
1567 if (amdgpu_connector->ddc_bus && i2c_bus->valid) {
1568 if (amdgpu_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1569 amdgpu_connector->shared_ddc = true;
1572 if (amdgpu_connector->router_bus && router->ddc_valid &&
1573 (amdgpu_connector->router.router_id == router->router_id)) {
1574 amdgpu_connector->shared_ddc = false;
1580 /* check if it's a dp bridge */
1581 list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
1582 amdgpu_encoder = to_amdgpu_encoder(encoder);
1583 if (amdgpu_encoder->devices & supported_device) {
1584 switch (amdgpu_encoder->encoder_id) {
1585 case ENCODER_OBJECT_ID_TRAVIS:
1586 case ENCODER_OBJECT_ID_NUTMEG:
1587 is_dp_bridge = true;
1595 amdgpu_connector = kzalloc(sizeof(struct amdgpu_connector), GFP_KERNEL);
1596 if (!amdgpu_connector)
1599 connector = &amdgpu_connector->base;
1601 amdgpu_connector->connector_id = connector_id;
1602 amdgpu_connector->devices = supported_device;
1603 amdgpu_connector->shared_ddc = shared_ddc;
1604 amdgpu_connector->connector_object_id = connector_object_id;
1605 amdgpu_connector->hpd = *hpd;
1607 amdgpu_connector->router = *router;
1608 if (router->ddc_valid || router->cd_valid) {
1609 amdgpu_connector->router_bus = amdgpu_i2c_lookup(adev, &router->i2c_info);
1610 if (!amdgpu_connector->router_bus)
1611 DRM_ERROR("Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
1615 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1616 if (!amdgpu_dig_connector)
1618 amdgpu_connector->con_priv = amdgpu_dig_connector;
1619 if (i2c_bus->valid) {
1620 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1621 if (amdgpu_connector->ddc_bus)
1624 DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1626 switch (connector_type) {
1627 case DRM_MODE_CONNECTOR_VGA:
1628 case DRM_MODE_CONNECTOR_DVIA:
1630 drm_connector_init(dev, &amdgpu_connector->base,
1631 &amdgpu_connector_dp_funcs, connector_type);
1632 drm_connector_helper_add(&amdgpu_connector->base,
1633 &amdgpu_connector_dp_helper_funcs);
1634 connector->interlace_allowed = true;
1635 connector->doublescan_allowed = true;
1636 amdgpu_connector->dac_load_detect = true;
1637 drm_object_attach_property(&amdgpu_connector->base.base,
1638 adev->mode_info.load_detect_property,
1640 drm_object_attach_property(&amdgpu_connector->base.base,
1641 dev->mode_config.scaling_mode_property,
1642 DRM_MODE_SCALE_NONE);
1644 case DRM_MODE_CONNECTOR_DVII:
1645 case DRM_MODE_CONNECTOR_DVID:
1646 case DRM_MODE_CONNECTOR_HDMIA:
1647 case DRM_MODE_CONNECTOR_HDMIB:
1648 case DRM_MODE_CONNECTOR_DisplayPort:
1649 drm_connector_init(dev, &amdgpu_connector->base,
1650 &amdgpu_connector_dp_funcs, connector_type);
1651 drm_connector_helper_add(&amdgpu_connector->base,
1652 &amdgpu_connector_dp_helper_funcs);
1653 drm_object_attach_property(&amdgpu_connector->base.base,
1654 adev->mode_info.underscan_property,
1656 drm_object_attach_property(&amdgpu_connector->base.base,
1657 adev->mode_info.underscan_hborder_property,
1659 drm_object_attach_property(&amdgpu_connector->base.base,
1660 adev->mode_info.underscan_vborder_property,
1663 drm_object_attach_property(&amdgpu_connector->base.base,
1664 dev->mode_config.scaling_mode_property,
1665 DRM_MODE_SCALE_NONE);
1667 drm_object_attach_property(&amdgpu_connector->base.base,
1668 adev->mode_info.dither_property,
1669 AMDGPU_FMT_DITHER_DISABLE);
1671 if (amdgpu_audio != 0)
1672 drm_object_attach_property(&amdgpu_connector->base.base,
1673 adev->mode_info.audio_property,
1676 subpixel_order = SubPixelHorizontalRGB;
1677 connector->interlace_allowed = true;
1678 if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1679 connector->doublescan_allowed = true;
1681 connector->doublescan_allowed = false;
1682 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1683 amdgpu_connector->dac_load_detect = true;
1684 drm_object_attach_property(&amdgpu_connector->base.base,
1685 adev->mode_info.load_detect_property,
1689 case DRM_MODE_CONNECTOR_LVDS:
1690 case DRM_MODE_CONNECTOR_eDP:
1691 drm_connector_init(dev, &amdgpu_connector->base,
1692 &amdgpu_connector_edp_funcs, connector_type);
1693 drm_connector_helper_add(&amdgpu_connector->base,
1694 &amdgpu_connector_dp_helper_funcs);
1695 drm_object_attach_property(&amdgpu_connector->base.base,
1696 dev->mode_config.scaling_mode_property,
1697 DRM_MODE_SCALE_FULLSCREEN);
1698 subpixel_order = SubPixelHorizontalRGB;
1699 connector->interlace_allowed = false;
1700 connector->doublescan_allowed = false;
1704 switch (connector_type) {
1705 case DRM_MODE_CONNECTOR_VGA:
1706 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_vga_funcs, connector_type);
1707 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_vga_helper_funcs);
1708 if (i2c_bus->valid) {
1709 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1710 if (!amdgpu_connector->ddc_bus)
1711 DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1713 amdgpu_connector->dac_load_detect = true;
1714 drm_object_attach_property(&amdgpu_connector->base.base,
1715 adev->mode_info.load_detect_property,
1717 drm_object_attach_property(&amdgpu_connector->base.base,
1718 dev->mode_config.scaling_mode_property,
1719 DRM_MODE_SCALE_NONE);
1720 /* no HPD on analog connectors */
1721 amdgpu_connector->hpd.hpd = AMDGPU_HPD_NONE;
1722 connector->interlace_allowed = true;
1723 connector->doublescan_allowed = true;
1725 case DRM_MODE_CONNECTOR_DVIA:
1726 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_vga_funcs, connector_type);
1727 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_vga_helper_funcs);
1728 if (i2c_bus->valid) {
1729 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1730 if (!amdgpu_connector->ddc_bus)
1731 DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1733 amdgpu_connector->dac_load_detect = true;
1734 drm_object_attach_property(&amdgpu_connector->base.base,
1735 adev->mode_info.load_detect_property,
1737 drm_object_attach_property(&amdgpu_connector->base.base,
1738 dev->mode_config.scaling_mode_property,
1739 DRM_MODE_SCALE_NONE);
1740 /* no HPD on analog connectors */
1741 amdgpu_connector->hpd.hpd = AMDGPU_HPD_NONE;
1742 connector->interlace_allowed = true;
1743 connector->doublescan_allowed = true;
1745 case DRM_MODE_CONNECTOR_DVII:
1746 case DRM_MODE_CONNECTOR_DVID:
1747 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1748 if (!amdgpu_dig_connector)
1750 amdgpu_connector->con_priv = amdgpu_dig_connector;
1751 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_dvi_funcs, connector_type);
1752 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dvi_helper_funcs);
1753 if (i2c_bus->valid) {
1754 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1755 if (!amdgpu_connector->ddc_bus)
1756 DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1758 subpixel_order = SubPixelHorizontalRGB;
1759 drm_object_attach_property(&amdgpu_connector->base.base,
1760 adev->mode_info.coherent_mode_property,
1762 drm_object_attach_property(&amdgpu_connector->base.base,
1763 adev->mode_info.underscan_property,
1765 drm_object_attach_property(&amdgpu_connector->base.base,
1766 adev->mode_info.underscan_hborder_property,
1768 drm_object_attach_property(&amdgpu_connector->base.base,
1769 adev->mode_info.underscan_vborder_property,
1771 drm_object_attach_property(&amdgpu_connector->base.base,
1772 dev->mode_config.scaling_mode_property,
1773 DRM_MODE_SCALE_NONE);
1775 if (amdgpu_audio != 0) {
1776 drm_object_attach_property(&amdgpu_connector->base.base,
1777 adev->mode_info.audio_property,
1780 drm_object_attach_property(&amdgpu_connector->base.base,
1781 adev->mode_info.dither_property,
1782 AMDGPU_FMT_DITHER_DISABLE);
1783 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1784 amdgpu_connector->dac_load_detect = true;
1785 drm_object_attach_property(&amdgpu_connector->base.base,
1786 adev->mode_info.load_detect_property,
1789 connector->interlace_allowed = true;
1790 if (connector_type == DRM_MODE_CONNECTOR_DVII)
1791 connector->doublescan_allowed = true;
1793 connector->doublescan_allowed = false;
1795 case DRM_MODE_CONNECTOR_HDMIA:
1796 case DRM_MODE_CONNECTOR_HDMIB:
1797 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1798 if (!amdgpu_dig_connector)
1800 amdgpu_connector->con_priv = amdgpu_dig_connector;
1801 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_dvi_funcs, connector_type);
1802 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dvi_helper_funcs);
1803 if (i2c_bus->valid) {
1804 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1805 if (!amdgpu_connector->ddc_bus)
1806 DRM_ERROR("HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1808 drm_object_attach_property(&amdgpu_connector->base.base,
1809 adev->mode_info.coherent_mode_property,
1811 drm_object_attach_property(&amdgpu_connector->base.base,
1812 adev->mode_info.underscan_property,
1814 drm_object_attach_property(&amdgpu_connector->base.base,
1815 adev->mode_info.underscan_hborder_property,
1817 drm_object_attach_property(&amdgpu_connector->base.base,
1818 adev->mode_info.underscan_vborder_property,
1820 drm_object_attach_property(&amdgpu_connector->base.base,
1821 dev->mode_config.scaling_mode_property,
1822 DRM_MODE_SCALE_NONE);
1823 if (amdgpu_audio != 0) {
1824 drm_object_attach_property(&amdgpu_connector->base.base,
1825 adev->mode_info.audio_property,
1828 drm_object_attach_property(&amdgpu_connector->base.base,
1829 adev->mode_info.dither_property,
1830 AMDGPU_FMT_DITHER_DISABLE);
1831 subpixel_order = SubPixelHorizontalRGB;
1832 connector->interlace_allowed = true;
1833 if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1834 connector->doublescan_allowed = true;
1836 connector->doublescan_allowed = false;
1838 case DRM_MODE_CONNECTOR_DisplayPort:
1839 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1840 if (!amdgpu_dig_connector)
1842 amdgpu_connector->con_priv = amdgpu_dig_connector;
1843 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_dp_funcs, connector_type);
1844 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dp_helper_funcs);
1845 if (i2c_bus->valid) {
1846 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1847 if (amdgpu_connector->ddc_bus)
1850 DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1852 subpixel_order = SubPixelHorizontalRGB;
1853 drm_object_attach_property(&amdgpu_connector->base.base,
1854 adev->mode_info.coherent_mode_property,
1856 drm_object_attach_property(&amdgpu_connector->base.base,
1857 adev->mode_info.underscan_property,
1859 drm_object_attach_property(&amdgpu_connector->base.base,
1860 adev->mode_info.underscan_hborder_property,
1862 drm_object_attach_property(&amdgpu_connector->base.base,
1863 adev->mode_info.underscan_vborder_property,
1865 drm_object_attach_property(&amdgpu_connector->base.base,
1866 dev->mode_config.scaling_mode_property,
1867 DRM_MODE_SCALE_NONE);
1868 if (amdgpu_audio != 0) {
1869 drm_object_attach_property(&amdgpu_connector->base.base,
1870 adev->mode_info.audio_property,
1873 drm_object_attach_property(&amdgpu_connector->base.base,
1874 adev->mode_info.dither_property,
1875 AMDGPU_FMT_DITHER_DISABLE);
1876 connector->interlace_allowed = true;
1877 /* in theory with a DP to VGA converter... */
1878 connector->doublescan_allowed = false;
1880 case DRM_MODE_CONNECTOR_eDP:
1881 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1882 if (!amdgpu_dig_connector)
1884 amdgpu_connector->con_priv = amdgpu_dig_connector;
1885 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_edp_funcs, connector_type);
1886 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dp_helper_funcs);
1887 if (i2c_bus->valid) {
1888 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1889 if (amdgpu_connector->ddc_bus)
1892 DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1894 drm_object_attach_property(&amdgpu_connector->base.base,
1895 dev->mode_config.scaling_mode_property,
1896 DRM_MODE_SCALE_FULLSCREEN);
1897 subpixel_order = SubPixelHorizontalRGB;
1898 connector->interlace_allowed = false;
1899 connector->doublescan_allowed = false;
1901 case DRM_MODE_CONNECTOR_LVDS:
1902 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1903 if (!amdgpu_dig_connector)
1905 amdgpu_connector->con_priv = amdgpu_dig_connector;
1906 drm_connector_init(dev, &amdgpu_connector->base, &amdgpu_connector_lvds_funcs, connector_type);
1907 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_lvds_helper_funcs);
1908 if (i2c_bus->valid) {
1909 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1910 if (!amdgpu_connector->ddc_bus)
1911 DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1913 drm_object_attach_property(&amdgpu_connector->base.base,
1914 dev->mode_config.scaling_mode_property,
1915 DRM_MODE_SCALE_FULLSCREEN);
1916 subpixel_order = SubPixelHorizontalRGB;
1917 connector->interlace_allowed = false;
1918 connector->doublescan_allowed = false;
1923 if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE) {
1924 if (i2c_bus->valid) {
1925 connector->polled = DRM_CONNECTOR_POLL_CONNECT |
1926 DRM_CONNECTOR_POLL_DISCONNECT;
1929 connector->polled = DRM_CONNECTOR_POLL_HPD;
1931 connector->display_info.subpixel_order = subpixel_order;
1932 drm_connector_register(connector);
1935 amdgpu_atombios_dp_aux_init(amdgpu_connector);
1940 drm_connector_cleanup(connector);