From 920e1a5bae33391615cd8b66f2f34d7837845aa0 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Thu, 25 May 2023 16:57:55 +1200 Subject: [PATCH] selftest: Rework samba.tests.getdcname not to use ncalrpc This test is able to operate over the network, which aids testing against a comparative windows DC. Signed-off-by: Andrew Bartlett Reviewed-by: Joseph Sutton --- python/samba/tests/getdcname.py | 2 +- source4/selftest/tests.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/samba/tests/getdcname.py b/python/samba/tests/getdcname.py index fc6b6d9a6bd..34806f5e662 100644 --- a/python/samba/tests/getdcname.py +++ b/python/samba/tests/getdcname.py @@ -44,7 +44,7 @@ class GetDCNameEx(samba.tests.TestCase): def _call_get_dc_name(self, domain=None, domain_guid=None, site_name=None, ex2=False, flags=0): if self.netlogon_conn is None: - self.netlogon_conn = netlogon.netlogon("ncalrpc:[schannel]", + self.netlogon_conn = netlogon.netlogon(f"ncacn_ip_tcp:{self.server}", self.get_loadparm()) if ex2: diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py index 93d161d89f1..ef63c222a4f 100755 --- a/source4/selftest/tests.py +++ b/source4/selftest/tests.py @@ -1323,7 +1323,7 @@ if have_heimdal_support: planoldpythontestsuite("ad_dc", "samba.tests.group_audit", extra_args=['-U"$USERNAME%$PASSWORD"']) -planoldpythontestsuite("fl2008r2dc:local", +planoldpythontestsuite("fl2008r2dc", "samba.tests.getdcname", extra_args=['-U"$USERNAME%$PASSWORD"']) -- 2.34.1