13 years agos4:Ensure the selected RDN is the right one per the schema
Andrew Bartlett [Tue, 22 Sep 2009 00:24:43 +0000 (17:24 -0700)]
s4:Ensure the selected RDN is the right one per the schema

The relative DN must be the one that the most specific structural
objectclass specifies.

Andrew Bartlett

13 years agos4-samldb: the samldb module requires that the primary group exists
Andrew Tridgell [Fri, 2 Oct 2009 10:00:42 +0000 (20:00 +1000)]
s4-samldb: the samldb module requires that the primary group exists

We need to create Domain Users in the test ldb

13 years agos4-samdb: added some debugging
Andrew Tridgell [Fri, 2 Oct 2009 10:00:08 +0000 (20:00 +1000)]
s4-samdb: added some debugging

This helped track down the failures

13 years agos4-test: skip python gensec test until its finished
Andrew Tridgell [Fri, 2 Oct 2009 08:52:51 +0000 (18:52 +1000)]
s4-test: skip python gensec test until its finished

13 years agos4-pygensec: a bit closer to working
Andrew Tridgell [Fri, 2 Oct 2009 08:50:59 +0000 (18:50 +1000)]
s4-pygensec: a bit closer to working

I'll need help from Andrew on how to get gensec to initialise it's ops

13 years agopidl: fixed unit tests for trailer alignment
Andrew Tridgell [Fri, 2 Oct 2009 07:14:15 +0000 (17:14 +1000)]
pidl: fixed unit tests for trailer alignment

13 years agopid: update ndr testsuite for new union alignment
Andrew Tridgell [Fri, 2 Oct 2009 07:11:26 +0000 (17:11 +1000)]
pid: update ndr testsuite for new union alignment

13 years agos4-torture: added a very simple samr ValidatePassword test
Andrew Tridgell [Fri, 2 Oct 2009 06:03:02 +0000 (16:03 +1000)]
s4-torture: added a very simple samr ValidatePassword test

13 years agos4-samr: fake up a samr_ValidatePassword response
Andrew Tridgell [Fri, 2 Oct 2009 06:02:42 +0000 (16:02 +1000)]
s4-samr: fake up a samr_ValidatePassword response

mdw is working on the correct call to check the password strength

13 years agoidl: rebuilt the IDL for the build farm
Andrew Tridgell [Fri, 2 Oct 2009 05:11:02 +0000 (15:11 +1000)]
idl: rebuilt the IDL for the build farm

13 years agos4-libnet: give sane error messages when functional levels don't match
Andrew Tridgell [Fri, 2 Oct 2009 05:09:59 +0000 (15:09 +1000)]
s4-libnet: give sane error messages when functional levels don't match

It is nice to tell the user why their command failed :-)

13 years agos4:dsdb/common/sidmap - Remove
Matthias Dieter Wallnöfer [Wed, 30 Sep 2009 18:34:35 +0000 (20:34 +0200)]
s4:dsdb/common/sidmap - Remove

As metze pointed out - this seems to be completely dead code. I too didn't find
any dependencies in other code parts. Therefore remove it.

13 years agos4:provision - Change the default forest/domain function level back to Windows 2003...
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 08:50:45 +0000 (10:50 +0200)]
s4:provision - Change the default forest/domain function level back to Windows 2003 Native

13 years agos4:libnet_become_dc - add checks for valid domain/forest function levels
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:44:19 +0000 (10:44 +0200)]
s4:libnet_become_dc - add checks for valid domain/forest function levels

Add checks to make sure that we join only supported AD domains (we agreed that
those are >= (Windows) 2003 Native per default - this is changeable with the
"ads:function level" option).
Add also checks to make sure that we cannot join domains which have a bigger
function level than our DC capable function level (e.g. a (Windows) 2008 DC
cannot join a (Windows) 2008 R2 domain).

13 years agondr64: added support for trailing gap alignment
Andrew Tridgell [Thu, 1 Oct 2009 06:08:02 +0000 (16:08 +1000)]
ndr64: added support for trailing gap alignment

NDR64 has a 'trailing gap' alignment, which aligns the end of a
structure on the overall structure alignment.

This explains the discrepancy we had with the RPC-SAMR test and NDR64

13 years agos4-ldb: accept the binary DN OIDs in extended DN modules
Andrew Tridgell [Thu, 24 Sep 2009 14:06:03 +0000 (07:06 -0700)]
s4-ldb: accept the binary DN OIDs in extended DN modules

13 years agos4-ldb: Add support for binary blobs in DNs
Andrew Tridgell [Fri, 2 Oct 2009 02:03:05 +0000 (12:03 +1000)]
s4-ldb: Add support for binary blobs in DNs

AD has the concept of a DN prefixed with B:NN:XXXXXX: that contains a
binary blob. We need to support those in order to give correctly
formatted binary blobs for things like wellKnownObjects

This implementation is not ideal, as it allows for binary blobs on all
DNs, whereas it should only allow them on those with a syntax of We should clean this up in the future, but meanwhile this
implementation at least gets us a working DC join of w2k8 to s4.

This patch also uses a static function for marking DNs as invalid,
which is very useful when debugging this code, as you can break on it
in gdb.

13 years agos4-cldap: match w2k8-r2 for cldap netlogon bits
Andrew Tridgell [Fri, 2 Oct 2009 01:52:16 +0000 (11:52 +1000)]
s4-cldap: match w2k8-r2 for cldap netlogon bits

Windows does not set the 3 high bits, which is strange given their
meaning. I've submitted a CAR on this.

13 years agods-flags: use the new name DS_DNS_FOREST_ROOT
Andrew Tridgell [Fri, 2 Oct 2009 02:02:00 +0000 (12:02 +1000)]
ds-flags: use the new name DS_DNS_FOREST_ROOT

Update to use the new DS_DNS_FOREST_ROOT name, which makes it clearer
what this bit means (according to MS-ADTS doc)

13 years agos3-ads: removed 3 unused defines
Andrew Tridgell [Fri, 2 Oct 2009 01:49:58 +0000 (11:49 +1000)]
s3-ads: removed 3 unused defines

These are in nbt.idl and netlogon.idl as well, no need to have them
here under different names, especially when the comments are wrong

13 years agoidl: use common netlogon bit definitions
Andrew Tridgell [Thu, 1 Oct 2009 07:29:56 +0000 (17:29 +1000)]
idl: use common netlogon bit definitions

The DS_ bits had got a bit ahead of the NBT_ bits.

Ideally we'd make these a single set of bits at some point.

This also removes NBT_SERVER_DNS_FOREST as this bit doesn't exist. I
think it came from someone mis-reading the docs, which show the bits
in reverse order within bytes (one of the worst bit table
representations I have ever seen!)

13 years agos4/torture: Add two new SMB RAW-OPEN tests
Aravind Srinivasan [Thu, 1 Oct 2009 23:13:37 +0000 (16:13 -0700)]
s4/torture: Add two new SMB RAW-OPEN tests

* Add chained NTCREATEX_READX test which first tries to open/read
  a non-existant file failing on the open, then attempts the same
  operation on a file that does exist, opening and reading

* Add test for open_dispositions on directories.

13 years agos4/torture: convert printf to torture_comment() in RAW-OPEN
Aravind Srinivasan [Thu, 1 Oct 2009 23:11:59 +0000 (16:11 -0700)]
s4/torture: convert printf to torture_comment() in RAW-OPEN

Allows "make test" and other harnesses to print cleaner output.

13 years agoFix bug #6769 - symlink unlink does nothing.
Jeremy Allison [Thu, 1 Oct 2009 23:54:06 +0000 (16:54 -0700)]
Fix bug #6769 - symlink unlink does nothing.
Always use LSTAT for POSIX pathnames.

13 years agos4/torture: second try on renaming oplocks.c to oplock.c
Steven Danneman [Thu, 1 Oct 2009 23:38:40 +0000 (16:38 -0700)]
s4/torture: second try on renaming oplocks.c to oplock.c

Forgot to "git add" the new file in commit b2bcfaae

13 years agoNULL is not a valid event context.
Jeremy Allison [Thu, 1 Oct 2009 23:18:33 +0000 (16:18 -0700)]
NULL is not a valid event context.

13 years agos4/torture: rename oplocks.c to oplock.c to match SMB1 file layout
Steven Danneman [Thu, 1 Oct 2009 20:47:28 +0000 (13:47 -0700)]
s4/torture: rename oplocks.c to oplock.c to match SMB1 file layout

13 years agos4/torture: Ported SMB oplock torture tests to SMB2
Steven Danneman [Thu, 30 Jul 2009 22:10:50 +0000 (15:10 -0700)]
s4/torture: Ported SMB oplock torture tests to SMB2

I've ported all applicable SMB oplock torture tests to SMB2, giving us
a good base for SMB2 oplock testing.

There are several differences between oplocks in SMB and SMB2, mostly
because of differences in W2K3 and W2K8.  The existing SMB oplock
tests all pass against W2K3, but several fail against W2K8.  These
same tests were failing in SMB2, util I reworked them.

BATCH19, BATCH20: In W2K3/SMB a setfileinfo - rename command wouldn't
cause a sharing violation or break an existing oplock.  It appears that
in W2K8/SMB2 a sharing violation is raised.

BATCH22: In W2K3/SMB when a second opener was waiting the full timeout
of an oplock break, it would receive NT_STATUS_SHARING_VIOLATION after
about 35 seconds.  This bug has been fixed in W2K8/SMB2 and instead
the second opener succeeds.

LEVELII500: Added 1 new test checking that the server returns a proper
error code when a client improperly replies to a levelII to none break

STREAM1: W2K8 now grants oplocks on alternate data streams.

13 years agos4/torture: fix typo in test comment
Steven Danneman [Thu, 1 Oct 2009 18:35:17 +0000 (11:35 -0700)]
s4/torture: fix typo in test comment

13 years agos4/asn1: ber_read_OID_String() to be based on _ber_read_OID_String_impl()
Kamen Mazdrashki [Fri, 25 Sep 2009 22:41:18 +0000 (01:41 +0300)]
s4/asn1: ber_read_OID_String() to be based on _ber_read_OID_String_impl()

13 years agos4/asn1: local TALLOC_CTX should be child of torture_context
Kamen Mazdrashki [Fri, 25 Sep 2009 22:36:01 +0000 (01:36 +0300)]
s4/asn1: local TALLOC_CTX should be child of torture_context

13 years agos4/asn1: fixed typo in torture messages
Kamen Mazdrashki [Fri, 25 Sep 2009 22:34:17 +0000 (01:34 +0300)]
s4/asn1: fixed typo in torture messages

13 years agos4/asn1: Added test for ber_read_partial_OID_String()
Kamen Mazdrashki [Fri, 25 Sep 2009 22:32:40 +0000 (01:32 +0300)]
s4/asn1: Added test for ber_read_partial_OID_String()

13 years agos4/asn1: Added test for ber_read_OID_String()
Kamen Mazdrashki [Fri, 25 Sep 2009 22:25:28 +0000 (01:25 +0300)]
s4/asn1: Added test for ber_read_OID_String()

13 years agos4/asn1: Added test for ber_write_partial_OID_String()
Kamen Mazdrashki [Fri, 25 Sep 2009 20:46:52 +0000 (23:46 +0300)]
s4/asn1: Added test for ber_write_partial_OID_String()

13 years agos4/asn1: Added test for ber_write_OID_String()
Kamen Mazdrashki [Fri, 25 Sep 2009 20:46:07 +0000 (23:46 +0300)]
s4/asn1: Added test for ber_write_OID_String()

13 years agos4/asn1: Added torture suite for ASN1
Kamen Mazdrashki [Fri, 25 Sep 2009 20:43:56 +0000 (23:43 +0300)]
s4/asn1: Added torture suite for ASN1

13 years agoutil: strhex_to_str() fixed to handle '0x' correctly
Kamen Mazdrashki [Fri, 25 Sep 2009 20:40:55 +0000 (23:40 +0300)]
util: strhex_to_str() fixed to handle '0x' correctly

13 years agoutil: fixed compile time "discards qualifiers" warning
Kamen Mazdrashki [Fri, 25 Sep 2009 20:40:04 +0000 (23:40 +0300)]
util: fixed compile time "discards qualifiers" warning

13 years agos4/drsuapi: ber_read_partial_OID_String() implementation
Kamen Mazdrashki [Fri, 25 Sep 2009 14:29:05 +0000 (17:29 +0300)]
s4/drsuapi: ber_read_partial_OID_String() implementation

13 years agos4/drsuapi: Internal implementation for ber_read_OID_String
Kamen Mazdrashki [Fri, 25 Sep 2009 14:28:33 +0000 (17:28 +0300)]
s4/drsuapi: Internal implementation for ber_read_OID_String

Modified implementation _ber_read_OID_String_impl()
returns how much bytes are converted.
The intentation is to use this implementation both for
reading OIDs and partial-OIDs in the future

13 years agos4/drsuapi: ber_write_partial_OID_String() implementation
Kamen Mazdrashki [Fri, 25 Sep 2009 13:38:54 +0000 (16:38 +0300)]
s4/drsuapi: ber_write_partial_OID_String() implementation

13 years agos3:Makefile: fix talloc dependencies with static build
Björn Jacke [Thu, 1 Oct 2009 16:57:38 +0000 (18:57 +0200)]
s3:Makefile: fix talloc dependencies with static build

When configure options --with-libtalloc=no --enable-shared-libs=no are used,
LIBTALLOC_TARGET stays empty. Actually LIBTALLOC_TARGET which is only used for
Makefile dependencies is obsolete as LIBTALLOC contains exactly the targets
that make the dependencies are. Obnox, pleaѕe check!

13 years agos3:configure: don't throw away PRINT_LIBS
Björn Jacke [Thu, 1 Oct 2009 17:08:51 +0000 (19:08 +0200)]
s3:configure: don't throw away PRINT_LIBS

PRINT_LIBS might have been set before intentionally, so don't thow it away.

13 years agos3: update comment about (deprecated) a6 records
Björn Jacke [Wed, 23 Sep 2009 12:40:25 +0000 (14:40 +0200)]
s3: update comment about (deprecated) a6 records

13 years agoFix for CVE-2009-2813.
Jeremy Allison [Thu, 1 Oct 2009 17:23:29 +0000 (10:23 -0700)]
Fix for CVE-2009-2813.

== Subject:     Misconfigured /etc/passwd file may share folders unexpectedly
== CVE ID#:     CVE-2009-2813
== Versions:    All versions of Samba later than 3.0.11
== Summary:     If a user in /etc/passwd is misconfigured to have
==              an empty home directory then connecting to the home
==              share of this user will use the root of the filesystem
==              as the home directory.

13 years agos3/VERSION: Raise version number up to 3.6.0.
Karolin Seeger [Thu, 1 Oct 2009 12:50:28 +0000 (14:50 +0200)]
s3/VERSION: Raise version number up to 3.6.0.


13 years agoFix for CVE-2009-2906.
Jeremy Allison [Thu, 1 Oct 2009 12:32:36 +0000 (14:32 +0200)]
Fix for CVE-2009-2906.

Specially crafted SMB requests on
authenticated SMB connections can send smbd
into a 100% CPU loop, causing a DoS on the
Samba server.

13 years agomount.cifs: don't leak passwords with verbose option
Jeff Layton [Fri, 25 Sep 2009 11:07:40 +0000 (07:07 -0400)]
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <>
Signed-off-by: Jeff Layton <>
Acked-by: Steve French <>
13 years agomount.cifs: check access of credential files before opening
Jeff Layton [Fri, 25 Sep 2009 10:45:10 +0000 (06:45 -0400)]
mount.cifs: check access of credential files before opening

It's possible for an unprivileged user to pass a setuid mount.cifs a
credential or password file to which he does not have access. This can cause
mount.cifs to open the file on his behalf and possibly leak the info in the
first few lines of the file.

Check the access permissions of the file before opening it.

Reported-by: Ronald Volgers <>
Signed-off-by: Jeff Layton <>
Acked-by: Steve French <>
13 years agos4:pyldb - Wrong error type (found only after the push)
Matthias Dieter Wallnöfer [Thu, 1 Oct 2009 12:02:59 +0000 (14:02 +0200)]
s4:pyldb - Wrong error type (found only after the push)

13 years agos4:ldb_msg_diff - Fixes up possible memory leaks and the python binding of it
Matthias Dieter Wallnöfer [Thu, 1 Oct 2009 11:59:02 +0000 (13:59 +0200)]
s4:ldb_msg_diff - Fixes up possible memory leaks and the python binding of it

13 years agos3-perfcount: more cleanup.
Günther Deschner [Thu, 1 Oct 2009 08:21:17 +0000 (10:21 +0200)]
s3-perfcount: more cleanup.


13 years agos3-perfcount: only pass down prs_struct when really required.
Günther Deschner [Thu, 1 Oct 2009 01:39:07 +0000 (03:39 +0200)]
s3-perfcount: only pass down prs_struct when really required.


13 years agos3: add perfcount idl and generated files.
Günther Deschner [Thu, 1 Oct 2009 00:09:33 +0000 (02:09 +0200)]
s3: add perfcount idl and generated files.


13 years agos3-registry: move rpccli_winreg_Connect to the only file it belongs.
Günther Deschner [Wed, 30 Sep 2009 23:30:45 +0000 (01:30 +0200)]
s3-registry: move rpccli_winreg_Connect to the only file it belongs.


13 years agos3: remove unused rpcstr_pull and rpcstr_pull_talloc.
Günther Deschner [Wed, 30 Sep 2009 18:01:54 +0000 (20:01 +0200)]
s3: remove unused rpcstr_pull and rpcstr_pull_talloc.


13 years agos3-printing: more use of pull_reg_sz().
Günther Deschner [Wed, 30 Sep 2009 18:01:35 +0000 (20:01 +0200)]
s3-printing: more use of pull_reg_sz().


13 years agos3-registry: use pull_reg_sz() where appropriate.
Günther Deschner [Wed, 30 Sep 2009 18:00:52 +0000 (20:00 +0200)]
s3-registry: use pull_reg_sz() where appropriate.

(and move away from rpcstr_pull and rpcstr_pull_talloc).


13 years agos4-tort-drs: Add bind_info for dcerpc_drsuapi_DsBind() call
Kamen Mazdrashki [Fri, 18 Sep 2009 16:04:22 +0000 (19:04 +0300)]
s4-tort-drs: Add bind_info for dcerpc_drsuapi_DsBind() call

After this patch DsGetNCChanges() test works fine.

bind_info returned by server is also cached for future use

Signed-off-by: Anatoliy Atanasov <>
13 years agos4-tort-drs: DsReplicaUpdateRefs test fixed and extended
Kamen Mazdrashki [Sun, 13 Sep 2009 20:54:05 +0000 (23:54 +0300)]
s4-tort-drs: DsReplicaUpdateRefs test fixed and extended

Signed-off-by: Anatoliy Atanasov <>
13 years agos4-tort: Added assertion macro for DRSUAPI call
Kamen Mazdrashki [Fri, 18 Sep 2009 15:11:56 +0000 (18:11 +0300)]
s4-tort: Added assertion macro for DRSUAPI call

Signed-off-by: Anatoliy Atanasov <>
13 years agoallow for outstanding_aio_calls to be decremented
Olaf Flebbe [Wed, 30 Sep 2009 22:20:09 +0000 (15:20 -0700)]
allow for outstanding_aio_calls to be decremented

13 years agos3-printing: use regval_ctr_addvalue_multi_sz.
Günther Deschner [Wed, 30 Sep 2009 13:22:02 +0000 (15:22 +0200)]
s3-printing: use regval_ctr_addvalue_multi_sz.


13 years agos3-registry: add regval_ctr_addvalue_multi_sz.
Günther Deschner [Wed, 30 Sep 2009 13:21:37 +0000 (15:21 +0200)]
s3-registry: add regval_ctr_addvalue_multi_sz.


13 years agos3: re-run make idl. janitor for tridge.
Günther Deschner [Wed, 30 Sep 2009 14:18:29 +0000 (16:18 +0200)]
s3: re-run make idl. janitor for tridge.


13 years agos3-rpc_parse: remove unused prs_string.
Günther Deschner [Tue, 29 Sep 2009 23:23:13 +0000 (01:23 +0200)]
s3-rpc_parse: remove unused prs_string.


13 years agos4:torture: data_blob_hex_string() output is now lowercase.
Andrew Kroeger [Fri, 25 Sep 2009 20:10:40 +0000 (15:10 -0500)]
s4:torture: data_blob_hex_string() output is now lowercase.

Based on the change in commit fb84edabbe9f358031117de2cf78613c704ac600, these
tests needs to expect lowercase output.

13 years agos4:samba.tests.samdb - remove last relicts of the templates
Matthias Dieter Wallnöfer [Sat, 26 Sep 2009 16:37:56 +0000 (18:37 +0200)]
s4:samba.tests.samdb - remove last relicts of the templates

13 years agos4:pyldb - Fixed the return value in "py_ldb_msg_diff"
Matthias Dieter Wallnöfer [Tue, 22 Sep 2009 12:10:52 +0000 (14:10 +0200)]
s4:pyldb - Fixed the return value in "py_ldb_msg_diff"

The case distinction shouldn't be needed also when "diff" is NULL.
"PyLdbMessage_FromMessage" works with "NULL" arguments.

13 years agoRevert "s4:wmic - Output enhancements"
Matthias Dieter Wallnöfer [Tue, 22 Sep 2009 14:06:23 +0000 (16:06 +0200)]
Revert "s4:wmic - Output enhancements"

This reverts commit fb914640ad656b146f732ab33063575e2e47e37c.

Jelmer requested the revert since he feels better when we reapply this change
after his merge with the updated WMI branch.

13 years agoRevert "python: create a script for reorgnizing an LDB file."
Matthias Dieter Wallnöfer [Wed, 23 Sep 2009 12:32:03 +0000 (14:32 +0200)]
Revert "python: create a script for reorgnizing an LDB file."

This reverts commit 11a7842854c0be8c427a2dbf0a8fc3761cda6298.

abartlet claims that this patch could lead to data loss (look at technical
mailing list)

13 years agos4:pwsettings - Improve error handling and introduce "choice" type
Matthias Dieter Wallnöfer [Tue, 22 Sep 2009 12:09:37 +0000 (14:09 +0200)]
s4:pwsettings - Improve error handling and introduce "choice" type

- Improve the error handling according to Jelmer's suggestions
- Print out the error messages on "stderr"
- Add also here the "choice" type for arguments

13 years agos4:provision - Lets the user choose between the supported forest/domain function...
Matthias Dieter Wallnöfer [Tue, 22 Sep 2009 14:59:29 +0000 (16:59 +0200)]
s4:provision - Lets the user choose between the supported forest/domain function levels

Adds a parameter "--function-level" which allows to specify the domain and
forest function level.

13 years agos4:provision: Show domains and forests are W2K8 DC capable.
Andrew Kroeger [Thu, 24 Sep 2009 21:58:04 +0000 (16:58 -0500)]
s4:provision: Show domains and forests are W2K8 DC capable.

When adding a W2K8 DC to a domain running earlier DC versions, the "adprep"
utility is used to perform schema updates and update other attributes as

Adding these entries provides an indication that the adprep utility has been run
with the /forestprep, /domainprep and /rodcprep arguments.  Although these
entries indicate adprep has been run, nothing has been done to verify that the
changes that the adprep utility would have made have actually been done.

The values used for the revision atttributes are as seen on a W2K8 DC (not
W2K8 R2, which will probably have higher values).

13 years agos4:provision: Update schema version number to W2K8.
Andrew Kroeger [Mon, 21 Sep 2009 02:36:47 +0000 (21:36 -0500)]
s4:provision: Update schema version number to W2K8.

We are running the W2K8 schema version, not the W2K3 version.

13 years agos4:dsdb/common/util - remove introduced "samdb_is_capable_dc" call
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 12:16:34 +0000 (14:16 +0200)]
s4:dsdb/common/util - remove introduced "samdb_is_capable_dc" call

I came up with a better solution which is invoked when we try to join a domain
as a DC (in file "libnet_become_dc.c"). Consider a following commit for this

13 years agos4:domainlevel - General rework
Matthias Dieter Wallnöfer [Mon, 21 Sep 2009 19:46:14 +0000 (21:46 +0200)]
s4:domainlevel - General rework

- We support domain/forest function levels >= (Windows) 2003 Native -> adapt the
  domain/forest and DC function level restrictions.
- Consider also the lowest function level of a DC. The domain and forest function
  levels can never be higher than it.
- Improve the error handling by printing out messages to "stderr"
- Introduce the "choice" type for choice arguments (saves us some error handling)

13 years agow32err: Importing auto-generated Win32 errors and descriptions
Kamen Mazdrashki [Fri, 18 Sep 2009 13:30:09 +0000 (16:30 +0300)]
w32err: Importing auto-generated Win32 errors and descriptions

Error codes and their descriptions are generated
using script.
Error are downloaded from MS site:

Signed-off-by: Anatoliy Atanasov <>
13 years agow32err: WERR_GROUP_NOT_FOUND renamed to WERR_GROUPNOTFOUND
Kamen Mazdrashki [Thu, 17 Sep 2009 21:20:23 +0000 (00:20 +0300)]

In Win 32 we have
NERR_GroupNotFound which maps to WERR_GROUP_NOT_FOUND currently
and we have
ERROR_GROUP_NOT_FOUND which maps to nothing, so it is to be added

Signed-off-by: Anatoliy Atanasov <>
13 years agow32err: WERR_USER_EXISTS replace with WERR_USEREXISTS name
Kamen Mazdrashki [Thu, 17 Sep 2009 21:00:21 +0000 (00:00 +0300)]
w32err: WERR_USER_EXISTS replace with WERR_USEREXISTS name

In Win32 we have
NERR_UserExists which maps to WERR_USER_EXISTS currently
and there is

Signed-off-by: Anatoliy Atanasov <>
13 years agow32err: WERR_DC_NOT_FOUND replaced with WERR_DCNOTFOUND
Kamen Mazdrashki [Thu, 17 Sep 2009 21:46:52 +0000 (00:46 +0300)]

It turns out in win32 ERROR_DC_NOT_FOUND exists and it is
an error for Device Context (DC), not Domain Controller

Signed-off-by: Anatoliy Atanasov <>
13 years agow32err: FRS_ group of errors replaced with numeric values
Kamen Mazdrashki [Thu, 17 Sep 2009 20:18:40 +0000 (23:18 +0300)]
w32err: FRS_ group of errors replaced with numeric values

Signed-off-by: Anatoliy Atanasov <>
13 years agow32err: WERR_DOMAIN_CONTROLLER_NOT_FOUND error value fixed
Kamen Mazdrashki [Thu, 17 Sep 2009 10:52:28 +0000 (13:52 +0300)]
w32err: WERR_DOMAIN_CONTROLLER_NOT_FOUND error value fixed

Signed-off-by: Anatoliy Atanasov <>
13 years agow32err: Script to fetch and prepare errors to be updated/added
Kamen Mazdrashki [Wed, 30 Sep 2009 09:28:10 +0000 (12:28 +0300)]
w32err: Script to fetch and prepare errors to be updated/added

Signed-off-by: Anatoliy Atanasov <>
13 years agoidl: ntsvcs.idl depends on misc.idl, not winreg.idl
Andrew Tridgell [Wed, 30 Sep 2009 04:33:14 +0000 (14:33 +1000)]
idl: ntsvcs.idl depends on misc.idl, not winreg.idl

The winreg_Type definition comes from misc.idl

13 years agos4/torture: fix RAW-OPLOCK-STREAM1 test after commit a11bb14
Steven Danneman [Wed, 30 Sep 2009 02:03:20 +0000 (19:03 -0700)]
s4/torture: fix RAW-OPLOCK-STREAM1 test after commit a11bb14

We were pulling junk memory for our stream names after the reordering
of the struct definition.

13 years agos4/torture: Allow receiving of oplock break requests in any order
Steven Danneman [Fri, 25 Sep 2009 23:44:51 +0000 (16:44 -0700)]
s4/torture: Allow receiving of oplock break requests in any order

Previously, the oplock torture tests, being single threaded, required
the server to return oplock break requests, and other SMB packets
in a specific order for us to verify "correctness".

Of course, in several cases the protocol allows the break packets,
especially breaks to levelII to come back in any order.  With tevent
we're now able to wait for oplock breaks in the middle of a torture

I've added a helper to do this, and modified all oplock tests to allow
returning of oplock breaks in any order.

13 years agos4/torture: convert printf to torture_comment()
Aravind Srinivasan [Tue, 8 Sep 2009 20:12:26 +0000 (13:12 -0700)]
s4/torture: convert printf to torture_comment()

Allows "make test" and other harnesses to print cleaner output.

13 years agos3-netlogon: properly implement _netr_NetrEnumerateTrustedDomains().
Günther Deschner [Thu, 24 Sep 2009 16:53:40 +0000 (18:53 +0200)]
s3-netlogon: properly implement _netr_NetrEnumerateTrustedDomains().


13 years agos3: remove unused unistr2_term_codes.
Günther Deschner [Tue, 29 Sep 2009 22:36:05 +0000 (00:36 +0200)]
s3: remove unused unistr2_term_codes.


13 years agos3: remove unused regval_convert_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 23:00:24 +0000 (01:00 +0200)]
s3: remove unused regval_convert_multi_sz().


13 years agos3: remove unused regval_build_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 22:37:02 +0000 (00:37 +0200)]
s3: remove unused regval_build_multi_sz().


13 years agos3-rpc_parse: remove unused UNISTR2 struct and init function.
Günther Deschner [Wed, 23 Sep 2009 18:48:25 +0000 (20:48 +0200)]
s3-rpc_parse: remove unused UNISTR2 struct and init function.


13 years agos3: use pull_reg_multi_sz in rpcclient and net.
Günther Deschner [Tue, 29 Sep 2009 21:22:46 +0000 (23:22 +0200)]
s3: use pull_reg_multi_sz in rpcclient and net.


13 years agos3-util: use pull_reg_multi_sz in reg_pull_multi_sz.
Günther Deschner [Fri, 25 Sep 2009 09:35:46 +0000 (11:35 +0200)]
s3-util: use pull_reg_multi_sz in reg_pull_multi_sz.


13 years agos3-registry: use pull_reg_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 22:55:56 +0000 (00:55 +0200)]
s3-registry: use pull_reg_multi_sz().


13 years agos3-util: add pull_reg_sz() and pull_reg_multi_sz() convenience functions.
Günther Deschner [Thu, 24 Sep 2009 22:56:17 +0000 (00:56 +0200)]
s3-util: add pull_reg_sz() and pull_reg_multi_sz() convenience functions.


13 years agos3: use push_reg_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 22:36:43 +0000 (00:36 +0200)]
s3: use push_reg_multi_sz().


13 years agos3-registry: use regval_ctr_addvalue_sz().
Günther Deschner [Thu, 24 Sep 2009 13:01:32 +0000 (15:01 +0200)]
s3-registry: use regval_ctr_addvalue_sz().

Greatly simplifies and cleanes up the code.