Note about crash from Ayamura KIKUCHI
authorMartin Pool <mbp@samba.org>
Sun, 2 Dec 2001 22:47:30 +0000 (22:47 +0000)
committerMartin Pool <mbp@samba.org>
Sun, 2 Dec 2001 22:47:30 +0000 (22:47 +0000)
batch.c

diff --git a/batch.c b/batch.c
index e45d36429a1b812280c4f4d4d0065457a9e3ab6c..0a8b1cf61f13c898e7e0654406f3868fe031249b 100644 (file)
--- a/batch.c
+++ b/batch.c
@@ -150,6 +150,10 @@ void write_batch_argvs_file(int orig_argc, int argc, char **argv)
        /* Write argvs info to batch file */
 
        for (i = argc - orig_argc; i < argc; i++) {
+               /* FIXME: This apparently crashes if rsync is run with
+                * just "rsync -F".  I think directly manipulating
+                * argv[] is probably bogus -- what if -F is part of a
+                * run of several short options? */
                if (!strcmp(argv[i], "-F")) {   /* safer to change it here than script */
                        strncat(buff, "-f ", 3);        /* chg to -f + ext to get ready for remote */
                        strncat(buff, batch_file_ext,