Optimized away a loop in hash_search().
[rsync.git] / flist.c
diff --git a/flist.c b/flist.c
index bc216eb90af12a49344e5d3e95c2027fb0021360..0b600acfba8ed45a30577aa07ab13db594b7052a 100644 (file)
--- a/flist.c
+++ b/flist.c
@@ -47,19 +47,22 @@ extern char *files_from;
 extern int filesfrom_fd;
 
 extern int one_file_system;
+extern int keep_dirlinks;
 extern int preserve_links;
 extern int preserve_hard_links;
 extern int preserve_perms;
 extern int preserve_devices;
 extern int preserve_uid;
 extern int preserve_gid;
-extern int preserve_times;
 extern int relative_paths;
 extern int implied_dirs;
 extern int copy_links;
 extern int copy_unsafe_links;
 extern int protocol_version;
 extern int sanitize_paths;
+extern int delete_excluded;
+extern int orig_umask;
+extern int list_only;
 
 extern int read_batch;
 extern int write_batch;
@@ -93,7 +96,7 @@ static int show_filelist_p(void)
 static void start_filelist_progress(char *kind)
 {
        rprintf(FINFO, "%s ... ", kind);
-       if ((verbose > 1) || do_progress)
+       if (verbose > 1 || do_progress)
                rprintf(FINFO, "\n");
        rflush(FINFO);
 }
@@ -107,7 +110,7 @@ static void emit_filelist_progress(const struct file_list *flist)
 
 static void maybe_emit_filelist_progress(const struct file_list *flist)
 {
-       if (do_progress && show_filelist_p() && ((flist->count % 100) == 0))
+       if (do_progress && show_filelist_p() && (flist->count % 100) == 0)
                emit_filelist_progress(flist);
 }
 
@@ -132,9 +135,10 @@ static void list_file_entry(struct file_struct *f)
 {
        char perms[11];
 
-       if (!f->basename)
+       if (!f->basename) {
                /* this can happen if duplicate names were removed */
                return;
+       }
 
        permstring(perms, f->mode);
 
@@ -142,14 +146,16 @@ static void list_file_entry(struct file_struct *f)
        if (preserve_links && S_ISLNK(f->mode)) {
                rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
                        perms,
-                       (double) f->length, timestring(f->modtime),
+                       (double)f->length, timestring(f->modtime),
                        f_name(f), f->u.link);
        } else
 #endif
+       {
                rprintf(FINFO, "%s %11.0f %s %s\n",
                        perms,
-                       (double) f->length, timestring(f->modtime),
+                       (double)f->length, timestring(f->modtime),
                        f_name(f));
+       }
 }
 
 
@@ -172,10 +178,10 @@ int readlink_stat(const char *path, STRUCT_STAT *buffer, char *linkbuf)
 #if SUPPORT_LINKS
        if (copy_links)
                return do_stat(path, buffer);
-       if (do_lstat(path, buffer) == -1)
+       if (link_stat(path, buffer, keep_dirlinks) < 0)
                return -1;
        if (S_ISLNK(buffer->st_mode)) {
-               int l = readlink((char *) path, linkbuf, MAXPATHLEN - 1);
+               int l = readlink((char *)path, linkbuf, MAXPATHLEN - 1);
                if (l == -1)
                        return -1;
                linkbuf[l] = 0;
@@ -193,12 +199,19 @@ int readlink_stat(const char *path, STRUCT_STAT *buffer, char *linkbuf)
 #endif
 }
 
-int link_stat(const char *path, STRUCT_STAT * buffer)
+int link_stat(const char *path, STRUCT_STAT *buffer, int follow_dirlinks)
 {
 #if SUPPORT_LINKS
        if (copy_links)
                return do_stat(path, buffer);
-       return do_lstat(path, buffer);
+       if (do_lstat(path, buffer) < 0)
+               return -1;
+       if (follow_dirlinks && S_ISLNK(buffer->st_mode)) {
+               STRUCT_STAT st;
+               if (do_stat(path, &st) == 0 && S_ISDIR(st.st_mode))
+                       *buffer = st;
+       }
+       return 0;
 #else
        return do_stat(path, buffer);
 #endif
@@ -248,7 +261,7 @@ static dev_t filesystem_dev;
 static void set_filesystem(char *fname)
 {
        STRUCT_STAT st;
-       if (link_stat(fname, &st) != 0)
+       if (do_stat(fname, &st) != 0)
                return;
        filesystem_dev = st.st_dev;
 }
@@ -260,14 +273,14 @@ static int to_wire_mode(mode_t mode)
        if (S_ISLNK(mode) && (_S_IFLNK != 0120000))
                return (mode & ~(_S_IFMT)) | 0120000;
 #endif
-       return (int) mode;
+       return (int)mode;
 }
 
 static mode_t from_wire_mode(int mode)
 {
        if ((mode & (_S_IFMT)) == 0120000 && (_S_IFLNK != 0120000))
                return (mode & ~(_S_IFMT)) | _S_IFLNK;
-       return (mode_t) mode;
+       return (mode_t)mode;
 }
 
 
@@ -283,7 +296,7 @@ static int flist_dir_len;
  **/
 void flist_expand(struct file_list *flist)
 {
-       void *new_ptr;
+       struct file_struct **new_ptr;
 
        if (flist->count < flist->malloced)
                return;
@@ -302,21 +315,17 @@ void flist_expand(struct file_list *flist)
        if (flist->malloced < flist->count)
                flist->malloced = flist->count;
 
-       if (flist->files) {
-               new_ptr = realloc_array(flist->files,
-                   struct file_struct *, flist->malloced);
-       } else {
-               new_ptr = new_array(struct file_struct *, flist->malloced);
-       }
+       new_ptr = realloc_array(flist->files, struct file_struct *,
+                               flist->malloced);
 
        if (verbose >= 2) {
                rprintf(FINFO, "[%s] expand file_list to %.0f bytes, did%s move\n",
                    who_am_i(),
-                   (double) sizeof flist->files[0] * flist->malloced,
+                   (double)sizeof flist->files[0] * flist->malloced,
                    (new_ptr == flist->files) ? " not" : "");
        }
 
-       flist->files = (struct file_struct **) new_ptr;
+       flist->files = new_ptr;
 
        if (!flist->files)
                out_of_memory("flist_expand");
@@ -333,7 +342,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
        static uid_t uid;
        static gid_t gid;
        static char lastname[MAXPATHLEN];
-       char *fname, fbuf[MAXPATHLEN];
+       char fname[MAXPATHLEN];
        int l1, l2;
 
        if (f == -1)
@@ -351,7 +360,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
 
        io_write_phase = "send_file_entry";
 
-       fname = f_name_to(file, fbuf);
+       f_name_to(file, fname);
 
        flags = base_flags;
 
@@ -515,7 +524,7 @@ void send_file_entry(struct file_struct *file, int f, unsigned short base_flags)
 
 
 void receive_file_entry(struct file_struct **fptr, unsigned short flags,
-    struct file_list *flist, int f)
+                       struct file_list *flist, int f)
 {
        static time_t modtime;
        static mode_t mode;
@@ -539,6 +548,7 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags,
                rdev_major = 0;
                uid = 0, gid = 0;
                *lastname = '\0';
+               lastdir_len = -1;
                return;
        }
 
@@ -708,7 +718,6 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags,
        }
 
        if (!preserve_perms) {
-               extern int orig_umask;
                /* set an appropriate set of permissions based on original
                 * permissions and umask. This emulates what GNU cp does */
                file->mode &= ~orig_umask;
@@ -731,8 +740,8 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags,
  * statting directories if we're not recursing, but this is not a very
  * important case.  Some systems may not have d_type.
  **/
-struct file_struct *make_file(char *fname,
-    struct file_list *flist, int exclude_level)
+struct file_struct *make_file(char *fname, struct file_list *flist,
+                             int exclude_level)
 {
        static char *lastdir;
        static int lastdir_len = -1;
@@ -745,7 +754,7 @@ struct file_struct *make_file(char *fname,
        char *basename, *dirname, *bp;
        unsigned short flags = 0;
 
-       if (!flist)     /* lastdir isn't valid if flist is NULL */
+       if (!flist || !flist->count)    /* Ignore lastdir when invalid. */
                lastdir_len = -1;
 
        if (strlcpy(thisname, fname, sizeof thisname)
@@ -761,25 +770,31 @@ struct file_struct *make_file(char *fname,
 
        if (readlink_stat(thisname, &st, linkname) != 0) {
                int save_errno = errno;
-               if (errno == ENOENT) {
-                       enum logcode c = am_daemon && protocol_version < 28
-                           ? FERROR : FINFO;
-                       /* either symlink pointing nowhere or file that
-                        * was removed during rsync run; see if excluded
-                        * before reporting an error */
-                       if (exclude_level != NO_EXCLUDES
-                           && check_exclude_file(thisname, 0, exclude_level)) {
-                               /* file is excluded anyway, ignore silently */
-                               return NULL;
+               /* See if file is excluded before reporting an error. */
+               if (exclude_level != NO_EXCLUDES
+                   && check_exclude_file(thisname, 0, exclude_level))
+                       return NULL;
+               if (save_errno == ENOENT) {
+#if SUPPORT_LINKS
+                       /* Avoid "vanished" error if symlink points nowhere. */
+                       if (copy_links && do_lstat(thisname, &st) == 0
+                           && S_ISLNK(st.st_mode)) {
+                               io_error |= IOERR_GENERAL;
+                               rprintf(FERROR, "symlink has no referent: %s\n",
+                                       full_fname(thisname));
+                       } else
+#endif
+                       {
+                               enum logcode c = am_daemon && protocol_version < 28
+                                   ? FERROR : FINFO;
+                               io_error |= IOERR_VANISHED;
+                               rprintf(c, "file has vanished: %s\n",
+                                       full_fname(thisname));
                        }
-                       io_error |= IOERR_VANISHED;
-                       rprintf(c, "file has vanished: %s\n",
-                           full_fname(thisname));
-               }
-               else {
+               } else {
                        io_error |= IOERR_GENERAL;
-                       rprintf(FERROR, "readlink %s failed: %s\n",
-                           full_fname(thisname), strerror(save_errno));
+                       rsyserr(FERROR, save_errno, "readlink %s failed",
+                               full_fname(thisname));
                }
                return NULL;
        }
@@ -923,7 +938,6 @@ void send_file_name(int f, struct file_list *flist, char *fname,
 {
        struct file_struct *file;
        char fbuf[MAXPATHLEN];
-       extern int delete_excluded;
 
        /* f is set to -1 when calculating deletion file list */
        file = make_file(fname, flist,
@@ -949,7 +963,11 @@ void send_file_name(int f, struct file_list *flist, char *fname,
                struct exclude_list_struct last_list = local_exclude_list;
                local_exclude_list.head = local_exclude_list.tail = NULL;
                send_directory(f, flist, f_name_to(file, fbuf));
-               free_exclude_list(&local_exclude_list);
+               if (verbose > 2) {
+                       rprintf(FINFO, "[%s] popping %sexclude list\n",
+                               who_am_i(), local_exclude_list.debug_type);
+               }
+               clear_exclude_list(&local_exclude_list);
                local_exclude_list = last_list;
        }
 }
@@ -966,8 +984,7 @@ static void send_directory(int f, struct file_list *flist, char *dir)
        d = opendir(dir);
        if (!d) {
                io_error |= IOERR_GENERAL;
-               rprintf(FERROR, "opendir %s failed: %s\n",
-                       full_fname(dir), strerror(errno));
+               rsyserr(FERROR, errno, "opendir %s failed", full_fname(dir));
                return;
        }
 
@@ -1014,8 +1031,7 @@ static void send_directory(int f, struct file_list *flist, char *dir)
        }
        if (errno) {
                io_error |= IOERR_GENERAL;
-               rprintf(FERROR, "readdir(%s): (%d) %s\n",
-                       dir, errno, strerror(errno));
+               rsyserr(FERROR, errno, "readdir(%s)", dir);
        }
 
        closedir(d);
@@ -1023,6 +1039,8 @@ static void send_directory(int f, struct file_list *flist, char *dir)
 
 
 /**
+ * This function is normally called by the sender, but the receiver also
+ * uses it to construct its own file list if --delete has been specified.
  * The delete_files() function in receiver.c sets f to -1 so that we just
  * construct the file list in memory without sending it over the wire.  It
  * also has the side-effect of ignoring user-excludes if delete_excluded
@@ -1050,8 +1068,8 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                io_start_buffering_out(f);
                if (filesfrom_fd >= 0) {
                        if (argv[0] && !push_dir(argv[0])) {
-                               rprintf(FERROR, "push_dir %s failed: %s\n",
-                                       full_fname(argv[0]), strerror(errno));
+                               rsyserr(FERROR, errno, "push_dir %s failed",
+                                       full_fname(argv[0]));
                                exit_cleanup(RERR_FILESELECT);
                        }
                        use_ff_fd = 1;
@@ -1085,11 +1103,11 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                        }
                }
 
-               if (link_stat(fname, &st) != 0) {
+               if (link_stat(fname, &st, keep_dirlinks) != 0) {
                        if (f != -1) {
                                io_error |= IOERR_GENERAL;
-                               rprintf(FERROR, "link_stat %s failed: %s\n",
-                                       full_fname(fname), strerror(errno));
+                               rsyserr(FERROR, errno, "link_stat %s failed",
+                                       full_fname(fname));
                        }
                        continue;
                }
@@ -1158,8 +1176,8 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
 
                        if (!push_dir(dir)) {
                                io_error |= IOERR_GENERAL;
-                               rprintf(FERROR, "push_dir %s failed: %s\n",
-                                       full_fname(dir), strerror(errno));
+                               rsyserr(FERROR, errno, "push_dir %s failed",
+                                       full_fname(dir));
                                continue;
                        }
 
@@ -1181,8 +1199,8 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                        flist_dir = NULL;
                        flist_dir_len = 0;
                        if (!pop_dir(olddir)) {
-                               rprintf(FERROR, "pop_dir %s failed: %s\n",
-                                       full_fname(dir), strerror(errno));
+                               rsyserr(FERROR, errno, "pop_dir %s failed",
+                                       full_fname(dir));
                                exit_cleanup(RERR_FILESELECT);
                        }
                }
@@ -1232,7 +1250,6 @@ struct file_list *recv_file_list(int f)
        struct file_list *flist;
        unsigned short flags;
        int64 start_read;
-       extern int list_only;
 
        if (show_filelist_p())
                start_filelist_progress("receiving file list");
@@ -1422,7 +1439,7 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
                return;
 
        qsort(flist->files, flist->count,
-           sizeof flist->files[0], (int (*)()) file_compare);
+           sizeof flist->files[0], (int (*)())file_compare);
 
        for (i = no_dups? 0 : flist->count; i < flist->count; i++) {
                if (flist->files[i]->basename) {
@@ -1488,8 +1505,8 @@ static void output_flist(struct file_list *flist)
                        *gidbuf = '\0';
                rprintf(FINFO, "[%s] i=%d %s %s %s mode=0%o len=%.0f%s%s\n",
                        who_am_i(), i, NS(file->basedir), NS(file->dirname),
-                       NS(file->basename), (int) file->mode,
-                       (double) file->length, uidbuf, gidbuf);
+                       NS(file->basename), (int)file->mode,
+                       (double)file->length, uidbuf, gidbuf);
        }
 }
 
@@ -1517,11 +1534,17 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
        if (!(c1 = (uchar*)f1->dirname)) {
                state1 = fnc_BASE;
                c1 = (uchar*)f1->basename;
+       } else if (!*c1) {
+               state1 = fnc_SLASH;
+               c1 = (uchar*)"/";
        } else
                state1 = fnc_DIR;
        if (!(c2 = (uchar*)f2->dirname)) {
                state2 = fnc_BASE;
                c2 = (uchar*)f2->basename;
+       } else if (!*c2) {
+               state2 = fnc_SLASH;
+               c2 = (uchar*)"/";
        } else
                state2 = fnc_DIR;