This adds Service Location Protocol support.
-After applying this patch, run these commands for a successful build:
+To use this patch, run these commands for a successful build:
+ patch -p1 <patches/slp.diff
./prepare-source
./configure --enable-slp
make
---- orig/Makefile.in 2006-02-06 05:03:50
-+++ Makefile.in 2006-02-02 00:00:00
-@@ -12,6 +12,8 @@ CFLAGS=@CFLAGS@
+TODO: the configure changes should abort if the user requests --enable-slp
+and we can't honor that request.
+
+based-on: d64bda1c1e79dc385f194d74f7957ce7cd118654
+diff --git a/Makefile.in b/Makefile.in
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -13,6 +13,8 @@ CFLAGS=@CFLAGS@
CPPFLAGS=@CPPFLAGS@
EXEEXT=@EXEEXT@
LDFLAGS=@LDFLAGS@
INSTALLCMD=@INSTALL@
INSTALLMAN=@INSTALL@
-@@ -35,7 +37,7 @@ OBJS1=rsync.o generator.o receiver.o cle
- OBJS2=options.o flist.o io.o compat.o hlink.o token.o uidlist.o socket.o \
- fileio.o batch.o clientname.o chmod.o
+@@ -38,7 +40,7 @@ OBJS1=flist.o rsync.o generator.o receiver.o cleanup.o sender.o exclude.o \
+ OBJS2=options.o io.o compat.o hlink.o token.o uidlist.o socket.o hashtable.o \
+ fileio.o batch.o clientname.o chmod.o acls.o xattrs.o
OBJS3=progress.o pipe.o
-DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o
+DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o $(SLPOBJ)
popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \
popt/popthelp.o popt/poptparse.o
OBJS=$(OBJS1) $(OBJS2) $(OBJS3) $(DAEMON_OBJ) $(LIBOBJ) $(ZLIBOBJ) @BUILD_POPT@
-@@ -69,7 +71,7 @@ install-strip:
+@@ -74,7 +76,7 @@ install-strip:
$(MAKE) INSTALL_STRIP='-s' install
rsync$(EXEEXT): $(OBJS)
+ $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJS) $(LIBS) $(LIBSLP)
$(OBJS): $(HEADERS)
-
---- orig/clientserver.c 2006-02-03 20:41:03
-+++ clientserver.c 2006-02-02 11:32:24
-@@ -836,6 +836,13 @@ int daemon_main(void)
+ $(CHECK_OBJS): $(HEADERS)
+diff --git a/clientserver.c b/clientserver.c
+--- a/clientserver.c
++++ b/clientserver.c
+@@ -1164,6 +1164,13 @@ int daemon_main(void)
* address too. In fact, why not just do inet_ntop on the
* local address??? */
+ }
+#endif
+
- if (((pid_file = lp_pid_file()) != NULL) && (*pid_file != '\0')) {
- char pidbuf[16];
- int fd;
---- orig/configure.in 2006-02-05 04:53:34
-+++ configure.in 2006-02-02 11:30:00
-@@ -518,6 +518,29 @@ if test $rsync_cv_chown_follows_symlink
- AC_DEFINE(CHOWN_MODIFIES_SYMLINK, 1, [Define to 1 if chown modifies symlinks.])
+ start_accept_loop(rsync_port, start_daemon);
+ return -1;
+ }
+diff --git a/configure.ac b/configure.ac
+--- a/configure.ac
++++ b/configure.ac
+@@ -683,6 +683,29 @@ if test $rsync_cv_can_hardlink_special = yes; then
+ AC_DEFINE(CAN_HARDLINK_SPECIAL, 1, [Define to 1 if link() can hard-link special files.])
fi
+AC_ARG_ENABLE(slp, [ --disable-slp turn off SLP support, defaults to on])
AC_CACHE_CHECK([for working socketpair],rsync_cv_HAVE_SOCKETPAIR,[
AC_TRY_RUN([
#include <sys/types.h>
---- orig/loadparm.c 2006-01-30 21:47:45
-+++ loadparm.c 2006-02-02 10:38:12
-@@ -105,6 +105,7 @@ typedef struct
+diff --git a/loadparm.c b/loadparm.c
+--- a/loadparm.c
++++ b/loadparm.c
+@@ -98,6 +98,9 @@ typedef struct {
char *socket_options;
int rsync_port;
++#ifdef HAVE_LIBSLP
+ int slp_refresh;
- int syslog_facility;
- } global;
++#endif
+ } global_vars;
-@@ -286,6 +287,7 @@ static struct parm_struct parm_table[] =
- {"motd file", P_STRING, P_GLOBAL,&Globals.motd_file, NULL,0},
- {"pid file", P_STRING, P_GLOBAL,&Globals.pid_file, NULL,0},
- {"port", P_INTEGER,P_GLOBAL,&Globals.rsync_port, NULL,0},
-+ {"slp refresh", P_INTEGER,P_GLOBAL,&Globals.slp_refresh, NULL,0},
- {"socket options", P_STRING, P_GLOBAL,&Globals.socket_options, NULL,0},
- {"syslog facility", P_ENUM, P_GLOBAL,&Globals.syslog_facility,enum_facilities,0},
+ /* This structure describes a single section. Their order must match the
+@@ -312,6 +315,9 @@ static struct parm_struct parm_table[] =
+ {"motd file", P_STRING, P_GLOBAL,&Vars.g.motd_file, NULL,0},
+ {"pid file", P_STRING, P_GLOBAL,&Vars.g.pid_file, NULL,0},
+ {"port", P_INTEGER,P_GLOBAL,&Vars.g.rsync_port, NULL,0},
++#ifdef HAVE_LIBSLP
++ {"slp refresh", P_INTEGER,P_GLOBAL,&Vars.g.slp_refresh, NULL,0},
++#endif
+ {"socket options", P_STRING, P_GLOBAL,&Vars.g.socket_options, NULL,0},
-@@ -379,6 +381,7 @@ FN_GLOBAL_STRING(lp_pid_file, &Globals.p
- FN_GLOBAL_STRING(lp_socket_options, &Globals.socket_options)
+ {"auth users", P_STRING, P_LOCAL, &Vars.l.auth_users, NULL,0},
+@@ -443,6 +449,9 @@ FN_GLOBAL_STRING(lp_pid_file, &Vars.g.pid_file)
+ FN_GLOBAL_STRING(lp_socket_options, &Vars.g.socket_options)
- FN_GLOBAL_INTEGER(lp_rsync_port, &Globals.rsync_port)
-+FN_GLOBAL_INTEGER(lp_slp_refresh, &Globals.slp_refresh)
- FN_GLOBAL_INTEGER(lp_syslog_facility, &Globals.syslog_facility)
+ FN_GLOBAL_INTEGER(lp_rsync_port, &Vars.g.rsync_port)
++#ifdef HAVE_LIBSLP
++FN_GLOBAL_INTEGER(lp_slp_refresh, &Vars.g.slp_refresh)
++#endif
FN_LOCAL_STRING(lp_auth_users, auth_users)
---- orig/main.c 2006-02-05 04:53:34
-+++ main.c 2006-02-02 11:33:24
-@@ -962,6 +962,18 @@ static int start_client(int argc, char *
+ FN_LOCAL_STRING(lp_charset, charset)
+diff --git a/main.c b/main.c
+--- a/main.c
++++ b/main.c
+@@ -1237,6 +1237,18 @@ static int start_client(int argc, char *argv[])
+
if (!read_batch) { /* for read_batch, NO source is specified */
- argc--;
- shell_path = check_for_hostspec(argv[0], &shell_machine, &rsync_port);
+ char *path = check_for_hostspec(argv[0], &shell_machine, &rsync_port);
+
+ if (shell_machine && !shell_machine[0]) {
+#ifdef HAVE_LIBSLP
+#endif
+ }
+
- if (shell_path) { /* source is remote */
- char *dummy1;
- int dummy2;
---- orig/options.c 2006-02-03 23:51:57
-+++ options.c 2006-02-02 11:41:16
-@@ -195,6 +195,7 @@ static void print_rsync_version(enum log
- char const *hardlinks = "no ";
+ if (path) { /* source is remote */
+ char *dummy_host;
+ int dummy_port = 0;
+diff --git a/options.c b/options.c
+--- a/options.c
++++ b/options.c
+@@ -568,6 +568,7 @@ static void print_rsync_version(enum logcode f)
char const *links = "no ";
+ char const *iconv = "no ";
char const *ipv6 = "no ";
+ char const *slp = "no ";
STRUCT_STAT *dumstat;
- #ifdef HAVE_SOCKETPAIR
-@@ -217,6 +218,10 @@ static void print_rsync_version(enum log
- ipv6 = "";
+ #if SUBPROTOCOL_VERSION != 0
+@@ -601,6 +602,9 @@ static void print_rsync_version(enum logcode f)
+ #ifdef CAN_SET_SYMLINK_TIMES
+ symtimes = "";
#endif
-
+#if HAVE_LIBSLP
+ slp = "";
+#endif
-+
- rprintf(f, "%s version %s protocol version %d\n",
- RSYNC_NAME, RSYNC_VERSION, PROTOCOL_VERSION);
- rprintf(f, "Copyright (C) 1996-2006 by Andrew Tridgell, Wayne Davison, and others.\n");
-@@ -229,9 +234,9 @@ static void print_rsync_version(enum log
- /* Note that this field may not have type ino_t. It depends
- * on the complicated interaction between largefile feature
- * macros. */
-- rprintf(f, " %sinplace, %sIPv6, "
-+ rprintf(f, " %sinplace, %sIPv6, %sSLP, "
- "%d-bit system inums, %d-bit internal inums\n",
-- have_inplace, ipv6,
-+ have_inplace, ipv6, slp,
- (int) (sizeof dumstat->st_ino * 8),
- (int) (sizeof (int64) * 8));
+
+ rprintf(f, "%s version %s protocol version %d%s\n",
+ RSYNC_NAME, RSYNC_VERSION, PROTOCOL_VERSION, subprotocol);
+@@ -614,8 +618,8 @@ static void print_rsync_version(enum logcode f)
+ (int)(sizeof (int64) * 8));
+ rprintf(f, " %ssocketpairs, %shardlinks, %ssymlinks, %sIPv6, batchfiles, %sinplace,\n",
+ got_socketpair, hardlinks, links, ipv6, have_inplace);
+- rprintf(f, " %sappend, %sACLs, %sxattrs, %siconv, %ssymtimes\n",
+- have_inplace, acls, xattrs, iconv, symtimes);
++ rprintf(f, " %sappend, %sACLs, %sxattrs, %siconv, %ssymtimes, %sSLP\n",
++ have_inplace, acls, xattrs, iconv, symtimes, slp);
+
#ifdef MAINTAINER_MODE
---- orig/rsync.h 2006-02-03 20:00:36
-+++ rsync.h 2006-02-02 00:00:00
-@@ -154,6 +154,9 @@
+ rprintf(f, "Panic Action: \"%s\"\n", get_panic_action());
+diff --git a/rsync.h b/rsync.h
+--- a/rsync.h
++++ b/rsync.h
+@@ -199,6 +199,10 @@
#define SIGNIFICANT_ITEM_FLAGS (~(\
ITEM_BASIS_TYPE_FOLLOWS | ITEM_XNAME_FOLLOWS | ITEM_LOCAL_CHANGE))
+/* this is the minimum we'll use, irrespective of config setting */
+/* definately don't set to less than about 30 seconds */
+#define SLP_MIN_TIMEOUT 120
-
- /* Log-message categories. Only FERROR and FINFO get sent over the socket.
- * FLOG and FCLIENT are only used on the daemon side for custom logging,
---- orig/rsync.yo 2006-02-05 15:31:49
-+++ rsync.yo 2006-02-02 10:44:29
-@@ -137,7 +137,12 @@ particular rsync daemon by leaving off t
++
+ #define CFN_KEEP_DOT_DIRS (1<<0)
+ #define CFN_KEEP_TRAILING_SLASH (1<<1)
+ #define CFN_DROP_TRAILING_DOT_DIR (1<<2)
+diff --git a/rsync.yo b/rsync.yo
+--- a/rsync.yo
++++ b/rsync.yo
+@@ -148,7 +148,12 @@ particular rsync daemon by leaving off the module name:
quote(tt(rsync somehost.mydomain.com::))
manpagesection(ADVANCED USAGE)
---- orig/rsyncd.conf 2006-02-02 00:00:00
-+++ rsyncd.conf 2006-02-02 00:00:00
+diff --git a/rsyncd.conf b/rsyncd.conf
+new file mode 100644
+--- /dev/null
++++ b/rsyncd.conf
@@ -0,0 +1,3 @@
+
+slp refresh = 300
+
---- orig/rsyncd.conf.yo 2006-02-03 20:00:36
-+++ rsyncd.conf.yo 2006-02-02 10:40:24
-@@ -119,6 +119,15 @@ details on some of the options you may b
- special socket options are set. These settings are superseded by the
- bf(--sockopts) command-line option.
+diff --git a/rsyncd.conf.yo b/rsyncd.conf.yo
+--- a/rsyncd.conf.yo
++++ b/rsyncd.conf.yo
+@@ -120,6 +120,15 @@ details on some of the options you may be able to set. By default no
+ special socket options are set. These settings can also be specified
+ via the bf(--sockopts) command-line option.
-+dit(bf(slp refresh)) This option is used to determine how long service
++dit(bf(slp refresh)) This parameter is used to determine how long service
+advertisements are valid (measured in seconds), and is only applicable if
-+you have Service Location Protocol support compiled in. If this option is
++you have Service Location Protocol support compiled in. If this is
+not set or is set to zero, then service advertisements never time out. If
+this is set to less than 120 seconds, then 120 seconds is used. If it is
+set to more than 65535, then 65535 is used (which is a limitation of SLP).
+
enddit()
-
-@@ -541,6 +550,7 @@ use chroot = no
+ manpagesection(MODULE PARAMETERS)
+@@ -768,6 +777,7 @@ use chroot = yes
max connections = 4
syslog facility = local5
pid file = /var/run/rsyncd.pid
+slp refresh = 3600
[ftp]
- path = /var/ftp/pub
---- orig/socket.c 2006-02-03 20:00:36
-+++ socket.c 2006-02-02 10:28:15
-@@ -447,6 +447,14 @@ void start_accept_loop(int port, int (*f
+ path = /var/ftp/./pub
+diff --git a/socket.c b/socket.c
+--- a/socket.c
++++ b/socket.c
+@@ -515,6 +515,16 @@ void start_accept_loop(int port, int (*fn)(int, int))
{
fd_set deffds;
int *sp, maxfd, i;
++#ifdef HAVE_LIBSLP
+ time_t next_slp_refresh;
+ short slp_timeout = lp_slp_refresh();
+ if (slp_timeout) {
+ /* re-register before slp times out */
+ slp_timeout -= 15;
+ }
++#endif
#ifdef HAVE_SIGACTION
sigact.sa_flags = SA_NOCLDSTOP;
-@@ -475,14 +483,20 @@ void start_accept_loop(int port, int (*f
+@@ -543,14 +553,25 @@ void start_accept_loop(int port, int (*fn)(int, int))
maxfd = sp[i];
}
++#ifdef HAVE_LIBSLP
+ next_slp_refresh = time(NULL) + slp_timeout;
++#endif
+
/* now accept incoming connections - forking a new process
* for each incoming connection */
pid_t pid;
int fd;
+ int sel_ret;
-+ struct timeval slp_tv;
struct sockaddr_storage addr;
socklen_t addrlen = sizeof addr;
++#ifdef HAVE_LIBSLP
++ struct timeval slp_tv;
++
+ slp_tv.tv_sec = 10;
+ slp_tv.tv_usec = 0;
++#endif
/* close log file before the potentially very long select so
* file can be trimmed by another process instead of growing
-@@ -494,8 +508,13 @@ void start_accept_loop(int port, int (*f
- #else
+@@ -563,7 +584,18 @@ void start_accept_loop(int port, int (*fn)(int, int))
fds = deffds;
#endif
--
-- if (select(maxfd + 1, &fds, NULL, NULL, NULL) != 1)
-+ sel_ret = select(maxfd + 1, &fds, NULL, NULL, slp_timeout ? &slp_tv: NULL);
+
+- if (select(maxfd + 1, &fds, NULL, NULL, NULL) < 1)
++#ifdef HAVE_LIBSLP
++ sel_ret = select(maxfd + 1, &fds, NULL, NULL,
++ slp_timeout ? &slp_tv : NULL);
+ if (sel_ret == 0 && slp_timeout && time(NULL) > next_slp_refresh) {
-+ rprintf(FINFO, "Service registration expired, refreshing it\n");
-+ register_services();
-+ next_slp_refresh = time(NULL) + slp_timeout;
++ rprintf(FINFO, "Service registration expired, refreshing it\n");
++ register_services();
++ next_slp_refresh = time(NULL) + slp_timeout;
+ }
-+ if (sel_ret != 1)
++#else
++ sel_ret = select(maxfd + 1, &fds, NULL, NULL, NULL);
++#endif
++ if (sel_ret < 1)
continue;
for (i = 0, fd = -1; sp[i] >= 0; i++) {
---- orig/srvloc.c 2006-02-02 11:19:54
-+++ srvloc.c 2006-02-02 11:19:54
-@@ -0,0 +1,105 @@
+diff --git a/srvloc.c b/srvloc.c
+new file mode 100644
+--- /dev/null
++++ b/srvloc.c
+@@ -0,0 +1,103 @@
+/* -*- c-file-style: "linux"; -*-
+
+ Copyright (C) 2002 by Brad Hards <bradh@frogmouth.net>
+ char *cleanstr;
+
+ if (errcode == SLP_OK) {
-+ if (!strcmp(attrlist, "(comment=)")) {
++ if (!strcmp(attrlist, "(comment=)"))
+ rprintf(FINFO, "\t(No description)\n");
-+ } else {
++ else {
+ cleanstr = strrchr(attrlist, ')') ;
+ *cleanstr = ' '; /* remove last ')' */
+ rprintf(FINFO, "\t%s\n", strchr(attrlist, '=') + 1);
+ return SLP_FALSE;
+}
+
-+SLPBoolean getSLPSrvURLCallback(UNUSED(SLPHandle hslp), const char *srvurl,
-+ UNUSED(unsigned short lifetime), SLPError errcode,
-+ void *cookie)
++static SLPBoolean getSLPSrvURLCallback(UNUSED(SLPHandle hslp),
++ const char *srvurl, UNUSED(unsigned short lifetime),
++ SLPError errcode, void *cookie)
+{
+ SLPError result;
+ SLPHandle attrhslp;
+ SLPClose(attrhslp);
+ }
+ *(SLPError*)cookie = SLP_OK;
-+ } else {
++ } else
+ *(SLPError*)cookie = errcode;
-+ }
-+
+
+ /* Return SLP_TRUE because we want to be called again
+ * if more services were found. */
+
+ return 0;
+}
---- orig/srvreg.c 2006-02-02 11:20:37
-+++ srvreg.c 2006-02-02 11:20:37
+diff --git a/srvreg.c b/srvreg.c
+new file mode 100644
+--- /dev/null
++++ b/srvreg.c
@@ -0,0 +1,128 @@
+/* -*- c-file-style: "linux"; -*-
+
git.samba.org / rsync-patches.git / blobdiff