obnox/wireshark/wip.git
11 years agoFrom Andrew Feren (bug 2462):
stig [Mon, 14 Apr 2008 20:02:45 +0000 (20:02 +0000)]
From Andrew Feren (bug 2462):
Patch to print packet rate.

From me:
Document -x option in man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25024 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Roberto Morro (bug 2416):
stig [Mon, 14 Apr 2008 19:43:39 +0000 (19:43 +0000)]
From Roberto Morro (bug 2416):
Added support for Ethernet SENDER_TSPEC and FLOWSPEC objects according to
draft-ietf-ccamp-ethernet-traffic-parameters-02.
Added support for enhancements in the LSP_TUNNEL_INTERFACE_ID object according
to draft-ietf-ccamp-lsp-hierarchy-bis-02.
Added support for NOTIFY_REQUEST and RECOVERY_LABEL objects.
Added display filters for some fields of the GENERALIZED_UNI and CALL_ID
objects.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25023 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThe unknown value (aka flags) can take any value
jmayer [Mon, 14 Apr 2008 19:34:05 +0000 (19:34 +0000)]
The unknown value (aka flags) can take any value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25022 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a FIXME
jmayer [Mon, 14 Apr 2008 19:31:36 +0000 (19:31 +0000)]
Add a FIXME

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25021 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of a warning in gcc 4.3: An integer overflow will not cause a sign change
jmayer [Mon, 14 Apr 2008 19:30:35 +0000 (19:30 +0000)]
Get rid of a warning in gcc 4.3: An integer overflow will not cause a sign change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25020 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate the warning flags (suppress one warning that appears with -pedantic)
jmayer [Mon, 14 Apr 2008 19:27:39 +0000 (19:27 +0000)]
Update the warning flags (suppress one warning that appears with -pedantic)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25019 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Philip Frey (bug 2443):
stig [Mon, 14 Apr 2008 19:22:19 +0000 (19:22 +0000)]
From Philip Frey (bug 2443):
Fixed issues from last patch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25018 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoget_profile_name() will always return a valid string.
stig [Mon, 14 Apr 2008 15:20:12 +0000 (15:20 +0000)]
get_profile_name() will always return a valid string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25017 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Jim Young (bug 2212):
sake [Mon, 14 Apr 2008 15:01:34 +0000 (15:01 +0000)]
From Jim Young (bug 2212):

Add the profile name to the title of all the configuration windows.
(this is a rewrite of Jim's patch)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25016 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2456:
jake [Mon, 14 Apr 2008 07:16:37 +0000 (07:16 +0000)]
Fix for bug 2456:
IPv6 multicast MAC address incorrectly resolved to neighborhood discovery.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25015 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Jim Young:
jake [Mon, 14 Apr 2008 06:43:42 +0000 (06:43 +0000)]
From Jim Young:
Within the packet-diameter_3gpp.c module, the call to proto_register_protocol()
comes AFTER the proto_register_field_array() call.
While the delayed call to proto_register_protocol() does not appear to impair the use
of the display filters, it DOES effect the generation of the wireshark-filter man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25014 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago"const static char *" -> "static const char *" to fix build
sfisher [Mon, 14 Apr 2008 03:29:49 +0000 (03:29 +0000)]
"const static char *" -> "static const char *" to fix build

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25013 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoadd stock icons for expert info and flow graph
ulfl [Mon, 14 Apr 2008 02:09:54 +0000 (02:09 +0000)]
add stock icons for expert info and flow graph

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25012 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago#ifdef HAVE_LUA_5_1 the handling of REGISTER_TOOLS_GROUP_NONE
tuexen [Mon, 14 Apr 2008 01:51:15 +0000 (01:51 +0000)]
#ifdef HAVE_LUA_5_1 the handling of REGISTER_TOOLS_GROUP_NONE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25011 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agowe don't need stat_menu.h here
ulfl [Mon, 14 Apr 2008 01:12:29 +0000 (01:12 +0000)]
we don't need stat_menu.h here

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25010 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoclarify the stats_tree menu items
ulfl [Mon, 14 Apr 2008 01:11:07 +0000 (01:11 +0000)]
clarify the stats_tree menu items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25009 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agobe clear that the "multicast stream" stats are about UDP
ulfl [Mon, 14 Apr 2008 01:10:06 +0000 (01:10 +0000)]
be clear that the "multicast stream" stats are about UDP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25008 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoas the "Firewall ACL rules" perfectly fits into a tools menu, and together with the...
ulfl [Mon, 14 Apr 2008 00:10:18 +0000 (00:10 +0000)]
as the "Firewall ACL rules" perfectly fits into a tools menu, and together with the optional lua we have two and as it slightly simplifies the code, make the

Tools

toplevel menu item "permanent".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25007 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoat least use the "open" (and not the save) icon for import
ulfl [Sun, 13 Apr 2008 23:57:14 +0000 (23:57 +0000)]
at least use the "open" (and not the save) icon for import

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25006 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoadd the (optional) possibility to register a stock icon for a stats menu entry
ulfl [Sun, 13 Apr 2008 23:55:32 +0000 (23:55 +0000)]
add the (optional) possibility to register a stock icon for a stats menu entry

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25005 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix splitting MIB/PIB paths in about box for other than win32.
stig [Sun, 13 Apr 2008 22:21:07 +0000 (22:21 +0000)]
Fix splitting MIB/PIB paths in about box for other than win32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25004 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoexport emem_tree_foreach as requested by user
ulfl [Sun, 13 Apr 2008 21:59:39 +0000 (21:59 +0000)]
export emem_tree_foreach as requested by user

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25003 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Giodi Giorgi (bug 2201):
stig [Sun, 13 Apr 2008 21:57:04 +0000 (21:57 +0000)]
From Giodi Giorgi (bug 2201):
Fix dumping of PROTECTION INFO and GENERALIZED UNI according to RFC3471.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25002 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 1603:
jake [Sun, 13 Apr 2008 21:54:07 +0000 (21:54 +0000)]
Fix for bug 1603:
SMPP validity period as relative time interpretation corrected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25001 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoas we can't easily (re)build adns on msvc6, create and use compiler specific dirs...
ulfl [Sun, 13 Apr 2008 21:21:25 +0000 (21:21 +0000)]
as we can't easily (re)build adns on msvc6, create and use compiler specific dirs (e.g. MSVC2005EE/adns) to place the compiler specific dll/lib files into

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25000 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet it compiing on Mac OS X.
tuexen [Sun, 13 Apr 2008 20:11:16 +0000 (20:11 +0000)]
Get it compiing on Mac OS X.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24999 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoadd a comment that the ping code is running in the background (that caused me some...
ulfl [Sun, 13 Apr 2008 18:50:45 +0000 (18:50 +0000)]
add a comment that the ping code is running in the background (that caused me some headache :-)

change the ping packet length, so the last packet will have exactly 100 bytes (at least on Windows)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24998 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agowe can't easily (re)build ADNS on MSVC6, because iphlpapi.h is needed (sic!)
ulfl [Sun, 13 Apr 2008 18:46:47 +0000 (18:46 +0000)]
we can't easily (re)build ADNS on MSVC6, because iphlpapi.h is needed (sic!)
-> so don't do the delete/rebuild on MSVC6 machines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24997 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoattempt to build ADNS on none MSVC6 systems - with the same mechanism as done with...
ulfl [Sun, 13 Apr 2008 17:58:04 +0000 (17:58 +0000)]
attempt to build ADNS on none MSVC6 systems - with the same mechanism as done with ZLIB

Unfortunately, both dep and rc files need to be patched, so I added the patched files

It's an ugly solution but it seems to work ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24996 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAllow the folders in the About Wireshark/Folders list to be double clicked on to...
gal [Sun, 13 Apr 2008 17:48:47 +0000 (17:48 +0000)]
Allow the folders in the About Wireshark/Folders list to be double clicked on to open the appropriate folder in explorer.

The MIB/PIB paths have been split up to allow each one to be clicked on separately, but as a result this will lose the order if the whole list is reordered.

XXX: I have been unable to test this on MacOS or Linux. Stig? :-)
I suppose it should work, but we may need to make it WIN32 specific?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24995 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInitialize linelen to avoid a warning.
stig [Sun, 13 Apr 2008 16:58:57 +0000 (16:58 +0000)]
Initialize linelen to avoid a warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24994 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInitialize conversation.
stig [Sun, 13 Apr 2008 16:55:56 +0000 (16:55 +0000)]
Initialize conversation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24993 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix the crash from bug 2432. I don't really like that we use a new tvb
stig [Sun, 13 Apr 2008 16:42:41 +0000 (16:42 +0000)]
Fix the crash from bug 2432.  I don't really like that we use a new tvb
and a new data source for displaying unaligned octet strings, because the
user cannot easily see where in the data package the values are from.

Maybe we should implement a "Packet Bits" pane for bit protocols?
Or just an option to turn the Bytes pane to a Bits pane?

Another problem is that the generated pdml (from the bug report) does not
generate correct data for these fields, as the "pos" value is always zero
(because we use a new tvb with offset 0).  But I suppose it's difficult to
fix this with byte values...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24992 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSupport for some additionl heading fields and the display of the (non-MIME) message...
gal [Sun, 13 Apr 2008 16:38:01 +0000 (16:38 +0000)]
Support for some additionl heading fields and the display of the (non-MIME) message text.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24991 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSupport for the reassembly dissection of IMF/MIME messages retrieved over POP using...
gal [Sun, 13 Apr 2008 16:36:41 +0000 (16:36 +0000)]
Support for the reassembly dissection of IMF/MIME messages retrieved over POP using the RETR and TOP commands.

The reassembly is, as usual, a preference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24990 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSupport for RFC 2920 SMTP Command Pipelining.
gal [Sun, 13 Apr 2008 16:33:44 +0000 (16:33 +0000)]
Support for RFC 2920 SMTP Command Pipelining.
The client can send multiple requests before waiting for responses.
Multiple requests/responses are delimited in the info column using  " | ".

Also changed to using "C:" (client) and "S:" (server) to save space in the info column and align with examples in RFC 2821.

Lack of support for PIPELINING was shown up during Sake's session at SharkFest08!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24989 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRenamed image/win32-file-dlg.rc to image/file_dlg_win32.rc
stig [Sun, 13 Apr 2008 16:21:22 +0000 (16:21 +0000)]
Renamed image/win32-file-dlg.rc to image/file_dlg_win32.rc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24988 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved #defined preference grouping
gal [Sun, 13 Apr 2008 16:21:08 +0000 (16:21 +0000)]
Removed #defined preference grouping

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24987 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoval of #defined preference grouping and tidy up agreement id.
gal [Sun, 13 Apr 2008 16:20:12 +0000 (16:20 +0000)]
Removal of #defined preference grouping and tidy up agreement id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24986 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove #defined preference grouping
gal [Sun, 13 Apr 2008 16:18:40 +0000 (16:18 +0000)]
Remove #defined preference grouping

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24985 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSupport for RFC 4530 - LDAP entryUUID attribute.
gal [Sun, 13 Apr 2008 16:14:03 +0000 (16:14 +0000)]
Support for RFC 4530 -  LDAP entryUUID attribute.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24984 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHandling of ROS Rejects.
gal [Sun, 13 Apr 2008 16:11:15 +0000 (16:11 +0000)]
Handling of ROS Rejects.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24983 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAnnotate the presentation context identifier with the presentation context.
gal [Sun, 13 Apr 2008 16:08:34 +0000 (16:08 +0000)]
Annotate the presentation context identifier with the presentation context.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24982 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agodisable ADNS stuff for now
ulfl [Sun, 13 Apr 2008 15:20:00 +0000 (15:20 +0000)]
disable ADNS stuff for now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24981 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofix a comment
ulfl [Sun, 13 Apr 2008 15:10:59 +0000 (15:10 +0000)]
fix a comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24980 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoupdate some prerequisites
ulfl [Sun, 13 Apr 2008 15:09:34 +0000 (15:09 +0000)]
update some prerequisites

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24979 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofirst preparations to build ADNS_DLL
ulfl [Sun, 13 Apr 2008 14:45:43 +0000 (14:45 +0000)]
first preparations to build ADNS_DLL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24978 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoit's color_utils.h
ulfl [Sun, 13 Apr 2008 13:47:52 +0000 (13:47 +0000)]
it's color_utils.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24977 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofixes related to file_dlg_win32.rc
ulfl [Sun, 13 Apr 2008 13:45:50 +0000 (13:45 +0000)]
fixes related to file_dlg_win32.rc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24976 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agochange all preferences related filenames from xy_prefs to prefs_xy
ulfl [Sun, 13 Apr 2008 13:10:32 +0000 (13:10 +0000)]
change all preferences related filenames from xy_prefs to prefs_xy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24975 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove all code from color.c into color_utils.c
ulfl [Sun, 13 Apr 2008 12:41:22 +0000 (12:41 +0000)]
move all code from color.c into color_utils.c
remove color.c
rename colors.h into color_utils.h (hopefully this reduces confusion to /color.h)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24974 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agotext_page -> text_page_utils
ulfl [Sun, 13 Apr 2008 12:24:57 +0000 (12:24 +0000)]
text_page -> text_page_utils

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24973 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agouse the ending "_win32" for every windows specific file
ulfl [Sun, 13 Apr 2008 12:14:57 +0000 (12:14 +0000)]
use the ending "_win32" for every windows specific file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24972 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agosort entries, update Visual Studio (ghost) project
ulfl [Sun, 13 Apr 2008 11:55:20 +0000 (11:55 +0000)]
sort entries, update Visual Studio (ghost) project

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24971 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd IPv6 multicast support.
jake [Sun, 13 Apr 2008 11:42:06 +0000 (11:42 +0000)]
Add IPv6 multicast support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24970 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agosort #includes by directories
ulfl [Sun, 13 Apr 2008 03:32:24 +0000 (03:32 +0000)]
sort #includes by directories

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24969 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agosort #includes by directories
ulfl [Sun, 13 Apr 2008 01:54:20 +0000 (01:54 +0000)]
sort #includes by directories

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24968 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agosort #includes by directories
ulfl [Sun, 13 Apr 2008 00:55:59 +0000 (00:55 +0000)]
sort #includes by directories

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24967 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoList tap_dfilter_dlg.h here, as it's in the gtk directory.
guy [Sat, 12 Apr 2008 23:52:41 +0000 (23:52 +0000)]
List tap_dfilter_dlg.h here, as it's in the gtk directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24966 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2452:
jake [Sat, 12 Apr 2008 23:45:25 +0000 (23:45 +0000)]
Fix for bug 2452:
Tighten heuristics on DirectPlay player to player messages, so that RTP isn't mistaken as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24965 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agovarious code cleanup
ulfl [Sat, 12 Apr 2008 23:34:44 +0000 (23:34 +0000)]
various code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24964 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Mike Davies (bug 2454):
stig [Sat, 12 Apr 2008 22:20:23 +0000 (22:20 +0000)]
From Mike Davies (bug 2454):
Include support for RTCP extended reports containing block type 8
as defined in RFC5093.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24963 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInclude string.h
stig [Sat, 12 Apr 2008 22:17:29 +0000 (22:17 +0000)]
Include string.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24962 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove "airpcap toolbar" code from main.c into new file(s) main_airpcap_toolbar
ulfl [Sat, 12 Apr 2008 22:14:42 +0000 (22:14 +0000)]
move "airpcap toolbar" code from main.c into new file(s) main_airpcap_toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24961 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove "filter toolbar" code from main.c into new file(s) main_filter_toolbar
ulfl [Sat, 12 Apr 2008 21:44:50 +0000 (21:44 +0000)]
move "filter toolbar" code from main.c into new file(s) main_filter_toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24960 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAnd remove tap_dfilter_dlg.h
stig [Sat, 12 Apr 2008 21:36:45 +0000 (21:36 +0000)]
And remove tap_dfilter_dlg.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24959 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a stub set_capture_if_dialog_for_capture_in_progress() routine when
guy [Sat, 12 Apr 2008 21:30:38 +0000 (21:30 +0000)]
Add a stub set_capture_if_dialog_for_capture_in_progress() routine when
HAVE_LIBPCAP isn't defined, as it's called even when it's not defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24958 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClean up indentation.
guy [Sat, 12 Apr 2008 21:28:49 +0000 (21:28 +0000)]
Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24957 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove tap_dfilter_dlg.h from / to /gtk (and use the callback mechanism in main.c instead)
ulfl [Sat, 12 Apr 2008 20:31:18 +0000 (20:31 +0000)]
move tap_dfilter_dlg.h from / to /gtk (and use the callback mechanism in main.c instead)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24956 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemoved menu.h
stig [Sat, 12 Apr 2008 20:16:00 +0000 (20:16 +0000)]
Removed menu.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24955 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoproto_draw -> main_proto_draw
ulfl [Sat, 12 Apr 2008 20:11:12 +0000 (20:11 +0000)]
proto_draw -> main_proto_draw

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24954 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSome packet_list.h -> main_packet_list.h changes.
stig [Sat, 12 Apr 2008 19:59:05 +0000 (19:59 +0000)]
Some packet_list.h -> main_packet_list.h changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24953 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReintroduced save of column width in main_packet_list.[ch],
stig [Sat, 12 Apr 2008 19:53:54 +0000 (19:53 +0000)]
Reintroduced save of column width in main_packet_list.[ch],
accidentally removed in r24950.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24952 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClean up indentation.
guy [Sat, 12 Apr 2008 19:49:43 +0000 (19:49 +0000)]
Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24951 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agorename packet_list to main_packet_list
ulfl [Sat, 12 Apr 2008 19:38:29 +0000 (19:38 +0000)]
rename packet_list to main_packet_list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24950 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded an option to save column widths in the recent file.
stig [Sat, 12 Apr 2008 19:37:05 +0000 (19:37 +0000)]
Added an option to save column widths in the recent file.

Not 100% implemented for usage with configuration profiles with
different column layout yet, as this requires some of the recent
values to be saved in each profile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24949 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove noinst_HEADERS and EXTRA_DIST settings from Makefile.am to Makefile.common as...
ulfl [Sat, 12 Apr 2008 19:24:25 +0000 (19:24 +0000)]
move noinst_HEADERS and EXTRA_DIST settings from Makefile.am to Makefile.common as it's done in /Makefile.common and elsewhere

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24948 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agorename menu -> main_menu
ulfl [Sat, 12 Apr 2008 19:18:26 +0000 (19:18 +0000)]
rename menu -> main_menu
remove old (and unused and confusing) ../menu.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24947 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agovarious code cleanup, e.g. replace specific callback functions by "compounds" that...
ulfl [Sat, 12 Apr 2008 18:28:01 +0000 (18:28 +0000)]
various code cleanup, e.g. replace specific callback functions by "compounds" that uses an action value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24946 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFetch return from g_list_remove.
stig [Sat, 12 Apr 2008 18:15:10 +0000 (18:15 +0000)]
Fetch return from g_list_remove.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24945 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Jonas Nilsson:
etxrab [Sat, 12 Apr 2008 17:09:20 +0000 (17:09 +0000)]
From   Jonas Nilsson:
Add exports for packet-gsm_a decoding functions in libwireshark.def
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2427

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24944 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agocleanup of "capture_in_progress" ugly hack from main_toolbar, call capture_if_dlg...
ulfl [Sat, 12 Apr 2008 17:04:21 +0000 (17:04 +0000)]
cleanup of "capture_in_progress" ugly hack from main_toolbar, call capture_if_dlg directly from within main.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24943 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Michael McCartney:
etxrab [Sat, 12 Apr 2008 17:00:41 +0000 (17:00 +0000)]
From   Michael McCartney:
patch for tvb_get_bits16 not to read past end of buffer
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2439

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24942 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInclude unistd.h, fix prototyping of static functions and mark some
stig [Sat, 12 Apr 2008 16:47:46 +0000 (16:47 +0000)]
Include unistd.h, fix prototyping of static functions and mark some
unused arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24941 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agorename toolbar to main_toolbar
ulfl [Sat, 12 Apr 2008 16:38:13 +0000 (16:38 +0000)]
rename toolbar to main_toolbar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24940 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMark some unused arguments.
stig [Sat, 12 Apr 2008 16:35:28 +0000 (16:35 +0000)]
Mark some unused arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24939 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoremove unrequired "references" to gtkglobals.h
ulfl [Sat, 12 Apr 2008 16:09:22 +0000 (16:09 +0000)]
remove unrequired "references" to gtkglobals.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24938 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove statusbar related code from main.c into it's own main_statusbar.c
ulfl [Sat, 12 Apr 2008 15:55:27 +0000 (15:55 +0000)]
move statusbar related code from main.c into it's own main_statusbar.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24937 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoimprove the "simple" callback mechanism, so more than one listener is possible
ulfl [Sat, 12 Apr 2008 15:16:52 +0000 (15:16 +0000)]
improve the "simple" callback mechanism, so more than one listener is possible

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24936 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Martin Peylo (bug 2245):
stig [Sat, 12 Apr 2008 14:53:48 +0000 (14:53 +0000)]
From Martin Peylo (bug 2245):
I'm providing a patch for the asn2wrs cmp.cnf file showing the types of the
PKIBody and  PKIStatus in the info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24935 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Andrew Feren (bug 2433):
stig [Sat, 12 Apr 2008 14:08:19 +0000 (14:08 +0000)]
From Andrew Feren (bug 2433):
Add support for port ranges in services.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24934 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Marton Nemeth (bug 2447):
stig [Sat, 12 Apr 2008 13:56:28 +0000 (13:56 +0000)]
From Marton Nemeth (bug 2447):
In help the not all of the following chapters begins with uppercase:

10.4.1. saving capture files
10.4.2. obtaining dissection data
10.4.3. GUI support
10.4.4. post-dissection packet analysis
10.4.5. obtaining packet information
10.4.6. functions for writing dissectors
10.4.7. adding information to the dissection tree
10.4.8. functions for handling packet data
10.4.9. Utility Functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24933 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Jesus Roman (bug 2431):
stig [Sat, 12 Apr 2008 13:41:53 +0000 (13:41 +0000)]
From Jesus Roman (bug 2431):
The decoded value of Size Packet shown as "From the calling DTE" is the value
of "From the called DTE".

When the size packet to negotiate has any of 512, 1024, 2048 or 4096 bytes, the
value shown decoded is erroneus.

The patch attached also includes new decoded facilities:

- Extended CUG selection.
- Extended access outgoing CUG selection.
- Extended RPOA selection.
- NUI selection.

- Charging info selection.
- Call dureation.
- Segment Count.
- Monetary Unit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24932 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Philip Frey (bug 2443):
stig [Sat, 12 Apr 2008 12:46:30 +0000 (12:46 +0000)]
From Philip Frey (bug 2443):
Add new dissectors for the iWARP protocol stack.
The code can handle the following 3 protocols:
- MPA
- DDP
- RDMAP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24931 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Philip Frey (bug 2420):
stig [Sat, 12 Apr 2008 12:31:53 +0000 (12:31 +0000)]
From Philip Frey (bug 2420):
Merge of the CRC32C calculation out of packet-iscsi.c and packet-sctp.c
into the already existing crc32.c and crc32.h files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24930 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Stephen Donnelly (bug 2359):
sake [Sat, 12 Apr 2008 10:21:51 +0000 (10:21 +0000)]
From Stephen Donnelly (bug 2359):

- add support for ERF files created with a snaplength
- tighten heuristics (rlen>=16, time_delta < 1 week)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24929 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Andrew Ferren (big 2434):
sake [Sat, 12 Apr 2008 09:35:48 +0000 (09:35 +0000)]
From Andrew Ferren (big 2434):

While borrowing code from an other dissector I have worked on I realized I
previously "borrowed" a comment and typo.  Here's a fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24928 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomove drag_and_drop declarations into it's own file
ulfl [Sat, 12 Apr 2008 09:33:59 +0000 (09:33 +0000)]
move drag_and_drop declarations into it's own file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24927 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Mark C. Brown:
jake [Sat, 12 Apr 2008 09:23:35 +0000 (09:23 +0000)]
From Mark C. Brown:
Added support for HPVM (Integrity Virtual Machines) guest AVIO (Accelerated Virtual IO)
driver IGSSN and 2nd generation 10 Gigabit Ethernet adapter AD386A driver ICXGBE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24926 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoPRIMARY_TEXT_START and PRIMARY_TEXT_END are gone; use
guy [Sat, 12 Apr 2008 03:02:23 +0000 (03:02 +0000)]
PRIMARY_TEXT_START and PRIMARY_TEXT_END are gone; use
simple_dialog_primary_start() and simple_dialog_primary_end() instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24925 f5534014-38df-0310-8fa8-9805f1628bb7