guy [Fri, 5 Jun 2009 22:42:47 +0000 (22:42 +0000)]
Have tap listeners specify whether the "packet" routine requires
a protocol tree;
the column values.
This includes stats-tree listeners.
Have the routines to build the packet list, and to retap packets, honor
those requirements. This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.
This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.
While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.
Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.
Clean up some indentation and some gboolean vs. gint items.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28645
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 5 Jun 2009 19:12:30 +0000 (19:12 +0000)]
And again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28644
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 5 Jun 2009 19:04:05 +0000 (19:04 +0000)]
Use time_stat_init() to initialize the statistics for procedures.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28643
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 5 Jun 2009 13:33:18 +0000 (13:33 +0000)]
* Fix name of Irene in AUTHORS.
* Add Varun Notibala to AUTHORS.
* Add support for NR-SACK and fix stability problems.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28642
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Fri, 5 Jun 2009 12:04:24 +0000 (12:04 +0000)]
Microsoft PKCS#12 local machine keyset bag attribute
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28641
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 4 Jun 2009 17:37:48 +0000 (17:37 +0000)]
From Jakub Zawadzki:
Fix edonkey dissector a little, by using gint type for tvb_length_remaining() result.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28640
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Thu, 4 Jun 2009 15:10:28 +0000 (15:10 +0000)]
Show total number of frames, UEs in stats window title.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28639
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Thu, 4 Jun 2009 15:08:56 +0000 (15:08 +0000)]
Fix typos, and make filter strings more consistent.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28638
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 4 Jun 2009 14:23:30 +0000 (14:23 +0000)]
Changed expert infos from PI_DEBUG to PI_UNDECODED for Lua errors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28637
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 4 Jun 2009 14:22:16 +0000 (14:22 +0000)]
Added missing PI_DEBUG to expert_group_vals[].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28636
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 4 Jun 2009 12:27:09 +0000 (12:27 +0000)]
Fix Windows build warning:
cl : Command line warning D9024 : unrecognized source file type 'ascend-grammar.h', object file assumed
cl : Command line warning D9027 : source file 'ascend-grammar.h' ignored
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28635
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Thu, 4 Jun 2009 08:30:03 +0000 (08:30 +0000)]
A segmented DATA SPDU sequence of length one has user information.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28634
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 4 Jun 2009 08:21:51 +0000 (08:21 +0000)]
From Sam Roberts:
The value_string_from_table()'s use of the lua stack is not balanced,
if a table is iterated, it pops one more time than it should.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28633
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 3 Jun 2009 22:58:07 +0000 (22:58 +0000)]
To quote the Wikipedia entry for the University of Duisburg-Essen, "In
2003 the Gerhard-Mercator-University and the University of Essen merged
to the University of Duisburg-Essen.", so the two entries for Thomas
Dreibholz are probably for the same person; merge them.
teluna.org is the site for a Joost Damad and an Isabelle Marien, and
following the links to his blog indicates that he's a Debian user and at
least uses openMSX. A search for Joost Yervante Damad also finds a
recommendation to accept a Joost Yervante Damad as a Debian developer;
he says he maintains openMSX and is "a software developer and integrator
for a large multinational". My guess is that said large multinational
is Siemens, so I'm assuming the two Joost Yervante Damad entries are for
the same person.
That leaves the two Thomas Palmers; they might be the same person, but
it's conceivable that they're not, so I'll do a bit more digging before
combining those entries.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28632
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 3 Jun 2009 22:13:53 +0000 (22:13 +0000)]
Eliminate some duplicate entries. If the e-mail addresses are the same,
it's an obvious duplicate; if the addresses are in the same domain, it's
almost certainly a duplicate; if the addresses are in different domains,
but one company bought some of the product line for another company, we
assume it's a duplicate (e.g., we presume Martijn Schipper moved from
Intersil to GlobespanVirata when Intersil sold the PRISM 802.11 chipset
lines to GlobespanVirata, although he now appears to be at Magna Carta).
This still leaves Joost Yervante Damad, Thomas Dreibholz, and Thomas
Palmer as duplicates - probably the same people, but I'll ask The Great
Gazoogle a few questions first.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28631
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 3 Jun 2009 20:46:15 +0000 (20:46 +0000)]
Merge another author entry.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28630
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 3 Jun 2009 19:17:35 +0000 (19:17 +0000)]
Unit is now ms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28629
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 3 Jun 2009 19:03:56 +0000 (19:03 +0000)]
Remove duplicate CAPWAP dissector author.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28628
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 3 Jun 2009 18:54:48 +0000 (18:54 +0000)]
Correct error dialog with correct tap name.
Cleanup source code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28627
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 3 Jun 2009 18:41:40 +0000 (18:41 +0000)]
Add CAPWAP dissector author.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28626
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 15:40:12 +0000 (15:40 +0000)]
Don't reuse lua_dir in a for loop.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28625
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 15:28:30 +0000 (15:28 +0000)]
Fixed setting of LUA_INCLUDES when having extraneous lua heder directory.
Fixed resetting flags after negative check for Lua.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28624
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 13:45:48 +0000 (13:45 +0000)]
Only give a failure message if configuring with --with-lua=yes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28623
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 13:21:48 +0000 (13:21 +0000)]
Added check for extraneous lua header directories, as some systems
apparently put the headers in a "lua5.1" subdirectory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28622
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 12:13:07 +0000 (12:13 +0000)]
Use liblua by default, if available.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28621
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 10:38:07 +0000 (10:38 +0000)]
Fixed bit position for wlan_mgt.fixed.delba.param.initiator.
This fixes bug 3505.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28620
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 3 Jun 2009 09:57:22 +0000 (09:57 +0000)]
Added a preference to define more udp ports to use for TFTP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28619
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Wed, 3 Jun 2009 06:38:21 +0000 (06:38 +0000)]
Fix pod errors in man pods.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28618
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 23:14:19 +0000 (23:14 +0000)]
If no valid packages was found in the input file we write an empty
header in the output file. This way we at least create a file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28617
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 22:02:13 +0000 (22:02 +0000)]
Escape ? in echo text the Windows way ....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28616
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 2 Jun 2009 21:44:00 +0000 (21:44 +0000)]
Remove the module globals.
Clean up the source code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28615
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 20:59:48 +0000 (20:59 +0000)]
Optimized check if file is a nstrace file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28614
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 20:57:57 +0000 (20:57 +0000)]
Fix some small memory leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28613
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 20:16:23 +0000 (20:16 +0000)]
Fix a small memory leak
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28612
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 2 Jun 2009 20:01:01 +0000 (20:01 +0000)]
Fix "tap-rtp-common.c:440: warning: ‘current_diff’ may be used uninitialized in this function"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28611
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 19:41:35 +0000 (19:41 +0000)]
Do find_dissector_handles once-only in proto_reg_handoff...
lenght ==> length in a few places;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28610
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 19:35:45 +0000 (19:35 +0000)]
Fixed the type for key_len in dissect_key().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28609
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 19:16:08 +0000 (19:16 +0000)]
io_stat save & filewall rule save: rework "save dialog" slightly:
- Prevent "dead" save-as window if error opening/writing file
or if a directory is entered as the filename;
Work-around is to always kill save-as window whether success
or an error causing alert-box popup;
- Enable "check for file overwrite" (if GTK 2.8 or greater);
- Fix some memory leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28608
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 2 Jun 2009 19:06:05 +0000 (19:06 +0000)]
When doing a seek-and-read, don't check the packet size, as we don't
have it (we have the size with the pseudo-header length already
removed); we've already read the packet, and thus have already checked
it. Fixes bug 3501.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28607
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 2 Jun 2009 19:05:20 +0000 (19:05 +0000)]
Calculate skew and clock drift, make it possible to copy the label.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28606
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 18:47:36 +0000 (18:47 +0000)]
From Graham Bloice via bug 3504:
Fix concurrent name resolution for c-ares.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28605
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 18:47:20 +0000 (18:47 +0000)]
packet_hip: (Minor): Remove unused data_handle; move proto_register... to just before proto_reg-handoff...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28604
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 18:39:38 +0000 (18:39 +0000)]
From Alexis La Goutte via bug 3488:
Add support for decoding CAPWAP Control Packet (RFC5415)
From me:
Adjusted some names.
Some space cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28603
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 17:22:40 +0000 (17:22 +0000)]
Only call wtap_dump_close() if we have an open file.
We can have a situation where a file only contains a valid file header
without any packages, so this will avoid a crash.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28602
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 15:46:55 +0000 (15:46 +0000)]
Rewrote to add IPv6 addresses correctly and rewrote some proto_item_add_bytes()
to avoid using tvb_get_ptr().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28601
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 15:39:20 +0000 (15:39 +0000)]
follow_stream: Enable "check for file overwrite" (if GTK 2.8 or greater);
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28600
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 2 Jun 2009 15:34:17 +0000 (15:34 +0000)]
Decode SCCP cause values in SUA (using value_strings exported from the SCCP
dissector).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28599
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 15:22:33 +0000 (15:22 +0000)]
Removed a unused preference setting, some unused includes and
some unused code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28598
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 2 Jun 2009 15:17:35 +0000 (15:17 +0000)]
rtp_stream_dlg: rework dtp_stream "save as" slightly:
- Prevent "dead" save-as window if error opening/writing file
or if a directory is entered as the filename;
Work-around is to always kill save-as window whether success
or an error causing alert-box popup;
- Enable "check for file overwrite" (if GTK 2.8 or greater);
- Fix some memory leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28597
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 15:10:04 +0000 (15:10 +0000)]
From Samu Varjonen via bug 3378:
Added support for Host Identity Protocol (HIP).
From me:
- Adjusted location of "Checksum" and "HIP Controls", as they seems to have
switched place in the bytes window
- Rewrote some proto_tree_add_uint -> proto_tree_add_item (some still remain)
- Rewrote to not use tvb_memcpy()
- Corrected some proto_tree_add_item's as the format seems to be big-endian
- Terminate ALL value_string's with { 0, NULL }
- No need to zero-terminate value_string strings.
- Removed call to check_col()
- Removed some prototypes
- Removed unused hf_hip_tlv_id, hf_hip_res and hf_hip_tlv_enc_iv (please check)
- Rewrote some C++ comments
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28596
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 14:36:42 +0000 (14:36 +0000)]
Better heuristics for detecting BER encoded file, especially when initial tag is indefinite length encoded.
Checked that the I4B traces reported in http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1972 still loads as expected.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28595
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 11:56:28 +0000 (11:56 +0000)]
Update to install latest WinPcap and silently install/uninstall the Visual C++ 2008 Redistributable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28594
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 11:04:14 +0000 (11:04 +0000)]
Update to:
* support the P3 protocol in addition to the P1 protocol; and
* reduce the number of changes to the ASN.1 modules (as asn2wrs now handles more of the ASN.1 constructs).
P3 is currently only supported over ROS (and not RTSE)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28593
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 10:40:58 +0000 (10:40 +0000)]
From Jim Young (bug 2504):
Quick fix to sync expert_tapdata_s.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28592
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 09:50:09 +0000 (09:50 +0000)]
Small typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28591
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 09:46:03 +0000 (09:46 +0000)]
Support for the Entrust VersionInfo certificate extension
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28590
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 09:44:52 +0000 (09:44 +0000)]
Restore the generation and display of LDAP DNs from RDN components
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28589
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 09:23:48 +0000 (09:23 +0000)]
Corrected nspm_signature_version() again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28588
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 09:20:10 +0000 (09:20 +0000)]
Correct LDAP certificate attribute name
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28587
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 2 Jun 2009 09:17:16 +0000 (09:17 +0000)]
Added support for the UserNotice certificate extension.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28586
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 2 Jun 2009 08:47:45 +0000 (08:47 +0000)]
Avoid infinite loop in nspm_signature_version().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28585
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 2 Jun 2009 07:18:18 +0000 (07:18 +0000)]
No newlines in the additional-error-information string, please.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28584
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 2 Jun 2009 06:37:21 +0000 (06:37 +0000)]
From Matt Deckard:
Add support for the DIS protocol dissector to more fully interpret the PDU
types "Data Query", "Data", and "Set Data". It should interpret the
originating and receiving entity IDs, request ID, number of fixed and variable
datum fields, and the ID and values of each datum field in the PDU.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28583
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Tue, 2 Jun 2009 00:04:55 +0000 (00:04 +0000)]
Unescape telnet suboption data if needed.
This fixes bug 191.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28582
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Mon, 1 Jun 2009 22:41:48 +0000 (22:41 +0000)]
Revert 28580.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28581
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Mon, 1 Jun 2009 22:27:00 +0000 (22:27 +0000)]
Fix dissection of telnet window size suboption.
This fixes bug 191.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28580
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 21:47:45 +0000 (21:47 +0000)]
Try Jakub's casting with GPOINTER_TO_INT().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28579
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 21:26:50 +0000 (21:26 +0000)]
Adding casts, take 3.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28578
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 20:52:53 +0000 (20:52 +0000)]
proto_main_draw: rework packet bytes "save as" slightly:
- Prevent "dead" save-as window if error opening/writing file
or if a directory is entered as the filename;
Work-around is to always kill save-as window whether success
or an error causing alert-box popup;
- Enable "check for file overwrite" (if GTK 2.8 or greater);
- Fix some memory leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28577
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 19:55:57 +0000 (19:55 +0000)]
Adding casts, take 2.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28576
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 19:46:40 +0000 (19:46 +0000)]
Added/Changed some more casts to build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28575
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 19:43:58 +0000 (19:43 +0000)]
follow_stream: rework "save as" slightly:
- Prevent "dead" save-as window if unable to open file for write
or if a directory is entered as the filename;
Work-around is to always kill save-as window whether success
or an error causing alert-box popup;
- Fix a memory leak.
- Define certain functions used only in follow_stream.c as static;
(Remove declarations for them from follow_stream.h)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28574
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 18:50:16 +0000 (18:50 +0000)]
Added some casts to remove some warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28573
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 18:24:42 +0000 (18:24 +0000)]
Removed _U_ for an used argument.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28572
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 18:17:52 +0000 (18:17 +0000)]
Removed some unused hf_ entries.
Renamed filter abbrev from ns. to nstrace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28571
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 18:09:07 +0000 (18:09 +0000)]
Added the wspython Makefile.nmake from bug 3500 to satisfy the
Ubuntu buildbot.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28570
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 17:52:14 +0000 (17:52 +0000)]
Fix a printf to make the label correct.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28569
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 17:42:30 +0000 (17:42 +0000)]
Fix a typo in PYTHON_DIR.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28568
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 17:29:08 +0000 (17:29 +0000)]
(Trivial): remove a comment referring to Gtk 1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28567
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 17:28:20 +0000 (17:28 +0000)]
Fixed a typo in a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28566
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 17:27:54 +0000 (17:27 +0000)]
dfilter_expr_dlg: fix several very minor memory leaks;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28565
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 17:23:38 +0000 (17:23 +0000)]
From Ravi Kondamuru via bug 3457:
Add support to read citrix netscaler capture file format.
From me:
- Renamed packet-ns.c to packet-nstrace.c
- Rewrote to not use "goto" in netscaler.c
- Moved dissecting of coreid
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28564
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 17:08:46 +0000 (17:08 +0000)]
about_dlg: fix a memory leak when double-clicking on a path.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28563
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 17:01:42 +0000 (17:01 +0000)]
wlan_stat: fix a memory leak
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28562
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 1 Jun 2009 16:50:27 +0000 (16:50 +0000)]
For DL-SCH/UL-SCH, show subframe number in info column.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28561
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 1 Jun 2009 16:44:05 +0000 (16:44 +0000)]
Show max and mean Jitter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28560
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 16:01:48 +0000 (16:01 +0000)]
From Kovarththanan Rajaratnam via bug 3482:
Sort display filter list entries by usage.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28559
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 15:54:14 +0000 (15:54 +0000)]
Rename dialog_data_t ==> graph_analysis_dialog_data_t
(so VWindows VC debugger doesn't confuse it with dialog_data_t in rtp_player.c)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28558
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 15:45:42 +0000 (15:45 +0000)]
Remove unneeded #include graph_analysis.h; Add #include gtk/gtk.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28557
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 15:26:15 +0000 (15:26 +0000)]
Popup a dialog in case we match a row outside the loaded frame area.
This adds some information for bug 3429.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28556
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 1 Jun 2009 14:51:09 +0000 (14:51 +0000)]
From Kovarththanan Rajaratnam via bug 3429:
This patch downgrades the g_assert() to a proper if statement. This is needed
because we can end up with a match but _without_ any valid row attached to it.
This is the case when the user has aborted while dissecting.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28555
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 14:00:09 +0000 (14:00 +0000)]
flow_graph & etc: rework graph "save as" slightly:
- Pop up an alert box if unable to open file for write;
- Prevent "dead" save-as window if unable to open file for write
or if a directory is entered as the filename;
- Fix a memory leak.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28554
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 12:32:02 +0000 (12:32 +0000)]
Fix a few more memory leaks & do a few other minor changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28553
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 1 Jun 2009 11:35:52 +0000 (11:35 +0000)]
Fix minor memory leaks; Minor reformatting
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28552
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 31 May 2009 19:55:30 +0000 (19:55 +0000)]
Copy the changes from:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=28534
User: wmeier
Date: 2009/05/30 11:07 AM
Log:
Fix the save_as functions so they work (including work-around when save-as raises an alert box).
Also:
- save_as_csv: don't skip over first line of output;
- save_as_csv: Fix some (probably significant) memory leaks
associated with the use of gtk_tree_view;
- Prevent tendency for IAX2 stream window and graph window
to get lost behind other windows;
- Minor save_as dialog window reformatting;
- Misc source code cleanup & reformatting.
To RTP Analysis.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28551
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 31 May 2009 19:46:31 +0000 (19:46 +0000)]
From yami (bug 3361):
Try to resolve a crash issue when having a function on the RHS
of a filter test which does not return the same type as the LHS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28550
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Sun, 31 May 2009 18:38:28 +0000 (18:38 +0000)]
Set SIGPIPE handler every time the program starts.
This hopefully fixes bug 1740.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28549
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 31 May 2009 18:30:46 +0000 (18:30 +0000)]
Added support for python bindings in the OSX package.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28548
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 31 May 2009 18:30:07 +0000 (18:30 +0000)]
Added Python Bindings directory to the About->Folders listing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28547
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 31 May 2009 17:06:04 +0000 (17:06 +0000)]
Calculate jitter and delta in ms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28546
f5534014-38df-0310-8fa8-
9805f1628bb7