16 years agoGet rid of a now unused variable.
obiot [Wed, 7 Jan 2004 19:52:25 +0000 (19:52 +0000)]
Get rid of a now unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9593 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate the list of OSes and OS versions on which Ethereal is known to
guy [Wed, 7 Jan 2004 19:51:39 +0000 (19:51 +0000)]
Update the list of OSes and OS versions on which Ethereal is known to
work (or inferred to work - some lists were changed to "XXX and later",
on the assumption that later releases didn't break anything).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9592 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a preference that controls the way the SIP version is enforced. By default,
obiot [Wed, 7 Jan 2004 19:49:45 +0000 (19:49 +0000)]
Add a preference that controls the way the SIP version is enforced. By default,
strict enforcement of SIP/2.0 will be applied.

Add some comments.

From Anders Broman:

Fix the length of content_type_parameter_str.

Fix a typo in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9591 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove extraneous parameters of packet count in case the end-user manually
obiot [Wed, 7 Jan 2004 19:10:49 +0000 (19:10 +0000)]
Remove extraneous parameters of packet count in case the end-user manually
enters a range of packets. Comment this in the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9590 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agominor changes
ulfl [Wed, 7 Jan 2004 12:12:09 +0000 (12:12 +0000)]
minor changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9589 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded current windows versions
ulfl [Wed, 7 Jan 2004 12:10:36 +0000 (12:10 +0000)]
added current windows versions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9588 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix some typoes.
guy [Wed, 7 Jan 2004 07:17:47 +0000 (07:17 +0000)]
Fix some typoes.

Give the appropriate locations for libiconv, gettext, and WinPcap.

Note that the WinPcap package is *not* available from ethereal.com.

Explain a bit more about how to unpack the zip files for development

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9587 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe type values from Net-SNMP are u_chars; make the formal argument for
guy [Wed, 7 Jan 2004 05:24:36 +0000 (05:24 +0000)]
The type values from Net-SNMP are u_chars; make the formal argument for
them u_char.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9586 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't assert that quoted_string be NULL; it can be non-NULL if
gram [Wed, 7 Jan 2004 05:24:04 +0000 (05:24 +0000)]
Don't assert that quoted_string be NULL; it can be non-NULL if
the previous dfilter failed to compile because a closing double-quote
was not provided. Handle that case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9585 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't do anything exotic to get signed integral values - Ethereal's
guy [Wed, 7 Jan 2004 05:13:29 +0000 (05:13 +0000)]
Don't do anything exotic to get signed integral values - Ethereal's
dissectors assume a two's-complement machine (we offer our apologies to
those trying to run it on sign-magnitude IBM 7090/7094's and one's
complement Univac/Unisys 11xx machines :-)).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9584 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe year in a LANalyzer capture's trace summary record is a 2-byte year
guy [Wed, 7 Jan 2004 04:50:21 +0000 (04:50 +0000)]
The year in a LANalyzer capture's trace summary record is a 2-byte year

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9583 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse "tvb_get_guint8()", not "tvb_get_ntohs()", to fetch 1-byte numbers.
guy [Wed, 7 Jan 2004 04:33:21 +0000 (04:33 +0000)]
Use "tvb_get_guint8()", not "tvb_get_ntohs()", to fetch 1-byte numbers.

Use "proto_tree_add_item()" if you don't need the number's value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9582 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNot that it really matters as the test still alwas evaluates to false:
jmayer [Wed, 7 Jan 2004 01:44:23 +0000 (01:44 +0000)]
Not that it really matters as the test still alwas evaluates to false:
An array with 256 elements should not be accessed with an index >= 256,
as we do not count as normal people do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9581 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agosave dialog with "Captured" and "Displayed" buttons in packet range
ulfl [Wed, 7 Jan 2004 00:10:52 +0000 (00:10 +0000)]
save dialog with "Captured" and "Displayed" buttons in packet range

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9580 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGPL.txt -> ../../COPYING
jmayer [Tue, 6 Jan 2004 22:52:59 +0000 (22:52 +0000)]
GPL.txt -> ../../COPYING

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9579 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWidgets get freed when the reference count goes to zero; we don't need
guy [Tue, 6 Jan 2004 22:38:07 +0000 (22:38 +0000)]
Widgets get freed when the reference count goes to zero; we don't need
to explicitly destroy menu items when we remove them from the "recent
files" list.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9578 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClear the interface list and free up interface names whenever a new
guy [Tue, 6 Jan 2004 22:05:37 +0000 (22:05 +0000)]
Clear the interface list and free up interface names whenever a new
capture is read.

"interface_anzahl" is always <= MAX_INTERFACES, so we don't need to
check array indices against MAX_INTERFACES when iterating over all known

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9577 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't add an interface to the interface list if we already have
guy [Tue, 6 Jan 2004 21:11:04 +0000 (21:11 +0000)]
Don't add an interface to the interface list if we already have
MAX_INTERFACES interfaces in the list.

Make "found" a gboolean.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9576 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPacket data is an array of "guint8"s, not an array of "char"s; declare
guy [Tue, 6 Jan 2004 20:05:39 +0000 (20:05 +0000)]
Packet data is an array of "guint8"s, not an array of "char"s; declare
variables appropriately.

Put in a cast to squelch MSVC++ warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9575 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the forward declarations of routines and their definitions match.
guy [Tue, 6 Jan 2004 19:56:56 +0000 (19:56 +0000)]
Make the forward declarations of routines and their definitions match.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9574 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd some sanity checking for the "-i" argument.
guy [Tue, 6 Jan 2004 02:58:20 +0000 (02:58 +0000)]
Add some sanity checking for the "-i" argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9573 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake a variable to which a 16-bit value is assigned big enough to hold
guy [Tue, 6 Jan 2004 02:51:13 +0000 (02:51 +0000)]
Make a variable to which a 16-bit value is assigned big enough to hold
such a value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9572 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake some variables to which 16-bit values are assigned wide enough to
guy [Tue, 6 Jan 2004 02:47:40 +0000 (02:47 +0000)]
Make some variables to which 16-bit values are assigned wide enough to
hold those values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9571 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe error code in an NBDS error packet is 1 byte, not 2.
guy [Tue, 6 Jan 2004 02:42:50 +0000 (02:42 +0000)]
The error code in an NBDS error packet is 1 byte, not 2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9570 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn "decode_qos_umts()", "length" can get assigned a 2-byte value, so
guy [Tue, 6 Jan 2004 02:38:03 +0000 (02:38 +0000)]
In "decode_qos_umts()", "length" can get assigned a 2-byte value, so
make it a "guint", not just a "guint8".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9569 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"decode_MPLS_stack()" always returns a nonnegative value; make it return
guy [Tue, 6 Jan 2004 02:29:36 +0000 (02:29 +0000)]
"decode_MPLS_stack()" always returns a nonnegative value; make it return
"guint", and make the "labnum" variable to which its return value is
assigned a "guint".

"plen" in "decode_prefix_MP()" can have a 16-bit value assigned to it;
make it a "guint", not just a "guint8".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9568 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNote in a comment that "dissect_asp_reply_get_status()" might be
guy [Tue, 6 Jan 2004 02:20:32 +0000 (02:20 +0000)]
Note in a comment that "dissect_asp_reply_get_status()" might be
dissecting AFP server status - other servers might have different status

In "dissect_asp_reply_get_status()", put the UTF-8 server name into a
tree, with the length and name in the tree as separate items, and fetch
the length into a 16-bit variable (as it's a 16-bit length in the
packet), as is done in "dissect_dsi_reply_get_status()".  (XXX - should
that just be done with an FT_UINT_STRING field, as is done for other

Use "tvb_get_string()" to fetch the UTF-8 server name, and set the
length and name from the values we fetched, in both of those routines.

For FT_UINT_STRING fields in "dissect_asp_reply_get_status()" and
"dissect_dsi_reply_get_status()", don't fetch the length separately -
just use the value filled in by "proto_tree_add_item()" (now that a
"proto_item" is no longer opaque, we can do that).  That means we don't
have a problem with overflows of the 8-bit "len" variable if the length
is 255.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9567 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of an unused value_string table.
guy [Tue, 6 Jan 2004 00:09:48 +0000 (00:09 +0000)]
Get rid of an unused value_string table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9566 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse "rstat4_proc" rather than "rstat3_proc" for rstat version 4.
guy [Tue, 6 Jan 2004 00:08:55 +0000 (00:08 +0000)]
Use "rstat4_proc" rather than "rstat3_proc" for rstat version 4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9565 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoan enum represents the radio buttons much better,
ulfl [Mon, 5 Jan 2004 22:21:53 +0000 (22:21 +0000)]
an enum represents the radio buttons much better,
than an "array" of gbooleans

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9564 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofixed / updated some dependencies
ulfl [Mon, 5 Jan 2004 21:47:44 +0000 (21:47 +0000)]
fixed / updated some dependencies

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9563 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoswitched to MSVC warning level 3 and
ulfl [Mon, 5 Jan 2004 21:04:42 +0000 (21:04 +0000)]
switched to MSVC warning level 3 and
default is winpcap version 3 now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9562 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved some MSVC warnings (level 3)
ulfl [Mon, 5 Jan 2004 19:31:44 +0000 (19:31 +0000)]
removed some MSVC warnings (level 3)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9561 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved some MSVC warnings (level 3)
ulfl [Mon, 5 Jan 2004 18:11:28 +0000 (18:11 +0000)]
removed some MSVC warnings (level 3)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9560 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Alex Rozin: fix handling of MST messages.
guy [Mon, 5 Jan 2004 17:35:31 +0000 (17:35 +0000)]
From Alex Rozin: fix handling of MST messages.

Fix his e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9559 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago removed some MSVC warnings (level 3)
ulfl [Mon, 5 Jan 2004 17:33:28 +0000 (17:33 +0000)]
 removed some MSVC warnings (level 3)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9558 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agousing the file "COPYING" instead of "GPL.txt"
ulfl [Mon, 5 Jan 2004 17:29:38 +0000 (17:29 +0000)]
using the file "COPYING" instead of "GPL.txt"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9557 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Alex Rozin: fix handling of MST messages.
guy [Mon, 5 Jan 2004 17:26:10 +0000 (17:26 +0000)]
From Alex Rozin: fix handling of MST messages.

Fix his e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9556 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agousing the file "COPYING" instead of "GPL.txt"
ulfl [Mon, 5 Jan 2004 15:27:35 +0000 (15:27 +0000)]
using the file "COPYING" instead of "GPL.txt"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9555 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Roland: corrected PATH settings
ulfl [Mon, 5 Jan 2004 15:05:00 +0000 (15:05 +0000)]
From Lars Roland: corrected PATH settings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9554 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBugfix from Lars Roland: included missing xdlc.h
ulfl [Mon, 5 Jan 2004 15:03:38 +0000 (15:03 +0000)]
Bugfix from Lars Roland: included missing xdlc.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9553 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFor RTSP requests, we assume that, if there's no Content-Length header,
guy [Mon, 5 Jan 2004 03:51:28 +0000 (03:51 +0000)]
For RTSP requests, we assume that, if there's no Content-Length header,
the request has no body.

When displaying the body, use the reported length remaining, not the
captured length remaining, as the length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9552 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHandle non-Unicode error tokens.
guy [Mon, 5 Jan 2004 01:18:53 +0000 (01:18 +0000)]
Handle non-Unicode error tokens.

Error tokens (at least in one capture) appear to have a server name in
them; handle that as well.  (They also appear to have 3 more bytes of
stuff in them.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9551 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv Kaul:
guy [Mon, 5 Jan 2004 00:55:42 +0000 (00:55 +0000)]
From Yaniv Kaul:

add parsing of message token (Unicode and regular);

add parsing of error token (Unicode only - do not have a non Unicode
sample. Anyone?);

add parsing of done token (only minimal actually);

add parsing of Collation Information structure in Environment
Change token.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9550 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv Kaul:
guy [Mon, 5 Jan 2004 00:44:21 +0000 (00:44 +0000)]
From Yaniv Kaul:

add parsing of message token (Unicode and regular);

add parsing of error token (Unicode only - do not have a non Unicode
sample. Anyone?);

add parsing of done token (only minimal actually);

add parsing of Collation Information structure in Environment
Change token.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9549 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Dick Gooris: updated lots of comments
ulfl [Sun, 4 Jan 2004 23:32:34 +0000 (23:32 +0000)]
From Dick Gooris: updated lots of comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9548 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd more information to the WTP protocol summary (PDU type and PDU specific
obiot [Sun, 4 Jan 2004 22:02:16 +0000 (22:02 +0000)]
Add more information to the WTP protocol summary (PDU type and PDU specific
important parameters).

Document the computation of the length field in WTP concatenation after having
looked at a capture with the length field encoded as a WSP uintvar-integer.

Use "common code" for WTP reassembly, by calling process_reassembled_data().
Document the behavior of reassembly as the output of Ethereal differs between
the first and the second pass.

Question: shoud the common reassembly code provide a call-back mechanism to
get access to previously-unreassembled packets that appear to be part of a
reassembled whole, and to be able to update the state and information of
those packets at the time of the reassembly?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9547 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Shiang-Ming Huang: bug fix.
guy [Sun, 4 Jan 2004 20:44:50 +0000 (20:44 +0000)]
From Shiang-Ming Huang: bug fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9546 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove a comment to the appropriate location, and put in another comment
guy [Sun, 4 Jan 2004 20:42:44 +0000 (20:42 +0000)]
Move a comment to the appropriate location, and put in another comment
about problems with handling replies.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9545 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove "XConvertCase()" from a header file to "packet-x11.c".
guy [Sun, 4 Jan 2004 10:57:18 +0000 (10:57 +0000)]
Move "XConvertCase()" from a header file to "packet-x11.c".

Handle the failure reply from the initial connection request.

"proto_item_append_text()" accepts "printf"-like formats; we don't need
to generate a string with a formatting routine and hand it to
"proto_item_append_text()", so don't do so.

When doing reassembly, the length that should be checked is the length
remaining in the tvbuff, not the length remaining in the packet, and
that length should be fetched with "tvb_ensure_length_remaining()" so
that if we *do* go past the end of the tvbuff we throw the appropriate

To determine whether a reply is a reply to the initial connection, check
the connection state and "initial connection reply" frame - don't check
the first byte of the message unless we've determined that the message
isn't an initial connection reply (the first byte of the initial
connection reply is the success/failure flag, so it could be 0 or 1).

Display window IDs in hex in replies, as we do in requests.

Fix the masks for Button3, Button4, and Button5 (it's a bitset, not a
button number - more than one mouse button can be down in an event,
although it can be a pain to try to click more than one button at the
same time).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9544 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUser Specified Decodes, since it brings up a dialog box, should be User Specified...
sharpe [Sun, 4 Jan 2004 06:16:57 +0000 (06:16 +0000)]
User Specified Decodes, since it brings up a dialog box, should be User Specified Decodes...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9543 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoJPEG File Interchange Format (JFIF) dissection.
obiot [Sun, 4 Jan 2004 03:01:27 +0000 (03:01 +0000)]
JPEG File Interchange Format (JFIF) dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9542 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support for JFIF (JPEG File Interchange Format) media.
obiot [Sun, 4 Jan 2004 02:59:46 +0000 (02:59 +0000)]
Add support for JFIF (JPEG File Interchange Format) media.

The JFIF dissector processes everything up to the start of scan as the data
thereafter is encoded and I didn't have the time to figure out how it is :)

TODO: fix the WTP dissector so it doesn't hand off unreassembled data to WSP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9541 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix the multipart dissection in WSP so media embedded in a multipart entity
obiot [Sun, 4 Jan 2004 02:55:03 +0000 (02:55 +0000)]
Fix the multipart dissection in WSP so media embedded in a multipart entity
gets handed off to subdissectors. However nested multipart entities are not
supported yet.

Add more information to the WSP protocol summary line.

Add some more clarifications (comments) in the WSP code.

Skip parsing of URL encoded data if tree is NULL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9540 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoA missing piece of Tadaaki Nagao's patches to add a global "disabled
guy [Sun, 4 Jan 2004 02:24:58 +0000 (02:24 +0000)]
A missing piece of Tadaaki Nagao's patches to add a global "disabled
protocols" file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9539 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply the patches from Tadaaki Nagao for a global version of disabled
sharpe [Sat, 3 Jan 2004 18:40:08 +0000 (18:40 +0000)]
Apply the patches from Tadaaki Nagao for a global version of disabled
protocols ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9538 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake Analyze/Statistics have an accelerator of Alt+A S and move
sharpe [Sat, 3 Jan 2004 18:05:57 +0000 (18:05 +0000)]
Make Analyze/Statistics have an accelerator of Alt+A S and move
Analyze/Summary to Alt+A Y.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9537 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWarning fix: Mark a parameter as unused
jmayer [Sat, 3 Jan 2004 14:08:57 +0000 (14:08 +0000)]
Warning fix: Mark a parameter as unused

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9536 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake XConvertCase static to avoid a warning at link time.
tuexen [Sat, 3 Jan 2004 13:03:02 +0000 (13:03 +0000)]
Make XConvertCase static to avoid a warning at link time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9535 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix an incorrect filterable field name.
obiot [Sat, 3 Jan 2004 12:43:51 +0000 (12:43 +0000)]
Fix an incorrect filterable field name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9534 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAt least with some versions of GCC, the __attribute__((unused)) stuff
guy [Sat, 3 Jan 2004 05:14:08 +0000 (05:14 +0000)]
At least with some versions of GCC, the __attribute__((unused)) stuff
has to come *after* the variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9533 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMark arguments as unused.
guy [Sat, 3 Jan 2004 05:13:12 +0000 (05:13 +0000)]
Mark arguments as unused.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9532 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHave "dissect_xdlc_control()" take a pointer to a structure containing
guy [Sat, 3 Jan 2004 03:51:27 +0000 (03:51 +0000)]
Have "dissect_xdlc_control()" take a pointer to a structure containing
pointers to hf_ values, so the subfields of the control field are put
into the protocol tree as filterable items.  Change the protocols that
use it appropriately.

Export "dissect_xdlc_control()" to plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9531 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoProcess all the data in the packet, regardless of whether it's captured
guy [Sat, 3 Jan 2004 03:43:20 +0000 (03:43 +0000)]
Process all the data in the packet, regardless of whether it's captured
or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9530 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDeal with some weird ISMP packets that have 0x42 0x42 0x03 in front of
guy [Sat, 3 Jan 2004 03:37:26 +0000 (03:37 +0000)]
Deal with some weird ISMP packets that have 0x42 0x42 0x03 in front of
the payload (are they some kind of weird 802.2 header?  0x42 is the SAP
for IEEE 802.1d Spanning Tree BPDUs).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9529 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a comment.
guy [Fri, 2 Jan 2004 23:44:20 +0000 (23:44 +0000)]
Fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9528 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agohide save dialog, while saving
ulfl [Fri, 2 Jan 2004 21:48:24 +0000 (21:48 +0000)]
hide save dialog, while saving

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9527 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix: init progbar to NULL at the right place
ulfl [Fri, 2 Jan 2004 21:47:06 +0000 (21:47 +0000)]
bugfix: init progbar to NULL at the right place

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9526 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded a progressbar, when saving a large capture file
ulfl [Fri, 2 Jan 2004 21:01:40 +0000 (21:01 +0000)]
added a progressbar, when saving a large capture file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9525 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agorecent files: make submenu insensitive if empty and
ulfl [Fri, 2 Jan 2004 17:27:00 +0000 (17:27 +0000)]
recent files: make submenu insensitive if empty and
add a menu item to clear the list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9524 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Didier: don't update the progress bar more often than every 100ms
ulfl [Fri, 2 Jan 2004 13:38:22 +0000 (13:38 +0000)]
From Didier: don't update the progress bar more often than every 100ms

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9523 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Didier: don't update the progress bar more often than every 100ms
ulfl [Fri, 2 Jan 2004 13:27:00 +0000 (13:27 +0000)]
From Didier: don't update the progress bar more often than every 100ms

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9522 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Michael Shuldman: enhanced X11 support.
obiot [Fri, 2 Jan 2004 12:57:26 +0000 (12:57 +0000)]
From Michael Shuldman: enhanced X11 support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9521 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Michael Shuldman:
obiot [Fri, 2 Jan 2004 12:52:45 +0000 (12:52 +0000)]
From Michael Shuldman:

Add support for parsing some X11 replies and events (and
the framework for handling X11 errors it looks like) to the
existing X11 code, which parses X11 requests.

It parses what is the most difficult part of the replies/events,
they Keycode stuff by parsing the Keyboardmapping replies and etc,
and then KeyPress, KeyRelease events and some related stuff (used
for a specific project).

Adding support for parsing the rest of the event/replies should not
be difficult, I think it will mostly consist of going through every
event/reply and add the missing calls for each dataitem i.e.  register
the data, the remaining the eventcodes/replies are pretty
straightforward if I remember correctly.

All events and replies are reported, it's the "detailed" (-V option)
that's missing for most.

The replies, events and errors are listed in the Info column,
and are summarized in the protocol summary line.

Bogus if (tree) { } constructs have also been fixed.

List over other misc. stuff added:
 - handle multiple outstanding requests.
 - add AllocNamedColor to list of requests expecting a reply.
 - body for parsing error replies.
 - each packet can be sent to us multiple times, try to handle that.
 - change request_length display to be what the client actually sends
   for x11_request, not what it means (don't multiply by four).
 - add some more opcodes expecting a reply (gone through all listed
   in the ref. now, so should be complete).
 - use hashtable and sequencenumber for matching reply to request.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9520 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRevert a small change I made a day or so ago because Guy has captures that
sharpe [Fri, 2 Jan 2004 06:35:45 +0000 (06:35 +0000)]
Revert a small change I made a day or so ago because Guy has captures that
show that the short name can be in ASCII if flags 2 says ASCII.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9519 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Steven Lass: put the request and status lines into the protocol
guy [Fri, 2 Jan 2004 02:03:39 +0000 (02:03 +0000)]
From Steven Lass: put the request and status lines into the protocol
tree as filterable fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9518 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTweak the name of the Coloring Rules dialog box to be more consistent ...
sharpe [Fri, 2 Jan 2004 00:19:59 +0000 (00:19 +0000)]
Tweak the name of the Coloring Rules dialog box to be more consistent ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9517 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the RTSP packet handling more like the HTTP packet handling.
guy [Thu, 1 Jan 2004 23:36:50 +0000 (23:36 +0000)]
Make the RTSP packet handling more like the HTTP packet handling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9516 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClean up the blank line handling a bit.
guy [Thu, 1 Jan 2004 23:34:06 +0000 (23:34 +0000)]
Clean up the blank line handling a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9515 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't show empty media formats.
guy [Thu, 1 Jan 2004 21:47:18 +0000 (21:47 +0000)]
Don't show empty media formats.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9514 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Chris Waters: fix a typo.
guy [Thu, 1 Jan 2004 21:35:49 +0000 (21:35 +0000)]
From Chris Waters: fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9513 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support of contains operator in slices.
obiot [Thu, 1 Jan 2004 17:02:56 +0000 (17:02 +0000)]
Add support of contains operator in slices.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9512 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support of contains and matches operators on slices.
obiot [Thu, 1 Jan 2004 16:59:20 +0000 (16:59 +0000)]
Add support of contains and matches operators on slices.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9511 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agolabel texts changed (tip from Richard)
ulfl [Thu, 1 Jan 2004 13:41:09 +0000 (13:41 +0000)]
label texts changed (tip from Richard)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9510 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agorearranged prefs topics
ulfl [Thu, 1 Jan 2004 13:29:16 +0000 (13:29 +0000)]
rearranged prefs topics

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9509 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomoved recent files pref, as it splits corresponding dir entries
ulfl [Thu, 1 Jan 2004 13:16:40 +0000 (13:16 +0000)]
moved recent files pref, as it splits corresponding dir entries

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9508 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocomment fixed
ulfl [Thu, 1 Jan 2004 13:10:45 +0000 (13:10 +0000)]
comment fixed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9507 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agohttp://www.ethereal.com/distribution/win32/development/ has GLib 2.2.3
guy [Wed, 31 Dec 2003 22:17:28 +0000 (22:17 +0000)]
ethereal.com/distribution/win32/development/ has GLib 2.2.3
packages, and a gtk+-1.3.0-20030717.zip package; update the version
numbers accordingly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9506 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove redundant protocol names from preference values.
guy [Wed, 31 Dec 2003 09:58:56 +0000 (09:58 +0000)]
Remove redundant protocol names from preference values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9505 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the tvbuff for SDP lines have the line length as its length and
guy [Wed, 31 Dec 2003 09:47:01 +0000 (09:47 +0000)]
Make the tvbuff for SDP lines have the line length as its length and
reported length, so we show the right error if we go past the end of the

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9504 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIf a packet has a packet number of 0, it's not a fragment if the status
guy [Wed, 31 Dec 2003 01:17:21 +0000 (01:17 +0000)]
If a packet has a packet number of 0, it's not a fragment if the status
is "last buffer".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9503 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFor WTAP_ENCAP_ETHERNET, you have to fill in the "eth.fcs_len" member of
guy [Wed, 31 Dec 2003 01:07:09 +0000 (01:07 +0000)]
For WTAP_ENCAP_ETHERNET, you have to fill in the "eth.fcs_len" member of
the pseudo-header; these captures don't appear to have an FCS in them,
so set that member to 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9502 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn "get_field_data()", check to make sure the field doesn't run past the
guy [Tue, 30 Dec 2003 23:13:32 +0000 (23:13 +0000)]
In "get_field_data()", check to make sure the field doesn't run past the
end of the tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9501 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude <string.h> to declare various string manipulation functions.
guy [Tue, 30 Dec 2003 22:48:14 +0000 (22:48 +0000)]
Include <string.h> to declare various string manipulation functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9500 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved compilation of packet-slsk
ulfl [Tue, 30 Dec 2003 22:18:03 +0000 (22:18 +0000)]
removed compilation of packet-slsk

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9499 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded dick gooris to the list of contributors
ulfl [Tue, 30 Dec 2003 21:55:19 +0000 (21:55 +0000)]
added dick gooris to the list of contributors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9498 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove unused variable firmware_rev
jmayer [Tue, 30 Dec 2003 19:11:30 +0000 (19:11 +0000)]
Remove unused variable firmware_rev

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9497 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNew protocol: Enterasys Interswitch Message Protocol (ismp) and
jmayer [Tue, 30 Dec 2003 17:14:15 +0000 (17:14 +0000)]
New protocol: Enterasys Interswitch Message Protocol (ismp) and
  edp (Enterasys Discovery Protocol)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9496 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHeader files proto-ABBREV.h must not exist if there are no functions
obiot [Tue, 30 Dec 2003 15:49:12 +0000 (15:49 +0000)]
Header files proto-ABBREV.h must not exist if there are no functions
to export to other dissectors.

Describe the "if (tree)" construct and its sense by introducing 2 operation
modes of Ethereal:
(a) operational dissection (tree == NULL)
(b) detailed dissection (tree != NULL).

Fix some typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9495 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoA small fix from Andrew Bartlett. The Short File Name is always in UNICODE.
sharpe [Tue, 30 Dec 2003 04:38:20 +0000 (04:38 +0000)]
A small fix from Andrew Bartlett. The Short File Name is always in UNICODE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9494 f5534014-38df-0310-8fa8-9805f1628bb7