gerald [Sun, 12 May 2002 20:43:29 +0000 (20:43 +0000)]
Fix a bounds checking error in get_CDR_octet_seq.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5452
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 23:04:53 +0000 (23:04 +0000)]
Put in a note about date and time formats.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5451
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:53:58 +0000 (22:53 +0000)]
Mark unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5450
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:40:40 +0000 (22:40 +0000)]
From Didier Gautheron: do case-insensitive comparison against the
authentication mode, and add support for the "exchange file" operation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5449
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:29:43 +0000 (22:29 +0000)]
In "dissect_nt_policy_hnd()":
add arguments to specify whether the policy handle is being
opened or closed, and don't set the "open frame" for the handle
unless it's being opened and don't set the "close frame" for the
handle unless it's being closed;
store the policy handle before fetching it, so that an open or
close is marked appropriately in the protocol tree on the first
pass;
if the policy handle has a name associated with it, put that
name into the top-level item for the policy handle.
In "packet-dcerpc-spoolss.c":
get rid of aun unused variable;
make "setjob_commands[]" static, as it's not used outside
"packet-dcerpc-spoolss.c";
put a "VALS()" call around the reference to "setjob_commands",
to squelch compiler warnings;
give the SPOOLSS return code field the appropriate
"value_string" array.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5448
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 22:22:11 +0000 (22:22 +0000)]
Handle an LSA length <= the length of an LSA header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5447
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:58:02 +0000 (18:58 +0000)]
Add a mechanism for registering "obsolete" preference modules, so that
if a dissector had preferences at one point but no longer does, it can
register that fact, so that the old preferences in the preference file
are silently ignored.
Use that mechanism in the NCP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5446
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:55:22 +0000 (18:55 +0000)]
Instead of creating two handles for the RPC-over-TCP and
RPC-over-everything-else dissectors, one registered by name and one
anonymous, just fetch the handles for the registered dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5445
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:52:55 +0000 (18:52 +0000)]
Use a name, not a number, to refer to the IP protocol number for UDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5444
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:46:38 +0000 (18:46 +0000)]
From Graeme Hewson: add some sanity checks to DNS dissector to avoid
loops.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5443
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 11 May 2002 18:43:09 +0000 (18:43 +0000)]
Get rid of an unused variable.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5442
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 23:20:38 +0000 (23:20 +0000)]
From Joerg Mayer: make a pile of stuff not used outside one source file
static, and add a new "packet-data.h" to declare "proto_data".
Display escape sequences in octal in the IAPP dissector, as is now done
in the RADIUS dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5441
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 22:09:24 +0000 (22:09 +0000)]
Update the URL and comment for the SNIA CIFS spec, now that it's final.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5440
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 20:02:40 +0000 (20:02 +0000)]
Mark an unused argument as such.
Fix a couple of typos in comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5439
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 10 May 2002 19:34:15 +0000 (19:34 +0000)]
The two entries for Martin Thomas are for the same person; combine them
under the e-mail address he says should be used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5438
f5534014-38df-0310-8fa8-
9805f1628bb7
ashokn [Fri, 10 May 2002 18:37:38 +0000 (18:37 +0000)]
- Added support for LMP draft versions -02 and -03 (selectable in
protocol preferences)
- Added OSPF display filtering support, including OSPF/TE extensions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5437
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 10 May 2002 02:44:08 +0000 (02:44 +0000)]
Register FT_UINT_BYTES with correct structure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5436
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Fri, 10 May 2002 02:41:48 +0000 (02:41 +0000)]
Add printer name to COL_INFO for ClosePrinter request.
Converted enumjobs command to Ronnie's NDR dissection routines.
Implemented getjob, setjob, startpageprinter, endpageprinter commands using
NDR routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5435
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Fri, 10 May 2002 02:30:22 +0000 (02:30 +0000)]
Added a private data member to the dcerpc_info structure. This second
level of private data turns out to be needed to pass something other than
an int to dcerpc_dissect_fnct_t functions passed to dissect_ndr_pointer.
A nicer way of doing this would be to convert the levels parameter to a
void *state type of variable but this turns out to be a lot more work as
opposed to a one line change here. (-:
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5434
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 9 May 2002 23:50:34 +0000 (23:50 +0000)]
Merge the work in Novell_NCP_branch into the mainline code.
A little work still needs to be done on the new NCP dissector -- make
some of the COL_INFO texts more useful, handle a Unicode issue, and
modify some of the cases that use "request conditions".
But the NCP dissector as it stands is very usable now.
Note: I didn't merge in the PROTO_LENGTH_UNTIL_END macro... I wanted
to think about the various possible macros and review an email conversation
I had with Guy on the subject.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5432
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 9 May 2002 12:10:06 +0000 (12:10 +0000)]
Added parsing of PORTMAP GETPORT functions.
When we see PRTOMAP GETPORT calls for UDP, make sure all further UDP packets to or from
this port goes to the ONC-RPC dissector regardless of the port on the other side.
We need this because if there is ONC-RPC traffic going between the ONC-RPC Program port to a port which has a normal ethereal dissector, ethereal would dissect the traffic as the protocol associated with the other port instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5430
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 11:18:47 +0000 (11:18 +0000)]
Process address lengths according to the X.25 spec.
Put in a comment noting that the address data should, if the A bit is
set, be processed according to the spec.
Label addresses for registration requests and confirmations
appropriately.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5429
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 09:54:13 +0000 (09:54 +0000)]
Put in a comment noting that the previous change came from a real
capture, so if an IDL disagrees, the IDL is wrong.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5428
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 09:49:34 +0000 (09:49 +0000)]
As Ronnie Sahlberg notes, the problem is that the QueryDomainInfo
response starts with a UNIQUE pointer to a DOMAIN_INFO, not with a REF
pointer to a DOMAIN_INFO - and also not with a UNIQUE pointer to a
DOMAIN_INFO REF pointer; fix the code to match that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5427
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 08:36:45 +0000 (08:36 +0000)]
In at least one capture, a QueryDomainInfo response starts with what is,
I guess, a UNIQUE pointer to a DOMAIN_INFO REF pointer; dissect it as
such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5426
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 08:27:51 +0000 (08:27 +0000)]
Fix another place where the heuristic dissector was checking data before
it new it was available.
Fix some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5425
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 07:42:07 +0000 (07:42 +0000)]
In the heuristic dissector, check to make sure the data being looked at
is available before looking at it, so we don't throw an exception before
we conclude whether the packet is, or isn't, one of ours.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5424
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 9 May 2002 05:49:28 +0000 (05:49 +0000)]
From Martin Thomas: handle address lengths based on TOA bit in X.25.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5423
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Thu, 9 May 2002 02:44:22 +0000 (02:44 +0000)]
Added a routine to dissect a DOS error code. These are used in the spoolss
(also registry and srvsvc?) pipe dissectors.
Also added some helper routines for decoding a range of uint8s. These map
nicely to the dissect_{dcerpc,ndr}_foo() format with the addition of a
length parameter, but aren't really part of the NDR specification and are
probably only going to be used in the NT dcerpc dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5421
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 23:46:34 +0000 (23:46 +0000)]
From Didier Gautheron:
DSI and ASP updates to better handle addresses in replies.
Dissect DSI "open session" and "attention" messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5420
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 22:24:03 +0000 (22:24 +0000)]
From Joerg Mayer:
autoconf 2.53 creates directories named autom4te.cache
Add them to .cvsignore
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5419
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 20:29:47 +0000 (20:29 +0000)]
From Stefan Wenk: SIP heuristic dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5418
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 8 May 2002 12:51:45 +0000 (12:51 +0000)]
Added option to match async NLM MSG with RES packets, to print which MSG packet matches which RES packet and v.v as well as (in RES packets) how long the call took to execute.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5417
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 8 May 2002 08:13:08 +0000 (08:13 +0000)]
From Kan Sasaki: VSA decoding and other changes to RADIUS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5416
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Wed, 8 May 2002 05:15:11 +0000 (05:15 +0000)]
Added constant and value_string for invalid security descriptor owner
error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5415
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 7 May 2002 18:52:27 +0000 (18:52 +0000)]
From Chenjiang Hu: use the correct offset when fetching unreserved
bandwidth values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5414
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 7 May 2002 11:26:46 +0000 (11:26 +0000)]
Several bugfixes for SAMR
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5413
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 7 May 2002 10:07:55 +0000 (10:07 +0000)]
Added extra check in the function that parses NDR pointers.
When the representation for a pointer type gets dissected, the dissector
is actually called twice. Once with conformant_run==1 and once ==0.
The idea is that when conformant_run is ==1, the ONLY bytes that will be
dissected and would be the array structure preceeding the actual data.
And the normal data and content will be dissected when conformant_run ==0.
This is to handle the case properly when conformant arrays are embedded inside
aggregated types, in which case there will be other data inserted between
these array control data, and the array content.
The check that is added will assert that no other data is actually eaten
for conformant_run==1 than just this data.
This will help debugging dcerpc dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5412
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 7 May 2002 06:25:30 +0000 (06:25 +0000)]
Traffic with a traffic type of 0x06 is Signalling AAL traffic, including
non-Q.2931 SSCOP traffic; change comments to reflect that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5411
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Tue, 7 May 2002 00:35:14 +0000 (00:35 +0000)]
Fix up item lengths for policy handle subtree and subitems under it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5410
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 21:53:33 +0000 (21:53 +0000)]
Remove the unused "offset_saved" variable, as per the changes to
"ethereal_gen.py" not to generate the line setting it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5409
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 21:50:28 +0000 (21:50 +0000)]
Get rid of "template_main_dissector_switch_msgtype_end", and get rid of
the unused "offset_saved" variable, as per comments by Frank Singleton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5408
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 21:41:07 +0000 (21:41 +0000)]
From Frank Singleton: fix for the handling of enum types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5407
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 02:12:36 +0000 (02:12 +0000)]
Note that not all attribute values are text strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5406
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 01:45:58 +0000 (01:45 +0000)]
Conversations aren't being used, so don't bother including
<epan/conversation.h>.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5405
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 01:25:45 +0000 (01:25 +0000)]
Note a problem with "GETSTR".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5404
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 00:58:28 +0000 (00:58 +0000)]
Note in comments that we should perhaps get all the information for
RADIUS attributes from files like the FreeRadius dictionary files,
rather than compiling them into the RADIUS dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5403
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 6 May 2002 00:49:19 +0000 (00:49 +0000)]
Fix a typo in a comment.
When displaying text strings, show escapes in octal (as is done C)
rather than decimal.
Display RADIUS_BINSTRING values as strings of hex digits rather than as
text strings.
Make some items that apparently *are* text strings RADIUS_STRING rather
than RADIUS_BINSTRING.
The return value of "rdconvertbufftostr()" is never used; get rid of it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5402
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Sun, 5 May 2002 23:48:19 +0000 (23:48 +0000)]
Remove unused function.
Dissect a status code at the end of GetAliasMem reply instead of uint32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5401
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 22:30:39 +0000 (22:30 +0000)]
Fix the declaration of pointers to "tcp_dissect_pdus()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5400
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 22:25:14 +0000 (22:25 +0000)]
Improve a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5399
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 22:20:11 +0000 (22:20 +0000)]
Use "gint32" rather than "int32_t"; not all platforms define the later,
but GLib defines the former.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5398
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 21:07:52 +0000 (21:07 +0000)]
Have "tvb_ensure_length_remaining()" directly call
"compute_offset_length()", and throw the exception it returns, rather
than calling "tvb_length_remaining()" and throw BoundsError if it
returns -1; this allows us to add additional exceptions without having
to change "tvb_ensure_length_remaining()".
Make "_tvb_get_nstringz()" static, as it's not used outside "tvbuff.c".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5397
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 00:57:59 +0000 (00:57 +0000)]
Make "tvb_ensure_length_remaining()" return a "guint" - it can't return
a negative value.
Use "tvb_ensure_length_remaining()" in "tcp_dissect_pdus()", rather than
checking the return value of "tvb_length_remaining()" ourselves, and
make various variables and parameters in it "guint" as appropriate.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5396
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 00:34:12 +0000 (00:34 +0000)]
Put the pointer to "tcp_dissect_pdus()" in the function pointer table
where the pointer to "dissect_data()" was in 0.9.3; the pointer to
"dissect_data()" wasn't initialized in 0.9.3 (as the function wasn't
exported - you call it through a handle), so no plugin should have been
using it, and putting the pointer to "tcp_dissect_pdus()" in its place
means the structure offsets of all function pointers after it will be
the same in 0.9.3 and the next release, preserving binary compatibility
for plugins.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5395
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 5 May 2002 00:16:38 +0000 (00:16 +0000)]
Make a "tcp_dissect_pdus()" with the standard loop for a TCP segment,
extracting PDUs from it and possibly doing reassembly. Make the COPS,
DNS, DSI, Gryphon, and SCCP dissectors use it.
Add "set_actual_length()", "tcp_dissect_pdus()",
"decode_boolean_bitfield()", "decode_numeric_bitfield()", and
"decode_enumerated_bitfield()" to the list of routines available to
dissectors on platforms where routines in the main program aren't
available to dynamically-loaded code.
Declare routines in "to_str.h" as "extern"; as I remember, that's
necessary to allow the "decode_XXX_bitfield()" routines declared therein
to be made available to plugins as per the above.
Note that new exported routines should be added to the end of the table
if that's the only change being made to the table.
Create a new "plugin_api_decls.h" header file, used to declare both the
"p_" variables and the "p_" structure members in the routine-exporting
mechanism; this reduces the number of places you have to change to
change the list of exported routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5394
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 20:57:18 +0000 (20:57 +0000)]
From Didier Gautheron: put "frame.marked" into the "Frame" subtree, not
into the top-level tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5393
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 11:04:44 +0000 (11:04 +0000)]
From Joerg Mayer: get rid of "-Wno-unused".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5392
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 11:03:18 +0000 (11:03 +0000)]
Update the dissectors (by hand) to match the changes to
"ethereal_gen.py".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5391
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 10:41:16 +0000 (10:41 +0000)]
From Joerg Mayer: mark unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5390
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 10:29:25 +0000 (10:29 +0000)]
In the generated code, mark possibly-unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5389
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 10:19:20 +0000 (10:19 +0000)]
From Joerg Mayer: mark possibly-unused arguments as unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5388
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 10:16:12 +0000 (10:16 +0000)]
From Joerg Mayer: get rid of an unused argument, and flag another as
unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5387
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 10:10:42 +0000 (10:10 +0000)]
Check whether "fflush()" succeeds, and clean up and return an error if
it fails.
"wtap_dump_close()" allows you to pass a null pointer as the second
argument, so an error value isn't returned; use that in the cleanup
routine, as we don't care whether the closes fail.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5386
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 10:00:18 +0000 (10:00 +0000)]
Fix capture-file-specific "close output" routines to check whether the
"err" argument is null and return an error code through that argument
only if it isn't, to match what "wtap_dump_close()", which calls those
routines, does.
Put the NetXRay dump routines in order by version number.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5385
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 09:57:29 +0000 (09:57 +0000)]
Mark unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5384
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 09:20:28 +0000 (09:20 +0000)]
From Joerg Mayer: mark unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5383
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 09:19:09 +0000 (09:19 +0000)]
From Joerg Mayer: mark an unused argument as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5382
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 09:11:28 +0000 (09:11 +0000)]
From Joerg Mayer: get rid of some unused arguments, and mark others as
unused.
Put in a comment to note that if we fail to open the interface either as
a device or as a pipe, we report the error from the failed
"pcap_open_live()" (which explains why "pipe_open_live()" doesn't return
an error string).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5381
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 4 May 2002 09:05:44 +0000 (09:05 +0000)]
From Joerg Mayer: mark unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5380
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Sat, 4 May 2002 02:54:48 +0000 (02:54 +0000)]
Add the packet len to the protocol tree as well, since it is often not visible in the summary display.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5379
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 3 May 2002 21:55:15 +0000 (21:55 +0000)]
From Didieer Gautheron:
Don't show progress bar for quick "Find Frame" searches
Add "Find Next" and "Find Previous" to repeat searches
Add documentation for "Find Next" and "Find Previous".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5378
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 3 May 2002 21:38:20 +0000 (21:38 +0000)]
From Didier Gautheron: add a "frame.marked" hidden field, set if the
frame is marked, so that you can use Find Frame to find the next marked
frame, and can filter the display to show only marked frames.
Update the documentation to note that "frame.marked" is set on marked
frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5377
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 3 May 2002 21:25:43 +0000 (21:25 +0000)]
From Didier Gautheron:
afp :
more calls.
asp :
move release transaction to atp.
dissect asp call.
fix a bug with transaction handling (conversation +tid are not
enough as key ).
atp :
deal with one packet transaction without ATP_EOM.
dsi:
safeguard against overflow for unreassembled packet.
more flags decoded.
Update the "packet-atalk.c" comment to reflect all the protocols in it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5376
f5534014-38df-0310-8fa8-
9805f1628bb7
nneul [Fri, 3 May 2002 20:34:14 +0000 (20:34 +0000)]
fix field names, break down flood and trace control packets, other cosmetics
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5375
f5534014-38df-0310-8fa8-
9805f1628bb7
nneul [Fri, 3 May 2002 19:47:09 +0000 (19:47 +0000)]
split opnums out onto separate tree
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5374
f5534014-38df-0310-8fa8-
9805f1628bb7
nneul [Fri, 3 May 2002 19:31:02 +0000 (19:31 +0000)]
added dissection of various query, report, admin operations
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5373
f5534014-38df-0310-8fa8-
9805f1628bb7
nneul [Fri, 3 May 2002 16:23:25 +0000 (16:23 +0000)]
added full copy of protocol header, small updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5372
f5534014-38df-0310-8fa8-
9805f1628bb7
nneul [Fri, 3 May 2002 15:50:11 +0000 (15:50 +0000)]
Add initial support for udp packets of the Distributed Checksum Clearhouse protocol
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5371
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 3 May 2002 11:16:55 +0000 (11:16 +0000)]
Added some new discovered names for some NETLOGON functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5370
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 3 May 2002 03:30:15 +0000 (03:30 +0000)]
Make the filter list combo box case-sensitive, as filter expressions are
case-sensitive.
Squelch a compiler complaint.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5369
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 3 May 2002 03:24:47 +0000 (03:24 +0000)]
Clean up the handling of filter strings:
have "filter_packets()" make a copy of the filter string handed
to it, as it may save the filter string in the "capture_file"
structure, and the caller of "filter_packets()" shouldn't have
to worry about the string it passed to "filter_packets()" being
stashed away somewhere so that it can't just free that string or
change it;
have callers of "filter_packets()" free up the string they
handed to it, if the string was allocated and they're done with
it;
plug some memory leaks in "match_selected_cb_do()".
Check for an illegal "action" argument being passed to
"match_selected_cb_do()".
Move some keys out of "keys.h" into "gtk/main.c", as they're only used
in "gtk/main.c".
Make the pointer to the filter list a data item for the combo box, as
it's a copy of the list of strings for the combo box, rather than
attaching it to the widgets that activate the filter (a pointer to the
combo box *itself* is a data item for those widgets).
In "filter_activate_cb()", make a copy of the text from the text entry
field as soon as we fetch it, and use that copy. Free that copy if
we didn't add the filter to the filter list.
Don't make a copy of the entire filter list and use that to set the
combo box's list of items - just use the list itself. Also, when the
list is changed, make the new value the data for the combo box (the list
pointer will actually not be changed, because we happen to be using
"g_list_append()", but let's not rely on that).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5368
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 23:49:21 +0000 (23:49 +0000)]
Remove some no-longer-applicable XXX comments.
When you click "OK" on the dialog box, destroy the dialog box *before*
activating any text widget into which we've stuffed the filter
expression, so we don't get the dialog box destroyed out from under us
before we try to destroy it ourselves.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5367
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 21:47:47 +0000 (21:47 +0000)]
From Joerg Mayer: get rid of some unused variables and arguments, and
mark other unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5366
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 19:39:05 +0000 (19:39 +0000)]
From Joerg Mayer: get rid of unused arguments, and "#if" out an unused
stub routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5365
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 19:32:19 +0000 (19:32 +0000)]
From Joerg Mayer: get rid of unused arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5364
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 11:52:52 +0000 (11:52 +0000)]
Only say "IPv6" once in the Info column for "no next header" packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5363
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 11:07:47 +0000 (11:07 +0000)]
From Joerg Mayer:
Prefer IEEE entries over CaveBear entries, as the former list
seems to be the better maintained one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5362
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 11:05:44 +0000 (11:05 +0000)]
From Joerg Mayer: flag unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5361
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 10:59:37 +0000 (10:59 +0000)]
From Joerg Mayer: flag unused arguments as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5360
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 10:53:03 +0000 (10:53 +0000)]
Put the protocol version into the ICQ v2/v3/v4 tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5359
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 10:46:23 +0000 (10:46 +0000)]
From Joerg Mayer: get rid of some unused arguments.
Put a minimal protocol tree in for ICQ v2, v3, and v4.
Add some length checks.
Properly handle the captured and the actual size of the ICQ packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5358
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 10:13:56 +0000 (10:13 +0000)]
From Joerg Mayer: mark unused arguments as such.
Add a check in "dissect_hello_restart_clv()" that the length of the TLV
is correct.
Use "val_to_str()" to get the name of the adjacency state in
"dissect_hello_ptp_adj_clv()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5357
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 09:52:20 +0000 (09:52 +0000)]
Make all routines not used outside this module static.
Get rid of some unused arguments.
Pass the tree argument, not the item argument, to "proto_tree_add"
routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5356
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 09:34:33 +0000 (09:34 +0000)]
From Joerg Mayer: get rid of an unused argument.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5355
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 09:28:43 +0000 (09:28 +0000)]
From Joerg Mayer: get rid of unused arguments.
Fix the spelling of "Reserved".
Use "proto_item_append_text()" when dissecting EIGRP TLVs, so they don't
have to put in name of the TLV into the top-level item for the TLV, they
can just append to the name that's already there.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5354
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 08:55:52 +0000 (08:55 +0000)]
Handle the "no next header" next header value specially - put into the
Info column information about the non-final headers seen in the packet
(or leave the information put in there by the AH dissector alone, if
there were AH's), or, if none were seen, just mark it as a "no next
header" packet, and do that in the code used if there's no match for the
next header value in the protocol table, rather than registering a
dissector for "no next header", which also means we'll dissect the
payload as data if there is any.
Use -1, not "tvb_reported_length_remaining()", when making a subset
tvbuff that runs to the end of the parent tvbuff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5353
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 2 May 2002 08:51:47 +0000 (08:51 +0000)]
Fix a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5352
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 2 May 2002 08:47:23 +0000 (08:47 +0000)]
Added LSA functions 0x38 and 0x3b. These were the two last LSA functions and now
all functions described in lsarpc.idl had been implemented.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5351
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 2 May 2002 08:38:24 +0000 (08:38 +0000)]
Added LSAEnumerateTrustedDomainsEX and LSACreateTrustedDomainEX
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@5350
f5534014-38df-0310-8fa8-
9805f1628bb7