guy [Sat, 26 Mar 2005 03:27:46 +0000 (03:27 +0000)]
There's no need to create a directory just because you're about to
remove a file in it - the directory presumably exists already, if you're
about to remove a file in it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13914
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 03:27:22 +0000 (03:27 +0000)]
For protocol tree items of type FT_NONE and FT_PROTOCOL, treat negative
length values (other than -1) as very large positive values, and for
values larger than the amount of data remaining in the tvbuff, clip the
value to the length of the tvbuff, so that dissectors don't have to
worry about doing that clipping themselves.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13913
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 03:03:43 +0000 (03:03 +0000)]
buildbot bugfix: if a length value is below zero, trim it to zero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13912
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 01:23:39 +0000 (01:23 +0000)]
buildbot bugfix: another (un-)signed one
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13911
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 01:09:14 +0000 (01:09 +0000)]
code cleanup: use common prefix for all functions in color_filters.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13910
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 01:05:29 +0000 (01:05 +0000)]
Create the directory for the preferences files before writing out the
"recent" file.
Have "write_recent()" handle putting up error windows for failed
attempts to write the "recent" file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13909
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 00:15:19 +0000 (00:15 +0000)]
Add some length checks to the CHAP dissector.
Use %u, not %d, to display unsigned values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13908
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 23:44:49 +0000 (23:44 +0000)]
buildbot bugfix: yet another (un-)signed problem.
Guy, you may have a look to add some "invalid" message to the tree in this case
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13907
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 23:12:07 +0000 (23:12 +0000)]
buildbot bugfix: and again, a guint16 will never become lower than zero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13906
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 22:52:45 +0000 (22:52 +0000)]
code cleanup: the term filter_list was used with different meanings throughout the code, and the filter_list of the color_filters is "global".
use appropriate prefixes to avoid confusion and bugs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13905
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2005 22:37:58 +0000 (22:37 +0000)]
jxta updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13904
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2005 22:27:37 +0000 (22:27 +0000)]
updates to SAMR
from Michael richardson
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13903
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 21:19:18 +0000 (21:19 +0000)]
bugfix: prevent a negative length, if ah.ah_len is zero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13902
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 25 Mar 2005 20:12:27 +0000 (20:12 +0000)]
For the Bandwidth Allocation Protocol Phone Delta option:
the length of a suboption must be at least 2;
the length of the Unique Digit option must be 3, and its name is
"Unique Digit", not "Uniq Digit";
the length of the other suboptions must be at least 3.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13901
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 25 Mar 2005 19:52:51 +0000 (19:52 +0000)]
In the cases fixed by the two previous fixes, check to make sure the
items don't run past the length left in the option, and, if they do, put
an indication into the protocol tree that they did.
The length returned by "tvb_strsize()" includes the terminating null
character.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13900
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2005 19:44:09 +0000 (19:44 +0000)]
Add checks to make sure the packet length hasn't overflowed in a couple of
places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13899
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 17:24:48 +0000 (17:24 +0000)]
bugfix: similar problem than the previous one fixed by Gerald
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13898
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2005 17:04:00 +0000 (17:04 +0000)]
Keep the length value from rolling over in CBCP. Add a comment asking if
there's a better way to do this.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13897
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2005 21:17:08 +0000 (21:17 +0000)]
Add a few more payload length checks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13896
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2005 14:21:30 +0000 (14:21 +0000)]
From Jacques Olivier:
Here is a patch that:
* packet-ber.c:
- Fixes handling tags longer than one octet (in
"packet-ber.c:get_ber_identifier") which consists of replacing "if (t &
0x80) break;" by "if (!(t & 0x80)) break;"
- Add debug info on the identifier when debug is enabled (I don't know if we want to keep this, but I find it useful)
- printf's a warning when packet-ber hits a constructed type (to remind that we eventually have to handle this)
- Add the display of unknown BER octet strings (this one was already submitted along with the initial Camel dissector but didn't got
included)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13895
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2005 14:19:24 +0000 (14:19 +0000)]
From Jacques Olivier add some OID:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13894
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 24 Mar 2005 08:55:23 +0000 (08:55 +0000)]
make it possible to use multiple capture files with "duration based switching" only
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13893
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 05:27:03 +0000 (05:27 +0000)]
The "new" routine for STTYPE_STRING and STTYPE_UNPARSED does a
"strdup()" on the argument, so we don't need to do that ourselves (and,
in fact, as we're doing it ourselves but not freeing the result, we leak
memory).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13892
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 04:44:33 +0000 (04:44 +0000)]
Keep a list of all the x11_conv_data_t structures, so that when we're
freeing our data structures, we can go through all those structures and
free up the hash tables associated with them, rather than just leaking
them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13891
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 03:58:38 +0000 (03:58 +0000)]
GtkStyles are reference-counted, and a style returned by
"gtk_style_copy()" has a reference count of 1; release the reference
when we're finished setting other widgets' styles to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13890
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 03:10:31 +0000 (03:10 +0000)]
Plug some more small leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13889
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 22:49:32 +0000 (22:49 +0000)]
Plug a small leak found by the "leaks" tool on OS X.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13888
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 22:30:37 +0000 (22:30 +0000)]
The correlation ID is a 32-bit integer, not a string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13887
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 21:42:40 +0000 (21:42 +0000)]
The DNS name data starts at the beginning of the suboption data, not the
beginning of the suboption.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13886
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 23 Mar 2005 21:38:05 +0000 (21:38 +0000)]
Some more IE stuff and added some ref:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13885
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 21:22:18 +0000 (21:22 +0000)]
When checking whether suboption data fits within the option, check
whether the suboption data offset plus the suboption data length is >,
not >=, the end of the option data - the end of the option data is the
first byte *after* the option data.
For CableLabs string suboptions, use the right offset when fetching the
data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13884
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 20:25:29 +0000 (20:25 +0000)]
From Anton Ivanov: add support for Frame Relay over ATM.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13883
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 23 Mar 2005 16:23:30 +0000 (16:23 +0000)]
Add "cleanup_dissection".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13882
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 12:58:59 +0000 (12:58 +0000)]
Add a "cleanup_dissection()" routine, intended to free up data
structures allocated by a dissection. Currently, it's the same as
"init_dissection()", but they should be split with "init_dissection()"
allocating the initial data structures and "cleanup_dissection()"
freeing them and *not* reallocating the initial data structures.
Use "cleanup_dissection()" in "cf_close()" to make it easier to find leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13881
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 23 Mar 2005 12:57:09 +0000 (12:57 +0000)]
Let packet-gsm_a.c dissect L3 messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13880
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 09:47:11 +0000 (09:47 +0000)]
Audit for TLV loops that don't check the length to make sure it's large
enough, and fix them - and handle the already-fixed case similarly (note
that the length is bogus, and break out of the loop).
Put object header items into the protocol tree in the order in which
they appear in the packet.
For unknown subobjects, make the "Data (N bytes)" item cover only the
data, not the header (which is already covered).
Fix the offset in some calls.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13879
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 23 Mar 2005 09:08:36 +0000 (09:08 +0000)]
buildbot reported bug fixed: prevent an endless loop
But what's the right way to do instead? Just inserted a return, this should do no harm.
Could someone with more knowledge of this dissector review this change?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13878
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 23 Mar 2005 08:38:47 +0000 (08:38 +0000)]
hf_oampdu_info_state_parser seems to be an uint8 not bool, as it can contain 4 values
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13877
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 03:51:38 +0000 (03:51 +0000)]
"tvb_get_stringz()" and "abs_time_to_str()" don't return null pointers,
so don't check whether they've done so with "DISSECTOR_ASSERT()".
("proto_item_set_string()" and friends already do so.)
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13876
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 02:48:47 +0000 (02:48 +0000)]
Thou shalt not g_assert() in a dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13875
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 02:39:21 +0000 (02:39 +0000)]
Remind people not to use "g_ntoh[ls]()" or "g_hton[ls]()" to convert
big-endian to little-endian - that doesn't work on big-endian machines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13874
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 01:55:11 +0000 (01:55 +0000)]
It doesn't matter whether, when building with WinPcap, we have
pcap_lib_version() in the WinPcap on the system on which we're building.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13873
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 01:25:01 +0000 (01:25 +0000)]
If we have "pcap_freecode()", use it to free the instructions for a BPF
filter after installing the filter.
Set HAVE_PCAP_LIB_VERSION if we're building with WinPcap 3.1; it's not
present in earlier versions, but is present in current 3.1 betas.
Check HAVE_PCAP_LIB_VERSION when building capture-wpcap.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13872
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 23 Mar 2005 00:09:12 +0000 (00:09 +0000)]
use DISSECTOR_ASSERT instead of g_assert
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13871
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 22 Mar 2005 23:59:54 +0000 (23:59 +0000)]
add a DISSECTOR_ASSERT_NOT_REACHED() macro
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13870
f5534014-38df-0310-8fa8-
9805f1628bb7
obiot [Tue, 22 Mar 2005 22:27:14 +0000 (22:27 +0000)]
As suggested by Ulf Lamping, prevent Ethereal from bailing out if there's a protocol error, as we now have a DISSECTOR_ASSERT() macro.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13869
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 22 Mar 2005 21:47:11 +0000 (21:47 +0000)]
bugfix for buildbot randpkt: don't call proto_tree_add_string with a NULL pointer
TO THE DISSECTOR DEVELOPERS, PLEASE FIX THIS: I could easily found several places where a g_assert is called, depending on the input packet data. NEVER DO THIS, as this crashes Ethereal simply by invalid packet data input!!!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13868
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 22 Mar 2005 21:39:37 +0000 (21:39 +0000)]
replace another g_assert by DISSECTOR_ASSERT, so Ethereal won't crash if a dissector triggers that assert
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13867
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 21:33:53 +0000 (21:33 +0000)]
More IE dissection
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13866
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 22 Mar 2005 16:02:09 +0000 (16:02 +0000)]
Remove trailing ';'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13865
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:41:40 +0000 (15:41 +0000)]
Initial checkin of a camel dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13864
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:40:58 +0000 (15:40 +0000)]
Initial checkin of a camel dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13863
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:36:33 +0000 (15:36 +0000)]
Dissect part of the payload.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13862
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:34:51 +0000 (15:34 +0000)]
Export q850_cause_code_vals
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13861
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:33:50 +0000 (15:33 +0000)]
Export q850_cause_code_vals as its's used by other dissector(s)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13860
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:19:53 +0000 (15:19 +0000)]
ERROR seems to be a reserved word change it to SCTP_ERROR to be able to build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13859
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Tue, 22 Mar 2005 10:25:07 +0000 (10:25 +0000)]
From Irene Ruengeler: Bugfixes and support of chunk statistics per end point.
Some cleanups of the code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13858
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 22:23:17 +0000 (22:23 +0000)]
Hint in README.tapping about the stats_tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13857
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 21:48:10 +0000 (21:48 +0000)]
Something is better than nothing, Sooner is better than later.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13856
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 21 Mar 2005 21:15:42 +0000 (21:15 +0000)]
Updates according to R1.0.3 (2005-02-26) and decode some more IE:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13855
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 21 Mar 2005 20:52:08 +0000 (20:52 +0000)]
from Hannes Gredler
update for q933
(and changes to move variable declarations to the start of a block since normal c compilers can not handle declarations in the middle of a block)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13854
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 21 Mar 2005 20:01:35 +0000 (20:01 +0000)]
two bugfixes (reported by buildbot randpkt):
don't use the return value of gmtime, if it's NULL
prevent from an endless loop, if payload_length is 0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13853
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 17:51:07 +0000 (17:51 +0000)]
Fix the names that were not consistent after the rename.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13852
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 15:40:33 +0000 (15:40 +0000)]
Add a cleanup call-back to the stats_tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13851
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 21 Mar 2005 10:52:57 +0000 (10:52 +0000)]
make ethereal decrypt gss-krb (secure ldap and ms signandseal for dce)
also when linked with mit kerberos
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13850
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 21 Mar 2005 10:07:55 +0000 (10:07 +0000)]
remove some heimdal dependencies we dont really need
and prepare for gssapi mit support
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13849
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 21 Mar 2005 09:56:55 +0000 (09:56 +0000)]
add capture_fr and stats_tree_branch_max_namelen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13848
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 21 Mar 2005 09:46:39 +0000 (09:46 +0000)]
fix stats_tree defs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13847
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 21 Mar 2005 04:06:45 +0000 (04:06 +0000)]
Declare "stats_tree_create_pivot_node()" and
"create_pivot_node_with_parent_name()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13846
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 21 Mar 2005 03:55:50 +0000 (03:55 +0000)]
Add a capture_fr() routine when capturing on Frame Relay.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13845
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 21 Mar 2005 02:00:14 +0000 (02:00 +0000)]
The table containing payload types and payload dissectors are now sparse
tables that are searched rather than dense tables that are indexed, so
there's no reason to tread payload types 130 and 131 specially.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13844
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 01:32:26 +0000 (01:32 +0000)]
This one is not in the makefiles (it's an example of stats_tree not realy a feature), make sure it works nontheless
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13843
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 21 Mar 2005 01:24:19 +0000 (01:24 +0000)]
From Lars Ruoff:
when formatting numerical values for CSV lists, save the locale
before formatting, set the locale to the "C" locale, and then
restore the locale, so that numbers are always formatted with
"." as the decimal point;
add to the RTP streams window a Copy button that copies all data
from the CList to the clipboard as CSV.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13842
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 01:22:23 +0000 (01:22 +0000)]
This one was missing from the last commit
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13841
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 00:55:04 +0000 (00:55 +0000)]
Rename all stats_tree extern functions to start with stats_tree_
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13840
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 21 Mar 2005 00:54:13 +0000 (00:54 +0000)]
bugfix (hopefully make buildbot happy again): don't call a function pointer, if it's NULL
However, handling of payload 130 and 131 at that place still seems to be bogus to me
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13839
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 23:32:56 +0000 (23:32 +0000)]
Put the source file names in alphabetical order.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13838
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 23:28:36 +0000 (23:28 +0000)]
Fix the expansion of the top-level nodes in GTK+ 1.2[.x].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13837
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 20 Mar 2005 23:26:19 +0000 (23:26 +0000)]
fix some typos, capitalization and don't put two SCTP entries in the Statistics menu
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13836
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 22:24:51 +0000 (22:24 +0000)]
Fix some offsets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13835
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 21:52:11 +0000 (21:52 +0000)]
From Oleg Terletsky:
get rid of a debugging printout;
in "get_agentx_pdu_len()", fetch the payload length in the right
byte order.
If the NETWORK_BYTE_ORDER flag isn't set, that means "little-endian",
not "host byte order" - the host on which I'm typing this is big-endian!
That means that using the "g_hton[ls]()" macros on the result of
"tvb_get_ntoh[ls]()" won't give you little-endian values on a big-endian
host; just directly use "tvb_get_letoh[ls]()" to fetch little-endian
values.
Use "proto_tree_add_item()" whenever possible.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13834
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 20 Mar 2005 21:48:11 +0000 (21:48 +0000)]
Expand the root nodes by default
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13833
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 20 Mar 2005 20:46:54 +0000 (20:46 +0000)]
SCTP port numbers are 16 unsigned integers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13832
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 20:27:51 +0000 (20:27 +0000)]
The GTK+ 2.x version doesn't automatically expand the root node; don't
do so in the GTK+ 1.2[.x] version.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13831
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 19:51:09 +0000 (19:51 +0000)]
Make columns in the GTK+ 1.2[.x] version auto-resizing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13830
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 19:44:19 +0000 (19:44 +0000)]
Make the top-level node start out expanded in GTK+ 1.2[.x].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13829
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 19:29:22 +0000 (19:29 +0000)]
Don't try to run net-snmp-config if we don't find it.
Check whether krb5.h defines KEYTYPE_ARCFOUR_56 - not all versions do
(in particular, the Heimdal that comes with FreeBSD 4.6 doesn't).
packet-kerberos.h includes krb5.h if we hae Heimdal; we don't need to do
so in packet-spnego.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13828
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 18:59:39 +0000 (18:59 +0000)]
Put the ports and addresses into "struct _sctp_info", as the dissector
fills them in.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13827
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 18:58:11 +0000 (18:58 +0000)]
The commented-out entry for sctp_chunk_stat_dlg.c broke
automake/autoconf-based builds, as Makefile.common wasn't getting
included into Makefile.in - remove it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13826
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 20 Mar 2005 12:29:02 +0000 (12:29 +0000)]
bugfix: don't access node elements, after calling free_stat_node
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13825
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 20 Mar 2005 12:07:00 +0000 (12:07 +0000)]
remove some MSVC warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13824
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 20 Mar 2005 12:02:00 +0000 (12:02 +0000)]
From Oleg Terletsky: Support for SCTP chunk counters. Modified to handle bundling correctly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13823
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 11:39:14 +0000 (11:39 +0000)]
Do a GTK+ 1.2[.x] version.
Clean up indentation.
Put the members of the _stat_tree_columns enum in order by column number.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13822
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 20 Mar 2005 11:12:21 +0000 (11:12 +0000)]
st->name was moved to st->cfg->name
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13821
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 11:09:29 +0000 (11:09 +0000)]
Fix dissect_per_restricted_character_string() calls in h225.cnf to pass
0, not NULL, for the last argument.
Re-generate packet-h225.c with the fixed h225.cnf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13820
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 10:57:39 +0000 (10:57 +0000)]
Fix asn2eth to pass 0, not NULL, for the last argument to
"dissect_per_restricted_character_string()", which is a guint32, not a
pointer. Re-generate packet-h225.c with the fixed asn2eth.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13819
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 20 Mar 2005 10:55:50 +0000 (10:55 +0000)]
"*p++" doesn't affect what "p" points to; it only affects "p" itself,
and is equivalent to just "p++". If "p" isn't used after that, "*p++"
does nothing whatsoever, and can just be removed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13818
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 20 Mar 2005 00:49:57 +0000 (00:49 +0000)]
added two stats_tree functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13817
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 20 Mar 2005 00:19:15 +0000 (00:19 +0000)]
There was a design flaw that caused a crash on windows and
left uninitialized successive copies of the stats tree.
Split the stats_tree data in two different structs one for data that's
always needed and it's not going to change at every run and another
for each run of the tap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13816
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Sun, 20 Mar 2005 00:07:07 +0000 (00:07 +0000)]
Make sure the tap info is created even when tree==NULL
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13815
f5534014-38df-0310-8fa8-
9805f1628bb7