obnox/wireshark/wip.git
14 years agoImprove HP Switch Protocol Dissection.
jake [Thu, 9 Nov 2006 12:27:52 +0000 (12:27 +0000)]
Improve HP Switch Protocol Dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19870 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSorry that should have been static int. Corrcted now.
etxrab [Wed, 8 Nov 2006 21:28:03 +0000 (21:28 +0000)]
Sorry that should have been static int. Corrcted now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19869 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake Wireshark build on my system (gcc 4.1.0) again
jmayer [Wed, 8 Nov 2006 13:59:46 +0000 (13:59 +0000)]
Make Wireshark build on my system (gcc 4.1.0) again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19868 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse h248v3.asn.
etxrab [Wed, 8 Nov 2006 06:57:29 +0000 (06:57 +0000)]
Use h248v3.asn.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19867 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake things build on my system again
jmayer [Wed, 8 Nov 2006 00:10:09 +0000 (00:10 +0000)]
Make things build on my system again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19866 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe tvb_ensure_length_remaining() calls aren't needed - we want an
guy [Tue, 7 Nov 2006 21:27:52 +0000 (21:27 +0000)]
The tvb_ensure_length_remaining() calls aren't needed - we want an
exception to be thrown if all the data for the icon isn't there, so the
packet gets marked as incomplete.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19865 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert the previous changes - the problem Paul Blankenbaker was fixing
guy [Tue, 7 Nov 2006 21:04:41 +0000 (21:04 +0000)]
Revert the previous changes - the problem Paul Blankenbaker was fixing
was really a problem with bytes_repr_len() and zero-length FT_BYTES
fields, and it's not clear what to do about fields that have zero
length.  (Put in a comment about that.)

Clean up indentation a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19864 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bytes_repr_len() to correctly handle a zero-length FT_BYTES field
guy [Tue, 7 Nov 2006 20:30:34 +0000 (20:30 +0000)]
Fix bytes_repr_len() to correctly handle a zero-length FT_BYTES field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19863 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBased on a change from Paul Blankenbaker, make the "show" attribute for
guy [Tue, 7 Nov 2006 19:49:58 +0000 (19:49 +0000)]
Based on a change from Paul Blankenbaker, make the "show" attribute for
a field an empty string if the field is zero-length; for some reason,
the existing code doesn't handle that correctly.

Also, the NetPDL Visualization Extension:

http://www.nbee.org/Docs/NetPDL/NetPDLVisualization.htm

seems to imply that "value" has to be present, so display it even if the
field is zero-length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19862 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1206
etxrab [Tue, 7 Nov 2006 19:25:59 +0000 (19:25 +0000)]
Fix bug bugs.wireshark.org/bugzilla/show_bug.cgi?id=1206
MEGACO message cannot be decoded correctly for ServiceChange Command
And decoding of serviceChangeReason.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19861 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to describe all that the read routine needs to return, and to
guy [Tue, 7 Nov 2006 19:25:32 +0000 (19:25 +0000)]
Update to describe all that the read routine needs to return, and to
indicate what the seek_read routine needs to do and that you *have* to
have a seek_read routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19860 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix for bug 1200
sahlberg [Tue, 7 Nov 2006 13:19:31 +0000 (13:19 +0000)]
fix for bug 1200

there used to be a bug in tcp reassembly that even if the dissector only asked for x more bytes from the next segment   the entire segment would still be added to reassembly.
this caused some issues when there was a new multisegment pdu that started at the end of the segment   but this bug was fixed when tcp reassembly was refactored semi-recently.

there was also another "bug" in the http reassembly that it would only ask for one more byte at a time when doing reassembly.
this did work well however when we still had the bug in tcp reassembly   but made wireshark become very very very slow once this tcp bug was fixed  since it is very very very slow to reassemble a huge http pdu just one byte at a time.

this patch adds partial support (what we need for http   which does not use tcp_dissect_pdus() ) for the desegmentation flag : DESEGMENT_ONE_MORE_SEGMENT and also to the http dissector   so that reassembly of http headers spanning multiple semgents now become fast again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19859 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnother packet-acn.c leftover
jmayer [Tue, 7 Nov 2006 10:55:12 +0000 (10:55 +0000)]
Another packet-acn.c leftover

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19858 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAs Ulf Lamping notes:
guy [Tue, 7 Nov 2006 09:50:09 +0000 (09:50 +0000)]
As Ulf Lamping notes:

if the pipename argument to cap_pipe_open_live() is null, that's
a bug, and we want a crash so it's caught;

if ld->pcap_h is null in capture_loop_dispatch(), that's a bug,
and we want a crash so it's caught;

if capture_opts is null in capture_loop_start(), that's a bug,
and we want a crash so it's caught;

there's no need to null out capture_opts->save_file twice.

Also, errmsg and secondary_errmsg are null-terminated strings, so the
array size should be the maximum length + 1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19857 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't copy mibs.txt files to mibs, but to snmp\mibs
ulfl [Tue, 7 Nov 2006 09:36:26 +0000 (09:36 +0000)]
don't copy mibs.txt files to mibs, but to snmp\mibs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19856 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Yet Another Portability Recommendation.
guy [Tue, 7 Nov 2006 09:12:30 +0000 (09:12 +0000)]
Add Yet Another Portability Recommendation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19855 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBitfields are bad - the C language spec does *NOT* guarantee which bits
guy [Tue, 7 Nov 2006 09:06:53 +0000 (09:06 +0000)]
Bitfields are bad - the C language spec does *NOT* guarantee which bits
will correspond to which bit fields.  Don't use them.

Use #defines rather than numbers in the appropriate places.

Constify some arguments.

Get rid of C++ comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19854 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoalbert chin:
jmayer [Tue, 7 Nov 2006 08:41:46 +0000 (08:41 +0000)]
albert chin:

version_info.c has:
  #ifdef HAVE_LIBGCRYPT
  #include <gcrypt.h>
  #endif /* HAVE_LIBGCRYPT */

  #ifdef HAVE_LIBGNUTLS
  #include <gnutls/gnutls.h>
  #endif /* HAVE_LIBGNUTLS */

However, Makefile.am doesn't include the necessary CPPFLAGS/LDFLAGS to
resolve symbols from the above. Patch attached.

Note: dumpcap should not need to be linked to gnutls, but that's a
problem with the version infrastructure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19853 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom albert chin
sahlberg [Tue, 7 Nov 2006 08:33:24 +0000 (08:33 +0000)]
from albert chin

The Solaris C compiler, among others, do not allow anonymous unions.
Patch attached.

thanks albert

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19852 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoYou run perl, not make, on Makefile.PL files.
guy [Tue, 7 Nov 2006 08:19:57 +0000 (08:19 +0000)]
You run perl, not make, on Makefile.PL files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19851 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWarning fix about empty source file
jmayer [Tue, 7 Nov 2006 08:04:11 +0000 (08:04 +0000)]
Warning fix about empty source file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19850 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoregenerate with news pidl
jmayer [Tue, 7 Nov 2006 08:00:30 +0000 (08:00 +0000)]
regenerate with news pidl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19849 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate svn:ignore
jmayer [Tue, 7 Nov 2006 07:58:01 +0000 (07:58 +0000)]
Update svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19848 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to use --includedir instead of copying idl_types.h.
jmayer [Tue, 7 Nov 2006 07:57:07 +0000 (07:57 +0000)]
Update to use --includedir instead of copying idl_types.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19847 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdated to revision 19604.
jmayer [Tue, 7 Nov 2006 07:52:53 +0000 (07:52 +0000)]
Updated to revision 19604.
Update from samba tree revision 19582 to 19604
============================ Samba log start ============
------------------------------------------------------------------------
r19585 | jelmer | 2006-11-06 22:54:19 +0100 (Mon, 06 Nov 2006) | 10 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/ODL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Add support for some more standard IDL instructions:
 - `include' (replaces helper())
 - `import' (replaces depends())

Add support for parsing importlib() - importlib() is now ignored (with a
warning), but no longer causes syntax errors.

helper() and depends() are now marked deprecated and will cause warnings.

------------------------------------------------------------------------
r19588 | jelmer | 2006-11-06 23:54:49 +0100 (Mon, 06 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm

Use include and import statements rather than depends() and helper().

------------------------------------------------------------------------
r19599 | jelmer | 2006-11-07 02:00:27 +0100 (Tue, 07 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm

Fix --includedir.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19846 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWarning fixes (void) instead of (), no newline at end of file.
jmayer [Tue, 7 Nov 2006 07:47:49 +0000 (07:47 +0000)]
Warning fixes (void) instead of (), no newline at end of file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19845 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Albert Chin:
jake [Tue, 7 Nov 2006 07:39:16 +0000 (07:39 +0000)]
From Albert Chin:
Patch attached to convert usage of ntohl() -> g_ntohl(). On HP-UX,
ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there
are other uses of g_ntohl().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19844 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of another ACN reference.
guy [Tue, 7 Nov 2006 00:56:45 +0000 (00:56 +0000)]
Get rid of another ACN reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19843 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of another ACN reference.
guy [Tue, 7 Nov 2006 00:56:04 +0000 (00:56 +0000)]
Get rid of another ACN reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19842 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of more ACN plugin references.
guy [Tue, 7 Nov 2006 00:55:14 +0000 (00:55 +0000)]
Get rid of more ACN plugin references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19841 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSplit the ".." and subdirectory into two separate "cd"s, in the hopes of
guy [Tue, 7 Nov 2006 00:54:01 +0000 (00:54 +0000)]
Split the ".." and subdirectory into two separate "cd"s, in the hopes of
reducing the chances that, if a plugin is removed, an extra ".."
reference will be left in.

Get rid of the extra ".."s that were left in when the ACN plugin was
recently removed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19840 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix 1203 as found by stephen fisher
ulfl [Mon, 6 Nov 2006 23:59:49 +0000 (23:59 +0000)]
fix 1203 as found by stephen fisher

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19839 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove ACN references.
gerald [Mon, 6 Nov 2006 23:38:35 +0000 (23:38 +0000)]
Remove ACN references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19838 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix an inadvertent change.
gerald [Mon, 6 Nov 2006 23:08:11 +0000 (23:08 +0000)]
Fix an inadvertent change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19837 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove ACN.
gerald [Mon, 6 Nov 2006 23:04:53 +0000 (23:04 +0000)]
Remove ACN.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19836 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the references to acn
etxrab [Mon, 6 Nov 2006 20:49:47 +0000 (20:49 +0000)]
Remove the references to acn

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19835 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoconvert restrictiontype to be an enum
sahlberg [Mon, 6 Nov 2006 20:47:37 +0000 (20:47 +0000)]
convert restrictiontype to be an enum

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19834 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the references to acn
etxrab [Mon, 6 Nov 2006 20:36:43 +0000 (20:36 +0000)]
Remove the references to acn

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19833 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobuilding the nspi dissector depends also on the nspi.cnf file, add this dependenc...
sahlberg [Mon, 6 Nov 2006 20:28:19 +0000 (20:28 +0000)]
building the nspi dissector depends also on the  nspi.cnf file,    add this dependency to the makefile

add tracking of policyhandles to the dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19832 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19578 to 19582
jmayer [Mon, 6 Nov 2006 20:21:02 +0000 (20:21 +0000)]
Update from samba tree revision 19578 to 19582
============================ Samba log start ============
------------------------------------------------------------------------
r19580 | jelmer | 2006-11-06 21:01:22 +0100 (Mon, 06 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/pidl

Add --includedir option.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19831 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agonew acn dissector from Bill Florac
sahlberg [Mon, 6 Nov 2006 20:13:32 +0000 (20:13 +0000)]
new acn dissector from Bill Florac

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19830 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some warnings about missing newline at end of file.
jmayer [Mon, 6 Nov 2006 19:58:06 +0000 (19:58 +0000)]
Fix some warnings about missing newline at end of file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19829 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove some // comments.
jmayer [Mon, 6 Nov 2006 19:56:11 +0000 (19:56 +0000)]
Remove some // comments.
Fix a warning about nested comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19828 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't do forward declarations in the file. I'll try to eventually
jmayer [Mon, 6 Nov 2006 19:53:39 +0000 (19:53 +0000)]
Don't do forward declarations in the file. I'll try to eventually
put this stuff into an external file but just doing a forward
declaration to squelch a compiler warning isn't the way to go - it
needs to be done right one day.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19827 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCopy over the nspi.cnf file which was recently added
jmayer [Mon, 6 Nov 2006 19:47:39 +0000 (19:47 +0000)]
Copy over the nspi.cnf file which was recently added

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19826 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19565 to 19578
jmayer [Mon, 6 Nov 2006 19:44:09 +0000 (19:44 +0000)]
Update from samba tree revision 19565 to 19578
============================ Samba log start ============
------------------------------------------------------------------------
r19572 | jelmer | 2006-11-06 15:07:20 +0100 (Mon, 06 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm

Fix typo.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19825 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAvoid ${ename}[...] being interpreted as $ename[...].
lego [Mon, 6 Nov 2006 18:16:56 +0000 (18:16 +0000)]
Avoid ${ename}[...] being interpreted as $ename[...].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19824 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd image/wiresharkdoc.ico to the EXTRA_DIST symbol
jake [Mon, 6 Nov 2006 14:20:59 +0000 (14:20 +0000)]
Add image/wiresharkdoc.ico to the EXTRA_DIST symbol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19823 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the executable property from this datafile
jake [Mon, 6 Nov 2006 14:20:03 +0000 (14:20 +0000)]
Remove the executable property from this datafile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19822 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrederic heem:
jmayer [Mon, 6 Nov 2006 14:16:29 +0000 (14:16 +0000)]
frederic heem:
Please find attached a patch to replace "#" with "*".
Check64BitFormat.c.in is a C file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19821 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLet the manifest state that we're Wireshark.
jake [Mon, 6 Nov 2006 12:58:14 +0000 (12:58 +0000)]
Let the manifest state that we're Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19820 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bug 1207, simple swap of the two text strings.
jake [Mon, 6 Nov 2006 12:19:26 +0000 (12:19 +0000)]
Fix bug 1207, simple swap of the two text strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19819 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't remove a preference, make it obsolete instead.
jake [Mon, 6 Nov 2006 11:41:02 +0000 (11:41 +0000)]
Don't remove a preference, make it obsolete instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19818 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosome compilers dont like unnamed unions and structs
sahlberg [Mon, 6 Nov 2006 09:30:15 +0000 (09:30 +0000)]
some compilers dont like unnamed unions and structs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19817 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix the return value of file_seek, as noted by Steve
ulfl [Mon, 6 Nov 2006 00:24:24 +0000 (00:24 +0000)]
fix the return value of file_seek, as noted by Steve

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19816 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19553 to 19565
jmayer [Sun, 5 Nov 2006 23:33:28 +0000 (23:33 +0000)]
Update from samba tree revision 19553 to 19565
============================ Samba log start ============
------------------------------------------------------------------------
r19553 | jelmer | 2006-11-04 16:40:05 +0100 (Sat, 04 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm

Add check for correct API usage.

------------------------------------------------------------------------
r19557 | jelmer | 2006-11-04 21:24:35 +0100 (Sat, 04 Nov 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix lookup table for WERROR.
Fix perl warnings when using NTSTATUS as return type.

------------------------------------------------------------------------
r19559 | jelmer | 2006-11-04 22:53:00 +0100 (Sat, 04 Nov 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix handling of types where the name isn't prefixed by the interface name.
Based on patch by Julien Kerihuel.

------------------------------------------------------------------------
r19560 | jelmer | 2006-11-05 01:03:44 +0100 (Sun, 05 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix handling of PARAM_VALUE.

------------------------------------------------------------------------
r19561 | jelmer | 2006-11-05 01:08:39 +0100 (Sun, 05 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Remove debug statement.

------------------------------------------------------------------------
r19562 | jelmer | 2006-11-05 01:26:44 +0100 (Sun, 05 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Support returning simple scalars.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19815 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange all file offsets from long to gint64 so we can - theoretically - handle files...
ulfl [Sun, 5 Nov 2006 22:46:44 +0000 (22:46 +0000)]
change all file offsets from long to gint64 so we can - theoretically - handle files > 2GB correct.

Please distclean Win32 builds!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19814 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Albert Chin
jake [Sun, 5 Nov 2006 22:31:57 +0000 (22:31 +0000)]
From Albert Chin
The IBM C compiler on AIX 4.3.3 doesn't accept a trailing comma after
the last enum definition. Patch attached for stat_menu.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19813 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd HP Switch Protocol SAP value
jake [Sun, 5 Nov 2006 18:26:21 +0000 (18:26 +0000)]
Add HP Switch Protocol SAP value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19812 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix svn728: don't scroll down packet list while capturing, if no packets are newly...
ulfl [Sun, 5 Nov 2006 13:47:17 +0000 (13:47 +0000)]
fix svn728: don't scroll down packet list while capturing, if no packets are newly displayed (happens when a display filter is active)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19811 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTidy up of information column for NTLM authentication.
gal [Sun, 5 Nov 2006 12:15:52 +0000 (12:15 +0000)]
Tidy up of information column for NTLM authentication.
Related to Bug 1148.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19810 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe used the wrong offset for attribute lists, fixed
sahlberg [Sun, 5 Nov 2006 11:19:46 +0000 (11:19 +0000)]
we used the wrong offset for attribute lists,   fixed

add decoding for attribute lists for another instance where these blobs appear in the data in/out buffers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19809 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago add a framework to manage dissection of osd attribute pages, attribute number and...
sahlberg [Sun, 5 Nov 2006 10:48:53 +0000 (10:48 +0000)]
 add a framework to manage dissection of osd attribute pages, attribute number and name and dissectors for them.

implement the dissector for attribute page 1 (user object info) number 82 (logical length) as an example.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19808 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodissect the Get Attributes List Offset according to the really weird encoding in...
sahlberg [Sun, 5 Nov 2006 07:59:20 +0000 (07:59 +0000)]
dissect the Get Attributes List Offset according to the really weird encoding in 4.12.5

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19807 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoregenerate NSPI using the latest version of pidl
sahlberg [Sun, 5 Nov 2006 06:12:24 +0000 (06:12 +0000)]
regenerate NSPI using the latest version of pidl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19806 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoupdate the Makefile to point to the new path after the svn move
sahlberg [Sun, 5 Nov 2006 06:00:01 +0000 (06:00 +0000)]
update the Makefile to point to the new path after the svn move

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19805 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agorename the nspi dissector from idl (where the idl2wrs dissectors live) ro epan/dissec...
sahlberg [Sun, 5 Nov 2006 05:56:27 +0000 (05:56 +0000)]
rename the nspi dissector from idl (where the idl2wrs dissectors live) ro epan/dissector/pidl  (where the pidl generated dce/rpc dissectors live)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19804 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd tracking of policy handles to the efs dissector
sahlberg [Sun, 5 Nov 2006 05:35:06 +0000 (05:35 +0000)]
add tracking of policy handles to the efs dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19803 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd packet-dcerpc-nspi.h to the distribution.
gerald [Sun, 5 Nov 2006 05:33:53 +0000 (05:33 +0000)]
Add packet-dcerpc-nspi.h to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19802 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd tracking of policy_handles to the eventlog dissector
sahlberg [Sun, 5 Nov 2006 05:21:33 +0000 (05:21 +0000)]
add tracking of policy_handles to the eventlog dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19801 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agotesting out latest pidl where PARAM values can be used to track policy handles properly
sahlberg [Sun, 5 Nov 2006 04:49:20 +0000 (04:49 +0000)]
testing out latest pidl where PARAM values can be used to track policy handles properly

winreg now tracks also where policy handles were closed    which previously didnt work properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19800 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoit is GtkText in gtk-1.x not GtkTextView
sahlberg [Sun, 5 Nov 2006 04:38:47 +0000 (04:38 +0000)]
it is GtkText in gtk-1.x   not GtkTextView

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19799 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake the routines that manipulate the hex/text display window take a
guy [Sun, 5 Nov 2006 00:54:17 +0000 (00:54 +0000)]
Make the routines that manipulate the hex/text display window take a
GtkWidget * as an argument, rather than a version-of-GTK+-dependent
pointer; that way, we need fewer #ifdefs.

Use WIDGET_SET_SIZE() instead of #ifdeffed code using
gtk_widget_set_usize() or gtk_widget_set_size_request() -
WIDGET_SET_SIZE() was created to encapsulate that GTK+ 1.2[.x] vs. 2.x
difference.

Make some variables not used outside gtk/main.c static.

Clean up white space.

Clean up handling of return value from load_airpcap() a bit.

Use one big #ifdef HAVE_AIRPCAP/#endif for all the AirPcap stuff in
gtk/main.c.

Attach _U_ to the unused arguments to driver_warning_dialog_cb(), not to
the arguments that are being used - and don't include it at all if
HAVE_AIRPCAP isn't defined, as it's not used in that case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19798 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Dave Richards
sahlberg [Sat, 4 Nov 2006 21:19:14 +0000 (21:19 +0000)]
from Dave Richards

Here is a patch to fix a problem with notification parameters.  Fix is:

Remove premature return statements from fNotificationParameters.

The real problem is that the original code is inconsistent about putting
a break in all cases of the switch blocks and some were falling through
to the default case where there was a return.  I took the simple route
and removed the unnecessary returns - they were OK for default case but
not for the fall through.

Is there a standard about having breaks?  If it is desired to have a
consistent coding style I will further update the code to conform.
Otherwise, could someone please commit this change as it does fix the bug?

Thanks,

Dave Richards

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19797 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoxxx_PROGRAMS variables have the name of the program without $(EXEEXT).
guy [Sat, 4 Nov 2006 20:37:16 +0000 (20:37 +0000)]
xxx_PROGRAMS variables have the name of the program without $(EXEEXT).

Update Gerald's address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19796 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopropset...
jmayer [Sat, 4 Nov 2006 18:00:29 +0000 (18:00 +0000)]
propset...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19795 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoJulien Kerihuel:
jmayer [Sat, 4 Nov 2006 17:44:37 +0000 (17:44 +0000)]
Julien Kerihuel:

The new version of the dissector will compile without any patches to apply to
Wireshark/NDR.pm. Jelmer has improved the patch and pidl now support enums as
return type. Regarding the nspi.cnf file, it won't be useful anymore.

Regarding the dissector, I've noticed a bug in NspiGetMatches which isn't
dumped correctly. I'm currently investigating the problem and I'll notify the
list when a fixed version is available.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19794 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19540 to 19553
jmayer [Sat, 4 Nov 2006 16:57:21 +0000 (16:57 +0000)]
Update from samba tree revision 19540 to 19553
============================ Samba log start ============
------------------------------------------------------------------------
r19541 | jelmer | 2006-11-03 20:55:17 +0100 (Fri, 03 Nov 2006) | 3 lines

Explicitly segfault when the API is being used incorrectly. Previously
this would've caused a silent premature return.

------------------------------------------------------------------------
r19544 | jelmer | 2006-11-04 00:08:33 +0100 (Sat, 04 Nov 2006) | 2 lines

Fix case of 'warning'.

------------------------------------------------------------------------
r19545 | jelmer | 2006-11-04 02:53:29 +0100 (Sat, 04 Nov 2006) | 2 lines

Allow enums as return types in code generated for wireshark. Originally based on a patch by Julien Kerihuel.

------------------------------------------------------------------------
r19546 | jelmer | 2006-11-04 03:51:03 +0100 (Sat, 04 Nov 2006) | 3 lines

fix number of bytes pushed when using switch_type() set to enum types.
die() on invalid used of enum_type_fn()

------------------------------------------------------------------------
r19547 | jelmer | 2006-11-04 03:54:24 +0100 (Sat, 04 Nov 2006) | 2 lines

Fix use of v1_enum on enums used in return types.

------------------------------------------------------------------------
r19553 | jelmer | 2006-11-04 16:40:05 +0100 (Sat, 04 Nov 2006) | 2 lines

Add check for correct API usage.

------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19793 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGeneral updates to:
gal [Sat, 4 Nov 2006 09:14:54 +0000 (09:14 +0000)]
General updates to:
*) Remove maximum LDAP PDU size check - they can get large with either large attributes (e.g. CRLs, SPIFs) or with lots of results (see http://www.wireshark.org/lists/wireshark-users/200610/msg00197.html). The max size preference is also removed.
*) Support for dissecting LDAP controls including server side sorting and paged results. A new BER function is introduced to see if there is a dissector for a given OID.
*) Remove reference to removed BER preference in the LDAP reassembly preference.
*) Mark a LDAPURL as a URL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19792 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom SF
sahlberg [Sat, 4 Nov 2006 08:54:45 +0000 (08:54 +0000)]
From SF

Attached is a fix for bug #1156: "If a dissector depends on a new
datasource created by a new tvb, that dissector's protocol can't be
filtered on."

Thanks,
 ┬áSteve

I change the code slightly to avoid dereferenceing a NULL pointer.
While the original code was fine and safe on unix   dereferencing a null pointer in this way would be unsafe and cause a segmentation violation on windows   if tree is NULL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19791 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to U3 packaging to:
gal [Sat, 4 Nov 2006 08:01:44 +0000 (08:01 +0000)]
Update to U3 packaging to:
*) Assign a new UUID for version 0.99.5 (so different versions of Wireshark can be installed on one U3 device)
*) Include version number in U3 program name to allow user to differentiate versions
*) Catch up with packaging changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19790 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix distcheck.
gerald [Sat, 4 Nov 2006 00:35:04 +0000 (00:35 +0000)]
Fix distcheck.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19789 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agosplit subversion into command line and GUI (TortoiseSVN) client
ulfl [Fri, 3 Nov 2006 22:39:28 +0000 (22:39 +0000)]
split subversion into command line and GUI (TortoiseSVN) client

update various version infos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19788 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't forget to uninstall pango\1.5.0, we might want to have something like this...
ulfl [Fri, 3 Nov 2006 22:12:57 +0000 (22:12 +0000)]
don't forget to uninstall pango\1.5.0, we might want to have something like this checked by the buildbot to prevent such problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19787 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect h324ext_h223lcparm.
etxrab [Fri, 3 Nov 2006 20:15:17 +0000 (20:15 +0000)]
Dissect h324ext_h223lcparm.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19786 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd $(EXEXT) after references to the Lemon executable.
guy [Fri, 3 Nov 2006 18:39:03 +0000 (18:39 +0000)]
Add $(EXEXT) after references to the Lemon executable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19785 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the Windows icons. Use the document icon for capture files.
gerald [Fri, 3 Nov 2006 15:54:12 +0000 (15:54 +0000)]
Update the Windows icons.  Use the document icon for capture files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19784 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 18675 to 19540
jmayer [Fri, 3 Nov 2006 15:10:17 +0000 (15:10 +0000)]
Update from samba tree revision 18675 to 19540
============================ Samba log start ============
svn: When specifying working copy paths, only one target may be given
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19783 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixes ./autogen.sh on Mac OS X...
tuexen [Fri, 3 Nov 2006 10:12:36 +0000 (10:12 +0000)]
Fixes ./autogen.sh on Mac OS X...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19782 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBump the version to 0.99.5.
gerald [Fri, 3 Nov 2006 06:55:30 +0000 (06:55 +0000)]
Bump the version to 0.99.5.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19781 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTouch up the glossy highlight in the main icon. Split "wsiconcap" into
gerald [Fri, 3 Nov 2006 06:30:52 +0000 (06:30 +0000)]
Touch up the glossy highlight in the main icon.  Split "wsiconcap" into
"capture-in-progress" and "document" icons.  Update the highlight in
each of them as well.  Resize and rename the 200-pixel icons to 256.
Add a script to generate icons from their canonical sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19780 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nicolas Dichtel:
jake [Thu, 2 Nov 2006 16:47:13 +0000 (16:47 +0000)]
From Nicolas Dichtel:
here is a patch that transforms "valid lifetime" and "prefered lifetime" in a prefix option (in RA)
in human readable format. Following the RFC2461 Section 4.6.2, if the value is 0xffffffff, this means lifetime
is infinity.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19779 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't try to report -ve roundtrip delays
martinm [Thu, 2 Nov 2006 11:51:09 +0000 (11:51 +0000)]
Don't try to report -ve roundtrip delays

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19778 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrederic Heem:
jmayer [Thu, 2 Nov 2006 09:45:12 +0000 (09:45 +0000)]
Frederic Heem:
 Fix some memleaks and overflows.

I haven't committed the changes that are not bug fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19777 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowe don't support 95/98/ME any longer, and indeed WS doesn't work on these versions.
ulfl [Thu, 2 Nov 2006 09:36:47 +0000 (09:36 +0000)]
we don't support 95/98/ME any longer, and indeed WS doesn't work on these versions.

Give a hint that the last known working version was Ethereal 0.99.0 and quit the installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19776 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd idl2wrs.sh to svn:ignore
jmayer [Thu, 2 Nov 2006 09:30:12 +0000 (09:30 +0000)]
add idl2wrs.sh to svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19775 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoZhu Yi:
jmayer [Thu, 2 Nov 2006 09:26:38 +0000 (09:26 +0000)]
Zhu Yi:

ieee80211e dissect patch
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1191

Me:
Fix signedness warnings regarding ssid and ccode.
(in the old code, not in the 11e code)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19774 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix bug 1043.
jmayer [Thu, 2 Nov 2006 08:52:25 +0000 (08:52 +0000)]
Try to fix bug 1043.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19773 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBug 1053: New SNMP filtering is broken
kukosa [Thu, 2 Nov 2006 08:48:58 +0000 (08:48 +0000)]
Bug 1053: New SNMP filtering is broken
Do not try to parse OID as hexbytes string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19772 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a warning: "airpcap_loader.c(2287) : warning C4700: local variable 'ad' used...
ulfl [Wed, 1 Nov 2006 23:22:13 +0000 (23:22 +0000)]
fix a warning: "airpcap_loader.c(2287) : warning C4700: local variable 'ad' used without having been initialized"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19771 f5534014-38df-0310-8fa8-9805f1628bb7