jake [Thu, 16 Dec 2010 08:03:57 +0000 (08:03 +0000)]
From Harald Welte:
It seems that Hay Systems Limited (HSL) is using stream 0xDD to transport
human-readable debug messages from the BTS to the BSC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35196
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 16 Dec 2010 07:55:35 +0000 (07:55 +0000)]
From Harald Welte:
As it seems, there are systems that use an IPA multiplex layer but don't use
it on the standard ports that ip.access is using them for the A-bis interface.
This patch adds a user-configurable preference for the TCP and UDP ports the
IPA dissector should work on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35195
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 16 Dec 2010 07:25:01 +0000 (07:25 +0000)]
Fix for bug 5475:
Track dissection properly of Packet Flow Identifier IE to
avoid Extraneous Data reporting.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35194
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Thu, 16 Dec 2010 07:01:22 +0000 (07:01 +0000)]
From Guido Reismueller:
packet-mdd.c
- TLV 15 fixed
packet-tlv.c
- Added Support for DOCSIS 3.0 TLVs (38-66)
Added Support for the following DOCSIS 3.0 MAC Management Messages
- DBC-REQ (packet-dbcreq.c)
- DBC-RSP (packet-dbcrsp.c)
- DBC-ACK (packet-dbcack.c)
- CM-CTRL-REQ (packet-cmctrlreq.c)
- CM-CTRL-RSP (packet-cmctrlrsp.c)
- DPV-REQ (packet-dpvreq.c)
- DPV-RSP (packet-dpvrsp.c)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35193
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 15 Dec 2010 18:38:17 +0000 (18:38 +0000)]
From k barnard:
Flag when a packet has been dropped by the jitter buffer in the audio player,
by showing:
D dropped packet
W wrong timestamp
S silence added by wireshark
To show when audio 'glitches' may have come from the processing the received
packets through the jitter buffer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35192
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Dec 2010 12:07:41 +0000 (12:07 +0000)]
Use value_string for MAC-is descriptor lchid.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35191
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Dec 2010 10:59:10 +0000 (10:59 +0000)]
From Tobias Witek:
Bug 5494 - FP-Hint: Display correct DCH-ID value
In FP-Hint, DCH-IDs are stored as a 5-bit value. While a 5-bit value can
hold values from 0..31, DCH-IDs in the NBAP, RNSAP and RRC protocols
have values from 1..32.
This patch adds 1 to the DCH-ID in FP-Hint in order to display the
correct DCH-ID value in the protcol tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35190
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Dec 2010 10:53:35 +0000 (10:53 +0000)]
Prettify the dissection of EDCH T2 data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35189
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Dec 2010 01:45:43 +0000 (01:45 +0000)]
Add support for FP E-DCH T2 frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35188
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 14 Dec 2010 18:27:04 +0000 (18:27 +0000)]
Introduce a preference to display the third and forth bytes of the RIPv2
header as the "Routing Domain" field as introduced in RFC 1388 [January 1993]
and obsoleted as of RFC 1723 [November 1994]. Defaults to FALSE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35187
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 14 Dec 2010 17:02:00 +0000 (17:02 +0000)]
Rename "Secure Socket Layer" to "Secure Sockets Layer" (plural) and update
protocol reference URLs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35186
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 14 Dec 2010 14:23:27 +0000 (14:23 +0000)]
Update the "Following Conversations" section to use se_alloc() instead of GMemChunks.
Also: add information about the conversation_set_dissector() function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35185
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 14 Dec 2010 07:43:17 +0000 (07:43 +0000)]
Riverbed published patch for dissection of Riverbed TCP Probe/Transparency TCP options.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35184
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 14 Dec 2010 01:50:31 +0000 (01:50 +0000)]
Minor cleanup:
- Initialize a few static global variables;
- Remove two unnecessary calls to g_hash_table_foreach_remove;
- Do whitespace cleanup and use consistent indentation;
- Fix a few typos and fix up several comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35183
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 13 Dec 2010 15:59:14 +0000 (15:59 +0000)]
From Marton Nemeth via bug #5490: Cleanup USB endpoint direction display.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35182
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 13 Dec 2010 11:00:05 +0000 (11:00 +0000)]
Show DDI config info.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35181
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 12 Dec 2010 16:03:46 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-12-12]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35178
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 11 Dec 2010 21:40:01 +0000 (21:40 +0000)]
Added opcua_extensionobjecttable.c from revision 34906.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35177
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sat, 11 Dec 2010 04:11:31 +0000 (04:11 +0000)]
Rework some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35176
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sat, 11 Dec 2010 03:22:09 +0000 (03:22 +0000)]
Fix bug #5477: fuzz-test failure found by using G_SLICE=debug-blocks.
Essentially: doing g_slice_free with the wrong 'type' for the data to be freed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5477
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35175
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 10 Dec 2010 15:49:33 +0000 (15:49 +0000)]
From Richard Sharpe via bug 5466: "Changes to dissect persistentreserveout
parameters", with some whitespace changes by me.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35173
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 10 Dec 2010 15:35:59 +0000 (15:35 +0000)]
Additions to allow the valgrind to test for reassembly.c memory leaks.
Specifically: free all dynamically allocated memory after each test (or
at program completion).
Also: add some debug functions (conditionally enabled) to print information
about the fragment_table and reassembled_table fd-chains.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35172
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 10 Dec 2010 15:32:47 +0000 (15:32 +0000)]
From Rob Casey:
Addition of support for DNP3 Analog Input Deadband object type
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5471
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35171
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 10 Dec 2010 14:23:48 +0000 (14:23 +0000)]
From Lori Tribble:
Enhancements to BACnet's bacapp dissector
Details:
1) Added the low and high instance parameters of the who-is command to the
summary view, if present.
2) Added dissecting of the property active-cov-subscriptions.
3) Added tag details to the decoded view of ProcessId.
4) Fixed the indent levels of the recipientProcess decoding.
5) Fixed the indent tree levels for ReadPropertyMultiple-ACK when decoding
error response.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5473
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35170
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 10 Dec 2010 12:39:59 +0000 (12:39 +0000)]
From Mike Morrin:
Fix RSL Channel description and interference dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5479
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35169
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Fri, 10 Dec 2010 10:37:03 +0000 (10:37 +0000)]
Move wslua_plugin_list to epan/plugins.c, that should fix the Solaris builds finally.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35167
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 10 Dec 2010 05:23:40 +0000 (05:23 +0000)]
Export G_SLICE=debug-blocks to do additional memory checks;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35166
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 10 Dec 2010 03:13:09 +0000 (03:13 +0000)]
Export G_SLICE=debug-blocks to do additional memory checks;
From the GLib docs
"Using this option (present since GLib-2.13) engages extra code which
performs sanity checks on the released memory slices. Invalid slice
addresses or slice sizes will be reported and lead to a program halt."
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35165
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Thu, 9 Dec 2010 15:47:23 +0000 (15:47 +0000)]
Drop init_wslua.h from EXTRA_DIST
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35164
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Thu, 9 Dec 2010 15:20:14 +0000 (15:20 +0000)]
Always provide wslua_plugin_list, even if we don't have Lua configured.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35163
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Thu, 9 Dec 2010 15:19:28 +0000 (15:19 +0000)]
revert commit 35160 (filter out wlua_plugin_list from libwireshark.sym when compiling without Lua)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35162
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Wed, 8 Dec 2010 23:36:01 +0000 (23:36 +0000)]
filter out wlua_plugin_list from libwireshark.sym when compiling without Lua
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35160
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 8 Dec 2010 11:25:22 +0000 (11:25 +0000)]
Mark parameter as unused.
reassemble.c:220: warning: unused parameter 'key_arg'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35156
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 8 Dec 2010 09:12:03 +0000 (09:12 +0000)]
reassemble.c: In function 'free_all_fragments':
reassemble.c:222: warning: unused variable 'key'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35155
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 8 Dec 2010 08:26:40 +0000 (08:26 +0000)]
fragment_free_key to be used only if Glib >= 2.10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35154
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 8 Dec 2010 06:32:04 +0000 (06:32 +0000)]
Reassemble.c leaks memory for GLIB > 2.8
Free fragment data and fragment keys in fragment_table when neccessary. reassembled_table remains to be fixed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35153
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Dec 2010 00:16:42 +0000 (00:16 +0000)]
Change "DCE RPC" to "Distributed Computing Environment / Remote Procedure
Call (DCE/RPC)" for the DCERPC dissector's PROTONAME.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35152
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 7 Dec 2010 23:27:11 +0000 (23:27 +0000)]
Init fragment_table and reassembly table every "session" rather than just once in proto_register...()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35151
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 21:20:39 +0000 (21:20 +0000)]
Change includes for getenv_utf8()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35150
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 20:45:22 +0000 (20:45 +0000)]
Include stdlib.h for getenv().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35149
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 20:24:57 +0000 (20:24 +0000)]
Move getenv_utf8() to wsutil.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35148
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 18:31:50 +0000 (18:31 +0000)]
Revert rev 35145 for wsutil: go back to exporting all symbols. libwsutil's list of exported symbols includes our optional targets and trying to export symbols that don't (always) exist upsets some linkers. Anyway, the list of global symbols in libwsutil is (so far) quite short.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35147
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 14:28:28 +0000 (14:28 +0000)]
Fill out libwiretap's DEPENDENCIES line with the rest of the dependencies (from LIBADD).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35146
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Tue, 7 Dec 2010 13:38:15 +0000 (13:38 +0000)]
Make libtool export only symbols listed in *.def files
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35145
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Tue, 7 Dec 2010 11:59:15 +0000 (11:59 +0000)]
... and update the documentation too :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35144
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Tue, 7 Dec 2010 11:42:32 +0000 (11:42 +0000)]
Change the accelerator keys for "goto previous/next packet in conversation" from "<ctrl>+[" and "<ctrl>+]" to "<ctrl>+," and "<ctrl>+." as the bracket keys cause problems on many keyboards where they are "hidden" behind AltGr (I was tipped by a user with a German keyboard that has that "problem"). The new keys should cause no problems on most keyboards according to en.wikipedia.org/wiki/Keyboard_layout.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35143
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 03:46:10 +0000 (03:46 +0000)]
From Andrew Feren via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5377 :
Add a bunch of NetFlow/IPFIX extensions from Plixer and ntop.
A little cleanup as well.
From me: remove duplicate blurbs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35142
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 7 Dec 2010 02:44:25 +0000 (02:44 +0000)]
From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5438 :
Various fixes for AgentX protocol decoding:
1/ Fixed the decode of get & getnext PDU to correctly iterate over range lists.
2/ Re-adjust PDU header highlighting to hightlight all 20 octets instead of
only the first 4.
3/ Altered the decode hierarchy so that PDU bodys are no longer a sub-component
of the PDU header, but is now at the same level as the header.
4/ Corrected the highlighted length of decoded OIDs.
5/ Added bitwise decoding of the PDU 'flag' octet.
From me:
- Remove unnecessary includes.
- Some indentation/white space cleanup.
- Remove (new) duplicate blurbs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35141
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 6 Dec 2010 23:20:21 +0000 (23:20 +0000)]
Make some symbols static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35140
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 6 Dec 2010 23:17:43 +0000 (23:17 +0000)]
Make a whole bunch of symbols static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35139
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 6 Dec 2010 22:08:48 +0000 (22:08 +0000)]
Make some prefs callback functions static. (These modules don't use proto_reg_handoff_*() as their prefs callback.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35138
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 6 Dec 2010 22:00:08 +0000 (22:00 +0000)]
Improve dissection of bit-oriented fields. Patch from Richard Sharpe via
bug #5466 with some minor whitespace modifications from me and a fix of an
invalid offset introduced with the patch. Fuzz testing still needs to be done.
I can't seem to get the fuzz tester to work with the capture files attached to
the bug report.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35137
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 6 Dec 2010 21:33:19 +0000 (21:33 +0000)]
Revert r35132 so that a better fix can be implemented that doesn't break
non-printable non-UTF8 ASCII characters such as in binary streams.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35136
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 6 Dec 2010 21:24:25 +0000 (21:24 +0000)]
Remove unnecessary #include "../isprint.h"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35135
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 6 Dec 2010 19:48:05 +0000 (19:48 +0000)]
Make some (preference) variables static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35134
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 6 Dec 2010 18:34:49 +0000 (18:34 +0000)]
Update the location of make-manuf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35133
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 6 Dec 2010 18:34:26 +0000 (18:34 +0000)]
Change isprint() calls in follow_stream.c (shared code that supports Follow
TCP, UDP and SSL streams) to g_unichar_isprint() so that UTF-8 characters
are displayed properly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35132
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 6 Dec 2010 18:30:39 +0000 (18:30 +0000)]
Change format_text() and format_text_wsp() to use g_unichar_isprint() for
UTF-8 support instead of isprint(). This allows the middle packet details
pane to display UTF-8 strings instead of escaping them with \xxx notation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35131
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 6 Dec 2010 18:30:14 +0000 (18:30 +0000)]
Move make-manuf to the tools directory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35130
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 6 Dec 2010 18:29:46 +0000 (18:29 +0000)]
Remove an unused include.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35129
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 6 Dec 2010 17:30:08 +0000 (17:30 +0000)]
Fix bug #5463 (and likely others) so that ep_strbuf_new() no longer
truncates newly created and copied strings. The problem was that
strlen() (which returns a length not counting the NULL terminator) was
being mixed with functions that do malloc() (which need to allocate
memory large enough to inculde the NULL string terminator).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35128
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 6 Dec 2010 15:57:39 +0000 (15:57 +0000)]
From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5372 :
Fix crash in LDAP dissector, in a generic way (for all callers of
dissect_nt_sid()).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35127
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 6 Dec 2010 01:34:58 +0000 (01:34 +0000)]
Fix various typos and spelling errors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35126
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Sun, 5 Dec 2010 23:34:11 +0000 (23:34 +0000)]
Add more PHY attributes to MAC frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35125
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 5 Dec 2010 17:32:19 +0000 (17:32 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-12-05]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35122
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 5 Dec 2010 16:03:43 +0000 (16:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-12-05]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35120
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 4 Dec 2010 02:54:59 +0000 (02:54 +0000)]
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5429 :
Until now the info column only shows the OPC UA transport protocol type (Hello,
Ack, Secure Conversion message).
After connections establishment has finished this column shows only Secure
Conversion message, because every service is sent over the secure channel.
This patch adds the useful support of displaying the service type in the info
column. This makes it easier to find specific service calls in huge capture
files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35119
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 4 Dec 2010 02:54:25 +0000 (02:54 +0000)]
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5427 :
This patch adds support for dissecting all Extension Objects types defined by
the OPC Foundation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35118
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 3 Dec 2010 23:44:35 +0000 (23:44 +0000)]
From Allan M. Madsen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5446 :
Bluetooth ACL packets are not defragmented when the packet boundary flags is set
to 'flushable first fragment'.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35117
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 3 Dec 2010 23:04:45 +0000 (23:04 +0000)]
From Andrew Feren via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5380 :
Comment in the code asked....
/*XXX: 2 bytes skipped ?? */
Here is what I have found.
The high byte (1) indicates the Classification Engine ID
The low bytes (3) indicate the application ID
Engine ID of 5 is NBAR Standard.
Engine ID of 6 is NBAR Custom.
Attached patch displays all 4 bytes (type and ID) in a readable way. Also
allows better filtering.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35116
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 3 Dec 2010 22:59:16 +0000 (22:59 +0000)]
Fix a problem noticed in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5380#c2 :
Don't attempt to use a BASE_CUSTOM field's 'strings' field as a
value_string: it's not, it's a pointer to a function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35115
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 3 Dec 2010 22:19:58 +0000 (22:19 +0000)]
After applying GUI preferences, reset the welcome screen's header message
in case the show version in welcome screen option was toggled.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35114
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 3 Dec 2010 21:52:05 +0000 (21:52 +0000)]
Change default for "Welcome screen and title bar shows version" to on per
discussion in this thread on the wireshark-dev mailing list:
http://www.wireshark.org/lists/wireshark-dev/201011/msg00151.html
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35113
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 3 Dec 2010 20:37:34 +0000 (20:37 +0000)]
Fix spelling errors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35112
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 3 Dec 2010 20:32:17 +0000 (20:32 +0000)]
Fix a typo & do whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35111
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 3 Dec 2010 18:48:05 +0000 (18:48 +0000)]
Don't assume everyone knows what Wireshark is.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35110
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 3 Dec 2010 18:47:10 +0000 (18:47 +0000)]
Don't include epan/emem.h twice.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35109
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 3 Dec 2010 17:31:58 +0000 (17:31 +0000)]
Change the Wireshark stock icon description from "Auto Scroll in Live Capture"
to "Auto Scroll" to save space in the main toolbar. Leave the rest of the
references (such as in the view menu) as they were.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35108
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 3 Dec 2010 16:56:04 +0000 (16:56 +0000)]
Sync from samba git:
========
f99c009..
189b4bc =========
commit
135756c8ac34c4cf82992dce8c7218781e67f39b
Author: Andrew Tridgell <tridge@samba.org>
Date: Fri Nov 5 11:52:20 2010 +1100
pidl: use a union assignment instead of memmove
this means we don't lose type checking
Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
commit
3bff03723d8920faece76dd57bcf5d19b84d7b02
Author: Jelmer Vernooij <jelmer@samba.org>
Date: Tue Nov 30 23:48:46 2010 +0100
pidl/python: Allow import of talloc, even though it doesn't live in the
samba.dcerpc. namespace.
commit
ba2110d19060c4d84656917eb6be7b78afc6df6b
Author: Jelmer Vernooij <jelmer@samba.org>
Date: Tue Nov 30 23:06:32 2010 +0100
pidl: Allow more flexibility importing modules using convenience function.
commit
dd0fbc47c798acfb003e37afbee5f0748e30ad1b
Author: Jelmer Vernooij <jelmer@samba.org>
Date: Tue Nov 30 22:59:32 2010 +0100
pidl: Base new objects off of talloc object.
commit
a3ed70ff96122531ba000123cdf3992d26663f30
Author: Andrew Tridgell <tridge@samba.org>
Date: Sun Nov 21 23:05:07 2010 +1100
pidl: fixed call to cpp with a space in the directory name
=============================
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35107
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 3 Dec 2010 07:14:04 +0000 (07:14 +0000)]
From Fred Fierling:
Fixes invalid long address mappings in NWK layer.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5456
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35106
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 2 Dec 2010 20:44:18 +0000 (20:44 +0000)]
From Gerhard Gappmeier:
Fix mapping of datatype strings in opcua plugin
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5428
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35105
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 2 Dec 2010 20:05:19 +0000 (20:05 +0000)]
Allow more than one instance of Wireshark to be started. For now, the stuff
that disallowed it is just commented out. Later, we might choose to make use
of AllowMultipleInstances like other portableapps do, such as Firefox, et al.
This change was made as a result of the following query on the -users list:
http://www.wireshark.org/lists/wireshark-users/201012/msg00008.html
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35104
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 2 Dec 2010 14:35:11 +0000 (14:35 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5460 :
MongoDB dissector improperly decodes cursorID in OP_KILL_CURSORS command.
The size of the CursorID is 64 bits, while the code assumes they are 4 bits,
though correctly incrementing the pointer. Fix this typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35103
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 2 Dec 2010 12:39:24 +0000 (12:39 +0000)]
From Slava:
Incorrectly registered range string in sdp infiniband dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5461
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35102
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 2 Dec 2010 03:22:45 +0000 (03:22 +0000)]
Remove an incorrect (uninformed) comment recently added my me.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35101
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 2 Dec 2010 01:38:50 +0000 (01:38 +0000)]
Windows 'File ! Save_As': Error popup if saving to name of open capture file and also
error popup if delete of existing file fails.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35100
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 1 Dec 2010 23:30:06 +0000 (23:30 +0000)]
From Zachary Mark via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5457 :
The scsi_persresv_type_val field in packet-scsi.c contains a mapping of
persistent reservation opcodes to their descriptive types. The opcode for the
Exclusive Access - Registrants Only field is incorrectly set to 7, when the
correct opcode is 6 (as per SPC-2 onward). The attached patch corrects this
discrepancy.
The attached patch also adds support for dissecting opcodes 7 and 8, the two
all registrants reservation types present in SPC-3 onward.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35099
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 1 Dec 2010 23:26:07 +0000 (23:26 +0000)]
From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
The information which is used to determine which sub-dissector to use for the
various Data messages within an SCCP connection is only present within the
initial Connection Request, so even with connection tracking on, unless the
trace contains the Connection Request no sub-dissector is called. It is common
for traces to only contain a single carried protocol anyway - e.g. RANAP.
The supplied patch adds a user preference for a "default payload"
sub-dissector, which is called in preference to the Data dissector if nothing
else has claimed the packet first.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35098
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 1 Dec 2010 23:12:46 +0000 (23:12 +0000)]
From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
The packet-sccp.c has a bug in the declared valid ranges of the SSN and DPC
values in the user table used to match to a subdissector. The SSN range is 16
bits rather than 8 (not really an issue) but the DPC range is 16 bits rather
than 24 - so many traces cannot be matched by this table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35097
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 1 Dec 2010 21:42:19 +0000 (21:42 +0000)]
Add details to the table of Microsoft Visual C++ compilers (Win32 native tool chain) for Visual C++ 2010 Express and Professional.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35096
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 1 Dec 2010 21:21:33 +0000 (21:21 +0000)]
Change underscore to dash to show correct docbook-xml42 package in Cygwin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35095
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 1 Dec 2010 20:48:44 +0000 (20:48 +0000)]
Now the Microsoft Visual C++ 2010 redistributable for x86 (32-bit) brings up a confusing dialog asking the user to repair or remove it if it's already installed. Change it to (re-)install quietly (/q command-line option) like we do with the 64-bit version.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35094
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 1 Dec 2010 18:25:18 +0000 (18:25 +0000)]
Add extern "C" to more header files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35093
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 1 Dec 2010 18:16:41 +0000 (18:16 +0000)]
Add #ifndef __PRIVILEGES_H__ / #define / #endif logic to prevent multiple
inclusions of privileges.h.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35092
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 1 Dec 2010 17:34:26 +0000 (17:34 +0000)]
Delegated-IPv6-Prefix(123) is shown incorrect as X-Ascend-Call-Attempt-Limit(123)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5455
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35091
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 1 Dec 2010 16:39:28 +0000 (16:39 +0000)]
Fix bug #5453 "Help->About Wireshark mis-reports OS" (again) without the help of MSDN code fragments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35090
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 1 Dec 2010 15:48:45 +0000 (15:48 +0000)]
Added Alex Badea for his contribution via bug #4149.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35089
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 1 Dec 2010 15:45:24 +0000 (15:45 +0000)]
From Alex Badea via bug #4149: IPcomp: decompress deflated payloads.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35088
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 1 Dec 2010 02:18:01 +0000 (02:18 +0000)]
Fix a GCC error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35087
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 1 Dec 2010 01:31:49 +0000 (01:31 +0000)]
On Windows: convert _tzname[] strings from the system charset to UTF8 before use.
In the Windows C Runtime the strings in the global array _tzname[]
are encoded using the "system default ansi code page".
They must be converted to UTF8 before use by Wireshark/GTK.
(See comment in the code for details).
Fixes Bug #5421 (I hope).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5421
Also: Fix bug: when the timezone name is not available from the system
?ST was used when ?DT should have been used (and vice-versa).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35086
f5534014-38df-0310-8fa8-
9805f1628bb7