obnox/wireshark/wip.git
14 years agoFrom Michel Marti:
jake [Thu, 30 Nov 2006 07:12:59 +0000 (07:12 +0000)]
From Michel Marti:
The attached patch fixes decoding of the "X-Mms-Reply-Charging-Deadline" header.
According to the OMA-TS-MMS-ENC specs, this header is encoded like this:
  Reply-charging-deadline-value = Value-length \
    (Absolute-token Date-value | Relative-token Delta-seconds-value)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20019 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAllow the sub-dissector to be called for decrypted SSL data even when tree is
sfisher [Thu, 30 Nov 2006 02:29:31 +0000 (02:29 +0000)]
Allow the sub-dissector to be called for decrypted SSL data even when tree is
null.  This allows the encrypted payload's dissector to fill in columns such
as protocol and info without turning on packet coloring or otherwise rescanning
the packet list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20018 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom the wishlist: add basic find functionality to the follow tcp & ssl stream
sfisher [Wed, 29 Nov 2006 20:45:02 +0000 (20:45 +0000)]
From the wishlist: add basic find functionality to the follow tcp & ssl stream
dialogs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20017 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some protocol references.
guy [Wed, 29 Nov 2006 16:19:56 +0000 (16:19 +0000)]
Add some protocol references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20016 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd documentation of the col_set_fence() and col_prepend_fence_fstr() calls. I ...
morriss [Wed, 29 Nov 2006 13:42:16 +0000 (13:42 +0000)]
Add documentation of the col_set_fence() and col_prepend_fence_fstr() calls.  I *think* I got the description of col_prepend_fence_fstr() right.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20015 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Reinhard Speyerer:
etxrab [Wed, 29 Nov 2006 06:53:48 +0000 (06:53 +0000)]
From Reinhard Speyerer:
this patch adds support for Any-encoding (WSP, 8.4.2.9) and Any-language (WSP, 8.4.2.10)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20014 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFroim Rene Pilz:
etxrab [Wed, 29 Nov 2006 06:44:07 +0000 (06:44 +0000)]
Froim Rene Pilz:
This patch consists also the last issues. Additionally it solves:
- For the SSCOP frames the AAL5 decoding was not performed due to an earlier patch. This caused that no SSCOP message was properly decoded.
- As the detection between a LANE frame and a SSCOP frame is rather hard a switch within the atm dissector is included which enforce SSCOP dissecting over a LANE frame. At the moment I do not see a better solution for that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20013 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo and handling of unknown TerminationStatedescriptors.
etxrab [Tue, 28 Nov 2006 20:43:25 +0000 (20:43 +0000)]
Fix a typo and handling of unknown TerminationStatedescriptors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20012 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd description of proto_tree_add_bitmask()
sahlberg [Tue, 28 Nov 2006 09:09:58 +0000 (09:09 +0000)]
add description of proto_tree_add_bitmask()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20011 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Richard Braun:
etxrab [Tue, 28 Nov 2006 06:31:07 +0000 (06:31 +0000)]
From Richard Braun:
The Q931 dissector applies a wrong mask when testing the odd/even indicator bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20010 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoComplete the SIP application AVP:s.
etxrab [Tue, 28 Nov 2006 05:59:24 +0000 (05:59 +0000)]
Complete the SIP application AVP:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20009 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissection of two streams in the media descriptor was broken.
etxrab [Tue, 28 Nov 2006 05:53:00 +0000 (05:53 +0000)]
Dissection of two streams in the media descriptor was broken.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20008 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse val_to_str() instead of match_strval().
gerald [Tue, 28 Nov 2006 01:18:47 +0000 (01:18 +0000)]
Use val_to_str() instead of match_strval().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20007 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe got rid of ldap/Lightweight-Directory-Access-Protocol-V3.asn.orig, so
guy [Mon, 27 Nov 2006 19:42:14 +0000 (19:42 +0000)]
We got rid of ldap/Lightweight-Directory-Access-Protocol-V3.asn.orig, so
don't try to put it into the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20006 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNote that this isn't just cut and pasted from RFC 2251.
guy [Mon, 27 Nov 2006 19:41:07 +0000 (19:41 +0000)]
Note that this isn't just cut and pasted from RFC 2251.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20005 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMap a DLT_ value of 188 to WTAP_ENCAP_IEEE802_16_MAC_CPS, and clarify
guy [Mon, 27 Nov 2006 18:41:45 +0000 (18:41 +0000)]
Map a DLT_ value of 188 to WTAP_ENCAP_IEEE802_16_MAC_CPS, and clarify
what a DLT_ value of 187 is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20004 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Wiretap encapsulation type for IEEE 802.16 MAC Common Part Sublayer,
guy [Mon, 27 Nov 2006 18:10:12 +0000 (18:10 +0000)]
Add Wiretap encapsulation type for IEEE 802.16 MAC Common Part Sublayer,
for which a DLT_ value and LINKTYPE_ value have just been assigned.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20003 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocreate a nice helper to dissect bitmasks and implement some test useage of it in...
sahlberg [Mon, 27 Nov 2006 14:50:23 +0000 (14:50 +0000)]
create a nice helper to dissect bitmasks and implement some test useage of it in the scsi dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20002 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSince this dissector is already 'new style' (it returns FALSE if it thinks the packet...
morriss [Mon, 27 Nov 2006 14:39:06 +0000 (14:39 +0000)]
Since this dissector is already 'new style' (it returns FALSE if it thinks the packet doesn't belong to it), register the dissector with new_create_dissector_handle() instead of create_dissector_handle(), thus fixing a compiler warning.  Also comment out some (currently) unused hf_ fields to get rid warnings about them.  Lastly, [AT]-ify the authors' email addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20001 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobreak the SCSI SBC commandset out into its own dissector
sahlberg [Mon, 27 Nov 2006 11:00:06 +0000 (11:00 +0000)]
break the SCSI SBC commandset out into its own dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20000 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agog_strdup takes one parameter not two
sahlberg [Mon, 27 Nov 2006 09:42:19 +0000 (09:42 +0000)]
g_strdup takes one parameter not two

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19999 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove unused variable: tooltips
sahlberg [Mon, 27 Nov 2006 09:40:08 +0000 (09:40 +0000)]
remove unused variable:  tooltips

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19998 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove file that is not used
sahlberg [Mon, 27 Nov 2006 09:00:01 +0000 (09:00 +0000)]
remove file that is not used

bug 1247

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19997 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix property typos:
wmeier [Mon, 27 Nov 2006 00:13:09 +0000 (00:13 +0000)]
fix property typos:
     eol-type  --> svn:eol-style
  sv:eol-style --> svn:eol-style
  svn:eol-type --> svn:eol-style

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19996 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWrap the declaration for tree_view_key_pressed_cb() in an #if/#endif.
gerald [Sun, 26 Nov 2006 20:29:24 +0000 (20:29 +0000)]
Wrap the declaration for tree_view_key_pressed_cb() in an #if/#endif.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19995 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake keyboard navigation common for all tree views (for GTK2, at least).
gerald [Sun, 26 Nov 2006 20:26:09 +0000 (20:26 +0000)]
Make keyboard navigation common for all tree views (for GTK2, at least).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19994 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix property typo: svm:keywords --> svn:keywords
wmeier [Sun, 26 Nov 2006 18:53:35 +0000 (18:53 +0000)]
Fix property typo: svm:keywords --> svn:keywords

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19993 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some property typos (eg: svn:kwywords, swn:keywords, etc)
wmeier [Sun, 26 Nov 2006 18:31:53 +0000 (18:31 +0000)]
Fix some property typos (eg: svn:kwywords, swn:keywords, etc)
Add 'svn:eol-style native' for a few .[hc] files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19992 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix compiler warning
wmeier [Sun, 26 Nov 2006 18:20:51 +0000 (18:20 +0000)]
fix compiler warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19991 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoClean up a bunch of unused parameter warnings and 2 uninitialized variable warnings
morriss [Sun, 26 Nov 2006 14:27:13 +0000 (14:27 +0000)]
Clean up a bunch of unused parameter warnings and 2 uninitialized variable warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19990 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange to show how to write a 'new style' dissector (that is, one that returns the...
morriss [Sun, 26 Nov 2006 14:00:01 +0000 (14:00 +0000)]
Change to show how to write a 'new style' dissector (that is, one that returns the number of bytes it was able to dissect).  I think the Developer's Guide (docbook/) probably needs similar updates but I'm a bit shy about editing XML with good old vi; maybe if I can figure out if I can build the doc in the first place...  Also rewrap a few pararaphs that went past 80 columns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19989 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf we found that the packet does not belong to Skinny (new style dissector), there...
morriss [Sun, 26 Nov 2006 13:36:03 +0000 (13:36 +0000)]
If we found that the packet does not belong to Skinny (new style dissector), there's no need to call call_dissector(data_handle, ...) before returning FALSE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19988 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stefan Metzmacher:
jake [Sun, 26 Nov 2006 13:24:07 +0000 (13:24 +0000)]
From Stefan Metzmacher:
I have a little additional patch, that makes it easier to see what which bytes
are not caught by the sub_dissector.
And it makes it easy to select and export the full payload to a file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19987 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stefan Metzmacher:
jake [Sun, 26 Nov 2006 13:22:14 +0000 (13:22 +0000)]
From Stefan Metzmacher:
2nd try: implement dissection of SMB_NETLOGON cmd's 0x17 and 0x19

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19986 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoU3 Packaging update for
gal [Sun, 26 Nov 2006 09:04:00 +0000 (09:04 +0000)]
U3 Packaging update for
a) Packaging changes - including the latest GTK/GLIB/PANGO libaries
b) File associations - made when Wireshark is first run and removed when device is removed.
c) Install WinPcap - by running the installer if WinPcap is not installed. Uninstalled (if the U3 device installed it) when the device is removed. (This is an interim approach until the appropriate WinPcap U3 installation can be determined).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19985 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBug 1246: From Eric Hall, fix typo: s/NETSNMPCNFIG/NETSNMPCONFIG/
morriss [Sun, 26 Nov 2006 08:28:09 +0000 (08:28 +0000)]
Bug 1246: From Eric Hall, fix typo: s/NETSNMPCNFIG/NETSNMPCONFIG/

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19984 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProblem:
wmeier [Sun, 26 Nov 2006 00:23:50 +0000 (00:23 +0000)]
Problem:
"off by 1" bug in
   packet-smb-common.c:  dissect_ms_compressed_string_internal()
was causing a 1 character buffer overflow thus causing the canary to sing !

Fixes bug #1241

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19983 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake dissecton of some of the annex packages work again.
etxrab [Sat, 25 Nov 2006 13:07:28 +0000 (13:07 +0000)]
Make dissecton of some of the annex packages work again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19982 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Julian Cable:
etxrab [Sat, 25 Nov 2006 13:03:48 +0000 (13:03 +0000)]
From Julian Cable:
New dissector for ETSI DCP (ETSI TS 102 821).

Code rearranged to look more like other Wireshark dissectors and some warnings/errors
on Windows fixed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19981 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Eliot Blennerhassett :
etxrab [Sat, 25 Nov 2006 12:04:21 +0000 (12:04 +0000)]
From   Eliot Blennerhassett :
Add Cirrus cobranet ethertype

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19980 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19759 to 19883
jmayer [Sat, 25 Nov 2006 10:35:39 +0000 (10:35 +0000)]
Update from samba tree revision 19759 to 19883
============================ Samba log start ============
------------------------------------------------------------------------
r19790 | vlendec | 2006-11-19 18:56:35 +0100 (Sun, 19 Nov 2006) | 10 lines
Changed paths:
   M /branches/SAMBA_3_0/source/libmsrpc/cac_winreg.c
   M /branches/SAMBA_3_0/source/librpc/gen_ndr/cli_unixinfo.c
   M /branches/SAMBA_3_0/source/librpc/gen_ndr/cli_unixinfo.h
   M /branches/SAMBA_3_0/source/librpc/gen_ndr/cli_winreg.c
   M /branches/SAMBA_3_0/source/librpc/gen_ndr/cli_winreg.h
   M /branches/SAMBA_3_0/source/librpc/gen_ndr/ndr_winreg.c
   M /branches/SAMBA_3_0/source/librpc/gen_ndr/winreg.h
   M /branches/SAMBA_3_0/source/rpcclient/cmd_unixinfo.c
   M /branches/SAMBA_3_0/source/utils/net_rpc_registry.c
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4.pm

Check in the PIDL change and the converted unixinfo and winbind pipes without
waiting for comments. This is what version control is for, and it does fix a
segfault I ran into ;-)

Nevertheless, Jelmer & Jerry, please take a look!

Thanks,

Volker

------------------------------------------------------------------------
r19829 | jelmer | 2006-11-22 00:15:57 +0100 (Wed, 22 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/pidl

Update documentation.

------------------------------------------------------------------------
r19830 | jelmer | 2006-11-22 00:21:08 +0100 (Wed, 22 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

Warn about non-ref top-level pointers.

------------------------------------------------------------------------
r19834 | jelmer | 2006-11-22 14:59:14 +0100 (Wed, 22 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

Prevent some inaccurate warnings.

------------------------------------------------------------------------
r19842 | jelmer | 2006-11-22 17:53:30 +0100 (Wed, 22 Nov 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

Complain about unknown pointer types.
Fallback to "unique" when "ptr" is specified instead of failing.

------------------------------------------------------------------------
r19845 | jelmer | 2006-11-22 18:13:19 +0100 (Wed, 22 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

Add warning for pointer_default_top()

------------------------------------------------------------------------
r19854 | metze | 2006-11-23 14:11:08 +0100 (Thu, 23 Nov 2006) | 4 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

readd support for 'sptr' pointers, to work against windows servers
until jelmer commits his 'ptr' support

metze
------------------------------------------------------------------------
r19856 | jelmer | 2006-11-23 14:48:01 +0100 (Thu, 23 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/librpc/idl/epmapper.idl
   M /branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm

Use sptr as basis for full ptr implementation. Will add checks for duplicates later.

------------------------------------------------------------------------
r19859 | jelmer | 2006-11-23 17:02:20 +0100 (Thu, 23 Nov 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/librpc/ndr/libndr.h
   M /branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c
   M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
   A /branches/SAMBA_4_0/source/pidl/tests/ndr_fullptr.pl

Reuse referrent ids when pushing full pointers (still need to
avoid pushing the referred object twice) and add test for full pointers.

------------------------------------------------------------------------
r19866 | jelmer | 2006-11-23 19:26:55 +0100 (Thu, 23 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/tests/ndr_fullptr.pl

Fix test compilation.

------------------------------------------------------------------------
r19868 | jelmer | 2006-11-23 21:59:09 +0100 (Thu, 23 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
   M /branches/SAMBA_4_0/source/pidl/tests/ndr_align.pl
   M /branches/SAMBA_4_0/source/pidl/tests/ndr_represent.pl
   M /branches/SAMBA_4_0/source/pidl/tests/ndr_string.pl

Fix more tests.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19979 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure we don't trigger undefined behavior in isprint().
gerald [Sat, 25 Nov 2006 06:15:51 +0000 (06:15 +0000)]
Make sure we don't trigger undefined behavior in isprint().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19978 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlso required to fix Win32 build problem
wmeier [Fri, 24 Nov 2006 18:47:50 +0000 (18:47 +0000)]
Also required to fix Win32 build problem

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19977 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHave separate proto_construct_match_selected_string() and
guy [Fri, 24 Nov 2006 18:25:23 +0000 (18:25 +0000)]
Have separate proto_construct_match_selected_string() and
proto_can_match_selected() routines, to more clearly separate the two
functions - but have them both call the same underlying routine, so
they both make the same decisions as to whether a match-selected string
can be constructed or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19976 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnother fix for Win32 build: add scsi_osd_vals
wmeier [Fri, 24 Nov 2006 17:41:09 +0000 (17:41 +0000)]
Another fix for Win32 build: add scsi_osd_vals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19975 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Peter Johansson:
jake [Fri, 24 Nov 2006 11:07:39 +0000 (11:07 +0000)]
From Peter Johansson:
The attached patch corrects the Win32 compilation problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19974 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd some missing commandsets to the preference for default commandset and to the...
sahlberg [Fri, 24 Nov 2006 08:22:30 +0000 (08:22 +0000)]
add some missing commandsets to the preference for default commandset and to the scsi srt statistics

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19973 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Patrick vd Lageweg:
jake [Fri, 24 Nov 2006 07:28:02 +0000 (07:28 +0000)]
From Patrick vd Lageweg:
This patch fixes a simple typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19972 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stefan Metzmacher:
jake [Fri, 24 Nov 2006 07:16:06 +0000 (07:16 +0000)]
From Stefan Metzmacher:
This patch fixes some problems with encrypted DCERPC traffic

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19971 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stefan Metzmacher:
jake [Fri, 24 Nov 2006 07:09:38 +0000 (07:09 +0000)]
From Stefan Metzmacher:
I created two patches:
1.) move the handling of the compressed strings in CLDAP 'netlogon' replies into a generic place.
2.) implement dissection of SMB_NETLOGON cmd's 0x17 and 0x19

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19970 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug #940. Convert HSRP to a new-style dissector so that it can
sfisher [Fri, 24 Nov 2006 06:04:01 +0000 (06:04 +0000)]
Fix for bug #940.  Convert HSRP to a new-style dissector so that it can
reject datagrams that don't have both the source and destination port
of UDP_PORT_HSRP (1985).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19969 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug #646: show the end of HTTP chunked encoding (a chunk with size 0)
sfisher [Fri, 24 Nov 2006 02:59:43 +0000 (02:59 +0000)]
Fix for bug #646: show the end of HTTP chunked encoding (a chunk with size 0)
as described in RFC 2616.

-This line, and those below, will be ignored--

M    packet-http.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19968 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename proto_construct_dfilter_string() to
guy [Thu, 23 Nov 2006 21:16:46 +0000 (21:16 +0000)]
Rename proto_construct_dfilter_string() to
proto_construct_match_selected_string() to indicate what it does - and
have it return a Boolean indication of whether the string could be
built, returning the string through a pointer, and, if that pointer is
null, have it just return the Boolean and not construct the string.

Get rid of proto_can_match_selected() -
proto_construct_match_selected_string() can be used for that, which
means we have only one piece of code that knows whether a "match
selected" string can be constructed or not.

Have proto_construct_match_selected_string() support matching
zero-length FT_NONE (and FT_PCRE, but that shouldn't happen) fields even
if there's no epan_dissect_t, as such a match just checks whether the
field is present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19967 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoShow the header size as number of bytes.
etxrab [Thu, 23 Nov 2006 20:17:58 +0000 (20:17 +0000)]
Show the header size as number of bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19966 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoErrase the lua plugin, its not longer in use.
lego [Thu, 23 Nov 2006 12:58:58 +0000 (12:58 +0000)]
Errase the lua plugin, its not longer in use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19965 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobreak the SCSI SMC commandset out into its own dissector
sahlberg [Thu, 23 Nov 2006 09:21:16 +0000 (09:21 +0000)]
break the SCSI SMC commandset out into its own dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19964 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBack out most of r19878; it was making the 802.11 dissector overwrite the
gerald [Thu, 23 Nov 2006 01:49:18 +0000 (01:49 +0000)]
Back out most of r19878; it was making the 802.11 dissector overwrite the
RSSI column with the wrong value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19963 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug #1211. Patch from Joshua Wright to add -S option to tshark's
sfisher [Thu, 23 Nov 2006 01:45:51 +0000 (01:45 +0000)]
Fix for bug #1211.  Patch from Joshua Wright to add -S option to tshark's
usage description (-h).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19962 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen checking whether a field supports "match selected", do the same
guy [Thu, 23 Nov 2006 00:15:49 +0000 (00:15 +0000)]
When checking whether a field supports "match selected", do the same
checks that we do when we try to construct the filter expression for
"match selected" - this means we don't just assert that all FT_NONEs are
filterable, as they aren't.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19961 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Cyril Margaria:
etxrab [Wed, 22 Nov 2006 23:20:11 +0000 (23:20 +0000)]
From Cyril Margaria:
Patch to support RSVP notify and added a few error codes, with some more objectcodes
added.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19960 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake the "standard" case in proto_can_match_selected() and
guy [Wed, 22 Nov 2006 22:11:38 +0000 (22:11 +0000)]
Make the "standard" case in proto_can_match_selected() and
proto_construct_dfilter_string() the default, so you add explicit cases
only when the type needs to be treated specially, so we don't end up
with types where we forget to have a case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19959 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix Win32 build: scsi_ssc2_vals -> scsi_ssc_vals
ulfl [Wed, 22 Nov 2006 20:52:40 +0000 (20:52 +0000)]
fix Win32 build: scsi_ssc2_vals -> scsi_ssc_vals

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19958 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobreak the SCSI SSC commandset out into its own dissector
sahlberg [Wed, 22 Nov 2006 10:12:59 +0000 (10:12 +0000)]
break the SCSI SSC commandset out into its own dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19957 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agossc space6 count is a signed integer
sahlberg [Wed, 22 Nov 2006 09:00:36 +0000 (09:00 +0000)]
ssc space6 count is a signed integer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19956 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Michael Lum
etxrab [Wed, 22 Nov 2006 06:39:24 +0000 (06:39 +0000)]
From Michael Lum

1)
A small change in the number of teleservices recognized

2)
Finally finished a lot of the changes for IOS 5 support.

The attached files must be used together.

Built in Windows XP Pro using Visual Studio C++ with the latest repository.

packet-ansi_map.c.gz

packet-ansi_a.gz
    This file contains both packet-ansi_a.c and packet-ansi_a.h changes.

libwireshark.def.gz

ansi_a_stat.c.gz

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19955 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert changes to have named bits in the bitstring of unknown length.
etxrab [Tue, 21 Nov 2006 22:18:12 +0000 (22:18 +0000)]
Revert changes to have named bits in the bitstring of unknown length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19954 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix pluralization of "bytes" so it doesn't say "1 bytes".
guy [Tue, 21 Nov 2006 21:49:58 +0000 (21:49 +0000)]
Fix pluralization of "bytes" so it doesn't say "1 bytes".

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19953 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix for bug 1226:
sahlberg [Tue, 21 Nov 2006 21:11:18 +0000 (21:11 +0000)]
fix for bug 1226:
reported by Benjamin Meyer

WireShark marks DCE RPC FACKs as "malformed" if they do not have a body.
According to DCE RPC Spec. 1.1 FACKs "may contain" a body PTU.

I am unable to build WireShark (lack of time to install all neccessary stuff)
but I looked at the SourceCode. I think, at least this has to be fixed:

file: epan/dissectors/packet-dcerpc.c
function: static gboolean dissect_dcerpc_dg (tvbuff_t *tvb, packet_info *pinfo,
proto_tree *tree)

*snip*
case PDU_FACK
dissect_dcerpc_dg_fack (tvb, offset, pinfo, dcerpc_tree, &hdr);
break;
*snap*

I guess, it should look like "case PDU_NOCALL:" directly above.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19952 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Bill Florac:
etxrab [Tue, 21 Nov 2006 21:00:25 +0000 (21:00 +0000)]
From Bill Florac:
Here is a patch for the ACN dissector. It fixes a bug in
acn_add_expiry() and cleans up some cosmetic things.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19951 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf you're doing TCP reassembly by hand rather than with
guy [Tue, 21 Nov 2006 20:10:10 +0000 (20:10 +0000)]
If you're doing TCP reassembly by hand rather than with
tcp_dissect_pdus(), pinfo->desegment_len indicates whether your
dissector needs more data from TCP or not - the return value doesn't
indicate that.

Fix typo.

It appears that the Id keyword is one of the case-insensitive ones in
the svn:keywords property, so if you set it to "ID" it still expands
"$Id$"; it also appears not to expand "$ID$".  We use Revision, Date,
and Author in the document to indicate the revision, and don't expand
Id, so that references to "$Id$" get left alone.

Rewrap paragraphs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19950 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCorrect comments and examples on get_pdu_len().
jake [Tue, 21 Nov 2006 14:18:46 +0000 (14:18 +0000)]
Correct comments and examples on get_pdu_len().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19949 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Japan SS7 variant to list of things I contributed (and verify this whole commit...
morriss [Tue, 21 Nov 2006 13:37:13 +0000 (13:37 +0000)]
Add Japan SS7 variant to list of things I contributed (and verify this whole commit thing works :-))

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19948 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPatrick vd Lageweg <patrick@bitwizard.nl>
sahlberg [Tue, 21 Nov 2006 09:18:28 +0000 (09:18 +0000)]
Patrick vd Lageweg <patrick@bitwizard.nl>

Hi,

The rease/release commands are also usable on SSC devices. This patch adds them to the valid SSC command.

        Patrick
_______________________________________________

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19947 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom: Burlyga, Alex
sahlberg [Tue, 21 Nov 2006 08:53:11 +0000 (08:53 +0000)]
From: Burlyga, Alex

Hi,

Attached is a patch for packet-rpc.c and packet-rpc.h.
Update support for pseudo-flavors that used in RPCSEC_GSS
Also fixed a problem where rpc.reqframe and rpc.repframe where
reversed.

Alex.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19946 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agothe result code, encoded within the userdata is in network byte order not little...
sahlberg [Tue, 21 Nov 2006 08:44:21 +0000 (08:44 +0000)]
the result code, encoded within the userdata is in network byte order not little endian.

this makes a difference for the cases where the result code is not KPASSWD_SUCCESS == 0x0000

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19945 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf a user starts typing text in the main window, append it to the
gerald [Tue, 21 Nov 2006 01:27:29 +0000 (01:27 +0000)]
If a user starts typing text in the main window, append it to the
display filter instead of replacing it.  Check for a valid character
with a simple isprint() instead of a giant boolean expression paragraph.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19944 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agowhile loading a huge capture file, enable the main window to show packets rushing...
ulfl [Tue, 21 Nov 2006 00:45:38 +0000 (00:45 +0000)]
while loading a huge capture file, enable the main window to show packets rushing into the packet list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19943 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoflush out the main event loop at dialog creation, so we don't see an empty dialog...
ulfl [Tue, 21 Nov 2006 00:40:36 +0000 (00:40 +0000)]
flush out the main event loop at dialog creation, so we don't see an empty dialog until the first update

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19942 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the <name> convention for command-line arguments in the usage
guy [Tue, 21 Nov 2006 00:36:35 +0000 (00:36 +0000)]
Use the <name> convention for command-line arguments in the usage
message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19941 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe also need the memory allocation subsystem initialized in anything
guy [Tue, 21 Nov 2006 00:30:36 +0000 (00:30 +0000)]
We also need the memory allocation subsystem initialized in anything
that uses libwireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19940 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCall guids_init() in epan_init(), so anything that needs libwireshark -
guy [Tue, 21 Nov 2006 00:16:44 +0000 (00:16 +0000)]
Call guids_init() in epan_init(), so anything that needs libwireshark -
including dftest - will get the GUID table initialized (which anything
that needs libwireshark needs to have happen, so dissectors can register
GUIDs in that table).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19939 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSquelch a compiler warning.
guy [Tue, 21 Nov 2006 00:00:26 +0000 (00:00 +0000)]
Squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19938 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 1235. Elapsed time is in 10ms units.
jake [Mon, 20 Nov 2006 19:39:19 +0000 (19:39 +0000)]
Fix for bug 1235. Elapsed time is in 10ms units.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19937 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake FT_STRINGZ items work as apply/prepare as filter menu items
martinm [Mon, 20 Nov 2006 14:53:22 +0000 (14:53 +0000)]
Make FT_STRINGZ items work as apply/prepare as filter menu items

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19936 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd exclamation and left parenthesis to the display filter keystroke
gerald [Sun, 19 Nov 2006 23:23:53 +0000 (23:23 +0000)]
Add exclamation and left parenthesis to the display filter keystroke
catcher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19935 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoif the WIRESHARK_LIBS dir isn't already existing, create it
ulfl [Sun, 19 Nov 2006 17:02:31 +0000 (17:02 +0000)]
if the WIRESHARK_LIBS dir isn't already existing, create it

this fixes problems discussed earlier on the list with cygpath

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19934 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix clean_setup target
ulfl [Sun, 19 Nov 2006 16:49:58 +0000 (16:49 +0000)]
fix clean_setup target

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19933 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to the latest versions from sqlite.
etxrab [Sun, 19 Nov 2006 16:24:18 +0000 (16:24 +0000)]
Update to the latest versions from sqlite.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19932 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug #1126. In the SSL dissector, don't just check if we're allowed
sfisher [Sun, 19 Nov 2006 07:41:25 +0000 (07:41 +0000)]
Fix for bug #1126.  In the SSL dissector, don't just check if we're allowed
to desegment, but also check if we need to before attempting it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19931 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf the user starts typing ([a-zA-Z0-9]) anywhere in the main window, start
gerald [Sat, 18 Nov 2006 17:17:28 +0000 (17:17 +0000)]
If the user starts typing ([a-zA-Z0-9]) anywhere in the main window, start
filling in a display filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19930 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix validity of document
ulfl [Sat, 18 Nov 2006 12:30:58 +0000 (12:30 +0000)]
fix validity of document

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19929 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't try to set focus on NULL.
gerald [Sat, 18 Nov 2006 05:19:40 +0000 (05:19 +0000)]
Don't try to set focus on NULL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19928 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGTK1 doesn't have gtk_window_get_focus.
gerald [Sat, 18 Nov 2006 05:12:55 +0000 (05:12 +0000)]
GTK1 doesn't have gtk_window_get_focus.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19927 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake F8 and F7 move to the next and previous packets, which adds
gerald [Sat, 18 Nov 2006 05:05:18 +0000 (05:05 +0000)]
Make F8 and F7 move to the next and previous packets, which adds
compatibility with a different analyzer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19926 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoboth recent fixes of warnings don't compile on Win32, inttypes.h is not available...
ulfl [Sat, 18 Nov 2006 03:37:34 +0000 (03:37 +0000)]
both recent fixes of warnings don't compile on Win32, inttypes.h is not available and PRId64 is not defined in the config.h.win32.

As discussed in a seperate thread the PRId64 should not be required.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19925 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd additional keyboard navigation: Ctrl+Up & Ctrl+Down (under the "Go"
gerald [Sat, 18 Nov 2006 01:47:49 +0000 (01:47 +0000)]
Add additional keyboard navigation: Ctrl+Up & Ctrl+Down (under the "Go"
menu) move to the previous and next packet even if the packet list isn't
in focus (specifically, the packet detail will stay in focus if that was
already the case).  Make the return and enter keys toggle tree items in
the packet detail and the backspace key jump to the parent node.  Add a
navigation section to the User's Guide.

Make SIGNAL_EMIT_BY_NAME a simple #define, so that we can feed it
multiple arguments.  Fix up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19924 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd the /LARGEADDRESSAWARE to the link process of Wireshark(2) and Tshark. See http...
ulfl [Fri, 17 Nov 2006 22:48:21 +0000 (22:48 +0000)]
add the /LARGEADDRESSAWARE to the link process of Wireshark(2) and Tshark. See msdn.microsoft.com/library/default.asp?url=/library/en-us/memory/base/physical_address_extension.asp how to enable 3GB support on several Windows versions - I will update the OutOfMemory Wiki page accordingly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19923 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd dissection for PROFINET "PTCP Status"
ulfl [Fri, 17 Nov 2006 22:38:34 +0000 (22:38 +0000)]
add dissection for PROFINET "PTCP Status"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19922 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to squash 2 more warnings seen on buildot
martinm [Fri, 17 Nov 2006 16:33:43 +0000 (16:33 +0000)]
Try to squash 2 more warnings seen on buildot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19921 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19744 to 19759
jmayer [Fri, 17 Nov 2006 09:29:36 +0000 (09:29 +0000)]
Update from samba tree revision 19744 to 19759
============================ Samba log start ============
------------------------------------------------------------------------
r19751 | jelmer | 2006-11-16 23:11:32 +0100 (Thu, 16 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/tests/parse_idl.pl

Add some tests for parsing the "include", "import" and "importlib" statements.

------------------------------------------------------------------------
r19752 | jelmer | 2006-11-16 23:13:44 +0100 (Thu, 16 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Remove support for the `depends' attribute (use "import") instead.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19920 f5534014-38df-0310-8fa8-9805f1628bb7