git.samba.org - obnox/wireshark/wip.git/log

git.samba.org / obnox / wireshark / wip.git / log

sfisher [Fri, 28 Jan 2011 20:15:41 +0000 (20:15 +0000)]

Remove the remaining tvb_fake_unicode() calls in the dissector source.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35692 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 28 Jan 2011 20:12:12 +0000 (20:12 +0000)]

Fix r35690: tvb_get_unicode_string() takes length in 8-bit bytes, not
16-bit UTF-16 characters as tvb_fake_unicode() did.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35691 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 28 Jan 2011 20:07:18 +0000 (20:07 +0000)]

Change tvb_fake_unicode() to tvb_get_unicode_string() in the DCERPC
DRSUAPI dissector. Updated the packet-dcerpc-drsuapi.c file manually
because it used to be auto-generated, but appears to have had changes
since then.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35690 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 28 Jan 2011 20:01:01 +0000 (20:01 +0000)]

Mention that the fake tvb unicode functions have been superceded

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35689 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Fri, 28 Jan 2011 18:42:49 +0000 (18:42 +0000)]

Add an option to enable Code Analysis for C/C++ (MSVC's static analyzer).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35688 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Fri, 28 Jan 2011 00:21:05 +0000 (00:21 +0000)]

Use the correct processor architecture in our manifest. This lets us
create a usable wireshark.exe for x64 using Visual C++ 10. Change the
name of VCREDIST_DLL to PROCESSOR_ARCHITECTURE to more accurately
reflect what it's used for. Allow MSVC_VARIANT to be set from the
system environment, mainly to keep me from accidentally clobbering it
in the future.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35687 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 28 Jan 2011 00:20:37 +0000 (00:20 +0000)]

Fix bug #5627: DHCPv6 dissector formats DUID_LLT time incorrectly

Add 30 years of seconds, not 20 years, since the DHCP_LLT time is seconds
since Jan 1 2000 and epoch is 30 years before that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35686 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Thu, 27 Jan 2011 19:04:14 +0000 (19:04 +0000)]

Fix chekcAPIs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35685 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Thu, 27 Jan 2011 17:45:45 +0000 (17:45 +0000)]

From Johannes Berg via bug 5625:

The radiotap standard just adopted the new MCS field to display MCS
information. The attached patch allows wireshark to parse that field.

From me:

Terminate value_strings. Move the IEEE80211_RADIOTAP_XCHANNEL definition
to packet-radiotap-defs.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35684 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Thu, 27 Jan 2011 17:31:41 +0000 (17:31 +0000)]

Use g_error() (with a hopefully-useful error message) instead of g_assert() to report problems with preference registrations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35683 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Thu, 27 Jan 2011 16:09:24 +0000 (16:09 +0000)]

Improve/rework the way we look for the original frame when there is a DL. retransmission.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35682 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Jan 2011 16:08:41 +0000 (16:08 +0000)]

From Roberto Morro: RSVP dissector enhancements

- add new PROTECTION obj c-type 2 (RFC4872)
- add new TLVs for IF_ID (RFC4920)
- add Path Key subobj in ERO (RFC5520)
- add new ASSOCIATION obj c-type 4 (oif2008.389)
- add new LSP_ATTRIBUTES and LSP_REQUIRED_ATTRIBUTES objects (RFC5420)
- improved ERROR object dissection and new error values added
- ADMIN_STATUS transformed to filter and new flags added
- minor fix to conversation (not applied to ACK, SREFRESH and HELLO messages)
to resolv displaying of "Unknown session type" string in such messages

Moreover, I've deleted some "enum" statements for error values that I thought
they were useless since they were used only once throughout the RSVP dissector
code.

See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5518

From me: fix two typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35681 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 27 Jan 2011 15:48:02 +0000 (15:48 +0000)]

Don't treat the aligned and unaligned bit strings differently
always padd LSBs.
Hopfully this does not break anything else...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35680 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 27 Jan 2011 15:43:55 +0000 (15:43 +0000)]

The attemt to pretify MSISDN and IMSI breaks the dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5593

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35679 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Jan 2011 14:41:38 +0000 (14:41 +0000)]

From Masatake YAMATO: Updating value_string for dlm3.m.result

... some values are added to value_string table for
dlm3.m.result. It reflects the latest dlm code in linux kernel.

See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5623

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35678 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 27 Jan 2011 11:23:22 +0000 (11:23 +0000)]

Fix a typo and prettify some printouts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35677 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Thu, 27 Jan 2011 07:45:31 +0000 (07:45 +0000)]

Removed duplicate hf_gsm_a_bssmap_lsa_only registry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35676 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Thu, 27 Jan 2011 07:26:21 +0000 (07:26 +0000)]

Missing a Users Guide graphic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35675 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 27 Jan 2011 03:39:16 +0000 (03:39 +0000)]

From Stéphane Bryant: bug fixes and improvements in RELOAD dissector:
*Bug Fixes
*NodeId length is now configurable
*Added missing messages

See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5620

From me:
-Remove trailing blanks from a few lines;
-Put "editor mode lines" at the end of the source file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35674 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 26 Jan 2011 23:11:08 +0000 (23:11 +0000)]

Fix compilation errors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35673 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

tuexen [Wed, 26 Jan 2011 21:21:16 +0000 (21:21 +0000)]

Add expert info related to gap ack blocks.
Based on a patch submitted by Thomas Dreibholz.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5616

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35672 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Wed, 26 Jan 2011 21:20:09 +0000 (21:20 +0000)]

Sharpen the description of preference names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35671 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 26 Jan 2011 21:00:06 +0000 (21:00 +0000)]

Add MS-SMB2 to the list of URLs to reference for this protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35670 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 26 Jan 2011 20:58:26 +0000 (20:58 +0000)]

Improve display of names and descriptions of SMB2 share flags and
share capabilities including adding two new flags with the help of
the MS-SMB2 specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35669 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 26 Jan 2011 20:29:44 +0000 (20:29 +0000)]

Minor changs to NetBIOS Session Service code:

- Simplify a proto_tree_add_uint() call into proto_tree_add_item()
- Mention RFC 1002 in comment above message type definitions
- Expand field descriptions for length field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35668 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Jan 2011 20:23:18 +0000 (20:23 +0000)]

Add references to Windows 7 where appropriate; Add temp file info for Windows 7/Vista.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35667 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 19:44:23 +0000 (19:44 +0000)]

Dissect PS-HANDOVER-REQUEST.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35666 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 19:37:30 +0000 (19:37 +0000)]

Add 10.5.1.14 NAS container for PS HO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35665 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 19:36:00 +0000 (19:36 +0000)]

Add tfs_allowed_not_allowed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35664 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 26 Jan 2011 19:01:10 +0000 (19:01 +0000)]

Minor changes to SMB2 Share Type value string: rename values and change
from 2 bytes to 1 byte (the next byte is reserved) according to MS-SMB2
specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35663 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

tuexen [Wed, 26 Jan 2011 15:15:20 +0000 (15:15 +0000)]

From Irene Ruengeler: Double check that the interface specified in the
preferences still exists. If not, don't use it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35659 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 26 Jan 2011 09:37:35 +0000 (09:37 +0000)]

Corrected entry for packet-lisp-data.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35658 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 09:07:11 +0000 (09:07 +0000)]

packet-ocsp-template.c:47: warning: type defaults to 'int' in declaration of 'proto_ocsp'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35657 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 08:57:26 +0000 (08:57 +0000)]

From Kaspar Brand:
(Part II)
SSL/TLS dissector: add support for "Certificate Status" messages (aka OCSP stapling)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5503

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35656 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 08:49:06 +0000 (08:49 +0000)]

From Kaspar Brand:
SSL/TLS dissector: add support for "Certificate Status" messages (aka OCSP stapling)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5503

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35655 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 26 Jan 2011 07:47:31 +0000 (07:47 +0000)]

From Alexis La Goutte:
Cleanup 802.11 Dissector : Header Field begin by hf_...
Patch 4 - 6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5609

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35654 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Wed, 26 Jan 2011 07:24:06 +0000 (07:24 +0000)]

From Brian Ginsbach:
Patch to add a new dissector for Realm Specific IP (RSIP) as defined by
RFC 3102, RFC 3103, and RFC 3104.
This is a very basic dissector. It could be extended to do addtional RSIP
protocol violation testing. The dissector is written such that it should be
easy to add later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35653 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Wed, 26 Jan 2011 00:15:01 +0000 (00:15 +0000)]

(Trivial) Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35652 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Tue, 25 Jan 2011 22:11:59 +0000 (22:11 +0000)]

Fix fo bug 5616:
Remove the filters on IPv6 Link Local and Multicast addresses, since
these _can_ be resolved through the hosts file and manual entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35651 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Tue, 25 Jan 2011 18:43:43 +0000 (18:43 +0000)]

Fix gcc compilation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35650 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 16:41:59 +0000 (16:41 +0000)]

Switch more messages over to the "gsm dissector style".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35649 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 15:34:52 +0000 (15:34 +0000)]

packet-windows-common.c:1492: warning: 'wkwn_sid2_len' may be used uninitialized in this function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35648 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 15:33:36 +0000 (15:33 +0000)]

Fix:
Error: the blurb for field "Well-known SID" ("nt.sid.wkwn") matches the field name in packet-windows-common.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35647 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 13:57:59 +0000 (13:57 +0000)]

Export de_emm_trac_area_id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35646 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 13:56:15 +0000 (13:56 +0000)]

Export Global-ENB-ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35645 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 13:55:20 +0000 (13:55 +0000)]

Add tfs_reliable_not_reliable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35644 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 25 Jan 2011 13:53:35 +0000 (13:53 +0000)]

From Cal Turney:
Enhancements to SID dissection.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5613

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35643 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Mon, 24 Jan 2011 22:04:43 +0000 (22:04 +0000)]

From Jouni Malinen:
Allow TDLS Setup Response/Confirm to not include optional fields

Verifying whether non-zero status code is used and use explicit validation of
the remaining length and an expert info instead of implicit failure by an
exception.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35642 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Mon, 24 Jan 2011 20:54:20 +0000 (20:54 +0000)]

From Alexis La Goutte:
Some patch to cleanup the 802.11 Dissector.
Part 3: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5609

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35641 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Mon, 24 Jan 2011 19:33:36 +0000 (19:33 +0000)]

Print "0 seconds" when time_val==0 in functions converting seconds to string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35640 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Mon, 24 Jan 2011 19:27:38 +0000 (19:27 +0000)]

1.5.0 → 1.5.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35639 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Mon, 24 Jan 2011 18:59:26 +0000 (18:59 +0000)]

Fix crash when doing File ! Export ! Objects ! SMB.
[Essentially: simplify the code used to test for duplicate packets].
Fixes Bug #5337: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5337

Also:
- Fix "divide by 0" which caused garbage for display of a percent value;
- Remove some unneeded #includes;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35638 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Mon, 24 Jan 2011 18:37:24 +0000 (18:37 +0000)]

Build 1.5.0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35637 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Sun, 23 Jan 2011 23:45:36 +0000 (23:45 +0000)]

Export UE-EUTRA-Capability.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35634 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sun, 23 Jan 2011 20:59:12 +0000 (20:59 +0000)]

Fix a crash which can occur if a user hits "Capture:Options" immediately followed by "Capture:Start"

Fixes Bug #4645: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4645

Essentially: The "Capture Start" code "interrupted" the "Capture Options" code and attempted
to use not yet initialized "Capture Options" state.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35633 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Sun, 23 Jan 2011 20:15:31 +0000 (20:15 +0000)]

From Alexis La Goutte:
Some patch to cleanup the 802.11 Dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35632 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Sun, 23 Jan 2011 20:11:08 +0000 (20:11 +0000)]

From Alexis La Goutte:
Some patch to cleanup the 802.11 Dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35631 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sun, 23 Jan 2011 17:29:06 +0000 (17:29 +0000)]

Reword some text about the accuracy of the dislayed values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35629 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Sun, 23 Jan 2011 16:03:54 +0000 (16:03 +0000)]

[Automatic manuf, services and enterprise-numbers update for 2011-01-23]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35627 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Sat, 22 Jan 2011 18:07:28 +0000 (18:07 +0000)]

Ensure we keep the pkg_data pointer for the init routine to cleanup correctly,
because the ep memory is cleared before the init routine is called.

Fixed the variable name for the no_yes true_false_string.
Update reference to protocol description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35626 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Sat, 22 Jan 2011 17:42:40 +0000 (17:42 +0000)]

Resolve bug #2520 by moving the follow stream direction combo box above the
buttons to make more room for hostnames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35625 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sat, 22 Jan 2011 17:01:47 +0000 (17:01 +0000)]

Add Loránd Jakab; Add two missing left-braces;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35624 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Sat, 22 Jan 2011 16:48:02 +0000 (16:48 +0000)]

Remove unneeded #includes: <stdio>,<stdlib>,<string>; Add emacs editor modelines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35623 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Sat, 22 Jan 2011 15:35:34 +0000 (15:35 +0000)]

Use nstime_set_zero() to initialize nstime_t's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35622 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Sat, 22 Jan 2011 15:15:51 +0000 (15:15 +0000)]

From Johannes Lange via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5606 :

In semcheck.c the display filter string of an expression is checked against the
header_field_info.display value BASE_CUSTOM. But the value of BASE_CUSTOM is
applied as bitmask while the actual type is an enum (BASE_CUSTOM = 6).

With this BASE_DEC, BASE_DEC_HEX and BASE_HEX_DEC are also matching and are not
accepted as filter expression.

Actually: BASE_DEC works but not BASE_HEX. And the problem only shows up when
trying to match a field in one of these bases against a string (from a
value_string).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35621 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Sat, 22 Jan 2011 14:02:38 +0000 (14:02 +0000)]

Set active combo_box entry before connecting the changed signal
to avoid a crash when opening the Import window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35620 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Sat, 22 Jan 2011 13:44:06 +0000 (13:44 +0000)]

Close dir opened by ws_dir_open().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35619 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Sat, 22 Jan 2011 13:43:54 +0000 (13:43 +0000)]

Close dir opened by ws_dir_open().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35618 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Sat, 22 Jan 2011 10:38:10 +0000 (10:38 +0000)]

Insert and update tshark and dumpcap help information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35617 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Sat, 22 Jan 2011 03:49:23 +0000 (03:49 +0000)]

Add buttons to allow filtering only UL or DL on selected UE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35616 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Sat, 22 Jan 2011 00:18:03 +0000 (00:18 +0000)]

From Loránd Jakab:
The patch I am attaching here is for dissecting LISP data packets.

From me:
Minor cleanups.
Showing the reserved field.
Adding to all makefiles and release notes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35615 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Fri, 21 Jan 2011 23:37:46 +0000 (23:37 +0000)]

Update the User Interface chapter of the User's Guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35614 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Fri, 21 Jan 2011 23:24:08 +0000 (23:24 +0000)]

Re-arrange help menu a bit to group website and wiki links.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35613 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Fri, 21 Jan 2011 20:57:24 +0000 (20:57 +0000)]

Start update for 1.5 version of User's Guide.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35612 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Fri, 21 Jan 2011 17:12:02 +0000 (17:12 +0000)]

From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5604 :

A small patch to add color rules for ICMPv6 Error (some error as ICMP(v4)..)

With this patch, Wireshark is ready for IPv6 Day ;)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35611 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Fri, 21 Jan 2011 17:08:35 +0000 (17:08 +0000)]

From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5603 :

Following the discussion on the dev mailing list about ett_ value in subtree
http://www.wireshark.org/lists/wireshark-dev/201101/msg00039.html

a small to update the Readme Developer Guide !

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35610 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 21 Jan 2011 14:03:42 +0000 (14:03 +0000)]

- Wrong element type used.
- Use match_strval_idx_ext.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35609 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 21 Jan 2011 09:31:25 +0000 (09:31 +0000)]

Use EXTRANEOUS_DATA_CHECK_EXPERT

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35608 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 21 Jan 2011 09:26:29 +0000 (09:26 +0000)]

Move sgsap_elem_idx_t to packet-gsm_a_common.h
Dissect Global-CN-Id

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35607 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 21 Jan 2011 09:24:43 +0000 (09:24 +0000)]

CN-Id is two bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35606 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 21 Jan 2011 06:30:55 +0000 (06:30 +0000)]

From Tobias Klauser:
Fix standard to IEC62439 Part 3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5599

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35605 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 21 Jan 2011 06:27:08 +0000 (06:27 +0000)]

Fix typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35604 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Fri, 21 Jan 2011 03:00:31 +0000 (03:00 +0000)]

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35603 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Fri, 21 Jan 2011 02:48:55 +0000 (02:48 +0000)]

Introduce, and start using, tvb_eth_to_str().

Export tvb_*_to_str() and put them in alphabetical order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35602 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Fri, 21 Jan 2011 02:25:30 +0000 (02:25 +0000)]

Use tvb_ip_to_str()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35601 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sake [Fri, 21 Jan 2011 00:19:03 +0000 (00:19 +0000)]

Adress => Address corrections (also in comments).

(see bug 5600)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35600 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Thu, 20 Jan 2011 20:04:39 +0000 (20:04 +0000)]

Allow presentation of Gauge32 values larger than 0x7FFFFFFF.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35599 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Thu, 20 Jan 2011 18:56:11 +0000 (18:56 +0000)]

Fix the dead initialization warnings found by clang's static analysis
("Value stored to 'xxx' during its initialization is never read")

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35598 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 20 Jan 2011 14:03:13 +0000 (14:03 +0000)]

Fix typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35597 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 20 Jan 2011 13:19:26 +0000 (13:19 +0000)]

Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35596 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 20 Jan 2011 13:05:17 +0000 (13:05 +0000)]

In MM context the container contains IE:s not a complete
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35595 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Thu, 20 Jan 2011 08:58:03 +0000 (08:58 +0000)]

Allow for expert items to be actually attached somewhere.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35594 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Thu, 20 Jan 2011 03:49:44 +0000 (03:49 +0000)]

Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (instead
of going through a temporary variable). This just makes it more obvious which
add_bytes_format() calls are or are not being given pointers into the TVB.

Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35593 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 19 Jan 2011 22:57:19 +0000 (22:57 +0000)]

Add a note to the top about r35589's change of the ADDCARRY(x) macro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35592 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Wed, 19 Jan 2011 22:55:53 +0000 (22:55 +0000)]

Don't stop calling subdissectors when there's no tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35591 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Wed, 19 Jan 2011 22:53:46 +0000 (22:53 +0000)]

Use Wireshark standard marking for unused parameters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35590 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 19 Jan 2011 22:53:38 +0000 (22:53 +0000)]

Change the ADDCARRY(x) macro to eliminate clang warning about unused
result from the ADDCARRY portion of the REDUCE macro.

-#define ADDCARRY(x) (x > 65535 ? x -= 65535 : x)
+#define ADDCARRY(x) {if ((x) > 65535) (x) -= 65535;}

The new code is from in_cksum.c in the Tahoe/CGI port of 4.4BSD-Lite2 (we're
using the "Portable Version" copy otherwise).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35589 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 19 Jan 2011 21:51:30 +0000 (21:51 +0000)]

Simply this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN ((gint)strlen (SIP2_HDR))

To this:

    #define SIP2_HDR "SIP/2.0"
    #define SIP2_HDR_LEN 7

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35588 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 19 Jan 2011 21:45:54 +0000 (21:45 +0000)]

Fix warning found by clang...

packet-dcerpc.c:4056:19: error: comparison of integers of different signs:
      'guint32' (aka 'unsigned int') and 'int' [-Wsign-compare]
    for (i = 0; i < (int) commands_nb; ++i) {
                ~ ^ ~~~~~~~~~~~~~~~~~

... by removing the "(int)" cast

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35587 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

jake [Wed, 19 Jan 2011 20:57:39 +0000 (20:57 +0000)]

From Alexis La Goutte:
A patch to enhance the ICMPv6 dissector
- Make ICMP Type (sub)field filterable
- Add Inverse Neighbor Discovery (RFC 3122)
- Remove dependency to packet-ipv6.h
- Cleanup packet-ipv6.h
- Update RFC Draft to draft-ietf-roll-rpl-17 (with make a sub dissector
for RPL Control and add Secure RPL...)
- Replace tvb_get_ipv6/ip6_to_str by new function tvb_ip6_to_str
- and other enchancements.....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35586 f5534014-38df-0310-8fa8-9805f1628bb7

git mirror of the wireshark svn

RSS Atom