guy [Sun, 16 Nov 2003 23:17:27 +0000 (23:17 +0000)]
Export "protocol_t" as an opaque type.
Make "proto_is_protocol_enabled()" and "proto_get_protocol_short_name()"
take a "protocol_t *" as an argument, so they don't have to look up the
"protocol_t" - this will probably speed them up considerably, and
they're called on almost every dissector handoff.
Get rid of a number of "proto_is_protocol_enabled()" calls that aren't
necessary (dissectors called through handles, including those called
through dissector tables, or called as heuristic dissectors, aren't even
called if their protocol isn't enabled).
Change some direct dissector calls to go through handles.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8979
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 16 Nov 2003 23:11:20 +0000 (23:11 +0000)]
From Lars Roland Service Response times for H225 RAS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8978
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 16 Nov 2003 22:33:19 +0000 (22:33 +0000)]
Bugfix for h450.
The hf field we give to dissect_per_object_string is a FT_STRING and not a FT_BYTES. This caused ethereal to abort with an assert failure.
This fixes the issue that Keith French recently brought up in his mailing to
ethereal-users
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8977
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Nov 2003 23:58:53 +0000 (23:58 +0000)]
From Olivier Biot: fix the offset for the Encoding-Version header in the
general form.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8976
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Nov 2003 23:48:52 +0000 (23:48 +0000)]
From Michael Lum: add <shift><control> hotkeys for Protocols and
Preferences.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8975
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 11:46:09 +0000 (11:46 +0000)]
GTK2 specific: use some Ethereal specific stock icons generated in toolbar.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8974
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 11:44:10 +0000 (11:44 +0000)]
handlebar removed,
GTK2 specific: generate some Ethereal specific stock icons and
use them in the toolbar
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8973
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 11:39:57 +0000 (11:39 +0000)]
added gdk_pixbuf to GTK2 specific libs to link (needed in toolbar.c)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8972
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 10:06:44 +0000 (10:06 +0000)]
removed no longer used gtk includes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8971
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 08:53:56 +0000 (08:53 +0000)]
seperated capture dialog from capture.c and put into new gtk/capture_info_dlg.c,
added some tiny bars, that will indicate the percentage,
added ESC key handler and use of GTK_STOCK button
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8970
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 08:50:07 +0000 (08:50 +0000)]
added "#include <epan/packet.h>" to be able to include "capture.h"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8969
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 15 Nov 2003 08:48:14 +0000 (08:48 +0000)]
seperated capture dialog from capture.c and put into new gtk/capture_info_dlg.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8968
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 21:18:06 +0000 (21:18 +0000)]
When it comes to whether to use "select()" or not, even if you're
building in Cygwin's pretend-it's-UNIX environment, we need to treat the
platform as Windows.
Get rid of the BSD #define - just check for the platforms on which we
mustn't use "select()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8967
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 19:20:24 +0000 (19:20 +0000)]
Fix the stuff that talks about adding to DISSECTOR_SOURCES to talk about
adding to DISSECTOR_SRC instead, and update it to mention
"Makefile.nmake" in the first instance.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8966
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 18:59:00 +0000 (18:59 +0000)]
From Josef Korelus: update the offset after decoding an IE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8965
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 10:11:11 +0000 (10:11 +0000)]
Fix the heuristics so that they recognize Linux DLT_NULL headers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8964
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 02:07:20 +0000 (02:07 +0000)]
Add support for the compact form of headers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8963
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 01:35:08 +0000 (01:35 +0000)]
From Michael Lum: fix up handling of ABORT package.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8962
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Nov 2003 01:27:34 +0000 (01:27 +0000)]
From Olivier Biot: fix the debugging output of "tvb_get_guintvar()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8961
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Nov 2003 23:44:05 +0000 (23:44 +0000)]
From Olivier Biot: use "g_strdup_printf()" to generate
dynamically-allocated sprintf output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8960
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Nov 2003 23:38:33 +0000 (23:38 +0000)]
Require that field names contain only alphanumerics, "-", "_", and ".".
Fix the names that contained other characters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8959
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Nov 2003 23:13:51 +0000 (23:13 +0000)]
From Jaime Fournier: get rid of space in field name.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8958
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 13 Nov 2003 20:53:44 +0000 (20:53 +0000)]
Change the gboolean controlling whether to use TCP Sequence Number Analysis and TCP Relative Sequence Numbers to default to ENABLED
instead of DISABLED.
These features do not consume that much memory or CPU but will greatly enhance the feature set of ethereal. Make it enabled by default so also those that never venture into the preferences dialog will benefit from it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8957
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 13 Nov 2003 08:22:48 +0000 (08:22 +0000)]
For Time Reference frames reset the counter for CulmulativeBytes.
This makes the CulmulativeBytes field make more sense since if we want
something to be a TimeReference frame it is likely that we also want to
measure BOTH time and number of bytes (==culmulative bytes) until the event we are looking at.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8956
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 13 Nov 2003 08:16:52 +0000 (08:16 +0000)]
Change the strings shown for ICMP TTL exceeded to match the wording in the standard
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8955
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 13 Nov 2003 05:08:58 +0000 (05:08 +0000)]
We can't pass NULLs to proto_tree_add_text(). Replace a bunch of occurrences
of match_strval() with val_to_str() so that we don't throw an assertion.
These changes fix a problem with a file from Martin Dubovsky; otherwise
they haven't been heavily tested.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8954
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Nov 2003 23:17:37 +0000 (23:17 +0000)]
From Anand Narwani: fix bitmask for Active Grants field.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8953
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Nov 2003 22:44:16 +0000 (22:44 +0000)]
From Olivier Biot:
implement the TE header decoding;
fix the exported add_content_type function;
reimplement the header parameter dissection so the parameters
also show up in the related header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8952
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Nov 2003 21:22:37 +0000 (21:22 +0000)]
From Chris Waters:
* Better decoding of TZSP header.
* Handle unknown tags in packet.
* Removed encapsulation types which are not actually supported.
* Added tags for original length and sensor address.
* Fix signedness of some fields.
Get rid of unused "hf_tzsp_reserved" variable.
Use -1 rather than "tvb_length(tvb)" when constructing the top-level
protocol tree item, and set the length if we have payload that we
dissect separately.
Have "add_option_info()" take a starting offset, rather than
constructing a subset tvbuff for it.
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8951
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Nov 2003 20:44:36 +0000 (20:44 +0000)]
From Matthias Drochner: support for mode 6 and mode 7 control packets
and NTP4 autokey extension data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8950
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 12 Nov 2003 19:04:58 +0000 (19:04 +0000)]
completely redesigned print dialog layout, to be more obvious to the user
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8949
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 12 Nov 2003 18:48:53 +0000 (18:48 +0000)]
Remove MAX_DECODE_BUFFER_SIZE; it's no longer used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8948
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Nov 2003 09:00:27 +0000 (09:00 +0000)]
Put stub data back where it was in the tree before.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8947
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Nov 2003 08:58:05 +0000 (08:58 +0000)]
If what remains of the SMB byte count exceeds the data left in the
tvbuff, show what's left as extra byte parameters - don't act as if
there aren't any extra byte parameters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8946
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 20:49:46 +0000 (20:49 +0000)]
From Brian Ginsbach: fix handling of IRIX and UNICOS/mp snoop captures
on loopback interfaces.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8945
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 20:33:53 +0000 (20:33 +0000)]
Add parameter length checking.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8944
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 20:11:05 +0000 (20:11 +0000)]
From Mohammad Hanif: fix dissection of RSVP DETOUR object code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8943
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 20:08:13 +0000 (20:08 +0000)]
Get rid of carriage returns in source files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8942
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 19:24:09 +0000 (19:24 +0000)]
Make the declaration of "process_tcp_payload()" match the definition.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8941
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 19:23:22 +0000 (19:23 +0000)]
"tacplus_pref_cb()" takes no arguments, not an unspecified list of
arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8940
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 18:25:04 +0000 (18:25 +0000)]
Get rid of GLib 1.3 support - current versions of GTK+ 1.3 require GLib
2.0, and earlier versions are sufficiently buggy that we don't want to
support them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8939
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 11 Nov 2003 13:59:53 +0000 (13:59 +0000)]
added some print dialog flags, to disable some unsupported print features
(e.g. selection of pages from X to Y)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8938
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 08:29:34 +0000 (08:29 +0000)]
From Yuriy Sidelnikov: ISO 8327-1 Session Protocol support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8937
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 06:10:57 +0000 (06:10 +0000)]
Add "asn1_id_decode1()" to the list of exported functions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8936
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 05:54:06 +0000 (05:54 +0000)]
From Michael Lum:
Minor improvements.
Added IEI level decoding of cdma2000 Handoff * IOS data
parameters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8935
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 05:51:09 +0000 (05:51 +0000)]
From Michael Lum:
Change P_xxx to ANSI_A_E_xxx.
Fix decoding of some parameters.
Fix initialization of ett array.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8934
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 05:23:23 +0000 (05:23 +0000)]
The user interface preference page has only 9 rows in the GTK+ 2.x
version.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8933
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 11 Nov 2003 05:09:03 +0000 (05:09 +0000)]
Create the last two items in the GUI preferences page's first column the
same way the other items are created - in order, going down the page,
and using "pos++" as the table position.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8932
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 10 Nov 2003 22:31:06 +0000 (22:31 +0000)]
From Albert Chin: <stdlib.h> on HP-UX 11.00 (and possibly 10.20 and
perhaps some versions of Digital/Tru64 UNIX) drags in <wait.h>, which
drags in <sys/procset.h>, which defines P_SID in ways that cause this
not to compile. Use P_MY_SID instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8931
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 10 Nov 2003 21:42:38 +0000 (21:42 +0000)]
From Martin Regner:
"aliasAddress", in an EndPoint sequence, is a sequence of
aliasAddresses.
Don't update the Info or Protocol columns in a pdu_item.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8930
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 10 Nov 2003 20:22:39 +0000 (20:22 +0000)]
From Yaniv Kaul:
1. Add dissection of inquiry type (rpc_c_ep_all_elts /
rpc_c_ep_match_by_if / rpc_c_ep_match_by_obj /
rpc_c_ep_match_by_both).
2. The version field seems incorrect to me - I believe it is usually
should be version 2.0, not 0.2.
I suspect that the insertion of version information to the hash
table is also wrong, (and the get for the version should have
used _letohl() ) - but I did not change it.
3. Clean up some white space.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8929
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 10 Nov 2003 20:15:28 +0000 (20:15 +0000)]
From Albert Chin: dynamically allocate the "ett" array - some compilers
(such as at least one older version of the HP C compiler) can't cope
with constant expressions that involve the "?" operator, it appears;
they think it's not a constant expression.
Also, as Albert notes, there's no reason for "ett" to be static here.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8928
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 10 Nov 2003 08:14:07 +0000 (08:14 +0000)]
The Q.931 dissector never checked whether the codeset variable was set to a reasonable value or not.
This was problematic and caused crashes since this variable is used as an index into an array where we grab a
pointer (which is later dereferenced).
Dereferencing that pointer will have surprising effects. Usually crashes.
Update Q.931 to verify sanity of the codeset variable everytime it gets set.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8927
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 10 Nov 2003 08:02:33 +0000 (08:02 +0000)]
Bugfix for ethereal crashes
If the ByteCount field in the SMB PDU spanned beyond the end of the
packet because the packet was short or because the BC field was corrupted and contained
garbade data then the tree item for the command (the subtree just after the SMBHeader subtree) would describe data continuing beyond the end of the
packet.
If we selected one such tree in the dissect pane and used Prepare/Match Selected this would cause the filter build thing to try to access data beyod the end
of the packet and ethereal would dump core.
Change the END_OF_SMB macro so that it shrinks bc so that bc never describes
data beyond the end of the packet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8926
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 10 Nov 2003 07:44:47 +0000 (07:44 +0000)]
Not all LDAP PDUs are aligned to the start of a TCP segment.
If we failed to dissect the GSS-SPNEGO blob it probably means that the segment
is somewhere in the middle of an LDAP PDU.
Just bail out and stop dissecting the PDU instead of aborting ethereal completely
using g_assert() since this is not really a pathological error, its just something that can and will happen normally.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8925
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:57:52 +0000 (22:57 +0000)]
Fix the type of the "integer" argument to "asn1_uint32_value_decode()",
as per a note by Michael Lum.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8924
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:55:35 +0000 (22:55 +0000)]
From Martin Mathieson: display the bitfields for
- the first 2 bytes of RTP headers
- the first byte of RTCP report.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8923
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:49:08 +0000 (22:49 +0000)]
From Michael Lum: add the ability to put parameter data at the end of
the parameter name so that the user doesn't have to open the parameter
subtree to see the most important data.
Use "%u", not "%d", to print unsigned quantities.
Get rid of includes of <gmodule.h> (we're not loading any code at
run-time in the dissector itself), and <sys/types.h> and <netinet/in.h>
(we shouldn't need either of those).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8922
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:41:55 +0000 (22:41 +0000)]
From Michael Lum get rid of non-portable "%N$" constructs in printf
formats.
Use "%u", not "%d", to print unsigned quantities.
Get rid of includes of <gmodule.h> (we're not loading any code at
run-time in the dissector itself), and <sys/types.h> and <netinet/in.h>
(we shouldn't need either of those).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8921
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:32:44 +0000 (22:32 +0000)]
Remove accidentally-inserted letter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8920
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:30:05 +0000 (22:30 +0000)]
From Michael Lum:
Fix some incorrect bit shifts.
Get rid of non-portable "%N$" constructs in printf formats.
Use "%u", not "%d", to print unsigned quantities.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8919
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:15:29 +0000 (22:15 +0000)]
From Albert Chin: the HP-UX 10.20 C compiler doesn't allow
typedef enum _foo foo;
enum _foo {
...
};
You have to define the enum before using it in a typedef. (If I had my
ANSI C89 standard handy, I could say whether that was legal ANSI C or
not.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8918
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 22:13:18 +0000 (22:13 +0000)]
From Albert Chin: get rid of null statements outside of function bodies
(that's what the ";" in
int
foo(...)
{
...
};
is).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8917
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 19:53:11 +0000 (19:53 +0000)]
From Albert Chin: get rid of C++ comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8916
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Nov 2003 01:36:21 +0000 (01:36 +0000)]
From Gisle Vanem:
Copy the "gui_fileopen_*" fields in "copy_prefs()".
Fix a typo in "free_prefs()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8915
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Nov 2003 05:47:12 +0000 (05:47 +0000)]
Have "decode_tcp_ports()" handle only the handoff to a subdissector -
and have it return TRUE if we succeeded, FALSE otherwise - and have an
internal "process_tcp_payload()" routine handle the (TCP-specific) PDU
tracking and sequence number analysis, with an argument to indicate
whether it should do that or not (i.e., whether it's being handed a TCP
segment or reassembled data).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8914
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Nov 2003 00:09:01 +0000 (00:09 +0000)]
From Mohammad Hanif:
correct and enhance support for RSVP FAST_REROUTE and DETOUR
objects (source: draft-ietf-mpls-rsvp-lsp-fastreroute-03.txt);
support an RSVP SESSION_OBJECT object with ctype = 1. This
object contains resource affinities (source: RFC 3209).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8913
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Nov 2003 00:02:56 +0000 (00:02 +0000)]
"decode_tcp_ports()" is for use by protocols that proxy transport-layer
packets/sessions, e.g. MSProxy and SOCKS. It should not cause any of
the TCP-specific stuff such as sequence number analysis or PDU tracking
to be done. (Actually, MSProxy and SOCKS should offer desegmentation
services *themselves* and do their *own* PDU tracking, rather than just
passing stuff on to "decode_tcp_ports()", but that's another matter.)
Make "tcp_tree" once again be a local variable to "dissect_tcp()", and
pass it as an argument to those functions that use it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8912
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 23:27:13 +0000 (23:27 +0000)]
Let people configure whether to build with Zlib or not solely by
controlling whether ZLIB_DIR is defined or not in config.nmake.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8911
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 23:26:15 +0000 (23:26 +0000)]
Nothing here should require zlib.h, so we shouldn't need to do
"/I$(ZLIB_DIR)".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8910
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 20:23:55 +0000 (20:23 +0000)]
From Olivier Biot: implement the Range, Content-Range and
Content-Disposition headers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8909
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 20:07:01 +0000 (20:07 +0000)]
From Olivier Biot: add dissection for the Content-Base headeer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8908
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 08:50:44 +0000 (08:50 +0000)]
From Dinesh Dutt:
- Added support for displaying support for Multicast/Broadcast supported
bits in *LOGI common service params
- Removed restriction for "Random Relative Offset" & its alternate to be in
PLOGI or PDISC only. Some HBAs set it even in FLOGI.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8907
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 08:47:53 +0000 (08:47 +0000)]
From Dinesh Dutt:
- Added support for decoding related to Security in *LOGI service params
- Added support for new LS_RJT code for authentication failure
- Brought packet-fcsp.c up-to-date with FC-SP rev 1.2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8906
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 7 Nov 2003 05:26:27 +0000 (05:26 +0000)]
New protocol: MS Kpasswd (RFC3244)
KPasswd is partially dissected for UDP.
It would be very useful if someone added dissection of the asn.1 encoded
AP_REQ and the KRB-PRIV blobs. I dont think I will add those.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8905
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 7 Nov 2003 04:03:44 +0000 (04:03 +0000)]
In some captures we might have already established and BOUND LDAP
session where GSS-SPNEGO is used.
If we havent seen the BIND call ethereal would assume it is
vanilla non-GSS-SPNEGO LDAP and would fail to decode the packet.
Add heuristics to the LDAP dissector so that
IF the first 4 bytes of the LDAP PDU looks like ity could be a length field
and IF the fifth byte has the value 0x60
then assume what we have is GSS-SPNEGO and assume this and all further commands on this session is GSS-SPNEGO as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8904
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 03:47:20 +0000 (03:47 +0000)]
Make a field for the Content-Type entity header, and give it an EH_
value so it can be handled specially (with a string dissector table so
that subdissectors can register for particular content types).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8903
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Nov 2003 01:29:05 +0000 (01:29 +0000)]
"File->Open" should be available whether or not we have a captue file
open.
The toolbar equivalent should *not* be available if we have an "Update
list of packets in real time" capture running.
The toolbar "Save" button should not be available if we don't have an
unsaved capture file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8902
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 23:02:06 +0000 (23:02 +0000)]
Make Shift+Control+S an accelerator for "Save As...", as per the GNOME
HIG.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8901
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 22:45:28 +0000 (22:45 +0000)]
From Scott Emberley: support for writing Network Instruments Observer
files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8900
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 09:52:28 +0000 (09:52 +0000)]
Note that not all OSes on which Ethereal runs can support plugins.
Note that you have to modify plugins/Makefile.nmake.
Fix "plugin/" to "plugins/".
Update the sample Makefile.am and Makefile.nmake to match the current
state of affairs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8899
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 09:47:06 +0000 (09:47 +0000)]
Warn people not to use the "numbered argument" feature that many UNIX
printf's implement.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8898
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 09:32:46 +0000 (09:32 +0000)]
From Erwin Rol: fix some switched fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8897
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 09:28:40 +0000 (09:28 +0000)]
From Michael Lum: have the SCCP dissector register itself by name.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8896
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 6 Nov 2003 09:18:46 +0000 (09:18 +0000)]
Update to LDAP and TCP
LDAP messages that span multiple segments will throw an exception unless we have reassembly enabled.
Update TCP so that IF an exception was thrown that we still pick up any hints
provided by the subdissector about where the next PDU starts.
Update LDAP so that it will rpovide hints to TCP about where the next LDAP PDU starts in the sequence number space.
Thus now ethereal can find and dissect LDAP PDUs that starts somewhere in the middle of a TCP segment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8895
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 09:13:26 +0000 (09:13 +0000)]
Update a comment.
Catch another case where we need to check for a null decrypted_tvb.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8894
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 09:05:14 +0000 (09:05 +0000)]
Use "$(OBJECTS)" whenever a complete list of .obj files appears, rather
than repeating the list from the setting of OBJECTS.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8893
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Nov 2003 08:54:31 +0000 (08:54 +0000)]
Add a mechanism to handle various entity headers, allowing their
(string) values to be put into the protocol tree as fields and allowing
some headers to get special treatment, and use it for Authorization,
Proxy-Authorization, WWW-Authenticate, and Proxy-Authenticate.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8892
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 6 Nov 2003 08:51:21 +0000 (08:51 +0000)]
Fix for TCP.
If we have short or malformed PDUs in protocols above TCP this will generate
an exception and thus some of the stateful things such as keeping track of
and printing the tcp analysis data will be shourcutted and not called.
Add a wrapper around the call to the subdissectors above TCP so that
if an exception is generated we will still catch it and explicitely
call tcp_print_sequence_number_analysis() so that also short packets are
handled well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8891
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 6 Nov 2003 07:44:13 +0000 (07:44 +0000)]
Bugfix for dcerpc parsing of encrypted short packets.
Sometimes if we cant decrypt a DCERPC packet decrypted_tvb is NULL.
do not pass a NULL pointer to show_stub_data() since this will dump
core.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8890
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 5 Nov 2003 20:19:39 +0000 (20:19 +0000)]
Get rid of includes of <gmodule.h> (we're not loading any code at
run-time in the dissector itself), and <sys/types.h> and <netinet/in.h>
(we shouldn't need either of those, and they might be responsible for
dragging in <sys/procset.h> on Digital UNIX - that header defines P_SID
in a way that conflicts with our definition).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8889
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 5 Nov 2003 20:10:54 +0000 (20:10 +0000)]
Update from Erwin Rol.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8888
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 5 Nov 2003 20:10:00 +0000 (20:10 +0000)]
A "GHashFunc()" returns a "guint", not a "gint".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8887
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 5 Nov 2003 09:04:51 +0000 (09:04 +0000)]
the LDAP service response time dialog
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8886
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 5 Nov 2003 09:04:17 +0000 (09:04 +0000)]
update for LDAP
measure the response time for some LDAP commands and
add a service response time dialog for it
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8885
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 5 Nov 2003 04:23:59 +0000 (04:23 +0000)]
From Olivier Biot: have a separate subtree ett_ value for concatenated
PDUs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8884
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Nov 2003 22:14:50 +0000 (22:14 +0000)]
Sigh. Some snoop files have 6 bytes of padding; assume the file is a
snoop file unless it has enoguh padding to hold a Shomiti trailer
record. (DEAR SUN MICROSYSTEMS: PLEASE DO NOT STUFF 16 OR MORE BYTES OF
PADDING INTO A SNOOP PACKET. THANK YOU. HAVE A NICE DAY.)
Add a little paranoia about the record and captured data lengths.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8883
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Nov 2003 21:44:27 +0000 (21:44 +0000)]
Get rid of all the UDP-encapsulated IPSec stuff.
draft-ietf-ipsec-udp-encaps-06 says "The UDP port numbers are the same
as used by IKE traffic, as defined in [Kiv05]", and "[Kiv05]" is
draft-ietf-ipsec-nat-t-ike-05, which has been superseded by
draft-ietf-ipsec-nat-t-ike-07; the latter appears to imply that it goes
over port 4500, not port 500.
We already have a draft-ietf-ipsec-udp-encaps-06 dissector for port
4500 (packet-ipsec-udp.c), and it's not entirely clear to me how, if
draft-ietf-ipsec-udp-encaps-06 traffic *did* go over port 500, you'd
distinguish it from regular ISAKMP traffic.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8882
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Nov 2003 20:33:13 +0000 (20:33 +0000)]
Skip the check for the module if a page doesn't have a module.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8881
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Nov 2003 20:22:21 +0000 (20:22 +0000)]
Clean up the way we find the properties page for a given protocol
somewhat; this fixes a bug wherein we were assuming all modules
necessarily had preference pages (they won't, if the only preferences
for the module are obsolete preferences).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8880
f5534014-38df-0310-8fa8-
9805f1628bb7