obnox/wireshark/wip.git
15 years agoUpdate Debian packaging files for development version
jake [Mon, 16 Jun 2008 20:49:02 +0000 (20:49 +0000)]
Update Debian packaging files for development version

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25461 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Michael Adam:
jake [Mon, 16 Jun 2008 20:38:26 +0000 (20:38 +0000)]
From Michael Adam:
This patch adds knowledge of the DFS server type to the SMB-BROWSE dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25460 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 2612:
jake [Mon, 16 Jun 2008 05:33:08 +0000 (05:33 +0000)]
Fix for bug 2612:
cleaned up FT_UINT_STRING type description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25459 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 2611:
jake [Mon, 16 Jun 2008 05:32:19 +0000 (05:32 +0000)]
Fix for bug 2611:
Add -v option to example "od" command line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25458 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoInitialize recent.gui_time_precision when changing profile to avoid a crash
stig [Sun, 15 Jun 2008 20:53:06 +0000 (20:53 +0000)]
Initialize recent.gui_time_precision when changing profile to avoid a crash
in some rare cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25457 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCleanup return values from info_bar_new() and packets_bar_new().
stig [Sun, 15 Jun 2008 20:50:10 +0000 (20:50 +0000)]
Cleanup return values from info_bar_new() and packets_bar_new().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25456 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoClick on the profile in the statusbar will open Configuration Profiles dialog.
stig [Sun, 15 Jun 2008 20:47:06 +0000 (20:47 +0000)]
Click on the profile in the statusbar will open Configuration Profiles dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25455 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMoved setting of E_MPACKET_LIST_KEY object data to the function creating
stig [Sun, 15 Jun 2008 18:29:22 +0000 (18:29 +0000)]
Moved setting of E_MPACKET_LIST_KEY object data to the function creating
packet_list to ensure it's created before we set it.

Applying filter from the packet list still doesn't work correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25454 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd missing IE id
etxrab [Sat, 14 Jun 2008 21:36:11 +0000 (21:36 +0000)]
Add missing IE id

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25453 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate all time columns when changing the time precision.
stig [Sat, 14 Jun 2008 16:51:11 +0000 (16:51 +0000)]
Update all time columns when changing the time precision.

Not implemented for conversation relative and delta time yet, because this
will need a reload as they are set by the dissectors and does not exist in
the frame data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25452 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSave the column width in the recent list on every change so we can
stig [Sat, 14 Jun 2008 16:45:06 +0000 (16:45 +0000)]
Save the column width in the recent list on every change so we can
pick the correct width when changing the time precision.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25451 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded svn:ignore wsutil/TAGS
stig [Fri, 13 Jun 2008 22:39:22 +0000 (22:39 +0000)]
Added svn:ignore wsutil/TAGS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25450 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWe half-enabled the Mac OS X packaging stuff, which meant that we
guy [Fri, 13 Jun 2008 16:52:45 +0000 (16:52 +0000)]
We half-enabled the Mac OS X packaging stuff, which meant that we
weren't including in the tarball stuff the packaging/macosx/Makefile.in
file that that the configure script from the tarball was trying to
expand.  Add macosx to the list of directories in packaging/Makefile.am,
and update the comment in packaging/macosx/Makefile.am to reflect the
enabling of the OS X packaging stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25449 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix list of files in the debian directory.
guy [Fri, 13 Jun 2008 05:54:22 +0000 (05:54 +0000)]
Fix list of files in the debian directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25448 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate to 3GPP TS 36.413 V8.2.0 (2008-06)
etxrab [Thu, 12 Jun 2008 19:18:06 +0000 (19:18 +0000)]
Update to 3GPP TS 36.413 V8.2.0 (2008-06)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25447 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoShow correct seqno in info column.
martinm [Thu, 12 Jun 2008 16:50:23 +0000 (16:50 +0000)]
Show correct seqno in info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25446 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDissect BCH channels (expect control messages only).
martinm [Thu, 12 Jun 2008 16:11:16 +0000 (16:11 +0000)]
Dissect BCH channels (expect control messages only).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25445 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom yami via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2603 : register...
morriss [Thu, 12 Jun 2008 13:39:55 +0000 (13:39 +0000)]
From yami via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2603 : register the SMB dissector by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25444 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoReturn 0 if we don't dissect any bytes.
stig [Wed, 11 Jun 2008 20:10:19 +0000 (20:10 +0000)]
Return 0 if we don't dissect any bytes.
Set desegment_len = DESEGMENT_ONE_MORE_SEGMENT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25443 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix for bug 2396:
jake [Wed, 11 Jun 2008 18:20:02 +0000 (18:20 +0000)]
Fix for bug 2396:
Wireshark expects 802.1ah Instance tags to have ethernet type 0x88f0, but latest
802.1ah draft 4.1 defines the 802.1ah Instance tag ethernet type to 0x88e7.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25442 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoptvcursor_subtree_set_item() does not need to be exported.
jake [Wed, 11 Jun 2008 18:16:04 +0000 (18:16 +0000)]
ptvcursor_subtree_set_item() does not need to be exported.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25441 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoThe change to "Use GTK+ 2.12.10" switched from "libpng13.dll" to
guy [Tue, 10 Jun 2008 17:23:36 +0000 (17:23 +0000)]
The change to "Use GTK+ 2.12.10" switched from "libpng13.dll" to
"libpng12-0.dll"; fix a reference to the former.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25440 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Joe Eykholt:
jake [Tue, 10 Jun 2008 05:41:29 +0000 (05:41 +0000)]
From Joe Eykholt:
The Fibre-channel FCP dissector shows the wrong byte as the response info
response code byte.  The byte with offset 2 in the FCP frame is shown
instead of byte 3 inside the response info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25439 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Alex Badea:
etxrab [Tue, 10 Jun 2008 05:39:58 +0000 (05:39 +0000)]
From   Alex Badea:
Migrate ISAKMP packet decryption from libnettle to libgcrypt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25438 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse GTK+ 2.12.10
etxrab [Tue, 10 Jun 2008 05:35:38 +0000 (05:35 +0000)]
Use GTK+ 2.12.10

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25437 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSet release year and month for F7 FP (needed for correct EDCH no-of-subframes field).
martinm [Fri, 6 Jun 2008 17:54:59 +0000 (17:54 +0000)]
Set release year and month for F7 FP (needed for correct EDCH no-of-subframes field).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25436 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix RACH extended IE handling.
martinm [Fri, 6 Jun 2008 09:09:00 +0000 (09:09 +0000)]
Fix RACH extended IE handling.
Flags have different meanings depending upon radio mode...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25435 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSquash uninitialised use warning.
martinm [Thu, 5 Jun 2008 21:39:06 +0000 (21:39 +0000)]
Squash uninitialised use warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25434 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom SUZUKI, Shinsuke:
jake [Thu, 5 Jun 2008 20:00:36 +0000 (20:00 +0000)]
From SUZUKI, Shinsuke:
There are some non-ASCII characters in the following file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25433 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoReplaced net-SNMP section with libSMI.
jake [Thu, 5 Jun 2008 13:25:48 +0000 (13:25 +0000)]
Replaced net-SNMP section with libSMI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25432 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded decoding of object 110 (Octet string), fixed reassembly if transport frame...
grahamb [Thu, 5 Jun 2008 10:32:51 +0000 (10:32 +0000)]
Added decoding of object 110 (Octet string), fixed reassembly if transport frame doesn't start with 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25431 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix operator precedence problem.
martinm [Thu, 5 Jun 2008 09:15:42 +0000 (09:15 +0000)]
Fix operator precedence problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25430 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCorrect math for counting how many TSNs were GAP acknowledged
morriss [Thu, 5 Jun 2008 01:29:58 +0000 (01:29 +0000)]
Correct math for counting how many TSNs were GAP acknowledged

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25429 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGet rid of unused variable.
guy [Wed, 4 Jun 2008 20:53:06 +0000 (20:53 +0000)]
Get rid of unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25428 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoA basic mp4v-es dissector.
etxrab [Wed, 4 Jun 2008 20:34:42 +0000 (20:34 +0000)]
A basic mp4v-es dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25427 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoThe joys of beating header files over the head to get all the various
guy [Wed, 4 Jun 2008 18:05:45 +0000 (18:05 +0000)]
The joys of beating header files over the head to get all the various
APIs we use declared.  We still need to define __EXTENSIONS__ on
Solaris, in order to get strptime() declared.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25426 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago- Make FP radio division mode/speed explicit in struct for R7
martinm [Wed, 4 Jun 2008 17:33:48 +0000 (17:33 +0000)]
- Make FP radio division mode/speed explicit in struct for R7
- Various R7 fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25425 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGet rid of one extra reference for our own g_ascii_strtoull().
guy [Wed, 4 Jun 2008 02:12:57 +0000 (02:12 +0000)]
Get rid of one extra reference for our own g_ascii_strtoull().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25424 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agog_ascii_strtoull() is in GLib 2.2 and later, and we require GLib 2.4 or
guy [Wed, 4 Jun 2008 01:30:40 +0000 (01:30 +0000)]
g_ascii_strtoull() is in GLib 2.2 and later, and we require GLib 2.4 or
later, so there's no longer any need to have our own g_ascii_strtoull.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25423 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSuppress some unused-argument warnings.
guy [Wed, 4 Jun 2008 00:35:30 +0000 (00:35 +0000)]
Suppress some unused-argument warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25422 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSun C warns about an integer overflow for 1 << 31, presumably because 1
guy [Wed, 4 Jun 2008 00:05:57 +0000 (00:05 +0000)]
Sun C warns about an integer overflow for 1 << 31, presumably because 1
is signed; make the flags field in "struct magnify" unsigned, and make
the flags unsigned, so we shift 1U rather than 1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25421 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWe require GLib 2.4 or later, and they define G_MININT32, G_MAXIN32,
guy [Tue, 3 Jun 2008 23:57:47 +0000 (23:57 +0000)]
We require GLib 2.4 or later, and they define G_MININT32, G_MAXIN32,
G_MAXUINT32, and G_MAXUINT64; don't check whether we need to define them
ourselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25420 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGTK+ 1.2[.x] is no longer relevant - we require 2.x - so don't talk
guy [Tue, 3 Jun 2008 23:57:26 +0000 (23:57 +0000)]
GTK+ 1.2[.x] is no longer relevant - we require 2.x - so don't talk
about it in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25419 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agostrtol() returns a long, as the name suggests; assign its return value
guy [Tue, 3 Jun 2008 23:51:39 +0000 (23:51 +0000)]
strtol() returns a long, as the name suggests; assign its return value
to a long, and check whether it fits in a gint before returning it as a
gint.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25418 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoInclude <stdlib.h> to declare strtol().
guy [Tue, 3 Jun 2008 23:35:40 +0000 (23:35 +0000)]
Include <stdlib.h> to declare strtol().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25417 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Frank Schorr:
jake [Tue, 3 Jun 2008 21:24:25 +0000 (21:24 +0000)]
From Frank Schorr:
The get_ifcp_pdu_len() call used for the tcp_dissect_pdus() call does not mask
off the frame length properly.  The result is that the "Flags" field
incorrectly becomes the high order part of the Frame Length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25416 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Frank Schorr:
jake [Tue, 3 Jun 2008 20:41:12 +0000 (20:41 +0000)]
From Frank Schorr:
RFC 4172 section 5.3.1 shows a chart of the iFCP encapsulated Header Format.
It says that bytes 4-7 MUST be zeros.  In reality most vendors are putting some
information in these 4 bytes, particularly Nishon. This caused almost all iFCP
packets to not be decoded for this vendor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25415 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix run checkapi for more targets.
etxrab [Tue, 3 Jun 2008 05:35:19 +0000 (05:35 +0000)]
Fix run checkapi for more targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25414 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRewrote ifopts_options_add() to make it readable and simpler.
stig [Mon, 2 Jun 2008 22:18:25 +0000 (22:18 +0000)]
Rewrote ifopts_options_add() to make it readable and simpler.
Fixed a bug where a one character comment would skip the interface.
If syntax error in the comment just skip the comment instead of the interface.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25413 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRewrote to not use gtk_combo_box_get_active_text().
stig [Mon, 2 Jun 2008 21:35:22 +0000 (21:35 +0000)]
Rewrote to not use gtk_combo_box_get_active_text().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25412 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded an option to set default link-layer header type for each interface.
stig [Mon, 2 Jun 2008 17:45:03 +0000 (17:45 +0000)]
Added an option to set default link-layer header type for each interface.
Set linktype history for each interface so we don't mix them.
Fixed some indents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25411 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't include \r in linktype on win32, it looks weird in the combo box.
stig [Mon, 2 Jun 2008 17:17:24 +0000 (17:17 +0000)]
Don't include \r in linktype on win32, it looks weird in the combo box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25410 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Rudolf Weidmann (bug 2583):
stig [Mon, 2 Jun 2008 07:32:55 +0000 (07:32 +0000)]
From Rudolf Weidmann (bug 2583):
Fixed enumeration type for new-mode in change-of-life-safety.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25409 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoClean up desktop files based on changes made by Stig.
jake [Mon, 2 Jun 2008 07:26:34 +0000 (07:26 +0000)]
Clean up desktop files based on changes made by Stig.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25408 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Toralf Förster: Fix minor typo: MAde -> Made
sfisher [Sun, 1 Jun 2008 18:45:19 +0000 (18:45 +0000)]
From Toralf Förster: Fix minor typo: MAde -> Made

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25407 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate Debian packaging files for Wireshark 1.0.
jake [Sat, 31 May 2008 16:44:02 +0000 (16:44 +0000)]
Update Debian packaging files for Wireshark 1.0.
These files build the package with all features and
minimum changes from the released sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25406 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoReturn the appropriate "everything OK" types.
guy [Fri, 30 May 2008 07:15:05 +0000 (07:15 +0000)]
Return the appropriate "everything OK" types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25405 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoClean up indentation.
guy [Fri, 30 May 2008 07:13:28 +0000 (07:13 +0000)]
Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25404 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoInclude <string.h> to declare strcmp().
guy [Fri, 30 May 2008 05:46:24 +0000 (05:46 +0000)]
Include <string.h> to declare strcmp().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25403 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agog_strcmp0() only shows up on the Intarweb in documentation for some
guy [Fri, 30 May 2008 05:19:54 +0000 (05:19 +0000)]
g_strcmp0() only shows up on the Intarweb in documentation for some
testing version of GLib; it doesn't appear to exist in any current
versions.  There's no need to "gracefully" handle NULL (whatever
"gracefully" means in this context - NULL compares less than any real
string?), as we already checked whether mac_name is null, and we're
comparing it against a string constant; just use strcmp().

In ssh_gslist_compare_strings(), check for null pointers for now.

strcmp() (and strcmp-alikes) don't return a boolean, they return a value
such that comparing strings with a particular operator is done by
comparing the result of strcmp() with 0 using that operator; do that, to
make it clearer that the strings are being compared for equality.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25402 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAgain, the err_info returned from wtap_read() and wtap_seek_read() is a
guy [Fri, 30 May 2008 04:03:32 +0000 (04:03 +0000)]
Again, the err_info returned from wtap_read() and wtap_seek_read() is a
g_mallocated string, so it's not const.

Fix a comment to reflect reality (err_info is some additional
information about the error returned by Wiretap, e.g. some gory details
about the error, mainly useful to developers and support people).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25401 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFree up the err_info string returned by wtap_read() and
guy [Fri, 30 May 2008 02:44:02 +0000 (02:44 +0000)]
Free up the err_info string returned by wtap_read() and
wtap_seek_read().

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25400 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFree up the err_info string returned by wtap_read().
guy [Fri, 30 May 2008 02:37:36 +0000 (02:37 +0000)]
Free up the err_info string returned by wtap_read().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25399 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowtap_read() and wtap_seek_read(), and thus the functions that it calls,
guy [Fri, 30 May 2008 02:34:45 +0000 (02:34 +0000)]
wtap_read() and wtap_seek_read(), and thus the functions that it calls,
are expected to return a g_mallocated error string; that's why they fill
in a gchar **, not a const gchar **.  g_strdup() the argument to
KERROR(), so it's g_mallocated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25398 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Kees Cook via bug #2577 (with minor modifications by me):
sfisher [Fri, 30 May 2008 02:13:30 +0000 (02:13 +0000)]
From Kees Cook via bug #2577 (with minor modifications by me):

provide more detailed SSH dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25397 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix references to tcpdump-workers@tcpdump.org to refer to the new
guy [Fri, 30 May 2008 01:47:57 +0000 (01:47 +0000)]
Fix references to tcpdump-workers@tcpdump.org to refer to the new
address, tcpdump-workers@lists.tcpdump.org.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25396 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoA MAC address is a sequence of 6 8-bit unsigned values (guint8), not a
guy [Fri, 30 May 2008 00:01:24 +0000 (00:01 +0000)]
A MAC address is a sequence of 6 8-bit unsigned values (guint8), not a
sequence of 6 ASCII characters (gchar).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25395 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFor a character string, use an array of char, not an array of guint8
guy [Thu, 29 May 2008 23:53:19 +0000 (23:53 +0000)]
For a character string, use an array of char, not an array of guint8
(the characters are all digits), and, to point to it, use a pointer to
char rather than a pointer to guint8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25394 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the types of k12text_read() and k12text_seek_read() to match what
guy [Thu, 29 May 2008 23:40:12 +0000 (23:40 +0000)]
Fix the types of k12text_read() and k12text_seek_read() to match what
the types of read and seek_read routines in Wiretap are supposed to be,
and get rid of the casts of pointers to those functions (type problems
should be fixed, not papered over with casts, whenver possible).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25393 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoHave iseries_parse_hex_string() take a "const char *" as its first
guy [Thu, 29 May 2008 23:30:51 +0000 (23:30 +0000)]
Have iseries_parse_hex_string() take a "const char *" as its first
argument, as

1) it doesn't modify the string that argument points to

and

2) it's a buffer of "char".

Use g_ascii_xdigit_value() and put the values of the two bytes together
ourselves; strtoul() is a bit of overkill for two-hex-digit pairs.
While we're at it, check for invalid hex digits, and for bytes where
only one hex digit is present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25392 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoNote underflow/overflow possibilities (there used to be checks that
guy [Thu, 29 May 2008 16:51:49 +0000 (16:51 +0000)]
Note underflow/overflow possibilities (there used to be checks that
clamped at TIME_T_MIN and TIME_T_MAX, but newer versions of GCC
"helpfully" warn that the usual checks for overflow or underflow "can't
fail").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25391 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPrint "POSIX capabilities" instead of "libcap".
gerald [Wed, 28 May 2008 18:52:31 +0000 (18:52 +0000)]
Print "POSIX capabilities" instead of "libcap".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25390 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFail the fuzz test (reporting the *input* file as a problem) if capinfos aborts out...
morriss [Wed, 28 May 2008 15:36:29 +0000 (15:36 +0000)]
Fail the fuzz test (reporting the *input* file as a problem) if capinfos aborts out--like it was for iSeries files prior to rev 25388.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25389 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAlways set pkt_encap, not just when we have the start date. This bug, around
morriss [Wed, 28 May 2008 15:01:16 +0000 (15:01 +0000)]
Always set pkt_encap, not just when we have the start date.  This bug, around
since rev 17756, meant that attempts to read iSeries files would fail in the
"Make sure it [pkt_encap] is not WTAP_ENCAP_PER_PACKET" assertion in
wtap_read().

Also set file_encap to WTAP_ENCAP_ETHERNET (instead of WTAP_ENCAP_PER_PACKET)
since it seems that all the packets in iSeries files are Ethernet (or at least
this module currently only supports Ethernet).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25388 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMissed "bytes" -> "bits" changes.
martinm [Tue, 27 May 2008 19:00:47 +0000 (19:00 +0000)]
Missed "bytes" -> "bits" changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25387 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoType 2 hsdsch data is different (size in bytes and byte-aligned).
martinm [Tue, 27 May 2008 16:08:08 +0000 (16:08 +0000)]
Type 2 hsdsch data is different (size in bytes and byte-aligned).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25386 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix max pdu size in hsdsch alloc type 2.
martinm [Tue, 27 May 2008 11:13:57 +0000 (11:13 +0000)]
Fix max pdu size in hsdsch alloc type 2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25385 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoEnable R7 FP for UDP-based variants.
martinm [Tue, 27 May 2008 10:58:15 +0000 (10:58 +0000)]
Enable R7 FP for UDP-based variants.
Correct interpretation of hs-dsch outhdr flag.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25384 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix subtle bugs introduced by recent change to safer APIs.
martinm [Tue, 27 May 2008 10:24:25 +0000 (10:24 +0000)]
Fix subtle bugs introduced by recent change to safer APIs.

I was counting the length without the terminating NULL, and didn't want one to be written to the string and copied into the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25383 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDo plugins Checkapi only if the checkapi target is explicitly invoked.
wmeier [Tue, 27 May 2008 02:14:14 +0000 (02:14 +0000)]
Do plugins Checkapi only if the checkapi target is explicitly invoked.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25382 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Balint Reczey:
jake [Mon, 26 May 2008 20:52:38 +0000 (20:52 +0000)]
From Balint Reczey:
The attached patch extends LAPD dissector to handle LAPD frames sent as RTP payload.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25381 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix run checkapi for more targets.
etxrab [Mon, 26 May 2008 17:09:03 +0000 (17:09 +0000)]
Fix run checkapi for more targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25380 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoShow ops, etc even when no filter set.
martinm [Mon, 26 May 2008 08:22:33 +0000 (08:22 +0000)]
Show ops, etc even when no filter set.
Also avoid crash I was seeing when changing preferences.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25379 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agodissect te lock structures in the LOCK request
sahlberg [Mon, 26 May 2008 02:51:36 +0000 (02:51 +0000)]
dissect te lock structures in the LOCK request

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25378 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd these functions as requested in bug 2553.
martinm [Sun, 25 May 2008 23:55:36 +0000 (23:55 +0000)]
Add these functions as requested in bug 2553.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25377 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMore R7 tweaks and comment updates.
martinm [Sun, 25 May 2008 23:12:56 +0000 (23:12 +0000)]
More R7 tweaks and comment updates.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25376 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Alex Turbov:
jake [Fri, 23 May 2008 19:07:46 +0000 (19:07 +0000)]
From Alex Turbov:
Show result code of last SSI operation with a human readable description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25375 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Alex Turbov:
jake [Fri, 23 May 2008 19:06:16 +0000 (19:06 +0000)]
From Alex Turbov:
Dissector for given SNAC has a bug with actual sizeof of rate_class and
rate_group structure. So in UI clicking on 'Available Rate Classes' and
concrete 'Rate Group 0x??' items in decoded packet window higlight incorrect
bytes in hexdump window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25374 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPrint correct number of packets for captured "From first to last marked packet".
stig [Fri, 23 May 2008 14:51:17 +0000 (14:51 +0000)]
Print correct number of packets for captured "From first to last marked packet".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25373 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAttempt to fix the !win32 build.
stig [Fri, 23 May 2008 13:14:08 +0000 (13:14 +0000)]
Attempt to fix the !win32 build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25372 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd more dissection of FIND infolevels
sahlberg [Fri, 23 May 2008 11:31:01 +0000 (11:31 +0000)]
add more dissection of FIND infolevels

update the BREAK dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25371 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoeth_ --> ws_
wmeier [Fri, 23 May 2008 10:43:04 +0000 (10:43 +0000)]
eth_   -->    ws_

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25370 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix some of the Errors/warnings detected by checkapi.
etxrab [Fri, 23 May 2008 06:06:33 +0000 (06:06 +0000)]
Fix some of the Errors/warnings detected by checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25369 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix some of the Errors/warnings detected by checkapi.
etxrab [Fri, 23 May 2008 05:55:34 +0000 (05:55 +0000)]
Fix some of the Errors/warnings detected by checkapi.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25368 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom cfreeer:
jake [Fri, 23 May 2008 05:36:09 +0000 (05:36 +0000)]
From cfreeer:
Wimax vals_tek_encryption_ids does not confirm the latest spec. Zero should be
"No TEK encryption" instead of "Reserved".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25367 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd dissectors for some more FIND info levels FileBothDirectoryInfo and
sahlberg [Fri, 23 May 2008 04:44:23 +0000 (04:44 +0000)]
add dissectors for some more FIND info levels FileBothDirectoryInfo and
FileIdBothDirectoryInfo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25366 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoenhance the FIND dissector
sahlberg [Fri, 23 May 2008 04:20:54 +0000 (04:20 +0000)]
enhance the FIND dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25365 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoupdate the dissection of NOTIFY
sahlberg [Fri, 23 May 2008 02:51:14 +0000 (02:51 +0000)]
update the dissection of NOTIFY

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25364 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoChange references to follow TCP stream to just follow stream to reflect
sfisher [Fri, 23 May 2008 02:33:24 +0000 (02:33 +0000)]
Change references to follow TCP stream to just follow stream to reflect
the multi-purpose nature of the follow_stream.c code (you can also follow
SSL and UDP streams with it.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25363 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofile_util.c is only for Windows; don't build it on UN*X. Put in a check
guy [Fri, 23 May 2008 02:15:27 +0000 (02:15 +0000)]
file_util.c is only for Windows; don't build it on UN*X.  Put in a check
to cause it to fail when built on UN*X, and get rid of code that's not
needed on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25362 f5534014-38df-0310-8fa8-9805f1628bb7