guy [Thu, 29 Nov 2007 08:17:44 +0000 (08:17 +0000)]
Is ping not installed on the Solaris buildbot, or does the path of the
script not include /usr/sbin, or is ping installed somewhere other than
where it is on my Solaris "machine"? Try explicitly running it as
/usr/sbin/ping on Solaris.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23670
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 29 Nov 2007 07:52:52 +0000 (07:52 +0000)]
hide implementation of module list
(it makes easier change from GList to GTree as we have many modules now and GList implementation is slow for searching)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23669
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 29 Nov 2007 07:48:12 +0000 (07:48 +0000)]
fix GLIB 1.x compatibility
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23668
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 29 Nov 2007 07:40:08 +0000 (07:40 +0000)]
Count stats for parent if encountering a field not related to a protocol.
This fixes a bug where packets having toplevel tree items for desegmentation
(like [Reassembled TCP Segments]) are not added to the Protocol Hierarchy
Statistics "End Packets" and "End Bytes" columns.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23667
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 29 Nov 2007 06:29:20 +0000 (06:29 +0000)]
Didier Gautheron:
Only call ether_to_str(), get_ether_name() if the tree is visible, they are slow.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23666
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 29 Nov 2007 06:28:07 +0000 (06:28 +0000)]
Didier Gautheron:
Call subdissectors preference for retransmitted frames.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23665
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 29 Nov 2007 00:01:09 +0000 (00:01 +0000)]
From Didier Gautheron: Fix for Bug #1862: JPEG (JFIF) packet always malformed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23662
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 28 Nov 2007 22:56:27 +0000 (22:56 +0000)]
Change each filter prefix to match the protocol name ("wmx"). Add a
"wmx" prefix to each sub-protocol. "wmx"-ize the preferences and
dissector registration.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23660
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 28 Nov 2007 22:44:37 +0000 (22:44 +0000)]
From Didier Gautheron: Bug #2042: Move constants initialisation at compile time.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23659
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 28 Nov 2007 22:37:33 +0000 (22:37 +0000)]
From Didier Gautheron: Bug #2040: Fix up goto at compilation time in gencode.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23658
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Wed, 28 Nov 2007 22:36:53 +0000 (22:36 +0000)]
Remove "Reset coloring" from context menu's to keep the GUI consistent
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23657
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 28 Nov 2007 22:29:00 +0000 (22:29 +0000)]
Tweak the order in which fields are registered, so that they don't
show up as protocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23656
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 28 Nov 2007 22:13:50 +0000 (22:13 +0000)]
Fropm Anders: Broman: Fix for bug #2041
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23655
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Wed, 28 Nov 2007 22:07:44 +0000 (22:07 +0000)]
Add sensitivity to some temporary coloring menu items.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23654
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 28 Nov 2007 21:44:40 +0000 (21:44 +0000)]
Didier Gautheron:
icmp dissector must call subdissectors even if tree is NULL
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23653
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 28 Nov 2007 21:33:01 +0000 (21:33 +0000)]
Add a link to NASM
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23652
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 28 Nov 2007 20:06:21 +0000 (20:06 +0000)]
Fixes for Windows build w/o ZLIB
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23651
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 28 Nov 2007 19:53:36 +0000 (19:53 +0000)]
(Somewhat academic): Fix fread related bug (when using GTK1).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23650
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Wed, 28 Nov 2007 18:59:37 +0000 (18:59 +0000)]
From Brian W. Antoine:
The Packet decoder for CFM has a couple of small bugs.
1) The frame rate for CCM's is wrong for rate=4, it's shown as 1ms and it should be shown as 1s.
2) The flags display for a LTM packet has the wrong title for bit 7. It should be UseFDBonly, not RDI.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23649
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Wed, 28 Nov 2007 18:02:01 +0000 (18:02 +0000)]
Apply coloring rules also when a frame is marked so that when a frame
is un-marked *after* enabling coloring it is still colored.
Fixes bug 2038
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23648
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 28 Nov 2007 17:43:42 +0000 (17:43 +0000)]
Fix filename in comment at top (it's .asm not .c)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23647
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 28 Nov 2007 15:55:50 +0000 (15:55 +0000)]
Use guints instead of guint8s for counters.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23646
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 28 Nov 2007 14:39:51 +0000 (14:39 +0000)]
try to fix *nix build environment
in accordance with asm_utils.c/asm_utils_win32_x86.asm used in Win32
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23645
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 28 Nov 2007 12:30:18 +0000 (12:30 +0000)]
Put double click on a frame link back.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23644
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 28 Nov 2007 10:18:16 +0000 (10:18 +0000)]
Various changes with focus to startup speedup
The startup timeout on Win32 is reduced to 80% without assembler and to 50% with assembler usage (which is optional)
proto.c
- do not look up in filed tree and inserts in two steps but do it at once
- next few small speedups
- some often called elementary functions can be optionally implemented in assembler
- dispart some functions to see more exact result from profiling
packet-tpnc.c
- do not reallocate memory for each filed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23643
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 28 Nov 2007 09:30:10 +0000 (09:30 +0000)]
Fixed a possible infinite loop.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23642
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Nov 2007 06:21:28 +0000 (06:21 +0000)]
update to most recent wkssvc.idl from the samba4 repository
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23641
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 28 Nov 2007 03:04:09 +0000 (03:04 +0000)]
Fix bug #954 for LDAP SRT stats along with the same problem in all the other
SRT code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23640
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 28 Nov 2007 02:54:23 +0000 (02:54 +0000)]
Fix a problem whereby the smb2 service resposne time statistics filter was
getting a comma added to be beginning of the filter that the user entered.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23639
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Nov 2007 01:31:23 +0000 (01:31 +0000)]
some more path fixes for g_ascii_strcasecmp.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23638
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Nov 2007 01:27:07 +0000 (01:27 +0000)]
no need to include those xpm's unless we are building for gtk2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23637
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Nov 2007 01:23:09 +0000 (01:23 +0000)]
fix the path to include g_ascii_strcasecmp.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23636
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Nov 2007 01:21:33 +0000 (01:21 +0000)]
we must include glib.h so we know what gchar and gsize is
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23635
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 28 Nov 2007 01:20:46 +0000 (01:20 +0000)]
we must include config.h or else NEED_G_ASCII_STRCASECMP_H will never be
defined
we must also include g_ascii_strcasecmp.h from the parent directory
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23634
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 28 Nov 2007 01:09:02 +0000 (01:09 +0000)]
Summary enhancements:
- Added traffic statistics for marked packages.
- Do not show Displayed column unless using it.
- Removed Marked packets line, as this info is in the marked packets column.
Will add documentation changes if keeping this feature.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23633
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 28 Nov 2007 01:04:11 +0000 (01:04 +0000)]
Fixed a bug when adjusting summary marked start time.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23632
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 27 Nov 2007 22:54:15 +0000 (22:54 +0000)]
- Added SEQ/ACK analysis for reports and notifications.
- Identify ack type in COL_INFO.
- No analysis when in error packets.
- Some cleanup in hf_ names.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23630
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Nov 2007 21:25:32 +0000 (21:25 +0000)]
Update to sqlite lemon 1.51
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23629
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Nov 2007 21:24:39 +0000 (21:24 +0000)]
Apply yet another of the optimization patches:
- Only call functions if they are needed or once.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23628
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 27 Nov 2007 21:23:45 +0000 (21:23 +0000)]
Apply yet another of the optimization patches:
- Remove a spurious volatile.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23627
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 27 Nov 2007 20:06:20 +0000 (20:06 +0000)]
Ban strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp()
while we're at it. More to come....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23626
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 27 Nov 2007 20:03:43 +0000 (20:03 +0000)]
From Sam Leffler: Add support for IEEE80211_RADIOTAP_XCHANNEL.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23625
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 27 Nov 2007 19:57:35 +0000 (19:57 +0000)]
Fixes from Sam Leffler:
In capture_sync.c: Don't clobber the DLT value.
In packet-cops.c (modified by me): Instead of adding an item as a static,
mis-cast FT_UINT16 to the tree, add it as an FT_NONE.
In packet-802.11.c: Add the right address to the tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23624
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 27 Nov 2007 18:52:51 +0000 (18:52 +0000)]
strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).
In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.
We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot. This causes strings that should
match not to match.
This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23623
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Tue, 27 Nov 2007 18:07:00 +0000 (18:07 +0000)]
Fixes to:
a) Check that UPX is configured correctly and offer solutions;
b) Ignore any errors generated from UPX (e.g. from previously compressed files); and
c) Clean up the tools directory when cleaning the U3 distribtion
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23622
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Tue, 27 Nov 2007 17:46:55 +0000 (17:46 +0000)]
Fix from Stephen Fisher for bug 2028.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23621
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 27 Nov 2007 16:08:24 +0000 (16:08 +0000)]
Don't attach to any TCP/UDP ports if we weren't able to load the database--and thus the hf_ entries (which are required for dissection).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23620
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 27 Nov 2007 11:21:12 +0000 (11:21 +0000)]
Added tvb_get_ephemeral_faked_unicode and tvb_get_ephemeral_stringz
to epan/libwireshark.def
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23619
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Tue, 27 Nov 2007 06:49:48 +0000 (06:49 +0000)]
Fix for bug 2000. Make sure that both datalink layer and application layer agree that information is missing before refusing to write a payload.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23618
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 27 Nov 2007 05:43:29 +0000 (05:43 +0000)]
Add support for showing wireless LAN info (signal strength / rate / channel)
in Wireshark when reading CommView files. Also write out these values when
coming from a file format with encapsulation type 802.11 with radio.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23617
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 27 Nov 2007 01:49:40 +0000 (01:49 +0000)]
fix mpa_... problems
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23616
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 27 Nov 2007 01:41:42 +0000 (01:41 +0000)]
Check for AVPs with a list of values and a type that's not a 32-bit or
shorter integral type. Fixes bug 2027.
Rename the "bytes" pointer to "octetstring", and initialize it in a
fashion that makes it clearer that it points to the first of the basic
types, to make it clearer that it's for OctetString.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23615
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 27 Nov 2007 01:02:03 +0000 (01:02 +0000)]
From Tuomas Maattanen: Fix a .11e QBSS IE endian error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23614
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 27 Nov 2007 00:36:41 +0000 (00:36 +0000)]
Make sure we fully initialize a struct. Fixes bug 2021.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23613
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 23:06:07 +0000 (23:06 +0000)]
Get rid of the global data structures populated by wiretap/mpeg-audio but
used by the mpeg-audio dissector: instead keep the data inside the wiretap
module and add accessor functions. I think this should fix
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677 and anyway it's
cleaner.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23612
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 26 Nov 2007 21:54:00 +0000 (21:54 +0000)]
Disable splash message logging, since it seems to ignore the log level mask.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23611
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 19:11:26 +0000 (19:11 +0000)]
Oops, don't put a comment inside a comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23610
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 18:59:32 +0000 (18:59 +0000)]
When we've found C++ style comments, tell which file we found them in.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23609
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 18:55:17 +0000 (18:55 +0000)]
Get rid of C++/C99 style comments--not all compilers support them
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23608
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 26 Nov 2007 18:51:24 +0000 (18:51 +0000)]
Use the offset and length for the interesting data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23607
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 26 Nov 2007 18:38:03 +0000 (18:38 +0000)]
If the user has G_LOG_LEVEL_INFO enabled, provide startup progress messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23606
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 18:35:37 +0000 (18:35 +0000)]
s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23605
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 18:00:21 +0000 (18:00 +0000)]
From Florent Drouin via bugs.wireshark.org/bugzilla/show_bug.cgi?id=2015 : fix crash when editing UAT tables
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23604
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 17:28:12 +0000 (17:28 +0000)]
gcc-4.1.1 thinks 'retval' might not get set inside the TRY(). Initialize it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23603
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 26 Nov 2007 17:03:12 +0000 (17:03 +0000)]
Use correct offset for subtree in dissect_spoolss_relstr.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23602
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 26 Nov 2007 16:40:17 +0000 (16:40 +0000)]
Change (yet another--I really need to find a way to automate finding these things) open() to eth_open() to fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=1987
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23601
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 26 Nov 2007 16:38:26 +0000 (16:38 +0000)]
From Kai Blin:
Dissect the PRINTER_INFO structure in the SpoolssEnumPrinters call.
From me:
Add the level info to COL_INFO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23600
f5534014-38df-0310-8fa8-
9805f1628bb7
standel [Mon, 26 Nov 2007 14:42:38 +0000 (14:42 +0000)]
Update error handling of UDP Light Illegal Checksum value 0
* change expert group from PI_MALFORMED to PI_CHECKSUM (as it should be!!!).
* set item hf_udp_checksum_[good|bad] as generated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23599
f5534014-38df-0310-8fa8-
9805f1628bb7
standel [Mon, 26 Nov 2007 14:30:40 +0000 (14:30 +0000)]
iUpdate error handling of UDP Light Illegal Checksum value 0
* Adding PI_MALFORMED expert field for this case.
* Adding an error string in COL_INFO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23598
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 26 Nov 2007 11:16:04 +0000 (11:16 +0000)]
Check current_frame instead of finfo_selected before trying to build a
display filter based on the "selected" package.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23597
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Mon, 26 Nov 2007 09:10:37 +0000 (09:10 +0000)]
Check if a packet is selected before trying to build a display filter based
on the "selected" packet. Fixes bug 2020.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23596
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 26 Nov 2007 08:08:51 +0000 (08:08 +0000)]
Change %G to %Y for year in strftime() so it works on Windows also (%G is an extension found at least on OS X). Also change from 4 to 5 bytes in each strftime() to allow space for the NULL terminator with 4 character outputs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23595
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 26 Nov 2007 05:34:07 +0000 (05:34 +0000)]
Add writing support for the CommView file format.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23594
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 25 Nov 2007 23:08:09 +0000 (23:08 +0000)]
Fix bug 2019: The SMB dissector was dereferencing a NULL pointer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23593
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 25 Nov 2007 21:38:18 +0000 (21:38 +0000)]
Move some items back into capture_loop.c (since TShark no longer needs them).
Clean up some of the Windows named pipe code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23592
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 25 Nov 2007 21:33:34 +0000 (21:33 +0000)]
If a child doesn't quit 500ms after sending a QUIT signal, force it to exit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23591
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 25 Nov 2007 21:30:57 +0000 (21:30 +0000)]
Added checksum.good and checksum.bad items.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23590
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 25 Nov 2007 21:30:33 +0000 (21:30 +0000)]
Added checksum.good and checksum.bad items.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23589
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 25 Nov 2007 19:20:32 +0000 (19:20 +0000)]
Header field array and whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23588
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Sun, 25 Nov 2007 18:10:01 +0000 (18:10 +0000)]
Bug 1997 From Timo Teras:
Patch to do the following:
1) Dissect CIE Lists in NHRP Extensions
2) Dissect original NHRP packet in Error Indication
3) Support for Cisco NAT extensions
4) Support for Cisco NHRP Traffic Indication packet
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23587
f5534014-38df-0310-8fa8-
9805f1628bb7
gal [Sun, 25 Nov 2007 17:46:42 +0000 (17:46 +0000)]
Changes suggested/provided by Anders so that fewer changes are required to the ASN modules.
Also includes the MSAccessProtocol.asn to generate defines for the operation numbers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23586
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Sun, 25 Nov 2007 15:55:45 +0000 (15:55 +0000)]
Make it possible to "move" a filter around the temporary coloring rules
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23585
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sun, 25 Nov 2007 15:36:38 +0000 (15:36 +0000)]
Based on suggestion from Stig Bjørlykke. Add CRC tree even when CRC is missing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23584
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Sun, 25 Nov 2007 14:17:56 +0000 (14:17 +0000)]
Reset the temporary coloring filters to defaults instead of doing it
implicitly by calling "color_filters_init()". This should probably
fix the crashes experienced when pressing ctrl-space a couple of times
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23583
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Sun, 25 Nov 2007 12:36:33 +0000 (12:36 +0000)]
Fixes crashing when opening color filters and pressing OK
(introduced in SVN 23560)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23582
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 25 Nov 2007 12:15:02 +0000 (12:15 +0000)]
From Joe Eykholt:
Show content even if the trailer is missing.
From me:
Add proto_tree_set_appendix for the checksum and EOF.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23581
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 25 Nov 2007 02:20:41 +0000 (02:20 +0000)]
Set an initial value to make gcc 4.1.3
20070929 (prerelease) on Ubuntu happy.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23580
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 25 Nov 2007 02:06:41 +0000 (02:06 +0000)]
Clean up a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23579
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 25 Nov 2007 01:53:45 +0000 (01:53 +0000)]
Removed a "/*" within comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23578
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 25 Nov 2007 01:48:01 +0000 (01:48 +0000)]
Corrected setting of "warnings_as_errors_default".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23577
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 25 Nov 2007 00:50:49 +0000 (00:50 +0000)]
Put in a comment about encapsulation hint values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23576
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 25 Nov 2007 00:23:37 +0000 (00:23 +0000)]
Note that the encapsulation type values are SNMP ifType values, and
suggest that perhaps WTAP_ENCAP_PER_PACKET be used for
propPointToPointSerial and HDLC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23575
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 24 Nov 2007 23:51:27 +0000 (23:51 +0000)]
Terminate <para> with </para>.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23574
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 24 Nov 2007 23:43:21 +0000 (23:43 +0000)]
From James Menzies: if the per-packet encapsulation hint is 14, the
packets are always PPP, otherwise they're of an unknown type and we use
a heuristic to guess the type.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23573
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 24 Nov 2007 23:04:49 +0000 (23:04 +0000)]
From Graham Bloice:
Show correct TCP segment data (and length) when multiple pdus.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23572
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 24 Nov 2007 22:45:57 +0000 (22:45 +0000)]
From Alex Burlyga:
It looks like in dissect_nfs_open_claim_delegate_cur4() instead of dissection
stateid we are doing something wierd and dissecting uint64 instead(remnants of
rfc3010 where stateid was 64 bit number?). We already have function for
dissecting stateids, so just a matter of making a different call.
From me:
Also deleted the hf_nfs_stateid4_delegate_stateid entry.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23571
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 24 Nov 2007 22:09:01 +0000 (22:09 +0000)]
From J. Bruce Fields:
Add basic support for NFSv4.1, as of about draft 13 of the current spec.
The protocol is not completely finished yet, and future patches will be
needed to bring it up to date.
From me:
- Add a check for valid pointers in nfsv4_operation_ett
- Always increase offset when calling dissect_nfs_devices4
- Added a default case in dissect_rpc_secparms4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23570
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 24 Nov 2007 20:55:03 +0000 (20:55 +0000)]
Add a cast to make it compile again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23569
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 24 Nov 2007 19:13:54 +0000 (19:13 +0000)]
Make sure h225_pi is never NULL.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23568
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 24 Nov 2007 17:56:46 +0000 (17:56 +0000)]
Fix crash reported in bugs.wireshark.org/bugzilla/show_bug.cgi?id=2014 : when adding fragments to the linked list of end fragments, don't check the TSN of the begin fragment--it may not be there. Looks like a cut-n-pasteo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23567
f5534014-38df-0310-8fa8-
9805f1628bb7