jake [Sat, 26 Mar 2011 11:23:46 +0000 (11:23 +0000)]
From Hadar Shoham:
Add support to correlation ID under DHCPv6 according to
"CL-SP-CANN-DHCP-Reg-I06-110210"
DHCPv6 option 17 Vendor-specific Information, sub option 2172 (paragraph 5.4.3)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36347
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 26 Mar 2011 05:39:45 +0000 (05:39 +0000)]
remove a proto_item variable we never use
coverity 866
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36346
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 26 Mar 2011 05:18:09 +0000 (05:18 +0000)]
remove a proto_item variable we dont need
coverity 1046
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36345
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 02:39:04 +0000 (02:39 +0000)]
Introduce ep_strconcat (copied from the glib version)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36344
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 02:11:42 +0000 (02:11 +0000)]
Remove some duplicated string manipulation code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36343
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 01:22:31 +0000 (01:22 +0000)]
Simplify the generation of the 'name' passed to tick_stat_node().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36342
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 01:21:43 +0000 (01:21 +0000)]
The 'name's passed to tick_stat_node() do not need to be static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36341
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2011 23:45:48 +0000 (23:45 +0000)]
Fix Coverity CIDs 810 & 811: uninitialized variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36340
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 25 Mar 2011 22:35:29 +0000 (22:35 +0000)]
Fix Coverity 331, 332, 333: Wrap the three remaining
gtk_tree_selection_get_selected() calls with if(!..) return;
like the rest of them. These functions shouldn't be called
unless a packet was selected, so this call should always return
TRUE for success.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36339
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 22:20:27 +0000 (22:20 +0000)]
Reword the comments from rev 36304.
Replace the tabs in the file (mostly added by me) with spaces (for consistency).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36338
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 25 Mar 2011 22:16:23 +0000 (22:16 +0000)]
Fix coverity 268, 269, 546, 547, 548, 549 by checking for null return
from p_get_proto_data() since it should have been set already by the
calling function. Any other case would be a bug, so call
DISSECTOR_ASSERT in those cases. Hopefully Coverity realizes that this
is a null return value check.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36337
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 25 Mar 2011 22:13:33 +0000 (22:13 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 941
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36336
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 25 Mar 2011 21:52:56 +0000 (21:52 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 958-961.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36335
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 25 Mar 2011 21:09:28 +0000 (21:09 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 852,854;
Add a hidden item to the correct subtree: Coverity 853.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36334
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 20:04:54 +0000 (20:04 +0000)]
As suggested by Didier in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to some more dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36333
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 19:02:18 +0000 (19:02 +0000)]
From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)
A couple of the patches had to be manually applied.
From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36332
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 25 Mar 2011 18:51:12 +0000 (18:51 +0000)]
Change urb_type from FT_STRING to FT_UINT8. This fixes the display filtering
for this field. This change was prompted because of the following query:
http://ask.wireshark.org/questions/3113/usburb_type-values
Also, remove 2 unused fields found by running tools/checkhf.pl.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36331
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 15:45:37 +0000 (15:45 +0000)]
Fix the problem reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3785#c14 :
If we thought we finished reassembly (and called the subdissector) only to find
out that the subdissector asked for more data, handle the case where the
subdissector asked for DESEGMENT_UNTIL_FIN. Previously we only handled the
possibility that the subdissector would ask for a specific number of bytes or
DESEGMENT_ONE_MORE_SEGMENT.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36330
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:26:17 +0000 (07:26 +0000)]
remove two unused assignments
coverity 1050
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36329
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:22:23 +0000 (07:22 +0000)]
use the newly created tree to store the new items instead of the parent tree
coverity 842
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36328
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:19:15 +0000 (07:19 +0000)]
remove unused variable
coverity 229
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36327
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:15:48 +0000 (07:15 +0000)]
remove an unused variable
coverity 1044
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36326
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 25 Mar 2011 06:42:59 +0000 (06:42 +0000)]
Make it build on Windows 7
(pcapng.c(1817) : warning C4267: '=' : conversion from 'size_t' to 'gint', possible loss of data)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36325
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 03:07:05 +0000 (03:07 +0000)]
remove assignment of an unused value
coverity 1178
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36324
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2011 00:28:47 +0000 (00:28 +0000)]
If a segment looks like a retransmission, don't mark it out-of-order.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36323
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 23:34:13 +0000 (23:34 +0000)]
Don't assign to a proto_item* if the value won't be used:
Also: Fix a bug wherein PPP_RTP_CUD8 was being registered
to "ppp.protocol" with the cudp16 handle rather than the cudp8 handle.
Coverity 1004-1013
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36322
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2011 23:33:38 +0000 (23:33 +0000)]
Add a missing include.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36321
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 23:05:36 +0000 (23:05 +0000)]
Fix a compile warning: unused variable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36320
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2011 22:58:45 +0000 (22:58 +0000)]
Add an item about pcapng name resolution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36319
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2011 22:47:57 +0000 (22:47 +0000)]
Add initial pcapng name resolution record support. Wireshark has read
support; TShark has read+write support. Additionally TShark can read a
"hosts" file and write those records to a capture file.
This uses "struct addrinfo" in many places and probably won't compile on
some platforms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36318
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 22:27:20 +0000 (22:27 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 942-951
Also: minor Code & Whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36317
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 24 Mar 2011 21:22:07 +0000 (21:22 +0000)]
Only display the 3 digits of precision after the decimal that we have
from the ICMP conversation response time tracking.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36316
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 21:19:39 +0000 (21:19 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;
Also:
- Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being
done on an already hidden item).
- Minor indentation cleanup;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36315
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 20:17:22 +0000 (20:17 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 1124-1128;
Also: minorwhitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36314
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 24 Mar 2011 18:05:10 +0000 (18:05 +0000)]
Display the value of the ICMP echo request/reply response time in milliseconds.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36313
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 17:37:07 +0000 (17:37 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36312
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 24 Mar 2011 16:21:31 +0000 (16:21 +0000)]
Export next_tvb_... functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36311
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 16:03:12 +0000 (16:03 +0000)]
Don't assign to a proto_item* if the value isn't to be used: Coverity 1173;
Also:
- Fix 2 cases of an item attached to the wrong subtree;
- "localize" & rename some variable definitions;
- Minor indentation cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36310
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 24 Mar 2011 15:31:52 +0000 (15:31 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 3 :
Enhance MySQL : Request/Response sub-dissector/function
(white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()...)
Patch 4 :
Enhance MySQL : packet_ok, server, capa sub-dissector/function (white space
changes, use ENC_NA when appropriate, use proto_tree_add_item()...)
Split mysql_dissect_caps in mysql_dissect_caps_client and
mysql_dissect_caps_server
Rename mysql_dissect_ext_caps to mysql_dissect_ext_caps_client
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36309
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2011 10:36:39 +0000 (10:36 +0000)]
Beutify IMEISV IE output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36308
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2011 10:35:29 +0000 (10:35 +0000)]
Fix Checkapi errors
Error: the name for field " N32" ("gsm_rlcmac_dl.n32") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N51" ("gsm_rlcmac_dl.n51") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N26" ("gsm_rlcmac_dl.n26") has leading space in packet-gsm_rlcmac.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36307
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2011 09:20:14 +0000 (09:20 +0000)]
From Vincent Helfre:
I updated again the csn1 dissector to associate hf_field to each element.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36306
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 24 Mar 2011 02:49:05 +0000 (02:49 +0000)]
From Dirk: fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2930 :
Make the image (png, gif, jfif) dissectors "new style" so that they don't
dissect data that does not belong to them.
Modify the HTTP dissector to call heuristic dissectors on the body if the
registered subdissector does not accept/dissect the data.
From me: don't use assert() and don't add a preference to the HTTP dissector
for this behavior: it makes sense to behave like that by default.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36305
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 24 Mar 2011 02:10:04 +0000 (02:10 +0000)]
If we've already seen a segment which starts a multi-segment pdu (i.e., it's
a retransmission), don't add it to the list (tree) of multi-segment pdus.
Otherwise, if we'd already seen the rest of the pdu and the other segments
were not retransmitted, the retransmission would break dissection of the pdu
because lookups for the segment would find the retransmission (to which the
other segments were not attached).
Since we know this segment is a retransmission, don't bother handing it off
to the subdissector either.
Use PINFO_FD_VISITED().
Add some white space in the desegmentation routine to improve readability.
Apply the same changes to the SSL dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36304
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 23 Mar 2011 23:36:39 +0000 (23:36 +0000)]
More markup updates.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36303
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 23 Mar 2011 22:31:59 +0000 (22:31 +0000)]
Fix markup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36302
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 23 Mar 2011 21:17:29 +0000 (21:17 +0000)]
remove a conditional that can never be true
coverity 247
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36301
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 23 Mar 2011 21:03:18 +0000 (21:03 +0000)]
Clean up information about older Windows versions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36300
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 23 Mar 2011 20:38:16 +0000 (20:38 +0000)]
Added an entry about the new tshark "-z <proto>,srt" syntax.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36299
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 23 Mar 2011 20:20:40 +0000 (20:20 +0000)]
Add ICMP echo request/reply conversation tracking. Closes bug 5770.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36298
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 23 Mar 2011 20:00:13 +0000 (20:00 +0000)]
From: wireshark.org/lists/wireshark-dev/201103/msg00157.html
Change RTT references to SRT.
(tshark.pod could use a description for -z afp,srt and -z camel,srt)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36297
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 23 Mar 2011 19:12:24 +0000 (19:12 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 1 :
Enhance MySQL : Reorder hf and Proto_reg
Patch 2 :
Enhance MySQL : white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36296
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 23 Mar 2011 18:55:02 +0000 (18:55 +0000)]
Remove unneeded NULL Test...
Addresses Coverity 598
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36295
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 23 Mar 2011 18:10:34 +0000 (18:10 +0000)]
Recode a loop slightly ....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36294
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 23 Mar 2011 15:21:18 +0000 (15:21 +0000)]
Fix bug: 'if ((octet & 0x80) == 80)' ==> 'if ((octet & 0x80) == 0x80)'
Coverity 345
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36293
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 23 Mar 2011 15:15:02 +0000 (15:15 +0000)]
Fix bugs: 'if ((flags & 0x2) == 1)' ==> 'if ((flags & 0x2) != 0)'
Coverity 346 & 347
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36292
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 14:58:34 +0000 (14:58 +0000)]
Fixed second parameter to create_persconffile_profile.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36291
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 14:52:39 +0000 (14:52 +0000)]
Ensure we create the "Default" personal configuration files directory before
creating a new profile. This fixes a bug when trying to create a new profile
from a newly installed wireshark with no saved preferences.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36290
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 23 Mar 2011 14:51:40 +0000 (14:51 +0000)]
Fix bug: 'guint8 |=0x8000'.
Coverity 350
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36289
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 23 Mar 2011 13:18:38 +0000 (13:18 +0000)]
Don't use C++/C99-style comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36288
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 23 Mar 2011 11:35:03 +0000 (11:35 +0000)]
Remove some unncessary assignments to proto_item pointers.
Coverity 904 & 905.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36287
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 23 Mar 2011 10:58:24 +0000 (10:58 +0000)]
Don't assign proto_item pointers that are not used.
Coverity CIDs 1021 & 1022.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36286
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 23 Mar 2011 10:12:35 +0000 (10:12 +0000)]
Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36285
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 23 Mar 2011 09:14:50 +0000 (09:14 +0000)]
From Vincent Helfre:
- added documentation in packet-csn1.h
- fixed a bug in packet-csn1.c
- fixed a BSIC description in packet-gsm_a_rr.c
- removed the "_v" suffix in packet-gsm_rlcmac element description
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36284
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 08:03:02 +0000 (08:03 +0000)]
Removed unused parameter to parseServiceNodeId.
Coverity 596.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36283
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 07:34:00 +0000 (07:34 +0000)]
Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst.
Coverity 535.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36282
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 07:31:17 +0000 (07:31 +0000)]
Removed "comparing an array to null", with no effect.
Coverity 534.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36281
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 07:29:19 +0000 (07:29 +0000)]
Removed "comparing an array to null", with no effect.
Coverity 533.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36280
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 23 Mar 2011 07:25:08 +0000 (07:25 +0000)]
Removed "comparing an array to null", with no effect.
Coverity 532.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36279
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 23 Mar 2011 06:50:09 +0000 (06:50 +0000)]
value&0x03 does not need to be shifted to the right by two.
cut-n-paste bug from a few lines above where value&0x0c do need to be shifted by two
before printing as a value
coverity 342
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36278
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 23 Mar 2011 05:48:58 +0000 (05:48 +0000)]
CID 453,454
Missing break
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36277
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 23 Mar 2011 05:18:26 +0000 (05:18 +0000)]
dont assign to a proto_item* unless we are going to use the value
coverity 1157
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36276
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 23 Mar 2011 05:11:06 +0000 (05:11 +0000)]
Print the time units in the CSV output for io_stat using correct extension, i.e. always in seconds.
coverity 419
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36275
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 23 Mar 2011 04:55:22 +0000 (04:55 +0000)]
Shift the correct number of steps when masking the UAAERP bit to 0/1
coverity 348
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36274
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 23 Mar 2011 04:50:17 +0000 (04:50 +0000)]
The NSG bits in the login pdu are 0x0c not 0xc0
coverity 344
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36273
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 23 Mar 2011 00:43:55 +0000 (00:43 +0000)]
Don't compute each checksum twice when adding dummy headers (-u, -T, -s, -S options)
g_ntohs() & friends may be (are ?) macros and may (will ?) eval args more than once ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36272
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 22 Mar 2011 21:15:36 +0000 (21:15 +0000)]
Don't compile expert_dlg.c (that dialog is being removed)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36271
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 22 Mar 2011 21:07:00 +0000 (21:07 +0000)]
Clarify a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36270
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 22 Mar 2011 20:48:36 +0000 (20:48 +0000)]
Coverity 989
Remove some item= assignments we dont need since we never use the value
of the created item.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36269
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 19:48:55 +0000 (19:48 +0000)]
Added a sanity check for finfo->hfinfo.
Coverity 425.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36268
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 22 Mar 2011 19:27:48 +0000 (19:27 +0000)]
Remove two tests for fail return from g_malloc(); Fixes Coverity #424 "FORWARD_NULL"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36267
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 19:24:08 +0000 (19:24 +0000)]
Allocate correct size of fdata col_text and col_text_len.
Coverity 711 & 716.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36266
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 19:16:19 +0000 (19:16 +0000)]
Allocate correct size of nwk_keyring.
Coverity 715.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36265
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 19:13:48 +0000 (19:13 +0000)]
Allocate correct size of hash_key.
Coverity 713.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36264
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 19:13:05 +0000 (19:13 +0000)]
Allocate correct size of reload_frame.
Coverity 714.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36263
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 18:58:32 +0000 (18:58 +0000)]
Allocate correct size of range.
Coverity 718.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36262
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 18:53:37 +0000 (18:53 +0000)]
Allocate correct size of int, not size of a pointer to int.
Coverity 717.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36261
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 18:42:02 +0000 (18:42 +0000)]
Initialize al_cto before usage.
Coverity 808.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36260
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 18:28:08 +0000 (18:28 +0000)]
Initialize geom in window_get_geometry.
Coverity 804.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36259
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 22 Mar 2011 18:26:36 +0000 (18:26 +0000)]
Fix potential array overrun: Coverity CID #565.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36258
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 22 Mar 2011 18:24:38 +0000 (18:24 +0000)]
Fix mask when extracting FACH Indicator.
Coverity CID 349.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36257
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 22 Mar 2011 18:06:58 +0000 (18:06 +0000)]
Remove redundant comparison.
Coverity CID 361.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36256
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 22 Mar 2011 17:46:59 +0000 (17:46 +0000)]
Make a struct static to avoid growing the stack too much.
Coverity CID 753.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36255
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 22 Mar 2011 17:37:47 +0000 (17:37 +0000)]
Don't assign top_ti - delete it for now.
Coverity CID 862
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36254
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 22 Mar 2011 16:43:16 +0000 (16:43 +0000)]
From Dirk via bug #5771: Add heuristic dissector for images and HTTP
Also add to AUTHORS file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36253
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 22 Mar 2011 16:33:39 +0000 (16:33 +0000)]
We have to initialize the elements of the fdata->col_text array to null
pointers, as there's code that assumes that if they're not set to null
pointers, they're set correctly, and doesn't bother setting them to the
right value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36252
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 22 Mar 2011 16:05:12 +0000 (16:05 +0000)]
Copy expert_tapdata_t here so that expert_dlg.h is no longer needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36251
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 22 Mar 2011 14:39:02 +0000 (14:39 +0000)]
There can be up to 15 DL HARQ processes (depending upon TDD config index).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36250
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 22 Mar 2011 13:49:07 +0000 (13:49 +0000)]
Fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36249
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 22 Mar 2011 12:12:04 +0000 (12:12 +0000)]
Pass pointers to structs instead of struct values to create_ntlmssp_v2_key.
Coverity 567.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36248
f5534014-38df-0310-8fa8-
9805f1628bb7