cmaynard [Wed, 30 Mar 2011 14:44:18 +0000 (14:44 +0000)]
Wrap all text lines of help at column 80.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36408
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 30 Mar 2011 04:36:09 +0000 (04:36 +0000)]
remove two pointless const in casts
coverity 580 and 581
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36407
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 30 Mar 2011 03:39:58 +0000 (03:39 +0000)]
remove some assignments we dont use
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36406
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 29 Mar 2011 21:40:54 +0000 (21:40 +0000)]
Change TCP_PORT_MANGO to TCP_PORT_MONGO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36405
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 21:39:15 +0000 (21:39 +0000)]
Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 760-761.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36404
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:20:36 +0000 (21:20 +0000)]
Add a missing break.
CID 487
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36403
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:11:26 +0000 (21:11 +0000)]
Add a missing break.
CID 488
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36402
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:08:34 +0000 (21:08 +0000)]
Add a missing break.
CID 490
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36401
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 21:05:29 +0000 (21:05 +0000)]
Added FALLTHRU comment to avoid a "missing break" warning.
CID 489
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36400
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 29 Mar 2011 20:58:57 +0000 (20:58 +0000)]
From Alexis La Goutte via bug 5790: Add partial bit flag in query.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36399
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 29 Mar 2011 20:05:33 +0000 (20:05 +0000)]
Grab URL from frame info value instead of from tvb. Fixes bug 5780.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36398
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 14:29:45 +0000 (14:29 +0000)]
Don't put a 196808 byte variable on the stack: instead, malloc/free it.
Coverity 789-790.
Since we've been keeping track of how many bytes we put in the buffer,
use that value instead of calling strlen() find it again.
Also, some white space/indentation cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36397
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2011 14:23:21 +0000 (14:23 +0000)]
Remove check_col().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36396
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 29 Mar 2011 14:23:13 +0000 (14:23 +0000)]
Don't assign proto_item pointers that are not used.
Coverity 1174
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36395
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 14:05:28 +0000 (14:05 +0000)]
Don't put a 65536 byte variable on the stack: instead, malloc/free it.
Coverity 791-794.
Also, some white space/indentation cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36394
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 29 Mar 2011 11:09:59 +0000 (11:09 +0000)]
Guard against NULL return from find_protocol_by_id().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36393
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 29 Mar 2011 11:08:15 +0000 (11:08 +0000)]
From Pascal Quantin:
Added guard against proto_name's not resolved as protocols.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36392
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Tue, 29 Mar 2011 10:56:30 +0000 (10:56 +0000)]
RTP: display payload type name from dynamic payload type table
H.223: use just one protocol for bot dissectors for more clear protocol disabling
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36391
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 29 Mar 2011 01:27:20 +0000 (01:27 +0000)]
Prohibit (memory-unsafe) g_sprintf() and g_vsprintf().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36390
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 22:22:05 +0000 (22:22 +0000)]
Cast to guint to avoid a Windows compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36389
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 22:12:53 +0000 (22:12 +0000)]
Move -D option into "pre-scan" group as there's no need to start gtk+ for it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36388
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 22:10:41 +0000 (22:10 +0000)]
Use fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36387
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Mon, 28 Mar 2011 20:53:20 +0000 (20:53 +0000)]
Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36386
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 19:44:41 +0000 (19:44 +0000)]
Use g_ascii_strdown instead of g_strdown
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36385
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 28 Mar 2011 17:23:06 +0000 (17:23 +0000)]
More updates to the wtap_open_offline() comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36384
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 17:04:58 +0000 (17:04 +0000)]
Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36383
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 16:42:25 +0000 (16:42 +0000)]
Don't use prohibited strncpy(). In this case, use g_strlcat() instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36382
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 15:28:03 +0000 (15:28 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :
Fix a Clang warning, add email address, and add some stuff to COL_INFO.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36381
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 15:23:27 +0000 (15:23 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :
Register the reload-framing dissector by name. Needed when RELOAD is not used
over udp/tcp (but tls, for example)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36380
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 28 Mar 2011 15:20:16 +0000 (15:20 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 5
Enchance MySQL :
* Add expert info of when undecoded data
* Fix some white space
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36379
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 28 Mar 2011 14:53:35 +0000 (14:53 +0000)]
Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
the value="..." attribute. Fixes bug 1520.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36378
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 28 Mar 2011 14:18:29 +0000 (14:18 +0000)]
Added payload, header and trailer information to the DLT tree entry.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36377
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 28 Mar 2011 13:09:47 +0000 (13:09 +0000)]
Update a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36376
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 27 Mar 2011 17:26:21 +0000 (17:26 +0000)]
If there are more than 4 billion characters in the printable form of a
network address, we have bigger problems. Cast the result of strlen()
to int to squelch a compiler warning with MSVC++.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36375
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 27 Mar 2011 16:15:19 +0000 (16:15 +0000)]
Fix Coverity 393: "DEADCODE"; Add an XXX comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36373
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 27 Mar 2011 16:06:03 +0000 (16:06 +0000)]
Add "-z hosts", which dumps name resolution information in hosts format.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36372
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 27 Mar 2011 15:58:52 +0000 (15:58 +0000)]
Add the IPv4 address, not the first 4 bytes of its name, to the
resolution table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36370
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 27 Mar 2011 15:39:06 +0000 (15:39 +0000)]
1. Fix bug in dissection of a field; Add two missing lines of code.
2. #if 0 if test "which will never be true"; Add XXX comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36369
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 27 Mar 2011 15:03:43 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-03-27]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36368
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 27 Mar 2011 14:34:19 +0000 (14:34 +0000)]
Removed uneeded 'continue'.
Fixes Coverity 815 ("UNREACHABLE").
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36367
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 14:11:40 +0000 (14:11 +0000)]
Added a FALLTHRU comment to avoid a "missing break" warning.
Coverity 472.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36366
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2011 14:02:42 +0000 (14:02 +0000)]
Added FALLTHRU comment to avoid a "missing break" warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36365
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:56:53 +0000 (13:56 +0000)]
Added a missing break.
Coverity 452.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36364
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:54:53 +0000 (13:54 +0000)]
Added a missing break.
Coverity 461.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36363
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:51:47 +0000 (13:51 +0000)]
Added some missing breaks.
Coverity 462 & 463.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36362
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:40:54 +0000 (13:40 +0000)]
Added some missing breaks.
Coverity 443 & 444.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36361
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:35:30 +0000 (13:35 +0000)]
Added some missing breaks.
Coverity 447.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36360
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:33:28 +0000 (13:33 +0000)]
Added a FALLTHRU comment to avoid a "missing break" warning.
Coverity 458.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36359
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:30:39 +0000 (13:30 +0000)]
Added some missing breaks.
Coverity 466.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36358
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:16:50 +0000 (13:16 +0000)]
Added a missing break.
Coverity 491.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36357
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 27 Mar 2011 13:15:14 +0000 (13:15 +0000)]
Added a missing break.
Coverity 492.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36356
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sat, 26 Mar 2011 16:39:30 +0000 (16:39 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 895-897
Also: Fix some indentation & whitespace.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36355
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sat, 26 Mar 2011 16:07:30 +0000 (16:07 +0000)]
From Alexis La Goutte:
A patch to add ATM over TCP Dissector.
The dissector dissect only the ATMTCP header (VCI, VPI, Payload Length)
The data are not yet dissect, it is necessary to add a "UAT" (As with the K12
dissector) to indicate the type (ILMI, AAL, ATM...) of data (based on VCI/VPI)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36354
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 26 Mar 2011 15:59:57 +0000 (15:59 +0000)]
Added a sanity check to remove a coverity warning.
Coverity 537.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36353
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 26 Mar 2011 15:53:55 +0000 (15:53 +0000)]
Added sanity checks for preferences.
Coverity 551 & 553.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36352
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 26 Mar 2011 15:39:35 +0000 (15:39 +0000)]
Added a sanity check in output_fields_set_option.
Coverity 552.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36351
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 26 Mar 2011 15:24:36 +0000 (15:24 +0000)]
Added a FALLTHRU comment to avoid a coverity warning.
Coverity 480.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36350
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 26 Mar 2011 15:20:37 +0000 (15:20 +0000)]
Added a missing break in graph_select_segment.
Coverity 482.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36349
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sat, 26 Mar 2011 15:16:40 +0000 (15:16 +0000)]
Added a missing break in hostlist_get_filter_name.
Coverity 481.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36348
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sat, 26 Mar 2011 11:23:46 +0000 (11:23 +0000)]
From Hadar Shoham:
Add support to correlation ID under DHCPv6 according to
"CL-SP-CANN-DHCP-Reg-I06-110210"
DHCPv6 option 17 Vendor-specific Information, sub option 2172 (paragraph 5.4.3)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36347
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 26 Mar 2011 05:39:45 +0000 (05:39 +0000)]
remove a proto_item variable we never use
coverity 866
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36346
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 26 Mar 2011 05:18:09 +0000 (05:18 +0000)]
remove a proto_item variable we dont need
coverity 1046
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36345
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 02:39:04 +0000 (02:39 +0000)]
Introduce ep_strconcat (copied from the glib version)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36344
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 02:11:42 +0000 (02:11 +0000)]
Remove some duplicated string manipulation code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36343
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 01:22:31 +0000 (01:22 +0000)]
Simplify the generation of the 'name' passed to tick_stat_node().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36342
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 26 Mar 2011 01:21:43 +0000 (01:21 +0000)]
The 'name's passed to tick_stat_node() do not need to be static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36341
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2011 23:45:48 +0000 (23:45 +0000)]
Fix Coverity CIDs 810 & 811: uninitialized variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36340
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 25 Mar 2011 22:35:29 +0000 (22:35 +0000)]
Fix Coverity 331, 332, 333: Wrap the three remaining
gtk_tree_selection_get_selected() calls with if(!..) return;
like the rest of them. These functions shouldn't be called
unless a packet was selected, so this call should always return
TRUE for success.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36339
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 22:20:27 +0000 (22:20 +0000)]
Reword the comments from rev 36304.
Replace the tabs in the file (mostly added by me) with spaces (for consistency).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36338
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 25 Mar 2011 22:16:23 +0000 (22:16 +0000)]
Fix coverity 268, 269, 546, 547, 548, 549 by checking for null return
from p_get_proto_data() since it should have been set already by the
calling function. Any other case would be a bug, so call
DISSECTOR_ASSERT in those cases. Hopefully Coverity realizes that this
is a null return value check.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36337
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 25 Mar 2011 22:13:33 +0000 (22:13 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 941
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36336
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 25 Mar 2011 21:52:56 +0000 (21:52 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 958-961.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36335
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 25 Mar 2011 21:09:28 +0000 (21:09 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 852,854;
Add a hidden item to the correct subtree: Coverity 853.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36334
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 20:04:54 +0000 (20:04 +0000)]
As suggested by Didier in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to some more dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36333
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 19:02:18 +0000 (19:02 +0000)]
From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)
A couple of the patches had to be manually applied.
From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36332
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 25 Mar 2011 18:51:12 +0000 (18:51 +0000)]
Change urb_type from FT_STRING to FT_UINT8. This fixes the display filtering
for this field. This change was prompted because of the following query:
http://ask.wireshark.org/questions/3113/usburb_type-values
Also, remove 2 unused fields found by running tools/checkhf.pl.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36331
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 25 Mar 2011 15:45:37 +0000 (15:45 +0000)]
Fix the problem reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3785#c14 :
If we thought we finished reassembly (and called the subdissector) only to find
out that the subdissector asked for more data, handle the case where the
subdissector asked for DESEGMENT_UNTIL_FIN. Previously we only handled the
possibility that the subdissector would ask for a specific number of bytes or
DESEGMENT_ONE_MORE_SEGMENT.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36330
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:26:17 +0000 (07:26 +0000)]
remove two unused assignments
coverity 1050
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36329
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:22:23 +0000 (07:22 +0000)]
use the newly created tree to store the new items instead of the parent tree
coverity 842
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36328
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:19:15 +0000 (07:19 +0000)]
remove unused variable
coverity 229
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36327
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 07:15:48 +0000 (07:15 +0000)]
remove an unused variable
coverity 1044
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36326
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 25 Mar 2011 06:42:59 +0000 (06:42 +0000)]
Make it build on Windows 7
(pcapng.c(1817) : warning C4267: '=' : conversion from 'size_t' to 'gint', possible loss of data)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36325
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2011 03:07:05 +0000 (03:07 +0000)]
remove assignment of an unused value
coverity 1178
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36324
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2011 00:28:47 +0000 (00:28 +0000)]
If a segment looks like a retransmission, don't mark it out-of-order.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36323
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 23:34:13 +0000 (23:34 +0000)]
Don't assign to a proto_item* if the value won't be used:
Also: Fix a bug wherein PPP_RTP_CUD8 was being registered
to "ppp.protocol" with the cudp16 handle rather than the cudp8 handle.
Coverity 1004-1013
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36322
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2011 23:33:38 +0000 (23:33 +0000)]
Add a missing include.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36321
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 23:05:36 +0000 (23:05 +0000)]
Fix a compile warning: unused variable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36320
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2011 22:58:45 +0000 (22:58 +0000)]
Add an item about pcapng name resolution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36319
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2011 22:47:57 +0000 (22:47 +0000)]
Add initial pcapng name resolution record support. Wireshark has read
support; TShark has read+write support. Additionally TShark can read a
"hosts" file and write those records to a capture file.
This uses "struct addrinfo" in many places and probably won't compile on
some platforms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36318
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 22:27:20 +0000 (22:27 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 942-951
Also: minor Code & Whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36317
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 24 Mar 2011 21:22:07 +0000 (21:22 +0000)]
Only display the 3 digits of precision after the decimal that we have
from the ICMP conversation response time tracking.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36316
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 21:19:39 +0000 (21:19 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;
Also:
- Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being
done on an already hidden item).
- Minor indentation cleanup;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36315
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 20:17:22 +0000 (20:17 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 1124-1128;
Also: minorwhitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36314
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Thu, 24 Mar 2011 18:05:10 +0000 (18:05 +0000)]
Display the value of the ICMP echo request/reply response time in milliseconds.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36313
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 17:37:07 +0000 (17:37 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36312
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Thu, 24 Mar 2011 16:21:31 +0000 (16:21 +0000)]
Export next_tvb_... functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36311
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 24 Mar 2011 16:03:12 +0000 (16:03 +0000)]
Don't assign to a proto_item* if the value isn't to be used: Coverity 1173;
Also:
- Fix 2 cases of an item attached to the wrong subtree;
- "localize" & rename some variable definitions;
- Minor indentation cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36310
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 24 Mar 2011 15:31:52 +0000 (15:31 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
Patch 3 :
Enhance MySQL : Request/Response sub-dissector/function
(white space changes, use ENC_NA when appropriate, use
proto_tree_add_item()...)
Patch 4 :
Enhance MySQL : packet_ok, server, capa sub-dissector/function (white space
changes, use ENC_NA when appropriate, use proto_tree_add_item()...)
Split mysql_dissect_caps in mysql_dissect_caps_client and
mysql_dissect_caps_server
Rename mysql_dissect_ext_caps to mysql_dissect_ext_caps_client
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36309
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2011 10:36:39 +0000 (10:36 +0000)]
Beutify IMEISV IE output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36308
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2011 10:35:29 +0000 (10:35 +0000)]
Fix Checkapi errors
Error: the name for field " N32" ("gsm_rlcmac_dl.n32") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N51" ("gsm_rlcmac_dl.n51") has leading space in packet-gsm_rlcmac.c
Error: the name for field " N26" ("gsm_rlcmac_dl.n26") has leading space in packet-gsm_rlcmac.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36307
f5534014-38df-0310-8fa8-
9805f1628bb7
git.samba.org / obnox / wireshark / wip.git / log