obnox/wireshark/wip.git
16 years agoFrom Bill Florac::
jake [Fri, 25 Jan 2008 06:23:28 +0000 (06:23 +0000)]
From Bill Florac::
Corrected display of attributes from previous patch (24165)
For V2, if field length was 0, do not display the empty field. This makes it
easier to read. I only did V2 as I do not have means to test V1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24189 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed some strcpy -> strncpy/g_snprintf cleanups.
stig [Thu, 24 Jan 2008 23:01:37 +0000 (23:01 +0000)]
Fixed some strcpy -> strncpy/g_snprintf cleanups.
Removed a debug printout in t38.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24188 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded some parantheses to avoid a warning.
stig [Thu, 24 Jan 2008 22:51:17 +0000 (22:51 +0000)]
Added some parantheses to avoid a warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24187 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemoved even more C++ style comments.
stig [Thu, 24 Jan 2008 22:33:49 +0000 (22:33 +0000)]
Removed even more C++ style comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24186 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix various small memory leaks & 1 invalid g_free (airpcap_gui_utils.c)
wmeier [Thu, 24 Jan 2008 22:26:05 +0000 (22:26 +0000)]
Fix various small memory leaks & 1 invalid g_free (airpcap_gui_utils.c)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24185 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDecode som MBMS elements.
etxrab [Thu, 24 Jan 2008 22:21:13 +0000 (22:21 +0000)]
Decode som MBMS elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24184 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChange "Found no match" to "No match found"
wmeier [Thu, 24 Jan 2008 22:12:10 +0000 (22:12 +0000)]
Change "Found no match" to "No match found"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24183 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWarn if we find %ll in the source
morriss [Thu, 24 Jan 2008 22:02:55 +0000 (22:02 +0000)]
Warn if we find %ll in the source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24182 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agos/%ll/%" G_GINT64_MODIFIER "/g
morriss [Thu, 24 Jan 2008 21:57:13 +0000 (21:57 +0000)]
s/%ll/%" G_GINT64_MODIFIER "/g

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24181 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.
stig [Thu, 24 Jan 2008 19:30:43 +0000 (19:30 +0000)]
Fixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24180 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed some malloc -> g_malloc, free -> g_free, strdup -> g_strdup.
stig [Thu, 24 Jan 2008 19:09:30 +0000 (19:09 +0000)]
Fixed some malloc -> g_malloc, free -> g_free, strdup -> g_strdup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24179 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemoved C++ style comment.
stig [Thu, 24 Jan 2008 18:51:54 +0000 (18:51 +0000)]
Removed C++ style comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24178 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd check for non-ASCII characters (defined, for now, as any whose value is > 0x80...
morriss [Thu, 24 Jan 2008 18:18:28 +0000 (18:18 +0000)]
Add check for non-ASCII characters (defined, for now, as any whose value is > 0x80) anywhere in the source files (as per discussion on -dev).  Amazingly, this does not appear to slow the tool down too much.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24177 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReplace a handful of tabs with spaces.
martinm [Thu, 24 Jan 2008 17:14:01 +0000 (17:14 +0000)]
Replace a handful of tabs with spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24176 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAlways return a valid profile name from get_profile_name().
stig [Thu, 24 Jan 2008 17:06:22 +0000 (17:06 +0000)]
Always return a valid profile name from get_profile_name().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24175 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOne of fixes in SVN #24173 incomplete; Undo it for now
wmeier [Thu, 24 Jan 2008 05:39:48 +0000 (05:39 +0000)]
One of fixes in SVN #24173 incomplete; Undo it for now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24174 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix two very minor memory leaks
wmeier [Thu, 24 Jan 2008 04:20:07 +0000 (04:20 +0000)]
Fix two very minor memory leaks

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24173 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoArrange things so that if '-o "capture.auto_scroll: FALSE"' is passed to
gerald [Thu, 24 Jan 2008 01:23:19 +0000 (01:23 +0000)]
Arrange things so that if '-o "capture.auto_scroll: FALSE"' is passed to
Wireshark on the command line, auto-scroll is actually disabled.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24172 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of non-ASCII characters.
guy [Wed, 23 Jan 2008 20:15:13 +0000 (20:15 +0000)]
Get rid of non-ASCII characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24171 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of non-ASCII characters.
guy [Wed, 23 Jan 2008 20:12:23 +0000 (20:12 +0000)]
Get rid of non-ASCII characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24170 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of non-ASCII characters.
guy [Wed, 23 Jan 2008 19:47:40 +0000 (19:47 +0000)]
Get rid of non-ASCII characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24169 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a minor memory leak; Remove some unused variables
wmeier [Wed, 23 Jan 2008 14:07:40 +0000 (14:07 +0000)]
Fix a minor memory leak; Remove some unused variables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24168 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix minor memory leak
wmeier [Wed, 23 Jan 2008 14:05:22 +0000 (14:05 +0000)]
Fix minor memory leak

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24167 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUnpack FindProcDLL.dll into $(WIRESHARK_LIBS\nsis-plugins, and tell NSIS
gerald [Wed, 23 Jan 2008 01:23:06 +0000 (01:23 +0000)]
Unpack FindProcDLL.dll into $(WIRESHARK_LIBS\nsis-plugins, and tell NSIS
where it is using "!addplugindir".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24166 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Bill Florac:
jake [Tue, 22 Jan 2008 18:20:00 +0000 (18:20 +0000)]
From Bill Florac:
Patch in revision 24163 is missing same fix needed for "case SRVREG", at line 1156.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24165 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't update COL_INFO at all if not claiming the packet as CMPP. Add a (guessed)...
morriss [Tue, 22 Jan 2008 18:05:45 +0000 (18:05 +0000)]
Don't update COL_INFO at all if not claiming the packet as CMPP. Add a (guessed) upper-size limit on the heuristics and take out a check that the tvb length matches the protocol length--that would essentially disable TCP reassembly of this protocol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24164 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Bill Florac:
jake [Tue, 22 Jan 2008 07:36:33 +0000 (07:36 +0000)]
From Bill Florac:
The displaying of attribute-lists in an "Attribute Reply" (ATTRRPLY) seems to
be written to display some special non-conforming attributes.  Conforming
attributes are either displayed wrong or not displayed at all.

When displaying an attributes-list in a "Service Registration" (SRVREG), the
attribute list is only displayed as a single string (and usually truncated).
While this is not wrong, it should be broken up into the comma separated
attributes as "Attribute Requests" tries to do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24163 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Bill Florac:
jake [Tue, 22 Jan 2008 06:49:49 +0000 (06:49 +0000)]
From Bill Florac:
When dissecting any message containing a "transport layer address", if the
address was NULL (which is valid), the offset pointer was not incremented by 1
and the remaining fields would not be dissected correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24162 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoClean up indentation.
guy [Tue, 22 Jan 2008 04:59:59 +0000 (04:59 +0000)]
Clean up indentation.

Move some comments to make it a bit clearer what each branch of the if
handles.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24161 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd another vendor id
jmayer [Tue, 22 Jan 2008 02:05:21 +0000 (02:05 +0000)]
Add another vendor id

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24160 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse WTAP_MAX_PACKET_SIZE in place of 65535 in sanity check for snap len
sfisher [Tue, 22 Jan 2008 01:05:32 +0000 (01:05 +0000)]
Use WTAP_MAX_PACKET_SIZE in place of 65535 in sanity check for snap len
(although they are the same value right now)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24159 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen using -T fields, print a "1" instead of nothing when a field of type FT_NONE is
sake [Tue, 22 Jan 2008 00:56:55 +0000 (00:56 +0000)]
When using -T fields, print a "1" instead of nothing when a field of type FT_NONE is
present. This way, scripts can check for the presence of this type of fields.

(fixes bug 2210)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24158 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd description of the new option for configuration profile (-C).
stig [Mon, 21 Jan 2008 22:46:43 +0000 (22:46 +0000)]
Add description of the new option for configuration profile (-C).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24157 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded entry for configuration profiles, and updated the statusbar
stig [Mon, 21 Jan 2008 22:27:02 +0000 (22:27 +0000)]
Added entry for configuration profiles, and updated the statusbar
description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24156 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate Preferences dialog description.
jake [Mon, 21 Jan 2008 22:08:50 +0000 (22:08 +0000)]
Update Preferences dialog description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24155 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Douglas Pratley (bug 1445):
stig [Mon, 21 Jan 2008 21:44:34 +0000 (21:44 +0000)]
From Douglas Pratley (bug 1445):
Add a "subnets" file defining a named list of subnets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24154 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a preferense to decode a dynamic payload type as H263-1998/H263-2000
etxrab [Mon, 21 Jan 2008 20:49:15 +0000 (20:49 +0000)]
Add a preferense to decode a dynamic payload type as H263-1998/H263-2000

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24153 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix for bug 1920:
jake [Mon, 21 Jan 2008 07:35:16 +0000 (07:35 +0000)]
Fix for bug 1920:
Avoid double free, causing crash, and stop memory leak via normal code path.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24152 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove duplicated OID entries and add text "(single NAL unit mode)"
etxrab [Mon, 21 Jan 2008 06:46:58 +0000 (06:46 +0000)]
Remove duplicated OID entries and add text "(single NAL unit mode)"
to 0.0.8.241.0.0.0.0.
This time with the updated packet-h245.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24151 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove duplicated OID entries and add text "(single NAL unit mode)"
etxrab [Mon, 21 Jan 2008 06:28:23 +0000 (06:28 +0000)]
Remove duplicated OID entries and add text "(single NAL unit mode)"
to 0.0.8.241.0.0.0.0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24150 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoas we have BSWAP64() now, at least read 64bit section_length (but currently unused)
ulfl [Mon, 21 Jan 2008 01:54:28 +0000 (01:54 +0000)]
as we have BSWAP64() now, at least read 64bit section_length (but currently unused)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24149 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix typo in help text
wmeier [Sun, 20 Jan 2008 23:12:12 +0000 (23:12 +0000)]
Fix typo in help text

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24148 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpate another VC++ 2005 EE link.
gerald [Sun, 20 Jan 2008 18:53:38 +0000 (18:53 +0000)]
Upate another VC++ 2005 EE link.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24147 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed a </para> placement.
stig [Sun, 20 Jan 2008 17:07:59 +0000 (17:07 +0000)]
Fixed a </para> placement.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24146 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed crash when save IO Graphs (bug 2126).
stig [Sun, 20 Jan 2008 16:53:53 +0000 (16:53 +0000)]
Fixed crash when save IO Graphs (bug 2126).

The problem was that configure_event() is called each time the window size
changes, and each time the pixmap buffer is recreated and a new signal added
to the save button.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24145 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDocument the copy button in conversations, endpoints and iographs.
stig [Sun, 20 Jan 2008 13:52:48 +0000 (13:52 +0000)]
Document the copy button in conversations, endpoints and iographs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24144 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded "copy as CSV" button to IO Graphs.
stig [Sun, 20 Jan 2008 12:24:14 +0000 (12:24 +0000)]
Added "copy as CSV" button to IO Graphs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24143 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIntroduce BSWAP64() and use it in the pcapng code
sfisher [Sun, 20 Jan 2008 02:31:34 +0000 (02:31 +0000)]
Introduce BSWAP64() and use it in the pcapng code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24142 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake it compile on Win32 ;-)
ulfl [Sat, 19 Jan 2008 12:34:43 +0000 (12:34 +0000)]
Make it compile on Win32 ;-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24141 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake it compile on OSX.
stig [Sat, 19 Jan 2008 12:22:44 +0000 (12:22 +0000)]
Make it compile on OSX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24140 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agovarious enhancements:
ulfl [Sat, 19 Jan 2008 12:09:00 +0000 (12:09 +0000)]
various enhancements:
- read simple packet block
- read various options
- jump over unknown block types
- more sanity checks

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24139 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Olivier Montanuy (bug 2198):
stig [Sat, 19 Jan 2008 10:46:13 +0000 (10:46 +0000)]
From Olivier Montanuy (bug 2198):
Fix the bug related to Option template:
- System scope (check that options scope size is == 4, not <= 4)
- Interface scope (same)
Same fix for fields BytesExported PacketsExported FlowsExported.
Also fix some tabulations in a previous patch related to IPv6 Addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24138 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCleanup the whitespace.
jake [Sat, 19 Jan 2008 07:46:52 +0000 (07:46 +0000)]
Cleanup the whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24137 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFree allocated data in prefs_reset, removed need for uat_reload_all and
stig [Sat, 19 Jan 2008 01:18:35 +0000 (01:18 +0000)]
Free allocated data in prefs_reset, removed need for uat_reload_all and
made some cleanups in profile_dlg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24136 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoI can't find any reason to unselect the current package only when an entry
stig [Fri, 18 Jan 2008 22:51:37 +0000 (22:51 +0000)]
I can't find any reason to unselect the current package only when an entry
in the packet details view is selected.  I suppose unselecting the field is
more correct.  The previous behaviour lead to some strange errors:

 Select a packet and an entry in the packet details.  Add a new column
 and change a protocol preference.  Observe the selected package is
 unselected and packet 1 is selected, which I think is wrong.

 Do the same as above with one of the following exceptions:
  - without selecting an entry in the packet details.
  - without adding a new column.
  - without changing a protocol preference.
 Observe the selected package is still selected, which is correct.

The correct behaviour here happens because of the cf_goto_frame call in
redraw_hex_dump_all, which causes the field to be unselected before
packet_list_set_sel_browse is called, and then the cf_unselect_package
is never called.

Maybe someone with a deeper knowledge should have a look at this...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24135 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded smi_modules_uat and smi_paths_uat to libwireshark.def.
stig [Fri, 18 Jan 2008 16:13:48 +0000 (16:13 +0000)]
Added smi_modules_uat and smi_paths_uat to libwireshark.def.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24134 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodecode IDB options (if_tsaccur and if_fcslen)
ulfl [Fri, 18 Jan 2008 10:29:23 +0000 (10:29 +0000)]
decode IDB options (if_tsaccur and if_fcslen)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24133 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDocument required changes to top level Makefile.nmake.
jake [Fri, 18 Jan 2008 07:35:01 +0000 (07:35 +0000)]
Document required changes to top level Makefile.nmake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24132 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMove libsmi settings from virtual mibs protocol page to name resolution page.
jake [Fri, 18 Jan 2008 07:18:32 +0000 (07:18 +0000)]
Move libsmi settings from virtual mibs protocol page to name resolution page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24131 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCorrect a typo.
etxrab [Fri, 18 Jan 2008 05:55:58 +0000 (05:55 +0000)]
Correct a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24130 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoLet epan/asn1.c handle real type.
etxrab [Fri, 18 Jan 2008 05:55:24 +0000 (05:55 +0000)]
Let epan/asn1.c handle real type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24129 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd link to pcap-ng format specification and use #defines for hex values of
sfisher [Fri, 18 Jan 2008 00:59:30 +0000 (00:59 +0000)]
Add link to pcap-ng format specification and use #defines for hex values of
block types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24128 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhitespace cleanup of AIRPCAP code.
jake [Thu, 17 Jan 2008 22:28:31 +0000 (22:28 +0000)]
Whitespace cleanup of AIRPCAP code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24127 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoStrengthen heuristics a little bit, remove a useless variable, put COL_INFO check...
morriss [Thu, 17 Jan 2008 22:05:06 +0000 (22:05 +0000)]
Strengthen heuristics a little bit, remove a useless variable, put COL_INFO check in the right place

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24126 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2206 : don't write into COL_IN...
morriss [Thu, 17 Jan 2008 21:40:33 +0000 (21:40 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=2206 : don't write into COL_INFO unless we've checked that it's there first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24125 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom RD Thrush: Fix for 'editcap relies on gnu extension to strptime(3)'
wmeier [Thu, 17 Jan 2008 21:04:48 +0000 (21:04 +0000)]
From RD Thrush: Fix for 'editcap relies on gnu extension to strptime(3)'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24124 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNow that we have wiretap plugins, capinfos and editcap need to be linked against...
morriss [Thu, 17 Jan 2008 19:44:04 +0000 (19:44 +0000)]
Now that we have wiretap plugins, capinfos and editcap need to be linked against libwireshark (because the non-wiretap plugins use it but also init_progfile_dir() is in epan and they use that to load the plugins)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24123 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd some parentheses as suggested by the OS X buildbot
ulfl [Thu, 17 Jan 2008 19:30:35 +0000 (19:30 +0000)]
add some parentheses as suggested by the OS X buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24122 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoepan (libwireshark) uses getservbyport() which, at least on Solaris, is in libsocket...
morriss [Thu, 17 Jan 2008 18:42:19 +0000 (18:42 +0000)]
epan (libwireshark) uses getservbyport() which, at least on Solaris, is in libsocket so add libsocket (and libnsl) to libwireshark_la_LIBADD

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24121 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobetter conformance to the released DCP protocol spec:
ulfl [Thu, 17 Jan 2008 18:29:51 +0000 (18:29 +0000)]
better conformance to the released DCP protocol spec:
- redesign/refactoring the code to support BlockQualifier
- fix handling of BlockInfo
- rename some display strings for better spec conformance
- remove LLDP suboption

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24120 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support for DLT_SCCP (SCCP without MTP2, MTP3, or any pseudo-header).
morriss [Thu, 17 Jan 2008 17:55:38 +0000 (17:55 +0000)]
Add support for DLT_SCCP (SCCP without MTP2, MTP3, or any pseudo-header).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24119 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHmmm. The previous ansi_tcap.cnf did not make valid code.
stig [Thu, 17 Jan 2008 09:20:17 +0000 (09:20 +0000)]
Hmmm.  The previous ansi_tcap.cnf did not make valid code.
I hope this fix is correct...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24118 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanged some variable types to make it compile.
stig [Wed, 16 Jan 2008 20:49:50 +0000 (20:49 +0000)]
Changed some variable types to make it compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24117 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- Removed some unused variables in asn1 dissectors
stig [Wed, 16 Jan 2008 20:41:23 +0000 (20:41 +0000)]
- Removed some unused variables in asn1 dissectors
- Fixed last parameter to cry_cipher_open() in pkcs12

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24116 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanged to checksum_good and checksum_bad to align with other dissectors.
stig [Wed, 16 Jan 2008 19:16:30 +0000 (19:16 +0000)]
Changed to checksum_good and checksum_bad to align with other dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24115 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrint the string to STDOUT regardless of the value of tree.
jake [Wed, 16 Jan 2008 18:39:32 +0000 (18:39 +0000)]
Print the string to STDOUT regardless of the value of tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24114 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- Display some sctpprim parameters
martinm [Wed, 16 Jan 2008 14:19:45 +0000 (14:19 +0000)]
- Display some sctpprim parameters
- Parse sctpprim v3 properly now
- Add wtp protocol name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24113 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jim Young:
jake [Wed, 16 Jan 2008 07:36:34 +0000 (07:36 +0000)]
From Jim Young:
This patch provides a new RTP Player preferences dialog.  It allows one to
select the maximum number of visable channels in the RTP Player window.  The
default is four (4) channels which is the maximum number of usable channels
that the RTP Player can display and still have access to the bottom row buttons
on a 1024*768 resolution display.  Specifying a value less than 1 or greater than
10 will be result in the RTP Player displaying the default 4 channels.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24112 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodumpcap link: remove duplicate epan/unicode-utils.obj
wmeier [Wed, 16 Jan 2008 04:40:18 +0000 (04:40 +0000)]
dumpcap link: remove duplicate epan/unicode-utils.obj

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24111 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd ':' to some labels to prevent assembler warning messages
wmeier [Wed, 16 Jan 2008 04:04:24 +0000 (04:04 +0000)]
Add ':' to some labels to prevent assembler warning messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24110 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCall post dissectors with call_dissector_only() to avoid an extra Data entry
stig [Tue, 15 Jan 2008 23:31:37 +0000 (23:31 +0000)]
Call post dissectors with call_dissector_only() to avoid an extra Data entry
if post dissectors are disabled, as pointed out by LEGO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24109 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMoved a G_GINT64_CONSTANT to a more correct position.
stig [Tue, 15 Jan 2008 23:25:40 +0000 (23:25 +0000)]
Moved a G_GINT64_CONSTANT to a more correct position.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24108 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed a small issue reporting corresponding package num for retransmitted
stig [Tue, 15 Jan 2008 22:32:34 +0000 (22:32 +0000)]
Fixed a small issue reporting corresponding package num for retransmitted
reports and notifications.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24107 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse G_GINT64_CONSTANT(hope it makes the OS X build bot happy).
etxrab [Tue, 15 Jan 2008 22:23:57 +0000 (22:23 +0000)]
Use G_GINT64_CONSTANT(hope it makes the OS X build bot happy).
Unused variables fix to camel.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24106 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse G_GINT64_CONSTANT(hope it makes the build bot happy).
etxrab [Tue, 15 Jan 2008 22:07:29 +0000 (22:07 +0000)]
Use G_GINT64_CONSTANT(hope it makes the build bot happy).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24105 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse G_GINT64_MODIFIER hope it makes the build bot happy.
etxrab [Tue, 15 Jan 2008 21:57:50 +0000 (21:57 +0000)]
Use G_GINT64_MODIFIER hope it makes the build bot happy.
Probbably needed in x2ap as well (needs asn2wrs support or .cnf magic).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24104 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate the VC2005EE URL.
gerald [Tue, 15 Jan 2008 21:48:16 +0000 (21:48 +0000)]
Update the VC2005EE URL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24103 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDiscard existing list of disabled protocols in read_disabled_protos_list()
stig [Tue, 15 Jan 2008 21:41:52 +0000 (21:41 +0000)]
Discard existing list of disabled protocols in read_disabled_protos_list()
even if disabled_protos file does not exist.  This fixes a problem with
disabled protocols when changing profile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24102 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse New GTK packages:
etxrab [Tue, 15 Jan 2008 20:18:04 +0000 (20:18 +0000)]
Use New GTK packages:
Overview of Changes from GLib 2.14.4 to GLib 2.14.5
===================================================

* Bugs fixed:
 482313 gregex: no way to tell why compilation failed
 315437 extern inline -> static inline
 480122 g_module_open fails to open modules with ".la" extension
 495589 gspawn.c failing to set FD_CLOEXEC
 500638 gkeyfile speedup ...
 503029 g_time_val_from_iso8601 parse non-ISO8601 dates
 503420 gkeyfile leaks a hash table

Overview of Changes from GTK+ 2.12.3 to 2.12.4
==============================================

 * Bugs fixed:
 494667 gdkpixloader jpeg loader problems with some files
 496546 Tooltips may crashe because a window is destroyed
 503824 gtk_paned_find_neighbours aborts with assertion failure
 388321 gtk_notebook_remove_tab_label
 503190 Doesn't build with directfb >= 1.0
 491847 gtk-builder-convert --root option doesn't work for GtkWin...
 492977 Setup autorelease pool automatically in each mainloop ite...
 499951 GtkAssistant remove_page may leave current_page as a dang...
 502250 Leak in gtkfilechooserdefault.c:shortcuts_reload_icons()
 503569 Leak in GtkTreeViewColumn
 504753 Destroyed subviews are not removed from the view hierarchy
 504804 Typo in TEST_EXPAND_ROW signal
 504984 Problems with hiding/showing transient windows
 505708 compatibility macros for signals has wrong type.
 506107 mem leak in print dialogue
 502850 gtk-builder-convert program not found
 504749 gtk-builder-convert and GtkMenu

GTK+ 2.12.5
This release fixes an incomplete icon cache that was
accidentally shipped in 2.12.4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24101 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude dirent.h if we have it (to fix glib-1 compile: it needed DIR).
morriss [Tue, 15 Jan 2008 19:39:31 +0000 (19:39 +0000)]
Include dirent.h if we have it (to fix glib-1 compile: it needed DIR).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24100 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOops, glib's iconv stuff is in glib >= 2, not just glib > 2
morriss [Tue, 15 Jan 2008 19:24:27 +0000 (19:24 +0000)]
Oops, glib's iconv stuff is in glib >= 2, not just glib > 2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24099 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe glib iconv routines are new to glib-2 so #ifdef around them to get glib-1 builds...
morriss [Tue, 15 Jan 2008 18:37:48 +0000 (18:37 +0000)]
The glib iconv routines are new to glib-2 so #ifdef around them to get glib-1 builds going again.  I started to merge in using the regular iconv routines (if we don't have glib-2 but we HAVE_CONV) but the code rapidly got ugly with all the #ifdef's; it could be done but it's probably not worth the effort/ugliness.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24098 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomake per_constrained_integer handle 64bits needed for X2AP.
etxrab [Tue, 15 Jan 2008 17:59:43 +0000 (17:59 +0000)]
make per_constrained_integer handle 64bits needed for X2AP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24097 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBump date
stig [Tue, 15 Jan 2008 14:34:03 +0000 (14:34 +0000)]
Bump date

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24096 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Neil Piercy:
etxrab [Tue, 15 Jan 2008 06:54:30 +0000 (06:54 +0000)]
From Neil Piercy:
Dissect RRC NAS Message PDUs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24095 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanged to use GTK stock icon for preferences in the toolbar.
stig [Tue, 15 Jan 2008 00:24:59 +0000 (00:24 +0000)]
Changed to use GTK stock icon for preferences in the toolbar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24094 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed a typo in the docbook.
stig [Mon, 14 Jan 2008 23:22:36 +0000 (23:22 +0000)]
Fixed a typo in the docbook.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24093 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSave the changes also when selecting a profile from the list.
stig [Mon, 14 Jan 2008 21:58:45 +0000 (21:58 +0000)]
Save the changes also when selecting a profile from the list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24092 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSeveral profile enhancements:
stig [Mon, 14 Jan 2008 21:43:10 +0000 (21:43 +0000)]
Several profile enhancements:
- Give initial focus to the profiles list
- Enter in the profiles list selects the profile
- Give focus to the profile name when creating a new profile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24091 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded cast of argument to isspace.
stig [Mon, 14 Jan 2008 19:19:47 +0000 (19:19 +0000)]
Added cast of argument to isspace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24090 f5534014-38df-0310-8fa8-9805f1628bb7