obnox/wireshark/wip.git
16 years agomake-faq: Format of the online file changed slightly.
jmayer [Tue, 20 Nov 2007 17:44:39 +0000 (17:44 +0000)]
make-faq: Format of the online file changed slightly.

Update FAQ and help/faq.txt to current version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23515 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix minor typo
sfisher [Tue, 20 Nov 2007 17:35:11 +0000 (17:35 +0000)]
Fix minor typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23514 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate before release process starts.
jmayer [Tue, 20 Nov 2007 17:16:24 +0000 (17:16 +0000)]
Update before release process starts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23513 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate from samba tree revision 25880 to 26066
jmayer [Tue, 20 Nov 2007 17:08:52 +0000 (17:08 +0000)]
Update from samba tree revision 25880 to 26066
============================ Samba log start ============
------------------------------------------------------------------------
r25915 | metze | 2007-11-09 20:23:25 +0100 (Fri, 09 Nov 2007) | 9 lines

ndr/pidl: change NTSTAUS into enum ndr_err_code (pidl code)

Samba4/NDR/Parser.pm
Samba4/NDR/Server.pm
Samba3/ServerNDR.pm
tests/

metze

------------------------------------------------------------------------
r26049 | metze | 2007-11-20 12:07:50 +0100 (Tue, 20 Nov 2007) | 4 lines

pidl: don't use ndr_pull_save anymore

metze

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23512 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIf libcap is present, have dumpcap use it to drop privileges while
gerald [Tue, 20 Nov 2007 16:53:01 +0000 (16:53 +0000)]
If libcap is present, have dumpcap use it to drop privileges while
retaining CAP_NET_ADMIN and CAP_NET_RAW.  Update some Makefile
dependencies for dumpcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23511 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReindent some to improve readability
morriss [Tue, 20 Nov 2007 16:51:14 +0000 (16:51 +0000)]
Reindent some to improve readability

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23510 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate some comments and whitespace.
gerald [Tue, 20 Nov 2007 16:46:11 +0000 (16:46 +0000)]
Update some comments and whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23509 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix tag handling inside snmp trap
kukosa [Tue, 20 Nov 2007 13:55:39 +0000 (13:55 +0000)]
fix tag handling inside snmp trap

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23508 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofrom Jörg Mayer: "a proposed change to the COPYING file"
ulfl [Tue, 20 Nov 2007 08:33:09 +0000 (08:33 +0000)]
from Jörg Mayer: "a proposed change to the COPYING file"

from ULFL: some minor changes to wording and alike

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23507 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRest of fix for SVN revision 23487. This change also changes the callback
sfisher [Tue, 20 Nov 2007 00:34:16 +0000 (00:34 +0000)]
Rest of fix for SVN revision 23487.  This change also changes the callback
function for the Save/Save As button as necessary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23506 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIntroduce use of the new FT_EBCDIC field type as a second display of
sfisher [Mon, 19 Nov 2007 21:28:17 +0000 (21:28 +0000)]
Introduce use of the new FT_EBCDIC field type as a second display of
text fields (data & sqlstatement).  Also fix the options on the FT_STRINGZ
items - change them to FT_STRING and change BASE_DEC to BASE_NONE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23505 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv kaul:
bondolo [Mon, 19 Nov 2007 21:28:08 +0000 (21:28 +0000)]
From Yaniv kaul:

Adds const declarations to req_resp_hdrs_do_reassembly() and re-orders some actions to occur after tests which may decide that the actions were not required.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23504 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIntroduce a new field type called FT_EBCDIC. This field works the same as
sfisher [Mon, 19 Nov 2007 21:27:01 +0000 (21:27 +0000)]
Introduce a new field type called FT_EBCDIC.  This field works the same as
FT_STRING, except that it converts the data from the packet from EBCDIC
to ASCII for display in Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23503 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDetect reneged acks or at least retransmissions after an ack was seen. Mark
morriss [Mon, 19 Nov 2007 20:34:57 +0000 (20:34 +0000)]
Detect reneged acks or at least retransmissions after an ack was seen.  Mark
them with an expert info (PI_WARN).

Change "Duplicate TSN" expert info to "Retransmitted TSN" and make it PI_NOTE
instead of PI_WARN.

Change "More than 100 TSNs gap-acked" expert info to PI_WARN (from PI_NOTE).

Frame numbers (and count of retransmissions) are unsigned, display them that way.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23502 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImproved "BER Error" messages to be more uniform.
stig [Mon, 19 Nov 2007 20:23:49 +0000 (20:23 +0000)]
Improved "BER Error" messages to be more uniform.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23501 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet the number of captured bytes from "rlen" instead of "wlen". This should
gerald [Mon, 19 Nov 2007 19:09:01 +0000 (19:09 +0000)]
Get the number of captured bytes from "rlen" instead of "wlen".  This should
fix bug #1983.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23500 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- Prettify "Value" node that contains EAP tree with top-level details
martinm [Mon, 19 Nov 2007 19:07:49 +0000 (19:07 +0000)]
- Prettify "Value" node that contains EAP tree with top-level details
- Lose unuseful header file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23499 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOnly show direction field when its set to a valid value.
martinm [Mon, 19 Nov 2007 19:04:19 +0000 (19:04 +0000)]
Only show direction field when its set to a valid value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23498 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSecond try to not stop processing if length==0 in choice.
stig [Mon, 19 Nov 2007 17:46:11 +0000 (17:46 +0000)]
Second try to not stop processing if length==0 in choice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23497 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix an infinite loop, and be more paranoid about looping in general.
gerald [Mon, 19 Nov 2007 17:33:59 +0000 (17:33 +0000)]
Fix an infinite loop, and be more paranoid about looping in general.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23496 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd missing \
martinm [Mon, 19 Nov 2007 17:23:30 +0000 (17:23 +0000)]
Add missing \

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23495 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTry to fix reported uninstallation problems
martinm [Mon, 19 Nov 2007 16:29:41 +0000 (16:29 +0000)]
Try to fix reported uninstallation problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23494 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded p7 to build environment.
stig [Mon, 19 Nov 2007 13:40:27 +0000 (13:40 +0000)]
Added p7 to build environment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23493 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded port range.
stig [Mon, 19 Nov 2007 07:31:56 +0000 (07:31 +0000)]
Added port range.
Added a dissector assert on inconsistent data.
Do not align retransmission or duplicate acknowledgement data in COL_INFO.
Removed several _U_ for used variables.
Re-indented some if-blocks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23492 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded port range.
stig [Mon, 19 Nov 2007 07:26:53 +0000 (07:26 +0000)]
Added port range.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23491 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInitialize credentials.
stig [Mon, 19 Nov 2007 07:26:10 +0000 (07:26 +0000)]
Initialize credentials.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23490 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReverted r23485 and r23486, this was not a correct fix.
stig [Mon, 19 Nov 2007 07:25:06 +0000 (07:25 +0000)]
Reverted r23485 and r23486, this was not a correct fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23489 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix my last commit (23487) to work with GTK 2.4 - 2.11+. I had accidently
sfisher [Mon, 19 Nov 2007 04:37:45 +0000 (04:37 +0000)]
Fix my last commit (23487) to work with GTK 2.4 - 2.11+.  I had accidently
used a GTK 2.12+ function in the last commit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23488 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a problem introduced with the GTK 2.4+ Toolbar API whereby the save/
sfisher [Mon, 19 Nov 2007 04:24:00 +0000 (04:24 +0000)]
Fix a problem introduced with the GTK 2.4+ Toolbar API whereby the save/
save as button would disappear (leaving a blank spot on the toolbar) after
starting & stopping a capture session more than once.

This fix gets rid of the second save_as_button when using GTK 2.4+ in favor
of converting the stock id / tooltip text of the save_button to that of
the save as button when necessary and reverting it back to just save when
necessary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23487 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAnd dump internal ber fields for empty choice field.
stig [Sun, 18 Nov 2007 16:40:20 +0000 (16:40 +0000)]
And dump internal ber fields for empty choice field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23486 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAs proposed by Martin Peylo:
stig [Sun, 18 Nov 2007 16:20:51 +0000 (16:20 +0000)]
As proposed by Martin Peylo:
Do not stop processing if the length of a choice has the (illegal)
value of zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23485 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to optionally use the "Ultimate Packer for eXecutables" (UPX) to pack the...
gal [Sun, 18 Nov 2007 10:20:26 +0000 (10:20 +0000)]
Update to optionally use the "Ultimate Packer for eXecutables" (UPX) to pack the exes and dlls prior to U3 and PortableApps packaging.

For the U3 package, this results in a 40% smaller package.
For the PortableApps version, the package size is not much different, but the install time is quicker.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23484 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix bug 1459: make the filter string "ip.version == 6" possible, by adding a "pseudo...
ulfl [Sun, 18 Nov 2007 08:16:49 +0000 (08:16 +0000)]
fix bug 1459: make the filter string "ip.version == 6" possible, by adding a "pseudo" field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23483 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug #1164 again - this time for GTK1.
sfisher [Sun, 18 Nov 2007 04:20:14 +0000 (04:20 +0000)]
Fix bug #1164 again - this time for GTK1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23482 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd ppp.direction field.
martinm [Sat, 17 Nov 2007 22:08:27 +0000 (22:08 +0000)]
Add ppp.direction field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23481 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoComment out dissect_ascii_tpkt to keep the buildbot happy.
gal [Sat, 17 Nov 2007 18:22:49 +0000 (18:22 +0000)]
Comment out dissect_ascii_tpkt to keep the buildbot happy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23480 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBasic P7 (X.400 Message Store Access Protocol) dissection after request from the...
gal [Sat, 17 Nov 2007 18:08:01 +0000 (18:08 +0000)]
Basic P7 (X.400 Message Store Access Protocol) dissection after request from the list:
http://www.wireshark.org/lists/wireshark-dev/200711/msg00228.html

Only a single (private) capture file is currently available which contains only a few of the P7 operations, so testing has been minimal.
General attribute types, containing information from the X.400 envelope, are also included.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23479 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe asciitpkt checkin broke the TPKT dissector comment out create_dissector_handle...
etxrab [Sat, 17 Nov 2007 09:17:06 +0000 (09:17 +0000)]
The asciitpkt checkin broke the TPKT dissector comment out create_dissector_handle() and
dissector_add() for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23478 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 17 Nov 2007 08:57:20 +0000 (08:57 +0000)]
Apply yet another set of the optimization patches:
- Don't call tree_view_select on first button click event, it's already done by the tree widget.
- Factorize slow gtk_text_buffer_insert_with_tags_by_name() calls

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23477 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd missing header file (eap.h)
martinm [Sat, 17 Nov 2007 00:20:32 +0000 (00:20 +0000)]
Add missing header file (eap.h)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23476 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a buffer overflow in the PPP dissector. Try to fix uninitialized
gerald [Fri, 16 Nov 2007 23:56:18 +0000 (23:56 +0000)]
Fix a buffer overflow in the PPP dissector.  Try to fix uninitialized
variable warnings turned up by Valgrind.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23475 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoEmbedding EAP inside wimaxasncp.
martinm [Fri, 16 Nov 2007 23:03:09 +0000 (23:03 +0000)]
Embedding EAP inside wimaxasncp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23474 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSome comments and formatting.
martinm [Fri, 16 Nov 2007 22:56:56 +0000 (22:56 +0000)]
Some comments and formatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23473 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix trivial typo.
martinm [Fri, 16 Nov 2007 22:53:18 +0000 (22:53 +0000)]
Fix trivial typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23472 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reassembly is off, catch ReportedBoundsError when calling a subdissector
morriss [Fri, 16 Nov 2007 22:04:27 +0000 (22:04 +0000)]
When reassembly is off, catch ReportedBoundsError when calling a subdissector
on the first fragment of a fragmented message.  This allows us to continue
dissecting chunks even if one of the first chunks in the frame was fragmented.
(It's useful to keep doing this partial dissection just so we have some idea
what's in that chunk.)

(One could rightfully argue that you should only see a fragmented chunk
bundled with another chunk when retransmitting but, well, I'm staring at
traces of an implementation--to remain nameless to protect the guilty--which
is sometimes fragmenting and then bundling the fragments into one packet.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23471 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd changes up to r23464.
gerald [Fri, 16 Nov 2007 20:00:00 +0000 (20:00 +0000)]
Add changes up to r23464.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23470 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reassembly is turned off don't pass non-first fragments to subdissectors: they...
morriss [Fri, 16 Nov 2007 19:32:59 +0000 (19:32 +0000)]
When reassembly is turned off don't pass non-first fragments to subdissectors: they will have no idea what they're getting and will exception out anyway.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23469 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd {} to some IF statements.
etxrab [Fri, 16 Nov 2007 09:00:14 +0000 (09:00 +0000)]
Add {} to some IF statements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23468 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Gignac:
etxrab [Fri, 16 Nov 2007 08:22:50 +0000 (08:22 +0000)]
From Martin Gignac:
Add comments and comment out an obsolete AVP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23467 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Harmeet Sawhney:
etxrab [Fri, 16 Nov 2007 08:18:30 +0000 (08:18 +0000)]
From Harmeet Sawhney:
Parse MGCP over TCP with ASCII TPKT header
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1964

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23466 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv Kaul :
bondolo [Thu, 15 Nov 2007 23:59:54 +0000 (23:59 +0000)]
From Yaniv Kaul :

Adds application/rss+xml mime type as a recognized XML type. It is used by some RSS servers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23465 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded correct svn propset settings to wiretap/netscreen.[ch]
sake [Thu, 15 Nov 2007 19:46:25 +0000 (19:46 +0000)]
Added correct svn propset settings to wiretap/netscreen.[ch]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23464 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't try to reassemble a huge number of fragments.
gerald [Thu, 15 Nov 2007 19:38:04 +0000 (19:38 +0000)]
Don't try to reassemble a huge number of fragments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23463 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a generated lapd.direction field/filter.
martinm [Thu, 15 Nov 2007 18:37:50 +0000 (18:37 +0000)]
Add a generated lapd.direction field/filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23462 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew t125 dissector
sahlberg [Thu, 15 Nov 2007 10:39:16 +0000 (10:39 +0000)]
new t125 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23461 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoonly dissect it as t125 if it looks like t125
sahlberg [Thu, 15 Nov 2007 10:38:43 +0000 (10:38 +0000)]
only dissect it as t125 if it looks like t125

dissect_ber_choice() returns the index of the choice taken   not the
tag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23460 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew ldap dissector
sahlberg [Thu, 15 Nov 2007 10:32:45 +0000 (10:32 +0000)]
new ldap dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23459 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice() returns the index of the taken arm not the tag
sahlberg [Thu, 15 Nov 2007 10:32:10 +0000 (10:32 +0000)]
dissect_ber_choice() returns the index of the taken arm   not the tag
value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23458 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew x411 dissector
sahlberg [Thu, 15 Nov 2007 10:11:09 +0000 (10:11 +0000)]
new x411 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23457 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice returns a gint that is the index of the choice taken,
sahlberg [Thu, 15 Nov 2007 10:10:22 +0000 (10:10 +0000)]
dissect_ber_choice returns a gint that is the index of the choice taken,
not the tag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23456 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated snmp dissector
sahlberg [Thu, 15 Nov 2007 09:50:36 +0000 (09:50 +0000)]
updated snmp dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23455 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice() returns the index of the choice, not the tag of the
sahlberg [Thu, 15 Nov 2007 09:49:55 +0000 (09:49 +0000)]
dissect_ber_choice() returns the index of the choice, not the tag of the
choice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23454 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated mms dissector
sahlberg [Thu, 15 Nov 2007 09:42:21 +0000 (09:42 +0000)]
updated mms dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23453 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobranch_taken that is returned by dissect_ber_choice() is the index of
sahlberg [Thu, 15 Nov 2007 09:41:32 +0000 (09:41 +0000)]
branch_taken that is returned by dissect_ber_choice() is the index of
of the branch and not the tag value   so one cant use it with
val_to_str()
(well one can in this instance since by luck the tag values match the
indices)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23452 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP".
etxrab [Thu, 15 Nov 2007 06:03:53 +0000 (06:03 +0000)]
Fix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23451 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanged to use the the packet-ber EXTERNAL decoding (into the ASN1 context).
gal [Wed, 14 Nov 2007 20:57:55 +0000 (20:57 +0000)]
Changed to use the the packet-ber EXTERNAL decoding (into the ASN1 context).
Uses the ber_callback mechanism to call the rtse oid callbacks, rather than the default ber oid callback list.
A couple of fixes to packet-ber.c to mark [in]direct references as present and call the ber_callback if it has been specified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23450 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoKeep the MEGACO dissector from looping on a malformed events descriptor.
gerald [Wed, 14 Nov 2007 19:28:29 +0000 (19:28 +0000)]
Keep the MEGACO dissector from looping on a malformed events descriptor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23449 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Valery Sigalov via bug #1853: Fix the following console error when
sfisher [Wed, 14 Nov 2007 17:39:21 +0000 (17:39 +0000)]
From Valery Sigalov via bug #1853: Fix the following console error when
starting Wireshark:

Duplicate field detected in call to proto_register_field_array: channel_id is
already registered

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23448 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded some parentheses to clarify the gint64 cast.
stig [Wed, 14 Nov 2007 10:15:20 +0000 (10:15 +0000)]
Added some parentheses to clarify the gint64 cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23447 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Shiang-Ming Huang:
stig [Wed, 14 Nov 2007 09:37:44 +0000 (09:37 +0000)]
From Shiang-Ming Huang:
Removed unnecessary parentheses that make the average packets size
calculated as an integer instead of a float.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23446 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom didier:
sfisher [Wed, 14 Nov 2007 06:39:58 +0000 (06:39 +0000)]
From didier:

Fix for bug #1876: Resizing columns changes the currently-selected packet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23445 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Dejan Bucar:
etxrab [Tue, 13 Nov 2007 22:05:43 +0000 (22:05 +0000)]
From Dejan Bucar:
Updated dissector for LINX protocols

* Linx Ethernet Connection Manager protocol is updated from version 2 to
version 3.
* Linx RLNH protocol has been updated from version 1 to version 2.

The updated dissector is backwards-compatible allowing correct dissection of
all versions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23444 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCorrect assorted typos and copy-past errors.
etxrab [Tue, 13 Nov 2007 22:00:46 +0000 (22:00 +0000)]
Correct assorted typos and copy-past errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23443 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Florent DROUIN:
etxrab [Tue, 13 Nov 2007 21:59:53 +0000 (21:59 +0000)]
From Florent DROUIN:
Since the use of the function 'dissect_ber_tagged_type' for DialoguePortion,
the file tcap.cnf must be updated to remove the decoding of the tag and length.
This decoding is now done in the new function 'dissect_ber_tagged_type'.

The file tcap.cnf has been updated to take into account this change.
But this leads to a change in tcap.asn too, for the definition of the
ExternalPDU.
I think this part of the ASN1 file is specific to Wireshark and can be
modified.

In the meantime, I did update the DEBUG part for packet_ber.c  for the function
(dissect_ber_tagged_type)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23442 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMark some generated items in ROS.
stig [Tue, 13 Nov 2007 10:26:30 +0000 (10:26 +0000)]
Mark some generated items in ROS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23441 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse glib-2.14.3
etxrab [Tue, 13 Nov 2007 06:11:24 +0000 (06:11 +0000)]
Use glib-2.14.3

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23440 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd AVP info.
etxrab [Mon, 12 Nov 2007 21:14:53 +0000 (21:14 +0000)]
Add AVP info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23439 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't dereference a NULL pointer.
gerald [Mon, 12 Nov 2007 20:02:24 +0000 (20:02 +0000)]
Don't dereference a NULL pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23438 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrint the pass number periodically as a convenience for running the script
gerald [Mon, 12 Nov 2007 19:47:15 +0000 (19:47 +0000)]
Print the pass number periodically as a convenience for running the script
on a large number of trace files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23437 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInitialize var_list in dissect_smux(), so that we don't use previously
gerald [Mon, 12 Nov 2007 18:44:29 +0000 (18:44 +0000)]
Initialize var_list in dissect_smux(), so that we don't use previously
ep_freed() memory and abort.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23436 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReplace strcpy()+strcat() with g_snprintf(). Make sure a string isn't
gerald [Mon, 12 Nov 2007 17:02:46 +0000 (17:02 +0000)]
Replace strcpy()+strcat() with g_snprintf().  Make sure a string isn't
NULL before we try to use it.  This fixes a crash found during fuzzing
and a possible buffer overrun.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23435 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd various files of PortableApps packaging
ulfl [Mon, 12 Nov 2007 07:35:21 +0000 (07:35 +0000)]
add various files of PortableApps packaging

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23434 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate various other places, where WinPcap version 4.0.1 was used
ulfl [Mon, 12 Nov 2007 07:34:32 +0000 (07:34 +0000)]
update various other places, where WinPcap version 4.0.1 was used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23433 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd various files of PortableApps packaging
ulfl [Mon, 12 Nov 2007 07:33:30 +0000 (07:33 +0000)]
add various files of PortableApps packaging

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23432 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate various other places, where WinPcap version 4.0.1 was used
ulfl [Mon, 12 Nov 2007 07:31:38 +0000 (07:31 +0000)]
update various other places, where WinPcap version 4.0.1 was used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23431 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove forgotten debug code.
etxrab [Mon, 12 Nov 2007 07:03:09 +0000 (07:03 +0000)]
Remove forgotten debug code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23430 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdate WinPcap installer to recent 4.0.2
ulfl [Sun, 11 Nov 2007 20:36:41 +0000 (20:36 +0000)]
update WinPcap installer to recent 4.0.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23429 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Valery Sigalov:
etxrab [Sun, 11 Nov 2007 13:23:17 +0000 (13:23 +0000)]
From Valery Sigalov:
New dissector for TPNCP protocol.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1853

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23428 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOpen the coloring rule edit dialog when the coloring rule is
sake [Sun, 11 Nov 2007 00:59:19 +0000 (00:59 +0000)]
Open the coloring rule edit dialog when the coloring rule is
double-clicked.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23427 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake the enable/disable buttons on the coloring rule list follow
sake [Sat, 10 Nov 2007 23:05:35 +0000 (23:05 +0000)]
Make the enable/disable buttons on the coloring rule list follow
the selection. There is a little difference between the behaviour
in GTK1 and GTK2 (As long as either one row or a block of rows with
the same status is selected, GTK1 and GTK2 behave the same way):

GTK1:
- if the last selected row is disabled, grey out the disable button
- if the last selected row is enabled, grey out the enable button

GTK2:
- grey out both buttons when no rule is selected
- grey out the enable button when *all* selected rules are enabled
- grey out the disable button when *all* selected rules are disabled
- leave both buttons active if there is a mix of disabled and enabled
  rules

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23426 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoEnsure we pop any previous loaded filename from the statusbar
stig [Sat, 10 Nov 2007 21:59:20 +0000 (21:59 +0000)]
Ensure we pop any previous loaded filename from the statusbar
when loading a new file with a file already loaded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23425 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 10 Nov 2007 17:06:49 +0000 (17:06 +0000)]
Apply yet another set of the optimization patches:
move TRY block in its own function.
 __attribute__((noinline)) does not compile with MS VC 6
nor does __declspec(noinline)
Applied the patch without it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23424 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 10 Nov 2007 16:09:10 +0000 (16:09 +0000)]
Apply yet another set of the optimization patches:
there's two structures with the same name conversation_t, change one to conv_t

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23423 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 10 Nov 2007 16:08:14 +0000 (16:08 +0000)]
Apply yet another set of the optimization patches:
Use O(1) logic for the fast path when adding fragments (ie fragments are in order).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23422 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThis patch makes it possible to disable individual coloring rules
sake [Sat, 10 Nov 2007 15:18:49 +0000 (15:18 +0000)]
This patch makes it possible to disable individual coloring rules
without having to delete them. The patch has been tested on
Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11.

Since I don't know how to use "strikethrough" in clists in GTK1
there is a little difference in how the disabled coloring rules
are displayed. In GTK2 they are striked through and in GTK1
they are shown in lightgrey on a white background.

Any info on how to use strikthrough in clists within GTK1 is more
than welcome :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23421 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoQuote a "Checking for" message.
guy [Sat, 10 Nov 2007 02:39:19 +0000 (02:39 +0000)]
Quote a "Checking for" message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23420 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate comment, clean up message.
guy [Sat, 10 Nov 2007 02:18:18 +0000 (02:18 +0000)]
Update comment, clean up message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23419 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd MacOS X version next to the Darwin version in version outputs.
sfisher [Sat, 10 Nov 2007 00:57:41 +0000 (00:57 +0000)]
Add MacOS X version next to the Darwin version in version outputs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23418 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCast "char"s to "unsigned char" before handing them to <ctype.h> macros.
guy [Sat, 10 Nov 2007 00:36:01 +0000 (00:36 +0000)]
Cast "char"s to "unsigned char" before handing them to <ctype.h> macros.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23417 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a newline.
gerald [Fri, 9 Nov 2007 20:05:44 +0000 (20:05 +0000)]
Add a newline.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23416 f5534014-38df-0310-8fa8-9805f1628bb7