Don't build a manifest if we don't need one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36448 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign to a proto_item * if the value won't be used: Coverity 820/821;
Also: #include <stdio.h> & <string.h> not required;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36447 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign to a variable if the value won't be used: Coverity 817-821.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36446 f5534014-38df-0310-8fa8-9805f1628bb7

Mark pinfo as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36445 f5534014-38df-0310-8fa8-9805f1628bb7

Get rid of gsm_a_dtap_pinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36444 f5534014-38df-0310-8fa8-9805f1628bb7

Change the signature of elem_fcn():ns to include pinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36443 f5534014-38df-0310-8fa8-9805f1628bb7

From Vincent Helfre:
updated the script that extracts the asn1 from the specification (we modified it after noticing that it currently fails to take the IMPORT section). It should also work now to extract the WCDMA RRC (TS 25.331).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36442 f5534014-38df-0310-8fa8-9805f1628bb7

Change the msg_fcn() signature to include pinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36441 f5534014-38df-0310-8fa8-9805f1628bb7

From jakub Zawadzki:
I've fixed composite tests #0 and #2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36440 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign to a proto_item* if the value won't be used: Coverity 885-889
Also: Significant code rework including:
  - Fix bug wherein a timestamp was incorrectly reported as being an Error;
  - Replace many proto_tree_add_text()/proto_item_set_text() sequences each by a
    single proto_tree_add_text().
  - remove unneeded #include <string.h>
  - Whitespace clanup including replacing mixed space/tab indentation by spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36437 f5534014-38df-0310-8fa8-9805f1628bb7

[Automatic manuf, services and enterprise-numbers update for 2011-04-03]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36436 f5534014-38df-0310-8fa8-9805f1628bb7

-Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36435 f5534014-38df-0310-8fa8-9805f1628bb7

Add some info as to the determination of the length of a FT_STRINGZ item.
Add a note not leaving trailing whitespace on a line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36434 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :

Patch 6 :
Enhance the MySQL collation

Patch 7 :
Enhance MySQL : add dissection of command Binlog Dump (replicate command).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36433 f5534014-38df-0310-8fa8-9805f1628bb7

Avoid potential buffer overruns when sscanf'ing strings.
Should resolve CID's 656 and 657.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36432 f5534014-38df-0310-8fa8-9805f1628bb7

Don't use pParser->yyidx as an index into pParser->yystack[] until after it is
verified that it is non-negative.  Should resolve CID 619.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36431 f5534014-38df-0310-8fa8-9805f1628bb7

Remove const type qualifier from cast.  Resolves CID's 582-585.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36430 f5534014-38df-0310-8fa8-9805f1628bb7

Take care not to append RLC mode to proto_item twice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36429 f5534014-38df-0310-8fa8-9805f1628bb7

Rename local 'pipe_input' so it doesn't shadow global 'pipe_input';
Use consistent indentation and remove trailing whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36428 f5534014-38df-0310-8fa8-9805f1628bb7

Memory leak in lemon.c

coverity 1177

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36427 f5534014-38df-0310-8fa8-9805f1628bb7

Fix 11 occurrences of returned pointer never used.  Fixes CID's 1064-1067.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36426 f5534014-38df-0310-8fa8-9805f1628bb7

Check return value of file_seek().  Fixes CID 338.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36425 f5534014-38df-0310-8fa8-9805f1628bb7

Don't dereference a NULL pointer.  Fixes CID 426.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36424 f5534014-38df-0310-8fa8-9805f1628bb7

separator will never be NULL, but sep_len could be 0, so test for that instead.
Fixes CID 620.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36423 f5534014-38df-0310-8fa8-9805f1628bb7

Use BSWAP16 instead of BSWAP32 for 16-bit values.  Fixes CID's 1179 and 1180.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36422 f5534014-38df-0310-8fa8-9805f1628bb7

Use a common function, higher_priority_status_level() to determine whether or
not messages should be pushed onto the statusbar.  Should fix CID 270.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36421 f5534014-38df-0310-8fa8-9805f1628bb7

Clear the entire contents of ctx at the end of md5_finish().  Fixes CID 712.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36420 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were:
"warning: Value stored to 'offset' is never read".  The 'offset' is now used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36419 f5534014-38df-0310-8fa8-9805f1628bb7

Delete unused header fields found by running tools/checkhf.pl.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36418 f5534014-38df-0310-8fa8-9805f1628bb7

(Trivial) Fix some typos; do some whitespace cleanup & rewording of comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36417 f5534014-38df-0310-8fa8-9805f1628bb7

From Yair via bug 5779: Add option to leave AAL5 in unspecified format.
(... with whitepsace changes by me.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36416 f5534014-38df-0310-8fa8-9805f1628bb7

From Andrew Feren via bug 5775: Correct types on several info elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36415 f5534014-38df-0310-8fa8-9805f1628bb7

Register tcp by name.
To be used in User DLT's and Lua scripts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36414 f5534014-38df-0310-8fa8-9805f1628bb7

Use correct functions to fetch protocol name for a dissector registered
by register_dissector().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36413 f5534014-38df-0310-8fa8-9805f1628bb7

Added dissector_handle_get_long_name().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36412 f5534014-38df-0310-8fa8-9805f1628bb7

Use correct length for clientaddr4 callback address entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36411 f5534014-38df-0310-8fa8-9805f1628bb7

Fix a couple of typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36410 f5534014-38df-0310-8fa8-9805f1628bb7

From: wireshark.org/lists/wireshark-dev/201103/msg00157.html
Change RTT references to SRT.  (This should have been checked in with r36297.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36409 f5534014-38df-0310-8fa8-9805f1628bb7

Wrap all text lines of help at column 80.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36408 f5534014-38df-0310-8fa8-9805f1628bb7

remove two pointless const in casts

coverity 580 and 581

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36407 f5534014-38df-0310-8fa8-9805f1628bb7

remove some assignments we dont use

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36406 f5534014-38df-0310-8fa8-9805f1628bb7

Change TCP_PORT_MANGO to TCP_PORT_MONGO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36405 f5534014-38df-0310-8fa8-9805f1628bb7

Don't put a 65536 byte variable on the stack: instead, malloc/free it.

Coverity 760-761.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36404 f5534014-38df-0310-8fa8-9805f1628bb7

Add a missing break.
CID 487

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36403 f5534014-38df-0310-8fa8-9805f1628bb7

Add a missing break.
CID 488

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36402 f5534014-38df-0310-8fa8-9805f1628bb7

Add a missing break.
CID 490

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36401 f5534014-38df-0310-8fa8-9805f1628bb7

Added  FALLTHRU comment to avoid a "missing break" warning.
CID 489

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36400 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte via bug 5790: Add partial bit flag in query.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36399 f5534014-38df-0310-8fa8-9805f1628bb7

Grab URL from frame info value instead of from tvb.  Fixes bug 5780.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36398 f5534014-38df-0310-8fa8-9805f1628bb7

Don't put a 196808 byte variable on the stack: instead, malloc/free it.

Coverity 789-790.

Since we've been keeping track of how many bytes we put in the buffer,
use that value instead of calling strlen() find it again.

Also, some white space/indentation cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36397 f5534014-38df-0310-8fa8-9805f1628bb7

Remove check_col().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36396 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign proto_item pointers that are not used.

Coverity 1174

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36395 f5534014-38df-0310-8fa8-9805f1628bb7

Don't put a 65536 byte variable on the stack: instead, malloc/free it.

Coverity 791-794.

Also, some white space/indentation cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36394 f5534014-38df-0310-8fa8-9805f1628bb7

Guard against NULL return from find_protocol_by_id().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36393 f5534014-38df-0310-8fa8-9805f1628bb7

From Pascal Quantin:
Added guard against proto_name's not resolved as protocols.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36392 f5534014-38df-0310-8fa8-9805f1628bb7

RTP: display payload type name from dynamic payload type table
H.223: use just one protocol for bot dissectors for more clear protocol disabling

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36391 f5534014-38df-0310-8fa8-9805f1628bb7

Prohibit (memory-unsafe) g_sprintf() and g_vsprintf().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36390 f5534014-38df-0310-8fa8-9805f1628bb7

Cast to guint to avoid a Windows compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36389 f5534014-38df-0310-8fa8-9805f1628bb7

Move -D option into "pre-scan" group as there's no need to start gtk+ for it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36388 f5534014-38df-0310-8fa8-9805f1628bb7

Use fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36387 f5534014-38df-0310-8fa8-9805f1628bb7

Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36386 f5534014-38df-0310-8fa8-9805f1628bb7

Use g_ascii_strdown instead of g_strdown

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36385 f5534014-38df-0310-8fa8-9805f1628bb7

More updates to the wtap_open_offline() comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36384 f5534014-38df-0310-8fa8-9805f1628bb7

Don't use prohibited strncpy().  Use g_strlcpy() instead.  Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36383 f5534014-38df-0310-8fa8-9805f1628bb7

Don't use prohibited strncpy().  In this case, use g_strlcat() instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36382 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :

Fix a Clang warning, add email address, and add some stuff to COL_INFO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36381 f5534014-38df-0310-8fa8-9805f1628bb7

From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :

Register the reload-framing dissector by name.  Needed when RELOAD is not used
over udp/tcp (but tls, for example)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36380 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :

Patch 5

Enchance MySQL :
* Add expert info of when undecoded data
* Fix some white space

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36379 f5534014-38df-0310-8fa8-9805f1628bb7

Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
the value="..." attribute.  Fixes bug 1520.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36378 f5534014-38df-0310-8fa8-9805f1628bb7

Added payload, header and trailer information to the DLT tree entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36377 f5534014-38df-0310-8fa8-9805f1628bb7

Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36376 f5534014-38df-0310-8fa8-9805f1628bb7

If there are more than 4 billion characters in the printable form of a
network address, we have bigger problems.  Cast the result of strlen()
to int to squelch a compiler warning with MSVC++.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36375 f5534014-38df-0310-8fa8-9805f1628bb7

Fix Coverity 393: "DEADCODE"; Add an XXX comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36373 f5534014-38df-0310-8fa8-9805f1628bb7

Add "-z hosts", which dumps name resolution information in hosts format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36372 f5534014-38df-0310-8fa8-9805f1628bb7

Add the IPv4 address, not the first 4 bytes of its name, to the
resolution table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36370 f5534014-38df-0310-8fa8-9805f1628bb7

1. Fix bug in dissection of a field; Add two missing lines of code.
2. #if 0 if test "which will never be true"; Add XXX comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36369 f5534014-38df-0310-8fa8-9805f1628bb7

[Automatic manuf, services and enterprise-numbers update for 2011-03-27]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36368 f5534014-38df-0310-8fa8-9805f1628bb7

Removed uneeded 'continue'.

Fixes Coverity 815 ("UNREACHABLE").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36367 f5534014-38df-0310-8fa8-9805f1628bb7

Added a FALLTHRU comment to avoid a "missing break" warning.

Coverity 472.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36366 f5534014-38df-0310-8fa8-9805f1628bb7

Added  FALLTHRU comment to avoid a "missing break" warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36365 f5534014-38df-0310-8fa8-9805f1628bb7

Added a missing break.

Coverity 452.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36364 f5534014-38df-0310-8fa8-9805f1628bb7

Added a missing break.

Coverity 461.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36363 f5534014-38df-0310-8fa8-9805f1628bb7

Added some missing breaks.

Coverity 462 & 463.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36362 f5534014-38df-0310-8fa8-9805f1628bb7

Added some missing breaks.

Coverity 443 & 444.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36361 f5534014-38df-0310-8fa8-9805f1628bb7

Added some missing breaks.

Coverity 447.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36360 f5534014-38df-0310-8fa8-9805f1628bb7

Added a FALLTHRU comment to avoid a "missing break" warning.

Coverity 458.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36359 f5534014-38df-0310-8fa8-9805f1628bb7

Added some missing breaks.

Coverity 466.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36358 f5534014-38df-0310-8fa8-9805f1628bb7

Added a missing break.

Coverity 491.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36357 f5534014-38df-0310-8fa8-9805f1628bb7

Added a missing break.

Coverity 492.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36356 f5534014-38df-0310-8fa8-9805f1628bb7

Don't assign to a proto_item* if the value won't be used: Coverity 895-897
Also: Fix some indentation & whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36355 f5534014-38df-0310-8fa8-9805f1628bb7

From Alexis La Goutte:
A patch to add ATM over TCP Dissector.
The dissector dissect only the ATMTCP header (VCI, VPI, Payload Length)
The data are not yet dissect, it is necessary to add a "UAT" (As with the K12
dissector) to indicate the type (ILMI, AAL, ATM...) of data (based on VCI/VPI)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36354 f5534014-38df-0310-8fa8-9805f1628bb7

Added a sanity check to remove a coverity warning.

Coverity 537.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36353 f5534014-38df-0310-8fa8-9805f1628bb7

Added sanity checks for preferences.

Coverity 551 & 553.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36352 f5534014-38df-0310-8fa8-9805f1628bb7

Added a sanity check in output_fields_set_option.

Coverity 552.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36351 f5534014-38df-0310-8fa8-9805f1628bb7

Added a FALLTHRU comment to avoid a coverity warning.

Coverity 480.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36350 f5534014-38df-0310-8fa8-9805f1628bb7

Added a missing break in graph_select_segment.

Coverity 482.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36349 f5534014-38df-0310-8fa8-9805f1628bb7

Added a missing break in hostlist_get_filter_name.

Coverity 481.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36348 f5534014-38df-0310-8fa8-9805f1628bb7

From Hadar Shoham:
Add support to correlation ID under DHCPv6 according to
"CL-SP-CANN-DHCP-Reg-I06-110210"
DHCPv6 option 17 Vendor-specific Information, sub option 2172 (paragraph 5.4.3)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36347 f5534014-38df-0310-8fa8-9805f1628bb7

remove a proto_item variable we never use

coverity 866

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36346 f5534014-38df-0310-8fa8-9805f1628bb7

remove a proto_item variable we dont need

coverity 1046

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36345 f5534014-38df-0310-8fa8-9805f1628bb7