morriss [Wed, 18 May 2011 17:09:55 +0000 (17:09 +0000)]
Add a default (else) case in the default case for cause values to avoid passing
a NULL string pointer to format routines.
While we're there, update the cause list from 48.008 v10.1.0.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37244
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 16:52:45 +0000 (16:52 +0000)]
Don't assign to an unused 'proto_item *': Coverity 939 [UNUSED];
Don't create a subtree which is never used: Coverity 940 [UNUSED].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37243
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 16:19:15 +0000 (16:19 +0000)]
Use subtree rather than parent tree to add items; Fixes Coverity 973 & 974;
#include <stdlib.h> not needed;
Minor whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37242
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Wed, 18 May 2011 15:56:46 +0000 (15:56 +0000)]
Per destination flags is a 1-byte field. Grab it with tvb_get_guint8(), not
with tvb_get_letohs(). (Bug surfaced while trying out MESH_OVERRIDES.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37241
f5534014-38df-0310-8fa8-
9805f1628bb7
alagoutte [Wed, 18 May 2011 15:34:34 +0000 (15:34 +0000)]
From discussion in dev mailing ( wireshark.org/lists/wireshark-dev/201105/msg00235.html )
* Fix a duplicate value_string in cp_version table
* Fix a typo error (Cersion => Version)
Also fix some whitespaces/4tab-spaces (Need more work...)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37240
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 18 May 2011 15:33:07 +0000 (15:33 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5930 :
with a variant of the patch submitted by Alexander Stein on the -dev list:
Allow FT_FRAMENUMs to be added (as base BASE_NONE). My change from Alexander's
patch is to disallow BASE_NONE for non-framenum integers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37239
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Wed, 18 May 2011 13:08:02 +0000 (13:08 +0000)]
Refer to "Capture Help" as "Capture Help below" when there are no interfaces
to capture on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37238
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 18 May 2011 08:10:37 +0000 (08:10 +0000)]
Removed "Copy" from the profiles popup menu in favour of a "Create from"
dropdown in the "Create New Profile" window.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37237
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 May 2011 07:20:45 +0000 (07:20 +0000)]
You cannot just make the "len" field of a GByteArray larger, if there's
no data to back that length; you can only make it smaller.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37236
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 May 2011 03:28:26 +0000 (03:28 +0000)]
Make some more routines not used outside epan/proto.c static.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37235
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 01:37:06 +0000 (01:37 +0000)]
Convert tabs to "4 spaces" since it appears that tabs are "4 space tabs";
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37234
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 01:29:25 +0000 (01:29 +0000)]
Remove code to generate an unuse sub-tree: Coverity: 976;
Don't assign to an unused variable: Coverity 977;
#include <stdlib.h> & <string.h> not req'd.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37233
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 00:59:24 +0000 (00:59 +0000)]
Don't assign to unused proto_item * variables: Coverity 1015 & 1016.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37232
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 00:37:35 +0000 (00:37 +0000)]
Remove altogether code '#if 0'd in SVN #37229.
Further research shows that registering the dissector
to "tcp.port" and "udp.port" was explicitly removed in SVN #34969
and thus the code to create tcp and udp handles and the associated
dissect_reload_tcp() and dissect_reload_udp() code is no longer
needed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37231
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 May 2011 00:29:48 +0000 (00:29 +0000)]
Get rid of unused function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37230
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Wed, 18 May 2011 00:07:32 +0000 (00:07 +0000)]
#if 0 some unused code & vars: Coverity 1018 & 1019;
Add a comment the unused code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37229
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 23:39:06 +0000 (23:39 +0000)]
Squelch a narrowing warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37228
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 23:37:27 +0000 (23:37 +0000)]
Squelch a narrowing warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37227
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 23:36:25 +0000 (23:36 +0000)]
Make some routines static that aren't used outside the source file in
which they're defined.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37226
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 17 May 2011 23:36:12 +0000 (23:36 +0000)]
Add items to subtree rather than tree: Coverity 1026;
Don't assign to an unused variable: Coverity 1027;
#include <stdlib.h> not req'd.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37225
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 23:35:12 +0000 (23:35 +0000)]
Fix another old-style function definition.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37224
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 23:33:23 +0000 (23:33 +0000)]
Make some routines static that aren't used outside the source file in
which they're defined.
Include some header files that declare functions in the source files
that define the functions.
Declare packet_list_get_type() in gtk/packet_list_store.h, as it defines
a macro that uses that function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37223
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 22:24:26 +0000 (22:24 +0000)]
Add -Wold-style-definition and -Wdeclaration-after-statement to the list
of warnings we enable by default; we'll move them if they break any
builds in non-fixable ways.
Add -Wmissing-prototypes and -Wmissing-declarations to the list of
things we don't enable by default, and explain why those, and
-Wstrict-prototypes can't be used.
Also explain why we check for clang before checking whether we can
enable -fexcess-precision=fast.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37219
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 22:21:25 +0000 (22:21 +0000)]
Always add the parameter length field to the tree; only make it visible
if the preference is set.
Add %d to the "not found" string in val_to_str() calls.
Upgrade the "ITU address format seen in ANSI" expert info from NOTE to WARN.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37218
f5534014-38df-0310-8fa8-
9805f1628bb7
darkjames [Tue, 17 May 2011 22:20:14 +0000 (22:20 +0000)]
Add generic tvb_get_bits_buf() which accepts any no_of_bits.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37217
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 22:18:32 +0000 (22:18 +0000)]
More eradication of old-style function definitions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37216
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 22:17:04 +0000 (22:17 +0000)]
Declare wtap_dump_has_name_resolution().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37215
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 21:59:58 +0000 (21:59 +0000)]
Add a filterable item for the length of the GT digits in a subtree under the
digits.
Since we now have a subtree from which to hang things, make the generic (called
or calling) digits fields visible under this new subtree (one less hidden item).
Don't use add_string_format() to add the GT digits, let epan format it for us.
Use more descriptive field descriptions for these entries.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37214
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 21:28:07 +0000 (21:28 +0000)]
This ain't C++; you have to put "void" in as the argument list of
functions that take no arguments, otherwise the function is treated as a
crufty old C function with undeclared arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37212
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 21:26:25 +0000 (21:26 +0000)]
This ain't C++; you have to put "void" in as the argument list of
functions that take no arguments, otherwise the function is treated as a
crufty old C function with undeclared arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37211
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 17 May 2011 21:00:58 +0000 (21:00 +0000)]
Fix docbook errors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37210
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 20:04:22 +0000 (20:04 +0000)]
Don't leave the truncation flag unset in any of the info level
dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37209
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 19:59:18 +0000 (19:59 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5875 :
Error out if the user asked us to install dumpcap with a particular group but
we are not building dumpcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37208
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Tue, 17 May 2011 19:51:55 +0000 (19:51 +0000)]
* Don't declare a used arg as unused.
* Really clear the EOF flag. This fixes a bug where
tshark is not able to do a live capture from a pcapng
file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37207
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 17 May 2011 19:26:00 +0000 (19:26 +0000)]
Update the release notes for 1.7/1.8.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37206
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 18:58:40 +0000 (18:58 +0000)]
As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.
Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.
Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer). A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.
Store the return value of match_strval() rather than calling it repeatedly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37204
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 18:53:35 +0000 (18:53 +0000)]
Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37203
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 17:40:26 +0000 (17:40 +0000)]
As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.
Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.
Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37202
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 17 May 2011 16:07:24 +0000 (16:07 +0000)]
Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
Solaris') will seg-fault on that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37201
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Tue, 17 May 2011 14:41:01 +0000 (14:41 +0000)]
All ELEM_MAND_* macros ensure curr_len > 0; no need to check again afterwards.
Resolves Coverity CIDs 381-382.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37200
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 17 May 2011 08:23:30 +0000 (08:23 +0000)]
Use the correct value string and bitmasks.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5928
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37199
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 17 May 2011 04:20:35 +0000 (04:20 +0000)]
Update to FindGTK2 from cmake 2.8.3. Add back quartz options which
are not part of the official cmake release.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37198
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 02:29:43 +0000 (02:29 +0000)]
According to MS-NLMP, the "version" field in the NTLMSSP blobs is
present only if the NTLMSSP_NEGOTIATE_VERSION flag is set in the flags
field, and that appears to be true in at least one capture I've seen.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37197
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 01:38:28 +0000 (01:38 +0000)]
Fix cut-and-pasteo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37196
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 17 May 2011 00:08:47 +0000 (00:08 +0000)]
Dear GLib Developers:
Thank you very much for using "gulong" rather than "gsize" as the
"buffer length" argument to g_snprintf(), the fact that the
corresponding argument to snprintf() is a size_t nonwithstanding.
Developers building for LLP64 platforms such as Win32 greatly appreciate
this decision.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37195
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Mon, 16 May 2011 23:15:08 +0000 (23:15 +0000)]
From beth.tridium [At] gmail.com: 6LoWPAN dissector selects wrong byte for HC_UDP Encoding subtree
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5926
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37194
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 16 May 2011 22:55:22 +0000 (22:55 +0000)]
Give the UNIX-extension routines used for info levels that appear both
in set and get names beginning with dissect_qspi_.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37192
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 21:56:12 +0000 (21:56 +0000)]
Add support for capturing from multiple interfaces.
This patch is basedon work done by Irene Ruengeler.
This feature is considered experimental at the moment.
However, you need to use the -t command line option
to use the feature. When not providing it, the old
method will be used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37191
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 16 May 2011 21:42:49 +0000 (21:42 +0000)]
Cast away some warnings about alignment; ep_alloc() guarantees
sufficient alignment for all types of data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37190
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 16 May 2011 20:33:39 +0000 (20:33 +0000)]
A gboolean is a gint; technically, it doesn't fit in a bit field of length 1,
so eliminate the bit field. Fixes Coverity CIDs 1195-1196.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37189
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 16 May 2011 20:02:14 +0000 (20:02 +0000)]
Fix endian issues, especially w/endian arg to proto_tree_add_item().
Should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5464.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37188
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Mon, 16 May 2011 19:56:27 +0000 (19:56 +0000)]
#include <conio.h> when compiling under Windows with DEBUG_DUMPCAP defined.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37187
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 16 May 2011 18:32:35 +0000 (18:32 +0000)]
Fix some comments.
Get rid of null-pointer tests for t2i in the "not null" branch of an
earlier test whether it's null, as those tests are redundant.
Use a switch statement to check the subcommand for Trans2.
If t2i->info_level is -1, it means we don't know the info level, for
whatever reason (e.g., the request was cut short by the snapshot length
before the info level). Report it as such.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37183
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Mon, 16 May 2011 17:02:22 +0000 (17:02 +0000)]
Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
Solaris') will seg-fault on that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37181
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 16:27:42 +0000 (16:27 +0000)]
Use correct variable...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37180
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 15:25:33 +0000 (15:25 +0000)]
Fix compilation on windows (hopefully).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37179
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 15:19:54 +0000 (15:19 +0000)]
Make remote capturing settings a per interface thing. You can now
configure that you want to capture on multiple remote interfaces
on mulitple hosts.
Improve some #ifdef mess in dumpcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37178
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 16 May 2011 14:42:34 +0000 (14:42 +0000)]
Remove extra ;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37177
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 14:12:35 +0000 (14:12 +0000)]
Make pcap samping a per interface setting.
Use consistent naming of variables on capture_options.
Make pcap sampling independent of remote capturing, since
it seems to work local pcap devices using winpcap (at
least that is what the documentation says).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37176
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 16 May 2011 06:28:33 +0000 (06:28 +0000)]
More GUIManager stuff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37175
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 00:55:04 +0000 (00:55 +0000)]
* Fix a bug when printing a pointer.
* Remove number_of_ifaces, since ifaces->len can be used instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37174
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 16 May 2011 00:19:47 +0000 (00:19 +0000)]
Don't use debug output.
BTW: Why does compilation fail with it being enabled?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37173
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 15 May 2011 23:41:21 +0000 (23:41 +0000)]
Fix compilation on Windows (hopefully).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37172
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 15 May 2011 22:54:52 +0000 (22:54 +0000)]
Change internal data structures to store and handle mulitple
pcap devices / pipes to capture from and open and close them.
However, capturing currently happens only on the last specified
interface.
So this does not add user visible functionality except that
some bugs are fixed. For example a crash when capturing on
a pipe and saving in pcapng format.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37171
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 15 May 2011 21:28:21 +0000 (21:28 +0000)]
Mark a function arg as unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37170
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 15 May 2011 21:12:55 +0000 (21:12 +0000)]
Replace a number if 'if(...){exit(10);}' by _g_asserts;
Fix an event callback function signature;
Change quit() signal calback function to return void;
#include <stdlib.h> not req'd;
Misc minor changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37169
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 15 May 2011 21:09:04 +0000 (21:09 +0000)]
Don't assign to an unused variable;
#include <stdlib.h> not req'd
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37168
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 15 May 2011 19:25:50 +0000 (19:25 +0000)]
Fix the ChmodBPF startup item permissions. Handling this within
PackageMaker would be a more correct fix. Replacing PackageMaker with
something that fits our development and deployment model would be an
even more correct fix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37167
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 15 May 2011 19:01:38 +0000 (19:01 +0000)]
Replace some 'if(...){exit(10);}' by g_asserts;
Fix some event callback functon signatures;
Change the "destroy" callback function (quit()) to return void: It's not an event callback.
Do some whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37166
f5534014-38df-0310-8fa8-
9805f1628bb7
alagoutte [Sun, 15 May 2011 18:48:39 +0000 (18:48 +0000)]
Add EUI64 display type for Source/Target Link-layer Address (RFC4861)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37165
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Sun, 15 May 2011 17:54:33 +0000 (17:54 +0000)]
Mark an unused argument.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37163
f5534014-38df-0310-8fa8-
9805f1628bb7
alagoutte [Sun, 15 May 2011 17:47:56 +0000 (17:47 +0000)]
From Colin O'Flynn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5921
Fix for RPL DAO-ACK Processing when DODAG ID present
Reported and fixed by Jakob Ruhe
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37162
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Sun, 15 May 2011 16:52:05 +0000 (16:52 +0000)]
Add missing trailing 0 to an hf mask value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37160
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 15 May 2011 16:51:21 +0000 (16:51 +0000)]
Use correct signature for event callback functions;
Use event callback function user_data arg instead of using a property;
Replace an 'if(...) {... exit(10);}' by a g_assert;
Remove several unneeded 'if(...) {... exit(10);}' groups of code;
Do whitespace cleanuip.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37159
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 15 May 2011 15:09:44 +0000 (15:09 +0000)]
Remove debug code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37157
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 15 May 2011 15:08:47 +0000 (15:08 +0000)]
Set menu sensitivity.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37156
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 15 May 2011 15:03:59 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-05-15]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37155
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 15 May 2011 14:18:22 +0000 (14:18 +0000)]
Add the TCPGraph for UIManager.
Note sensitivity remains to be fixed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37154
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 15 May 2011 02:48:18 +0000 (02:48 +0000)]
Whitespace cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37152
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 15 May 2011 02:45:18 +0000 (02:45 +0000)]
gtk_combo_box_get_active_text() may return NULL and g_ascii_strcasecmp() complains if its first argument is NULL, so check for the NULL pointer before using it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37151
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sun, 15 May 2011 02:42:52 +0000 (02:42 +0000)]
main_widgets_rearrange(): only pack the airpcap_tb once (to avoid GTK complaints about the child already having a parent).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37150
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 14 May 2011 20:17:37 +0000 (20:17 +0000)]
1.5.2 → 1.7.0.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37148
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 14 May 2011 18:39:16 +0000 (18:39 +0000)]
Rebuild the X11 dissector with the latest versions of xcbproto and mesa.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37145
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Sat, 14 May 2011 14:57:58 +0000 (14:57 +0000)]
From Tyson Key via bug 5922: Add another AT magic array.
(I changed the array names to be more generic.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37144
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 14 May 2011 14:31:51 +0000 (14:31 +0000)]
From Sven Eckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5658 :
Add support for v12 fragmented unicast.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37143
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 14 May 2011 14:05:30 +0000 (14:05 +0000)]
From Sven Eckelmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5658 :
Read unchanged packets of v12 as v10 packets
Read unchanged packets of v13 as v11 packets
Use version in packet type definitions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37142
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 14 May 2011 13:15:56 +0000 (13:15 +0000)]
Move MAIN_MENU_USE_UI_MANAGER outside of if win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37141
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 14 May 2011 13:15:22 +0000 (13:15 +0000)]
Move MAIN_MENU_USE_UI_MANAGER outside of if win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37140
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 14 May 2011 02:52:04 +0000 (02:52 +0000)]
Remove the qpi_ from info level dissectors used for set info calls as
well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37139
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 14 May 2011 01:28:49 +0000 (01:28 +0000)]
For Find File Unix and Unix Info2, spell it "Unix", to match Query File
and Set File.
Add Query and Set File Unix Info2; use common code to dissect the Unix
Info2 structure. Use common code for Unix Basic, while we're at it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37138
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 14 May 2011 00:50:22 +0000 (00:50 +0000)]
Make the tree items for strings look a little less ugly.
Note that the string value should be put into the protocol tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37137
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 13 May 2011 22:10:42 +0000 (22:10 +0000)]
Fix a compiler warning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37136
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 13 May 2011 22:01:22 +0000 (22:01 +0000)]
Fix Bug 5920: "DNP3 dissector incorrect constants AL_OBJ_FCTR_16NF _FDCTR_32NF _FDCTR_16NF"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5920
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37135
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 13 May 2011 21:49:35 +0000 (21:49 +0000)]
More packets_bar_update improvements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37134
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 13 May 2011 21:47:09 +0000 (21:47 +0000)]
Fix Bug 5919: "IE 89 Forwarding Status - Incorrect Decoding"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5919
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37133
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 13 May 2011 19:29:15 +0000 (19:29 +0000)]
Delete 2 assignments to 'i' as neither were used. Fixes Coverity CID 875.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37132
f5534014-38df-0310-8fa8-
9805f1628bb7
cmaynard [Fri, 13 May 2011 19:15:21 +0000 (19:15 +0000)]
Delete assignment of item as it's not used. Fixes Coverity CID 869.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37131
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 13 May 2011 19:02:55 +0000 (19:02 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5902 :
Increase the maximum number of silence frames insert from 1000 to 240,000.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37130
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 13 May 2011 18:23:27 +0000 (18:23 +0000)]
Fix items pointed out by Guy in bug 5756.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37129
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 13 May 2011 17:12:44 +0000 (17:12 +0000)]
From Huzaifa Sidhpurwala of the Red Hat Security Response Team: Fix an
integer overflow in wiretap/visual.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37128
f5534014-38df-0310-8fa8-
9805f1628bb7