16 years agoFrom Charlie Lenahan: support for some HP switch protocol.
guy [Fri, 1 Apr 2005 09:43:19 +0000 (09:43 +0000)]
From Charlie Lenahan: support for some HP switch protocol.

Fix some damage to the AUTHORS file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13996 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of an unused variable.
guy [Fri, 1 Apr 2005 09:20:39 +0000 (09:20 +0000)]
Get rid of an unused variable.

Include "packet-gsm_map.h", not "packet-gsm_map.c".

Check in the regenerated CAMEL dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13995 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"get_conv_info()" doesn't use the tvbuff passed to it, so don't pass it
guy [Fri, 1 Apr 2005 09:19:29 +0000 (09:19 +0000)]
"get_conv_info()" doesn't use the tvbuff passed to it, so don't pass it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13994 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRename "register_ethereal_tap()" to "register_tap_listener_cmd_arg()" as
guy [Fri, 1 Apr 2005 09:08:27 +0000 (09:08 +0000)]
Rename "register_ethereal_tap()" to "register_tap_listener_cmd_arg()" as
it's used to register a callback for a tap listener invoked if the
specified command line argument is specified to the "-z" flag.

Move it, along with routines to:

look up a "-z" argument in the table constructed by
"register_tap_listener_cmd_arg()" and either save the full
argument to "-z" and the corresponding listener if it's found or
return a failure indication if it isn't;

list the available tap listeners;

call the "init" routines for the tap listeners saved in the
table above;

and have Ethereal and Tethereal use those routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13993 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoEdits, update to current "all GTK+ stuff is common" state.
guy [Fri, 1 Apr 2005 08:47:42 +0000 (08:47 +0000)]
Edits, update to current "all GTK+ stuff is common" state.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13992 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't assume only one "-z" argument will be given on the command line;
guy [Fri, 1 Apr 2005 05:45:08 +0000 (05:45 +0000)]
Don't assume only one "-z" argument will be given on the command line;
add information for each tap to a list, and set up all the taps in the

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13991 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGive the RFC number for IGMPv3.
guy [Fri, 1 Apr 2005 04:19:28 +0000 (04:19 +0000)]
Give the RFC number for IGMPv3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13990 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a couple of "proto_tree_add_text()" calls to pass the right arguments.
guy [Thu, 31 Mar 2005 23:48:08 +0000 (23:48 +0000)]
Fix a couple of "proto_tree_add_text()" calls to pass the right arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13989 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a link to a more recent Apple page describing DSI.
guy [Thu, 31 Mar 2005 22:04:59 +0000 (22:04 +0000)]
Add a link to a more recent Apple page describing DSI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13988 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIncluded packet-gsm_map.h and removed unpack_digits as it now is exported from gsm_ma...
etxrab [Thu, 31 Mar 2005 18:51:14 +0000 (18:51 +0000)]
Included packet-gsm_map.h and removed unpack_digits as it now is exported from gsm_map, as it isn't used
yet no need to regenerate the dissector now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13987 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago From Jacques, Olivier: Length of digit_str wrongly calculated.
etxrab [Thu, 31 Mar 2005 18:41:44 +0000 (18:41 +0000)]
 From Jacques, Olivier: Length of digit_str wrongly calculated.

 Free the string, fix dissection of some elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13986 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jacques, Olivier: Length of digit_str wrongly calculated.
etxrab [Thu, 31 Mar 2005 18:39:45 +0000 (18:39 +0000)]
From Jacques, Olivier: Length of digit_str wrongly calculated.

Free the string, fix dissection of some elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13985 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jacques, Olivier: Length of digit_str wrongly calculated.
etxrab [Thu, 31 Mar 2005 18:34:25 +0000 (18:34 +0000)]
From Jacques, Olivier: Length of digit_str wrongly calculated.

Free the string, fix dissection of some elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13984 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agohttp://www.shaftnet.org/~pizza/software/capturefrm.txt is currently not
guy [Thu, 31 Mar 2005 07:59:43 +0000 (07:59 +0000)]
shaftnet.org/~pizza/software/capturefrm.txt is currently not
available; add an archive.org URL for it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13983 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFurther IE dissection updates.
etxrab [Thu, 31 Mar 2005 04:50:48 +0000 (04:50 +0000)]
Further IE dissection updates.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13982 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSmall bug fix
etxrab [Wed, 30 Mar 2005 19:10:26 +0000 (19:10 +0000)]
Small bug fix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13981 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImprove some debug messages.
etxrab [Wed, 30 Mar 2005 19:09:48 +0000 (19:09 +0000)]
Improve some debug messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13980 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate and small bugfix
etxrab [Wed, 30 Mar 2005 19:08:39 +0000 (19:08 +0000)]
Update and small bugfix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13979 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix the handling of the length parameter in the DATA chunk.
tuexen [Wed, 30 Mar 2005 16:16:07 +0000 (16:16 +0000)]
Fix the handling of the length parameter in the DATA chunk.
This is a quick fix. A systematic follows...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13978 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Ulf Lamping:
etxrab [Wed, 30 Mar 2005 13:37:27 +0000 (13:37 +0000)]
From Ulf Lamping:
Fix a "off by one" error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13977 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Tim
sahlberg [Wed, 30 Mar 2005 09:18:25 +0000 (09:18 +0000)]
From Tim
small bugfix for packet-ber.c if packet is malformed, prevent dereferenceing a null pointer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13976 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake it a bit clearer that what "-w" writes is raw binary packet data,
guy [Wed, 30 Mar 2005 01:06:12 +0000 (01:06 +0000)]
Make it a bit clearer that what "-w" writes is raw binary packet data,
not the result of dissecting that data.

Note that "-F" applies to the output of "-w", that "-S" says "dissect
and print even if you're doing '-w'", and that "-T" applies to the
dissected output, not the "-w" output.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13975 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a tvb_ensure_bytes_exist() and fix a few other offset-related bugs.
gerald [Tue, 29 Mar 2005 22:23:09 +0000 (22:23 +0000)]
Add a tvb_ensure_bytes_exist() and fix a few other offset-related bugs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13974 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Mathieson:
etxrab [Tue, 29 Mar 2005 20:58:03 +0000 (20:58 +0000)]
From Martin Mathieson:
- bump up SDP_MAX_PAYLOAD_TYPES to 20 (I have an mgcp capture where a media
gateway responded with 12 media types, resulting in a crash).  Probably more
care needs to be taken while parsing the list of media types though...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13973 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Mathieson :
etxrab [Tue, 29 Mar 2005 20:56:42 +0000 (20:56 +0000)]
From Martin Mathieson :

- allow dissector to show "MGCP/SDP" in the Protocol column, at least when
the 'Display the number of MGCP messages' preference is switched off
- when displaying the command verb, show in the tree the full verb name as
well as the 4-letter code
- show the links to response and request messages as being [generated]
- fixed some indentation problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13972 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove a g_assert() left over from debugging.
gerald [Tue, 29 Mar 2005 19:52:04 +0000 (19:52 +0000)]
Remove a g_assert() left over from debugging.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13971 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse an offset of 0 in PER_NOT_DECODED_YET() so that we don't generate a
gerald [Tue, 29 Mar 2005 16:11:11 +0000 (16:11 +0000)]
Use an offset of 0 in PER_NOT_DECODED_YET() so that we don't generate a
dissector bug error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13970 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a compiler warning.
gerald [Tue, 29 Mar 2005 16:02:02 +0000 (16:02 +0000)]
Fix a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13969 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a tvb_ensure_bytes_exist().
gerald [Tue, 29 Mar 2005 15:38:11 +0000 (15:38 +0000)]
Add a tvb_ensure_bytes_exist().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13968 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoREADME.developer says:
gerald [Tue, 29 Mar 2005 14:56:09 +0000 (14:56 +0000)]
README.developer says:

"PROTOABBREV     A name for the protocol for use in filter expressions;
                 it should contain only lower-case letters, digits, and

In proto_register_protocol(), generate a warning if PROTOABBREV contains
invalid characters.  Along with the list above, allow underscores and
periods.  Fix up whitespace.

Lower-case PROTOABBREV in several dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13967 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofrom Sid
sahlberg [Tue, 29 Mar 2005 12:36:40 +0000 (12:36 +0000)]
from Sid
updates to FTAM

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13966 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofrom Sid
sahlberg [Tue, 29 Mar 2005 12:27:13 +0000 (12:27 +0000)]
from Sid
bugfix for ACSE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13965 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofrom Lars Ruoff
sahlberg [Tue, 29 Mar 2005 10:58:08 +0000 (10:58 +0000)]
from Lars Ruoff
rtp analysis optimization

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13964 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a tvb_ensure_bytes_exist().
gerald [Mon, 28 Mar 2005 22:35:35 +0000 (22:35 +0000)]
Add a tvb_ensure_bytes_exist().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13963 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agosome minor changes
ulfl [Mon, 28 Mar 2005 21:35:21 +0000 (21:35 +0000)]
some minor changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13962 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfixes: bring non real-time captures back to former behaviour, other minor fixes
ulfl [Mon, 28 Mar 2005 21:05:53 +0000 (21:05 +0000)]
bugfixes: bring non real-time captures back to former behaviour, other minor fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13961 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMinor change to Call-ID dissector to set up object line.
ashokn [Mon, 28 Mar 2005 19:32:39 +0000 (19:32 +0000)]
Minor change to Call-ID dissector to set up object line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13960 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPass a NULL instead of an empty string in the value_string/true_false_string
gerald [Mon, 28 Mar 2005 19:19:19 +0000 (19:19 +0000)]
Pass a NULL instead of an empty string in the value_string/true_false_string
field of hf_rtp_payload_type.  This should fix the "values output" test failures
in the FreeBSD builder.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13959 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix: don't call tvb_length_remaining() if tvb is NULL
ulfl [Mon, 28 Mar 2005 18:08:31 +0000 (18:08 +0000)]
bugfix: don't call tvb_length_remaining() if tvb is NULL
but what to do instead?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13958 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agovarious (minor) capture code cleanup
ulfl [Mon, 28 Mar 2005 18:04:09 +0000 (18:04 +0000)]
various (minor) capture code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13957 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix Solaris build (I've removed O_BINARY)
ulfl [Mon, 28 Mar 2005 16:14:34 +0000 (16:14 +0000)]
fix Solaris build (I've removed O_BINARY)

rename sync_mode to real_time_mode, as we using sync_mode all the time now, so the name is misleading

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13956 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn tvb_get_string(), throw an exception if our length is less than zero.
gerald [Mon, 28 Mar 2005 15:55:47 +0000 (15:55 +0000)]
In tvb_get_string(), throw an exception if our length is less than zero.

Add a message block length check to the AIM dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13955 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremove capture_child flag from capture_opts as it's no longer required
ulfl [Mon, 28 Mar 2005 15:31:13 +0000 (15:31 +0000)]
remove capture_child flag from capture_opts as it's no longer required

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13954 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoa lot more capture engine code cleanup
ulfl [Mon, 28 Mar 2005 14:39:31 +0000 (14:39 +0000)]
a lot more capture engine code cleanup

most notably:

- moved opening of safe_file to the capture child (capture_loop.c)
- removed save_file_fd from capture_opts (no longer need to have it global)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13953 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe "cf" field of a "capture_options" structure is a "void *" and, in
guy [Mon, 28 Mar 2005 03:08:29 +0000 (03:08 +0000)]
The "cf" field of a "capture_options" structure is a "void *" and, in
practice, it points to a "capture_file" structure; print it with "%p",
not "%s".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13952 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe "application_context_version" variables in the CAMEL and GSM MAP
guy [Mon, 28 Mar 2005 02:53:49 +0000 (02:53 +0000)]
The "application_context_version" variables in the CAMEL and GSM MAP
dissectors aren't needed outside the dissectors, and having more than
one of them exported causes build problems, at least on OS X - make them

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13951 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake hf_oampdu_info_state_parser "BASE_HEX" instead of "8", so that we don't
gerald [Mon, 28 Mar 2005 02:03:45 +0000 (02:03 +0000)]
Make hf_oampdu_info_state_parser "BASE_HEX" instead of "8", so that we don't
throw an assertion in hfinfo_uint_vals_format().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13950 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomajor capture engine rework: use two task model for EVERY capture mode
ulfl [Mon, 28 Mar 2005 00:19:02 +0000 (00:19 +0000)]
major capture engine rework: use two task model for EVERY capture mode

rework of the -b command line parameter (for Ethereal and Tethereal)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13949 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomake skinny compile again
sahlberg [Sun, 27 Mar 2005 22:56:32 +0000 (22:56 +0000)]
make skinny compile again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13948 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a typo
etxrab [Sun, 27 Mar 2005 22:11:09 +0000 (22:11 +0000)]
Fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13947 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd Jacques, Olivier as the Camel dissector author.
etxrab [Sun, 27 Mar 2005 21:53:28 +0000 (21:53 +0000)]
Add Jacques, Olivier as the Camel dissector author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13946 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jacques, Olivier:
etxrab [Sun, 27 Mar 2005 21:44:26 +0000 (21:44 +0000)]
From Jacques, Olivier:
Camel dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13945 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of an unused variabnle
etxrab [Sun, 27 Mar 2005 21:40:27 +0000 (21:40 +0000)]
Get rid of an unused variabnle

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13944 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jacques, Olivier:
etxrab [Sun, 27 Mar 2005 21:39:38 +0000 (21:39 +0000)]
From Jacques, Olivier:
The patch attached fixes it by creating a table of unique files at the
time of file deletion. This way, current asn2eth behaviour is not

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13943 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago From Alejandro Vaquero :
etxrab [Sun, 27 Mar 2005 21:37:05 +0000 (21:37 +0000)]
 From  Alejandro Vaquero :
 Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13942 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrevious commit failed doing them one by one.
etxrab [Sun, 27 Mar 2005 21:14:48 +0000 (21:14 +0000)]
Previous commit failed doing them one by one.
 From  Alejandro Vaquero :
 Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13941 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrevious commit failed doing them one by one.
etxrab [Sun, 27 Mar 2005 21:14:15 +0000 (21:14 +0000)]
Previous commit failed doing them one by one.
 From  Alejandro Vaquero :
 Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13940 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrevious commit failed doing them one by one.
etxrab [Sun, 27 Mar 2005 21:12:39 +0000 (21:12 +0000)]
Previous commit failed doing them one by one.
 From  Alejandro Vaquero :
 Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13939 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrevious commit failed doing them one by one.
etxrab [Sun, 27 Mar 2005 21:11:48 +0000 (21:11 +0000)]
Previous commit failed doing them one by one.
 From  Alejandro Vaquero :
 Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13938 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse the new table for dynamic payload types.
etxrab [Sun, 27 Mar 2005 21:01:21 +0000 (21:01 +0000)]
Use the new table for dynamic payload types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13937 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Alejandro Vaquero :
etxrab [Sun, 27 Mar 2005 20:55:14 +0000 (20:55 +0000)]
From  Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13936 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Alejandro Vaquero :
etxrab [Sun, 27 Mar 2005 20:54:18 +0000 (20:54 +0000)]
From  Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13935 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Alejandro Vaquero :
etxrab [Sun, 27 Mar 2005 20:53:15 +0000 (20:53 +0000)]
From  Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13934 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: add another tvb_ensure_bytes_exist()
ulfl [Sun, 27 Mar 2005 12:28:03 +0000 (12:28 +0000)]
buildbot bugfix: add another tvb_ensure_bytes_exist()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13933 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: add another tvb_ensure_bytes_exist()
ulfl [Sun, 27 Mar 2005 10:53:14 +0000 (10:53 +0000)]
buildbot bugfix: add another tvb_ensure_bytes_exist()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13932 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd SCTP and MEGACO types, so that we can add SCTP to the "random" test.
gerald [Sun, 27 Mar 2005 04:43:49 +0000 (04:43 +0000)]
Add SCTP and MEGACO types, so that we can add SCTP to the "random" test.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13931 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix of a bug causing tethereal value output to fail:
ulfl [Sun, 27 Mar 2005 02:40:05 +0000 (02:40 +0000)]
bugfix of a bug causing tethereal value output to fail:

value_string's must be terminated with { 0, NULL }!!!

...seems I've missed one place in my last commit!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13930 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd a new checkitem "Colorize Packet List" into the View menu
ulfl [Sun, 27 Mar 2005 02:19:51 +0000 (02:19 +0000)]
add a new checkitem "Colorize Packet List" into the View menu

keep it's setting in the recent file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13929 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix of a bug causing tethereal value output to fail:
ulfl [Sun, 27 Mar 2005 01:18:06 +0000 (01:18 +0000)]
bugfix of a bug causing tethereal value output to fail:

value_string's must be terminated with { 0, NULL }!!!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13928 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: add another tvb_ensure_bytes_exist (tvb,offset,length);
ulfl [Sun, 27 Mar 2005 01:02:29 +0000 (01:02 +0000)]
buildbot bugfix: add another tvb_ensure_bytes_exist (tvb,offset,length);

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13927 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a note about doing checks before subtracting, for example, the
guy [Sat, 26 Mar 2005 23:31:35 +0000 (23:31 +0000)]
Add a note about doing checks before subtracting, for example, the
length of a fixed-length header from the length of the item with that
fixed-length header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13926 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake sure we have enough bytes in our tvbuff to dissect our header.
gerald [Sat, 26 Mar 2005 23:02:24 +0000 (23:02 +0000)]
Make sure we have enough bytes in our tvbuff to dissect our header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13925 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate the URL for draft-stewart-sctp-pktdrprep to the -02 draft.
guy [Sat, 26 Mar 2005 21:31:13 +0000 (21:31 +0000)]
Update the URL for draft-stewart-sctp-pktdrprep to the -02 draft.

Clean up indentation.

Have the main loop for dissecting chunks check that the chunk size is
large enough for the chunk header, and have it pass the chunk size,
minus the size of the chunk header, to dissectors for particular chunk
types.  Make those dissectors check that value to make sure it's large
enough for any fixed-length portion before subtracting the length of
that portion and using the result as a remaining data length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13924 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix some typos + decode more IE stuff
etxrab [Sat, 26 Mar 2005 19:55:46 +0000 (19:55 +0000)]
Fix some typos + decode more IE stuff

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13923 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a bug reported by Soi Hon Lo octet 6x and 7 not read from tvb.
etxrab [Sat, 26 Mar 2005 19:09:05 +0000 (19:09 +0000)]
Fix a bug reported by Soi Hon Lo octet 6x and 7 not read from tvb.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13922 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: another (un-)signed problem and a problem with the offset (fixed...
ulfl [Sat, 26 Mar 2005 12:10:58 +0000 (12:10 +0000)]
buildbot bugfix: another (un-)signed problem and a problem with the offset (fixed by calling tvb_ensure...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13921 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomove some color_filter related things from file.c to color_filters.c
ulfl [Sat, 26 Mar 2005 11:32:43 +0000 (11:32 +0000)]
move some color_filter related things from file.c to color_filters.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13920 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd rules to build xml_lexer.c, and to remove it with "make distclean",
guy [Sat, 26 Mar 2005 10:48:38 +0000 (10:48 +0000)]
Add rules to build xml_lexer.c, and to remove it with "make distclean",
modeled after the rules in epan/dfilter/Makefile.nmake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13919 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWith the recent change that makes the length field for FT_PROTOCOL and
guy [Sat, 26 Mar 2005 04:04:37 +0000 (04:04 +0000)]
With the recent change that makes the length field for FT_PROTOCOL and
FT_NONE be, in effect, unsigned, it's no longer necessary to check for a
so-large-it-doesn't-fit-in-a-signed-value length for items of those types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13918 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of boilerplate.
guy [Sat, 26 Mar 2005 03:56:54 +0000 (03:56 +0000)]
Get rid of boilerplate.

Use "tvb_ensure_bytes_exist()" to check for some invalid lengths.

Add some comments about possible problems in the code.

Get rid of an unnecessary length check (the length is the sum of a small
constant and a value extracted from a single byte, so the sum won't

For a FCP_RSP, make the top-level protocol tree item run to the end of
the tvbuff and then set its length when we finish dissecting it (if we
throw an exception and don't get around to setting the length, that
means that we hit the end of the tvbuff before we hit the end of the
item).  Add some checks to catch too-large length fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13917 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd xml_lexer.c to the list of files to ignore, as it's a generated
guy [Sat, 26 Mar 2005 03:34:58 +0000 (03:34 +0000)]
Add xml_lexer.c to the list of files to ignore, as it's a generated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13916 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoxml_lexer.c is generated by Flex; we don't put files generated by Flex
guy [Sat, 26 Mar 2005 03:30:08 +0000 (03:30 +0000)]
xml_lexer.c is generated by Flex; we don't put files generated by Flex
into the SVN tree, we just put the files from which they're generated
into the SVN tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13915 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThere's no need to create a directory just because you're about to
guy [Sat, 26 Mar 2005 03:27:46 +0000 (03:27 +0000)]
There's no need to create a directory just because you're about to
remove a file in it - the directory presumably exists already, if you're
about to remove a file in it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13914 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFor protocol tree items of type FT_NONE and FT_PROTOCOL, treat negative
guy [Sat, 26 Mar 2005 03:27:22 +0000 (03:27 +0000)]
For protocol tree items of type FT_NONE and FT_PROTOCOL, treat negative
length values (other than -1) as very large positive values, and for
values larger than the amount of data remaining in the tvbuff, clip the
value to the length of the tvbuff, so that dissectors don't have to
worry about doing that clipping themselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13913 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: if a length value is below zero, trim it to zero
ulfl [Sat, 26 Mar 2005 03:03:43 +0000 (03:03 +0000)]
buildbot bugfix: if a length value is below zero, trim it to zero

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13912 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: another (un-)signed one
ulfl [Sat, 26 Mar 2005 01:23:39 +0000 (01:23 +0000)]
buildbot bugfix: another (un-)signed one

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13911 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocode cleanup: use common prefix for all functions in color_filters.h
ulfl [Sat, 26 Mar 2005 01:09:14 +0000 (01:09 +0000)]
code cleanup: use common prefix for all functions in color_filters.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13910 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCreate the directory for the preferences files before writing out the
guy [Sat, 26 Mar 2005 01:05:29 +0000 (01:05 +0000)]
Create the directory for the preferences files before writing out the
"recent" file.

Have "write_recent()" handle putting up error windows for failed
attempts to write the "recent" file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13909 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd some length checks to the CHAP dissector.
guy [Sat, 26 Mar 2005 00:15:19 +0000 (00:15 +0000)]
Add some length checks to the CHAP dissector.

Use %u, not %d, to display unsigned values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13908 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: yet another (un-)signed problem.
ulfl [Fri, 25 Mar 2005 23:44:49 +0000 (23:44 +0000)]
buildbot bugfix: yet another (un-)signed problem.

Guy, you may have a look to add some "invalid" message to the tree in this case

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13907 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobuildbot bugfix: and again, a guint16 will never become lower than zero
ulfl [Fri, 25 Mar 2005 23:12:07 +0000 (23:12 +0000)]
buildbot bugfix: and again, a guint16 will never become lower than zero

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13906 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocode cleanup: the term filter_list was used with different meanings throughout the...
ulfl [Fri, 25 Mar 2005 22:52:45 +0000 (22:52 +0000)]
code cleanup: the term filter_list was used with different meanings throughout the code, and the filter_list of the color_filters is "global".

use appropriate prefixes to avoid confusion and bugs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13905 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agojxta updates
sahlberg [Fri, 25 Mar 2005 22:37:58 +0000 (22:37 +0000)]
jxta updates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13904 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdates to SAMR
sahlberg [Fri, 25 Mar 2005 22:27:37 +0000 (22:27 +0000)]
updates to SAMR
from Michael richardson

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13903 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix: prevent a negative length, if ah.ah_len is zero
ulfl [Fri, 25 Mar 2005 21:19:18 +0000 (21:19 +0000)]
bugfix: prevent a negative length, if ah.ah_len is zero

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13902 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFor the Bandwidth Allocation Protocol Phone Delta option:
guy [Fri, 25 Mar 2005 20:12:27 +0000 (20:12 +0000)]
For the Bandwidth Allocation Protocol Phone Delta option:

the length of a suboption must be at least 2;

the length of the Unique Digit option must be 3, and its name is
"Unique Digit", not "Uniq Digit";

the length of the other suboptions must be at least 3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13901 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn the cases fixed by the two previous fixes, check to make sure the
guy [Fri, 25 Mar 2005 19:52:51 +0000 (19:52 +0000)]
In the cases fixed by the two previous fixes, check to make sure the
items don't run past the length left in the option, and, if they do, put
an indication into the protocol tree that they did.

The length returned by "tvb_strsize()" includes the terminating null

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13900 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd checks to make sure the packet length hasn't overflowed in a couple of
gerald [Fri, 25 Mar 2005 19:44:09 +0000 (19:44 +0000)]
Add checks to make sure the packet length hasn't overflowed in a couple of

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13899 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobugfix: similar problem than the previous one fixed by Gerald
ulfl [Fri, 25 Mar 2005 17:24:48 +0000 (17:24 +0000)]
bugfix: similar problem than the previous one fixed by Gerald

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13898 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoKeep the length value from rolling over in CBCP. Add a comment asking if
gerald [Fri, 25 Mar 2005 17:04:00 +0000 (17:04 +0000)]
Keep the length value from rolling over in CBCP.  Add a comment asking if
there's a better way to do this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13897 f5534014-38df-0310-8fa8-9805f1628bb7