obnox/wireshark/wip.git
18 years agoAdd radius_dict.c to DISTCLEAN
jmayer [Sun, 17 Jul 2005 13:55:46 +0000 (13:55 +0000)]
Add radius_dict.c to DISTCLEAN

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14945 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd radius_dict.c to the distclean target, don't know how to do this for Makefile.am
ulfl [Sun, 17 Jul 2005 13:39:24 +0000 (13:39 +0000)]
add radius_dict.c to the distclean target, don't know how to do this for Makefile.am

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14944 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIt's "svn:keywords", not "svn:keyword".
guy [Sun, 17 Jul 2005 08:41:07 +0000 (08:41 +0000)]
It's "svn:keywords", not "svn:keyword".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14943 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix the RCS ID.
guy [Sun, 17 Jul 2005 08:39:51 +0000 (08:39 +0000)]
Fix the RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14942 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate to the new per signatures.
etxrab [Sat, 16 Jul 2005 21:34:19 +0000 (21:34 +0000)]
Update to the new per signatures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14941 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRemove some unused variables.
etxrab [Sat, 16 Jul 2005 19:59:21 +0000 (19:59 +0000)]
Remove some unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14940 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRemove an unused export
etxrab [Sat, 16 Jul 2005 19:58:23 +0000 (19:58 +0000)]
Remove an unused export

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14939 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoList the new "packet-radius.h" file so it's included in the tarball.
guy [Sat, 16 Jul 2005 06:20:56 +0000 (06:20 +0000)]
List the new "packet-radius.h" file so it's included in the tarball.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14938 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of the newline between "radius:" and the error when trying to
guy [Sat, 16 Jul 2005 01:55:58 +0000 (01:55 +0000)]
Get rid of the newline between "radius:" and the error when trying to
read the RADIUS directory.

The error string from "radius_load_dictionary()" is g_malloced; free it,
and g_strdup the "Could not find the radius directory" error, so we
don't have to worry about constant vs. g_malloced strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14937 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoThrow in some casts to squelch warnings, at least with some compilers
guy [Sat, 16 Jul 2005 01:33:22 +0000 (01:33 +0000)]
Throw in some casts to squelch warnings, at least with some compilers
(the values are const because nobody's supposed to modify them once
they've been allocated, but they *can* be freed - by us - when we're
done with them).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14936 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agonew protocol
sahlberg [Sat, 16 Jul 2005 01:04:36 +0000 (01:04 +0000)]
new protocol

RFC3770   Wlan Certificate Extensions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14935 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIt's "plugins", not "Plugins".
guy [Sat, 16 Jul 2005 00:45:22 +0000 (00:45 +0000)]
It's "plugins", not "Plugins".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14934 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoepan/dissectors/packet-gtp.h has rung down the curtain and joined the
guy [Sat, 16 Jul 2005 00:37:44 +0000 (00:37 +0000)]
epan/dissectors/packet-gtp.h has rung down the curtain and joined the
Choir Invisible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14933 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix the name of the "svn:keywords" property.
guy [Sat, 16 Jul 2005 00:27:53 +0000 (00:27 +0000)]
Fix the name of the "svn:keywords" property.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14932 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix the RCS ID.
guy [Sat, 16 Jul 2005 00:26:07 +0000 (00:26 +0000)]
Fix the RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14931 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agocomments are ";" not ":"
lego [Fri, 15 Jul 2005 22:36:21 +0000 (22:36 +0000)]
comments are ";" not ":"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14930 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agopropset and fix the filename
lego [Fri, 15 Jul 2005 21:45:34 +0000 (21:45 +0000)]
propset and fix the filename

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14929 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoforgot to add the (c) notice
lego [Fri, 15 Jul 2005 21:41:47 +0000 (21:41 +0000)]
forgot to add the (c) notice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14928 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoregister the dissector by name
lego [Fri, 15 Jul 2005 21:32:12 +0000 (21:32 +0000)]
register the dissector by name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14927 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRadius Dictionary Support
lego [Fri, 15 Jul 2005 21:18:32 +0000 (21:18 +0000)]
Radius Dictionary Support
Part 3: the makefiles

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14926 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRadius Dictionary Support
lego [Fri, 15 Jul 2005 21:12:27 +0000 (21:12 +0000)]
Radius Dictionary Support
Part 2: the code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14925 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRadius dictionary support
lego [Fri, 15 Jul 2005 21:03:13 +0000 (21:03 +0000)]
Radius dictionary support
Part 1: the dictionary

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14924 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPoint to the latest Windows library tag and versions.
gerald [Fri, 15 Jul 2005 20:50:34 +0000 (20:50 +0000)]
Point to the latest Windows library tag and versions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14923 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdare Id, and a comment.
etxrab [Fri, 15 Jul 2005 20:26:36 +0000 (20:26 +0000)]
Updare Id, and a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14922 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- PER helper functions for SET/SEQUENCE OF dissection were changed to have prototype...
kukosa [Fri, 15 Jul 2005 15:20:40 +0000 (15:20 +0000)]
- PER helper functions for SET/SEQUENCE OF dissection were changed to have prototype similar to BER (per_sequence_t is used as parameter)
- asn2eth was updated to support new PER helper functions for SET/SEQUENCE OF
- #.FN_PARS implemented for SET/SEQUENCE OF and REAL
- PER SET/SEQUENCE OF field can be FT_UINTxx to display number of items
- PER dissectors regenerated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14921 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake io-stat able to do SUM(*) for FT_RELATIVE_TIME fields
sahlberg [Fri, 15 Jul 2005 08:29:26 +0000 (08:29 +0000)]
make io-stat able to do SUM(*) for FT_RELATIVE_TIME fields

Example:   SUM(tcp.analysis.rto)
so one can plot the total amount of time that TCP sessions were idle due to waiting for a retransmission to occur.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14920 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agominor change: add TcpdumpManpage entity
ulfl [Thu, 14 Jul 2005 21:45:18 +0000 (21:45 +0000)]
minor change: add TcpdumpManpage entity

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14919 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPacket-gtp.c - Fix up decoding of the rest of the IE:s use routines from packet-gsm_a.c
etxrab [Thu, 14 Jul 2005 21:05:38 +0000 (21:05 +0000)]
Packet-gtp.c - Fix up decoding of the rest of the IE:s use routines from packet-gsm_a.c
Packet-uma.c Let packet-gsm_a handle som IE dissection.
Packet-gsm.a add some IE dissection and export some routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14918 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoISAKMP version2 has changed the payload format of a CertificateRequest.
sahlberg [Thu, 14 Jul 2005 08:10:30 +0000 (08:10 +0000)]
ISAKMP version2   has changed the payload format of a CertificateRequest.

In version 2 this is just a concatenation of 20 byte SHA-1 hashes with no other encxapsulation.

this resolves bug 281

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14917 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomoduleinfo.h was included twice.
jmayer [Thu, 14 Jul 2005 08:03:59 +0000 (08:03 +0000)]
moduleinfo.h was included twice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14916 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a string
lego [Wed, 13 Jul 2005 23:40:06 +0000 (23:40 +0000)]
fix a string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14915 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Ilya Konstantinov :
etxrab [Wed, 13 Jul 2005 21:38:07 +0000 (21:38 +0000)]
From Ilya Konstantinov :
fixes a tiny bug which caused the boolean fields not to refer to the same offset as their
parent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14914 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoconvert two other autogenerated dissectors to use FT_GUID
sahlberg [Wed, 13 Jul 2005 08:24:05 +0000 (08:24 +0000)]
convert two other autogenerated dissectors to use FT_GUID

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14913 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake idl2eth generate FT_GUID hf fields for uuid_t and GUID types.
sahlberg [Wed, 13 Jul 2005 08:00:15 +0000 (08:00 +0000)]
make idl2eth generate FT_GUID hf fields for uuid_t and GUID types.

make dissect_dcerpc_uuid_t() accept eitehr FT_STRING (old style) and FT_GUID (new style) hf fields. once all dissectors are modified to use FT_GUID we can remove the FT_STRING support here.

regenerate the DRSUAPI interface with the new FT_GUID support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14912 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Ilya Konstantinov :
etxrab [Wed, 13 Jul 2005 05:06:38 +0000 (05:06 +0000)]
From Ilya Konstantinov :
 A patch to the AIM dissector to support Client Auto Response messages. I still don't know the meaning of all the fields as they weren't all mapped but this patch decodes all the important ones.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14911 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agocode cleanup: use "correct" proto_tree_add_... functions for li and tpdu code fields
ulfl [Tue, 12 Jul 2005 21:21:14 +0000 (21:21 +0000)]
code cleanup: use "correct" proto_tree_add_... functions for li and tpdu code fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14910 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoadd some more textual explanations of the protocol and it's fields
ulfl [Tue, 12 Jul 2005 21:09:34 +0000 (21:09 +0000)]
add some more textual explanations of the protocol and it's fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14909 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Irene Ruengeler: Handle multiple gap reports correctly and use correct name...
tuexen [Tue, 12 Jul 2005 21:04:05 +0000 (21:04 +0000)]
From Irene Ruengeler: Handle multiple gap reports correctly and use correct name of a button.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14908 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix decoding of quintuplets.
etxrab [Tue, 12 Jul 2005 20:30:33 +0000 (20:30 +0000)]
Fix decoding of quintuplets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14907 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate svn:ignore
jmayer [Tue, 12 Jul 2005 17:08:17 +0000 (17:08 +0000)]
Update svn:ignore
        Add register.c-tmp
        Remove duplicate tags and TAGS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14906 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd value for FCS (no decoding).
jmayer [Tue, 12 Jul 2005 17:06:09 +0000 (17:06 +0000)]
Add value for FCS (no decoding).
Fix a signedness warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14905 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoRemove/replace SPACES at the beginning of Makefile.am/Makefile.common
jmayer [Tue, 12 Jul 2005 12:44:42 +0000 (12:44 +0000)]
Remove/replace SPACES at the beginning of Makefile.am/Makefile.common
files as not all make implementation work with this.

Found by running
grep '^ ' `find . -name "Makefile.am" -o -name "Makefile.common"`

Gerald: Maybe adding this to the buildbot would be a good idea after all.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14904 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix some more signed vs. unsigned warnings.
guy [Tue, 12 Jul 2005 01:01:19 +0000 (01:01 +0000)]
Fix some more signed vs. unsigned warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14903 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIn NTLMSP_AUTH messages, include the domain name and user name in the
guy [Mon, 11 Jul 2005 22:48:51 +0000 (22:48 +0000)]
In NTLMSP_AUTH messages, include the domain name and user name in the
Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14902 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd Jeremy j Ouellette
etxrab [Mon, 11 Jul 2005 22:27:20 +0000 (22:27 +0000)]
Add Jeremy j Ouellette

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14901 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDIS dissection
etxrab [Mon, 11 Jul 2005 22:23:57 +0000 (22:23 +0000)]
DIS dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14900 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Jeremy j Ouellette:
etxrab [Mon, 11 Jul 2005 22:23:15 +0000 (22:23 +0000)]
From Jeremy j Ouellette:
DIS dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14899 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix a syntax error in the "Routing" rule, reported by Jeff Morriss
ulfl [Mon, 11 Jul 2005 20:14:43 +0000 (20:14 +0000)]
fix a syntax error in the "Routing" rule, reported by Jeff Morriss

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14898 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDissect some more fields
etxrab [Mon, 11 Jul 2005 19:25:25 +0000 (19:25 +0000)]
Dissect some more fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14897 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDissect some more fields
etxrab [Mon, 11 Jul 2005 19:24:30 +0000 (19:24 +0000)]
Dissect some more fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14896 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoJust pass &cfile to select_tcpip_session(); we don't need to pass
guy [Sun, 10 Jul 2005 18:29:43 +0000 (18:29 +0000)]
Just pass &cfile to select_tcpip_session(); we don't need to pass
cfile.current_frame to it separately.

Note that we shouldn't ever get a "Selected packet isn't a TCP segment"
error any more; we can now handle all link layers.

Give a little more detail in the message shown if there's *more than
one* TCP header in the packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14895 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix some comment typos.
guy [Sun, 10 Jul 2005 10:10:40 +0000 (10:10 +0000)]
Fix some comment typos.

Don't regenerate the packet list when generating the TCP stream graph -
it won't be changing; just redissect and run the tap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14894 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoPut the data (print job contents) in LPD requests under the LPD protocol
guy [Sun, 10 Jul 2005 09:26:20 +0000 (09:26 +0000)]
Put the data (print job contents) in LPD requests under the LPD protocol
item, rather than making it a top-level item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14893 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of an unused argument.
guy [Sun, 10 Jul 2005 09:21:57 +0000 (09:21 +0000)]
Get rid of an unused argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14892 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAfter doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
jmayer [Sun, 10 Jul 2005 08:04:27 +0000 (08:04 +0000)]
After doing "make maintainer-clean", "svn status --no-ignore | grep ^I"
returned quite a list of files. Add them to MAINTAINERCLEANFILES.

Whitespace changes (replace multiple spaces by TABs, in a few cases this
needed to be done at the beginning of Makefile lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14891 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFor packets flagged as Retransmission
sahlberg [Sun, 10 Jul 2005 05:27:38 +0000 (05:27 +0000)]
For packets flagged as Retransmission

calculate RTO as the delta between the retransmitted frame and the last previous frame seen for this session (in the same direction).

while this is technically not the RTO  this delta is in most cases more important/useful than the tru RTO anyway since this measure represents the amount of thiime that the link went idle  while waiting for an RTO.

It would be nice with a statistics tap for TCP where one couls see, seeion by session :
Length in time of the session.
Total bytes transferred
Number of retransmissions
Time spent waiting for an RTO
Time spent waiting for an RTO in % of the total time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14890 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoIt works reasonably well with extensive testing so here goes :
sahlberg [Sun, 10 Jul 2005 02:59:50 +0000 (02:59 +0000)]
It works reasonably well with extensive testing so here goes :

tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file.

This makes tcp graph work for any type of capture and for any transport.

In the future someone with access to captures with TCP over something over TCP
to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14889 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMSVC: fix some guint64 related compiler errors
ulfl [Sat, 9 Jul 2005 11:28:13 +0000 (11:28 +0000)]
MSVC: fix some guint64 related compiler errors

strange enough, MSVC cannot convert from guint64 to float, so cast guint64 -> gint64 -> float

However, even gint64 might be big enough to prevent us from an overflow :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14888 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMSVC: fix some guint64 related compiler warnings, could someone please review my...
ulfl [Sat, 9 Jul 2005 11:26:46 +0000 (11:26 +0000)]
MSVC: fix some guint64 related compiler warnings, could someone please review my comment(s), I don't think it's currently implemented correct

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14887 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake a bunch of items in encryption code arrays of guint8, and make some
guy [Sat, 9 Jul 2005 03:25:25 +0000 (03:25 +0000)]
Make a bunch of items in encryption code arrays of guint8, and make some
pointers either "void *" or "guint8 *", to reduce the level of compiler
warnings (the data in question is largely binary in those cases).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14886 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix up a bunch of arguments to "dissect_ber_identifier()" to match its
guy [Sat, 9 Jul 2005 02:58:07 +0000 (02:58 +0000)]
Fix up a bunch of arguments to "dissect_ber_identifier()" to match its
current signature ("class" is a "gint8 *", not a "guint8 *", and "tag"
is a "gint32 *", not a "guint32 *").  Re-generate the dissectors from
the ASN.1 and the .cnf files in the cases where the arguments were fixed
in a .cnf file.

Give some dissectors the right svn:keywords and svn:eol-style settings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14885 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch various signed vs. unsigned warnings by:
guy [Sat, 9 Jul 2005 00:53:17 +0000 (00:53 +0000)]
Squelch various signed vs. unsigned warnings by:

making pointers to byte data be "guint8 *" rather than "char *",
and making buffers holding byte data arrays of "guint8" rather
than arrays of "char";

making pointers to text strings "char *" rather than "guchar *";

appropriately casting pointers (cast to "guint8 *" when passing
to routines expecting "guint8 *" or when assigning to "guint8
*");

making port-number preferences "guint";

making enum preferences "gint";

making hf_ variables "int".

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14884 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMAC addresses are arrays of bytes, not strings; make the destination MAC
guy [Sat, 9 Jul 2005 00:47:57 +0000 (00:47 +0000)]
MAC addresses are arrays of bytes, not strings; make the destination MAC
address an array of guint8 - that squelches some compiler warnings.

Use -1 rather than tvb_length(tvb) to make the item for LWAPP go to the
end of the tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14883 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFind the BitTorrent dissector immediately after registering it, and save
guy [Sat, 9 Jul 2005 00:44:44 +0000 (00:44 +0000)]
Find the BitTorrent dissector immediately after registering it, and save
the handle, rather than finding it every time we need it.

Just make a guint8 array with the BitTorrent magic string length
followed by the string, and use "tvb_memeql()" to test against that - it
handles checking to make sure there's enough data in the tvbuff (if
not, it returns -1 as a "no match" indication) and then checks all of
the first 20 bytes in one operation.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14882 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUse "tvb_get_string()" rather than duplicating its functionality by
guy [Sat, 9 Jul 2005 00:35:13 +0000 (00:35 +0000)]
Use "tvb_get_string()" rather than duplicating its functionality by
hand.

Use "g_strdup()" rather than duplicating its functionality by hand.

Make the magic number an array of "guint8", as "tvb_memeql()" expects a
pointer to "guint8".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14881 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agochecksum messages: use "[correct]" instead of "(correct)" and other "alike" messages
ulfl [Fri, 8 Jul 2005 22:11:13 +0000 (22:11 +0000)]
checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14880 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoUpdate the EDG screenshots to reflect the latest Ethereal GUI changes
ulfl [Fri, 8 Jul 2005 22:04:35 +0000 (22:04 +0000)]
Update the EDG screenshots to reflect the latest Ethereal GUI changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14879 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some missing IMPLICIT tags, and use FN_PARS directive.
etxrab [Fri, 8 Jul 2005 20:01:11 +0000 (20:01 +0000)]
Add some missing IMPLICIT tags, and use FN_PARS directive.

Add disection of some RR elements and command Handover.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14878 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd some missing IMPLICIT tags, and use FN_PARS directive.
etxrab [Fri, 8 Jul 2005 19:59:56 +0000 (19:59 +0000)]
Add some missing IMPLICIT tags, and use FN_PARS directive.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14877 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a crash reported by Jeff Morris.
tuexen [Fri, 8 Jul 2005 11:47:59 +0000 (11:47 +0000)]
Fix a crash reported by Jeff Morris.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14876 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake the counters in the summary 64-bit, so they don't overflow on
guy [Fri, 8 Jul 2005 09:12:11 +0000 (09:12 +0000)]
Make the counters in the summary 64-bit, so they don't overflow on
Really Big Captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14875 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGet rid of most unused arguments and variables (including some that are
guy [Fri, 8 Jul 2005 02:31:45 +0000 (02:31 +0000)]
Get rid of most unused arguments and variables (including some that are
set but not used).  (Leave "pi" around so the warning acts as a reminder
that the tap structure stuff needs a cleanup - currently, the tap
structures aren't freed; perhaps the new memory allocation scheme
proposed by Ronnie could be used for tap structures.)

Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace
packets and return the packet type for actrace packets, so that we don't
need a global variable for the packet type.

Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned
warning.

Use "col_set_str()" rather than "col_add_str()" when setting the
Protocol column.

We don't recognized packets as CAS packets unless they're 48 bytes long,
so we don't need to test whether they're 48 bytes long in the CAS packet
dissection code.

Use the reported length, not the captured length, when doing length
checks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14874 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake nettl file header items containing strings "gchar", to squelch
guy [Fri, 8 Jul 2005 02:21:16 +0000 (02:21 +0000)]
Make nettl file header items containing strings "gchar", to squelch
signed vs. unsigned compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14873 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomake the packets/bytes counters 64bit integers to not wrap when using really large...
sahlberg [Thu, 7 Jul 2005 22:24:28 +0000 (22:24 +0000)]
make the packets/bytes counters 64bit integers to not wrap when using really large captures.

setting packet counter to 64bit is overkill but makes it consistent with the very similar bytes counter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14872 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoMake sure "which" is present before we verify our tools. Add "env" to
gerald [Thu, 7 Jul 2005 21:26:09 +0000 (21:26 +0000)]
Make sure "which" is present before we verify our tools.  Add "env" to
the list of programs to check.  Make sure our python scripts start with
"#!/usr/bin/env python" as recommended at

  http://www.python.org/doc/faq/library.html#how-do-i-make-a-python-script-executable-on-unix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14871 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd parlay.dll and tango.dll to the installer.
etxrab [Thu, 7 Jul 2005 19:48:06 +0000 (19:48 +0000)]
Add parlay.dll and tango.dll to the installer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14870 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoavoid few warnings from asn2eth compiler
kukosa [Thu, 7 Jul 2005 05:45:51 +0000 (05:45 +0000)]
avoid few warnings from asn2eth compiler

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14869 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoSquelch a compiler pointer vs. integer warning - NULL is for pointers,
guy [Thu, 7 Jul 2005 04:05:01 +0000 (04:05 +0000)]
Squelch a compiler pointer vs.  integer warning - NULL is for pointers,
'\0' is for characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14868 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
guy [Thu, 7 Jul 2005 04:03:35 +0000 (04:03 +0000)]
Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
warnings.  Use SET_ADDRESS in the VOIP calls code, rather than
explicitly filling in "pstn_add".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14867 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoExplicitly initialize all the elements of a voip_calls_tapinfo_t, to
guy [Thu, 7 Jul 2005 03:20:43 +0000 (03:20 +0000)]
Explicitly initialize all the elements of a voip_calls_tapinfo_t, to
squelch a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14866 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFix a spelling error.
guy [Wed, 6 Jul 2005 23:55:19 +0000 (23:55 +0000)]
Fix a spelling error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14865 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomore usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter
kukosa [Wed, 6 Jul 2005 16:19:34 +0000 (16:19 +0000)]
more usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14864 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- #.FN_PARS implemented for BOOLEAN
kukosa [Wed, 6 Jul 2005 16:15:12 +0000 (16:15 +0000)]
- #.FN_PARS implemented for BOOLEAN
- user defined body #.FN_BODY can be combined with default body using DEFAULT_BODY parameter (see e.g. H.225)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14863 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoReplace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch
jmayer [Tue, 5 Jul 2005 22:58:00 +0000 (22:58 +0000)]
Replace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14862 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agofix *several* dissector bugs, found by private fuzz-tests
ulfl [Tue, 5 Jul 2005 22:33:22 +0000 (22:33 +0000)]
fix *several* dissector bugs, found by private fuzz-tests

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14861 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agonew directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors...
kukosa [Tue, 5 Jul 2005 21:42:13 +0000 (21:42 +0000)]
new directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors with new_dissector_t prototype

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14860 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoCall proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274,
gerald [Tue, 5 Jul 2005 20:20:15 +0000 (20:20 +0000)]
Call proto_tree_add_guid_hidden() for an FT_GUID value.  Fixes bugs 274,
276, and 277.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14859 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoDon't crash if we're handed a zero-length fragment. Fixes bug 272. Although
gerald [Tue, 5 Jul 2005 20:04:03 +0000 (20:04 +0000)]
Don't crash if we're handed a zero-length fragment.  Fixes bug 272.  Although
we don't crash now, we still don't handle zero-length fragments correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14858 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agomore usage of #.FN_PARS
kukosa [Tue, 5 Jul 2005 19:53:38 +0000 (19:53 +0000)]
more usage of #.FN_PARS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14857 f5534014-38df-0310-8fa8-9805f1628bb7

18 years ago- #.FN_PARS support for ENUMERATED type
kukosa [Tue, 5 Jul 2005 19:47:04 +0000 (19:47 +0000)]
- #.FN_PARS support for ENUMERATED type
- cleanup unused parameters for some methods

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14856 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoGUID lowercase form seems to be preferred
kukosa [Tue, 5 Jul 2005 18:55:17 +0000 (18:55 +0000)]
GUID lowercase form seems to be preferred

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14855 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd application/vnd.wv.csp.xml
etxrab [Tue, 5 Jul 2005 17:10:09 +0000 (17:10 +0000)]
Add application/vnd.wv.csp.xml

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14854 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd application/vnd.wv.csp.xml
etxrab [Tue, 5 Jul 2005 17:09:28 +0000 (17:09 +0000)]
Add application/vnd.wv.csp.xml

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14853 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Alejandro Vaquero
etxrab [Tue, 5 Jul 2005 05:16:28 +0000 (05:16 +0000)]
From Alejandro Vaquero

- avoid the clist of the calls dlg to be refreshed multiple times when
first appear.
- destroy the Graph window when the data is not valid anymore.
- fixes an H245 packet count error
- resizing the Graph windows when is displayed (up to 5 columns).
With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct =
{0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0};
alone.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14852 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom : David Frascone
etxrab [Tue, 5 Jul 2005 04:32:32 +0000 (04:32 +0000)]
From : David Frascone

These minor changes fix some errors, and add some messages to the LWAPP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14851 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoFrom Ainsley Pereira:
etxrab [Tue, 5 Jul 2005 04:30:59 +0000 (04:30 +0000)]
From Ainsley Pereira:

If you have an RTP stream in which the first packet is duplicated, and has the marker bit set, then the RTP stream analysis will try to pad silence into a temporary file from 0 upto whatever the RTP timestamp is (which is enough to fill up my disk...). The  patch fixes this misbehaviour.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14850 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
etxrab [Mon, 4 Jul 2005 19:09:38 +0000 (19:09 +0000)]
Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14849 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoAdd dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
etxrab [Mon, 4 Jul 2005 19:07:02 +0000 (19:07 +0000)]
Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14848 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agousage of FT_GUID field type in H.225 dissector
kukosa [Mon, 4 Jul 2005 13:19:58 +0000 (13:19 +0000)]
usage of FT_GUID field type in H.225 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14847 f5534014-38df-0310-8fa8-9805f1628bb7

18 years agoexport of proto_tree_add_guid...() functions
kukosa [Mon, 4 Jul 2005 13:13:07 +0000 (13:13 +0000)]
export of proto_tree_add_guid...() functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14846 f5534014-38df-0310-8fa8-9805f1628bb7