guy [Thu, 20 Apr 2000 07:05:58 +0000 (07:05 +0000)]
Have the IPv6 dissector use the same dissector table as the IPv4
dissector.
Don't dissect the payload of any fragmented IPv6 packet unless it's the
initial fragment (that's what we do for IPv4).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1882
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 20 Apr 2000 02:18:53 +0000 (02:18 +0000)]
Microsoft Proxy protocol dissector from Jeff Foster.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1881
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 19 Apr 2000 03:28:07 +0000 (03:28 +0000)]
Greg Kilfoyle <gregk@redback.com>'s change for detection of compressed
A/C PPP fields.
Get rid of spurious printf() in packet.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1880
f5534014-38df-0310-8fa8-
9805f1628bb7
deniel [Tue, 18 Apr 2000 18:01:50 +0000 (18:01 +0000)]
Fix the checksum option decoding in the CC/CR TPDU variable part.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1879
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 18 Apr 2000 04:46:07 +0000 (04:46 +0000)]
In the NCP dissector, construct conversations using the source and
destination network-layer addresses of the servers, and the NCP
connection number, and use the pointer to the conversation and the
request sequence number as the hash key for the table of requests used
to find the request for a given response; this lets it work with
NCP-over-TCP and NCP-over-UDP.
Register the NCP dissector with the UDP dissector in the handoff
registration routine for NCP, just as we do with the TCP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1878
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 17 Apr 2000 14:52:32 +0000 (14:52 +0000)]
Remove optopt and opterr, two unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1877
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 17 Apr 2000 04:00:36 +0000 (04:00 +0000)]
Don't rely on the "tree" argument being null as an indication that this
is the first time we've looked at a packet; it may not be null if, for
example, we're doing read filtering, or if we're colorizing packets, or
if there are plugins active, or if this is Tethereal with the "-V" flag.
Instead, use the new "visited" flag.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1876
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 17 Apr 2000 02:47:43 +0000 (02:47 +0000)]
Tweak a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1875
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 17 Apr 2000 02:39:55 +0000 (02:39 +0000)]
Make "decode_tcp_ports()" and "decode_udp_ports()" more closely resemble
one another, put the comments that explain what they do in front of
them, and clean up the indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1874
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 17 Apr 2000 01:36:31 +0000 (01:36 +0000)]
Register an "osinl" dissector table for ISO/IEC TR 9577 NLPID values,
and have dissectors for protocols that run at the OSI network layer
register themselves with it using "dissector_add()".
Make various dissectors static if they can be, and remove from header
files declarations of those dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1873
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 17 Apr 2000 00:32:43 +0000 (00:32 +0000)]
Register a "llc.dsap" dissector table for 802.2 LLC, and have dissectors
for protocols that run inside 802.2 LLC register themselves with it
using "dissector_add()".
Make various dissectors static if they can be, and remove from header
files declarations of those dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1872
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 16 Apr 2000 22:59:37 +0000 (22:59 +0000)]
Make various dissectors static if they can be, and get rid of any header
files that no longer contain any information as a result of that change.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1871
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 16 Apr 2000 22:46:25 +0000 (22:46 +0000)]
Register an "ip.proto" dissector table for IPv4, and have dissectors for
protocols that run inside IPv4 register themselves with it using
"dissector_add()".
Make various dissectors static if they can be, and get rid of any header
files that no longer contain any information as a result of that change.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1870
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 16 Apr 2000 21:37:07 +0000 (21:37 +0000)]
Register a "ppp.protocol" dissector table for PPP, and have dissectors
for protocols that run inside PPP register themselves with it using
"dissector_add()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1869
f5534014-38df-0310-8fa8-
9805f1628bb7
deniel [Sun, 16 Apr 2000 09:10:53 +0000 (09:10 +0000)]
Remove TODO comments about NSAP and ISIS decodings since
this is implemented now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1868
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 16 Apr 2000 08:58:55 +0000 (08:58 +0000)]
Ralf Schneider's changes to enhance to OSI CLNP, CLTP, and ISIS support
and to add OSI ESIS support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1867
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Sun, 16 Apr 2000 04:56:40 +0000 (04:56 +0000)]
Fix up the allocation stuff for the per frame data ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1866
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 22:11:26 +0000 (22:11 +0000)]
Ralf Schneider's changes to enhance to OSI CLNP, CLTP, and ISIS support
and to add OSI ESIS support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1865
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 21:27:12 +0000 (21:27 +0000)]
In the COTP dissector, don't forcibly set the protocol to COTP if we
find a COTP PDU - we might have called a subdissector, which would have
set the protocol itself. Do so only if we've not seen any DT PDUs on
which we've called a subdissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1864
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 21:12:37 +0000 (21:12 +0000)]
Get rid of the "start" field in the private data for RADCOM, i4btrace,
and nettl captures - a "start" field is used for capture files where the
time stamps on packets are relative to some initial time stamp, e.g. the
time the capture started, but those file formats use absolute time
stamps, so no "start" field is needed.
Make the "this is an HP-UX 11.x nettl capture" flag a member of the
private data structure for a nettl capture, rather than a global - it's
per-capture-file state.
Once the "start" field is removed from the RADCOM private data
structure, there's nothing left, so eliminate the private data
structure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1863
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 19:55:24 +0000 (19:55 +0000)]
Graham Bloice's Win32 icon for Ethereal and Win32 resource-compiler
files to add version/copyright/etc. information to Win32 executables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1862
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 07:26:57 +0000 (07:26 +0000)]
Alas, one can't count on CLNP packets with a destination NSEL of 0x21
being COTP packets, so we make "dissect_cotp_internal()" return FALSE if
it saw no valid COTP packets, and return TRUE and set the COL_PROTOCOL
field to COTP if it saw at least one valid COTP packet, and have
"dissect_cotp()" dissect the packet as raw data if
"dissect_cotp_internal()" returns FALSE (for the benefit of callers such
as X.25).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1861
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 06:47:43 +0000 (06:47 +0000)]
If an NPDU contains multiple concatenated TPDUs, dissect all of them.
Fix up some spacing problems in the INFO field of CLNP packets.
Dissect only the payload of DT and MD NPDUs as COTP; the payload of
other packets isn't to be so dissected (ER NPDUs are like ICMP error
packets, in that they contain the network-layer header and zero or more
bytes of the payload of the offending packet, for example).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1860
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 04:10:50 +0000 (04:10 +0000)]
Graham Bloice's Win32 icon for Ethereal and Win32 resource-compiler
files to add version/copyright/etc. information to Win32 executables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1859
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 15 Apr 2000 02:26:17 +0000 (02:26 +0000)]
Changes from Richard Sharpe to improve the display of FTP data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1858
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Apr 2000 09:00:25 +0000 (09:00 +0000)]
On Win32, build Ethereal as a Windows-subsystem program rather than a
console-subsystem program, so that when not run from a shell window it
doesn't cause a shell window to be popped up. (Yes, this means that any
messages it prints, when not popped up from a shell window, get lost,
but the same is true of Ethereal on UNIX/X.) Trick for doing this
shamelessly stolen from the Win32 port of the GIMP.
We do not want to build Tethereal or editcap as Windows-subsystem
programs, however, so we take the "/SUBSYSTEM" flag out of LDFLAGS and
put it into the link commands for Ethereal, Tethereal, and editcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1857
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Apr 2000 06:42:52 +0000 (06:42 +0000)]
Register all the AFS ports in "proto_reg_handoff_rx()", rather than
checking for them in the UDP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1856
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 14 Apr 2000 06:17:23 +0000 (06:17 +0000)]
RFC 1058, on RIP V1, says:
Specific queries and debugging requests may be sent from ports
other than 520, but they are directed to port 520 on the target
machine.
and RFC 2453, on RIP V2, says:
Specific queries may be sent from ports other than the RIP port,
but they must be directed to the RIP port on the target machine.
so there is no requirement that RIP packets have 520 as both source and
destination port numbers. It's therefore OK to register it as the
dissector for UDP port 520 - no need to handle it specially in the UDP
dissector as a reminder to make it check both source and destination
ports - so we do so.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1855
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 14 Apr 2000 05:39:43 +0000 (05:39 +0000)]
Change dfilter_apply() to 4-argument function. 4th argument is not yet used,
but will be in the future, and it's easier for me to keep my local branch
in sync with the source with the calls to dfilter_apply() already modified
tothe 4-arg format.
Add a CPP macro to ipv4.h to define ipv4_addr_ne(). Use it in dfilter.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1854
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 13 Apr 2000 21:16:22 +0000 (21:16 +0000)]
Missed a few things in the DHIS to DDTP name change.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1853
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 13 Apr 2000 21:08:16 +0000 (21:08 +0000)]
Renamed packet-dhis to packet-ddtp.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1852
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 13 Apr 2000 21:03:56 +0000 (21:03 +0000)]
Renamed the DHIS protocol to DDTP (Dynamic DNS Tools Protocol).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1851
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 13 Apr 2000 20:39:38 +0000 (20:39 +0000)]
Consolidate flags in struct frame_data, and add "visited" flag. Use
it in SOCKS dissector.
(Okay, how many times am I going to modify packet.h today, forcing you
to re-compile everything? :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1850
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 13 Apr 2000 19:38:55 +0000 (19:38 +0000)]
Re-insert 4 #include lines to get capture_*() function prototypes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1849
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 13 Apr 2000 18:18:56 +0000 (18:18 +0000)]
Change the sub-dissector handoff registration routines so that the
sub-dissector table is not stored in the header_field_info struct, but
in a separate namespace. Dissector tables are now registered by name
and not by field ID. For example:
udp_dissector_table = register_dissector_table("udp.port");
Because of this different namespace, dissector tables can have names
that are not field names. This is useful for ethertype, since multiple
fields are "ethertypes".
packet-ethertype.c replaces ethertype.c (the name was changed so that it
would be named in the same fashion as all the filenames passed to make-reg-dotc)
Although it registers no protocol or field, it registers one dissector table:
ethertype_dissector_table = register_dissector_table("ethertype");
All protocols that can be called because of an ethertype field now register
that fact with dissector_add() calls.
In this way, one dissector_table services all ethertype fields
(hf_eth_type, hf_llc_type, hf_null_etype, hf_vlan_etype)
Furthermore, the code allows for names of protocols to exist in the
etype_vals, yet a dissector for that protocol doesn't exist. The name
of the dissector is printed in COL_INFO. You're welcome, Richard. :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1848
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 13 Apr 2000 11:20:49 +0000 (11:20 +0000)]
Add last minute changes.
Fix statement about Win32 version not capturing in README.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1846
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 13 Apr 2000 11:11:38 +0000 (11:11 +0000)]
Remove extra space before "Port" in proto_tree label.
Add packet-socks.obj to Makefile.nmake.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1845
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 09:17:09 +0000 (09:17 +0000)]
As we always have to have a filter string (thanks to a bug in the Linux
libpcap), if we have a null filter string we report it as "no filter",
just as we would do for a null filter string pointer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1844
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 09:03:32 +0000 (09:03 +0000)]
Update to reflect the current state of the Win32 libpcap.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1843
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 08:14:35 +0000 (08:14 +0000)]
Set the COL_PROTOCOL column to "ISIS" in the ISIS dissector, rather than
in its caller.
Set the COL_PROTOCOL column to "COTP" in the COTP dissector, rather than
in the dissectors it calls, so that it's done for all frames we hand to
that dissector.
Set the COL_INFO field for COTP packets we don't dissect because the
length indicator is zero, or the frame is too short, or the PDU type is
bogus.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1842
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 07:52:55 +0000 (07:52 +0000)]
Add CLNP PDU types other than DT and ER.
Fix the TPDU code numeric value to be "0x%x" rather than "Ox%x".
Add a COL_INFO field for CLNP PDUs whose payload we don't dissect as
COTP.
Don't dissect segments other than the first derived PDU of a segmented
CLNP PDU (just as we do with fragments other than the first fragment of
a fragmented IP datagram).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1841
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 06:26:31 +0000 (06:26 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1840
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 06:09:35 +0000 (06:09 +0000)]
Fix a typo.
Use "%u" rather than a hex format to print length values and segment
offsets, and use "%u" rather than "%d" to print unsigned values.
In the CLNP dissector, chop off the payload and captured-payload lengths
based on the segment length (along the lines of what we do for IP).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1839
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 13 Apr 2000 02:36:35 +0000 (02:36 +0000)]
For I and S frames, the LLC control field is 2 bytes, so make it
FT_UINT16 (that won't break things for U frames, where it's 1 byte).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1838
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Apr 2000 22:53:16 +0000 (22:53 +0000)]
Jeff Foster's SOCKS dissector, support for associating dissectors
with conversations and having TCP and UDP check whether a packet is part
of a conversation with a dissector and, if so, using that dissector on
the conversation, and "ethertype()"-style support for allowing a
dissector to call a sub-dissector via the same path that the TCP and UDP
dissectors use, based on port numbers supplied by that dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1837
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 12 Apr 2000 21:52:11 +0000 (21:52 +0000)]
Build tethereal and editcap on Win32.
Add RCS ID tags to Makefile.nmake's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1836
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Apr 2000 21:42:31 +0000 (21:42 +0000)]
A further update from Mark Muhlestein.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1835
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 12 Apr 2000 21:02:51 +0000 (21:02 +0000)]
Move to version 0.8.7.
I'm going to go ahead and install the plugins in a "0.8.7" directory, and
continue incrementing the micro number until the minor version changes to 9.
Then for all of 0.9.x, the plugin directory will be "0.9" until the ABI
changes again. This should cause less confusion, even if it means the
plugins don't change between 0.8.6 and 0.8.7.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1834
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Apr 2000 20:47:46 +0000 (20:47 +0000)]
Ben Fowler's additions to exclude more files from "cvs diff" and the
like.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1833
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Apr 2000 20:43:53 +0000 (20:43 +0000)]
Mark Muhlestein's code to support CIFS-atop-TCP (without the NetBIOS
Session Service).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1832
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 12 Apr 2000 20:24:43 +0000 (20:24 +0000)]
Change my e-mail address from @tivoli.com to @xiexie.org
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1831
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 12 Apr 2000 06:59:28 +0000 (06:59 +0000)]
Catch "loops" in compressed DNS names the same way the BSD DNS resolver,
and BIND, do, by counting the number of characters we look at and, if
when we see a pointer, we see we've already looked at as many characters
as there are in the DNS packet, we conclude that we're looping.
Also, check for pointers that point past the end of the packet (not just
past the end of the captured portion of the packet, i.e. cases where we
didn't capture all of the packet, but cases where the packet is actually
malformed).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1830
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 11 Apr 2000 16:07:40 +0000 (16:07 +0000)]
Have proto_tree_set_boolean() call proto_tree_set_uint() so that
bit shifting is handled correctly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1829
f5534014-38df-0310-8fa8-
9805f1628bb7
itojun [Tue, 11 Apr 2000 14:21:37 +0000 (14:21 +0000)]
BGP confederations support (RFC1965).
From: Greg Hankins <gregh@twoguys.org>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1828
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 10 Apr 2000 18:40:13 +0000 (18:40 +0000)]
Have separate global variables for the current "File:Open" and
"File:Save {As}" dialog boxes, if any.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1827
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 10 Apr 2000 14:45:30 +0000 (14:45 +0000)]
Add DOCSIS BPDU patch from Johannes Hennecke <Johannes.Hennecke@elsa.de>.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1826
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 9 Apr 2000 18:33:26 +0000 (18:33 +0000)]
The "llc_ctrl_vals[]" value_string table isn't used to generate the
protocol tree text for the control field - that protocol tree entry is
added by "dissect_xdlc_control()", which uses
"proto_tree_add_uint_format()" - and it's not a simple enumerated field
(which is why "proto_tree_add_uint_format()" is used, to show all the
various bits of the field). Eliminate it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1825
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Apr 2000 07:55:11 +0000 (07:55 +0000)]
The "llc_ctrl_vals[]" value_string table isn't used to generate the
protocol tree text for the control field - that protocol tree entry is
added by "dissect_xdlc_control()", which uses
"proto_tree_add_uint_format()" - and it's not a simple enumerated field
(which is why "proto_tree_add_uint_format()" is used, to more fully
describe the field). Eliminate it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1824
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Apr 2000 07:07:42 +0000 (07:07 +0000)]
Move calls to "dissector_add()" out of the register routines for TCP and
UDP and into the handoff registration routines for the protocols in
question.
Make the dissectors for those protocols static if they're not called
outside the dissector's source file.
Get rid of header files if all they did was declare dissectors that are
now static; remove declarations of now-static dissectors from header
files that do more than just declare the dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1823
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Apr 2000 03:32:10 +0000 (03:32 +0000)]
Jeff Foster's rlogin dissector, and changes to the TCP dissector to
export the urgent pointer (as the rlogin dissector needs it).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1822
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Sat, 8 Apr 2000 01:28:13 +0000 (01:28 +0000)]
Minor update to SMB browse display code ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1821
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 8 Apr 2000 01:16:52 +0000 (01:16 +0000)]
Declare, in "wtap.h", Richard's new "wtap_read()" function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1820
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Sat, 8 Apr 2000 00:33:04 +0000 (00:33 +0000)]
Some stuff, like libdencode, needs a wiretap routine that allows
them to simply read through the capture file ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1819
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Apr 2000 19:10:51 +0000 (19:10 +0000)]
Avoid using zero-length arrays - they're an extension that only some
compilers support, and at least some versions of HP's PA-RISC C
compiler, for example (which people do use to compile Ethereal), don't
support them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1818
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 7 Apr 2000 15:37:59 +0000 (15:37 +0000)]
Disable "Update list of packets in real tiem" and
"Automatic scrolling in live capture" for Win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1817
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 7 Apr 2000 10:22:20 +0000 (10:22 +0000)]
Patch for multiple %doc lines in RPM spec file.
From Patrick Higgins <phiggins@transzap.com>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1816
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Apr 2000 08:00:34 +0000 (08:00 +0000)]
When searching for a frame that matches a filter expression, we
shouldn't stop the search as soon as we get back to the starting frame,
we should stop the search if the filter expression doesn't match and the
frame we tried it on was the starting frame - it's OK if we find the
starting frame, it's just not OK to continue if we don't find that
frame.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1815
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 7 Apr 2000 07:48:15 +0000 (07:48 +0000)]
Plug a memory leak in the "Find Frame" code - we weren't freeing the
protocol tree after checking whether it matched the filter we supplied.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1814
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 7 Apr 2000 03:18:08 +0000 (03:18 +0000)]
Move to version 0.8.6.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1812
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Apr 2000 06:52:10 +0000 (06:52 +0000)]
Define "popup_menu_object" only in "gtk/menu.c", and just declare it as
an "extern" in "gtk/menu.h", to avoid complaints from the linker on some
platforms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1810
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Apr 2000 06:38:24 +0000 (06:38 +0000)]
Update the document to reflect Gilbert's changes to split
"proto_tree_add_item_format()" into multiple routines for different item
types, and to note that a subtree can be added under any item.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1809
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Apr 2000 06:19:42 +0000 (06:19 +0000)]
Use the "-o" flag, rather than using the "-t" flag and redirecting the
standard output, in the rules to get Flex to produce scanner code; that
way, if Flex fails to run for some reason, we don't leave around a
zero-length or otherwise incorrect "XXX-scanner.c" file that might
keep a subsequent make from thinking it has to generate that file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1808
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Apr 2000 06:18:50 +0000 (06:18 +0000)]
Fix a typo in the rules to make "dfilter-grammar.c" and
"dfilter-grammar.h".
Use the "-o" flag, rather than using the "-t" flag and redirecting the
standard output, in the rules to get Flex to produce scanner code; that
way, if Flex fails to run for some reason, we don't leave around a
zero-length or otherwise incorrect "XXX-scanner.c" file that might
keep a subsequent make from thinking it has to generate that file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1807
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Apr 2000 06:04:24 +0000 (06:04 +0000)]
After destroying the mem chunk for the packet list, null out the pointer
pointing to it, so that if we call "close_cap_file()" again, we don't
try to destroy an already-destroyed mem chunk.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1806
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 6 Apr 2000 03:59:28 +0000 (03:59 +0000)]
Add in an include of "snprintf.h" on platforms where it's necessary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1805
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 5 Apr 2000 16:01:39 +0000 (16:01 +0000)]
Add Attribute Tunnel-Password, from Florian Lohoff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1804
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 5 Apr 2000 15:57:04 +0000 (15:57 +0000)]
Spelling fix from Florian Lohoff
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1803
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 5 Apr 2000 11:53:30 +0000 (11:53 +0000)]
Update version and plugin directory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1801
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 5 Apr 2000 11:45:50 +0000 (11:45 +0000)]
Plugin API is at version 0.8.5 (reflected in directory name for plugins)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1800
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 5 Apr 2000 11:04:46 +0000 (11:04 +0000)]
Packaging fixes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1799
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Tue, 4 Apr 2000 22:26:36 +0000 (22:26 +0000)]
Add a test to check if there is at least one enabled plugin before searching
the plugin list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1798
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 21:46:29 +0000 (21:46 +0000)]
Add "dissector_add()" to the list of routines exported to plugins via
the Big Function Pointer Table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1797
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 21:07:33 +0000 (21:07 +0000)]
Add some additional notes about
building GTK+/GLib with 64-bit integer support when using HP's C
compiler;
libpcap;
from Jost Martin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1796
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 4 Apr 2000 19:47:20 +0000 (19:47 +0000)]
Move to version 0.8.5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1795
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 4 Apr 2000 17:07:07 +0000 (17:07 +0000)]
Add assertions from Ben Fowler <wapdev@leedsnet.com>.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1794
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 4 Apr 2000 16:33:57 +0000 (16:33 +0000)]
Add #include "plugins.h" to get definition of HAVE_PLUGINS
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1793
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 08:25:35 +0000 (08:25 +0000)]
Add "clean" rules in subdirectories, and run subdirectory "nmake -f
Makefile.nmake clean" when "nmake -f Makefile.nmake clean" is done in
the top-level directory, so that "nmake -f Makefile.nmake clean" cleans
everything up.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1792
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 08:22:13 +0000 (08:22 +0000)]
The Win32 port of libpcap requires that programs with which it's built
be built as multi-threaded programs; add "/MT" to the list of compiler
flags.
Add "clean" rules in subdirectories, and run subdirectory "nmake -f
Makefile.nmake clean" when "nmake -f Makefile.nmake clean" is done in
the top-level directory, so that "nmake -f Makefile.nmake clean" cleans
everything up.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1791
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 07:03:07 +0000 (07:03 +0000)]
Turn "ethereal_proto_init()" and "ethereal_proto_cleanup()" into
"dissect_init()" and "dissect_cleanup()", in "packet.c", so that we
don't duplicate those routines in Ethereal and Tethereal (and so on),
and don't have to remember to update N different versions of them if we
have to change the way we do one-time initialization and cleanup.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1790
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 06:46:41 +0000 (06:46 +0000)]
Use the new split between protocol registration and protocol handoff
registration routines to get rid of the special handling of ONC RPC
protocols - dissectors for ONC RPC-based protocols should register their
protocol, fields, and ETT values in a protocol registration routine, and
register themselves with the ONC RPC dissector in their protocol handoff
routine, so that the latter is done after the ONC RPC dissector's
protocol registration routine is called, so that the data structures
needed when dissectors for ONC RPC protocols register themselves with
the ONC RPC dissector have been initialized.
Get rid of "init_dissect_rpc()", which initializes said data structures;
do that in "proto_register_rpc()" instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1789
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 06:17:30 +0000 (06:17 +0000)]
Make "make-reg-dotc" generate a "register_all_protocol_handoffs()"
routine, which calls all routines found in the dissector source files
with names that match " proto_reg_handoff_[a-z_0-9A-Z]*".
Call "register_all_protocol_handoffs()" after calling
"register_all_protocols()" - "register_all_protocols()" needs to be
called first, so that all protocols can register their fields, because
registering a dissector as being called if field "proto.port" is equal
to N requires that "proto.port" be a registered field.
Give DNS a handoff registration routine, and register its dissector to
be called if "udp.port" is UDP_PORT_DNS; remove the registration of DNS
from "packet-udp.c", and make "dissect_dns()" static (as nobody else
need know that it exists).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1788
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 06:10:44 +0000 (06:10 +0000)]
Make "register.c" depend on "$(srcdir)/make-reg-dotc", so that if the
"make-reg-dotc" script is changed, "register.c" is remade (as the change
may change what it generates).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1787
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 05:54:59 +0000 (05:54 +0000)]
Do all the UDP port numbers that we can, and that don't require special
processing (as TFTP does), and don't have comments suggesting that extra
checks are needed, with the port table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1786
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 05:37:36 +0000 (05:37 +0000)]
Make a routine that takes a dissector table, a port number, and
pd/offset/fd/tree arguments, looks up the port number in the dissector
table, and:
if it finds it, call the corresponding dissector routine with
the pd/offset/fd/tree arguments, and return TRUE;
if it doesn't find it, return FALSE.
Use that in the TCP and UDP dissectors.
Don't add arbitrary UDP ports for which a dissector is found in the
table as ports that should be dissected as TFTP; this should only be
done if we find a packet going from port XXX to the official TFTP port.
Don't register TFTP in UDP's dissector table, as it has to be handled
specially (i.e., we have to add the source port as a TFTP port, although
we really should register the source port *and* IP address); eventually,
we should move that registration to the TFTP dissector itself, at which
point we can register TFTP normally.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1785
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 4 Apr 2000 05:14:48 +0000 (05:14 +0000)]
Allocate the new mem chunk for the capture in "open_cap_file()", rather
than duplicating the allocation code in "read_cap_file()" and
"start_tail_cap_file()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1784
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 4 Apr 2000 02:34:40 +0000 (02:34 +0000)]
Rename find_hfinfo_record() to proto_registrar_get_nth() since
all the other public functions in proto.c start with "proto_".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1783
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 3 Apr 2000 22:28:51 +0000 (22:28 +0000)]
Set cf->plist_chunk in the other place where needed. Guy's experiencing
some network problems today, so I checked this in for him.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1782
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 3 Apr 2000 09:41:31 +0000 (09:41 +0000)]
Move the creation of, and registration of protocols known to UDP in, the
hash table attached to "udp.port" out of "init_dissect_udp()" into
"proto_register_udp()", so that it's done the way TCP does it, and then
get rid of "init_dissect_udp()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1781
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 3 Apr 2000 09:37:39 +0000 (09:37 +0000)]
Fix a compile error introduced by the previous checkin, which also moved
the check for plugins after the check for ONC RPC protocols, so that we
do the checks in the same order for TCP and UDP (ONC RPC first, as we
expect the RPC heuristics not to get false hits, and ONC RPC protocols
could well use ports that are nominally assigned to other protocols).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1780
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 3 Apr 2000 09:24:12 +0000 (09:24 +0000)]
Jeff Foster's patch to support attaching a hash table to a protocol
field, to allow dissectors to register their dissection routine in a
particular field's hash table with a particular "port" value, and to
make the TCP and UDP dissectors support that for their "port" field and
to look up ports in that hash table.
This replaces the hash table that the UDP dissector was using.
There's still more work needed to make this useful - right now, the hash
tables are attached to the protocol field in the register routines for
the TCP and UDP protocols, which means that the register routines for
protocols that run atop TCP and UDP can't use this unless their register
routines happen to be called after those for TCP and/or UDP, and several
other protocols need to attach hash tables to fields, and there's no
single global field for Ethernet types so we can't even attach a hash
table to such a field to allow protocols to register themselves with a
particular Ethertype - but it's a start.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1779
f5534014-38df-0310-8fa8-
9805f1628bb7