obnox/wireshark/wip.git
14 years agoFix build
jake [Fri, 17 Nov 2006 07:44:37 +0000 (07:44 +0000)]
Fix build

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19919 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocode cleanup
ulfl [Fri, 17 Nov 2006 03:08:09 +0000 (03:08 +0000)]
code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19918 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImprove the heuristics of the SES dissector some more in response to bug #1229
sfisher [Fri, 17 Nov 2006 01:52:15 +0000 (01:52 +0000)]
Improve the heuristics of the SES dissector some more in response to bug #1229

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19917 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agovarious minor prefs code cleanup
ulfl [Fri, 17 Nov 2006 01:24:03 +0000 (01:24 +0000)]
various minor prefs code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19916 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDavid Young pointed out that we weren't aligning fields according to the
gerald [Thu, 16 Nov 2006 22:27:47 +0000 (22:27 +0000)]
David Young pointed out that we weren't aligning fields according to the
radiotap specification.  Do so.  Add fields for FHSS and Transmit
attenuation (untested).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19915 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoJelmer Vernooij:
jmayer [Thu, 16 Nov 2006 21:57:31 +0000 (21:57 +0000)]
Jelmer Vernooij:

The attached patch replace the use of 'depends()' with "import" (the
latter is a standard IDL statement).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19914 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTemporrary change to force the buildbot to update the libraries as I suspect there...
etxrab [Thu, 16 Nov 2006 21:11:26 +0000 (21:11 +0000)]
Temporrary change to force the buildbot to update the libraries as  I suspect there are left
over old files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19913 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix an annoying behaviour: If we save a capture file, let the default be the current...
ulfl [Thu, 16 Nov 2006 20:13:26 +0000 (20:13 +0000)]
fix an annoying behaviour: If we save a capture file, let the default be the current file format - as we do it in the GTK version. The former implementation just defaulted to libpcap all the time, which is especially ugly if you use a file format that provides nanosecond time resolution - you're losing information :-(

Interestingly the implementation was half way there, but not really working as expected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19912 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago(hopefully) fix the recently discussed warnings where CLAMP() is called with a value...
ulfl [Thu, 16 Nov 2006 20:08:13 +0000 (20:08 +0000)]
(hopefully) fix the recently discussed warnings where CLAMP() is called with a value being 0

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19911 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd comments to the indentation style section.
gerald [Thu, 16 Nov 2006 18:28:09 +0000 (18:28 +0000)]
Add comments to the indentation style section.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19910 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake multipart part a proper field, and append contained content-type to
martinm [Thu, 16 Nov 2006 14:35:52 +0000 (14:35 +0000)]
Make multipart part a proper field, and append contained content-type to
it label to make it easier to find the part you're looking for.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19909 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 948, "Apply capture preferences not applying." Now when the user
sfisher [Thu, 16 Nov 2006 07:04:02 +0000 (07:04 +0000)]
Fix for bug 948, "Apply capture preferences not applying."  Now when the user
changes a capture option in the preferences, it will show up right away in
the capture options dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19908 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a warning
ulfl [Wed, 15 Nov 2006 23:48:56 +0000 (23:48 +0000)]
fix a warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19907 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix a warning
ulfl [Wed, 15 Nov 2006 23:43:16 +0000 (23:43 +0000)]
fix a warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19906 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd a "private_data" pointer to the read_prefs_file() function, which will be "tunnel...
ulfl [Wed, 15 Nov 2006 23:33:39 +0000 (23:33 +0000)]
add a "private_data" pointer to the read_prefs_file() function, which will be "tunneled" to the callback function. This seems to be generally a good idea - as a lot of GLib/GTK function doing similiar and I'll need this for the upcoming update mechanisms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19905 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdding ISC Object Management API dissector
jake [Wed, 15 Nov 2006 20:55:46 +0000 (20:55 +0000)]
Adding ISC Object Management API dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19904 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago solve both issues pointed out in:
lego [Wed, 15 Nov 2006 18:40:37 +0000 (18:40 +0000)]
 solve both issues pointed out in:
    http://wireshark.org/lists/ethereal-dev/200605/msg02351.html

- dtd_parse.l:
   be more liberal on what a name can be (a number now can be a name)

- packet-xml.c
  if proto-name is given use it instead of the root element name as prefix for generated fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19903 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPropset
martinm [Wed, 15 Nov 2006 18:20:03 +0000 (18:20 +0000)]
Propset

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19902 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Olivier Jacques:
martinm [Wed, 15 Nov 2006 17:27:04 +0000 (17:27 +0000)]
From Olivier Jacques:

Here is a DTD for the MSCML protocol, draft-07. This implementation is not entirely up-to-date (draft-09 is out), but this is a good base to start from.

I updated the WIKI with info, snapshot and sample capture: http://wiki.wireshark.org/MSCML

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19901 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd OID translation for some more Generic codecs.
etxrab [Wed, 15 Nov 2006 07:04:22 +0000 (07:04 +0000)]
Add OID translation for some more Generic codecs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19900 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix problem reported on -dev list by Frank Maerz with Wireshark crashing
sfisher [Wed, 15 Nov 2006 06:46:11 +0000 (06:46 +0000)]
Fix problem reported on -dev list by Frank Maerz with Wireshark crashing
when it encountered a proxy http connect to port 80.  This was caused by
the dissector calling itself over and over.  Now if the connect to port is
one of the defined http ports, it calls the data dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19899 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA fix bug #1138: "Follow TCP Streams gets stream direction wrong if started
sfisher [Tue, 14 Nov 2006 22:53:24 +0000 (22:53 +0000)]
A fix bug #1138: "Follow TCP Streams gets stream direction wrong if started
from a server->client frame."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19898 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNew feature to automatically highlight the field found when doing a find.
sfisher [Tue, 14 Nov 2006 22:35:22 +0000 (22:35 +0000)]
New feature to automatically highlight the field found when doing a find.
This works for both string and hex searches.  This resolves feature request
bug #776.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19897 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd svn:ignore to tools/TAGS and plugins/TAGS
sfisher [Tue, 14 Nov 2006 21:28:44 +0000 (21:28 +0000)]
Add svn:ignore to tools/TAGS and plugins/TAGS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19896 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agonikai@nikai.net:
jmayer [Tue, 14 Nov 2006 20:32:29 +0000 (20:32 +0000)]
nikai@nikai.net:

Remaining fixes from:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19895 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agonikai@nikai.net:
jmayer [Tue, 14 Nov 2006 20:08:44 +0000 (20:08 +0000)]
nikai@nikai.net:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

Attempting a simple cleanup of duplicated includes, will attach patch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19894 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodidier gautheron:
jmayer [Tue, 14 Nov 2006 20:01:41 +0000 (20:01 +0000)]
didier gautheron:
idl2wrs.sh is a generated file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19893 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix possible build error + warnings seen on buildbot
martinm [Tue, 14 Nov 2006 13:45:35 +0000 (13:45 +0000)]
Fix possible build error + warnings seen on buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19892 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Use 64-bit indexes into file for packet locations (was previously casting index...
martinm [Tue, 14 Nov 2006 12:06:11 +0000 (12:06 +0000)]
- Use 64-bit indexes into file for packet locations (was previously casting index to and from void*) - this should allow very large files to be used
- The characters between the timestamp and start of data are almost always " l ", optimise memory usage in this case
- Rename hash table for clarity

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19891 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd SIP application AVP:s.
etxrab [Tue, 14 Nov 2006 06:31:47 +0000 (06:31 +0000)]
Add SIP application AVP:s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19890 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd SIP application AVP:s (Incomplete) and sortmobileipv4 in numerical order.
etxrab [Tue, 14 Nov 2006 06:14:20 +0000 (06:14 +0000)]
Add SIP application AVP:s (Incomplete) and sortmobileipv4 in numerical order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19889 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Simon Munton as pointed out by Stephen Fisher:
etxrab [Tue, 14 Nov 2006 06:00:48 +0000 (06:00 +0000)]
From Simon Munton as pointed out by Stephen Fisher:
patch on bug #220 (to main.c.
the second part to packet_list.c was done separately for bug 1159 in rev 19735).  That patch fixes bug #1205 coincidentally.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19888 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom martin Peylo:
etxrab [Tue, 14 Nov 2006 05:49:59 +0000 (05:49 +0000)]
From martin Peylo:
This patch changes the name of "Link Configuration" Packets to "Neighbour Discovery" - as preferred by the creator of TIPC - and shows the TIPC src/dst in the columns instead of the MAC address for those packages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19887 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Stephen Fisher:
etxrab [Tue, 14 Nov 2006 05:47:57 +0000 (05:47 +0000)]
From Stephen Fisher:
a new more accurate fix for bug #1163.  Thanks to Graeme Lunt for pointing out that the first patch broke a different capture with legitimate SES data in it.  My patch also corrects the check for number of bytes existing from 4 to 2 as the minimum length of an SES PDU is only 2 bytes: 1 byte type, 1 byte length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19886 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThis is Gerrit Renker code which:
etxrab [Tue, 14 Nov 2006 05:45:28 +0000 (05:45 +0000)]
This is Gerrit Renker code which:

       * makes checksum computation dependent
         upon the header CsCov field (cf. RFC 4340, 5.1)
       * removes the case where checksums are zero
         (unlike UDP/packet-udp, from which the code stems,
          zero checksums are illegal in DCCP (as in TCP))
       * fixes a minor typo - missing bitshift of the
         CCVal field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19885 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for IPv4-Aggregate session/template/filter types.
ashokn [Mon, 13 Nov 2006 17:30:38 +0000 (17:30 +0000)]
Add support for IPv4-Aggregate session/template/filter types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19884 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSet a transparency threshold for the XPM icons. Have the make-icons script
gerald [Mon, 13 Nov 2006 01:15:56 +0000 (01:15 +0000)]
Set a transparency threshold for the XPM icons.  Have the make-icons script
constify the XPMs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19883 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMark Krochmal says that the class field should be treated in mDNS as a
guy [Sun, 12 Nov 2006 23:42:08 +0000 (23:42 +0000)]
Mark Krochmal says that the class field should be treated in mDNS as a
flag and a 15-bit field even for OPT RRs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19882 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFlag the question as a "QM" question if the QU flag isn't set.
guy [Sun, 12 Nov 2006 22:35:21 +0000 (22:35 +0000)]
Flag the question as a "QM" question if the QU flag isn't set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19881 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to use the latest gtk 2.8 glib and pango libraries.
etxrab [Sun, 12 Nov 2006 22:18:50 +0000 (22:18 +0000)]
Update to use the latest gtk 2.8 glib and pango libraries.
Note from a mail on gtk dev list:
-rwxr-xr-x    1 tml      Administ   224510 Oct  3 18:35 libpango-1.0-0.dll
-rwxr-xr-x    1 tml      Administ    37952 Oct  3 18:35 libpangocairo-1.0-0.dll
-rwxr-xr-x    1 tml      Administ    58749 Oct  3 18:35 libpangowin32-1.0-0.dll

(That's the relevant DLLs from the "bin" folder in Pango 1.14.5, where
the module(s) are built-in into the DLLs, so no
lib/pango/1.5.0/modules folder is needed.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19880 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomDNS treats the class field as a flag bit and 15 bits of class; display
guy [Sun, 12 Nov 2006 22:12:39 +0000 (22:12 +0000)]
mDNS treats the class field as a flag bit and 15 bits of class; display
it as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19879 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a plain "radiotap.channel" field to the radiotap dissector.
gerald [Sun, 12 Nov 2006 00:52:05 +0000 (00:52 +0000)]
Add a plain "radiotap.channel" field to the radiotap dissector.
Check for an invalid channel frequency.  Pass the channel, data rate,
and quality to the 802.11 dissector, so that they show up there
as well.  Clean up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19878 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix so that tcp.pdu.time works again.
sahlberg [Sat, 11 Nov 2006 22:39:25 +0000 (22:39 +0000)]
fix so that tcp.pdu.time works again.
it broken in one of the previous bugfixes to tcp

add a function to print an emem tree to the console for easier emem tree debugging

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19877 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd dissection of PROFINET "MRP Port Status"
ulfl [Sat, 11 Nov 2006 01:29:43 +0000 (01:29 +0000)]
add dissection of PROFINET "MRP Port Status"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19876 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Alex B
sahlberg [Fri, 10 Nov 2006 23:36:57 +0000 (23:36 +0000)]
From Alex B

Added support for upcoming Netapp's ONTAP-GX nfsv3 filehandle.

Alex.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19875 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix for bug 1142
sahlberg [Fri, 10 Nov 2006 20:53:42 +0000 (20:53 +0000)]
fix for bug 1142

if we dont have a content-length   but we do have a keepalive in the header then we should not do reassemble-until-fin.

convert some tvb_get_String into tvb_get_ephemeral_string at the same time

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19874 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix test
martinm [Fri, 10 Nov 2006 12:06:10 +0000 (12:06 +0000)]
Fix test

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19873 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse value_string for info column. Also use fences to handle compound packets
martinm [Thu, 9 Nov 2006 16:46:58 +0000 (16:46 +0000)]
Use value_string for info column.  Also use fences to handle compound packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19872 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake it easier to track user-buffer-space vs capacity requests for HSDPA calls
martinm [Thu, 9 Nov 2006 16:35:12 +0000 (16:35 +0000)]
Make it easier to track user-buffer-space vs capacity requests for HSDPA calls

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19871 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImprove HP Switch Protocol Dissection.
jake [Thu, 9 Nov 2006 12:27:52 +0000 (12:27 +0000)]
Improve HP Switch Protocol Dissection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19870 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSorry that should have been static int. Corrcted now.
etxrab [Wed, 8 Nov 2006 21:28:03 +0000 (21:28 +0000)]
Sorry that should have been static int. Corrcted now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19869 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake Wireshark build on my system (gcc 4.1.0) again
jmayer [Wed, 8 Nov 2006 13:59:46 +0000 (13:59 +0000)]
Make Wireshark build on my system (gcc 4.1.0) again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19868 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse h248v3.asn.
etxrab [Wed, 8 Nov 2006 06:57:29 +0000 (06:57 +0000)]
Use h248v3.asn.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19867 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake things build on my system again
jmayer [Wed, 8 Nov 2006 00:10:09 +0000 (00:10 +0000)]
Make things build on my system again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19866 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe tvb_ensure_length_remaining() calls aren't needed - we want an
guy [Tue, 7 Nov 2006 21:27:52 +0000 (21:27 +0000)]
The tvb_ensure_length_remaining() calls aren't needed - we want an
exception to be thrown if all the data for the icon isn't there, so the
packet gets marked as incomplete.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19865 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert the previous changes - the problem Paul Blankenbaker was fixing
guy [Tue, 7 Nov 2006 21:04:41 +0000 (21:04 +0000)]
Revert the previous changes - the problem Paul Blankenbaker was fixing
was really a problem with bytes_repr_len() and zero-length FT_BYTES
fields, and it's not clear what to do about fields that have zero
length.  (Put in a comment about that.)

Clean up indentation a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19864 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bytes_repr_len() to correctly handle a zero-length FT_BYTES field
guy [Tue, 7 Nov 2006 20:30:34 +0000 (20:30 +0000)]
Fix bytes_repr_len() to correctly handle a zero-length FT_BYTES field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19863 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBased on a change from Paul Blankenbaker, make the "show" attribute for
guy [Tue, 7 Nov 2006 19:49:58 +0000 (19:49 +0000)]
Based on a change from Paul Blankenbaker, make the "show" attribute for
a field an empty string if the field is zero-length; for some reason,
the existing code doesn't handle that correctly.

Also, the NetPDL Visualization Extension:

http://www.nbee.org/Docs/NetPDL/NetPDLVisualization.htm

seems to imply that "value" has to be present, so display it even if the
field is zero-length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19862 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1206
etxrab [Tue, 7 Nov 2006 19:25:59 +0000 (19:25 +0000)]
Fix bug bugs.wireshark.org/bugzilla/show_bug.cgi?id=1206
MEGACO message cannot be decoded correctly for ServiceChange Command
And decoding of serviceChangeReason.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19861 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to describe all that the read routine needs to return, and to
guy [Tue, 7 Nov 2006 19:25:32 +0000 (19:25 +0000)]
Update to describe all that the read routine needs to return, and to
indicate what the seek_read routine needs to do and that you *have* to
have a seek_read routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19860 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix for bug 1200
sahlberg [Tue, 7 Nov 2006 13:19:31 +0000 (13:19 +0000)]
fix for bug 1200

there used to be a bug in tcp reassembly that even if the dissector only asked for x more bytes from the next segment   the entire segment would still be added to reassembly.
this caused some issues when there was a new multisegment pdu that started at the end of the segment   but this bug was fixed when tcp reassembly was refactored semi-recently.

there was also another "bug" in the http reassembly that it would only ask for one more byte at a time when doing reassembly.
this did work well however when we still had the bug in tcp reassembly   but made wireshark become very very very slow once this tcp bug was fixed  since it is very very very slow to reassemble a huge http pdu just one byte at a time.

this patch adds partial support (what we need for http   which does not use tcp_dissect_pdus() ) for the desegmentation flag : DESEGMENT_ONE_MORE_SEGMENT and also to the http dissector   so that reassembly of http headers spanning multiple semgents now become fast again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19859 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnother packet-acn.c leftover
jmayer [Tue, 7 Nov 2006 10:55:12 +0000 (10:55 +0000)]
Another packet-acn.c leftover

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19858 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAs Ulf Lamping notes:
guy [Tue, 7 Nov 2006 09:50:09 +0000 (09:50 +0000)]
As Ulf Lamping notes:

if the pipename argument to cap_pipe_open_live() is null, that's
a bug, and we want a crash so it's caught;

if ld->pcap_h is null in capture_loop_dispatch(), that's a bug,
and we want a crash so it's caught;

if capture_opts is null in capture_loop_start(), that's a bug,
and we want a crash so it's caught;

there's no need to null out capture_opts->save_file twice.

Also, errmsg and secondary_errmsg are null-terminated strings, so the
array size should be the maximum length + 1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19857 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't copy mibs.txt files to mibs, but to snmp\mibs
ulfl [Tue, 7 Nov 2006 09:36:26 +0000 (09:36 +0000)]
don't copy mibs.txt files to mibs, but to snmp\mibs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19856 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Yet Another Portability Recommendation.
guy [Tue, 7 Nov 2006 09:12:30 +0000 (09:12 +0000)]
Add Yet Another Portability Recommendation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19855 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBitfields are bad - the C language spec does *NOT* guarantee which bits
guy [Tue, 7 Nov 2006 09:06:53 +0000 (09:06 +0000)]
Bitfields are bad - the C language spec does *NOT* guarantee which bits
will correspond to which bit fields.  Don't use them.

Use #defines rather than numbers in the appropriate places.

Constify some arguments.

Get rid of C++ comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19854 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoalbert chin:
jmayer [Tue, 7 Nov 2006 08:41:46 +0000 (08:41 +0000)]
albert chin:

version_info.c has:
  #ifdef HAVE_LIBGCRYPT
  #include <gcrypt.h>
  #endif /* HAVE_LIBGCRYPT */

  #ifdef HAVE_LIBGNUTLS
  #include <gnutls/gnutls.h>
  #endif /* HAVE_LIBGNUTLS */

However, Makefile.am doesn't include the necessary CPPFLAGS/LDFLAGS to
resolve symbols from the above. Patch attached.

Note: dumpcap should not need to be linked to gnutls, but that's a
problem with the version infrastructure.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19853 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom albert chin
sahlberg [Tue, 7 Nov 2006 08:33:24 +0000 (08:33 +0000)]
from albert chin

The Solaris C compiler, among others, do not allow anonymous unions.
Patch attached.

thanks albert

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19852 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoYou run perl, not make, on Makefile.PL files.
guy [Tue, 7 Nov 2006 08:19:57 +0000 (08:19 +0000)]
You run perl, not make, on Makefile.PL files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19851 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWarning fix about empty source file
jmayer [Tue, 7 Nov 2006 08:04:11 +0000 (08:04 +0000)]
Warning fix about empty source file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19850 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoregenerate with news pidl
jmayer [Tue, 7 Nov 2006 08:00:30 +0000 (08:00 +0000)]
regenerate with news pidl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19849 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate svn:ignore
jmayer [Tue, 7 Nov 2006 07:58:01 +0000 (07:58 +0000)]
Update svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19848 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to use --includedir instead of copying idl_types.h.
jmayer [Tue, 7 Nov 2006 07:57:07 +0000 (07:57 +0000)]
Update to use --includedir instead of copying idl_types.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19847 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdated to revision 19604.
jmayer [Tue, 7 Nov 2006 07:52:53 +0000 (07:52 +0000)]
Updated to revision 19604.
Update from samba tree revision 19582 to 19604
============================ Samba log start ============
------------------------------------------------------------------------
r19585 | jelmer | 2006-11-06 22:54:19 +0100 (Mon, 06 Nov 2006) | 10 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/ODL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Add support for some more standard IDL instructions:
 - `include' (replaces helper())
 - `import' (replaces depends())

Add support for parsing importlib() - importlib() is now ignored (with a
warning), but no longer causes syntax errors.

helper() and depends() are now marked deprecated and will cause warnings.

------------------------------------------------------------------------
r19588 | jelmer | 2006-11-06 23:54:49 +0100 (Mon, 06 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm

Use include and import statements rather than depends() and helper().

------------------------------------------------------------------------
r19599 | jelmer | 2006-11-07 02:00:27 +0100 (Tue, 07 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm

Fix --includedir.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19846 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWarning fixes (void) instead of (), no newline at end of file.
jmayer [Tue, 7 Nov 2006 07:47:49 +0000 (07:47 +0000)]
Warning fixes (void) instead of (), no newline at end of file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19845 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Albert Chin:
jake [Tue, 7 Nov 2006 07:39:16 +0000 (07:39 +0000)]
From Albert Chin:
Patch attached to convert usage of ntohl() -> g_ntohl(). On HP-UX,
ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there
are other uses of g_ntohl().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19844 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of another ACN reference.
guy [Tue, 7 Nov 2006 00:56:45 +0000 (00:56 +0000)]
Get rid of another ACN reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19843 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of another ACN reference.
guy [Tue, 7 Nov 2006 00:56:04 +0000 (00:56 +0000)]
Get rid of another ACN reference.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19842 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of more ACN plugin references.
guy [Tue, 7 Nov 2006 00:55:14 +0000 (00:55 +0000)]
Get rid of more ACN plugin references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19841 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSplit the ".." and subdirectory into two separate "cd"s, in the hopes of
guy [Tue, 7 Nov 2006 00:54:01 +0000 (00:54 +0000)]
Split the ".." and subdirectory into two separate "cd"s, in the hopes of
reducing the chances that, if a plugin is removed, an extra ".."
reference will be left in.

Get rid of the extra ".."s that were left in when the ACN plugin was
recently removed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19840 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix 1203 as found by stephen fisher
ulfl [Mon, 6 Nov 2006 23:59:49 +0000 (23:59 +0000)]
fix 1203 as found by stephen fisher

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19839 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove ACN references.
gerald [Mon, 6 Nov 2006 23:38:35 +0000 (23:38 +0000)]
Remove ACN references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19838 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix an inadvertent change.
gerald [Mon, 6 Nov 2006 23:08:11 +0000 (23:08 +0000)]
Fix an inadvertent change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19837 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove ACN.
gerald [Mon, 6 Nov 2006 23:04:53 +0000 (23:04 +0000)]
Remove ACN.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19836 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the references to acn
etxrab [Mon, 6 Nov 2006 20:49:47 +0000 (20:49 +0000)]
Remove the references to acn

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19835 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoconvert restrictiontype to be an enum
sahlberg [Mon, 6 Nov 2006 20:47:37 +0000 (20:47 +0000)]
convert restrictiontype to be an enum

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19834 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the references to acn
etxrab [Mon, 6 Nov 2006 20:36:43 +0000 (20:36 +0000)]
Remove the references to acn

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19833 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agobuilding the nspi dissector depends also on the nspi.cnf file, add this dependenc...
sahlberg [Mon, 6 Nov 2006 20:28:19 +0000 (20:28 +0000)]
building the nspi dissector depends also on the  nspi.cnf file,    add this dependency to the makefile

add tracking of policyhandles to the dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19832 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19578 to 19582
jmayer [Mon, 6 Nov 2006 20:21:02 +0000 (20:21 +0000)]
Update from samba tree revision 19578 to 19582
============================ Samba log start ============
------------------------------------------------------------------------
r19580 | jelmer | 2006-11-06 21:01:22 +0100 (Mon, 06 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/pidl

Add --includedir option.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19831 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agonew acn dissector from Bill Florac
sahlberg [Mon, 6 Nov 2006 20:13:32 +0000 (20:13 +0000)]
new acn dissector from Bill Florac

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19830 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix some warnings about missing newline at end of file.
jmayer [Mon, 6 Nov 2006 19:58:06 +0000 (19:58 +0000)]
Fix some warnings about missing newline at end of file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19829 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove some // comments.
jmayer [Mon, 6 Nov 2006 19:56:11 +0000 (19:56 +0000)]
Remove some // comments.
Fix a warning about nested comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19828 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't do forward declarations in the file. I'll try to eventually
jmayer [Mon, 6 Nov 2006 19:53:39 +0000 (19:53 +0000)]
Don't do forward declarations in the file. I'll try to eventually
put this stuff into an external file but just doing a forward
declaration to squelch a compiler warning isn't the way to go - it
needs to be done right one day.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19827 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCopy over the nspi.cnf file which was recently added
jmayer [Mon, 6 Nov 2006 19:47:39 +0000 (19:47 +0000)]
Copy over the nspi.cnf file which was recently added

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19826 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate from samba tree revision 19565 to 19578
jmayer [Mon, 6 Nov 2006 19:44:09 +0000 (19:44 +0000)]
Update from samba tree revision 19565 to 19578
============================ Samba log start ============
------------------------------------------------------------------------
r19572 | jelmer | 2006-11-06 15:07:20 +0100 (Mon, 06 Nov 2006) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm

Fix typo.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19825 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAvoid ${ename}[...] being interpreted as $ename[...].
lego [Mon, 6 Nov 2006 18:16:56 +0000 (18:16 +0000)]
Avoid ${ename}[...] being interpreted as $ename[...].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19824 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd image/wiresharkdoc.ico to the EXTRA_DIST symbol
jake [Mon, 6 Nov 2006 14:20:59 +0000 (14:20 +0000)]
Add image/wiresharkdoc.ico to the EXTRA_DIST symbol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19823 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the executable property from this datafile
jake [Mon, 6 Nov 2006 14:20:03 +0000 (14:20 +0000)]
Remove the executable property from this datafile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19822 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrederic heem:
jmayer [Mon, 6 Nov 2006 14:16:29 +0000 (14:16 +0000)]
frederic heem:
Please find attached a patch to replace "#" with "*".
Check64BitFormat.c.in is a C file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19821 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLet the manifest state that we're Wireshark.
jake [Mon, 6 Nov 2006 12:58:14 +0000 (12:58 +0000)]
Let the manifest state that we're Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19820 f5534014-38df-0310-8fa8-9805f1628bb7