obnox/wireshark/wip.git
11 years agoFix editcap Windows build problem.....
wmeier [Sat, 21 Jun 2008 13:03:18 +0000 (13:03 +0000)]
Fix editcap Windows build problem.....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25501 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom David Moreau (bug 2621):
sake [Sat, 21 Jun 2008 10:04:27 +0000 (10:04 +0000)]
From David Moreau (bug 2621):

add support for MSDP protocol based on TFTP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25500 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Ken Smith (bug 2574): Allow editcap to parse files into even time intervals
sake [Sat, 21 Jun 2008 09:45:21 +0000 (09:45 +0000)]
From Ken Smith (bug 2574): Allow editcap to parse files into even time intervals

A few changes from me:
- make use of nstime_set_unset and nstime_is_unset i.s.o. extra variable first_pass
- change 'if' to 'while' to allow intervals with no packets
- remove 'unused' variable current_pkt_ts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25499 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoPort over the composite tvbuff fixes from /trunk-1.0.
gerald [Fri, 20 Jun 2008 20:33:38 +0000 (20:33 +0000)]
Port over the composite tvbuff fixes from /trunk-1.0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25498 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd a preference for SCTP port.
etxrab [Fri, 20 Jun 2008 16:20:10 +0000 (16:20 +0000)]
Add a preference for SCTP port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25496 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWimax: support TLV type 48 in REG-REQ/REG-RSP.
martinm [Fri, 20 Jun 2008 15:55:32 +0000 (15:55 +0000)]
Wimax: support TLV type 48 in REG-REQ/REG-RSP.

From cfreeer, fixes bug 2571.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25495 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix wimax encoding err when packing subheader present.
martinm [Fri, 20 Jun 2008 10:26:18 +0000 (10:26 +0000)]
Fix wimax encoding err when packing subheader present.

From Frank Wang, fixes bug 2570.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25494 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSupport TLV type 36 in wimax plugin.
martinm [Fri, 20 Jun 2008 10:17:13 +0000 (10:17 +0000)]
Support TLV type 36 in wimax plugin.

From cfreeer (fix for bug 2569).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25493 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agocapture_opts_print_statistics() has nothing to do with capture options
guy [Fri, 20 Jun 2008 00:09:47 +0000 (00:09 +0000)]
capture_opts_print_statistics() has nothing to do with capture options
setting, and is used only in dumpcap.c, and needs to get at information
set by dumpcap's signal handlers so it can respond to ^C; move it to
dumpcap.c, rename it print_statistics_loop(), and make it set ld.go to
TRUE before looping and loop only as long as ld.go is TRUE.

That fixes bug 2592 (at least on Mac OS X, and probably on other UN*Xes;
it should fix it on Windows as well).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25492 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate the statusbar expert info icon when changing profile.
stig [Thu, 19 Jun 2008 21:56:25 +0000 (21:56 +0000)]
Update the statusbar expert info icon when changing profile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25491 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofix BlockError strings
ulfl [Thu, 19 Jun 2008 18:44:23 +0000 (18:44 +0000)]
fix BlockError strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25490 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMake storage-based and time-based "Next file every" checkboxes behave equal
stig [Thu, 19 Jun 2008 17:25:34 +0000 (17:25 +0000)]
Make storage-based and time-based "Next file every" checkboxes behave equal
in "Use multiple files".  Also default to storage-based if not time-based.

This fixes the initial problem in bug #2599.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25489 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIf ENBname is a string append that string.
etxrab [Thu, 19 Jun 2008 16:03:15 +0000 (16:03 +0000)]
If ENBname is a string append that string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25488 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoExport the tvb_get_bits functions.
etxrab [Thu, 19 Jun 2008 14:39:43 +0000 (14:39 +0000)]
Export the tvb_get_bits functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25487 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd an expert item warning if a full sequence isn't decoded. ( take 2)
etxrab [Thu, 19 Jun 2008 14:19:13 +0000 (14:19 +0000)]
Add an expert item warning if a full sequence isn't decoded. ( take 2)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25486 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInitialize new_offset.
stig [Thu, 19 Jun 2008 12:36:30 +0000 (12:36 +0000)]
Initialize new_offset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25485 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd an expert item warning if a full sequence isn't decoded.
etxrab [Thu, 19 Jun 2008 12:16:26 +0000 (12:16 +0000)]
Add an expert item warning if a full sequence isn't decoded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25484 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDo not overwrite existing files when copying dependencies, as this will
stig [Wed, 18 Jun 2008 22:47:58 +0000 (22:47 +0000)]
Do not overwrite existing files when copying dependencies, as this will
overwrite the wireshark libs with libs installed in /opt/local, which is
probably not the ones we want.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25483 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoEncase another variable used only if we support capture in #ifdef
guy [Wed, 18 Jun 2008 21:23:52 +0000 (21:23 +0000)]
Encase another variable used only if we support capture in #ifdef
HAVE_LIBPCAP/#endif.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25482 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoPut a variable inside a ifdef HAVE_LIBPCAP
stig [Wed, 18 Jun 2008 20:59:57 +0000 (20:59 +0000)]
Put a variable inside a ifdef HAVE_LIBPCAP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25481 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2613:
jake [Wed, 18 Jun 2008 20:23:42 +0000 (20:23 +0000)]
Fix for bug 2613:
Add explanation of built-in vs plugin dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25480 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReload the interface list on the welcome page when changing profile and
stig [Wed, 18 Jun 2008 20:14:28 +0000 (20:14 +0000)]
Reload the interface list on the welcome page when changing profile and
after editing the interface options.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25479 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2618:
jake [Wed, 18 Jun 2008 19:59:24 +0000 (19:59 +0000)]
Fix for bug 2618:
Add MS Time Zone interpretation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25478 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoComment out the "shilp" entry in the services file, so that port 2049
guy [Wed, 18 Jun 2008 17:50:01 +0000 (17:50 +0000)]
Comment out the "shilp" entry in the services file, so that port 2049
gets reported as NFS rather than "shilp", whatever *that* is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25476 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2619:
jake [Wed, 18 Jun 2008 17:32:35 +0000 (17:32 +0000)]
Fix for bug 2619:
Current OUI registery has changed location (again). Adjusting script to fetch current file.
Generated dataset based on this current file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25475 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoShow enhanced high speed channels more clearly.
martinm [Wed, 18 Jun 2008 16:06:12 +0000 (16:06 +0000)]
Show enhanced high speed channels more clearly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25472 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDraw menu items with radio buttons.
stig [Wed, 18 Jun 2008 15:57:12 +0000 (15:57 +0000)]
Draw menu items with radio buttons.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25471 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2616:
jake [Wed, 18 Jun 2008 06:27:02 +0000 (06:27 +0000)]
Fix for bug 2616:
According to RFC 3720 the login command doesn't require either T or C, just (C => !T)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25470 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThe recent.gui_time_precision fix introduced a worse bug when changing
stig [Tue, 17 Jun 2008 20:37:34 +0000 (20:37 +0000)]
The recent.gui_time_precision fix introduced a worse bug when changing
profiles, so I revert this and will investigate some more...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25469 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoPopup a menu with configuration profiles instead of the profile dlg
stig [Tue, 17 Jun 2008 19:50:22 +0000 (19:50 +0000)]
Popup a menu with configuration profiles instead of the profile dlg
when clicking the profile in the statusbar.  Much easier to use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25468 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFully implement Guy's suggested fix. Rename ADDRBUF_MAX_MESSAGE_SIZE to
gerald [Tue, 17 Jun 2008 19:05:48 +0000 (19:05 +0000)]
Fully implement Guy's suggested fix. Rename ADDRBUF_MAX_MESSAGE_SIZE to
MAX_ADDR_SIZE, to be more in line with a suggestion by Abhik Sarkar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25466 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix an off-by-one bug reported by David Ceccanti, as suggested by Guy at
gerald [Mon, 16 Jun 2008 21:55:37 +0000 (21:55 +0000)]
Fix an off-by-one bug reported by David Ceccanti, as suggested by Guy at
http://www.wireshark.org/lists/wireshark-users/200806/msg00077.html.
Add a comment about the usage of gsm_sms_char_7bit_unpack().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25462 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate Debian packaging files for development version
jake [Mon, 16 Jun 2008 20:49:02 +0000 (20:49 +0000)]
Update Debian packaging files for development version

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25461 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Michael Adam:
jake [Mon, 16 Jun 2008 20:38:26 +0000 (20:38 +0000)]
From Michael Adam:
This patch adds knowledge of the DFS server type to the SMB-BROWSE dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25460 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2612:
jake [Mon, 16 Jun 2008 05:33:08 +0000 (05:33 +0000)]
Fix for bug 2612:
cleaned up FT_UINT_STRING type description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25459 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2611:
jake [Mon, 16 Jun 2008 05:32:19 +0000 (05:32 +0000)]
Fix for bug 2611:
Add -v option to example "od" command line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25458 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInitialize recent.gui_time_precision when changing profile to avoid a crash
stig [Sun, 15 Jun 2008 20:53:06 +0000 (20:53 +0000)]
Initialize recent.gui_time_precision when changing profile to avoid a crash
in some rare cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25457 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCleanup return values from info_bar_new() and packets_bar_new().
stig [Sun, 15 Jun 2008 20:50:10 +0000 (20:50 +0000)]
Cleanup return values from info_bar_new() and packets_bar_new().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25456 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClick on the profile in the statusbar will open Configuration Profiles dialog.
stig [Sun, 15 Jun 2008 20:47:06 +0000 (20:47 +0000)]
Click on the profile in the statusbar will open Configuration Profiles dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25455 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMoved setting of E_MPACKET_LIST_KEY object data to the function creating
stig [Sun, 15 Jun 2008 18:29:22 +0000 (18:29 +0000)]
Moved setting of E_MPACKET_LIST_KEY object data to the function creating
packet_list to ensure it's created before we set it.

Applying filter from the packet list still doesn't work correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25454 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd missing IE id
etxrab [Sat, 14 Jun 2008 21:36:11 +0000 (21:36 +0000)]
Add missing IE id

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25453 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate all time columns when changing the time precision.
stig [Sat, 14 Jun 2008 16:51:11 +0000 (16:51 +0000)]
Update all time columns when changing the time precision.

Not implemented for conversation relative and delta time yet, because this
will need a reload as they are set by the dissectors and does not exist in
the frame data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25452 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSave the column width in the recent list on every change so we can
stig [Sat, 14 Jun 2008 16:45:06 +0000 (16:45 +0000)]
Save the column width in the recent list on every change so we can
pick the correct width when changing the time precision.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25451 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded svn:ignore wsutil/TAGS
stig [Fri, 13 Jun 2008 22:39:22 +0000 (22:39 +0000)]
Added svn:ignore wsutil/TAGS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25450 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWe half-enabled the Mac OS X packaging stuff, which meant that we
guy [Fri, 13 Jun 2008 16:52:45 +0000 (16:52 +0000)]
We half-enabled the Mac OS X packaging stuff, which meant that we
weren't including in the tarball stuff the packaging/macosx/Makefile.in
file that that the configure script from the tarball was trying to
expand.  Add macosx to the list of directories in packaging/Makefile.am,
and update the comment in packaging/macosx/Makefile.am to reflect the
enabling of the OS X packaging stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25449 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix list of files in the debian directory.
guy [Fri, 13 Jun 2008 05:54:22 +0000 (05:54 +0000)]
Fix list of files in the debian directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25448 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate to 3GPP TS 36.413 V8.2.0 (2008-06)
etxrab [Thu, 12 Jun 2008 19:18:06 +0000 (19:18 +0000)]
Update to 3GPP TS 36.413 V8.2.0 (2008-06)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25447 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoShow correct seqno in info column.
martinm [Thu, 12 Jun 2008 16:50:23 +0000 (16:50 +0000)]
Show correct seqno in info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25446 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDissect BCH channels (expect control messages only).
martinm [Thu, 12 Jun 2008 16:11:16 +0000 (16:11 +0000)]
Dissect BCH channels (expect control messages only).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25445 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom yami via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2603 : register...
morriss [Thu, 12 Jun 2008 13:39:55 +0000 (13:39 +0000)]
From yami via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2603 : register the SMB dissector by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25444 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReturn 0 if we don't dissect any bytes.
stig [Wed, 11 Jun 2008 20:10:19 +0000 (20:10 +0000)]
Return 0 if we don't dissect any bytes.
Set desegment_len = DESEGMENT_ONE_MORE_SEGMENT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25443 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 2396:
jake [Wed, 11 Jun 2008 18:20:02 +0000 (18:20 +0000)]
Fix for bug 2396:
Wireshark expects 802.1ah Instance tags to have ethernet type 0x88f0, but latest
802.1ah draft 4.1 defines the 802.1ah Instance tag ethernet type to 0x88e7.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25442 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoptvcursor_subtree_set_item() does not need to be exported.
jake [Wed, 11 Jun 2008 18:16:04 +0000 (18:16 +0000)]
ptvcursor_subtree_set_item() does not need to be exported.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25441 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThe change to "Use GTK+ 2.12.10" switched from "libpng13.dll" to
guy [Tue, 10 Jun 2008 17:23:36 +0000 (17:23 +0000)]
The change to "Use GTK+ 2.12.10" switched from "libpng13.dll" to
"libpng12-0.dll"; fix a reference to the former.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25440 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Joe Eykholt:
jake [Tue, 10 Jun 2008 05:41:29 +0000 (05:41 +0000)]
From Joe Eykholt:
The Fibre-channel FCP dissector shows the wrong byte as the response info
response code byte.  The byte with offset 2 in the FCP frame is shown
instead of byte 3 inside the response info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25439 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Alex Badea:
etxrab [Tue, 10 Jun 2008 05:39:58 +0000 (05:39 +0000)]
From   Alex Badea:
Migrate ISAKMP packet decryption from libnettle to libgcrypt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25438 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUse GTK+ 2.12.10
etxrab [Tue, 10 Jun 2008 05:35:38 +0000 (05:35 +0000)]
Use GTK+ 2.12.10

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25437 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSet release year and month for F7 FP (needed for correct EDCH no-of-subframes field).
martinm [Fri, 6 Jun 2008 17:54:59 +0000 (17:54 +0000)]
Set release year and month for F7 FP (needed for correct EDCH no-of-subframes field).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25436 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix RACH extended IE handling.
martinm [Fri, 6 Jun 2008 09:09:00 +0000 (09:09 +0000)]
Fix RACH extended IE handling.
Flags have different meanings depending upon radio mode...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25435 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSquash uninitialised use warning.
martinm [Thu, 5 Jun 2008 21:39:06 +0000 (21:39 +0000)]
Squash uninitialised use warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25434 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom SUZUKI, Shinsuke:
jake [Thu, 5 Jun 2008 20:00:36 +0000 (20:00 +0000)]
From SUZUKI, Shinsuke:
There are some non-ASCII characters in the following file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25433 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReplaced net-SNMP section with libSMI.
jake [Thu, 5 Jun 2008 13:25:48 +0000 (13:25 +0000)]
Replaced net-SNMP section with libSMI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25432 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded decoding of object 110 (Octet string), fixed reassembly if transport frame...
grahamb [Thu, 5 Jun 2008 10:32:51 +0000 (10:32 +0000)]
Added decoding of object 110 (Octet string), fixed reassembly if transport frame doesn't start with 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25431 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix operator precedence problem.
martinm [Thu, 5 Jun 2008 09:15:42 +0000 (09:15 +0000)]
Fix operator precedence problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25430 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCorrect math for counting how many TSNs were GAP acknowledged
morriss [Thu, 5 Jun 2008 01:29:58 +0000 (01:29 +0000)]
Correct math for counting how many TSNs were GAP acknowledged

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25429 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of unused variable.
guy [Wed, 4 Jun 2008 20:53:06 +0000 (20:53 +0000)]
Get rid of unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25428 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoA basic mp4v-es dissector.
etxrab [Wed, 4 Jun 2008 20:34:42 +0000 (20:34 +0000)]
A basic mp4v-es dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25427 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThe joys of beating header files over the head to get all the various
guy [Wed, 4 Jun 2008 18:05:45 +0000 (18:05 +0000)]
The joys of beating header files over the head to get all the various
APIs we use declared.  We still need to define __EXTENSIONS__ on
Solaris, in order to get strptime() declared.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25426 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago- Make FP radio division mode/speed explicit in struct for R7
martinm [Wed, 4 Jun 2008 17:33:48 +0000 (17:33 +0000)]
- Make FP radio division mode/speed explicit in struct for R7
- Various R7 fixes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25425 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of one extra reference for our own g_ascii_strtoull().
guy [Wed, 4 Jun 2008 02:12:57 +0000 (02:12 +0000)]
Get rid of one extra reference for our own g_ascii_strtoull().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25424 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agog_ascii_strtoull() is in GLib 2.2 and later, and we require GLib 2.4 or
guy [Wed, 4 Jun 2008 01:30:40 +0000 (01:30 +0000)]
g_ascii_strtoull() is in GLib 2.2 and later, and we require GLib 2.4 or
later, so there's no longer any need to have our own g_ascii_strtoull.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25423 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSuppress some unused-argument warnings.
guy [Wed, 4 Jun 2008 00:35:30 +0000 (00:35 +0000)]
Suppress some unused-argument warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25422 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSun C warns about an integer overflow for 1 << 31, presumably because 1
guy [Wed, 4 Jun 2008 00:05:57 +0000 (00:05 +0000)]
Sun C warns about an integer overflow for 1 << 31, presumably because 1
is signed; make the flags field in "struct magnify" unsigned, and make
the flags unsigned, so we shift 1U rather than 1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25421 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWe require GLib 2.4 or later, and they define G_MININT32, G_MAXIN32,
guy [Tue, 3 Jun 2008 23:57:47 +0000 (23:57 +0000)]
We require GLib 2.4 or later, and they define G_MININT32, G_MAXIN32,
G_MAXUINT32, and G_MAXUINT64; don't check whether we need to define them
ourselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25420 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGTK+ 1.2[.x] is no longer relevant - we require 2.x - so don't talk
guy [Tue, 3 Jun 2008 23:57:26 +0000 (23:57 +0000)]
GTK+ 1.2[.x] is no longer relevant - we require 2.x - so don't talk
about it in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25419 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agostrtol() returns a long, as the name suggests; assign its return value
guy [Tue, 3 Jun 2008 23:51:39 +0000 (23:51 +0000)]
strtol() returns a long, as the name suggests; assign its return value
to a long, and check whether it fits in a gint before returning it as a
gint.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25418 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInclude <stdlib.h> to declare strtol().
guy [Tue, 3 Jun 2008 23:35:40 +0000 (23:35 +0000)]
Include <stdlib.h> to declare strtol().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25417 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Frank Schorr:
jake [Tue, 3 Jun 2008 21:24:25 +0000 (21:24 +0000)]
From Frank Schorr:
The get_ifcp_pdu_len() call used for the tcp_dissect_pdus() call does not mask
off the frame length properly.  The result is that the "Flags" field
incorrectly becomes the high order part of the Frame Length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25416 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Frank Schorr:
jake [Tue, 3 Jun 2008 20:41:12 +0000 (20:41 +0000)]
From Frank Schorr:
RFC 4172 section 5.3.1 shows a chart of the iFCP encapsulated Header Format.
It says that bytes 4-7 MUST be zeros.  In reality most vendors are putting some
information in these 4 bytes, particularly Nishon. This caused almost all iFCP
packets to not be decoded for this vendor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25415 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix run checkapi for more targets.
etxrab [Tue, 3 Jun 2008 05:35:19 +0000 (05:35 +0000)]
Fix run checkapi for more targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25414 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRewrote ifopts_options_add() to make it readable and simpler.
stig [Mon, 2 Jun 2008 22:18:25 +0000 (22:18 +0000)]
Rewrote ifopts_options_add() to make it readable and simpler.
Fixed a bug where a one character comment would skip the interface.
If syntax error in the comment just skip the comment instead of the interface.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25413 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRewrote to not use gtk_combo_box_get_active_text().
stig [Mon, 2 Jun 2008 21:35:22 +0000 (21:35 +0000)]
Rewrote to not use gtk_combo_box_get_active_text().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25412 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded an option to set default link-layer header type for each interface.
stig [Mon, 2 Jun 2008 17:45:03 +0000 (17:45 +0000)]
Added an option to set default link-layer header type for each interface.
Set linktype history for each interface so we don't mix them.
Fixed some indents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25411 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDon't include \r in linktype on win32, it looks weird in the combo box.
stig [Mon, 2 Jun 2008 17:17:24 +0000 (17:17 +0000)]
Don't include \r in linktype on win32, it looks weird in the combo box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25410 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Rudolf Weidmann (bug 2583):
stig [Mon, 2 Jun 2008 07:32:55 +0000 (07:32 +0000)]
From Rudolf Weidmann (bug 2583):
Fixed enumeration type for new-mode in change-of-life-safety.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25409 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClean up desktop files based on changes made by Stig.
jake [Mon, 2 Jun 2008 07:26:34 +0000 (07:26 +0000)]
Clean up desktop files based on changes made by Stig.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25408 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Toralf Förster: Fix minor typo: MAde -> Made
sfisher [Sun, 1 Jun 2008 18:45:19 +0000 (18:45 +0000)]
From Toralf Förster: Fix minor typo: MAde -> Made

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25407 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate Debian packaging files for Wireshark 1.0.
jake [Sat, 31 May 2008 16:44:02 +0000 (16:44 +0000)]
Update Debian packaging files for Wireshark 1.0.
These files build the package with all features and
minimum changes from the released sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25406 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReturn the appropriate "everything OK" types.
guy [Fri, 30 May 2008 07:15:05 +0000 (07:15 +0000)]
Return the appropriate "everything OK" types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25405 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClean up indentation.
guy [Fri, 30 May 2008 07:13:28 +0000 (07:13 +0000)]
Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25404 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInclude <string.h> to declare strcmp().
guy [Fri, 30 May 2008 05:46:24 +0000 (05:46 +0000)]
Include <string.h> to declare strcmp().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25403 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agog_strcmp0() only shows up on the Intarweb in documentation for some
guy [Fri, 30 May 2008 05:19:54 +0000 (05:19 +0000)]
g_strcmp0() only shows up on the Intarweb in documentation for some
testing version of GLib; it doesn't appear to exist in any current
versions.  There's no need to "gracefully" handle NULL (whatever
"gracefully" means in this context - NULL compares less than any real
string?), as we already checked whether mac_name is null, and we're
comparing it against a string constant; just use strcmp().

In ssh_gslist_compare_strings(), check for null pointers for now.

strcmp() (and strcmp-alikes) don't return a boolean, they return a value
such that comparing strings with a particular operator is done by
comparing the result of strcmp() with 0 using that operator; do that, to
make it clearer that the strings are being compared for equality.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25402 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAgain, the err_info returned from wtap_read() and wtap_seek_read() is a
guy [Fri, 30 May 2008 04:03:32 +0000 (04:03 +0000)]
Again, the err_info returned from wtap_read() and wtap_seek_read() is a
g_mallocated string, so it's not const.

Fix a comment to reflect reality (err_info is some additional
information about the error returned by Wiretap, e.g. some gory details
about the error, mainly useful to developers and support people).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25401 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree up the err_info string returned by wtap_read() and
guy [Fri, 30 May 2008 02:44:02 +0000 (02:44 +0000)]
Free up the err_info string returned by wtap_read() and
wtap_seek_read().

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25400 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFree up the err_info string returned by wtap_read().
guy [Fri, 30 May 2008 02:37:36 +0000 (02:37 +0000)]
Free up the err_info string returned by wtap_read().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25399 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agowtap_read() and wtap_seek_read(), and thus the functions that it calls,
guy [Fri, 30 May 2008 02:34:45 +0000 (02:34 +0000)]
wtap_read() and wtap_seek_read(), and thus the functions that it calls,
are expected to return a g_mallocated error string; that's why they fill
in a gchar **, not a const gchar **.  g_strdup() the argument to
KERROR(), so it's g_mallocated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25398 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Kees Cook via bug #2577 (with minor modifications by me):
sfisher [Fri, 30 May 2008 02:13:30 +0000 (02:13 +0000)]
From Kees Cook via bug #2577 (with minor modifications by me):

provide more detailed SSH dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25397 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix references to tcpdump-workers@tcpdump.org to refer to the new
guy [Fri, 30 May 2008 01:47:57 +0000 (01:47 +0000)]
Fix references to tcpdump-workers@tcpdump.org to refer to the new
address, tcpdump-workers@lists.tcpdump.org.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25396 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoA MAC address is a sequence of 6 8-bit unsigned values (guint8), not a
guy [Fri, 30 May 2008 00:01:24 +0000 (00:01 +0000)]
A MAC address is a sequence of 6 8-bit unsigned values (guint8), not a
sequence of 6 ASCII characters (gchar).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25395 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFor a character string, use an array of char, not an array of guint8
guy [Thu, 29 May 2008 23:53:19 +0000 (23:53 +0000)]
For a character string, use an array of char, not an array of guint8
(the characters are all digits), and, to point to it, use a pointer to
char rather than a pointer to guint8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25394 f5534014-38df-0310-8fa8-9805f1628bb7