obnox/wireshark/wip.git
19 years agoBack out the previous change - we were setting "datafiledir", not
guy [Sun, 6 Feb 2005 21:36:11 +0000 (21:36 +0000)]
Back out the previous change - we were setting "datafiledir", not
"datafile", and code in epan/filesystem.c expectes DATAFILE_DIR to be
set to the "ethereal" subdirectory of the data directory, not to the
data directory itself.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13322 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agominor code cleanup
ulfl [Sun, 6 Feb 2005 21:34:59 +0000 (21:34 +0000)]
minor code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13321 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoanother two steps towards privilege seperation:
ulfl [Sun, 6 Feb 2005 21:20:35 +0000 (21:20 +0000)]
another two steps towards privilege seperation:

move another two capture related fields (iface and cfilter) from cfile to capture_opts

also move the handling of capture related command line options from main.c to capture.c, that way a future privilege seperated capture program can use the same code to parse it's command line than Ethereal.
It might be even possible to share this parser code even with Tethereal, didn't took a closer look at this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13320 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoClean up indentation.
guy [Sun, 6 Feb 2005 20:53:54 +0000 (20:53 +0000)]
Clean up indentation.

Make "reset()" static (it's not used outside "sctp_stat.c"), and fix its
prototype to match what's expected for a reset routine passed to
"register_tap_listener()".  Similarly, fix the prototypes of other
routines passed to "register_tap_listener()", and get rid of the casts
of pointers to those functions to "void *".

Fix some declarations in "sctp_stat.h" to have function prototypes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13319 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom: LEGO
etxrab [Sun, 6 Feb 2005 20:37:02 +0000 (20:37 +0000)]
From: LEGO
- fix a bug at gog reinit that disabled gogs after reload of a file.
- fix some crashes when Debug_GoG>0
- cleanup the debug output (no CR at the end is needed)
- Gops start when no GopStart is given and match an existing GogKey

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13318 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosome cleanup of the initial start sequence of Ethereal, filling in capture_opts and...
ulfl [Sun, 6 Feb 2005 14:43:27 +0000 (14:43 +0000)]
some cleanup of the initial start sequence of Ethereal, filling in capture_opts and alike

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13317 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofix bugs regarding the capture child
ulfl [Sun, 6 Feb 2005 12:21:27 +0000 (12:21 +0000)]
fix bugs regarding the capture child

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13316 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoinstead of initializing the capture_options in main.c, use the new function capture_o...
ulfl [Sun, 6 Feb 2005 00:13:00 +0000 (00:13 +0000)]
instead of initializing the capture_options in main.c, use the new function capture_opts_init

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13315 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove obsolete function add_rtp_streams_graph() from voip_calls.[ch] and fix a regis...
lroland [Sat, 5 Feb 2005 23:34:56 +0000 (23:34 +0000)]
remove obsolete function add_rtp_streams_graph() from voip_calls.[ch] and fix a register_tap_listener() call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13314 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobegin a welcome page which is shown, if you don't have any capture data loaded.
ulfl [Sat, 5 Feb 2005 23:12:44 +0000 (23:12 +0000)]
begin a welcome page which is shown, if you don't have any capture data loaded.

This might be improved to have additional content and/or better layout of the elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13313 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agocompletely hide the main window panes, if we currently don't have a capture file.
ulfl [Sat, 5 Feb 2005 17:53:39 +0000 (17:53 +0000)]
completely hide the main window panes, if we currently don't have a capture file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13312 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Josh Bailey:
gerald [Sat, 5 Feb 2005 17:39:12 +0000 (17:39 +0000)]
From Josh Bailey:

Attached is an update to Lucent/Ascend trace parsing: fix a few bugs,
add support for ISDN and Ethernet captures - diffs to 0.10.9.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13311 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRemove g_free.
etxrab [Sat, 5 Feb 2005 15:51:45 +0000 (15:51 +0000)]
Remove g_free.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13310 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofixed the dnd_init declaration
ulfl [Sat, 5 Feb 2005 15:40:44 +0000 (15:40 +0000)]
fixed the dnd_init declaration

(we have to do something about the non existing win32 compile dependencies, this is just a pain)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13309 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agorename kill_capture_child to capture_kill_child to have a common prefix
ulfl [Sat, 5 Feb 2005 15:35:25 +0000 (15:35 +0000)]
rename kill_capture_child to capture_kill_child to have a common prefix

split drag and drop support out of main.c into new file drag_and_drop.c, to reduce the size of main.c a bit.

Hopefully this won't break unix builds because of missing #include's, I will keep an eye on the buildbot

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13308 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouse the interfaces descriptive name to be shown in the statusbar as it's, well, more...
ulfl [Sat, 5 Feb 2005 14:37:56 +0000 (14:37 +0000)]
use the interfaces descriptive name to be shown in the statusbar as it's, well, more descriptive

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13307 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofix a comment
ulfl [Sat, 5 Feb 2005 14:33:03 +0000 (14:33 +0000)]
fix a comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13306 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRe-commit the asn2eth based gsm-map dissector, hopfully it'll work better now.
etxrab [Sat, 5 Feb 2005 14:24:26 +0000 (14:24 +0000)]
Re-commit the asn2eth based gsm-map dissector, hopfully it'll work better now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13305 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agominor enhancements to Guy's last update
ulfl [Sat, 5 Feb 2005 13:44:27 +0000 (13:44 +0000)]
minor enhancements to Guy's last update

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13304 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut "cf_status_t" back.
guy [Sat, 5 Feb 2005 12:50:47 +0000 (12:50 +0000)]
Put "cf_status_t" back.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13303 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "cf_open()" match the prototype in "file.h".
guy [Sat, 5 Feb 2005 12:08:01 +0000 (12:08 +0000)]
Make "cf_open()" match the prototype in "file.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13302 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoupdated some comments
ulfl [Sat, 5 Feb 2005 11:37:56 +0000 (11:37 +0000)]
updated some comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13301 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Alejandro Vaquero:
etxrab [Sat, 5 Feb 2005 11:08:24 +0000 (11:08 +0000)]
From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now
using an RTP tap (not using the rtp_stream).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13300 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Alejandro Vaquero:
etxrab [Sat, 5 Feb 2005 11:07:21 +0000 (11:07 +0000)]
From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now
using an RTP tap (not using the rtp_stream).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13299 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomake some string parameters const, as they are not changed inside
ulfl [Sat, 5 Feb 2005 11:00:04 +0000 (11:00 +0000)]
make some string parameters const, as they are not changed inside

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13298 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoretap_packets() was renamed cf_retap_packets().
guy [Sat, 5 Feb 2005 04:37:36 +0000 (04:37 +0000)]
retap_packets() was renamed cf_retap_packets().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13297 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoActivate SCTP association analysis
tuexen [Fri, 4 Feb 2005 22:48:17 +0000 (22:48 +0000)]
Activate SCTP association analysis

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13296 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate to versions compiling on and working on Windows and Unix.
tuexen [Fri, 4 Feb 2005 22:45:15 +0000 (22:45 +0000)]
Update to versions compiling on and working on Windows and Unix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13295 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd detection of zero checksum.
tuexen [Fri, 4 Feb 2005 22:39:48 +0000 (22:39 +0000)]
Add detection of zero checksum.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13294 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInstead of having a single enumerated type for status return values from
guy [Fri, 4 Feb 2005 20:54:12 +0000 (20:54 +0000)]
Instead of having a single enumerated type for status return values from
cf_ functions, have separate ones for different classes of routines, and
use gboolean when the return value is just "success" or "failure" - that
way you don't get compiler warnings if a case statement isn't handling a
particular status value if the routine in question won't return it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13293 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoProperly define "cf_start_tail()".
guy [Fri, 4 Feb 2005 20:32:32 +0000 (20:32 +0000)]
Properly define "cf_start_tail()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13292 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove #include "globals.h" from summary.c, as it's a bad idea for multiple capture...
ulfl [Fri, 4 Feb 2005 19:29:27 +0000 (19:29 +0000)]
remove #include "globals.h" from summary.c, as it's a bad idea for multiple capture files.
If a summary user would like to get a summary, it should know the file of *which* it needs the summary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13291 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agothis file doesn't use any item of the globals.h so remove #include.
ulfl [Fri, 4 Feb 2005 19:24:40 +0000 (19:24 +0000)]
this file doesn't use any item of the globals.h so remove #include.
However, if it needs one of:
#include "file.h"
#include <epan/timestamp.h>
it should include it directly, please let me know if it's required, as I can't test it :-(

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13290 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agohuge cleanup of capture file API (functions in file.c/file.h).
ulfl [Fri, 4 Feb 2005 18:44:44 +0000 (18:44 +0000)]
huge cleanup of capture file API (functions in file.c/file.h).

This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions.

Hopefully, I didn't introduced any new bugs, as I had to change a lot of files...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13289 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a couple of distcheck problems:
gerald [Fri, 4 Feb 2005 15:22:25 +0000 (15:22 +0000)]
Fix a couple of distcheck problems:

Update conversation_new and find_conversation in plugin_api_list.c and
associated files.

Add packet-dcerpc-butc.h to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13288 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Dominique Bastien: marker and OAM slow protocol support.
guy [Fri, 4 Feb 2005 10:48:03 +0000 (10:48 +0000)]
From Dominique Bastien: marker and OAM slow protocol support.

Fix his e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13287 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHFILL can't be used to initialize at run time.
guy [Fri, 4 Feb 2005 10:32:28 +0000 (10:32 +0000)]
HFILL can't be used to initialize at run time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13286 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove access to global cfile, use access functions and capture_opts instead
ulfl [Fri, 4 Feb 2005 08:52:38 +0000 (08:52 +0000)]
remove access to global cfile, use access functions and capture_opts instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13285 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove #include "globals.h" and access to global cfile, use access functions and...
ulfl [Fri, 4 Feb 2005 08:42:39 +0000 (08:42 +0000)]
remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13284 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove #include "globals.h" and access to global cfile, use access functions and...
ulfl [Fri, 4 Feb 2005 08:27:41 +0000 (08:27 +0000)]
remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13283 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouse a bitmap for the restore flags so the dissection is prettier
sahlberg [Fri, 4 Feb 2005 05:26:51 +0000 (05:26 +0000)]
use a bitmap for the restore flags so the dissection is prettier

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13282 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoinitial checkin of modified idl file for autogenerating the BUTC interface
sahlberg [Fri, 4 Feb 2005 04:58:03 +0000 (04:58 +0000)]
initial checkin of modified idl file for autogenerating the BUTC interface

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13281 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agocheck in new directory for the files for autogenerating dcerpc interfaces
sahlberg [Fri, 4 Feb 2005 04:37:47 +0000 (04:37 +0000)]
check in new directory for the files for autogenerating dcerpc interfaces
and the prototype idl compiler.

this is not ready for wide use yet but is useful with a svn area where we can sync our changes to the compiler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13280 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd missing conversion to new use of save_file and fork_child
sahlberg [Fri, 4 Feb 2005 04:31:59 +0000 (04:31 +0000)]
add missing conversion to new use of save_file and fork_child

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13279 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd support for varying strings in addition to conformant and varying strings that...
sahlberg [Fri, 4 Feb 2005 04:02:36 +0000 (04:02 +0000)]
add support for varying strings in addition to conformant and varying strings that we already support

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13278 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoupdate BUTC and fill in all (bar one) dissectors
sahlberg [Fri, 4 Feb 2005 02:17:29 +0000 (02:17 +0000)]
update BUTC and fill in all (bar one) dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13277 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago(some) redesign of capture data structures.
ulfl [Fri, 4 Feb 2005 01:29:29 +0000 (01:29 +0000)]
(some) redesign of capture data structures.

don't use global cfile at all but only an untpyed handle to call the cf_... functions in file.c
move the save_file member from capture_file to capture_opts, as it's only used while capturing and while preparing it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13276 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAlbert Chin:
jmayer [Fri, 4 Feb 2005 00:29:37 +0000 (00:29 +0000)]
Albert Chin:
>From autoconf.info:
     In order to support these features, it is essential that `datadir'
  remains being defined as `${prefix}/share' to depend upon the current
  value of `prefix'.

     A corollary is that you should not use these variables except in
  Makefiles.  For instance, instead of trying to evaluate `datadir' in
  `configure' and hard-coding it in Makefiles using e.g.,
  `AC_DEFINE_UNQUOTED(DATADIR, "$datadir")', you should add
  `-DDATADIR="$(datadir)"' to your `CPPFLAGS'.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13275 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoalbert chin:
jmayer [Fri, 4 Feb 2005 00:22:00 +0000 (00:22 +0000)]
albert chin:
        The HP-UX compilers don't like non-constant initializers (C99'ism).
        Patch attached for plugins/mate/mate_setup.c.

Fix a few warnings (change some () to (void))

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13274 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoYaniv Kaul
jmayer [Thu, 3 Feb 2005 23:42:06 +0000 (23:42 +0000)]
Yaniv Kaul
        Attached patch simplifies a very complex 'if' statement in packet-fw1.c
        and generally streamlines the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13273 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoYaniv Kaul:
jmayer [Thu, 3 Feb 2005 23:35:57 +0000 (23:35 +0000)]
Yaniv Kaul:
        Attached please find a small performance optimization to packet-ip.c,
        which removes multiple redundant calls to tvb_get_ptr().

Changed srt_addr and dst_addr from char to guchar

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13272 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMotonori Shindo:
jmayer [Thu, 3 Feb 2005 23:24:08 +0000 (23:24 +0000)]
Motonori Shindo:
Please find attached a small patch for CoSine L2 debug dissector. The
code used to incorrectly select the first 4 octets in the tvbuff. This
patch fixes this problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13271 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoYniv Kaul: Small performance optimization
jmayer [Thu, 3 Feb 2005 23:18:23 +0000 (23:18 +0000)]
Yniv Kaul: Small performance optimization
  It change a while()->do, to do->while() and removes a variable (and an
  assignment to it).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13270 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoncisco Alcoba:
jmayer [Thu, 3 Feb 2005 22:52:20 +0000 (22:52 +0000)]
ncisco Alcoba:
        Do not add target address if the packet is a Request. According to the RFC,
        target addresses in requests have no meaning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13269 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomove capture_file_fd field from capture_file to capture_opts type, as this is the...
ulfl [Thu, 3 Feb 2005 22:48:20 +0000 (22:48 +0000)]
move capture_file_fd field from capture_file to capture_opts type, as this is the place where it should be

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13268 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMark C. Brown: Added support for new ixgbe card
jmayer [Thu, 3 Feb 2005 22:44:13 +0000 (22:44 +0000)]
Mark C. Brown: Added support for new ixgbe card

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13267 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoprevent ringbuffer from having to know about capture_file type at all (decoupling...
ulfl [Thu, 3 Feb 2005 21:58:33 +0000 (21:58 +0000)]
prevent ringbuffer from having to know about capture_file type at all (decoupling dependencies)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13266 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd dissection of some more packages.
etxrab [Thu, 3 Feb 2005 21:57:42 +0000 (21:57 +0000)]
Add dissection of some more packages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13265 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd dissection of some more packages.
etxrab [Thu, 3 Feb 2005 21:56:59 +0000 (21:56 +0000)]
Add dissection of some more packages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13264 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Francisco Alcoba:
etxrab [Thu, 3 Feb 2005 21:51:35 +0000 (21:51 +0000)]
From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message,
in the first one the calling and called numbers, and in the second the SPs
and CIC; in releases it shows the cause value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13263 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Francisco Alcoba:
etxrab [Thu, 3 Feb 2005 21:50:19 +0000 (21:50 +0000)]
From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message,
in the first one the calling and called numbers, and in the second the SPs
and CIC; in releases it shows the cause value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13262 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoVarious updates to GSM MAP
etxrab [Thu, 3 Feb 2005 21:22:09 +0000 (21:22 +0000)]
Various updates to GSM MAP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13261 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoJon Ringle: bug fix to the stun ERROR-CODE dissecting
jmayer [Thu, 3 Feb 2005 21:11:46 +0000 (21:11 +0000)]
Jon Ringle: bug fix to the stun ERROR-CODE dissecting

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13260 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd tooltips to the dialogs radio buttons
ulfl [Thu, 3 Feb 2005 20:44:19 +0000 (20:44 +0000)]
add tooltips to the dialogs radio buttons

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13259 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Dominique Bastien: add the slow protocol MAC address to the list of
guy [Thu, 3 Feb 2005 20:14:11 +0000 (20:14 +0000)]
From Dominique Bastien: add the slow protocol MAC address to the list of
well-known MAC addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13258 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSmall fix for h225 dissector as suggested by Tomas Kukosa
lroland [Thu, 3 Feb 2005 16:22:08 +0000 (16:22 +0000)]
Small fix for h225 dissector as suggested by Tomas Kukosa

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13257 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Pekka Pietikainen <pp@ee.oulu.fi>, add a byte to the hex[]
gram [Thu, 3 Feb 2005 15:03:29 +0000 (15:03 +0000)]
From Pekka Pietikainen <pp@ee.oulu.fi>, add a byte to the hex[]
array so that there is room for the terminating NUL from sprintf().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13256 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd an OID
etxrab [Thu, 3 Feb 2005 06:54:55 +0000 (06:54 +0000)]
Add an OID

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13255 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoEnable GTK-Wimp only for Windows 2000/XP/2003
ulfl [Thu, 3 Feb 2005 02:35:20 +0000 (02:35 +0000)]
Enable GTK-Wimp only for Windows 2000/XP/2003
...as Win9x/ME/NT known to have problems with it!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13254 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCopied this file from:
ulfl [Thu, 3 Feb 2005 02:32:48 +0000 (02:32 +0000)]
Copied this file from:
http://nsis.sourceforge.net/archive/nsisweb.php?page=15&instances=0,11

Licensing question, as the NSIS homepage states:
http://nsis.sourceforge.net/features/license/
so it should be ok to rerelease this file under the GPL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13253 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGive a URL for the ERF specification.
guy [Thu, 3 Feb 2005 02:26:20 +0000 (02:26 +0000)]
Give a URL for the ERF specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13252 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a comment.
guy [Thu, 3 Feb 2005 01:24:07 +0000 (01:24 +0000)]
Fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13251 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCheck in the missing part of Jon Ringle's patch (the part that actually
guy [Thu, 3 Feb 2005 01:08:39 +0000 (01:08 +0000)]
Check in the missing part of Jon Ringle's patch (the part that actually
changed the conversation code).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13250 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUndo de-UTF-8ification and other damage.
guy [Thu, 3 Feb 2005 01:07:21 +0000 (01:07 +0000)]
Undo de-UTF-8ification and other damage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13249 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded %ETHEREAL%\disabled_protos
ulfl [Wed, 2 Feb 2005 22:18:37 +0000 (22:18 +0000)]
added %ETHEREAL%\disabled_protos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13248 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: the EOT flag detection in a COTP data TPDU was using little endian, although...
ulfl [Wed, 2 Feb 2005 21:13:52 +0000 (21:13 +0000)]
bugfix: the EOT flag detection in a COTP data TPDU was using little endian, although it's big endian in the packet.

some other minor output enhancements

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13247 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd Jon Ringle, at the moment I don't have the e-mail address.
etxrab [Wed, 2 Feb 2005 20:15:29 +0000 (20:15 +0000)]
Add Jon Ringle, at the moment I don't have the e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13246 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Jon Ringle:
etxrab [Wed, 2 Feb 2005 20:09:00 +0000 (20:09 +0000)]
From Jon Ringle:
 1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13245 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Jon Ringle:
etxrab [Wed, 2 Feb 2005 20:08:36 +0000 (20:08 +0000)]
From Jon Ringle:
 1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13244 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Jon Ringle:
etxrab [Wed, 2 Feb 2005 20:07:03 +0000 (20:07 +0000)]
From Jon Ringle:
 1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13243 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Jon Ringle:
etxrab [Wed, 2 Feb 2005 20:02:46 +0000 (20:02 +0000)]
From Jon Ringle:
 1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13242 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd mtp3.pc as suggested by Luis Ontanon.
tuexen [Wed, 2 Feb 2005 13:37:04 +0000 (13:37 +0000)]
Add mtp3.pc as suggested by Luis Ontanon.
Cleanups

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13241 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWriting the raw data of a TCP stream to a file isn't printing it, so
guy [Wed, 2 Feb 2005 10:28:51 +0000 (10:28 +0000)]
Writing the raw data of a TCP stream to a file isn't printing it, so
don't use the print mechanism for that - do the writing directly in the
"follow stream" code.

Use "size_t" for character counts.

Make the "hexchars" array static and const, as it's not written to, and
there's probably no point in copying it to the stack (unless that
improves cache locality).

There's no need to explain why we're subtracting the number of bytes
actually read, rather than the number of bytes asked for, from the data
length.

Note an issue with printing lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13240 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of an unused typedef.
guy [Wed, 2 Feb 2005 10:19:35 +0000 (10:19 +0000)]
Get rid of an unused typedef.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13239 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse C89 syntax, not C++ syntax, for functions that take no arguments.
guy [Wed, 2 Feb 2005 09:08:42 +0000 (09:08 +0000)]
Use C89 syntax, not C++ syntax, for functions that take no arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13238 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't assume that the only blank filter expression is empty - check for
guy [Wed, 2 Feb 2005 08:53:08 +0000 (08:53 +0000)]
Don't assume that the only blank filter expression is empty - check for
an all-space-character string.

Don't use "filter_string" both for the (unfreeable, unmodifiable) value
fetched from the text entry and the new filter expression; use it only
for the former, and make it a "const" pointer to avoid compiler
warnings.

Use a GString to construct the stuff to be added to the new filter
expression - the old code, when appending stuff to the filter expression
in a loop, would leak the pre-append value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13237 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofrom chris eagle
sahlberg [Wed, 2 Feb 2005 08:50:40 +0000 (08:50 +0000)]
from chris eagle

add radiobutton to allow saving raw tcpstreams

these radiobuttons should, by someone that uses, this feature be changed into
a menu instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13236 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake sure "comment" is set.
guy [Wed, 2 Feb 2005 08:08:53 +0000 (08:08 +0000)]
Make sure "comment" is set.

Get rid of an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13235 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoClean up white space.
guy [Wed, 2 Feb 2005 08:02:46 +0000 (08:02 +0000)]
Clean up white space.

Get rid of an unused variable and two #includes that aren't needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13234 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"filter_string_fwd" is assigned a "const" pointer, so make it a "const"
guy [Wed, 2 Feb 2005 08:01:27 +0000 (08:01 +0000)]
"filter_string_fwd" is assigned a "const" pointer, so make it a "const"
pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13233 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofor VoIP Call Analysis:
lroland [Wed, 2 Feb 2005 01:02:09 +0000 (01:02 +0000)]
for VoIP Call Analysis:
- make VoIP Call Analysis work if, called from command line
- should also work now while capturing with packet list
  updated in "real time" (to be tested)
- give each tap listener a unique identifier, so ethereal
  won't mix them up
- various cleanups
- compile by default

Todo:
- add support for "tap display filter"
- reimplement function to add rtp streams to the call flow.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13232 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoby more specific about unix configuration files
ulfl [Tue, 1 Feb 2005 23:49:02 +0000 (23:49 +0000)]
by more specific about unix configuration files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13231 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agothe old netlogon protocol is now called smb_netlogon
sahlberg [Tue, 1 Feb 2005 23:33:04 +0000 (23:33 +0000)]
the old netlogon protocol is now called smb_netlogon

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13230 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agog_strlcpy does not exist in gtk 1.2
sahlberg [Tue, 1 Feb 2005 23:30:18 +0000 (23:30 +0000)]
g_strlcpy does not exist in gtk 1.2
use strncpy instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13229 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoImprove handling of pinfo->private_data
etxrab [Tue, 1 Feb 2005 22:57:22 +0000 (22:57 +0000)]
Improve handling of pinfo->private_data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13228 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd boolean to the list of non-portable types
jmayer [Tue, 1 Feb 2005 15:45:03 +0000 (15:45 +0000)]
Add boolean to the list of non-portable types

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13227 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd packet-sdp.h
lroland [Tue, 1 Feb 2005 14:00:25 +0000 (14:00 +0000)]
add packet-sdp.h
and from Julien Leproust:
fix graph_analysis.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13226 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Alejandro Vaquero:
lroland [Tue, 1 Feb 2005 12:12:35 +0000 (12:12 +0000)]
From Alejandro Vaquero:
h323 taps support up to 5 messages per packet now.

VoIP call analysis:
      - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info:
      - Start and Stop time of the call
      - Init

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13225 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd some comments noting issues with some of the items in here.
guy [Tue, 1 Feb 2005 11:11:15 +0000 (11:11 +0000)]
Add some comments noting issues with some of the items in here.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13224 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove "dissect_nt_GUID()" into "packet-dcerpc-nt.c", as it's used by the
guy [Tue, 1 Feb 2005 05:21:08 +0000 (05:21 +0000)]
Move "dissect_nt_GUID()" into "packet-dcerpc-nt.c", as it's used by the
LSA dissector as well, and declare it in "packet-dcerpc-nt.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13223 f5534014-38df-0310-8fa8-9805f1628bb7