obnox/wireshark/wip.git
17 years agoUpdate to newer version of the file from
jmayer [Wed, 6 Sep 2006 22:13:52 +0000 (22:13 +0000)]
Update to newer version of the file from
http://cmake-modules.googlecode.com/svn/trunk/

This update adds a license text (dual: GPLv2 and 3 clause BSD)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19166 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUpdate enterprise-numbers
jake [Wed, 6 Sep 2006 21:08:24 +0000 (21:08 +0000)]
Update enterprise-numbers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19165 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoDissect some more common control messages
martinm [Wed, 6 Sep 2006 14:08:40 +0000 (14:08 +0000)]
Dissect some more common control messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19164 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for the typo in bug 1094
sahlberg [Wed, 6 Sep 2006 08:36:13 +0000 (08:36 +0000)]
fix for the typo in bug 1094

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19163 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Make options filterable
jmayer [Wed, 6 Sep 2006 08:24:36 +0000 (08:24 +0000)]
- Make options filterable
- Display options in info column
- Only remember blksize from OACK packets
- Add some rfc numbers
- Move tftp_dissect_options in front of dissect_tftp
  (I forgot to fix the forward decl once too often ;)
- Warning fixes
- Add expert error in case of tftp-error pdu

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19162 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd comments about PORTAUDIO API version comment out use of PORTAUDIO library for...
etxrab [Wed, 6 Sep 2006 05:23:38 +0000 (05:23 +0000)]
Add comments about PORTAUDIO API version comment out use of PORTAUDIO library for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19161 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoNAME can also contain '_'
etxrab [Wed, 6 Sep 2006 05:22:05 +0000 (05:22 +0000)]
NAME can also contain '_'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19160 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoHandle PORTAUDIO_API_1 and add clean-deps target to distclean.
etxrab [Tue, 5 Sep 2006 20:35:41 +0000 (20:35 +0000)]
Handle PORTAUDIO_API_1 and add clean-deps target to distclean.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19159 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agooption name "blksize" is case in-sensitive
jmayer [Tue, 5 Sep 2006 16:09:49 +0000 (16:09 +0000)]
option name "blksize" is case in-sensitive

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19158 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMake smrse & radius dissectors findable by name
martinm [Tue, 5 Sep 2006 16:06:41 +0000 (16:06 +0000)]
Make smrse & radius dissectors findable by name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19157 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFor DCT2000, show better transport info:
martinm [Tue, 5 Sep 2006 16:05:23 +0000 (16:05 +0000)]
For DCT2000, show better transport info:
- for FP over AAL2, add CID to AAL tree
- for IPPRIM protocols, show IPV4 addresses in src & dst columns

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19156 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1092
jmayer [Tue, 5 Sep 2006 15:58:11 +0000 (15:58 +0000)]
Fix for bugs.wireshark.org/bugzilla/show_bug.cgi?id=1092
Actually, this was a feature request:

Store the value of the blksize option in the conversation data
and use that information to compare whether we have reached the
last packet.

Includes the cleanup ideas from Ronnie.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19155 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for bug 1054
sahlberg [Tue, 5 Sep 2006 15:13:39 +0000 (15:13 +0000)]
fix for bug 1054

there were instances where the function dissect_nt_sid() would not fill in the return pointer for the sid string
causing callers that rely on that this string will ALWAYS be assigned try to access and g_free() an uninitialized pointer.

dissect_nt_sid() should be changed to use and return ep allocated memory instead of gmalloced memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19154 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for bug 1079
sahlberg [Tue, 5 Sep 2006 14:32:15 +0000 (14:32 +0000)]
fix for bug 1079

verify that stat_info->request_uri is non null before doing string manipulations on it
so that we dont try to dereference a null pointer further down the code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19153 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for bug 1093, as proposed by Atsushi Fukumoto
jake [Tue, 5 Sep 2006 12:22:44 +0000 (12:22 +0000)]
Fix for bug 1093, as proposed by Atsushi Fukumoto

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19152 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd some links for further reading
jmayer [Tue, 5 Sep 2006 12:04:46 +0000 (12:04 +0000)]
Add some links for further reading

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19151 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agopropset, add $Id: $ and copyright headers
jmayer [Tue, 5 Sep 2006 09:50:45 +0000 (09:50 +0000)]
propset, add $Id: $ and copyright headers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19150 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoOK, as I haven't had any negative feedback, I'm adding my work
jmayer [Tue, 5 Sep 2006 09:27:22 +0000 (09:27 +0000)]
OK, as I haven't had any negative feedback, I'm adding my work
to use cmake as a build system. It's in no way complete, I'd
just like others to be able to participate in playing with cmake
and to document what I'm doing.

Please read the README.cmake for what can be done right now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19149 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agortp_player.c will now compile with the new API, although it will not
jmayer [Tue, 5 Sep 2006 09:17:55 +0000 (09:17 +0000)]
rtp_player.c will now compile with the new API, although it will not
actually do something useful except to print that the new API is not
supported.

Adapt acinclude.m4 to provide PORTAUDIO_API_1 and add back the
check_message to indicate *why* we are checking for the type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19148 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdded some files to svn:ignore
jmayer [Tue, 5 Sep 2006 09:14:18 +0000 (09:14 +0000)]
Added some files to svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19147 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMove the include of rtp_player.h after the include of stuff it needs,
guy [Tue, 5 Sep 2006 07:58:14 +0000 (07:58 +0000)]
Move the include of rtp_player.h after the include of stuff it needs,
and include rtp_analysis.h as well, as it declares something else
rtp_player.h needs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19146 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Stephen Fisher:
etxrab [Tue, 5 Sep 2006 05:38:11 +0000 (05:38 +0000)]
From Stephen Fisher:
A patch to bring the VNC dissector almost to completion.

I have not had a chance to finish the server message type "frame buffer
update," which are the pixel values for screen rectangle updates.
Everything else is there - tracking the keys the user is pushing,
ringing a bell on the client, mouse button pushes/pointer movements,
etc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19145 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoComment #endifs so you can tell what they match.
guy [Mon, 4 Sep 2006 23:23:16 +0000 (23:23 +0000)]
Comment #endifs so you can tell what they match.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19144 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoBuild with rtp_player.c.
guy [Mon, 4 Sep 2006 23:22:39 +0000 (23:22 +0000)]
Build with rtp_player.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19143 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd RCS IDs, introductory comments, and multiple-include protection.
guy [Mon, 4 Sep 2006 23:21:52 +0000 (23:21 +0000)]
Add RCS IDs, introductory comments, and multiple-include protection.
Remove extra blank lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19142 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoDeclare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
guy [Mon, 4 Sep 2006 23:20:52 +0000 (23:20 +0000)]
Declare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19141 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAC_CHECK_TYPE outputs a "Checking..." message; we don't need to issue
guy [Mon, 4 Sep 2006 22:47:16 +0000 (22:47 +0000)]
AC_CHECK_TYPE outputs a "Checking..." message; we don't need to issue
one ourselves.

The documentation for autoconf isn't very clear on the "includes"
argument to AC_CHECK_TYPE - it's in the form of a list of #include
statements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19140 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix(?) bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
etxrab [Mon, 4 Sep 2006 21:07:35 +0000 (21:07 +0000)]
Fix(?) bug bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
Does the string need to be freed ad destruction of the hashtable?

Surplus add_text removed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19139 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAlways dissect SDP info to set up RTP conversation.
etxrab [Mon, 4 Sep 2006 20:36:52 +0000 (20:36 +0000)]
Always dissect SDP info to set up RTP conversation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19138 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix a typo for rtp_player
etxrab [Mon, 4 Sep 2006 18:11:02 +0000 (18:11 +0000)]
Fix a typo for rtp_player

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19137 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Oleg Kostenko:
etxrab [Mon, 4 Sep 2006 18:10:14 +0000 (18:10 +0000)]
From Oleg Kostenko:
This patch will add the following functionality to the H.248
 dissector:

 1. Dissection of properties from Annex C.11 SDP equivalents.

 2. Dissection of EventNames and SignalNames from Annex E Basic
Packages.

 3. Dissection of event and signal parameters from Annex E.9 Analog
 Line Supervision Package.

 4. Dissection of statistics from Annex E.11 Network Package and
 Annex E.12 RTP Package.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19136 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoCorrect some typos and add some comments.
etxrab [Mon, 4 Sep 2006 18:04:10 +0000 (18:04 +0000)]
Correct some typos and add some comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19135 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoThe previous way of (not) including portaudio support didn't
jmayer [Mon, 4 Sep 2006 14:19:12 +0000 (14:19 +0000)]
The previous way of (not) including portaudio support didn't
work reliably (at least it didn't work on my system).
Change it to just wrap the rtp_player.[hc] files into a
#if defined(...) #endif.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19134 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAfter some reading it is clear that the code was written for
jmayer [Mon, 4 Sep 2006 14:16:50 +0000 (14:16 +0000)]
After some reading it is clear that the code was written for
portaudio versions <= 18. At least Suse 10.1 provides a snapshot
of version 19, which, in turn has the brand new and incompatible
version 2.0 of the API. Change the error message to tell the
user that he needs portaudio <= 18.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19133 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Donald White:
jake [Mon, 4 Sep 2006 14:12:26 +0000 (14:12 +0000)]
From Donald White:
First, the length of the header of a sub-frame may be miscalculated if
if the PID field is not present, but was present in a previous
sub-frame.  The calculation of the header length will use the value from
the previous sub-frame.

Second, correct the typo "ength" to "length".

Third, the length of the current sub-frame was not passed as the
reported length to a sub-dissector.  When the sub-dissector calls
tvb_reported_length(), the function returns the length of the complete
frame and not the length of the sub-frame to be dissected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19132 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUse portaudio if it's there. Check that we have the right version.
jmayer [Mon, 4 Sep 2006 13:34:48 +0000 (13:34 +0000)]
Use portaudio if it's there. Check that we have the right version.
Note: This check is currently carried out by checking that the include
defines PortAudioStream. If you know of any better check, please let
me know.

acinclude.m4:
Replace sequences of 8 spaces by tab

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19131 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoPartial implementation of UMTS FP. Currently only works with Catapult DCT2000 format...
martinm [Mon, 4 Sep 2006 11:04:14 +0000 (11:04 +0000)]
Partial implementation of UMTS FP.  Currently only works with Catapult DCT2000 format files, as need extra information about packet when decoding.  There are a few TODOs (notably E-DCH channels), but the current version gives OK coverage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19130 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agokrb4 is a new style dissector and is called through a handle from krb5 which is also...
sahlberg [Mon, 4 Sep 2006 08:18:52 +0000 (08:18 +0000)]
krb4 is a new style dissector and is called through a handle from krb5 which is also new style.

use call_dissector_only()  which is new-style aware and not call_dissector() which is not.

this fixes a recent bug found on the heimdal list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19129 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomake the heuristics for detecting kerberos4 stronger
sahlberg [Mon, 4 Sep 2006 07:44:30 +0000 (07:44 +0000)]
make the heuristics for detecting kerberos4 stronger

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19128 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAd $Id: § and reorder and reformat some comments in the header.
jmayer [Sun, 3 Sep 2006 15:41:42 +0000 (15:41 +0000)]
Ad $Id: Â§ and reorder and reformat some comments in the header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19127 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoComment out debug code.
etxrab [Sat, 2 Sep 2006 23:21:59 +0000 (23:21 +0000)]
Comment out debug code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19126 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom David Buechi
sahlberg [Sat, 2 Sep 2006 23:18:38 +0000 (23:18 +0000)]
From David Buechi
New protocol: epl v1

Hi,

in addition to the recently submitted dissector for the EPL v2 protocol,
this is the dissector for the first version of the EPL protocol.

Best Regards,
David

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19125 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoPackages can have digits and '/' in their names...
etxrab [Sat, 2 Sep 2006 16:56:22 +0000 (16:56 +0000)]
Packages can have digits and '/' in their names...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19124 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoInclude codecs in the all target.
etxrab [Sat, 2 Sep 2006 16:55:31 +0000 (16:55 +0000)]
Include codecs in the all target.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19123 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove some extra output for MediaDescriptor.
etxrab [Sat, 2 Sep 2006 16:05:03 +0000 (16:05 +0000)]
Remove some extra output for MediaDescriptor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19122 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1080.
etxrab [Sat, 2 Sep 2006 15:50:24 +0000 (15:50 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=1080.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19121 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix path and name.
etxrab [Sat, 2 Sep 2006 14:18:47 +0000 (14:18 +0000)]
Fix path and name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19120 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd primitive reassembly of gssapi
sahlberg [Sat, 2 Sep 2006 11:46:15 +0000 (11:46 +0000)]
add primitive reassembly of gssapi

this will allow reassembly of gssapi blobs that span multiple smb/sessionsetup command pdus

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19119 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoSquelch compiler warnings, and get rid of unused variables and
guy [Sat, 2 Sep 2006 07:18:16 +0000 (07:18 +0000)]
Squelch compiler warnings, and get rid of unused variables and
declarations.

Define functions with no arguments as such.

Clean up white space.

Declare tables in the codec .h files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19118 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMove the codecs into a top-level "codecs" subdirectory; there's no
guy [Sat, 2 Sep 2006 06:39:43 +0000 (06:39 +0000)]
Move the codecs into a top-level "codecs" subdirectory; there's no
guarantee that all programs using the codecs will necessarily be using
GTK+.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19117 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoClean up indentation, etc.
guy [Sat, 2 Sep 2006 06:39:09 +0000 (06:39 +0000)]
Clean up indentation, etc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19116 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd a common routine for adding session IDs. Have it handle session IDs
guy [Sat, 2 Sep 2006 06:38:21 +0000 (06:38 +0000)]
Add a common routine for adding session IDs.  Have it handle session IDs
from 1 to 8 bytes, and not only handle 0-byte session IDs as special,
have it handle session IDs > 8 bytes as special as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19115 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd brackets to squelch a compiler warning.
guy [Sat, 2 Sep 2006 06:36:42 +0000 (06:36 +0000)]
Add brackets to squelch a compiler warning.

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19114 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agobreak out the handling of conversation specific data so that we will always have...
sahlberg [Sat, 2 Sep 2006 02:03:26 +0000 (02:03 +0000)]
break out the handling of conversation specific data so that we will always have one such struct (and not an value pointer to an oid struct)
so that it is easier to attach other useage to the conversation specific state

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19113 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoresolve the oid to a variable before we check it in the conditional so that
sahlberg [Sat, 2 Sep 2006 00:43:19 +0000 (00:43 +0000)]
resolve the oid to a variable before we check it in the conditional so that
we can add code to check that it looks sane (for better heuristics) when
we start adding GSS-KRB reassembly.

we need this for some transports such as SMB/SessionSetup that will transport GSS-KRB blobs inside multiple PDUs (multiple different SMB/SessionSetups) so we can reassemble the blobs before decoding them.

this probably only happens for SMB/SessionSetup   but the design of that command is so "nice" that you can not tell whether the blob is fragmented or not or how big it is supposed to be by looking at the SMB layer itself, one needs to know the BER length field for the BER APPLICATION tag. :-(

to make things worse, the only way match multiple such fragments together one will need not just the fragments from the SessionSetup requests  but also the UID that is returned in the response to the initial request.
perverse design.

lets assume that there will almost never be multiple sessionsetups on the same tcp session in real traces    so to make things easier just ignore the UID for now when reassembling. (well reassembly is not added yet but will be)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19112 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove a comment with dead code
sahlberg [Sat, 2 Sep 2006 00:24:31 +0000 (00:24 +0000)]
remove a comment with dead code
remove three pointless volatile declarations

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19111 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoalways create a conversation for gssapi
sahlberg [Sat, 2 Sep 2006 00:17:35 +0000 (00:17 +0000)]
always create a conversation for gssapi

we will need a conversation in more places once we start adding reassembly of gss-krb blobs that span multiple pdus (smb/sessionsetup)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19110 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Florent Drouin:
etxrab [Fri, 1 Sep 2006 16:17:48 +0000 (16:17 +0000)]
From Florent Drouin:
patch to implement the decoding of the GPRS reference. The specific oid for the CAP-GPRS-ReferenceNumber is attached to a decoding function in the camel module.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19108 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Add svn:ignore
jmayer [Fri, 1 Sep 2006 04:26:53 +0000 (04:26 +0000)]
- Add svn:ignore
- Replace the completely wrong Makefile.am (was a copy of makefile.nmake)
  by the version the author sent. As I needed to retrieve it from the ML
  archives, it may be different from the originally sent version. If
  someone still has the original version in his inbox, please send it to
  me.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19107 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomark the "short segment" message field as generated and add an expert_info to it
ulfl [Thu, 31 Aug 2006 23:00:44 +0000 (23:00 +0000)]
mark the "short segment" message field as generated and add an expert_info to it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19106 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agouse an expert_info instead of an fprintf to show an undecoded message (fprintf won...
ulfl [Thu, 31 Aug 2006 22:58:22 +0000 (22:58 +0000)]
use an expert_info instead of an fprintf to show an undecoded message (fprintf won't work on windows as usually no console available)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19105 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomove value_strings from expert_dialogs into expert.c to remove duplicates
ulfl [Thu, 31 Aug 2006 22:56:38 +0000 (22:56 +0000)]
move value_strings from expert_dialogs into expert.c to remove duplicates
keep the highest severity level of the current file (experimental)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19104 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAlbert Chin:
jmayer [Thu, 31 Aug 2006 13:14:48 +0000 (13:14 +0000)]
Albert Chin:

Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1078

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19103 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodon't recycle ethereal-icons
jmayer [Thu, 31 Aug 2006 13:12:09 +0000 (13:12 +0000)]
don't recycle ethereal-icons

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19102 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodont include config.nmake in the codecs makefile it appears it is not needed
sahlberg [Thu, 31 Aug 2006 12:13:12 +0000 (12:13 +0000)]
dont include config.nmake in the codecs makefile    it appears it is not needed

dont link with libcodec.a
1, this should be a shared library not a static one?
2, its not built on unix so it is missing

making unix/linux build work again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19101 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agothe commands for a rule in a amkefile must in classical makefiles start with a TAB...
sahlberg [Thu, 31 Aug 2006 09:37:02 +0000 (09:37 +0000)]
the commands for a rule in a amkefile must in classical makefiles start with a TAB not with spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19100 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove trailing backslash from CFLAGS
jake [Thu, 31 Aug 2006 06:58:29 +0000 (06:58 +0000)]
Remove trailing backslash from CFLAGS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19099 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoa huge redesign of the settings in config.nmake
ulfl [Thu, 31 Aug 2006 01:50:11 +0000 (01:50 +0000)]
a huge redesign of the settings in config.nmake

most changes are related to comments and the sequence of the settings, so by comparing the old and the new file, any merge conflicts will be hopefully easily resolved at least manually.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19098 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago remove the MAKENSIS_MODERN_UI, as the modern UI of NSIS is very stable now so there...
ulfl [Wed, 30 Aug 2006 23:27:37 +0000 (23:27 +0000)]
 remove the MAKENSIS_MODERN_UI, as the modern UI of NSIS is very stable now so there's no need for this setting any longer (removing some unnecessary complexity)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19097 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove the MAKENSIS_MODERN_UI, as the modern UI of NSIS is very stable now so there...
ulfl [Wed, 30 Aug 2006 23:25:15 +0000 (23:25 +0000)]
remove the MAKENSIS_MODERN_UI, as the modern UI of NSIS is very stable now so there's no need for this setting any longer (removing some unnecessary complexity)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19096 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix a suspected typo of the portaudio commit
ulfl [Wed, 30 Aug 2006 22:26:34 +0000 (22:26 +0000)]
fix a suspected typo of the portaudio commit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19095 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Alejandro Vaquero:
etxrab [Wed, 30 Aug 2006 21:51:31 +0000 (21:51 +0000)]
From Alejandro Vaquero:
- Change the "listen_rtp" to "rtp_player"
- Change from a plugin to be part of the core
- By default it will not compile with the rtp_player. In order to
compile it is necessary to:
       + For windows: uncomment the line
"PORTAUDIO_DIR=$(WIRESHARK_LIBS)\portaudio_v18_1" in config.nmake
       + For linux: using the "--with-portaudio=yes"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19094 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Alejandro Vaquero:
etxrab [Wed, 30 Aug 2006 20:50:37 +0000 (20:50 +0000)]
From Alejandro Vaquero:
- Change the "listen_rtp" to "rtp_player"
- Change from a plugin to be part of the core
- By default it will not compile with the rtp_player. In order to
compile it is necessary to:
       + For windows: uncomment the line
"PORTAUDIO_DIR=$(WIRESHARK_LIBS)\portaudio_v18_1" in config.nmake
       + For linux: using the "--with-portaudio=yes"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19093 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Alejandro Vaquero:
etxrab [Wed, 30 Aug 2006 20:47:16 +0000 (20:47 +0000)]
From Alejandro Vaquero:
The "codecs"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19092 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove a lot of XXX:
ulfl [Wed, 30 Aug 2006 20:45:13 +0000 (20:45 +0000)]
Remove a lot of XXX:
- add help buttons to the dialogs
- the read filter fields are now working (the filter button still not)
- PDML export don't need "Packet Format" settings, grey them out
- fix a bug in the filter fields coloring function (g_alloc space was too small)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19091 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agohave only one Export/File menu entry for the Win32 dialog, instead of 5 entries leadi...
ulfl [Wed, 30 Aug 2006 20:38:17 +0000 (20:38 +0000)]
have only one Export/File menu entry for the Win32 dialog, instead of 5 entries leading to exactly the same dialog (with a single setting - the file type - set different)

we might want the Unix/GTK version work the same way, as this is how other programs I know work as well ... and making the documentation easier by desribing only one way how it's working

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19090 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd some file dialog related help pages
ulfl [Wed, 30 Aug 2006 20:27:12 +0000 (20:27 +0000)]
add some file dialog related help pages

use file related instead of print related help pages for the export dialogs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19089 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoseems the height offset 16 seems a bit too small to prevent a scrollbar, using 20...
ulfl [Wed, 30 Aug 2006 20:24:49 +0000 (20:24 +0000)]
seems the height offset 16 seems a bit too small to prevent a scrollbar, using 20 instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19088 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Alejandro Vaquero:
etxrab [Wed, 30 Aug 2006 19:27:54 +0000 (19:27 +0000)]
From Alejandro Vaquero:
- The current "/plugin/listen_rtp" directory should be removed from the
source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19087 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoflags have only 1 byte
kukosa [Wed, 30 Aug 2006 10:03:50 +0000 (10:03 +0000)]
flags have only 1 byte

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19086 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd SIP response code 494 from RFC 3329
martinm [Wed, 30 Aug 2006 09:48:12 +0000 (09:48 +0000)]
Add SIP response code 494 from RFC 3329

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19085 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodisplay Random as a single item with two subitems
kukosa [Wed, 30 Aug 2006 07:31:36 +0000 (07:31 +0000)]
display Random as a single item with two subitems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19084 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove debugcode left by mistake...
etxrab [Wed, 30 Aug 2006 05:03:16 +0000 (05:03 +0000)]
Remove debugcode left by mistake...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19083 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd CLNP over TCP over TPKT dissection. The port number is by default set to 0.
etxrab [Tue, 29 Aug 2006 22:18:39 +0000 (22:18 +0000)]
Add CLNP over TCP over TPKT dissection. The port number is by default set to 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19082 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agosort the u3.c file into the list alphabetically
ulfl [Tue, 29 Aug 2006 21:12:45 +0000 (21:12 +0000)]
sort the u3.c file into the list alphabetically

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19081 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix #331: add a scrollbar to the dialog. If a fileset contains more than 18 files...
ulfl [Tue, 29 Aug 2006 21:09:32 +0000 (21:09 +0000)]
fix #331: add a scrollbar to the dialog. If a fileset contains more than 18 files, use that scrollbar. These 18 files should be displayable even on a 800*600 display.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19080 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd u3.h to the distribution files (hopefully this fixes ubuntu buildbot distcheck)
ulfl [Tue, 29 Aug 2006 21:06:36 +0000 (21:06 +0000)]
add u3.h to the distribution files (hopefully this fixes ubuntu buildbot distcheck)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19079 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix a minor bug: don't show a single file twice in the fileset dialog
ulfl [Tue, 29 Aug 2006 21:03:33 +0000 (21:03 +0000)]
fix a minor bug: don't show a single file twice in the fileset dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19078 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agouse unique variable names to prevent "global variable" side effects -> endless repeat...
ulfl [Tue, 29 Aug 2006 21:01:05 +0000 (21:01 +0000)]
use unique variable names to prevent "global variable" side effects -> endless repeating tests of subsections

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19077 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Update to 0.9.5 (from 0.9.4)
jmayer [Tue, 29 Aug 2006 20:21:47 +0000 (20:21 +0000)]
- Update to 0.9.5 (from 0.9.4)
- Remove some unneeded entries
- Add a translation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19076 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for bug 795: handle CR as line end as well
jake [Tue, 29 Aug 2006 16:54:39 +0000 (16:54 +0000)]
Fix for bug 795: handle CR as line end as well

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19075 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFlorent DROUIN <florent.drouin@alcatel.fr>:
jmayer [Tue, 29 Aug 2006 16:31:00 +0000 (16:31 +0000)]
Florent DROUIN <florent.drouin@alcatel.fr>:

Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1077

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19074 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFixes and updated files:
gmorris [Tue, 29 Aug 2006 08:45:53 +0000 (08:45 +0000)]
Fixes and updated files:

File NCP2222.py:
1. Added NCP service type 0xffff = All types
2. Added evaluation of task states. (following bits are defined. 0=normal, 1 = TTS explicit transaction in progress, 2= TTS implicit transaction in progress, 4 = Shared file ste lock in progress)
3. Reversed the Volume Request Flags, this was backwards (s/b 0=do not return name with volume number, 1=Return name with volume number)
4. Fixed endianess of Creator ID in NetWare Information Struct.
5. File information structure incorrectly defined Current Block Being Decompressed.
6. Logical Lock Status structure incorrectly identified Task Number as a byte. It should be two bytes "word".
7. Fixed endianess of Modifier ID in NetWare Information Struct.
8. Fixed Name Space Information structure (was defined as Name Space, changed to Creator Name Space Number).
9. Fixed Semaphore Structure (Task Number was incorrectly defined as a byte, should be two bytes "word").
10. Added Task structure (Task Number, Task State)
11. Fixed Volume structure (incorrectly defined Volume Name)
12. Added VolumeWithName structure (This struct contains both volume number and volume name)
13. Added error 0x8901 - "No purgable files available"
14. Added error 0x8977 - "Buffer too small"
15. Added error 0x899c - "No more trustees found"
16. Added error 0x89d9 - "Queue station is not a server"
17. Added NCP connection status values (0=Ok, 1=Bad service connection, 10=File server is down, 40=Broadcast Message Pending)
18. Fixed error definitions for NCP 22/50.
19. Fixed reply packet for NCP 22/52 to properly display volume information depending on reply struct, Volume or volume with name.
20. Fixed error definitions for NCP 22/52
21. Fixed NCP 23/26 reply packet to properly return internet address and display correctly.
22. Fixed NCP 23/27 Reply packet structure to properly repeat connection numbers array.
23. Fixed error definitions for NCP 23/33
24. Fixed NCP 23/114 Request (improperly defined Charge Information as a long value, s/b word)
25. Fixed NCP 23/120 Reply (Improperly defined Job Number as a long value, s/b word)
26. Fixed error definitions for NCP 23/123
27. Fixed error definitions for NCP 23/124
28. Fixed error definitions for NCP 23/131
29. Fixed error definitions for NCP 23/132
30. Fixed error definitions for NCP 23/135
31. Fixed error definitions for NCP 23/137
32. Fixed error definitions for NCP 23/138
33. Fixed NCP 23/205 Reply (User Login Allowed incorrectly defined as long value, s/b byte value)
34. Fixed NCP 23/234 Reply (Reply structure incorrectly defined based on old NCP documentation. Corrected per new docs)
35. Fixed endianess of NCP 23/237 Reply on value Number of Locks.
36. Fixed endianess of NCP 23/238 Reply on value Number of Locks.
37. Fixed error definitions for NCP 30
38. Fixed error definitions for NCP 36/6
39. Fixed error definitions for NCP 86/2
40. Fixed error definitions for NCP 86/3
41. Fixed error definitions for NCP 86/4
42. Fixed error definitions for NCP 86/5
43. Fixed error definitions for NCP 87/1
44. Fixed error definitions for NCP 87/4
45. Fixed error definitions for NCP 87/5
46. Fixed error definitions for NCP 87/10
47. Fixed error definitions for NCP 87/11
48. Fixed error definitions for NCP 87/12
49. Fixed error definitions for NCP 87/17
50. Fixed error definitions for NCP 87/18
51. Fixed NCP 87/20 Reply to properly decode multiple entries returned. This used to only dissect the first entry.
52. Fixed error definitions for NCP 87/30
53. Fixed NCP 87/33 Reply to properly utilize the request flags to dissect the reply packet NetWare Info Struct
54. Fixed error definitions for NCP 87/33
55. Fixed error definitions for NCP 88/22
56. Fixed error definitions for NCP 89/1
57. Fixed error definitions for NCP 89/10
58. Fixed NCP 89/11 Request packet structure
59. Fixed error definitions for NCP 89/11
60. Fixed NCP 89/20 Reply to properly decode multiple entries returned. This used to only dissect the first entry.
61. Fixed error definitions for NCP 104/5
62. Added undefined NCP 112
63. Fixed NCP 123/11 Reply to properly dissect FileName, Name, and copyright.
64. Fixed NCP 123/17 Reply to properly display NCP Network Address values.
65. Fixed NCP 123/24 Reply to properly display Driver Board Name, Driver Short Name, and Dirver Logical Name.
66. Fixed error definitions for NCP 123/33
67. Fixed NCP 123/60 to properly display Set Command Name and Set Command Value.
68. Fixed error definitions for NCP 123/70
69. Fixed NCP 123/71 Reply to utilize new File Information Struct
70. Fixed error definitions for NCP 123/71
71. Fixed error definitions for NCP 123/72
72. Added NCP 123/249
73. Added NCP 123/251
74. Added NCP 123/252
75. Added NCP 123/253
76. Added NCP 123/254
77. Added NCP 123/255
78. Fixed error definitions for NCP 131/1
79. Fixed error definitions for NCP 131/2

File packet-ncp2222.inc
1. Added new NCP preference setting to tell Wireshark to decode the NetWare information structure as new or old style.
2. Set default NCP preference settings of echo connection and echo file to FALSE.
3. Added NDS verb 2 Request Flags (0=retain old object, 1=delete old object)
4. Fixed problem where NDS fragmentation could not be reassembled on reload. (fragment array needed to be re-initialized on reload)
5. Fixed NCP service types 1111, 5555, bbbb, and 1111/LIP to reflect real type number. (Was defined as 0xf1, 0xf2, 0xf3, etc... Now defined as 0x1, 0x5, 0xb, etc)
6. Fixed function build_expert_data to parse subtree memory structures to acquire NCP request value records
7. Fix NDS attribute type Boolean to byte value and properly aligned.
8. Fixed attribute zendmSearchOrder to display properly regardless of number or order of value entries.
9. Added check of length of packet prior to attempting to defragment
10. Added for Request packets logic to abort if NCP type isn't found.
11. Added logic to store packet length and then manually decode NCP function 123 based on length.
12. Added logic to manually dissect NCP 87/20 and 89/20 reply packets.
13. NDS resolve name replies with remote entry as the specifier should not store the EID returned (0x00000000)
14. Added logic to trap and echo to expert tap when connection status flags indicate an error.
15. Added manual dissect of NCP 23/26 replies
16. Added logic to Capture the EID returned form NCP 22/51 "Get vol info".
17. Fixed NDS verb 0x2a
18. Fixed NDS verb 0x2b

File packet-ncp.c
1. Fix offset for packet signature. (This used to automatically set the offset to account for packet signature if it could not determine the correct NCP type. But for some failed fragment packets, retransmissions, etc, this would be wrongly identified. So first we check to see if we can read a valid type at the offset before we just automatically assume that packet signature is being used)
2. Register the new NCP preference for old/new NetWareInfoStruct.

File packet-ncp-int.h
1. Add extern declaration for ncp_newstyle setting.
2. Add length, req_mask, and req_mast_ext to ncp_req_hash_value structure

File packet-ncp-sss.c
1. Fix SecretStore request verb Write App Secrets, Client Put Data, to evaluate packet length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19073 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoget rid of few warnings
kukosa [Tue, 29 Aug 2006 08:33:52 +0000 (08:33 +0000)]
get rid of few warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19072 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd a missing file.
gerald [Tue, 29 Aug 2006 02:19:27 +0000 (02:19 +0000)]
Add a missing file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19071 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofrom Stephen Fisher:
ulfl [Tue, 29 Aug 2006 00:15:09 +0000 (00:15 +0000)]
from Stephen Fisher:

"I ran doc/README.developer through a spell checker and conservatively
changed misspelled words.  Attached is a compressed patch with the
corrections."

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19070 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix #1061: the logic to search for a specific protocol page was missing the changes...
ulfl [Mon, 28 Aug 2006 22:54:12 +0000 (22:54 +0000)]
fix #1061: the logic to search for a specific protocol page was missing the changes of the scrollable window indirection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19069 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix a typo.
gerald [Mon, 28 Aug 2006 22:52:26 +0000 (22:52 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19068 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix a minor typo
ulfl [Mon, 28 Aug 2006 22:23:18 +0000 (22:23 +0000)]
fix a minor typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19067 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd a new this/that flag value
ulfl [Mon, 28 Aug 2006 21:14:36 +0000 (21:14 +0000)]
add a new this/that flag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19066 f5534014-38df-0310-8fa8-9805f1628bb7