obnox/wireshark/wip.git
8 years agoDon't assign to a proto_item * if the value won't be used: Coverity 823 & 824;
wmeier [Mon, 4 Apr 2011 16:13:42 +0000 (16:13 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 823 & 824;
Fix a minor bug wherein a proto_tree_add_text used the wrong tree: Coverity 825;
Remove some unneeded #includes;
Use consistent indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36449 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't build a manifest if we don't need one.
gerald [Mon, 4 Apr 2011 15:41:07 +0000 (15:41 +0000)]
Don't build a manifest if we don't need one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36448 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't assign to a proto_item * if the value won't be used: Coverity 820/821;
wmeier [Mon, 4 Apr 2011 15:38:19 +0000 (15:38 +0000)]
Don't assign to a proto_item * if the value won't be used: Coverity 820/821;
Also: #include <stdio.h> & <string.h> not required;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36447 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't assign to a variable if the value won't be used: Coverity 817-821.
wmeier [Mon, 4 Apr 2011 15:31:33 +0000 (15:31 +0000)]
Don't assign to a variable if the value won't be used: Coverity 817-821.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36446 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMark pinfo as unused.
etxrab [Mon, 4 Apr 2011 15:09:22 +0000 (15:09 +0000)]
Mark pinfo as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36445 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoGet rid of gsm_a_dtap_pinfo.
etxrab [Mon, 4 Apr 2011 14:49:14 +0000 (14:49 +0000)]
Get rid of gsm_a_dtap_pinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36444 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoChange the signature of elem_fcn():ns to include pinfo.
etxrab [Mon, 4 Apr 2011 14:37:25 +0000 (14:37 +0000)]
Change the signature of elem_fcn():ns to include pinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36443 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Vincent Helfre:
etxrab [Mon, 4 Apr 2011 14:35:21 +0000 (14:35 +0000)]
From Vincent Helfre:
updated the script that extracts the asn1 from the specification (we modified it after noticing that it currently fails to take the IMPORT section). It should also work now to extract the WCDMA RRC (TS 25.331).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36442 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoChange the msg_fcn() signature to include pinfo.
etxrab [Mon, 4 Apr 2011 07:45:34 +0000 (07:45 +0000)]
Change the msg_fcn() signature to include pinfo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36441 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom jakub Zawadzki:
etxrab [Mon, 4 Apr 2011 05:48:06 +0000 (05:48 +0000)]
From jakub Zawadzki:
I've fixed composite tests #0 and #2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36440 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't assign to a proto_item* if the value won't be used: Coverity 885-889
wmeier [Sun, 3 Apr 2011 15:39:01 +0000 (15:39 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 885-889
Also: Significant code rework including:
  - Fix bug wherein a timestamp was incorrectly reported as being an Error;
  - Replace many proto_tree_add_text()/proto_item_set_text() sequences each by a
    single proto_tree_add_text().
  - remove unneeded #include <string.h>
  - Whitespace clanup including replacing mixed space/tab indentation by spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36437 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago[Automatic manuf, services and enterprise-numbers update for 2011-04-03]
gerald [Sun, 3 Apr 2011 15:03:50 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-04-03]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36436 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago-Whitespace fix in gsm_map-template(no need to regenerate).
etxrab [Sat, 2 Apr 2011 09:18:18 +0000 (09:18 +0000)]
-Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36435 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd some info as to the determination of the length of a FT_STRINGZ item.
wmeier [Fri, 1 Apr 2011 20:48:56 +0000 (20:48 +0000)]
Add some info as to the determination of the length of a FT_STRINGZ item.
Add a note not leaving trailing whitespace on a line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36434 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
morriss [Fri, 1 Apr 2011 19:50:50 +0000 (19:50 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :

Patch 6 :
Enhance the MySQL collation

Patch 7 :
Enhance MySQL : add dissection of command Binlog Dump (replicate command).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36433 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAvoid potential buffer overruns when sscanf'ing strings.
cmaynard [Fri, 1 Apr 2011 18:16:47 +0000 (18:16 +0000)]
Avoid potential buffer overruns when sscanf'ing strings.
Should resolve CID's 656 and 657.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36432 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't use pParser->yyidx as an index into pParser->yystack[] until after it is
cmaynard [Fri, 1 Apr 2011 16:55:59 +0000 (16:55 +0000)]
Don't use pParser->yyidx as an index into pParser->yystack[] until after it is
verified that it is non-negative.  Should resolve CID 619.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36431 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemove const type qualifier from cast. Resolves CID's 582-585.
cmaynard [Fri, 1 Apr 2011 16:30:59 +0000 (16:30 +0000)]
Remove const type qualifier from cast.  Resolves CID's 582-585.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36430 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoTake care not to append RLC mode to proto_item twice.
martinm [Fri, 1 Apr 2011 13:41:08 +0000 (13:41 +0000)]
Take care not to append RLC mode to proto_item twice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36429 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRename local 'pipe_input' so it doesn't shadow global 'pipe_input';
wmeier [Thu, 31 Mar 2011 20:57:40 +0000 (20:57 +0000)]
Rename local 'pipe_input' so it doesn't shadow global 'pipe_input';
Use consistent indentation and remove trailing whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36428 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMemory leak in lemon.c
sahlberg [Thu, 31 Mar 2011 20:50:13 +0000 (20:50 +0000)]
Memory leak in lemon.c

coverity 1177

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36427 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix 11 occurrences of returned pointer never used. Fixes CID's 1064-1067.
cmaynard [Thu, 31 Mar 2011 19:17:06 +0000 (19:17 +0000)]
Fix 11 occurrences of returned pointer never used.  Fixes CID's 1064-1067.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36426 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCheck return value of file_seek(). Fixes CID 338.
cmaynard [Thu, 31 Mar 2011 18:28:52 +0000 (18:28 +0000)]
Check return value of file_seek().  Fixes CID 338.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36425 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't dereference a NULL pointer. Fixes CID 426.
cmaynard [Thu, 31 Mar 2011 18:00:26 +0000 (18:00 +0000)]
Don't dereference a NULL pointer.  Fixes CID 426.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36424 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoseparator will never be NULL, but sep_len could be 0, so test for that instead.
cmaynard [Thu, 31 Mar 2011 17:27:48 +0000 (17:27 +0000)]
separator will never be NULL, but sep_len could be 0, so test for that instead.
Fixes CID 620.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36423 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse BSWAP16 instead of BSWAP32 for 16-bit values. Fixes CID's 1179 and 1180.
cmaynard [Thu, 31 Mar 2011 16:46:16 +0000 (16:46 +0000)]
Use BSWAP16 instead of BSWAP32 for 16-bit values.  Fixes CID's 1179 and 1180.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36422 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse a common function, higher_priority_status_level() to determine whether or
cmaynard [Thu, 31 Mar 2011 16:23:07 +0000 (16:23 +0000)]
Use a common function, higher_priority_status_level() to determine whether or
not messages should be pushed onto the statusbar.  Should fix CID 270.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36421 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoClear the entire contents of ctx at the end of md5_finish(). Fixes CID 712.
cmaynard [Thu, 31 Mar 2011 15:41:23 +0000 (15:41 +0000)]
Clear the entire contents of ctx at the end of md5_finish().  Fixes CID 712.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36420 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were:
cmaynard [Thu, 31 Mar 2011 15:17:49 +0000 (15:17 +0000)]
From Alexis La Goutte via bug 5790: Fix 8 clang warnings, all of which were:
"warning: Value stored to 'offset' is never read".  The 'offset' is now used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36419 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDelete unused header fields found by running tools/checkhf.pl.
cmaynard [Thu, 31 Mar 2011 14:35:40 +0000 (14:35 +0000)]
Delete unused header fields found by running tools/checkhf.pl.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36418 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago(Trivial) Fix some typos; do some whitespace cleanup & rewording of comments.
wmeier [Thu, 31 Mar 2011 14:30:38 +0000 (14:30 +0000)]
(Trivial) Fix some typos; do some whitespace cleanup & rewording of comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36417 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Yair via bug 5779: Add option to leave AAL5 in unspecified format.
cmaynard [Thu, 31 Mar 2011 14:23:07 +0000 (14:23 +0000)]
From Yair via bug 5779: Add option to leave AAL5 in unspecified format.
(... with whitepsace changes by me.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36416 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Andrew Feren via bug 5775: Correct types on several info elements.
cmaynard [Thu, 31 Mar 2011 14:03:23 +0000 (14:03 +0000)]
From Andrew Feren via bug 5775: Correct types on several info elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36415 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRegister tcp by name.
stig [Thu, 31 Mar 2011 12:18:14 +0000 (12:18 +0000)]
Register tcp by name.
To be used in User DLT's and Lua scripts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36414 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse correct functions to fetch protocol name for a dissector registered
stig [Thu, 31 Mar 2011 12:16:41 +0000 (12:16 +0000)]
Use correct functions to fetch protocol name for a dissector registered
by register_dissector().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36413 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded dissector_handle_get_long_name().
stig [Thu, 31 Mar 2011 12:14:59 +0000 (12:14 +0000)]
Added dissector_handle_get_long_name().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36412 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse correct length for clientaddr4 callback address entry.
stig [Thu, 31 Mar 2011 11:01:06 +0000 (11:01 +0000)]
Use correct length for clientaddr4 callback address entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36411 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix a couple of typos.
cmaynard [Wed, 30 Mar 2011 15:54:28 +0000 (15:54 +0000)]
Fix a couple of typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36410 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom: http://www.wireshark.org/lists/wireshark-dev/201103/msg00157.html
cmaynard [Wed, 30 Mar 2011 14:53:09 +0000 (14:53 +0000)]
From: wireshark.org/lists/wireshark-dev/201103/msg00157.html
Change RTT references to SRT.  (This should have been checked in with r36297.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36409 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoWrap all text lines of help at column 80.
cmaynard [Wed, 30 Mar 2011 14:44:18 +0000 (14:44 +0000)]
Wrap all text lines of help at column 80.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36408 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoremove two pointless const in casts
sahlberg [Wed, 30 Mar 2011 04:36:09 +0000 (04:36 +0000)]
remove two pointless const in casts

coverity 580 and 581

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36407 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoremove some assignments we dont use
sahlberg [Wed, 30 Mar 2011 03:39:58 +0000 (03:39 +0000)]
remove some assignments we dont use

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36406 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoChange TCP_PORT_MANGO to TCP_PORT_MONGO.
cmaynard [Tue, 29 Mar 2011 21:40:54 +0000 (21:40 +0000)]
Change TCP_PORT_MANGO to TCP_PORT_MONGO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36405 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't put a 65536 byte variable on the stack: instead, malloc/free it.
morriss [Tue, 29 Mar 2011 21:39:15 +0000 (21:39 +0000)]
Don't put a 65536 byte variable on the stack: instead, malloc/free it.

Coverity 760-761.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36404 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd a missing break.
etxrab [Tue, 29 Mar 2011 21:20:36 +0000 (21:20 +0000)]
Add a missing break.
CID 487

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36403 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd a missing break.
etxrab [Tue, 29 Mar 2011 21:11:26 +0000 (21:11 +0000)]
Add a missing break.
CID 488

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36402 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd a missing break.
etxrab [Tue, 29 Mar 2011 21:08:34 +0000 (21:08 +0000)]
Add a missing break.
CID 490

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36401 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded FALLTHRU comment to avoid a "missing break" warning.
etxrab [Tue, 29 Mar 2011 21:05:29 +0000 (21:05 +0000)]
Added  FALLTHRU comment to avoid a "missing break" warning.
CID 489

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36400 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via bug 5790: Add partial bit flag in query.
cmaynard [Tue, 29 Mar 2011 20:58:57 +0000 (20:58 +0000)]
From Alexis La Goutte via bug 5790: Add partial bit flag in query.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36399 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoGrab URL from frame info value instead of from tvb. Fixes bug 5780.
cmaynard [Tue, 29 Mar 2011 20:05:33 +0000 (20:05 +0000)]
Grab URL from frame info value instead of from tvb.  Fixes bug 5780.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36398 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't put a 196808 byte variable on the stack: instead, malloc/free it.
morriss [Tue, 29 Mar 2011 14:29:45 +0000 (14:29 +0000)]
Don't put a 196808 byte variable on the stack: instead, malloc/free it.

Coverity 789-790.

Since we've been keeping track of how many bytes we put in the buffer,
use that value instead of calling strlen() find it again.

Also, some white space/indentation cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36397 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemove check_col().
etxrab [Tue, 29 Mar 2011 14:23:21 +0000 (14:23 +0000)]
Remove check_col().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36396 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't assign proto_item pointers that are not used.
martinm [Tue, 29 Mar 2011 14:23:13 +0000 (14:23 +0000)]
Don't assign proto_item pointers that are not used.

Coverity 1174

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36395 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't put a 65536 byte variable on the stack: instead, malloc/free it.
morriss [Tue, 29 Mar 2011 14:05:28 +0000 (14:05 +0000)]
Don't put a 65536 byte variable on the stack: instead, malloc/free it.

Coverity 791-794.

Also, some white space/indentation cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36394 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoGuard against NULL return from find_protocol_by_id().
stig [Tue, 29 Mar 2011 11:09:59 +0000 (11:09 +0000)]
Guard against NULL return from find_protocol_by_id().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36393 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Pascal Quantin:
stig [Tue, 29 Mar 2011 11:08:15 +0000 (11:08 +0000)]
From Pascal Quantin:
Added guard against proto_name's not resolved as protocols.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36392 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRTP: display payload type name from dynamic payload type table
kukosa [Tue, 29 Mar 2011 10:56:30 +0000 (10:56 +0000)]
RTP: display payload type name from dynamic payload type table
H.223: use just one protocol for bot dissectors for more clear protocol disabling

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36391 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoProhibit (memory-unsafe) g_sprintf() and g_vsprintf().
morriss [Tue, 29 Mar 2011 01:27:20 +0000 (01:27 +0000)]
Prohibit (memory-unsafe) g_sprintf() and g_vsprintf().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36390 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoCast to guint to avoid a Windows compiler warning.
cmaynard [Mon, 28 Mar 2011 22:22:05 +0000 (22:22 +0000)]
Cast to guint to avoid a Windows compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36389 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMove -D option into "pre-scan" group as there's no need to start gtk+ for it.
cmaynard [Mon, 28 Mar 2011 22:12:53 +0000 (22:12 +0000)]
Move -D option into "pre-scan" group as there's no need to start gtk+ for it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36388 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).
cmaynard [Mon, 28 Mar 2011 22:10:41 +0000 (22:10 +0000)]
Use fprintf_stderr() instead of printf() so "wireshark -D" works (on Windows).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36387 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.
sfisher [Mon, 28 Mar 2011 20:53:20 +0000 (20:53 +0000)]
Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36386 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUse g_ascii_strdown instead of g_strdown
morriss [Mon, 28 Mar 2011 19:44:41 +0000 (19:44 +0000)]
Use g_ascii_strdown instead of g_strdown

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36385 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMore updates to the wtap_open_offline() comment.
guy [Mon, 28 Mar 2011 17:23:06 +0000 (17:23 +0000)]
More updates to the wtap_open_offline() comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36384 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
cmaynard [Mon, 28 Mar 2011 17:04:58 +0000 (17:04 +0000)]
Don't use prohibited strncpy().  Use g_strlcpy() instead.  Ensures that "orig"
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36383 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't use prohibited strncpy(). In this case, use g_strlcat() instead.
cmaynard [Mon, 28 Mar 2011 16:42:25 +0000 (16:42 +0000)]
Don't use prohibited strncpy().  In this case, use g_strlcat() instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36382 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :
morriss [Mon, 28 Mar 2011 15:28:03 +0000 (15:28 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 :

Fix a Clang warning, add email address, and add some stuff to COL_INFO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36381 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :
morriss [Mon, 28 Mar 2011 15:23:27 +0000 (15:23 +0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 :

Register the reload-framing dissector by name.  Needed when RELOAD is not used
over udp/tcp (but tls, for example)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36380 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :
morriss [Mon, 28 Mar 2011 15:20:16 +0000 (15:20 +0000)]
From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 :

Patch 5

Enchance MySQL :
* Add expert info of when undecoded data
* Fix some white space

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36379 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoMake ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
cmaynard [Mon, 28 Mar 2011 14:53:35 +0000 (14:53 +0000)]
Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in
the value="..." attribute.  Fixes bug 1520.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36378 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded payload, header and trailer information to the DLT tree entry.
stig [Mon, 28 Mar 2011 14:18:29 +0000 (14:18 +0000)]
Added payload, header and trailer information to the DLT tree entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36377 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoUpdate a comment.
etxrab [Mon, 28 Mar 2011 13:09:47 +0000 (13:09 +0000)]
Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36376 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoIf there are more than 4 billion characters in the printable form of a
guy [Sun, 27 Mar 2011 17:26:21 +0000 (17:26 +0000)]
If there are more than 4 billion characters in the printable form of a
network address, we have bigger problems.  Cast the result of strlen()
to int to squelch a compiler warning with MSVC++.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36375 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFix Coverity 393: "DEADCODE"; Add an XXX comment
wmeier [Sun, 27 Mar 2011 16:15:19 +0000 (16:15 +0000)]
Fix Coverity 393: "DEADCODE"; Add an XXX comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36373 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd "-z hosts", which dumps name resolution information in hosts format.
gerald [Sun, 27 Mar 2011 16:06:03 +0000 (16:06 +0000)]
Add "-z hosts", which dumps name resolution information in hosts format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36372 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdd the IPv4 address, not the first 4 bytes of its name, to the
gerald [Sun, 27 Mar 2011 15:58:52 +0000 (15:58 +0000)]
Add the IPv4 address, not the first 4 bytes of its name, to the
resolution table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36370 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago1. Fix bug in dissection of a field; Add two missing lines of code.
wmeier [Sun, 27 Mar 2011 15:39:06 +0000 (15:39 +0000)]
1. Fix bug in dissection of a field; Add two missing lines of code.
2. #if 0 if test "which will never be true"; Add XXX comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36369 f5534014-38df-0310-8fa8-9805f1628bb7

8 years ago[Automatic manuf, services and enterprise-numbers update for 2011-03-27]
gerald [Sun, 27 Mar 2011 15:03:43 +0000 (15:03 +0000)]
[Automatic manuf, services and enterprise-numbers update for 2011-03-27]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36368 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoRemoved uneeded 'continue'.
wmeier [Sun, 27 Mar 2011 14:34:19 +0000 (14:34 +0000)]
Removed uneeded 'continue'.

Fixes Coverity 815 ("UNREACHABLE").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36367 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a FALLTHRU comment to avoid a "missing break" warning.
stig [Sun, 27 Mar 2011 14:11:40 +0000 (14:11 +0000)]
Added a FALLTHRU comment to avoid a "missing break" warning.

Coverity 472.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36366 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded FALLTHRU comment to avoid a "missing break" warning.
etxrab [Sun, 27 Mar 2011 14:02:42 +0000 (14:02 +0000)]
Added  FALLTHRU comment to avoid a "missing break" warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36365 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a missing break.
stig [Sun, 27 Mar 2011 13:56:53 +0000 (13:56 +0000)]
Added a missing break.

Coverity 452.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36364 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a missing break.
stig [Sun, 27 Mar 2011 13:54:53 +0000 (13:54 +0000)]
Added a missing break.

Coverity 461.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36363 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded some missing breaks.
stig [Sun, 27 Mar 2011 13:51:47 +0000 (13:51 +0000)]
Added some missing breaks.

Coverity 462 & 463.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36362 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded some missing breaks.
stig [Sun, 27 Mar 2011 13:40:54 +0000 (13:40 +0000)]
Added some missing breaks.

Coverity 443 & 444.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36361 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded some missing breaks.
stig [Sun, 27 Mar 2011 13:35:30 +0000 (13:35 +0000)]
Added some missing breaks.

Coverity 447.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36360 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a FALLTHRU comment to avoid a "missing break" warning.
stig [Sun, 27 Mar 2011 13:33:28 +0000 (13:33 +0000)]
Added a FALLTHRU comment to avoid a "missing break" warning.

Coverity 458.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36359 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded some missing breaks.
stig [Sun, 27 Mar 2011 13:30:39 +0000 (13:30 +0000)]
Added some missing breaks.

Coverity 466.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36358 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a missing break.
stig [Sun, 27 Mar 2011 13:16:50 +0000 (13:16 +0000)]
Added a missing break.

Coverity 491.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36357 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a missing break.
stig [Sun, 27 Mar 2011 13:15:14 +0000 (13:15 +0000)]
Added a missing break.

Coverity 492.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36356 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoDon't assign to a proto_item* if the value won't be used: Coverity 895-897
wmeier [Sat, 26 Mar 2011 16:39:30 +0000 (16:39 +0000)]
Don't assign to a proto_item* if the value won't be used: Coverity 895-897
Also: Fix some indentation & whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36355 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Alexis La Goutte:
jake [Sat, 26 Mar 2011 16:07:30 +0000 (16:07 +0000)]
From Alexis La Goutte:
A patch to add ATM over TCP Dissector.
The dissector dissect only the ATMTCP header (VCI, VPI, Payload Length)
The data are not yet dissect, it is necessary to add a "UAT" (As with the K12
dissector) to indicate the type (ILMI, AAL, ATM...) of data (based on VCI/VPI)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36354 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a sanity check to remove a coverity warning.
stig [Sat, 26 Mar 2011 15:59:57 +0000 (15:59 +0000)]
Added a sanity check to remove a coverity warning.

Coverity 537.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36353 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded sanity checks for preferences.
stig [Sat, 26 Mar 2011 15:53:55 +0000 (15:53 +0000)]
Added sanity checks for preferences.

Coverity 551 & 553.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36352 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a sanity check in output_fields_set_option.
stig [Sat, 26 Mar 2011 15:39:35 +0000 (15:39 +0000)]
Added a sanity check in output_fields_set_option.

Coverity 552.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36351 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a FALLTHRU comment to avoid a coverity warning.
stig [Sat, 26 Mar 2011 15:24:36 +0000 (15:24 +0000)]
Added a FALLTHRU comment to avoid a coverity warning.

Coverity 480.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36350 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a missing break in graph_select_segment.
stig [Sat, 26 Mar 2011 15:20:37 +0000 (15:20 +0000)]
Added a missing break in graph_select_segment.

Coverity 482.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36349 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoAdded a missing break in hostlist_get_filter_name.
stig [Sat, 26 Mar 2011 15:16:40 +0000 (15:16 +0000)]
Added a missing break in hostlist_get_filter_name.

Coverity 481.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36348 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoFrom Hadar Shoham:
jake [Sat, 26 Mar 2011 11:23:46 +0000 (11:23 +0000)]
From Hadar Shoham:
Add support to correlation ID under DHCPv6 according to
"CL-SP-CANN-DHCP-Reg-I06-110210"
DHCPv6 option 17 Vendor-specific Information, sub option 2172 (paragraph 5.4.3)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36347 f5534014-38df-0310-8fa8-9805f1628bb7

8 years agoremove a proto_item variable we never use
sahlberg [Sat, 26 Mar 2011 05:39:45 +0000 (05:39 +0000)]
remove a proto_item variable we never use

coverity 866

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36346 f5534014-38df-0310-8fa8-9805f1628bb7