obnox/wireshark/wip.git
15 years agoadd a warning, that patch and sources files must have the same line endings (CR/NL)
ulfl [Tue, 28 Sep 2004 18:34:00 +0000 (18:34 +0000)]
add a warning, that patch and sources files must have the same line endings (CR/NL)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12124 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofrom Thomas Palmer: add a combobox for the recently used capture filter strings
ulfl [Tue, 28 Sep 2004 18:04:15 +0000 (18:04 +0000)]
from Thomas Palmer: add a combobox for the recently used capture filter strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12123 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Carlos Pignataro:
guy [Tue, 28 Sep 2004 17:57:56 +0000 (17:57 +0000)]
From Carlos Pignataro:

o Add link type string for MPLS Link Type in MPLS Link sub-TLV
o Decode MPLS Link Color/Resource sub-TLV
o Add bps for bandwidths in Max BW and Max Reservable BW sub-TLVs
o Display Type, Length Value for Unknown Link sub-TLV
o Allow display filter on Link Type and Link Color

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12122 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Olivier Jacques:
guy [Tue, 28 Sep 2004 17:52:36 +0000 (17:52 +0000)]
From Olivier Jacques:

- Add a configuration option for Diameter version. Currently,
  the choice is between everything before draft-v16 and RFC3588.
- Fix diameter-ip-address parsing depending on the Diameter
  version (and showing decoding errors accordingly).
- Change registration of Diameter from TCP and SCTP port 1812 to
  TCP and SCTP port 3868 (this is according to RFC3588, section
  11.5).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12121 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom David Fort: ipseckey DNS RR support.
guy [Tue, 28 Sep 2004 10:28:01 +0000 (10:28 +0000)]
From David Fort: ipseckey DNS RR support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12120 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf, when checking whether the Kerberos library is Heimdal or not, we
guy [Tue, 28 Sep 2004 04:47:10 +0000 (04:47 +0000)]
If, when checking whether the Kerberos library is Heimdal or not, we
find it's not, always report "no", even if we're going to give up
because the user specified --with-krb5, so the "sorry, you don't have
Heimdal" message shows up on a line of its own.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12119 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf the user specified --with-krb5 but we don't have a usable Kerberos
guy [Tue, 28 Sep 2004 04:41:57 +0000 (04:41 +0000)]
If the user specified --with-krb5 but we don't have a usable Kerberos
library, don't disable dissection and drive on, report an error and
stop; --with-krb5 means "build this with Kerberos", not "build this with
Kerberos if you can" (no -krb5 option at all means "build this with
Kerberos if you can").

If they *didn't* specify --with-krb5 and we don't have a usable Kerberos
library, set want_krb5 to "no", so that at the end of the configure
script we don't say we're building with the Kerberos library (otherwise,
want_krb5 is "ifpresent", but the stuff to print the configuration
options treats anything other than "no" as meaning "yes").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12118 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove various checksum routines and headers to epan.
guy [Tue, 28 Sep 2004 00:06:32 +0000 (00:06 +0000)]
Move various checksum routines and headers to epan.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12117 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove the DES, MD4, MD5, and RC4 source files and headers into epan, and
guy [Mon, 27 Sep 2004 23:29:22 +0000 (23:29 +0000)]
Move the DES, MD4, MD5, and RC4 source files and headers into epan, and
make the source files all include the corresponding header files (so
that the declarations in the headers have to match the definitions in
the source files in order for compilation to succeed).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12116 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove prefs.c and prefs.h into the epan subdirectory.
guy [Mon, 27 Sep 2004 22:55:15 +0000 (22:55 +0000)]
Move prefs.c and prefs.h into the epan subdirectory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12115 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago"ethereal_stock_icons()" isn't used outside "gtk/toolbar.c" (and should
guy [Mon, 27 Sep 2004 22:32:09 +0000 (22:32 +0000)]
"ethereal_stock_icons()" isn't used outside "gtk/toolbar.c" (and should
presumably only be called once in any case), so make it static.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12114 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAt least in the screenshot at
guy [Mon, 27 Sep 2004 22:21:31 +0000 (22:21 +0000)]
At least in the screenshot at

http://ftp.gnome.org/pub/GNOME/teams/marketing/en/2004/two-eight-screenshots/html/g27-openwithhal.png

a "browse" button in GNOME has a label "Browse", and I think that's the
case in at least some Windows applications as well, so give browse
buttons "Browse" as a text label.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12113 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAs the GTK Wimp default theme (since 0.6.1) won't display any icons in buttons any...
ulfl [Mon, 27 Sep 2004 19:44:24 +0000 (19:44 +0000)]
As the GTK Wimp default theme (since 0.6.1) won't display any icons in buttons any longer (which is typical for win applications), the browse button won't display anything for GTK2 now. Add some ... into it, which is also looking ok together with the stock icon on other platforms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12112 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved well_known.txt
ulfl [Mon, 27 Sep 2004 17:27:27 +0000 (17:27 +0000)]
removed well_known.txt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12111 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRoutines called by "g_node_traverse()" return a Boolean - FALSE to
guy [Mon, 27 Sep 2004 08:30:25 +0000 (08:30 +0000)]
Routines called by "g_node_traverse()" return a Boolean - FALSE to
continue traversing, TRUE to stop traversing - so make
"free_node_data()" return FALSE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12110 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf "HAVE_PCAP_DATALINK_NAME_TO_VAL" is defined - i.e., if we're built
guy [Mon, 27 Sep 2004 01:11:23 +0000 (01:11 +0000)]
If "HAVE_PCAP_DATALINK_NAME_TO_VAL" is defined - i.e., if we're built
with a version of WinPcap that has "pcap_datalink_name_to_val()" - then,
if the version of WinPcap we've loaded doesn't have
"pcap_datalink_name_to_val()", supply our own version.  Do the
equivalent for "pcap_datalink_val_to_name()".

We do that so that we can build Ethereal with a recent version of
WinPcap, so that it uses the new APIs in newer versions, and still have
it work with older versions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12109 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoExplicitly indicate when we're doing tests to see if UCD SNMP contains
guy [Sun, 26 Sep 2004 22:30:46 +0000 (22:30 +0000)]
Explicitly indicate when we're doing tests to see if UCD SNMP contains
sprint_realloc_objid(), and the extra libraries we're using with the
tests, along the lines of what we do with the Kerberos 5 library.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12108 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a typo.
guy [Sun, 26 Sep 2004 22:28:23 +0000 (22:28 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12107 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIn the SNMP tests, we're using AC_TRY_LINK to avoid caching the results
guy [Sun, 26 Sep 2004 20:30:44 +0000 (20:30 +0000)]
In the SNMP tests, we're using AC_TRY_LINK to avoid caching the results
of the test for sprint_realloc_objid() (so that a failure to find it
when we're not linking with extra libraries doesn't cause us to assume
we won't find it if we *do* link with extra libraries), so
"ac_cv_lib_snmp_sprint_realloc_objid" doesn't get set - set our own
variable for that.

Use AC_TRY_LINK rather than AC_CHECK_LIB in the Kerberos tests when
checking for krb_k5_resolve(), to avoid caching the results.

Improve the messages printed in the Kerberos tests to give more detail.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12106 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoClean up a bunch of cruft in --with-ssl; make it more resemble other
guy [Sun, 26 Sep 2004 04:00:20 +0000 (04:00 +0000)]
Clean up a bunch of cruft in --with-ssl; make it more resemble other
--with flags.

Report, in the messages at the end of the configure script, whether
we're building with the SSL library.

If we fail to find "sprint_realloc_objid()" when linking with a
particular library, and --with-ssl wasn't specified, try linking with
-lcrypto as well and, if that succeeds, fail with an indication that UCD
SNMP requires -lcrypto but --with-ssl wasn't specified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12105 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoExplicitly test whether we need -lresolv in order to link with -lkrb5.
guy [Sun, 26 Sep 2004 00:26:06 +0000 (00:26 +0000)]
Explicitly test whether we need -lresolv in order to link with -lkrb5.
Include -lresolv if we do, and don't include it if we don't.

Clean up some other things in the -lkrb5 macro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12104 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFor annoying licensing reasons, we don't want to use -lcrypto unless the
guy [Sat, 25 Sep 2004 23:58:42 +0000 (23:58 +0000)]
For annoying licensing reasons, we don't want to use -lcrypto unless the
user explicitly says to do so by using --with-ssl.  However, we *still*
don't want to just blithely replace -lcrypto with SSL_LIBS, so, if
KRB5_LIBS contains "-lcrypto" but SSL_LIBS isn't set to a non-empty
string, we report an error (the user can than either configure without
Kerberos or with -lcrypto).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12103 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWhen applying preferences, we have to apply the protocol preferences
guy [Sat, 25 Sep 2004 22:50:58 +0000 (22:50 +0000)]
When applying preferences, we have to apply the protocol preferences
before applying any other preferences, as, before we've applied them,
the internal state of the preferences in some dissectors might be
inconsistent (for example, the 802.11 dissector might've had its
number-of-WEP-keys preference increased but might not yet have allocated
a table for the WEP keys), and, as "gui_prefs_apply()" could cause a
redissection when redisplaying, that could cause dissectors to
malfunction (e.g., crash).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12102 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFetch the function from the correct offset.
guy [Sat, 25 Sep 2004 10:36:08 +0000 (10:36 +0000)]
Fetch the function from the correct offset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12101 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved "Well Known" help page, as the content (and far more than that) moved to...
ulfl [Sat, 25 Sep 2004 10:15:08 +0000 (10:15 +0000)]
removed "Well Known" help page, as the content (and far more than that) moved to the wiki.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12100 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't just add "-lresolv" to KRB5_LIBS if it's missing - on some
guy [Sat, 25 Sep 2004 09:33:53 +0000 (09:33 +0000)]
Don't just add "-lresolv" to KRB5_LIBS if it's missing - on some
platforms, it's missing because it's not needed, which is good because
it's not even *present* on those platforms (the resolver functions are
built into libc).  If there really are platforms where krb5-config is
broken to the extent that it doesn't list -lresolv when it's required,
the way to fix that is to try building a program with Heimdal and just
the krb5-config libraries and, if that fails, try building with those
libraries and -lresolv - if that works, add -lresolv to the list of
libraries.

Don't just replace -lcrypto with SSL_LIBS in KRB5_LIBS, as SSL_LIBS
might not contain any libraries - replace it only if SSL_LIBS is defined
as something.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12099 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWhat part of "least significant octet first" do you not understand? :-)
guy [Sat, 25 Sep 2004 09:17:12 +0000 (09:17 +0000)]
What part of "least significant octet first" do you not understand? :-)
(The part I didn't bother to notice.... :-))

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12098 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agorenamed dirs dg-src and ug-src to match output dirnames
ulfl [Sat, 25 Sep 2004 08:36:07 +0000 (08:36 +0000)]
renamed dirs dg-src and ug-src to match output dirnames

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12097 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom packet steve: label the GRE key as "GRE Key", so that
guy [Sat, 25 Sep 2004 08:03:23 +0000 (08:03 +0000)]
From packet steve: label the GRE key as "GRE Key", so that
post-processing scripts can more easily distinguish it from other keys.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12096 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFetch the handle for the data dissector, as we use it....
guy [Sat, 25 Sep 2004 08:01:00 +0000 (08:01 +0000)]
Fetch the handle for the data dissector, as we use it....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12095 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Tomas Kukosa: export ether_to_str() from libethereal.dll.
guy [Sat, 25 Sep 2004 07:43:12 +0000 (07:43 +0000)]
From Tomas Kukosa: export ether_to_str() from libethereal.dll.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12094 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Tomas Kukosa:
guy [Sat, 25 Sep 2004 07:41:58 +0000 (07:41 +0000)]
From Tomas Kukosa:

- pass only value (not tag and length) to subdissectors from the
  snmp.variable_oid table
- register the SNMP dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12093 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofix bug in handling of offset for integers longer than 4 bytes
sahlberg [Sat, 25 Sep 2004 02:44:45 +0000 (02:44 +0000)]
fix bug in handling of offset for  integers longer than 4 bytes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12092 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoas the interface is usually fixed, or it can be selected by the interface drop down...
ulfl [Fri, 24 Sep 2004 21:19:48 +0000 (21:19 +0000)]
as the interface is usually fixed, or it can be selected by the interface drop down list, grab the keyboard focus at the filter string field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12091 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoupdated screenshot, as the last one had no icons on buttons
ulfl [Fri, 24 Sep 2004 20:18:06 +0000 (20:18 +0000)]
updated screenshot, as the last one had no icons on buttons

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12089 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd some minor details
ulfl [Fri, 24 Sep 2004 19:21:18 +0000 (19:21 +0000)]
add some minor details

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12088 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate help menu screenshot (wiki link) and add some notes about Web browser handling
ulfl [Fri, 24 Sep 2004 18:18:05 +0000 (18:18 +0000)]
Update help menu screenshot (wiki link) and add some notes about Web browser handling

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12087 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse new win32 libs from anonsvn instead of webpage, including setup target. Use updat...
ulfl [Fri, 24 Sep 2004 16:08:44 +0000 (16:08 +0000)]
Use new win32 libs from anonsvn instead of webpage, including setup target. Use updated GTK 2.4.9 libraries. But still use wget.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12086 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix Some compiler warnings:
etxrab [Fri, 24 Sep 2004 16:01:09 +0000 (16:01 +0000)]
Fix Some compiler warnings:

packet-etheric.c:99: warning: `message_type_vals' defined but not used
packet-etheric.c:376: warning:
`isup_calling_party_nature_of_address_ind_value'
defined but not used
packet-etheric.c:892: warning:
`dissect_etheric_cause_indicators_parameter' defi
ned but not used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12085 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd a link to the Ethereal wiki front page
ulfl [Fri, 24 Sep 2004 15:41:46 +0000 (15:41 +0000)]
add a link to the Ethereal wiki front page

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12084 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Carlos Pignataro:
guy [Fri, 24 Sep 2004 11:56:17 +0000 (11:56 +0000)]
From Carlos Pignataro:

updates for 2 PWE3 interface parameters:

o FCS Retention [draft-ietf-pwe3-fcs-retention-02.txt]
o VCCV [draft-ietf-pwe3-vccv-03.txt]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12083 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a typo.
gerald [Fri, 24 Sep 2004 02:09:40 +0000 (02:09 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12082 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Magnus Hansson: move CIP protocol to own dissector (we forgot to
guy [Thu, 23 Sep 2004 22:36:01 +0000 (22:36 +0000)]
From Magnus Hansson: move CIP protocol to own dissector (we forgot to
check in packet-cip.h).

Also, add packet-cip.h to epan/dissectors/Makefile.common, so it gets
included in the release tarballs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12081 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Carlos Pignataro: append the symbolic name for reserved MPLS labels
guy [Thu, 23 Sep 2004 20:51:09 +0000 (20:51 +0000)]
From Carlos Pignataro: append the symbolic name for reserved MPLS labels
to the protocol tree item for the label.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12080 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGet rid of the CRs and set eol-style to native so that you get CRs on
guy [Thu, 23 Sep 2004 19:52:29 +0000 (19:52 +0000)]
Get rid of the CRs and set eol-style to native so that you get CRs on
Windows and don't get them on UN*X.

Set keywords so that RCS IDs are expanded.

Squelch some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12078 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd dissector packet-etheric.c
etxrab [Thu, 23 Sep 2004 19:44:51 +0000 (19:44 +0000)]
Add dissector packet-etheric.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12077 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a dissector for an Ericsson protocol named "Etheric"
etxrab [Thu, 23 Sep 2004 19:41:21 +0000 (19:41 +0000)]
Add a dissector for an Ericsson protocol named "Etheric"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12076 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the dissection of the Reply function - it has a "receipt number"
guy [Thu, 23 Sep 2004 18:54:39 +0000 (18:54 +0000)]
Fix the dissection of the Reply function - it has a "receipt number"
field, and the data isn't at a fixed offset of 4.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12075 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd support for the Ethernet Configuration Testing Protocol.
guy [Thu, 23 Sep 2004 18:48:11 +0000 (18:48 +0000)]
Add support for the Ethernet Configuration Testing Protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12074 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Gisle Vanem: add support for pcap_datalink_val_to_name() for Win32.
guy [Thu, 23 Sep 2004 17:54:49 +0000 (17:54 +0000)]
From Gisle Vanem: add support for pcap_datalink_val_to_name() for Win32.

Also add support for pcap_datalink_name_to_val(), and arrange that we
properly define HAVE_PCAP_DATALINK_NAME_TO_VAL and
HAVE_PCAP_DATALINK_VAL_TO_NAME for MSVC++ builds.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12073 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
guy [Thu, 23 Sep 2004 17:40:36 +0000 (17:40 +0000)]
From Jelmer Vernooij:

- Dissect ICQ TLV values
- Dissect channel 1 and channel 2 messages correctly in Oscar (required
  for dissecting direct connections)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12072 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij: fix a comment.
guy [Thu, 23 Sep 2004 17:39:13 +0000 (17:39 +0000)]
From Jelmer Vernooij: fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12071 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Magnus Hansson:
guy [Thu, 23 Sep 2004 17:34:35 +0000 (17:34 +0000)]
From Magnus Hansson:

move CIP protocol to own dissector
clean up code and fix variable names
add more info to info column
fixed decoding of embedded messages in Unconnected send and
    Multiple Service packets
add more info to path decoding
add more filter options/clean up
complete CIP vendor codes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12070 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom packet steve: add a filterable field for the GRE key.
guy [Thu, 23 Sep 2004 17:15:26 +0000 (17:15 +0000)]
From packet steve: add a filterable field for the GRE key.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12069 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd proto_tree_add_debug_text(), rtcp_add_address(), and
guy [Thu, 23 Sep 2004 07:32:58 +0000 (07:32 +0000)]
Add proto_tree_add_debug_text(), rtcp_add_address(), and
rtp_add_address() to the list of functions exported from libethereal.dll
and exported via the plugin function table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12068 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd proto_tree_add_debug_text(), rtcp_add_address(), and
guy [Thu, 23 Sep 2004 07:32:16 +0000 (07:32 +0000)]
Add proto_tree_add_debug_text(), rtcp_add_address(), and
rtp_add_address() to the list of functions exported from libethereal.dll
and exported via the plugin function table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12067 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Tomas Kukosa:
guy [Wed, 22 Sep 2004 16:32:20 +0000 (16:32 +0000)]
From Tomas Kukosa:

- make the default protocol name module-name from input file
- don't use the [##]/(##) mark for index of SET/SEQUENCE item with
  original PER/BER API
- allow PDUs to be registered

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12066 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Carlos Pignataro:
guy [Wed, 22 Sep 2004 16:28:39 +0000 (16:28 +0000)]
From Carlos Pignataro:

append MPLS fields and values to the MPLS Header subtree;

correct the string displayed for MPLS Label;

don't show non-reserved MPLS label values as "Unknown".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12065 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf we have "pcap_datalink_val_to_name()", use it when we construct a
guy [Wed, 22 Sep 2004 09:42:57 +0000 (09:42 +0000)]
If we have "pcap_datalink_val_to_name()", use it when we construct a
"-y" argument for the capture subprocess - the capture subprocess will
expect a symbolic value, not a numeric value, if we have
"pcap_datalink_name_to_val()".  (We assume that if one is present the
other will be present as well.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12064 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
guy [Wed, 22 Sep 2004 08:04:40 +0000 (08:04 +0000)]
From Jelmer Vernooij:

 - Dissect the DC (Direct Connection) info structure
 - Dissect the complete buddy icon family (you can now save buddy
   icons as .JPG's/.PNG's directly from the capture using the "Export
   selected bytes..." option!)
 - Add a function that dissects a sequence of TLV's instead of having
   while() loops all over the place.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12063 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a typo.
guy [Tue, 21 Sep 2004 23:15:59 +0000 (23:15 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12062 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
guy [Tue, 21 Sep 2004 08:01:29 +0000 (08:01 +0000)]
From Jelmer Vernooij:

Remove some code duplication from the Oscar dissector (reduces
the number of lines by 500) by providing a custom registration
function for oscar families (aim_init_family).  This also fixes
a number of issues with column names.

Add minor updates such as adding support for the Capability Info
TLV on users.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12060 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Yaniv Kaul:
guy [Tue, 21 Sep 2004 07:47:14 +0000 (07:47 +0000)]
From Yaniv Kaul:

1. Fix dissection of Check Point vendor ID version field. The length was
   wrong.
2. Added dissection of payloads 130 and 131, which were used in early
   NAT-T drafts (and are still used by MS and others). They are equal to
   payloads 15 & 16, (NAT-D, NAT-OA), respectively.
3. Added ASN.1 decoding of Certificate requests of type X.509
   Certificate - Signature (4)
4. Added ASN.1 decoding of ID of type ID_DER_ASN1_DN (9)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12059 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Viorel Suman: fields in TALI are little-endian, so in the "get PDU
guy [Tue, 21 Sep 2004 06:48:31 +0000 (06:48 +0000)]
From Viorel Suman: fields in TALI are little-endian, so in the "get PDU
length" routine, fetch the length field with "tvb_get_letohs()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12058 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofixed some comment typos
ulfl [Tue, 21 Sep 2004 05:17:59 +0000 (05:17 +0000)]
fixed some comment typos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12057 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Martin Mathieson: Fix a simple bug, in calculate_roundtrip_delay(), where the...
etxrab [Mon, 20 Sep 2004 19:22:10 +0000 (19:22 +0000)]
From Martin Mathieson: Fix a simple bug, in calculate_roundtrip_delay(), where the conversation is looked up, the port arguments are given in reverse order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12055 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate some RADIUS value strings
etxrab [Mon, 20 Sep 2004 19:20:05 +0000 (19:20 +0000)]
Update some RADIUS value strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12054 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd Ethereal logo
ulfl [Sun, 19 Sep 2004 16:43:11 +0000 (16:43 +0000)]
add Ethereal logo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12053 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved duplicate Ethereal version entities
ulfl [Sun, 19 Sep 2004 16:41:58 +0000 (16:41 +0000)]
removed duplicate Ethereal version entities

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12052 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved EtherealCurrentVersionTarFile entity
ulfl [Sun, 19 Sep 2004 16:40:11 +0000 (16:40 +0000)]
removed EtherealCurrentVersionTarFile entity

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12051 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd some info how to report problems
ulfl [Sun, 19 Sep 2004 16:38:29 +0000 (16:38 +0000)]
add some info how to report problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12050 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agothe file content seemed to be corrupted
ulfl [Sun, 19 Sep 2004 16:36:10 +0000 (16:36 +0000)]
the file content seemed to be corrupted

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12049 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd to the "radius_attr_info" structure a pointer to an hf_ value, and,
guy [Sun, 19 Sep 2004 11:39:48 +0000 (11:39 +0000)]
Add to the "radius_attr_info" structure a pointer to an hf_ value, and,
if that pointer is non-null, put the field in question into the protocol
tree under the top-level item for that attribute/value pair, rather than
hardcoding particular fields for particular attribute codes.

Use BASE_NONE, not BASE_DEC, for FT_STRING, FT_BYTES, and FT_IPv4
fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12048 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Mark C. Brown: fix support for nettl NETTL_SUBSYS_NS_LS_ICMP and
guy [Sun, 19 Sep 2004 07:13:52 +0000 (07:13 +0000)]
From Mark C. Brown: fix support for nettl NETTL_SUBSYS_NS_LS_ICMP and
NETTL_SUBSYS_NS_LS_ICMPV6 - they don't even have IP headers, so we need
to directly call the ICMP and ICMPv6 dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12047 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMake the Kerberos 4 dissector a "new-style" dissector, so it can
guy [Sun, 19 Sep 2004 03:51:42 +0000 (03:51 +0000)]
Make the Kerberos 4 dissector a "new-style" dissector, so it can
indicate when it's rejected a packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12046 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPreference strings don't remain null pointers for long - they get
guy [Sun, 19 Sep 2004 03:00:00 +0000 (03:00 +0000)]
Preference strings don't remain null pointers for long - they get
converted to pointers to null strings (see prefs.c for an explanation).
Initialize "current_asn1" to a mallocated null string.

That lets us use "strcmp()" to compare asn1_filename and current_asn1.
We already do that with asn1_pduname and current_pduname, so use
"strcmp()" for them as well.

Call "build_pdu_tree()" if we haven't yet built a PDU tree, even if the
PDU type preference hasn't changed.

Don't register with any of the ports unless we have a PDU tree, so we
don't try to dissect with a null PDU tree pointer.

Before constructing a PDU tree, if we already have a PDU tree, free it.

When we free data_nodes, free the data attached to the nodes.

Make a bunch of stuff static.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12045 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFiax a MSVC Warning
etxrab [Sat, 18 Sep 2004 21:31:20 +0000 (21:31 +0000)]
Fiax a MSVC Warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12044 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix dissection of MEGACO over TCP, there will be a TPKT header included.
etxrab [Sat, 18 Sep 2004 21:28:28 +0000 (21:28 +0000)]
Fix dissection of MEGACO over TCP, there will be a TPKT header included.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12043 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse FALSE as the byte order argument to "proto_tree_add_item()" when
guy [Sat, 18 Sep 2004 09:31:26 +0000 (09:31 +0000)]
Use FALSE as the byte order argument to "proto_tree_add_item()" when
fetching big-endian IPv4 addresses.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12042 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDistinguish between the "data offset" field (offset of this burst
guy [Sat, 18 Sep 2004 09:19:33 +0000 (09:19 +0000)]
Distinguish between the "data offset" field (offset of this burst
within the file) and "burst offset" field (offset of this packet within
the burst).

The burst header is not present if the SYS flag is set in the packet or
if the data offset field is non-zero.

Compute the offset, within a burst packet, of the data, as we advance
through the burst header - and don't advance through the burst header if
it's not present.

Properly display the fields in the "missing fragment list".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12041 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
guy [Sat, 18 Sep 2004 06:42:16 +0000 (06:42 +0000)]
From Jelmer Vernooij:

- Support client capabilities list
- Fix incorrect TLV usage

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12040 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd decoding of werido special transac versions of kerberos 4
sahlberg [Sat, 18 Sep 2004 03:20:52 +0000 (03:20 +0000)]
add decoding of werido special transac versions of kerberos 4

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12039 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agomake kerberos able to dissect pkinit/pa-pk-as-rep packets
sahlberg [Fri, 17 Sep 2004 23:45:29 +0000 (23:45 +0000)]
make kerberos able to dissect pkinit/pa-pk-as-rep packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12038 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd pkinit replies dissection
sahlberg [Fri, 17 Sep 2004 23:33:10 +0000 (23:33 +0000)]
add pkinit replies dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12037 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoadd pkinit replies
sahlberg [Fri, 17 Sep 2004 23:32:33 +0000 (23:32 +0000)]
add pkinit replies

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12036 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoget rid of some compiler warnings
sahlberg [Fri, 17 Sep 2004 23:24:17 +0000 (23:24 +0000)]
get rid of some compiler warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12035 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoget rid of some more compiler warnings
sahlberg [Fri, 17 Sep 2004 23:23:40 +0000 (23:23 +0000)]
get rid of some more compiler warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12034 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoget rid of a compiler warning for unused function UserNotice
sahlberg [Fri, 17 Sep 2004 23:16:17 +0000 (23:16 +0000)]
get rid of a compiler warning for unused function UserNotice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12033 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agosquelch a compiler warning for UserNotice
sahlberg [Fri, 17 Sep 2004 23:14:21 +0000 (23:14 +0000)]
squelch a compiler warning   for UserNotice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12032 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij: get rid of some unused tables.
guy [Fri, 17 Sep 2004 09:37:14 +0000 (09:37 +0000)]
From Jelmer Vernooij: get rid of some unused tables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12030 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoNote that declarations in the middle of a block aren't supported by all
guy [Fri, 17 Sep 2004 09:32:53 +0000 (09:32 +0000)]
Note that declarations in the middle of a block aren't supported by all
compilers, and thus shouldn't be used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12029 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofrom Thomas Boehne: don't put code before a declaration - that's a
guy [Fri, 17 Sep 2004 09:30:41 +0000 (09:30 +0000)]
from Thomas Boehne: don't put code before a declaration - that's a
GCCism.

De-@ify Marten Svantesson's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12028 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIP addresses are always big-endian.
guy [Fri, 17 Sep 2004 09:05:03 +0000 (09:05 +0000)]
IP addresses are always big-endian.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12027 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agonew protocol : Kerberos v4
sahlberg [Fri, 17 Sep 2004 08:43:03 +0000 (08:43 +0000)]
new protocol : Kerberos v4

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12026 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoget rid of some compiler warnings
sahlberg [Fri, 17 Sep 2004 08:12:21 +0000 (08:12 +0000)]
get rid of some compiler warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12025 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoget rid of some compiler warnings for pkinit
sahlberg [Fri, 17 Sep 2004 08:11:30 +0000 (08:11 +0000)]
get rid of some compiler warnings for pkinit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12024 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFALSE, not TRUE, means big-endian in a "proto_tree_add_item()" call.
guy [Fri, 17 Sep 2004 08:10:12 +0000 (08:10 +0000)]
FALSE, not TRUE, means big-endian in a "proto_tree_add_item()" call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12023 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jelmer Vernooij:
guy [Fri, 17 Sep 2004 02:02:04 +0000 (02:02 +0000)]
From Jelmer Vernooij:

- Support for more generic TLV's
- Support for two more SNAC families: email and sst
- Support for extended status (as used by iChat)
- Use correct TLV in SSI RightsInfo
- Dissect and handle FNAC flags field correctly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12022 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofirst steps towards using the User's Guide as Ethereal's help system
ulfl [Thu, 16 Sep 2004 22:07:03 +0000 (22:07 +0000)]
first steps towards using the User's Guide as Ethereal's help system

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12021 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoThe list of protocols should be sorted in a case-insensitive fashion, so
guy [Thu, 16 Sep 2004 21:30:51 +0000 (21:30 +0000)]
The list of protocols should be sorted in a case-insensitive fashion, so
giFT, iSCSI, and iSNS don't show up at the end.  Protocol short names
are ASCII, so just use "g_ascii_strcasecmp()".

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12020 f5534014-38df-0310-8fa8-9805f1628bb7