obnox/wireshark/wip.git
21 years agoPut a "-I" before "$gtk_aclocal_dir".
gerald [Wed, 22 Jan 2003 15:58:33 +0000 (15:58 +0000)]
Put a "-I" before "$gtk_aclocal_dir".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6977 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdded support for version 05 of the (expired) ID describing M3UA.
tuexen [Wed, 22 Jan 2003 09:07:26 +0000 (09:07 +0000)]
Added support for version 05 of the (expired) ID describing M3UA.
Updated to support RFC 3332.
Better handling of padding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6976 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoInclude <epan/resolv.h> to declare "get_hostname()".
guy [Wed, 22 Jan 2003 07:28:29 +0000 (07:28 +0000)]
Include <epan/resolv.h> to declare "get_hostname()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6975 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Dinesh Dutt:
guy [Wed, 22 Jan 2003 06:26:36 +0000 (06:26 +0000)]
From Dinesh Dutt:

    - A new decoder called MDSHDR which decodes the internal header of the
      Cisco MDS switch (this is different from the Boardwalk header).
    - Support for some more new columns as part of FC support.
    - Fixed the decoding of the Special Frame in FCIP.
    - Fixed the decoding of credit management type field in FLOGI/PLOGI frame
      in FC-ELS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6974 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago"echo -n" isn't portable, and neither is sticking "\c" at the end of the
guy [Wed, 22 Jan 2003 02:14:26 +0000 (02:14 +0000)]
"echo -n" isn't portable, and neither is sticking "\c" at the end of the
string to be echoed; use "tr" to delete new lines and, while we're at
it, also delete carriage returns (just in case this is being run under
Cygwin or something such as that, and it produces lines ending with
CR-LF).  Don't use character classes - I seem to remember that some
versions of "tr" require you to put the classes in square brackets and
some other versions don't work if you put them in square brackets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6973 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoTopTalkers feature for Ethernet/IP/TokenRing
sahlberg [Wed, 22 Jan 2003 01:24:06 +0000 (01:24 +0000)]
TopTalkers feature for Ethernet/IP/TokenRing

IO-Users is a feature for tethereal that will print statistics on io usage
similar to top talkers in other tools.

It needs to be ported to ethereal with a nice graph sometime later.

try:
-z io,users,ip

see man-page

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6972 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoreate a TAP for Ethernet
sahlberg [Wed, 22 Jan 2003 01:18:03 +0000 (01:18 +0000)]
reate a TAP for Ethernet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6971 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCreate a TAP for TokenRing
sahlberg [Wed, 22 Jan 2003 01:17:01 +0000 (01:17 +0000)]
Create a TAP for TokenRing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6970 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPatch for packet-ip to make it TAPable
sahlberg [Wed, 22 Jan 2003 01:16:33 +0000 (01:16 +0000)]
Patch for packet-ip to make it TAPable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6969 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoKeep track of and display the time between Call and Reply in NCP packets.
sahlberg [Wed, 22 Jan 2003 00:45:30 +0000 (00:45 +0000)]
Keep track of and display the time between Call and Reply in NCP packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6968 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoNew files for the SMB RTT statistics feature
sahlberg [Wed, 22 Jan 2003 00:42:05 +0000 (00:42 +0000)]
New files for the SMB RTT statistics feature

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6967 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSMB RTT statistics for tethereal and ethereal.
sahlberg [Wed, 22 Jan 2003 00:40:36 +0000 (00:40 +0000)]
SMB RTT statistics for tethereal and ethereal.

SMB RTT statistics are similar to the RTT statistics already supported by ONC-RPC and DCE-RPC.
It will present a table with all seen SMB commands and present the Min/Max and Avg response time in ms.

Transaction2 and NT-Transaction commands are broken out and presented in its own subtables.

tethereal feature is activated with -z smb,rtt    switch
and in ethereal it is activated either through -0z smb,rtt switch or through the Menu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6966 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoaclocal-flags, autogen.sh:
jmayer [Wed, 22 Jan 2003 00:19:00 +0000 (00:19 +0000)]
aclocal-flags, autogen.sh:
- Fix handling of aclocal include flags for aclocal-include

autogen.sh:
- Name version variables individually
- Disable configure at end of autogen.sh

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6965 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix for the problem that the aclocal-missing directory was not included in make dist...
jmayer [Wed, 22 Jan 2003 00:08:12 +0000 (00:08 +0000)]
Fix for the problem that the aclocal-missing directory was not included in make dist-gzip

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6964 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agocjs 2895: Fix configure check to compile with IBM Visual Age C compiler
jmayer [Tue, 21 Jan 2003 21:47:36 +0000 (21:47 +0000)]
cjs 2895: Fix configure check to compile with IBM Visual Age C compiler
- remove nested functions
- use char *pcap_version instead of char pcap_version[]

Changed the fix for the nested functions to use the mechanisms provided
by autoconf.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6963 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCheck for pcap in before /usr/local and stop on first hit
jmayer [Tue, 21 Jan 2003 20:38:32 +0000 (20:38 +0000)]
Check for pcap in  before /usr/local and stop on first hit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6962 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReorder defines numerically within version
jmayer [Tue, 21 Jan 2003 20:29:42 +0000 (20:29 +0000)]
Reorder defines numerically within version

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6961 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate FAQ
jmayer [Tue, 21 Jan 2003 20:26:53 +0000 (20:26 +0000)]
Update FAQ

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6960 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdate manuf file to revised format
jmayer [Tue, 21 Jan 2003 20:25:29 +0000 (20:25 +0000)]
Update manuf file to revised format

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6959 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't replace spaces by '_', remove them.
jmayer [Tue, 21 Jan 2003 20:20:09 +0000 (20:20 +0000)]
Don't replace spaces by '_', remove them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6958 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a small fixme aboutn --enable-usr-local
jmayer [Tue, 21 Jan 2003 20:15:52 +0000 (20:15 +0000)]
Add a small fixme aboutn --enable-usr-local

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6957 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix a typo.
gerald [Tue, 21 Jan 2003 19:20:49 +0000 (19:20 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6956 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoNote that IP-over-FC is described by RFC 2625.
guy [Tue, 21 Jan 2003 05:21:03 +0000 (05:21 +0000)]
Note that IP-over-FC is described by RFC 2625.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6955 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Brian Ginsbach: symbolic names for Fibre Channel Network Address
guy [Tue, 21 Jan 2003 05:04:07 +0000 (05:04 +0000)]
From Brian Ginsbach: symbolic names for Fibre Channel Network Address
Authority identifiers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6954 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Huagang Xie: use "tvb_format_text()" when putting the command
guy [Tue, 21 Jan 2003 02:42:14 +0000 (02:42 +0000)]
From Huagang Xie: use "tvb_format_text()" when putting the command
parameter into the Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6953 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoBump the version to 0.9.9. Update the NEWS and ChangeLog files.
gerald [Tue, 21 Jan 2003 02:12:37 +0000 (02:12 +0000)]
Bump the version to 0.9.9.  Update the NEWS and ChangeLog files.

I'm shooting for a release on Wednesday evening.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6952 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "tcp_dissect_pdus()" rather than doing the dissection ourselves.
guy [Tue, 21 Jan 2003 01:45:17 +0000 (01:45 +0000)]
Use "tcp_dissect_pdus()" rather than doing the dissection ourselves.

If we reject a TCP segment, tell our caller, so they can try another
dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6951 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd packet-ntlmssp.h to Makefile.am.
gerald [Tue, 21 Jan 2003 00:39:57 +0000 (00:39 +0000)]
Add packet-ntlmssp.h to Makefile.am.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6950 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUpdated to support latest versions of the Internet Drafts:
tuexen [Mon, 20 Jan 2003 22:49:36 +0000 (22:49 +0000)]
Updated to support latest versions of the Internet Drafts:
  http://www.ietf.org/internet-drafts/draft-ietf-rserpool-common-param-02.txt
  http://www.ietf.org/internet-drafts/draft-ietf-rserpool-asap-05.txt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6949 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of old ASAP PPID.
tuexen [Mon, 20 Jan 2003 22:46:27 +0000 (22:46 +0000)]
Get rid of old ASAP PPID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6948 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Yaniv Kaul:
guy [Mon, 20 Jan 2003 22:27:03 +0000 (22:27 +0000)]
From Yaniv Kaul:

1. Add NAT-D and NAT-OA to the known payloads (does not dissect NAT-D
yet, though),
2. Add types 3 and 4 as enapsulated tunnel and transport.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6947 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReject packets with opcodes we don't recognize.
guy [Mon, 20 Jan 2003 08:03:16 +0000 (08:03 +0000)]
Reject packets with opcodes we don't recognize.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6946 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDo desegmentation and handle multiple AIM messages per TCP segment.
guy [Mon, 20 Jan 2003 07:39:25 +0000 (07:39 +0000)]
Do desegmentation and handle multiple AIM messages per TCP segment.

If the packet doesn't look like an AIM packet, tell our caller so they
can try something else.

Don't display an item for undissected data if there isn't any data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6945 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "tcp_dissect_pdus()" rather than doing that stuff ourselves.
guy [Mon, 20 Jan 2003 06:54:52 +0000 (06:54 +0000)]
Use "tcp_dissect_pdus()" rather than doing that stuff ourselves.

"mysql_handle" doesn't need to be static.

"is_response" is really a Boolean; make it a gboolean.

Get rid of some unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6944 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe decision on whether there's an encapsulated IP packet in a
guy [Mon, 20 Jan 2003 06:24:37 +0000 (06:24 +0000)]
The decision on whether there's an encapsulated IP packet in a
Source-Active TLV should be based on the length of the Source-Active
TLV, not on the length of the data remaining in the tvbuff.

The length of an (S,G) block is 12 bytes, not 24 bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6943 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMove into "call_dissector_work()" the stuff to handle dissecting, in
guy [Mon, 20 Jan 2003 05:42:37 +0000 (05:42 +0000)]
Move into "call_dissector_work()" the stuff to handle dissecting, in
error packets, the copy of the packet that got the error, rather than
doing it in the CLNP dissector and the ICMP dissector and the ICMPv6
dissector and the PPP dissector for various control protocols; have it
do that work iff "pinfo->in_error_pkt" is set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6942 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWhen dissecting the packet that gave an ICMP error, save the writability
guy [Sun, 19 Jan 2003 22:21:01 +0000 (22:21 +0000)]
When dissecting the packet that gave an ICMP error, save the writability
state of the columns and the current protocol, and restore them when
done.  Also, cache BoundsError and, if we get a BoundsError, restore
them and then re-throw the BoundsError, so we see a "Short Frame"
indication if the frame was cut off by the snapshot length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6941 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake the DDTP dissector reject packets with an invalid version number.
guy [Sun, 19 Jan 2003 21:43:18 +0000 (21:43 +0000)]
Make the DDTP dissector reject packets with an invalid version number.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6940 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Huagang Xie: dissector for MySQL protocol.
guy [Sun, 19 Jan 2003 21:29:10 +0000 (21:29 +0000)]
From Huagang Xie: dissector for MySQL protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6939 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Didier Gautheron:
guy [Sun, 19 Jan 2003 21:21:32 +0000 (21:21 +0000)]
From Didier Gautheron:

fix a padding issue and a problem where the spec appears to give
the size of the AFP session token length incorrectly (changed to
match what's captured, not what the spec says);

provide more verbose messages in the Info column and decode more
parameters for login packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6938 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRename OUT_DATE to OUT_TIMESECS, as it can be used for relative time in
guy [Sat, 18 Jan 2003 02:18:39 +0000 (02:18 +0000)]
Rename OUT_DATE to OUT_TIMESECS, as it can be used for relative time in
seconds as well as for UNIX-style date/time stamps.

FT_ABSOLUTE_TIME fields don't have a base, so use BASE_NONE.

Make hf_afs_fs_callback_expires an FT_RELATIVE_TIME, as it's a relative
time not an absolute UNIX time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6937 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Marc Milgram: e-mail address update.
guy [Fri, 17 Jan 2003 23:54:19 +0000 (23:54 +0000)]
From Marc Milgram: e-mail address update.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6936 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoChange name of proto item for UINT16UNI.
tpot [Thu, 16 Jan 2003 22:44:05 +0000 (22:44 +0000)]
Change name of proto item for UINT16UNI.

Use dissect_ndr_uint32 instead of dissect_doserror() to peek at the
RPC error in SpoolssOpenPrinterEx_r.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6935 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoClean up some unused variables in dissect_ndr_nt_UNICODE_STRING_str()
tpot [Thu, 16 Jan 2003 22:40:48 +0000 (22:40 +0000)]
Clean up some unused variables in dissect_ndr_nt_UNICODE_STRING_str()

Undo change to dissect_doserror() and dissect_ntstatus() made in
revision 1.42 as it breaks the display of rpc errors in COL_INFO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6934 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd "doc/README.tapping" to the list of files that go into the release
guy [Thu, 16 Jan 2003 07:10:24 +0000 (07:10 +0000)]
Add "doc/README.tapping" to the list of files that go into the release
tarballs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6933 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Devin Heitmueller: further AIM cleanups, including cleanups of
guy [Wed, 15 Jan 2003 06:09:11 +0000 (06:09 +0000)]
From Devin Heitmueller: further AIM cleanups, including cleanups of
Family subtype dissection, and addition of subtypes present in GAIM
source but not in Ethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6932 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMove the code that associates buttons with filter dialogs, and vice
guy [Wed, 15 Jan 2003 05:58:50 +0000 (05:58 +0000)]
Move the code that associates buttons with filter dialogs, and vice
versa, into "filter_dialog_new()", rather than replicating it in a
couple of routines.

The return value of "display_filter_construct_cb()" isn't used for
anything, it's ignored by most callers and stored but subsequently
ignored by io_stat.c; get rid of the return value, and don't bother
storing it in io_stat.c.

Before destroying a filter dialog box associated with a button being
destroyed, break the association.

Get rid of an unused variable in io_stat.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6931 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a new routine "filter_button_destroy_cb()", and make it the
guy [Wed, 15 Jan 2003 05:20:19 +0000 (05:20 +0000)]
Add a new routine "filter_button_destroy_cb()", and make it the
"destroy" signal handler for any button that pops up a filter; if the
button has a filter dialog box associated with it, it destroys that
dialog box.

Have the routines that create filter dialog boxes asociate the dialog
box with the button that created it, so that if the button is destroyed
the filter dialog box can be destroyed as well, and associate the button
with the dialog box.

This means that if a dialog box has a button to create a filter, we no
longer have to have the destroy handler for the dialog box destroy any
filters - that'll happen when the button in the dialog box is destroyed
as part of the process of destroying the dialog box.

Don't make the "Filter" buttons in the io_stat dialog box insensitive if
there's already a filter dialog box open - we can have more than one
open per dialog box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6930 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't have two entries for the official ASAP PPID, have one for it and
guy [Wed, 15 Jan 2003 01:20:32 +0000 (01:20 +0000)]
Don't have two entries for the official ASAP PPID, have one for it and
one for the old one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6929 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago#if 0 out the binary protocol stuff, as there's only a dissector for
guy [Wed, 15 Jan 2003 00:17:53 +0000 (00:17 +0000)]
#if 0 out the binary protocol stuff, as there's only a dissector for
text MEGACO.

Fix up the preference description strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6928 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGive it an RCS ID.
guy [Tue, 14 Jan 2003 23:54:20 +0000 (23:54 +0000)]
Give it an RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6927 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Christian Falckenberg: beginnings of a MEGACO dissector.
guy [Tue, 14 Jan 2003 23:53:40 +0000 (23:53 +0000)]
From Christian Falckenberg: beginnings of a MEGACO dissector.

Move SCTP payload protocol IDs to a header file, and get the PPIDs from
that header file rather than defining them in dissectors running atop
SCTP.  Use both the old(?) and official PPID for ASAP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6926 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Anders Broman: some additional SCTP payload protocol IDs.
guy [Tue, 14 Jan 2003 22:54:20 +0000 (22:54 +0000)]
From Anders Broman: some additional SCTP payload protocol IDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6925 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCatch ReportedBoundsError exceptions when dissecting decrypted stub
guy [Tue, 14 Jan 2003 22:03:33 +0000 (22:03 +0000)]
Catch ReportedBoundsError exceptions when dissecting decrypted stub
data, as the error could be due to the decryption being bad, and we
should still dissect the authentication data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6924 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoWe don't know what, in captures with a major version number of 3,
guy [Tue, 14 Jan 2003 19:52:47 +0000 (19:52 +0000)]
We don't know what, in captures with a major version number of 3,
indicates the subtype of an "Internetwork analyzer" capture; we've seen
only one such capture, and it was a frame relay capture, so we just wire
it to frame relay for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6923 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoSet the length of the L2TP tvbuff based on the length in the L2TP
guy [Tue, 14 Jan 2003 18:57:07 +0000 (18:57 +0000)]
Set the length of the L2TP tvbuff based on the length in the L2TP
header, if present.

Don't explicitly base the length of the subset we hand to the PPP
dissector on the length in the header, as it might not be present;
instead, just use -1 for the lengths, as we set the length of our tvbuff
if there's a length in the L2TP header.

Set the length of the L2TP top-level protocol item for data packets, so
it covers the L2TP header but not the packet data.

Don't put a padding item into the tree if there's no padding.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6922 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDon't copy the entire IP header into a structure, extract stuff from it
guy [Tue, 14 Jan 2003 18:54:29 +0000 (18:54 +0000)]
Don't copy the entire IP header into a structure, extract stuff from it
as you dissect it, so we can dissect packets that are cut short before
the end of an IP header.

Check for an IP total length less than the header length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6921 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd value_string for secure channel type used in ServerAuthenticate2.
tpot [Tue, 14 Jan 2003 05:09:16 +0000 (05:09 +0000)]
Add value_string for secure channel type used in ServerAuthenticate2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6920 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Dinesh Dutt:
guy [Tue, 14 Jan 2003 01:17:44 +0000 (01:17 +0000)]
From Dinesh Dutt:

- Decoders for the few remaining FC protocols not included in my first
  patch. Included in this list are decoders for FC-CT (common transport),
  Name Server (dNS), Fabric Configuration Server (FCS) and Zone Server
  (FZS).

- Decoder for MDS Debug Port Adapter. MDS Debug Port Adapter (internal
  name was   Boardwalk and this is the file name) is a piece of hardware
  that can be purchased with Cisco's MDS Fibre Channel switches that
  converts FC frames into Ethernet frames.  One end is connected to a
  port on a FC switch and the other end is connected to a FE/GE Ethernet
  port.  The decoder included here decodes the encapsulation header that
  carries information such as SOF/EOF of FC frames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6919 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFixed a typo.
tuexen [Mon, 13 Jan 2003 14:04:31 +0000 (14:04 +0000)]
Fixed a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6918 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Devin Heitmueller:
guy [Sun, 12 Jan 2003 04:58:32 +0000 (04:58 +0000)]
From Devin Heitmueller:

* Break up dissection into separate functions
* Added families not already present (based on GAIM source code)
* Added entries from the "generic" family not already present
* Started to break families and subtypes into constants instead of
  having hardcoded values (signon and generic are done, others in
  progress)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6917 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Ronald Henderson, when closing IO-Stat window, also close any open Filter...
sahlberg [Sat, 11 Jan 2003 11:10:33 +0000 (11:10 +0000)]
From Ronald Henderson,   when closing IO-Stat window, also close any open Filter dialogs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6916 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd a new "chdlctypes.h" file for Cisco HDLC type values that aren't
guy [Sat, 11 Jan 2003 10:16:22 +0000 (10:16 +0000)]
Add a new "chdlctypes.h" file for Cisco HDLC type values that aren't
just Ethernet type values.  Move the type value for ISO network-layer
protocols there, and put the type value for IEEE spanning tree there as
well, use that value in the BPDU dissector, and add an item to the CHDLC
dissector for it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6915 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoOnly do stuff to circuits on the first pass.
guy [Sat, 11 Jan 2003 10:03:12 +0000 (10:03 +0000)]
Only do stuff to circuits on the first pass.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6914 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago0x4242 is the Cisco HDLC type value for the spanning tree protocol.
guy [Sat, 11 Jan 2003 10:01:51 +0000 (10:01 +0000)]
0x4242 is the Cisco HDLC type value for the spanning tree protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6913 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDo some simple sanity checking of TNS data before dissecting it.
guy [Sat, 11 Jan 2003 09:57:16 +0000 (09:57 +0000)]
Do some simple sanity checking of TNS data before dissecting it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6912 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFix the copyright notice, give it an RCS ID, and fix the introductory
guy [Sat, 11 Jan 2003 09:15:00 +0000 (09:15 +0000)]
Fix the copyright notice, give it an RCS ID, and fix the introductory
comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6911 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut Unicode strings into the protocol tree with the appropriate protocol
guy [Sat, 11 Jan 2003 08:22:39 +0000 (08:22 +0000)]
Put Unicode strings into the protocol tree with the appropriate protocol
tree item, not with hf_nt_str.  Get rid of hf_nt_str, as it's no longer
used.

Put ASCII strings into the protocol tree only once.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6910 f5534014-38df-0310-8fa8-9805f1628bb7

21 years ago"hf_nt_str" is of type FT_STRING, so it should be set to an ASCII
guy [Sat, 11 Jan 2003 07:52:34 +0000 (07:52 +0000)]
"hf_nt_str" is of type FT_STRING, so it should be set to an ASCII
string; set it to the result of the "fake_unicode()" call, not to the
raw Unicode string.  (Yes, we should have support for strings that don't
have 8-bit characters - and somehow handle strings in packets in
multiple character sets, e.g. ISO 8859/x and other EUC codes, the
Macintosh extended character set, various DOS/Windows code pages, and
Unicode - but we don't have it now.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6909 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of an extra "." at the end of the name of the "nt.str" field.
guy [Sat, 11 Jan 2003 07:48:22 +0000 (07:48 +0000)]
Get rid of an extra "." at the end of the name of the "nt.str" field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6908 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoGet rid of unused variables.
guy [Sat, 11 Jan 2003 07:40:09 +0000 (07:40 +0000)]
Get rid of unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6907 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Devin Heitmueller: improve dissection of the AIM signon-reply, the
guy [Sat, 11 Jan 2003 07:17:37 +0000 (07:17 +0000)]
From Devin Heitmueller: improve dissection of the AIM signon-reply, the
request-user-info, and the start of the user-info reply.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6906 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Jaime Fournier: extend the packet-dcerpc-krb5rpc dissectors to call
guy [Sat, 11 Jan 2003 07:11:21 +0000 (07:11 +0000)]
From Jaime Fournier: extend the packet-dcerpc-krb5rpc dissectors to call
kerberos V.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6905 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut the message type in the Info column.
guy [Sat, 11 Jan 2003 07:01:59 +0000 (07:01 +0000)]
Put the message type in the Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6904 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut the correct/incorrect flag after the CRC value, as is done for other
guy [Sat, 11 Jan 2003 06:17:22 +0000 (06:17 +0000)]
Put the correct/incorrect flag after the CRC value, as is done for other
checksums.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6903 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe OAM type and function type are packed into a single byte; set the
guy [Sat, 11 Jan 2003 06:03:49 +0000 (06:03 +0000)]
The OAM type and function type are packed into a single byte; set the
length of the entries for them to 1, not 2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6902 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIf it doesn't begin with FF 00 it can't be LANE LE Control; if it's
guy [Sat, 11 Jan 2003 05:54:52 +0000 (05:54 +0000)]
If it doesn't begin with FF 00 it can't be LANE LE Control; if it's
LANE, claimed to be LE Control, but doesn't begin with FF 00, call it
802.3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6901 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoDelete all prs_* functions. Huzzah!
tpot [Sat, 11 Jan 2003 04:42:16 +0000 (04:42 +0000)]
Delete all prs_* functions.  Huzzah!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6900 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFinish converting remaining RPCs to ndr routines.
tpot [Sat, 11 Jan 2003 04:40:21 +0000 (04:40 +0000)]
Finish converting remaining RPCs to ndr routines.

Deleted all the old crufy ndr pointer dissection. Hooray!

Next on the hit list is some refactoring of the ndr string
routines...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6899 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoConvert some incidental prs_* calls to dissect_dcerpc_*
tpot [Sat, 11 Jan 2003 04:35:57 +0000 (04:35 +0000)]
Convert some incidental prs_* calls to dissect_dcerpc_*
equivalents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6898 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoConverted some more RPCs to ndr routines.
tpot [Sat, 11 Jan 2003 00:42:12 +0000 (00:42 +0000)]
Converted some more RPCs to ndr routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6897 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIn "dissect_spnego_negTokenTarg()", don't assume we've found a GSSAPI
guy [Fri, 10 Jan 2003 23:47:30 +0000 (23:47 +0000)]
In "dissect_spnego_negTokenTarg()", don't assume we've found a GSSAPI
OID value for the protocol being used in a previous packet in the GSSAPI
sequence.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6896 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoPut the traffic type right after the AAL.
guy [Fri, 10 Jan 2003 09:46:19 +0000 (09:46 +0000)]
Put the traffic type right after the AAL.

Dump unknown AAL purportedly-reassembled data as raw data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6895 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoRename the "version" argument to "process_header_records()" "maj_vers",
guy [Fri, 10 Jan 2003 09:04:44 +0000 (09:04 +0000)]
Rename the "version" argument to "process_header_records()" "maj_vers",
as it's the major version number.

Try using the first word of "rsvd" to determine whether a capture is an
ISDN capture or not in version 1 captures.

Version 1 captures look as if they might also have a REC_HEADER2 record
- it's longer than the ones in version 4 and 5 captures, but it still
appears to have a network subtype in the 5th byte.

Get rid of the heuristic that checks for WTAP_ENCAP_ISDN by looking at
the packet data; if we fail to recognize an ISDN capture, we should look
for stuff in the headers to determine whether the capture is one or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6894 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIt looks as if a value of 0xfa in the second byte of a REC_HEADER2
guy [Fri, 10 Jan 2003 05:53:00 +0000 (05:53 +0000)]
It looks as if a value of 0xfa in the second byte of a REC_HEADER2
record might indicate an ISDN capture; treat that as an indication that
a capture is an ISDN capture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6893 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoConverted enumprinters and enumprinterkey rpc to ndr routines.
tpot [Fri, 10 Jan 2003 05:41:29 +0000 (05:41 +0000)]
Converted enumprinters and enumprinterkey rpc to ndr routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6892 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoConvert enumprinterdataex rpc to ndr format calls.
tpot [Fri, 10 Jan 2003 05:01:48 +0000 (05:01 +0000)]
Convert enumprinterdataex rpc to ndr format calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6891 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoOops, a last-minute name change didn't get into packet-atm.c.
guy [Fri, 10 Jan 2003 04:38:43 +0000 (04:38 +0000)]
Oops, a last-minute name change didn't get into packet-atm.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6890 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe Sniffer file formats include a file to identify raw cells; export
guy [Fri, 10 Jan 2003 04:04:42 +0000 (04:04 +0000)]
The Sniffer file formats include a file to identify raw cells; export
that flag in the ATM pseudo-header, and use it to determine whether a
frame is a raw cell or a reassembled frame, rather than using the AAL,
as you can have raw AAL5 cells in a capture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6889 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "datafiledir" rather than "DATAFILE_DIR" as the name of the variable
guy [Fri, 10 Jan 2003 00:03:33 +0000 (00:03 +0000)]
Use "datafiledir" rather than "DATAFILE_DIR" as the name of the variable
in the configure script for the all-variables-expanded version of the
data file directory.

Don't AC_SUBST "DATAFILE_DIR", as it's not used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6888 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoUse "plugindir", not "PLUGIN_DIR", as the variable name in the configure
guy [Thu, 9 Jan 2003 23:50:55 +0000 (23:50 +0000)]
Use "plugindir", not "PLUGIN_DIR", as the variable name in the configure
script for the plugin directory; in most Makefile.am files it's set with

plugindir = @plugindir@

(along the lines of what's done with other variables with pathnames -
the variable name is all lower case), so the variable needs to be named
"plugindir".

Fix the DOCSIS plugins' Makefile.am to use "plugindir".

Don't bother doing "AC_SUBST(PLUGIN_DIR)", as no Makefiles use
PLUGIN_DIR as an autoconf variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6887 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoFrom Albert Chin: "sync_pipe[]" isn't exported by "capture.c", so it
guy [Thu, 9 Jan 2003 19:37:14 +0000 (19:37 +0000)]
From Albert Chin: "sync_pipe[]" isn't exported by "capture.c", so it
shouldn't be declared in "capture.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6886 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoThe checksum in DOS ATM Sniffer files appears to be stored in big-endian
guy [Thu, 9 Jan 2003 04:36:26 +0000 (04:36 +0000)]
The checksum in DOS ATM Sniffer files appears to be stored in big-endian
format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6885 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCheck the CRC-10 on AAL3/4 and OAM cells.
guy [Thu, 9 Jan 2003 04:11:08 +0000 (04:11 +0000)]
Check the CRC-10 on AAL3/4 and OAM cells.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6884 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoCheck the HEC in ATM cells.
guy [Thu, 9 Jan 2003 03:45:34 +0000 (03:45 +0000)]
Check the HEC in ATM cells.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6883 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoAdd code to check the AAL5 CRC, and report it as a CRC rather than as a
guy [Thu, 9 Jan 2003 02:55:21 +0000 (02:55 +0000)]
Add code to check the AAL5 CRC, and report it as a CRC rather than as a
checksum.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6882 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIt appears that a channel number of 0 means DTE->DCE, and a channel
guy [Thu, 9 Jan 2003 01:55:13 +0000 (01:55 +0000)]
It appears that a channel number of 0 means DTE->DCE, and a channel
number of 1 means DCE->DTE, in DOS Sniffer ATM captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6881 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoIt appears that ATM sniffer files with 4.x versions 4.95 and greater
guy [Thu, 9 Jan 2003 01:38:30 +0000 (01:38 +0000)]
It appears that ATM sniffer files with 4.x versions 4.95 and greater
have a bogus record length for type 4 records, but earlier 4.x versions,
and 5.x versions, don't.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6880 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoReplace :
oabad [Wed, 8 Jan 2003 23:33:38 +0000 (23:33 +0000)]
Replace :
popup_menu_object = gtk_widget_new(GTK_TYPE_WIDGET, NULL);
with
popup_menu_object = gtk_menu_new();

so that ethereal runs with Gtk+ v2.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6879 f5534014-38df-0310-8fa8-9805f1628bb7

21 years agoMake the AAL for a packet a filterable field.
guy [Wed, 8 Jan 2003 23:07:44 +0000 (23:07 +0000)]
Make the AAL for a packet a filterable field.

Put the code to handle AAL5 and Signalling AAL traffic, and to handle
raw cells, into routines of their own.

Don't put the VPI/VCI/cell count information from the pseudo-header into
the protocol tree for raw cells - just get the VPI/VCI from the raw
cell, and leave out the cell count.

Set the Protocol and Info column for AAL1 and AAL3/4 cells.

Clean up the names of some of the raw cell fields, as displayed.

Make the payload type text match what's in various specs.

Display the cell loss priority symbolically.

Fix up the code that displays the AAL3/4 trailer information to use the
AAL3/4 trailer rather than the AAL3/4 header.

Show the number of cells if we have reassembled traffic complete with
the AAL5 trailer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6878 f5534014-38df-0310-8fa8-9805f1628bb7