obnox/wireshark/wip.git
13 years agoFrom Graham Bloice:
jake [Fri, 26 Jan 2007 17:12:00 +0000 (17:12 +0000)]
From Graham Bloice:
In the Developers Guide, Section 9.3, Example 9.17. Decompressing data
packets for dissection

The code calls tvb_set_free_cb() for the newly created next_tvb.  This
is unnecessary as the call to tvb_set_child_real_data() adds next_tvb to
the chained list of tvb, thus ensuring that next_tvb is correctly
deleted.  In fact when I had the call in, Visual Studio kept breaking
deep down in ntdll.dll, probably because of a double free every time the
main tvb was deleted.

In README.developer, para 2..2.7 The example conversation code doesn't
assign the result of conversation_new() back into the conversation variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20569 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Patrick vd Lageweg:
jake [Fri, 26 Jan 2007 17:06:17 +0000 (17:06 +0000)]
From Patrick vd Lageweg:
This patch fixes three problems with the SCSI persistent reserve in command:
- The Additional length starts at offset 4 and not 0
- The len field contains the length used by the keys and doesn't include the header length.
  So don't substract the header length from the length.
- The key list is traversed from the beginning to end end and not the other way around.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20568 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoform Florian Lohoff
lego [Fri, 26 Jan 2007 15:10:47 +0000 (15:10 +0000)]
form Florian Lohoff

here is an addition to the redback radius dictionary - Attributes seen
in all authentications for PPPoE sessions ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20567 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUse previously unused hf_cops_obj_c_type (cops.c_type) field
martinm [Fri, 26 Jan 2007 12:14:06 +0000 (12:14 +0000)]
Use previously unused hf_cops_obj_c_type (cops.c_type) field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20566 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTLS 1.0/1.1 just ignores unknown records - RFC 2246 chapter 6. The TLS Record Protocol
kukosa [Fri, 26 Jan 2007 12:08:45 +0000 (12:08 +0000)]
TLS 1.0/1.1 just ignores unknown records - RFC 2246 chapter 6. The TLS Record Protocol
(some implementations use it like "keepalive")

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20565 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMake COPS dissector findable by name
martinm [Fri, 26 Jan 2007 11:31:51 +0000 (11:31 +0000)]
Make COPS dissector findable by name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20564 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix bugs 1330 & 1333 (one wrong and one missing entry in XML description)
martinm [Fri, 26 Jan 2007 10:40:34 +0000 (10:40 +0000)]
Fix bugs 1330 & 1333 (one wrong and one missing entry in XML description)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20563 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIf there is just a tftp response without a prior request,
jmayer [Fri, 26 Jan 2007 08:09:20 +0000 (08:09 +0000)]
If there is just a tftp response without a prior request,
dissection would fail with dissector assert.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20562 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSpelling fixes.
gerald [Fri, 26 Jan 2007 06:45:12 +0000 (06:45 +0000)]
Spelling fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20561 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMassive indentation fixes.
gerald [Fri, 26 Jan 2007 06:34:05 +0000 (06:34 +0000)]
Massive indentation fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20560 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoA few more ethereal --> wireshark
wmeier [Fri, 26 Jan 2007 01:34:29 +0000 (01:34 +0000)]
A few more ethereal --> wireshark

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20559 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug #1325: Protocol hierarchy display shows an empty line because of
sfisher [Thu, 25 Jan 2007 23:00:29 +0000 (23:00 +0000)]
Fix for bug #1325: Protocol hierarchy display shows an empty line because of
the hop-by-hop option header tree in the main protocol tree.  This fix skips
those entries that don't have a name assigned to them and goes on to the next
entry before adding it to the protocol hierarchy display.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20558 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove extra space from a call .cmd file command line so it can be copied
sfisher [Thu, 25 Jan 2007 21:07:29 +0000 (21:07 +0000)]
Remove extra space from a call .cmd file command line so it can be copied
and pasted out of the guide

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20557 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix indentation of field_info struct definition
sfisher [Thu, 25 Jan 2007 20:47:37 +0000 (20:47 +0000)]
Fix indentation of field_info struct definition

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20556 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate manifest file (template) to:
gal [Thu, 25 Jan 2007 17:37:54 +0000 (17:37 +0000)]
Update manifest file (template) to:
a) remove schema reference
b) assign new GUID for 0.99.6

Update makefile.nmake to:
a) include user-guide.chm - user-guide.chm is copied from the nsis packaging directory
b) include the example_snmp_users_file
c) other tidy-ups

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20555 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoModification of version resource.
jake [Thu, 25 Jan 2007 07:42:10 +0000 (07:42 +0000)]
Modification of version resource.
- FILEFLAGS should not contain VS_FF_SPECIAL_BUILD
- FILEOS changed to VOS_NT_WINDOWS32 since we no longer support pre-NT platforms
- Adding Comments string to include compiler, based on MSVC_VARIANT symbol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20554 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove dead code. Fixes Coverity CID 228. Squelch various compiler warnings.
gerald [Thu, 25 Jan 2007 07:06:47 +0000 (07:06 +0000)]
Remove dead code.  Fixes Coverity CID 228.  Squelch various compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20553 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSquelch Coverity CIDs 225, 226, and 227.
gerald [Thu, 25 Jan 2007 06:51:30 +0000 (06:51 +0000)]
Squelch Coverity CIDs 225, 226, and 227.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20552 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAttempt to squelch Coverity CID 222.
gerald [Thu, 25 Jan 2007 06:45:09 +0000 (06:45 +0000)]
Attempt to squelch Coverity CID 222.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20551 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix Coverity CIDs 217 and 218, and fix filter dialog autoselection in
gerald [Thu, 25 Jan 2007 02:54:14 +0000 (02:54 +0000)]
Fix Coverity CIDs 217 and 218, and fix filter dialog autoselection in
the process.  This change assumes that you can make a copy of a
GtkTreeIter and use it later (which may not be valid), and hasn't been
tested using GTK 1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20550 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a key preference crash bug. Improve WPA passphrase and SSID length
gerald [Thu, 25 Jan 2007 01:24:14 +0000 (01:24 +0000)]
Fix a key preference crash bug.  Improve WPA passphrase and SSID length
handling.  Free a byte array.  Squelch a compiler warning.  Fix a URI
string parsing bug.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20549 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoWhen parsing DISPLAY, mirror what __X11TransConnectDisplay() does - and
guy [Wed, 24 Jan 2007 23:30:23 +0000 (23:30 +0000)]
When parsing DISPLAY, mirror what __X11TransConnectDisplay() does - and
handle the case where the "host name" begins with "/", as some platforms
might allow the pathname of a UNIX domain socket to be given in DISPLAY.

Fix indentation of a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20548 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate the NEWS file.
gerald [Wed, 24 Jan 2007 19:27:49 +0000 (19:27 +0000)]
Update the NEWS file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20547 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix Coverity CID 230: Make sure we handle a negative tvb_length_remaining()
gerald [Wed, 24 Jan 2007 19:22:13 +0000 (19:22 +0000)]
Fix Coverity CID 230: Make sure we handle a negative tvb_length_remaining()
value correctly.  Fix up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20546 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agodissect SDP encapsulated inside an Q1950 annex A.7 paramenter of H248
lego [Wed, 24 Jan 2007 17:19:44 +0000 (17:19 +0000)]
dissect SDP encapsulated inside an Q1950 annex A.7 paramenter of H248

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20545 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix for bug #1308: tacacs decoding fails. Introduce TCP desegmentation for
sfisher [Wed, 24 Jan 2007 04:57:32 +0000 (04:57 +0000)]
Fix for bug #1308: tacacs decoding fails.  Introduce TCP desegmentation for
data after the fixed length header as some implementations may not send
the header and payload in the same segment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20544 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoIt's not an error if we don't find any AirPcap interfaces when AirPcap isn't
gerald [Wed, 24 Jan 2007 01:17:48 +0000 (01:17 +0000)]
It's not an error if we don't find any AirPcap interfaces when AirPcap isn't
loaded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20543 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoInstead of checking for WinPcap 4.x versions, assume that if the version
gerald [Wed, 24 Jan 2007 01:16:45 +0000 (01:16 +0000)]
Instead of checking for WinPcap 4.x versions, assume that if the version
is greater than 3 we can get detailed interface information.  This should
limit the amount of work we have to do when new WinPcap releases come out.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20542 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix compilation (under Windows, at least).
gerald [Wed, 24 Jan 2007 01:06:24 +0000 (01:06 +0000)]
Fix compilation (under Windows, at least).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20541 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd range to the metatable of Tvb.
lego [Tue, 23 Jan 2007 23:36:28 +0000 (23:36 +0000)]
add range to the metatable of Tvb.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20540 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agotvb:range did not appear under Tvb in generated refman
lego [Tue, 23 Jan 2007 23:34:41 +0000 (23:34 +0000)]
tvb:range did not appear under Tvb in generated refman
pinfo.curr_proto appeared as pinfo.match
pinfo.columns in the refman was pinfo.cols in lua (now it is both in lua and in refman)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20539 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix problem "no target to build user-guide.zip"
ulfl [Tue, 23 Jan 2007 21:19:46 +0000 (21:19 +0000)]
fix problem "no target to build user-guide.zip"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20538 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd the obsolete RESERVE10/RELEASE10 to the sbc dissector
sahlberg [Tue, 23 Jan 2007 20:59:50 +0000 (20:59 +0000)]
add the obsolete RESERVE10/RELEASE10 to the sbc dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20537 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agosome iscsi/scsi initiators still use the ancient sbc1 commandset so add RESERVE6...
sahlberg [Tue, 23 Jan 2007 20:49:57 +0000 (20:49 +0000)]
some iscsi/scsi initiators still use the ancient sbc1 commandset    so add RESERVE6/RELEASE6 to the SBC dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20536 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPropagate the recent interface list changes (r20521) to the AirPcap code.
gerald [Tue, 23 Jan 2007 20:12:09 +0000 (20:12 +0000)]
Propagate the recent interface list changes (r20521) to the AirPcap code.
Fix a mismatched declaration found by Gisle Vanem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20535 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a shord description on how the snmp_users_file can be used
lego [Tue, 23 Jan 2007 19:56:10 +0000 (19:56 +0000)]
Add a shord description on how the snmp_users_file can be used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20534 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoHave build succeed even if portaudio is located somewhere else than any other librari...
lego [Tue, 23 Jan 2007 19:46:55 +0000 (19:46 +0000)]
Have build succeed even if portaudio is located somewhere else than any other libraries in use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20533 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoDISSECTOR_ASSERT_NOT_REACHED() now, by default, throws a Wireshark
guy [Tue, 23 Jan 2007 18:31:26 +0000 (18:31 +0000)]
DISSECTOR_ASSERT_NOT_REACHED() now, by default, throws a Wireshark
exception rather than aborting the program; using it means that
dissector bugs show up as such rather than as malformed packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20532 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoif DataSegmentLength is non zero for iscsi async messages the data segment contains
sahlberg [Tue, 23 Jan 2007 09:38:41 +0000 (09:38 +0000)]
if DataSegmentLength is non zero for iscsi async messages  the data segment contains
scsi sense information potentially followed by iscsi event data.

this is used by a target to tell an initiator (among other things) that the lun configuration has changed and now is a good time to rescan the target for lun changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20531 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoremove example_snmp_users_file at uninstall
ulfl [Tue, 23 Jan 2007 08:20:59 +0000 (08:20 +0000)]
remove example_snmp_users_file at uninstall

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20530 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd correct link to vcredist_x86.exe
ulfl [Tue, 23 Jan 2007 08:12:20 +0000 (08:12 +0000)]
add correct link to vcredist_x86.exe

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20529 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a link to the Providence University WinPcap mirror, and a comment
gerald [Tue, 23 Jan 2007 01:49:30 +0000 (01:49 +0000)]
Add a link to the Providence University WinPcap mirror, and a comment
linking to the WinPcap mirror page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20528 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agowinpcap.mirror.wireshark.org doesn't exist, so remove it.
gerald [Tue, 23 Jan 2007 01:25:57 +0000 (01:25 +0000)]
winpcap.mirror.wireshark.org doesn't exist, so remove it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20527 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoBump the trunk version to 0.99.6.
gerald [Mon, 22 Jan 2007 22:57:32 +0000 (22:57 +0000)]
Bump the trunk version to 0.99.6.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20526 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd dfilter_macro_load.c to the distclean target to rebuild it if building from a...
etxrab [Mon, 22 Jan 2007 21:32:17 +0000 (21:32 +0000)]
Add dfilter_macro_load.c to the distclean target to rebuild it if building from a tarball.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20524 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoas Bill Meier noted:
ulfl [Mon, 22 Jan 2007 04:03:17 +0000 (04:03 +0000)]
as Bill Meier noted:
"The Help ! Contents and the Help ! User's Guide  both display the User's
Guide."

Remove the duplicate Help!/User's Guide item

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20523 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix various compiler warnings
sfisher [Mon, 22 Jan 2007 00:20:33 +0000 (00:20 +0000)]
Fix various compiler warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20522 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoHave the routines to get interface lists take a pointer to a "gchar *"
guy [Sun, 21 Jan 2007 23:45:36 +0000 (23:45 +0000)]
Have the routines to get interface lists take a pointer to a "gchar *"
as an argument, and, on an error, if they have an error message, have
them set that "gchar *" to point to a g_malloc()ed string containing the
error message, rather than taking a pointer to a buffer for that message
as an argument.  That's more like what's done in Wiretap, and doesn't
impose an upper limit on the lengths of those error messages.  If that
pointer is null, don't allocate the message string and return it.

Have that error message already have the "cant_get" processing applied
to it, so nobody other than those routines need to call the "cant_get"
routines to process the error messages.

Have get_airpcap_interface_list() explicitly set "*err" to the
appropriate error code.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20521 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Tobias Witek:
sfisher [Sun, 21 Jan 2007 23:36:53 +0000 (23:36 +0000)]
From Tobias Witek:

I found a rare situation in which the BSSAP dissector seems to wrongly
assume a packet.

When a RANAP DirectTransfer message contains the GSM Supplementary
Service 'Call Confirmed' this seems to yield a message that the BSSAP
dissector recognizes as a BSSMAP BLOCK message (and from the perspective
of BSSAP, this is perfectly correct).

My patch includes code that checks this very special case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20520 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoChange frame dissector to show "frame" instead of "packet" for all fields
sfisher [Sun, 21 Jan 2007 23:02:07 +0000 (23:02 +0000)]
Change frame dissector to show "frame" instead of "packet" for all fields
for consistency.  The frame.pkt_len filter is now deprecated, but still
supported as a hidden field for an easy transition.  The new field name is
frame.len.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20519 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Sebastien Tandel:
sfisher [Sun, 21 Jan 2007 22:45:58 +0000 (22:45 +0000)]
From Sebastien Tandel:

patch against a crash of wireshark with gtk1.2 when using packet
length statistics window.  The crash was due to a difference of
implementation of g_strsplit between gtk1.2 and gtk2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20518 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSet the appropriate keywords.
guy [Sun, 21 Jan 2007 22:32:37 +0000 (22:32 +0000)]
Set the appropriate keywords.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20517 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSet the appropriate keywords.
guy [Sun, 21 Jan 2007 22:28:54 +0000 (22:28 +0000)]
Set the appropriate keywords.

Add a newline at the end of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20516 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix bug 1321
lego [Sun, 21 Jan 2007 17:06:16 +0000 (17:06 +0000)]
fix bug 1321

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20515 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix bug 1320
lego [Sun, 21 Jan 2007 17:05:33 +0000 (17:05 +0000)]
fix bug 1320

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20514 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agomajor redesign:
ulfl [Sun, 21 Jan 2007 04:48:49 +0000 (04:48 +0000)]
major redesign:
- add a chapter about a Win32 Quick Setup
- update MSVC information about Versions > 6

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20513 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix a bug where the size of each column was being computed with the GTK+
sfisher [Sat, 20 Jan 2007 23:23:50 +0000 (23:23 +0000)]
Fix a bug where the size of each column was being computed with the GTK+
default font of Sans 10 instead of the setting in Wireshark (such as
Monospace 10).  On some systems this bug was causing the contents of columns
such as the command line specified (CLS) time to be cut off.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20512 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate some value strings.
etxrab [Sat, 20 Jan 2007 21:45:38 +0000 (21:45 +0000)]
Update some value strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20511 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofrom Stephen Fisher:
ulfl [Sat, 20 Jan 2007 17:52:39 +0000 (17:52 +0000)]
from Stephen Fisher:
A user asked what file format the flow graph is saved as, which isn't
apparent by looking at the dialog.  I had to try saving a file and check
its type -- plain text file.  Could someone please apply the attached
patch or similar change to graph_analysis.c.  My patch updates the title
of the dialog box from "Wireshark: Save graph to file" to "Wireshark:
Save graph to text file".

However, I used the term "plain text file" instead ;-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20510 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Graeme Hewson:
jake [Sat, 20 Jan 2007 16:46:42 +0000 (16:46 +0000)]
From Graeme Hewson:
The attached patch adds Homeplug to the table of ethernet types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20509 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTrying to get buildbot Windows-XP-x86 to build again.
jake [Sat, 20 Jan 2007 14:08:05 +0000 (14:08 +0000)]
Trying to get buildbot Windows-XP-x86 to build again.
Reverting GTK2 to GTK1.2 functionname

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20508 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRecent versions of GTK+ have added a "gtk-label-select-on-focus"
gerald [Sat, 20 Jan 2007 02:05:49 +0000 (02:05 +0000)]
Recent versions of GTK+ have added a "gtk-label-select-on-focus"
property, which selects the entire contents of a label when it comes
into focus.  This property annoyingly defaults to TRUE, which meant that
the labels in simple dialogs and the about box would unexpectedly show
up selected.

Work around this by setting the focus on the "OK" button in the about
dialog and the first button specified in simple dialogs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20507 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Paul Moore:
jake [Fri, 19 Jan 2007 23:56:42 +0000 (23:56 +0000)]
From Paul Moore:
This patch adds support for the IPv4 Commercial IP Security Option (CIPSO) as
defined in the IETF draft, draft-ietf-cipso-ipsecurity-01.txt.  While this
draft has long since expired, it has become a de-facto standard for labeled
networking with support from several commercial Multi-Level Security (MLS)
operating systems such as HP-UX CMW and Trusted Solaris; in addition, Linux
Kernels 2.6.19 and later provide support for CIPSO in conjunction with
SELinux.

Copies of the expired CIPSO draft can be found at the NetLabel project page:
 * http://netlabel.sf.net

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20506 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix the SCCP dissector so it doesn't show non-segmented DT1 messages as
morriss [Fri, 19 Jan 2007 23:27:24 +0000 (23:27 +0000)]
Fix the SCCP dissector so it doesn't show non-segmented DT1 messages as
having been reassembled.

Fix the comments in reassembly.c and reassembly.h regarding what the reassembly
routines actually return in the 802.11 and no-sequence-number cases when they
are given the first and last packet (that is, a non-segmented packet): in
particular the routines return a pointer to a list containing just the one
fragment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20505 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoReindent pretty heavily. It's still not 100% consistent but at least all the
morriss [Fri, 19 Jan 2007 17:25:13 +0000 (17:25 +0000)]
Reindent pretty heavily.  It's still not 100% consistent but at least all the
code in each function is consistent (previously there were some sections of
code indented, oh, about 10 indentations too far).  At the same time, remove
trailing white space and change spaces to tabs.

Remove one duplicated call to sccp_assoc() and s/isup_apm/sccp/g in the hf[]
array (apparently when the XUDT reassembly was put in it was copied from ISUP
but the filter names weren't changed).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20502 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdated svn:ignore props for win32 build artifacts
grahamb [Fri, 19 Jan 2007 16:20:48 +0000 (16:20 +0000)]
Updated svn:ignore props for win32 build artifacts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20501 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoSet our package version even if we're using the SVN client.
gerald [Fri, 19 Jan 2007 06:34:07 +0000 (06:34 +0000)]
Set our package version even if we're using the SVN client.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20500 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPut in some information about RSSI.
guy [Fri, 19 Jan 2007 05:22:43 +0000 (05:22 +0000)]
Put in some information about RSSI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20498 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAs discussed on the devlist:
ulfl [Fri, 19 Jan 2007 02:41:25 +0000 (02:41 +0000)]
As discussed on the devlist:
A clean_setup is done first now to ensure that the target dirs don't contain old files -  probably remaining from a previous setup run.

explicit removing of the gtk2 dir is no longer required therefore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20497 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agouser-guide final step:
ulfl [Fri, 19 Jan 2007 01:21:17 +0000 (01:21 +0000)]
user-guide final step:
enable HHC_DIR as default, hopefully the buildbot will "get it right" now :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20496 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd the user-guide as a component to the setup target
ulfl [Fri, 19 Jan 2007 01:10:59 +0000 (01:10 +0000)]
add the user-guide as a component to the setup target

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20495 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd user-guide.zip to the clean target
ulfl [Fri, 19 Jan 2007 00:14:43 +0000 (00:14 +0000)]
add user-guide.zip to the clean target

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20494 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoadd a target to build a zipped version of user-guide.chm
ulfl [Fri, 19 Jan 2007 00:12:01 +0000 (00:12 +0000)]
add a target to build a zipped version of user-guide.chm

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20493 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoinstead of getting the user-guide.chm file always from the docbook dir, copy the...
ulfl [Fri, 19 Jan 2007 00:10:22 +0000 (00:10 +0000)]
instead of getting the user-guide.chm file always from the docbook dir, copy the more recent one from docbook or win32-libs\user-guide dir into local nsis dir, and use that one to build the installer - seems to be the cleanest way

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20492 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agothe docbook generation also suffers from the cygwin bash CR/LF problem :-(
ulfl [Thu, 18 Jan 2007 23:57:03 +0000 (23:57 +0000)]
the docbook generation also suffers from the cygwin bash CR/LF problem :-(
I've added a call to dos2unix to convert check_svn_version.sh that way

Is it safe to assume that dos2unix is available on a common UNIX developer machine?!?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20491 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd a preference (defaulted to off) to have the MTP3 dissector show the priority...
morriss [Thu, 18 Jan 2007 22:06:56 +0000 (22:06 +0000)]
Add a preference (defaulted to off) to have the MTP3 dissector show the priority (which is a national option in ITU) of MSUs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20490 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoChange save & restart requirement sentence in column preferences to say just
sfisher [Thu, 18 Jan 2007 20:53:24 +0000 (20:53 +0000)]
Change save & restart requirement sentence in column preferences to say just
that you must restart wireshark for the changes to take effect.  The sentence
used to say to hit the save button first, which is now gone by default.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20489 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTrying to get buildbot Windows-XP-x86 to build again.
jake [Thu, 18 Jan 2007 20:21:35 +0000 (20:21 +0000)]
Trying to get buildbot Windows-XP-x86 to build again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20486 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoPut
guy [Thu, 18 Jan 2007 18:43:30 +0000 (18:43 +0000)]
Put

#ifdef __cplusplus
extern "C" {
#endif /* __cplusplus */

...

#ifdef __cplusplus
}
#endif /* __cplusplus */

wrappers into some header files, for the benefit of C++ plugins.  Also,
add multiple-include protections.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20485 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoguint32 requires %[doxu], not %l[doxu]. (We don't support ILP16
guy [Thu, 18 Jan 2007 18:41:46 +0000 (18:41 +0000)]
guint32 requires %[doxu], not %l[doxu].  (We don't support ILP16
platforms, just ILP32, LP64, and LLP64.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20484 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoExport the split fvalue_get_integer as fvalue_get_uinteger and fvalue_get_sinteger
jake [Thu, 18 Jan 2007 16:36:10 +0000 (16:36 +0000)]
Export the split fvalue_get_integer as fvalue_get_uinteger and fvalue_get_sinteger

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20483 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agofix the dfilter_macro_load.c rule
lego [Thu, 18 Jan 2007 15:32:01 +0000 (15:32 +0000)]
fix the dfilter_macro_load.c rule

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20482 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoI actually forgot that dfilter_macro_expand.l was not used
lego [Thu, 18 Jan 2007 15:00:39 +0000 (15:00 +0000)]
I actually  forgot that dfilter_macro_expand.l was not used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20481 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoThe forgotten file strikes back...
lego [Thu, 18 Jan 2007 14:56:03 +0000 (14:56 +0000)]
The forgotten file strikes back...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20480 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFilled in missing hf entries.
martinm [Thu, 18 Jan 2007 14:41:59 +0000 (14:41 +0000)]
Filled in missing hf entries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20479 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFix version_info.c compilation
lego [Thu, 18 Jan 2007 14:04:49 +0000 (14:04 +0000)]
Fix version_info.c compilation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20478 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoRemove extra element.
martinm [Thu, 18 Jan 2007 13:13:55 +0000 (13:13 +0000)]
Remove extra element.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20477 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoImprove information on building plugins.
jake [Thu, 18 Jan 2007 12:22:21 +0000 (12:22 +0000)]
Improve information on building plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20476 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Clay Jones: Shomiti wireless packet support.
guy [Thu, 18 Jan 2007 12:19:17 +0000 (12:19 +0000)]
From Clay Jones: Shomiti wireless packet support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20475 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoMissed this one (I don't build with pcre)
martinm [Thu, 18 Jan 2007 11:44:24 +0000 (11:44 +0000)]
Missed this one (I don't build with pcre)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20474 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTrying to fix the build on Ubuntu-5.10-x86 buildbot again.
jake [Thu, 18 Jan 2007 11:28:47 +0000 (11:28 +0000)]
Trying to fix the build on Ubuntu-5.10-x86 buildbot again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20473 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoAdd separate union entries to fvalue.value for signed and unsigned
martinm [Thu, 18 Jan 2007 11:02:26 +0000 (11:02 +0000)]
Add separate union entries to fvalue.value for signed and unsigned
32-bit numbers.  Separate signed and unsigned accessors have been
added and used where appropriate.

Definitely not for 0.99.5.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20472 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoTrying to get buildbot Ubuntu-5.10-x86 to build again.
jake [Thu, 18 Jan 2007 07:10:02 +0000 (07:10 +0000)]
Trying to get buildbot Ubuntu-5.10-x86 to build again.
Fix typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20471 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoNOT for 0.99.5
lego [Thu, 18 Jan 2007 03:21:22 +0000 (03:21 +0000)]
NOT for 0.99.5
macro_dlg.h was in this other file!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20470 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agonot for 0.99.5
lego [Thu, 18 Jan 2007 03:17:33 +0000 (03:17 +0000)]
not for 0.99.5
add macro_dlg.h and macro_dlg.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20469 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agothe version string stated "without Lua" regardless or not Lua support was indeed...
lego [Thu, 18 Jan 2007 03:13:10 +0000 (03:13 +0000)]
the version string stated "without Lua" regardless or not Lua support was indeed built.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20468 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agodisplay filter macros.
lego [Thu, 18 Jan 2007 02:54:56 +0000 (02:54 +0000)]
display filter macros.
NOT to be copied over to release 0.99.5

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20467 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agocheck if we have a finfo before dereferencing it later in PROTO_ITEM_IS_HIDDEN()
sahlberg [Wed, 17 Jan 2007 21:05:44 +0000 (21:05 +0000)]
check if we have a finfo before dereferencing it later in PROTO_ITEM_IS_HIDDEN()

this prevents wireshark from crashing on X Liu's kerberos capture files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20464 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoUpdate to use the latest GTK packages.
etxrab [Wed, 17 Jan 2007 19:14:11 +0000 (19:14 +0000)]
Update to use the latest GTK packages.
Win32-setup.sh changed to overwrite existing folders.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20463 f5534014-38df-0310-8fa8-9805f1628bb7

13 years agoFrom Patrick vd Lageweg:
jake [Wed, 17 Jan 2007 17:11:09 +0000 (17:11 +0000)]
From Patrick vd Lageweg:
The "NUMBER OF BLOCKS" field in the SCSI MODE SENSE return data is 24 bits and not 32 bits. This patch fixes that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20462 f5534014-38df-0310-8fa8-9805f1628bb7