guy [Tue, 21 Sep 2010 09:53:44 +0000 (09:53 +0000)]
Move a bunch of definitions before the code that uses at least one of
the variables in question.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34174
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 21 Sep 2010 09:30:16 +0000 (09:30 +0000)]
Try to fix:
"In menus_init() you seem to use ui_manager_packet_list_heading before it's initialized."
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34173
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 21 Sep 2010 07:18:31 +0000 (07:18 +0000)]
Add an SVN ID.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34172
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 21 Sep 2010 07:17:20 +0000 (07:17 +0000)]
Get rid of C++ comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34171
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 21 Sep 2010 07:08:35 +0000 (07:08 +0000)]
Make "Displayed Columns" work yet again, as done in revision 34160.
Bring back 'Resize Column' and 'Rename Column Title'.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34170
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 21 Sep 2010 05:58:14 +0000 (05:58 +0000)]
Fix comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34169
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 21 Sep 2010 05:32:32 +0000 (05:32 +0000)]
Update GUIManager menubar code(#IF 0 ).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34168
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 21 Sep 2010 05:24:02 +0000 (05:24 +0000)]
Wrong signature used for a GtkToggleActionEntry callback.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34167
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 21 Sep 2010 05:10:38 +0000 (05:10 +0000)]
Remove leftover debug code/comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34166
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 21 Sep 2010 03:14:49 +0000 (03:14 +0000)]
As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34165
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 21 Sep 2010 03:06:54 +0000 (03:06 +0000)]
Add a cast
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34164
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 21 Sep 2010 02:41:29 +0000 (02:41 +0000)]
Use size_t to keep the Windows compiler happy
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34163
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Tue, 21 Sep 2010 02:12:21 +0000 (02:12 +0000)]
From Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3336 :
We parse host & request page from headers, so we easily can construct full http
uri.
I was thinking about making it as field, so we could filter, print in column
info, or do other fancy stuff, but for now this is imho enough.
From me: add it as a (filterable) item. Clean up spacing and indentation in a
few places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34162
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 20 Sep 2010 17:01:22 +0000 (17:01 +0000)]
Fix sequence numbers reported when duplicate SN detected.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34161
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 20 Sep 2010 13:11:48 +0000 (13:11 +0000)]
Make "Displayed Columns" work again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34160
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 20 Sep 2010 12:49:52 +0000 (12:49 +0000)]
Put Abort reason in info column.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34159
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 19 Sep 2010 15:03:36 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2010-09-19]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34155
f5534014-38df-0310-8fa8-
9805f1628bb7
jake [Sat, 18 Sep 2010 13:12:03 +0000 (13:12 +0000)]
Fix for bug 5220:
- Don't list codecs which are deleted by using port 0.
- Use real concatenation i.s.o. reprint, which seems to fail in some circumstances.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34154
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 18 Sep 2010 01:07:00 +0000 (01:07 +0000)]
Update Cal Turney's entry for the tshark SCSI tap
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34153
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Sat, 18 Sep 2010 01:03:45 +0000 (01:03 +0000)]
From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5223 :
I would like to contribute iSCSI SRT tap, 'tap-scsistat.c' for tshark.
The output exactly matches that of the Wireshark's iSCSI(disk) SRT dialog.
From me: a couple of small changes to make it compile without warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34152
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 17 Sep 2010 14:03:05 +0000 (14:03 +0000)]
Copy the rev 34143 changes to packet-snmp.c over to the asn1 source.
hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING. This fixes
the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34151
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 17 Sep 2010 13:38:09 +0000 (13:38 +0000)]
Don't include stock icons that we no longer use.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34150
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 17 Sep 2010 12:54:07 +0000 (12:54 +0000)]
Use GTK dialog stock icons rather than our own.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34149
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Sep 2010 08:48:19 +0000 (08:48 +0000)]
Fix some bugs that show up when you build with the old packet list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34148
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Sep 2010 07:24:35 +0000 (07:24 +0000)]
Put the definition of NEW_PACKET_LIST into config.h rather than the
Makefile; that will force a rebuild if you configure it on or off
(that'll rebuild stuff that doesn't need to be rebuilt, but it'll also
rebuild stuff that *does* need to be rebuilt and that wouldn't be
rebuilt otherwise).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34145
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 17 Sep 2010 04:58:30 +0000 (04:58 +0000)]
Use the same control sequences for the old packet list that are used for
the new packet list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34144
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 17 Sep 2010 04:51:21 +0000 (04:51 +0000)]
Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34143
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 17 Sep 2010 02:22:37 +0000 (02:22 +0000)]
Remove check_col(). Clean up some spacing/indentation too.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34142
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 17 Sep 2010 02:03:09 +0000 (02:03 +0000)]
From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5197 :
The NFS dissector (all versions) show access types that have not been requested
to be checked as "not allowed" in the call and reply. This is incorrect and
misleading. At present one must manually compare what was requested in order
to assess if access was actually denied for that type. When there are hundreds
or thousands of these ACCESS requests in a capture, it is not possible or
practical to manually check each one.
The submitted patch does the following:
* Passes the access mask in the call to the reply for comparison
* Adds filterable fields for each supported (v4) and access type
* Adds a pseudo field, nfs.access_denied
* Lists the access types to be checked in the summary and tree
* Separately lists the supported, denied, and allowed access types in the
summary and tree
The changes are applied to all NFS versions.
From me: a couple of small changes to make it compile without warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34141
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 17 Sep 2010 01:45:29 +0000 (01:45 +0000)]
Extensive V9/V10 code clean up, bug fixing & dissection display improvements:
Bugs fixed:
- Invalid time display for various time fields;
Millisecs for types 152, 153 are actually stored as 64 bit integers;
Microsecs, nanosecs are actually stored in "NTP format";
Times for fields 158, 159 are relative to "export time";
SystemInitTime displayed incorrectly;
...
- Options template not cached when only scope fields in template.
- Templates not processed on first pass thru capture file:
(In some cases data flows might not be handled until options template later displayed).
- V9: number of options template entries limited to about 8 instead of intended 42;
- Multiple options temlate flows in an Options Template flowset not handled;
- "NotSentOctets" dislayed as "NotSentPackets";
...
Cleanups:
- Options and data template processing code more or less rewritten;
- options template displayed with format similar to that used for data templates;
- Handling and display of PEN field (including use to indicate REVERSE) improved;
- Don't use same filter name for two similar fields which only differ in size;
- Handling & dislay of "variable length" fields improved;
- sminmec lookup (PEN) done only during template processing & cached for later use;
...
- Whitespace/Formatting
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34140
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 16 Sep 2010 19:56:34 +0000 (19:56 +0000)]
More typos.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34139
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 16 Sep 2010 19:55:25 +0000 (19:55 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34138
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 16 Sep 2010 19:20:06 +0000 (19:20 +0000)]
Turn on ASLR via /DYNAMICBASE and DEP via SetProcessDEPPolicy().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34137
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 16 Sep 2010 18:22:45 +0000 (18:22 +0000)]
Add "(BE)" to the big endian representations of the ICMP identifier and
sequence number fields to match the "(LE)" ones.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34136
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 16 Sep 2010 13:12:02 +0000 (13:12 +0000)]
#if out ui_desc_conv_filter_popup to get the builds going (it looks like it should be used but it isn't currently).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34135
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Thu, 16 Sep 2010 12:29:22 +0000 (12:29 +0000)]
Make "4 NOP in a row" work again after changing the NOP name for TCP and IP
in revisions 34095 and 34097.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34134
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 16 Sep 2010 10:40:33 +0000 (10:40 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34133
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 16 Sep 2010 08:58:46 +0000 (08:58 +0000)]
Remove C++ comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34132
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 16 Sep 2010 08:15:45 +0000 (08:15 +0000)]
menus.c:1508: warning: unused parameter 'current'
menus.c:1508: warning: unused parameter 'user_data'
Mark parameters as unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34131
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 16 Sep 2010 07:48:18 +0000 (07:48 +0000)]
Use GUIManager for the pop-up:s.
Can be dissabled by commenting out
#define MENUS_USE_UIMANAGER 1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34130
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 15 Sep 2010 21:41:27 +0000 (21:41 +0000)]
Also rename inet_ntop() on Windows
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34129
f5534014-38df-0310-8fa8-
9805f1628bb7
sake [Wed, 15 Sep 2010 21:17:35 +0000 (21:17 +0000)]
From Juha Siltanen :
When sorting a capture by protocol, some RTP packets are shown only as FLIP,
even though the dissection windows shows the RTP tree.
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5215)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34128
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 15 Sep 2010 20:51:44 +0000 (20:51 +0000)]
Add more GUIManager code #ifdef:ed out.
The popups should be working now exept for protocol help.
Help with testing and cleaning up apreciated.
GTK 2.6 requred, I'll look into that too later if no one beats me to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34127
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 15 Sep 2010 20:29:31 +0000 (20:29 +0000)]
Bug #5127 from Guenter Strubreiter:
for avoiding doubled definition of a table needed also by a tcap subdissector
plugin a definition in libwirshark.def is needed:
isup_calling_partys_category_value
Me: Change extern to WS_VAR_IMPORT in header file
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34126
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Sep 2010 16:17:16 +0000 (16:17 +0000)]
Missed this one (check_col() removal)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34125
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Sep 2010 16:16:23 +0000 (16:16 +0000)]
Remove a few more calls to check_col()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34124
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 15 Sep 2010 15:52:30 +0000 (15:52 +0000)]
Add expert info for timing adjustment control message, and tweak a label.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34123
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 15 Sep 2010 15:13:40 +0000 (15:13 +0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 differently:
On Windows, rename inet_pton() to ws_inet_pton() so that builds on Vista or
later systems (that have inet_pton() natively) will still work on pre-Vista
systems.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34122
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 15 Sep 2010 15:13:17 +0000 (15:13 +0000)]
Revert 34081 and 34093 in preparation for a cleaner fix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34121
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 15 Sep 2010 14:10:25 +0000 (14:10 +0000)]
Follow up to bug 5209 and rev 34115:
%hh is C99 so remove it from packet-ssl-utils and add it to the banned list
(similar to %ll) in checkAPIs.pl .
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34120
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 14 Sep 2010 21:38:54 +0000 (21:38 +0000)]
Clean up the icmp info column per discussion in bug #4014.
Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE
in the proto_tree_add_item() calls for the identifier and sequence numbers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34119
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 14 Sep 2010 20:50:03 +0000 (20:50 +0000)]
Add more GUIManager code #ifdef:ed out
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34118
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 14 Sep 2010 16:03:34 +0000 (16:03 +0000)]
Remove duplicate register_all_protocol_handoffs entry
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34117
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 14 Sep 2010 15:54:12 +0000 (15:54 +0000)]
Bug #5211 from Guenter Strubreiter:
for writing a TCAP subdissector as a plugin some functions are needed in
libwireshark.def for export
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34116
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 14 Sep 2010 15:43:19 +0000 (15:43 +0000)]
From Cal Turney via bug 5209:
Decode of SETCLIENTID calls in the Windows x86 version fail with "[Dissector
bug, protocol NFS: STATUS_ACCESS_VIOLATION: dissector accessed an invalid
memory address]". This error occurs in packet-nfs.c in
dissect_nfs_clientaddr4() where vars 'protocol' and 'universal_ip_address' get
stepped on following the call to scanf(). The b1-b10 vars are declared as
quint8. While "hh" modifier used in the scanf() is documented in Linux to
correspond to an a signed/unsigned char arg, I cannot find a similar
designation in Windows (MSDN). The Windows C compiler interprets %hhu as
corresponding to a int16 rather than int8.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34115
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 14 Sep 2010 14:43:56 +0000 (14:43 +0000)]
From tieuthunhi:
Add new time source for Gigamon header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5210
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34114
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 14 Sep 2010 14:24:39 +0000 (14:24 +0000)]
From Vincent Helfre:
Incorrect decoding of List of ARFCN in BCCH frequency list.
When the range 1024 is selected, it can happen that 2 bytes need to be read for
W1, and also for W2. In the current version, when W1 ends on a byte boundary,
W2 will get an incorrect value, since it will be truncated by 1 bit.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5214
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34113
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 13 Sep 2010 20:21:41 +0000 (20:21 +0000)]
Add more GUIManager code #ifdef:ed out
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34112
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 13 Sep 2010 18:49:55 +0000 (18:49 +0000)]
Attempt to fix the stack overflow reported at
http://seclists.org/bugtraq/2010/Sep/87 .
Unfortunately no one from the NCNIPC pen test team has contacted us or
provided a sample capture so the fix hasn't been verified.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34111
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 13 Sep 2010 16:51:10 +0000 (16:51 +0000)]
From Yaniv Kaul:
[PATCH] Add SSL cipher 'Transport Layer Security (TLS) Renegotiation Indication Extension' (RFC 5746)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5207
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34110
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 12 Sep 2010 22:36:52 +0000 (22:36 +0000)]
set_menu_sensitivity() is used only if MENUS_USE_UIMANAGER is defined,
so define it only if MENUS_USE_UIMANAGER is defined.
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34109
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 12 Sep 2010 21:53:26 +0000 (21:53 +0000)]
Get rid of /* within comment, clean up white space.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34108
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 12 Sep 2010 19:29:05 +0000 (19:29 +0000)]
Remove deprecated check_col().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34107
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 12 Sep 2010 19:26:42 +0000 (19:26 +0000)]
Add more GUIManager code #ifdef:ed out
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34106
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 12 Sep 2010 15:03:34 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2010-09-12]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34102
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Sun, 12 Sep 2010 01:13:42 +0000 (01:13 +0000)]
Decode SLL payloads using a dissector table based on sll.ltype.
The idea and the original patch came from Sebastian Reichel
<elektranox@gmail.com> in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594390
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34101
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 10 Sep 2010 21:24:32 +0000 (21:24 +0000)]
Only check for 4 NOP in a row within a uint32 boundary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34100
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 10 Sep 2010 21:22:29 +0000 (21:22 +0000)]
From Martin Peylo via bug 5198:
Added missing OIDs in CRMF (RFC 4211) dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34099
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 10 Sep 2010 16:50:12 +0000 (16:50 +0000)]
Use absolute paths in link_directories.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34098
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 10 Sep 2010 16:48:00 +0000 (16:48 +0000)]
Follow TCP and expand description for "NOP" and "EOL" options to "No-Operation (NOP)"
and "End of Options List (EOL)" respectively.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34097
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 10 Sep 2010 16:33:46 +0000 (16:33 +0000)]
Put the ": %u (multiply by %u)" back on the TCP window scaling option, so
users don't have to expand the tree to see the details that were there
before rev 34094.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34096
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 10 Sep 2010 16:23:58 +0000 (16:23 +0000)]
Expand description for "NOP" and "EOL" options to "No-Operation (NOP)" and
"End of Options List (EOL)" respectively.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34095
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 10 Sep 2010 16:12:17 +0000 (16:12 +0000)]
Enhance the TCP option display for window scaling.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34094
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Fri, 10 Sep 2010 13:52:42 +0000 (13:52 +0000)]
From BBA via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 :
Followup to 34081: move libwsutil _all_ the way forward so that our inet_pton
is always linked in before wsock32's. This means that our Windows-7 Win64
builds (on which there is a native inet_pton in wsock32) will still work on
pre-Vista Win64's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34093
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 10 Sep 2010 11:16:29 +0000 (11:16 +0000)]
Update dsfield ECN according to RFC3168.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34092
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 9 Sep 2010 18:36:20 +0000 (18:36 +0000)]
Add some hf blurbs (for fields whose description is an acronym)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34091
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 9 Sep 2010 17:30:35 +0000 (17:30 +0000)]
Remove what appear to be two redundant lines of code (AFAIKT).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34090
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Thu, 9 Sep 2010 15:46:40 +0000 (15:46 +0000)]
Resolve another issue the Windows buildbots are having after rev 34084:
guint8 -> guint16 for th_flags variable in segment struct.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34089
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Sep 2010 23:10:52 +0000 (23:10 +0000)]
Turn the TCP timestamp option into a subtree to also show the option kind,
option length and values with proto_tree_add_item() intead of _add_text().
The options tree still shows the same information as before until the sub-
tree is expanded.
The goal is to do this with all TCP and IP options.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34088
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 8 Sep 2010 21:25:14 +0000 (21:25 +0000)]
Mask out the header length from th_flags.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34087
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Sep 2010 21:11:45 +0000 (21:11 +0000)]
Make the Windows buildbot happy: guint8 -> guint16 for flags variable in
definition of tcp_analyze_sequence_number().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34086
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Sep 2010 20:52:00 +0000 (20:52 +0000)]
Minor correction to SVN revision 34084: we better only try up to the 9
available values in flags[], so we don't run past the end of the array
if one of the reserved flags is set.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34085
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Sep 2010 20:43:19 +0000 (20:43 +0000)]
Expand the TCP flags to include the low nibble of the byte that has
the header length in the high nibble. The only new flag is nonce (NS);
the remaining three bits are still reserved.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34084
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Sep 2010 19:01:41 +0000 (19:01 +0000)]
From Frank Lahm via bug #5169: Provide initial support for the undocumented
AFP FPSpotlightRPC call.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34083
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Wed, 8 Sep 2010 18:47:14 +0000 (18:47 +0000)]
Follow up to rev 34073: Since "-b files:0" is no longer necessary to
override the default of turning on a multiple file ring buffer, require
a positive integer to be specified for the files value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34082
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Wed, 8 Sep 2010 16:51:12 +0000 (16:51 +0000)]
Attempt to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 :
Move libwsutil forward in the list of Wireshark libraries so that our inet_pton
is always used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34081
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 8 Sep 2010 13:38:47 +0000 (13:38 +0000)]
Revert revision 33780, because the checksum is only calculated
from the header and not the content.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34080
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 8 Sep 2010 10:29:06 +0000 (10:29 +0000)]
Support negative values when viewing seconds with hours and minutes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34079
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 8 Sep 2010 09:33:53 +0000 (09:33 +0000)]
Allow for proto_tree_add_item() with FT_ABSOLUTE_TIME and FT_RELATIVE_TIME
to have length == 4 (only seconds).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34078
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 8 Sep 2010 09:24:53 +0000 (09:24 +0000)]
From Yaniv Kaul via bug 5193:
Dissect NTLMSSP type 0x5 (DNS Forest name).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34077
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Wed, 8 Sep 2010 09:02:16 +0000 (09:02 +0000)]
Do not report undecoded message to expert info for ReturnResult without result filed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34076
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 8 Sep 2010 06:45:04 +0000 (06:45 +0000)]
Fake proto_item_prepend_text() in reassemble_test.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34075
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Sep 2010 20:40:39 +0000 (20:40 +0000)]
Put the number of fragments/segments in front of the element to avoid
conflict when they are named fragments instead of segments and to avoid
duplicating the fragments/segments text.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34074
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Tue, 7 Sep 2010 19:22:05 +0000 (19:22 +0000)]
These two capture option variables are defined by capture_opts_init(), so
don't redefine them to new values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34073
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Tue, 7 Sep 2010 14:06:43 +0000 (14:06 +0000)]
From Yaniv Kaul via bug 4550:
Show number of segments which were used in the desgementation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34072
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 7 Sep 2010 08:10:45 +0000 (08:10 +0000)]
Start adding GTKUIManager code.(#IF 0'ed out.).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34071
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 6 Sep 2010 19:59:15 +0000 (19:59 +0000)]
From yami via bug 3310:
SMB2 create context response fix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34070
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 6 Sep 2010 17:31:17 +0000 (17:31 +0000)]
From Pascal Quantin via bug 5186:
Fix the decoding of the maximum/guaranteed bit rates for uplink/downlink.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34069
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 6 Sep 2010 09:22:43 +0000 (09:22 +0000)]
Change bandwidth labels, and update stop time even on first frame.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34068
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 5 Sep 2010 15:03:42 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2010-09-05]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34064
f5534014-38df-0310-8fa8-
9805f1628bb7