obnox/wireshark/wip.git
16 years agoasn2wrs
kukosa [Mon, 29 Oct 2007 19:25:37 +0000 (19:25 +0000)]
asn2wrs
 - parameterized object class assignment
 - octet string with extensible size constraint
 - RELATIVE-OID type (still not supported in packet-per/ber)
packet-per
 - octet string with extensible size constraint
more dissect_per_... functions exported from libwireshark.dll
PER dissectors regenerated
add forgotten packet-h323-template.h
fix svn properties for h323 files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23309 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd comment for Windows build re config.nmake and .h file changes requiring distclean
wmeier [Mon, 29 Oct 2007 15:11:20 +0000 (15:11 +0000)]
Add comment for Windows build re config.nmake and .h file changes requiring distclean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23308 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd a asn2wrs generated T.125 MCP dissector
sahlberg [Mon, 29 Oct 2007 11:32:07 +0000 (11:32 +0000)]
add a asn2wrs generated T.125 MCP dissector

This dissects the initial Connect-Initial and Connect-confirm pdus of
setting up t.125

The dissector needs to be enhanced to also decode the data payload so
that it can decode any furhter packets on the connection after these two
initial handshake packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23307 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoregister tpkt for port 3389 and use x224 as the subdissector for this
sahlberg [Mon, 29 Oct 2007 07:16:49 +0000 (07:16 +0000)]
register tpkt for port 3389 and use x224 as the subdissector for this
port

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23306 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd x224 to the makefile
sahlberg [Mon, 29 Oct 2007 07:15:29 +0000 (07:15 +0000)]
add x224 to the makefile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23305 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd an initial x.224 dissector it is very incomplete
sahlberg [Mon, 29 Oct 2007 07:14:50 +0000 (07:14 +0000)]
add an initial x.224 dissector    it is very incomplete

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23304 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen there are multiple conversations with the same key, conversation_lookup_hashtabl...
sake [Mon, 29 Oct 2007 06:54:25 +0000 (06:54 +0000)]
When there are multiple conversations with the same key, conversation_lookup_hashtable() did not return the correct conversation for the first packet of a conversation (ie when frame_num == conversation->setup_frame).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23303 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude winposixtypes.h only if building with GNUTLS; Bug 1942: part 2 of 2 of fix.
wmeier [Mon, 29 Oct 2007 01:14:51 +0000 (01:14 +0000)]
Include winposixtypes.h only if building with GNUTLS; Bug 1942: part 2 of 2 of fix.
asn1 template file plus generated .[hc] files;
Note that the generated files include changes which are a result of previous
changes to snmp.cnf (SVN #23252) and of other changes (eg: svn 21145).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23302 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInclude winposixtype.h only if building with GNUTLS; Bug #1949: Part 1 of fix
wmeier [Mon, 29 Oct 2007 00:58:06 +0000 (00:58 +0000)]
Include winposixtype.h only if building with GNUTLS; Bug #1949: Part 1 of fix
[asn1 template plu generated .c file]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23301 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBug 1227 : From Frederic Heem:
sake [Sun, 28 Oct 2007 23:49:15 +0000 (23:49 +0000)]
Bug 1227 : From Frederic Heem:

* modify CMakeInstallDirs.cmake according to cmake developper wishes
* FindDBUSGLIB.cmake fixes
* Add HAVE_CHOWN
* remove DBus from CMakeLists.txt.
* DBus support has its own application (capdbus) and is in a self contained directory. A separate patch will be provided

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23300 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThis patch is a remake of SVN 22762:
sake [Sun, 28 Oct 2007 23:38:43 +0000 (23:38 +0000)]
This patch is a remake of SVN 22762:

When doing TCP_SEQ analysis, if the packet is a SYN, then it's
not a lost packet but the tcp ports are being reused. This is often
seen in load-balanced environments where client ports are preserved
on the server-side.

This time it is fixed by creating a new conversation whenever a
new SYN is received for an existing conversation. This fixes the
following:

- bug 1680: Error in TCP Sequence number analysis
- TCP-conversation timestamps for new TCP-sessions with the addresses
  and ports as a previous TCP-conversation in the trace-file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23299 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBug 1751: From Allan M. Madsen :
sake [Sun, 28 Oct 2007 18:52:45 +0000 (18:52 +0000)]
Bug 1751: From Allan M. Madsen :

When trying to open a pcap file with the new pseudo-header/DLT (using SVN
version, changelist 23283) I get the error message:
"libpcap: ERF file has a 13-byte packet, too small to have even an ERF
pseudo-header".

After reviewing Paolo's patch I found that there are 2 places with missing
breaks in switch case structures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23298 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSmall fixes:
wmeier [Sun, 28 Oct 2007 18:12:52 +0000 (18:12 +0000)]
Small fixes:
1. wireshark.bat: Quote %U3_HOST_EXEC_PATH%\wireshark.exe so pathname
   with spaces will work;
2. makefile.nmake: Use $(MAKE) /$(MAKEFLAGS) so things like
   invoking nmake at the top level with /E to have environment
   variables override config.namke definitions will work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23297 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix Windows build error if not using LUA; Bug #1950
wmeier [Sun, 28 Oct 2007 13:46:20 +0000 (13:46 +0000)]
Fix Windows build error if not using LUA; Bug #1950

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23296 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoU3 package update to:
gal [Sun, 28 Oct 2007 11:58:16 +0000 (11:58 +0000)]
U3 package update to:
a) include smi.dll if SMI_DIR is set
b) add a batch script to run the U3 wireshark configuration by simulating the U3 environment
c) include a test step in the build process to verify that the U3 package contains all the required files (tries to run "wireshark -D")
d) include the wireshark.bat in the U3 zip file.

This final step means that the U3 package can be unzipped on any drive and run using the wireshark.bat script. (Note this currently creates an unwanted cmd window.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23295 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofrom Gisele Vanem:
jake [Sun, 28 Oct 2007 11:25:34 +0000 (11:25 +0000)]
from Gisele Vanem:
This needs file_util.h if HAVE_LIBNETTLE is defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23294 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Stefan Puiu:
etxrab [Sat, 27 Oct 2007 16:49:13 +0000 (16:49 +0000)]
From Stefan Puiu:
According to http://www.iana.org/assignments/bootp-dhcp-parameters, suboptions
from 1 to 10 have been defined. 3 is reserved, and most of the others have
their own RFC. For a start I've attached a patch that decodes suboption 6 just
as 1 and 2, and also suboption 3. This might not be entirely correct, since
suboptions 1 and 2 are opaque values (RFC3046), while 6 is an ASCII text
string.

I added something for the other values as well...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23293 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Stephane Chazelas:
etxrab [Sat, 27 Oct 2007 15:53:29 +0000 (15:53 +0000)]
From Stephane Chazelas:
The description of the most significant bit of the "Device Revision" byte of
the response to a "Get Device ID" is the wrong way round. 1 means "device
provides Device SDRs" and not the contrary according to IPMI specs 1.5 and 2.0.

Also, I noticed in that file that "Chassis" is spelled "Chasis".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23292 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Peylo:
etxrab [Sat, 27 Oct 2007 15:48:47 +0000 (15:48 +0000)]
From Martin Peylo:
Enhancement:
- TIPC is available in a new version (1.7), adding/removing fields while
keeping the same version number (2).

Minor bugs:
- In NAME_DISTRIBUTOR messages the origianting and destination node are
switched.
- The used size of BUNDLER messages payload is not calculated correctly when
size%4=0, this leads to the wrong assumption that the message would be
malformed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23291 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Mark C. Brown:
etxrab [Sat, 27 Oct 2007 15:44:12 +0000 (15:44 +0000)]
From Mark C. Brown:
Add support for the new NS_LS_SCTP tracing subsystem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23290 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Steve Osselton:
etxrab [Sat, 27 Oct 2007 15:38:22 +0000 (15:38 +0000)]
From Steve Osselton:
The GIOP Fragment message type was added as of GIOP 1.1. However the Fragment
message header (containing a request id) was only added as of GIOP 1.2. The
GIOP Fragment dissector incorrectly attempts to process the request id for a
version 1.1 request.

To fix add a version check to the dissect_giop_fragment function in
packet-giop.c:

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23289 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Stefano Picerno:
etxrab [Sat, 27 Oct 2007 15:28:35 +0000 (15:28 +0000)]
From Stefano Picerno:
I made some updates to the edonkey dissector.
Most kademlia1 and some kademlia2 messages are now completely decoded.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23288 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Andrew Feren:
etxrab [Sat, 27 Oct 2007 15:02:07 +0000 (15:02 +0000)]
From Andrew Feren:
return FALSE if dissector_try_string(...) is passed a NULL string pointer
arguably this should assert instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23287 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Andrew Feren:
etxrab [Sat, 27 Oct 2007 14:57:46 +0000 (14:57 +0000)]
From Andrew Feren:
patch to test for NULL media_type_str_lower_case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23286 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 27 Oct 2007 14:44:29 +0000 (14:44 +0000)]
Apply yet another set of the optimization patches:
- Use a fast path for the most common use of tvb_get_xxx functions:
offset is >= 0 and tvb->real_data is set (this one is always true).
- match_strval() is a linear search, put the most common protocols
TCP/UDP/RDP first.
- fix gtk1 g_strlcat declaration Use g_strlcat

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23285 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix for bug 1935.
jake [Sat, 27 Oct 2007 09:24:31 +0000 (09:24 +0000)]
Fix for bug 1935.
RFC3315 says that the vendor-specific information option must encapsulate each
option in the format code/length/value.  The current dhcpv6 dissector does not
differentiate these fields, it just puts it all together as one option-data
field. Attached is a patch that addresses this issue.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23284 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove empty #if / #endif block
sfisher [Sat, 27 Oct 2007 05:11:50 +0000 (05:11 +0000)]
Remove empty #if / #endif block

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23283 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMinor indentation changes
morriss [Fri, 26 Oct 2007 22:17:45 +0000 (22:17 +0000)]
Minor indentation changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23282 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoStop including xmlstab.h
martinm [Fri, 26 Oct 2007 16:57:54 +0000 (16:57 +0000)]
Stop including xmlstab.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23281 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove some unnecessary includes.
martinm [Fri, 26 Oct 2007 16:53:08 +0000 (16:53 +0000)]
Remove some unnecessary includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23280 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFor the Wireshark/TShark -> dumpcap signal pipe on Windows, use a named
gerald [Fri, 26 Oct 2007 16:32:28 +0000 (16:32 +0000)]
For the Wireshark/TShark -> dumpcap signal pipe on Windows, use a named
pipe instead of stdin.  Add an argument (currently the parent PID) back
to the "-Z" flag and use it to construct the pipe name.  This lets us
pass the parent's stdin handle to dumpcap, which lets us capture from
stdin on Windows.  Add a comment about checking for the parent process.

In capture_loop.c, remove the wait_forever argument from cap_pipe_select()
since it was always FALSE.  Set the timeout under Windows to 250 ms
instead of 250000 ms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23279 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoShow the acronyms for LSSU types in the Info column rather than the long description...
morriss [Fri, 26 Oct 2007 16:19:18 +0000 (16:19 +0000)]
Show the acronyms for LSSU types in the Info column rather than the long description (and don't tell the user it's an LSSU, they already know that).  Also, there is no such thing as a SIBO, it's a SIB.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23278 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Andrew Feren: Fix an assortment of typos and other minor errors
wmeier [Fri, 26 Oct 2007 15:26:04 +0000 (15:26 +0000)]
From Andrew Feren: Fix an assortment of typos and other minor errors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23277 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd expert item for cases of unmatched function type or message op.
martinm [Fri, 26 Oct 2007 10:38:16 +0000 (10:38 +0000)]
Add expert item for cases of unmatched function type or message op.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23276 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoH.501 Mobility protocol implemented
kukosa [Fri, 26 Oct 2007 07:42:29 +0000 (07:42 +0000)]
H.501 Mobility protocol implemented

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23275 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix wrong headers in H.460.x ASN.1 sources
kukosa [Fri, 26 Oct 2007 07:18:44 +0000 (07:18 +0000)]
fix wrong headers in H.460.x ASN.1 sources

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23274 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Fri, 26 Oct 2007 05:42:12 +0000 (05:42 +0000)]
Apply yet another set of the optimization patches:
Replace strncpy with g_strlcpy.
Add g_strlcat for GTK1 and don't use g_snprintf in GTK1 g_strlcpy
printf family is very slow.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23273 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a typo.
gerald [Thu, 25 Oct 2007 20:37:12 +0000 (20:37 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23272 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodo not update call_state if new call_state == VOIP_NO_STATE
kukosa [Thu, 25 Oct 2007 12:24:01 +0000 (12:24 +0000)]
do not update call_state if new call_state == VOIP_NO_STATE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23271 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew codec table for registering codecs by name
kukosa [Thu, 25 Oct 2007 09:38:15 +0000 (09:38 +0000)]
new codec table for registering codecs by name
new codec plugin type
search registered codecs in rtp player
fix memory leak in rtp player

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23270 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove unused variable.
etxrab [Wed, 24 Oct 2007 21:52:44 +0000 (21:52 +0000)]
Remove unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23269 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse the media_type_dissector_table for the content type.
etxrab [Wed, 24 Oct 2007 21:47:13 +0000 (21:47 +0000)]
Use the media_type_dissector_table for the content type.
Add a few media types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23268 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd an item for the recent packet-gdsdb.c fixes.
gerald [Wed, 24 Oct 2007 16:43:45 +0000 (16:43 +0000)]
Add an item for the recent packet-gdsdb.c fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23267 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove a couple of unused variables.
gerald [Wed, 24 Oct 2007 16:32:51 +0000 (16:32 +0000)]
Remove a couple of unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23266 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd port ranges.
etxrab [Wed, 24 Oct 2007 15:04:01 +0000 (15:04 +0000)]
Add port ranges.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23265 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd missing case.
martinm [Wed, 24 Oct 2007 09:21:13 +0000 (09:21 +0000)]
Add missing case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23264 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix voip_calls.c:126: warning: missing initializer
kukosa [Wed, 24 Oct 2007 09:10:43 +0000 (09:10 +0000)]
fix voip_calls.c:126: warning: missing initializer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23263 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd common VoIP TAP listener "voip" which can be used in arbitrary experimental/propr...
kukosa [Wed, 24 Oct 2007 08:30:46 +0000 (08:30 +0000)]
add common VoIP TAP listener "voip" which can be used in arbitrary experimental/proprietary protocol (implemented e.g. in plugin) and allows it to make graphs and replay streams

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23262 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSquelch warnings about uninitialized structure members.
guy [Wed, 24 Oct 2007 07:14:34 +0000 (07:14 +0000)]
Squelch warnings about uninitialized structure members.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23261 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSet svn:eol-style to native and svn:keywords to Id.
guy [Wed, 24 Oct 2007 06:56:07 +0000 (06:56 +0000)]
Set svn:eol-style to native and svn:keywords to Id.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23260 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of CRs, and set svn:eol-style to native.
guy [Wed, 24 Oct 2007 06:54:58 +0000 (06:54 +0000)]
Get rid of CRs, and set svn:eol-style to native.

Set svn:keywords to Id while we're at it.

Get rid of extra blank lines at the ends of files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23259 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"time_t" might be an "int" or might be a "long"; cast it to "long" and
guy [Wed, 24 Oct 2007 06:21:05 +0000 (06:21 +0000)]
"time_t" might be an "int" or might be a "long"; cast it to "long" and
print it with "%ld".  (It's typically signed.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23258 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"sa_mask" in a "struct sigaction" is a sigset_t, which is not
guy [Wed, 24 Oct 2007 04:13:30 +0000 (04:13 +0000)]
"sa_mask" in a "struct sigaction" is a sigset_t, which is not
necessarily an integral data type.  Use sigemptyset() to clear it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23257 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse sigaction(), not signal(), so we know what its semantics are (and so
guy [Wed, 24 Oct 2007 03:33:35 +0000 (03:33 +0000)]
Use sigaction(), not signal(), so we know what its semantics are (and so
that we can find out what the signal action for SIGHUP is without
changing it).

That renders report_counts() safe to use at the end of a capture; do so.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23256 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agopacket-diameter.c should now compile without warnings. Mark it as a
guy [Wed, 24 Oct 2007 02:28:03 +0000 (02:28 +0000)]
packet-diameter.c should now compile without warnings.  Mark it as a
clean dissector (so that the buildbots compile it with -Werror, in the
hopes of keeping it clean).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23255 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake sure characters aren't sign-extended before being handed to
guy [Wed, 24 Oct 2007 02:12:46 +0000 (02:12 +0000)]
Make sure characters aren't sign-extended before being handed to
isalnum().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23254 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake groups of PDUs filterable as large FT_BYTES items
martinm [Tue, 23 Oct 2007 11:02:08 +0000 (11:02 +0000)]
Make groups of PDUs filterable as large FT_BYTES items
(where the initial length isn't readily available when item is first added)

Note that this still won't work where an initial length of 0 is given for
the item that will later be extended using proto_item_set_len(), as the
pointer value part of the zero-length array will reamin NULL...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23253 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply the small performance enhancment patches for:
etxrab [Tue, 23 Oct 2007 05:50:00 +0000 (05:50 +0000)]
Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace
- col_append_fstr() with faster  col_append_str()
- col_add_str() with col_set_str()
when it's safe

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix for bug 1931 and bug 1932:
jake [Tue, 23 Oct 2007 05:37:42 +0000 (05:37 +0000)]
Fix for bug 1931 and bug 1932:
A never ending while loop and a value to string mapping error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23251 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix export of ObjectFieldSpec and ObjectSetFieldSpec of CLASS
kukosa [Mon, 22 Oct 2007 19:29:29 +0000 (19:29 +0000)]
fix export of ObjectFieldSpec and ObjectSetFieldSpec of CLASS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23250 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:21:11 +0000 (17:21 +0000)]
Update to use the -X and -T asn2wrs flags.
Straightforward.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23249 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:20:04 +0000 (17:20 +0000)]
Update to use the -X and -T asn2wrs flags.
Straightforward.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23248 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:18:42 +0000 (17:18 +0000)]
Update to use the -X and -T asn2wrs flags.
Straightforward.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23247 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:17:15 +0000 (17:17 +0000)]
Update to use the -X and -T asn2wrs flags.
Straightforward.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23246 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:16:15 +0000 (17:16 +0000)]
Update to use the -X and -T asn2wrs flags.
Straightfoward.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23245 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:14:42 +0000 (17:14 +0000)]
Update to use the -X and -T asn2wrs flags.
Straightforward.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23244 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T asn2wrs flags.
gal [Mon, 22 Oct 2007 17:13:08 +0000 (17:13 +0000)]
Update to use the -X and -T asn2wrs flags.
Removed the workaround code from the .cnf file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23243 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T flags.
gal [Mon, 22 Oct 2007 17:08:03 +0000 (17:08 +0000)]
Update to use the -X and -T flags.
Removed some workaround code in the .cnf file.
There is still some code for handling an EXTERNAL (EXTERNALt) as the RTSE dissector has its own set of callbacks and consequently can't (currently) use the packet-ber.c functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23242 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to use the -X and -T flags to asn2wrs.
gal [Mon, 22 Oct 2007 17:03:09 +0000 (17:03 +0000)]
Update to use the -X and -T flags to asn2wrs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23241 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jim Young: Simple one line patch resolves compiler warning.: Bug #1929
wmeier [Mon, 22 Oct 2007 15:13:41 +0000 (15:13 +0000)]
From Jim Young: Simple one line patch resolves compiler warning.: Bug #1929

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23240 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoShow multi-byte variable length fields using FT_BYTES|BASE_HEX.
martinm [Mon, 22 Oct 2007 13:31:51 +0000 (13:31 +0000)]
Show multi-byte variable length fields using FT_BYTES|BASE_HEX.

Note that there is still a problem with 'Apply as filter' filters.  They seem to remember the initial length of the item, and not the final length set using proto_item_set_len() (this is the case for groups of TBs/PDUs).  Will investigate when time allows...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23239 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd flags for optional fields of EXTERNAL type into asn1_ctx_t struct
kukosa [Mon, 22 Oct 2007 12:25:56 +0000 (12:25 +0000)]
add flags for optional fields of EXTERNAL type into asn1_ctx_t struct

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23238 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove the no-longer-used packet-diameter-defs.h
martinm [Mon, 22 Oct 2007 12:16:53 +0000 (12:16 +0000)]
Remove the no-longer-used packet-diameter-defs.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23237 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake some capitalisation more consistent.
martinm [Mon, 22 Oct 2007 10:47:23 +0000 (10:47 +0000)]
Make some capitalisation more consistent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23236 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAllow wimaxasncp plugin to be found in Windows dev build.
martinm [Mon, 22 Oct 2007 10:03:22 +0000 (10:03 +0000)]
Allow wimaxasncp plugin to be found in Windows dev build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23235 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIn relinquish_special_privs_perm(), only relinquish special privileges
guy [Sat, 20 Oct 2007 03:45:47 +0000 (03:45 +0000)]
In relinquish_special_privs_perm(), only relinquish special privileges
if we were given them; doing so when we weren't seems to change the
apparent group set in OS X 10.5 (and possibly 10.4 - the group set
manipulated by getgroups()/setgroups() isn't the full group set, and
changing your UID might cause the credential identity resolver daemon
not to give you your full group set).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23234 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSilently ignore bogus geometry subkeys, just as we silently ignore other
guy [Sat, 20 Oct 2007 02:34:41 +0000 (02:34 +0000)]
Silently ignore bogus geometry subkeys, just as we silently ignore other
bogus entries in the recent file.  This fixes bug 1925.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23233 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug #1926: buffer overflow when parsing iseries files
sfisher [Fri, 19 Oct 2007 22:40:42 +0000 (22:40 +0000)]
Fix bug #1926: buffer overflow when parsing iseries files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23232 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMinor update to reflect recent plugins/Makefile.nmake change to clean/distclean/maint...
wmeier [Fri, 19 Oct 2007 15:21:42 +0000 (15:21 +0000)]
Minor update to reflect recent plugins/Makefile.nmake change to clean/distclean/maintainer-clean

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23231 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Andrew Feren:
sake [Fri, 19 Oct 2007 09:50:29 +0000 (09:50 +0000)]
From Andrew Feren:

sFlow datagrams can contain sampled headers from conversations on the network.

Often it is convenient to have wireshark dissect these payload headers, but
doing so can also have undesirable side effects.  Dissected payload headers may
match filters looking for header fields that also happen to occur in the
payload.  This can cause surprising results.

Also TCP analysis will almost always flag errors on sampled headers.  They are,
after all, just a sample and many sequence numbers are sure to be missing.

There is probably a more general way to resolve these issues, but adding
preferences to enable/disable tcp analysis and dissection of sampled headers
will be a good start.  This will make it possible to examine the details of
sampled headers if desired or to disable dissection if the side effects of
dissecting sampled headers cause issues.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23230 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse gtk 2.12.1
etxrab [Thu, 18 Oct 2007 21:29:19 +0000 (21:29 +0000)]
Use gtk 2.12.1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23229 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOops: Backout the library updates until libraries configured for download... (??)
wmeier [Thu, 18 Oct 2007 19:47:45 +0000 (19:47 +0000)]
Oops: Backout the library updates until libraries configured for download... (??)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23228 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdated GTK/Glib/Pango Libraries
wmeier [Thu, 18 Oct 2007 19:30:56 +0000 (19:30 +0000)]
Updated GTK/Glib/Pango Libraries

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23227 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoH.460 new dissector implemented (H.460.2-H.460.22)
kukosa [Thu, 18 Oct 2007 13:35:57 +0000 (13:35 +0000)]
H.460 new dissector implemented (H.460.2-H.460.22)
H.225
 - change RysMessage_vals to h225_Rasmessage_vals
 - use #.PDU directive for H323-UserInformation and RasMessage instead of implementing it by hands
 - register RasMessage_PDU as "h225.ras" dissector for calling it from H.460
asn2wrs make PDUs exportable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23226 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded svn:ignore targets for asn1/h323
stig [Thu, 18 Oct 2007 12:41:11 +0000 (12:41 +0000)]
Added svn:ignore targets for asn1/h323

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23225 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdated svn:ignore props for win32 build
grahamb [Thu, 18 Oct 2007 12:08:50 +0000 (12:08 +0000)]
Updated svn:ignore props for win32 build

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23224 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFixed sort order, used case-insensitive ascending
grahamb [Thu, 18 Oct 2007 11:42:59 +0000 (11:42 +0000)]
Fixed sort order, used case-insensitive ascending

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23223 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd eth_stdio_open to libwireshark.def
stig [Thu, 18 Oct 2007 11:29:32 +0000 (11:29 +0000)]
Add eth_stdio_open to libwireshark.def

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23222 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agos/fopen()/eth_fopen()/ in plugins/ (for bug 1827).
morriss [Wed, 17 Oct 2007 21:25:16 +0000 (21:25 +0000)]
s/fopen()/eth_fopen()/ in plugins/ (for bug 1827).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23221 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoLogic error
jake [Wed, 17 Oct 2007 18:25:49 +0000 (18:25 +0000)]
Logic error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23220 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMask error
jake [Wed, 17 Oct 2007 18:25:29 +0000 (18:25 +0000)]
Mask error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23219 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFlag error
jake [Wed, 17 Oct 2007 18:25:01 +0000 (18:25 +0000)]
Flag error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23218 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd forgotten packet-h323.h
kukosa [Wed, 17 Oct 2007 11:06:14 +0000 (11:06 +0000)]
add forgotten packet-h323.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23217 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew H.323 dissector
kukosa [Wed, 17 Oct 2007 10:25:21 +0000 (10:25 +0000)]
new H.323 dissector
  - Generic Extensible Framework helper
  - Annex M1 (QSIG over H.323)
  - Annex M4
  - Annex R
H.225/H.245 support for Generic Extensible Framework (GEF)
H.235 register MIKEY into new H.225/H.245 GEF tables
regenerate H.225,H.245,H.235,H.450,H.450-ROS,T.35 from new makefiles

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23216 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- register QSIG over SIP
kukosa [Wed, 17 Oct 2007 09:55:08 +0000 (09:55 +0000)]
- register QSIG over SIP
- regenerate Q932, Q932-ROS, QSIG from new makefiles

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23215 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomake dissect_per_length_determinant() private
kukosa [Wed, 17 Oct 2007 09:51:27 +0000 (09:51 +0000)]
make dissect_per_length_determinant() private

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23214 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix for bug 1542:
sake [Wed, 17 Oct 2007 07:14:56 +0000 (07:14 +0000)]
Fix for bug 1542:

When a SYN/ACK is missing in the capture, the base_seq used in
relative sequence numbers was not set correctly. I made the
setting of fwd->base_seq and rev->base_seq a little more solid.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23213 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoProperly decode "South Africa"
jake [Wed, 17 Oct 2007 06:24:43 +0000 (06:24 +0000)]
Properly decode "South Africa"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23212 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom tmiller@hcjbtech.org : Spelling error on GDS DB protocol dissector: "Buffer...
sake [Tue, 16 Oct 2007 23:42:33 +0000 (23:42 +0000)]
From tmiller@hcjbtech.org : Spelling error on GDS DB protocol dissector: "Buffer lenght:"

(recursively grepped through the source and corrected all occurences, even
the ones just in comments)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23211 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBug 1704 is fixed in the main branch by the simpler expedient of not
guy [Tue, 16 Oct 2007 19:01:58 +0000 (19:01 +0000)]
Bug 1704 is fixed in the main branch by the simpler expedient of not
using modf() and thus not requiring libm.  In addition, adding -lm to
the dependencies upsets the build on at least some platforms because
"-lm" isn't a pathname.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23210 f5534014-38df-0310-8fa8-9805f1628bb7