obnox/wireshark/wip.git
16 years agoAdd a plugin interface to wiretap.
lego [Fri, 4 May 2007 21:10:55 +0000 (21:10 +0000)]
Add a plugin interface to wiretap.
So far I've done only regression testing (the new functionality and what's in wtap-plugins.c has not yet being tested).

it is a first step in the way to have lua opening files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21686 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoShow BER internal fields in external type in ACSE, update a comment in packet-ber.c.
etxrab [Fri, 4 May 2007 20:27:43 +0000 (20:27 +0000)]
Show BER internal fields in external type in ACSE, update a comment in packet-ber.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21685 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOnce is enough. :-)
guy [Fri, 4 May 2007 18:56:59 +0000 (18:56 +0000)]
Once is enough. :-)

That should get rid of warnings in packet-ber.c; add it to the list of
clean dissectors, to try to keep it clean.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21684 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- Q.932: fix warnings
kukosa [Fri, 4 May 2007 13:33:35 +0000 (13:33 +0000)]
- Q.932: fix warnings
- RNSAP: generate field functions only for necessary types
- other dissectors regenerated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21683 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- new #.OPT directive which allows to use command line options from conformance file...
kukosa [Fri, 4 May 2007 13:11:34 +0000 (13:11 +0000)]
- new #.OPT directive which allows to use command line options from conformance file (and more options in the future)
- option -F|CREATE_FIELDS used from conformance file can have type parameter, field functions are created only for its members

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21682 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSpare the filter compilation and filter list handling on clear display filter.
jake [Fri, 4 May 2007 11:28:01 +0000 (11:28 +0000)]
Spare the filter compilation and filter list handling on clear display filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21681 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Steven Schaeffer:
jake [Fri, 4 May 2007 11:21:03 +0000 (11:21 +0000)]
From Steven Schaeffer:
Fix for bug 310. Use the frame number to store history i.s.o. row number.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21680 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomissing packet-t30.h file
kukosa [Fri, 4 May 2007 09:48:06 +0000 (09:48 +0000)]
missing packet-t30.h file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21679 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomissing asn1.c file
kukosa [Fri, 4 May 2007 08:24:06 +0000 (08:24 +0000)]
missing asn1.c file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21678 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix few warnings in Q.932 and QSIG dissectors
kukosa [Fri, 4 May 2007 07:51:19 +0000 (07:51 +0000)]
fix few warnings in Q.932 and QSIG dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21677 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agogenerate T.38 dissector from ASN.1 source
kukosa [Fri, 4 May 2007 07:10:15 +0000 (07:10 +0000)]
generate T.38 dissector from ASN.1 source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21676 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- fix creating PDU_NEW functions, return the right value
kukosa [Fri, 4 May 2007 06:55:48 +0000 (06:55 +0000)]
- fix creating PDU_NEW functions, return the right value
- allow FN_PARS to be spreaded over more lines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21675 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a copy paste error.
etxrab [Fri, 4 May 2007 06:41:55 +0000 (06:41 +0000)]
Fix a copy paste error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21674 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agorevert changes done by mistake - keep original ASN.1 source
kukosa [Fri, 4 May 2007 06:08:17 +0000 (06:08 +0000)]
revert changes done by mistake - keep original ASN.1 source

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21673 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Olivier Montanuy:
etxrab [Fri, 4 May 2007 06:07:30 +0000 (06:07 +0000)]
From Olivier Montanuy:

Patch tested against traces obtained from Cisco IOS 12.4 Flexible Netflow,
IOS-XR 3.3, Huawei VRP 5.30.

Features:
- Decodes Netflow v9 option templates
- Decodes quite a few additional Netflow v9 types
- Packets and octets counters can be 64-bit
- Show unknown Netflow v9 fields as hexa, useful when using tshark -V with
  Netflow v9 implementations that use undocumented proprietary types.
  Enabled by:  "#define SHOW_UNKNOWN_TYPES 1"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21672 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNote: make test for the following update generates 1 error:
jmayer [Thu, 3 May 2007 21:56:22 +0000 (21:56 +0000)]
Note: make test for the following update generates 1 error:
---------
tests/header..............NOK 14#   Failed test 'struct declaration'
#   in tests/header.pl at line 49.
#                   '/* header auto-generated by pidl */
#
# #include <core.h>
# #include <stdint.h>
#
# #ifndef _HEADER_p
# #define _HEADER_p
#
# struct x#endif /* _HEADER_p */
# '
#     doesn't match '(?ms-xi:struct x;)'
# Looks like you failed 1 test of 15.
tests/header..............dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 14
---------

Update from samba tree revision 22314 to 22657
============================ Samba log start ============
------------------------------------------------------------------------
r22357 | jelmer | 2007-04-19 03:26:15 +0200 (Thu, 19 Apr 2007) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/TDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/tests/wireshark-ndr.pl

Don't use 'our'

------------------------------------------------------------------------
r22453 | jelmer | 2007-04-22 12:42:33 +0200 (Sun, 22 Apr 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/TDR.pm
   M /branches/SAMBA_4_0/source/pidl/tests/tdr.pl

Fix TDR testsuite without using our.
------------------------------------------------------------------------
r22456 | jelmer | 2007-04-22 15:57:07 +0200 (Sun, 22 Apr 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/pidl
   M /branches/SAMBA_4_0/source/pidl/tests/samba-ejs.pl
   M /branches/SAMBA_4_0/source/pidl/tests/wireshark-ndr.pl

Merge wireshark and ejs test improvements.
------------------------------------------------------------------------
r22457 | jelmer | 2007-04-22 16:19:22 +0200 (Sun, 22 Apr 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
   M /branches/SAMBA_4_0/source/pidl/pidl
   M /branches/SAMBA_4_0/source/pidl/tests/samba3-cli.pl

Fix tests for Samba3 client generator.
------------------------------------------------------------------------
r22462 | jelmer | 2007-04-22 17:59:34 +0200 (Sun, 22 Apr 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/pidl
   M /branches/SAMBA_4_0/source/pidl/tests/Util.pm
   M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl

Fix test suite for ndr parser without using 'our'
------------------------------------------------------------------------
r22520 | jelmer | 2007-04-25 18:10:54 +0200 (Wed, 25 Apr 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/Conformance.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/tests/wireshark-conf.pl

Fix the TYPE command.
------------------------------------------------------------------------
r22617 | metze | 2007-05-01 03:57:17 +0200 (Tue, 01 May 2007) | 4 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

assume we have defered elements if the type is just provides via
'declare' this should fix the problem with the winbind IRPC calls

metze
------------------------------------------------------------------------
r22618 | metze | 2007-05-01 04:00:57 +0200 (Tue, 01 May 2007) | 8 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm

handle the properties related to the type
and not to 'declare' to avoid a pidl warning with:

declare [switch_type(uint16)] union netr_Validation;

void foo([in] uint16 level, [in,switch_is(level)] netrValidation info);

metze
------------------------------------------------------------------------
r22640 | metze | 2007-05-02 20:00:02 +0200 (Wed, 02 May 2007) | 4 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm

- generate nicer output
- fix compiler warning about unused ';'

metze
------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21671 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSplit out asn1 common functions. Start of BER EXTERNAL.
etxrab [Thu, 3 May 2007 21:52:57 +0000 (21:52 +0000)]
Split out asn1 common functions. Start of BER EXTERNAL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21670 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agouse the latest version of PIDL to regenerate winreg using the new TYPE
sahlberg [Thu, 3 May 2007 19:58:04 +0000 (19:58 +0000)]
use the latest version of PIDL to regenerate winreg using the new TYPE
conformance file directive to replace winreg_String with our own code.

PARAM_VALUE does not yet work for this however which needs to looked
into

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21669 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoShow internal ber fields for tagged type if pref. set.
etxrab [Thu, 3 May 2007 19:56:13 +0000 (19:56 +0000)]
Show internal ber fields for tagged type if pref. set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21668 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDissect returnedFunction.
etxrab [Thu, 3 May 2007 19:55:22 +0000 (19:55 +0000)]
Dissect returnedFunction.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21667 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agowill this finally get rid of the warnigs?
lego [Thu, 3 May 2007 18:32:52 +0000 (18:32 +0000)]
will this finally get rid of the warnigs?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21666 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCheck for an infinite loop while processing cipher suites. Fixes bug 1582.
gerald [Thu, 3 May 2007 16:59:13 +0000 (16:59 +0000)]
Check for an infinite loop while processing cipher suites.  Fixes bug 1582.

Add release notes for the SSL and display filter macro bugs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21665 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHandle cases where our macro doesn't have any arguments. We should
gerald [Thu, 3 May 2007 16:11:18 +0000 (16:11 +0000)]
Handle cases where our macro doesn't have any arguments.  We should
probably provide feedback to the user, but at least we don't crash now.
Fixes Coverity CID 232.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21664 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- REAL type and values are supported
kukosa [Thu, 3 May 2007 11:42:33 +0000 (11:42 +0000)]
- REAL type and values are supported
- if a value of some INTEGER type is defined then it is assigned to this type like a named value
i.e.
MyType ::= INTEGER
mv01 MyType ::= 1
is equal to
MyType ::= INTEGER { mv01 (1) }

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21663 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoEXTERNAL type is handled in asn2wrs now
kukosa [Thu, 3 May 2007 11:37:47 +0000 (11:37 +0000)]
EXTERNAL type is handled in asn2wrs now
private implementations were renamed EXTERNAL -> EXTERNALt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21662 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocomment out parameters of parametrized type
kukosa [Thu, 3 May 2007 10:49:49 +0000 (10:49 +0000)]
comment out parameters of parametrized type

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21661 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agouppercase identifiers are not allowed
kukosa [Thu, 3 May 2007 09:59:09 +0000 (09:59 +0000)]
uppercase identifiers are not allowed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21660 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agouppercase identifiers are not allowed
kukosa [Thu, 3 May 2007 09:51:49 +0000 (09:51 +0000)]
uppercase identifiers are not allowed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21659 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoREAL type support
kukosa [Thu, 3 May 2007 09:15:04 +0000 (09:15 +0000)]
REAL type support

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21658 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a couple of typos and fixup whitespace.
gerald [Thu, 3 May 2007 00:21:22 +0000 (00:21 +0000)]
Fix a couple of typos and fixup whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21657 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe forgotten file strikes back.
lego [Wed, 2 May 2007 23:54:01 +0000 (23:54 +0000)]
The forgotten file strikes back.
... It also fixes a lua compile warning/error in wslua_gui.c. ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21656 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Tamas Regos (Via Balint Reczey)
lego [Wed, 2 May 2007 23:39:44 +0000 (23:39 +0000)]
From Tamas Regos (Via Balint Reczey)

The attached patch adds ability of of creating radio button, drop-down
list and range type preference entries to the Lua plugin.
It also fixes a lua compile warning/error in wslua_gui.c.
The patch is written by Tamas Regos, he asked me to send it to the list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21655 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a routine to dissect the MCS Set. Add a tree for the MCS Set
gerald [Wed, 2 May 2007 23:26:33 +0000 (23:26 +0000)]
Add a routine to dissect the MCS Set.  Add a tree for the MCS Set
Rx Bitmask.  "Steams" -> "Scheme".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21654 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix warnings
lego [Wed, 2 May 2007 21:58:52 +0000 (21:58 +0000)]
fix warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21653 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix warnings in debug code
lego [Wed, 2 May 2007 20:37:25 +0000 (20:37 +0000)]
fix warnings in debug code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21652 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadd support for the text export format of textronix k1[25]
lego [Wed, 2 May 2007 20:09:42 +0000 (20:09 +0000)]
add support for the text export format of textronix k1[25]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21651 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCheck for read failures, and report them (and don't parse the key list
guy [Wed, 2 May 2007 19:46:05 +0000 (19:46 +0000)]
Check for read failures, and report them (and don't parse the key list
if we get one).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21650 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImmediately quit routines if fwrite() fails - further writes will
guy [Wed, 2 May 2007 19:28:24 +0000 (19:28 +0000)]
Immediately quit routines if fwrite() fails - further writes will
probably fail (as you're probably out of disk space or over quota), and,
even if they don't, the file's going to be corrupt in any case.

(Hopefully that's sufficient to avoid warnings that we're ignoring the
result of fwrite().)

For fread(), check for errors or short reads, at least in all cases
where we have a provision for failing if the read fails.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21649 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix the windows build by changing uint32_t into guint32.
jake [Wed, 2 May 2007 18:42:53 +0000 (18:42 +0000)]
Fix the windows build by changing uint32_t into guint32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21648 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Matt Addison:
jake [Wed, 2 May 2007 18:42:02 +0000 (18:42 +0000)]
From Matt Addison:
Problem:
The existing sll dissector does not handle ppp_hdlc packets (sll.ltype == 0x0007).
Resolution:
Alter packet-sll.c to call the ppp_hdlc dissector when a packet with sll.ltype=0x0007 is received.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21647 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdates to the ctdb dissector to follow the latest protocol
sahlberg [Wed, 2 May 2007 13:32:07 +0000 (13:32 +0000)]
updates to the ctdb dissector to follow the latest protocol

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21646 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix forgotten calling of dissect_per_External()
kukosa [Wed, 2 May 2007 12:48:22 +0000 (12:48 +0000)]
fix forgotten calling of dissect_per_External()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21645 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agocomment out a unused function so that wireshark builds on suse again
sahlberg [Wed, 2 May 2007 12:34:28 +0000 (12:34 +0000)]
comment out a unused function so that wireshark builds on suse again

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21644 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix some compiler warnings leading to compile failure
sahlberg [Wed, 2 May 2007 12:26:26 +0000 (12:26 +0000)]
fix some compiler warnings leading to compile failure

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21643 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- better reporting of syntax errors (or unsupported syntax) in ASN.1 source
kukosa [Wed, 2 May 2007 12:18:27 +0000 (12:18 +0000)]
- better reporting of syntax errors (or unsupported syntax) in ASN.1 source
- support of EXTERNAL type
- support of ObjectDescriptor for PER
- new #.CLASS directive for supporting some class workarounds

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21642 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agosome more : try to make read/write not break the build if the return value is not...
sahlberg [Wed, 2 May 2007 12:17:01 +0000 (12:17 +0000)]
some more : try to make read/write not break the build if the return value is not used

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21641 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPER - support of EXTERNAL and ObjectDescriptor types (not tested)
kukosa [Wed, 2 May 2007 12:13:29 +0000 (12:13 +0000)]
PER - support of EXTERNAL and ObjectDescriptor types (not tested)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21640 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodo something with the return value from eth_write (which is a define for fwrite)so...
sahlberg [Wed, 2 May 2007 12:07:46 +0000 (12:07 +0000)]
do something with the return value from eth_write (which is a define for fwrite)so that -Werror does not cause the build to fail

-This line, and those below, will be ignored--

M    gtk/rtp_analysis.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21639 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix some more warnings that the result from fread/fwrite is discarded by assigning...
sahlberg [Wed, 2 May 2007 11:50:54 +0000 (11:50 +0000)]
fix some more warnings that the result from fread/fwrite is discarded by assigning  the return value to a variable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21638 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agostore the result of fread in a variable to make -Werror happy
sahlberg [Wed, 2 May 2007 08:50:16 +0000 (08:50 +0000)]
store the result of fread in a variable  to make -Werror happy

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21637 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Stefan Puiu:
jake [Wed, 2 May 2007 06:17:19 +0000 (06:17 +0000)]
From Stefan Puiu:
A DHCP Discover option 90 has no Secret ID nor HMAC MD5 Hash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21636 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSplit out common asn1 stuff to asn1.h and include that where needed.
etxrab [Tue, 1 May 2007 22:05:11 +0000 (22:05 +0000)]
Split out common asn1 stuff to asn1.h and include that where needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21635 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Dustin Johnson: Normalize indentation.
gerald [Tue, 1 May 2007 16:55:15 +0000 (16:55 +0000)]
From Dustin Johnson: Normalize indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21634 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake these protocols findable by name.
martinm [Tue, 1 May 2007 09:45:34 +0000 (09:45 +0000)]
Make these protocols findable by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21633 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFetch IP and TCP length values directly instead of casting the data buffer
gerald [Tue, 1 May 2007 04:58:12 +0000 (04:58 +0000)]
Fetch IP and TCP length values directly instead of casting the data buffer
to struct pointers (which causes compiler errors on the Solaris builder).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21632 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoParenthesize to squelch a compiler warning (a warning that suggests that
guy [Tue, 1 May 2007 01:56:58 +0000 (01:56 +0000)]
Parenthesize to squelch a compiler warning (a warning that suggests that
the parentheses are needed - not that I can remember which of && and ||
have higher precedence, anyway, which is why I like parenthesizing
expressions such as this...).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21631 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Dustin Johnson and myself:
gerald [Mon, 30 Apr 2007 23:50:35 +0000 (23:50 +0000)]
From Dustin Johnson and myself:

  - HT Control fixes and updates
  - Add an is_ht flag to the common dissection and capture routines, along
    with a registered dissector (which is used in code that hasn't been
    checked in yet.)
  - Action Fixed Parameter updates
  - Control Wrapper fixes and updates
  - Beacon Interval fixes and updates
  - Capability Info fixes and updates
  - Block Ack / Block Ack Request fixes
  - Lots of miscellaneous fixes and updates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21630 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse memcpy() to copy the session ID to the buffer, so we don't get
guy [Mon, 30 Apr 2007 21:22:15 +0000 (21:22 +0000)]
Use memcpy() to copy the session ID to the buffer, so we don't get
warnings from the compiler about pointer value alignment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21629 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate copyright notice.
guy [Mon, 30 Apr 2007 19:25:18 +0000 (19:25 +0000)]
Update copyright notice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21628 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a header that redefines g_array_index() to throw in a "void *" cast
guy [Mon, 30 Apr 2007 19:24:25 +0000 (19:24 +0000)]
Add a header that redefines g_array_index() to throw in a "void *" cast
to work around the "data" field of a GArray being a guint8 *, and
defines a g_array_data() macro to extract that field and cast it to void
*.

Use that header where needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21627 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoYet another workaround for GArray's bad data type choice.
guy [Mon, 30 Apr 2007 16:54:29 +0000 (16:54 +0000)]
Yet another workaround for GArray's bad data type choice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21626 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix up the asn/q932 Makefile as per Tomas Kukosa's suggestion - and make
guy [Mon, 30 Apr 2007 08:55:59 +0000 (08:55 +0000)]
Fix up the asn/q932 Makefile as per Tomas Kukosa's suggestion - and make
it a lot more like the Makefile.nmake file.  Also, use $(PROTOCOL_NAME)
in a couple of places in Makefile.nmake where it wasn't being used
before.

(It might be interesting to see whether we can use a template for these
Makefiles, and just tweak some variables at the beginning.)

That lets us get a Q.932 ROS dissector with the right file name and with
"q932.ros" rather than "q932-ros" as the dissector name; do that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21625 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonewline at end of file is required by some compilers
kukosa [Mon, 30 Apr 2007 08:38:59 +0000 (08:38 +0000)]
newline at end of file is required by some compilers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21624 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThou shalt not squelch compiler complaints about an assignment
guy [Mon, 30 Apr 2007 08:33:44 +0000 (08:33 +0000)]
Thou shalt not squelch compiler complaints about an assignment
discarding a qualifier by explicitly casting away the qualifier;
constness should persist, so that attempts to, for example, modify
something you got with tvb_get_ptr() get complained about (as we don't,
and won't, guarantee that you will get correct behavior if you do that).
Just make the pointer to which a const pointer is being assigned const
itself.

Yet *AGAIN* work around GArray's brokenness of having its data pointer
be a guint8 * rather than a void *.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21623 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe Q.932 dissector doesn't need to include <string.h>; the Q.932 ROS
guy [Mon, 30 Apr 2007 06:41:53 +0000 (06:41 +0000)]
The Q.932 dissector doesn't need to include <string.h>; the Q.932 ROS
dissector does.

The fix to the Makefile to generate packet-q932-ros.c changed the
protocol name in some cases; change it uniformly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21622 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomove T.30 protocol into its own dissector file
kukosa [Mon, 30 Apr 2007 06:40:07 +0000 (06:40 +0000)]
move T.30 protocol into its own dissector file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21621 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPut the q932-ros dissector into a file with the right name.
guy [Mon, 30 Apr 2007 06:24:27 +0000 (06:24 +0000)]
Put the q932-ros dissector into a file with the right name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21620 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't cast a "guint8 *" to a pointer to a structure; just use the
guy [Mon, 30 Apr 2007 06:19:35 +0000 (06:19 +0000)]
Don't cast a "guint8 *" to a pointer to a structure; just use the
pointer to the guint8, plus explicitly defined structure offsets (the
structure had better be the same on all platforms, forever, otherwise
binary compatibility breaks, which would be an error, given that the
structure appears in capture files).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21619 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Sake Blok:
sfisher [Sat, 28 Apr 2007 23:52:12 +0000 (23:52 +0000)]
From Sake Blok:

While looking into the http-dissector I improved a few things on
how it dissects a proxy CONNECT session. This is what I have changed:

- added the fields hf_http_proxy_connect_host and -port

- changed proto_tree_add_text to proto_tree_add_string and -uint
  so that it's possible to filter on them

- make these two fields "PROTO_ITEM_SET_GENERATED"

- removed the alteration of the ports within pinfo, now the
  ports in the column info are not changed to the port used to
  connect to the backend server. It is now possible to use
  follow-tcp-stream again on proxied ssl sessions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21618 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoThe data in a GArray is guaranteed to be properly aligned; add a cast to
guy [Sat, 28 Apr 2007 22:31:04 +0000 (22:31 +0000)]
The data in a GArray is guaranteed to be properly aligned; add a cast to
squelch compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21617 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoInclude <string.h> before using C string functions.
guy [Sat, 28 Apr 2007 22:22:35 +0000 (22:22 +0000)]
Include <string.h> before using C string functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21616 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoLibwireshark is now a shared library.
guy [Sat, 28 Apr 2007 22:17:05 +0000 (22:17 +0000)]
Libwireshark is now a shared library.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21615 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix the dependencies.
guy [Sat, 28 Apr 2007 22:16:27 +0000 (22:16 +0000)]
Fix the dependencies.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21614 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoNULL is a pointer value; routines returning integral values shouldn't
guy [Sat, 28 Apr 2007 22:01:27 +0000 (22:01 +0000)]
NULL is a pointer value; routines returning integral values shouldn't
return NULL.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21613 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoIn emem_tree_lookup_string(), return NULL if the allocation fails.
guy [Sat, 28 Apr 2007 21:58:42 +0000 (21:58 +0000)]
In emem_tree_lookup_string(), return NULL if the allocation fails.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21612 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoIn calls to the emem_tree routines, forcibly align items not known to be
guy [Sat, 28 Apr 2007 21:09:20 +0000 (21:09 +0000)]
In calls to the emem_tree routines, forcibly align items not known to be
aligned on 32-bit boundaries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21611 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMake tvb_memdup(), like ep_tvb_memdup(), return a "void *".
guy [Sat, 28 Apr 2007 21:06:15 +0000 (21:06 +0000)]
Make tvb_memdup(), like ep_tvb_memdup(), return a "void *".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21610 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRevert some private experiments checked in by misstake.
etxrab [Sat, 28 Apr 2007 14:47:43 +0000 (14:47 +0000)]
Revert some private experiments checked in by misstake.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21609 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Gavin Heer:
etxrab [Sat, 28 Apr 2007 14:38:53 +0000 (14:38 +0000)]
From Gavin Heer:
 Here's a patch that decodes MMS(Manufacturing Messaging
Specification) when transported over COTP/TPKT/TCP.  Previously, MMS would only be decoded if the OSI Presentation Layers were present. Now MMS/COTP/TPKT/TCP is dissected.
With a change to use more functions from packet-ber

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21608 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd:
etxrab [Sat, 28 Apr 2007 12:13:25 +0000 (12:13 +0000)]
Add:
 proto_tree_add_bits_ret_val()
tvb_get_bits()
And modify
proto_tree_add_bits() not to return a value.
little endian is not yet implemented.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21607 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofrom metatech at flashmail.com :
sahlberg [Sat, 28 Apr 2007 07:57:12 +0000 (07:57 +0000)]
from metatech at flashmail.com :
 new protocol STARTEAM

>Hi,
>
>Here is a submission of a new dissector for the Borland StarTeam protocol.
>For the compiler warnings, I tried to get rid of them, at least what MSVC6
>is reporting.  If your compiler reports more, please tell me the line number.
>As I do not have SVN installed but I compiled from the 0.99.5 tarball,
>please forgive me if I cannot easily generate diffs against current SVN (I
>tried my best with Cygwin).
>I also added the sample capture file on the Wiki on which I ran 900 loops
>of fuzz testing with no problem.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21606 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix Q.932 extra dist and add QSIG to extra dist.
kukosa [Sat, 28 Apr 2007 07:55:41 +0000 (07:55 +0000)]
Fix Q.932 extra dist and add QSIG to extra dist.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21605 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd Q.932 to extra dist.
etxrab [Fri, 27 Apr 2007 23:03:37 +0000 (23:03 +0000)]
Add Q.932 to extra dist.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21604 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoChange of authors email address
jake [Fri, 27 Apr 2007 18:16:05 +0000 (18:16 +0000)]
Change of authors email address

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21603 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agonew Q.932 and QSIG dissectors
kukosa [Fri, 27 Apr 2007 08:10:18 +0000 (08:10 +0000)]
new Q.932 and QSIG dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21602 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agominor formal changes
kukosa [Fri, 27 Apr 2007 07:37:30 +0000 (07:37 +0000)]
minor formal changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21601 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- new #.Exports parameter VALS_WITH_TABLE which "exports" whole table into header...
kukosa [Fri, 27 Apr 2007 07:35:01 +0000 (07:35 +0000)]
- new #.Exports parameter VALS_WITH_TABLE which "exports" whole table into header file
  /it is only one way how to use it in Windows plugins/
- better handling of imports and definitions if more ASN.1 sources are compiled together
- fix tag handling on top level of PDU
- new -I command line option for path(s) of conformance files including

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21600 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Bingyao Du:
jake [Fri, 27 Apr 2007 06:34:31 +0000 (06:34 +0000)]
From Bingyao Du:
Attachment is a patch for adding a new Juniper NSRP dissector. In this patch, OICQ author email address
<dubingyao@gmail.com> has also been updated to <secfire@gmail.com>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21599 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Jeff Foster: add support for Cisco HDLC captures.
guy [Thu, 26 Apr 2007 20:06:06 +0000 (20:06 +0000)]
From Jeff Foster: add support for Cisco HDLC captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21598 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAs with other types of extra info, tag the UID extra info. Don't add
guy [Thu, 26 Apr 2007 19:44:18 +0000 (19:44 +0000)]
As with other types of extra info, tag the UID extra info.  Don't add
stuff to the UID tree unless it's UID stuff.

Also, as we appear to allow for null domain and account information in
dissect_smb_uid(), check for null information before trying to add it to
the top-level item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21597 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoTiny formatting change
jmayer [Thu, 26 Apr 2007 15:39:41 +0000 (15:39 +0000)]
Tiny formatting change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21596 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomtp3_addr_to_str_buf() and mtp3_pc_hash() expect to be passed a pointer
guy [Thu, 26 Apr 2007 07:57:44 +0000 (07:57 +0000)]
mtp3_addr_to_str_buf() and mtp3_pc_hash() expect to be passed a pointer
to a mtp3_addr_pc_t; declare them as such, and pass the argument as
such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21595 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoChange the signature of proto_tree_add_bits() and add proto_tree_add_bits_ret_val()
etxrab [Thu, 26 Apr 2007 06:39:29 +0000 (06:39 +0000)]
Change the signature of proto_tree_add_bits() and add proto_tree_add_bits_ret_val()
which will hopefully be more acceptable.
Change name of tvb_get_bits() in ansi_801

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21594 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for bug 1505. Adding getprinterdriver levels 2, 6, and (partially) 101.
jake [Thu, 26 Apr 2007 06:00:48 +0000 (06:00 +0000)]
Fix for bug 1505. Adding getprinterdriver levels 2, 6, and (partially) 101.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21593 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:47:34 +0000 (05:47 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21592 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:43:43 +0000 (05:43 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21591 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:40:48 +0000 (05:40 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21590 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomemmove() is needed only if the source and destination might overlap.
guy [Thu, 26 Apr 2007 05:35:04 +0000 (05:35 +0000)]
memmove() is needed only if the source and destination might overlap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21589 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMake ADD_ADDRESS_TO_HASH() take a pointer to an address as an argument,
guy [Thu, 26 Apr 2007 04:30:41 +0000 (04:30 +0000)]
Make ADD_ADDRESS_TO_HASH() take a pointer to an address as an argument,
as the other address macros do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21588 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoSee previous comment.
guy [Thu, 26 Apr 2007 03:43:34 +0000 (03:43 +0000)]
See previous comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21587 f5534014-38df-0310-8fa8-9805f1628bb7