git.samba.org - obnox/wireshark/wip.git/log

git.samba.org / obnox / wireshark / wip.git / log

martinm [Wed, 15 Sep 2010 15:52:30 +0000 (15:52 +0000)]

Add expert info for timing adjustment control message, and tweak a label.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34123 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Wed, 15 Sep 2010 15:13:40 +0000 (15:13 +0000)]

Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 differently:

On Windows, rename inet_pton() to ws_inet_pton() so that builds on Vista or
later systems (that have inet_pton() natively) will still work on pre-Vista
systems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34122 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Wed, 15 Sep 2010 15:13:17 +0000 (15:13 +0000)]

Revert 34081 and 34093 in preparation for a cleaner fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34121 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Wed, 15 Sep 2010 14:10:25 +0000 (14:10 +0000)]

Follow up to bug 5209 and rev 34115:

%hh is C99 so remove it from packet-ssl-utils and add it to the banned list
(similar to %ll) in checkAPIs.pl .

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34120 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Tue, 14 Sep 2010 21:38:54 +0000 (21:38 +0000)]

Clean up the icmp info column per discussion in bug #4014.

Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE
in the proto_tree_add_item() calls for the identifier and sequence numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34119 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 14 Sep 2010 20:50:03 +0000 (20:50 +0000)]

Add more GUIManager code #ifdef:ed out

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34118 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Tue, 14 Sep 2010 16:03:34 +0000 (16:03 +0000)]

Remove duplicate register_all_protocol_handoffs entry

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34117 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Tue, 14 Sep 2010 15:54:12 +0000 (15:54 +0000)]

Bug #5211 from Guenter Strubreiter:

for writing a TCAP subdissector as a plugin some functions are needed in
libwireshark.def for export

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34116 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Tue, 14 Sep 2010 15:43:19 +0000 (15:43 +0000)]

From Cal Turney via bug 5209:

Decode of SETCLIENTID calls in the Windows x86 version fail with "[Dissector
bug, protocol NFS: STATUS_ACCESS_VIOLATION: dissector accessed an invalid
memory address]".  This error occurs in packet-nfs.c in
dissect_nfs_clientaddr4() where vars 'protocol' and 'universal_ip_address' get
stepped on following the call to scanf().  The b1-b10 vars are declared as
quint8.  While "hh" modifier used in the scanf() is documented in Linux to
correspond to an a signed/unsigned char arg, I cannot find a similar
designation in Windows (MSDN). The Windows C compiler interprets %hhu as
corresponding to a int16 rather than int8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34115 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 14 Sep 2010 14:43:56 +0000 (14:43 +0000)]

From tieuthunhi:
Add new time source for Gigamon header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5210

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34114 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 14 Sep 2010 14:24:39 +0000 (14:24 +0000)]

From Vincent Helfre:
Incorrect decoding of List of ARFCN in BCCH frequency list.
When the range 1024 is selected, it can happen that 2 bytes need to be read for
W1, and also for W2. In the current version, when W1 ends on a byte boundary,
W2 will get an incorrect value, since it will be truncated by 1 bit.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5214

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34113 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 13 Sep 2010 20:21:41 +0000 (20:21 +0000)]

Add more GUIManager code #ifdef:ed out

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34112 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Mon, 13 Sep 2010 18:49:55 +0000 (18:49 +0000)]

Attempt to fix the stack overflow reported at
http://seclists.org/bugtraq/2010/Sep/87 .

Unfortunately no one from the NCNIPC pen test team has contacted us or
provided a sample capture so the fix hasn't been verified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34111 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 13 Sep 2010 16:51:10 +0000 (16:51 +0000)]

From Yaniv Kaul:
[PATCH] Add SSL cipher 'Transport Layer Security (TLS) Renegotiation Indication Extension' (RFC 5746)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5207

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34110 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Sun, 12 Sep 2010 22:36:52 +0000 (22:36 +0000)]

set_menu_sensitivity() is used only if MENUS_USE_UIMANAGER is defined,
so define it only if MENUS_USE_UIMANAGER is defined.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34109 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Sun, 12 Sep 2010 21:53:26 +0000 (21:53 +0000)]

Get rid of /* within comment, clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34108 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Sun, 12 Sep 2010 19:29:05 +0000 (19:29 +0000)]

Remove deprecated check_col().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34107 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Sun, 12 Sep 2010 19:26:42 +0000 (19:26 +0000)]

Add more GUIManager code #ifdef:ed out

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34106 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Sun, 12 Sep 2010 15:03:34 +0000 (15:03 +0000)]

[Automatic manuf and enterprise-numbers update for 2010-09-12]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34102 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

rbalint [Sun, 12 Sep 2010 01:13:42 +0000 (01:13 +0000)]

Decode SLL payloads using a dissector table based on sll.ltype.
The idea and the original patch came from Sebastian Reichel
<elektranox@gmail.com> in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594390

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34101 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 10 Sep 2010 21:24:32 +0000 (21:24 +0000)]

Only check for 4 NOP in a row within a uint32 boundary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34100 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 10 Sep 2010 21:22:29 +0000 (21:22 +0000)]

From Martin Peylo via bug 5198:
Added missing OIDs in CRMF (RFC 4211) dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34099 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 10 Sep 2010 16:50:12 +0000 (16:50 +0000)]

Use absolute paths in link_directories.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34098 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 10 Sep 2010 16:48:00 +0000 (16:48 +0000)]

Follow TCP and expand description for "NOP" and "EOL" options to "No-Operation (NOP)"
and "End of Options List (EOL)" respectively.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34097 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 10 Sep 2010 16:33:46 +0000 (16:33 +0000)]

Put the ": %u (multiply by %u)" back on the TCP window scaling option, so
users don't have to expand the tree to see the details that were there
before rev 34094.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34096 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 10 Sep 2010 16:23:58 +0000 (16:23 +0000)]

Expand description for "NOP" and "EOL" options to "No-Operation (NOP)" and
"End of Options List (EOL)" respectively.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34095 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Fri, 10 Sep 2010 16:12:17 +0000 (16:12 +0000)]

Enhance the TCP option display for window scaling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34094 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Fri, 10 Sep 2010 13:52:42 +0000 (13:52 +0000)]

From BBA via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 :

Followup to 34081: move libwsutil _all_ the way forward so that our inet_pton
is always linked in before wsock32's. This means that our Windows-7 Win64
builds (on which there is a native inet_pton in wsock32) will still work on
pre-Vista Win64's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34093 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 10 Sep 2010 11:16:29 +0000 (11:16 +0000)]

Update dsfield ECN according to RFC3168.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34092 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Thu, 9 Sep 2010 18:36:20 +0000 (18:36 +0000)]

Add some hf blurbs (for fields whose description is an acronym)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34091 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Thu, 9 Sep 2010 17:30:35 +0000 (17:30 +0000)]

Remove what appear to be two redundant lines of code (AFAIKT).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34090 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Thu, 9 Sep 2010 15:46:40 +0000 (15:46 +0000)]

Resolve another issue the Windows buildbots are having after rev 34084:
guint8 -> guint16 for th_flags variable in segment struct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34089 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 8 Sep 2010 23:10:52 +0000 (23:10 +0000)]

Turn the TCP timestamp option into a subtree to also show the option kind,
option length and values with proto_tree_add_item() intead of _add_text().
The options tree still shows the same information as before until the sub-
tree is expanded.

The goal is to do this with all TCP and IP options.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34088 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 8 Sep 2010 21:25:14 +0000 (21:25 +0000)]

Mask out the header length from th_flags.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34087 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 8 Sep 2010 21:11:45 +0000 (21:11 +0000)]

Make the Windows buildbot happy: guint8 -> guint16 for flags variable in
definition of tcp_analyze_sequence_number().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34086 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 8 Sep 2010 20:52:00 +0000 (20:52 +0000)]

Minor correction to SVN revision 34084: we better only try up to the 9
available values in flags[], so we don't run past the end of the array
if one of the reserved flags is set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34085 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 8 Sep 2010 20:43:19 +0000 (20:43 +0000)]

Expand the TCP flags to include the low nibble of the byte that has
the header length in the high nibble. The only new flag is nonce (NS);
the remaining three bits are still reserved.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34084 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 8 Sep 2010 19:01:41 +0000 (19:01 +0000)]

From Frank Lahm via bug #5169: Provide initial support for the undocumented
AFP FPSpotlightRPC call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34083 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Wed, 8 Sep 2010 18:47:14 +0000 (18:47 +0000)]

Follow up to rev 34073: Since "-b files:0" is no longer necessary to
override the default of turning on a multiple file ring buffer, require
a positive integer to be specified for the files value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34082 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Wed, 8 Sep 2010 16:51:12 +0000 (16:51 +0000)]

Attempt to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 :

Move libwsutil forward in the list of Wireshark libraries so that our inet_pton
is always used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34081 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 8 Sep 2010 13:38:47 +0000 (13:38 +0000)]

Revert revision 33780, because the checksum is only calculated
from the header and not the content.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34080 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 8 Sep 2010 10:29:06 +0000 (10:29 +0000)]

Support negative values when viewing seconds with hours and minutes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34079 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 8 Sep 2010 09:33:53 +0000 (09:33 +0000)]

Allow for proto_tree_add_item() with FT_ABSOLUTE_TIME and FT_RELATIVE_TIME
to have length == 4 (only seconds).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34078 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 8 Sep 2010 09:24:53 +0000 (09:24 +0000)]

From Yaniv Kaul via bug 5193:
Dissect NTLMSSP type 0x5 (DNS Forest name).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34077 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

kukosa [Wed, 8 Sep 2010 09:02:16 +0000 (09:02 +0000)]

Do not report undecoded message to expert info for ReturnResult without result filed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34076 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 8 Sep 2010 06:45:04 +0000 (06:45 +0000)]

Fake proto_item_prepend_text() in reassemble_test.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34075 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Tue, 7 Sep 2010 20:40:39 +0000 (20:40 +0000)]

Put the number of fragments/segments in front of the element to avoid
conflict when they are named fragments instead of segments and to avoid
duplicating the fragments/segments text.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34074 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Tue, 7 Sep 2010 19:22:05 +0000 (19:22 +0000)]

These two capture option variables are defined by capture_opts_init(), so
don't redefine them to new values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34073 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Tue, 7 Sep 2010 14:06:43 +0000 (14:06 +0000)]

From Yaniv Kaul via bug 4550:
Show number of segments which were used in the desgementation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34072 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 7 Sep 2010 08:10:45 +0000 (08:10 +0000)]

Start adding GTKUIManager code.(#IF 0'ed out.).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34071 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Mon, 6 Sep 2010 19:59:15 +0000 (19:59 +0000)]

From yami via bug 3310:
SMB2 create context response fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34070 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Mon, 6 Sep 2010 17:31:17 +0000 (17:31 +0000)]

From Pascal Quantin via bug 5186:
Fix the decoding of the maximum/guaranteed bit rates for uplink/downlink.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34069 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Mon, 6 Sep 2010 09:22:43 +0000 (09:22 +0000)]

Change bandwidth labels, and update stop time even on first frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34068 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

gerald [Sun, 5 Sep 2010 15:03:42 +0000 (15:03 +0000)]

[Automatic manuf and enterprise-numbers update for 2010-09-05]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34064 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Sun, 5 Sep 2010 12:16:14 +0000 (12:16 +0000)]

Request-Line can contain an empty Request-URI.

I don't want to change get_token_len() to not skip multiple spaces,
because I don't know if other protocols depends on this behaviour.
We should maybe check this...

This fixes bug 5181.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34063 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 17:10:52 +0000 (17:10 +0000)]

GTPv2: IMSI is decoded improperly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5179

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34062 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Fri, 3 Sep 2010 16:45:05 +0000 (16:45 +0000)]

Add bandwidth figures per UE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34061 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Fri, 3 Sep 2010 16:05:01 +0000 (16:05 +0000)]

Try to cast away windows buildbot problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34060 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

martinm [Fri, 3 Sep 2010 15:22:28 +0000 (15:22 +0000)]

Add bandwidth figures to RLC stats (per-UE and per-channel).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34059 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

kukosa [Fri, 3 Sep 2010 10:31:56 +0000 (10:31 +0000)]

Fix start offset and length handling in SEQUNCE OF (caused Gtk crash for sequences at the end of frame)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34058 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 3 Sep 2010 09:12:40 +0000 (09:12 +0000)]

Increase maximum number of nodes to 40.
10 is in some situations too few.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34057 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 3 Sep 2010 09:10:32 +0000 (09:10 +0000)]

Code cleanup: Remove Begin/End comments on each and every code block,
this only makes the code hard to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34056 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Fri, 3 Sep 2010 08:44:00 +0000 (08:44 +0000)]

Check if using tree before adding the octet string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34055 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 08:41:04 +0000 (08:41 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34054 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 07:28:51 +0000 (07:28 +0000)]

Add doxygen coments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34053 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 07:27:59 +0000 (07:27 +0000)]

Add doxygen coments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34052 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 07:25:51 +0000 (07:25 +0000)]

Add a comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34051 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 06:18:29 +0000 (06:18 +0000)]

From Michael Lum:
ANSI-A dissector does not recognize service option 73
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5176

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34050 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Fri, 3 Sep 2010 05:50:55 +0000 (05:50 +0000)]

From Michael Lum:
The EVRC dissector does not handle service option 73 (EVRC-NW).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5177

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34049 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Thu, 2 Sep 2010 21:30:54 +0000 (21:30 +0000)]

Apply the quick fix from bug 2952.

And it's true, this dissector really needs an overhaul!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34048 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 2 Sep 2010 19:23:01 +0000 (19:23 +0000)]

Add comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34047 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Thu, 2 Sep 2010 18:02:06 +0000 (18:02 +0000)]

Introduce 2 new environment variables: WIRESHARK_EP_VERIFY_POINTERS and
WIRESHARK_SE_VERIFY_POINTERS that control whether or not we verify if a given
pointer is ep_ or se_ allocated, respectively.

Turn the behavior off by default for speed reasons (the speed difference isn't
huge, but...).

Turn the behavior on when fuzz testing.

Document these two new variables in the man pages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34046 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Thu, 2 Sep 2010 17:13:36 +0000 (17:13 +0000)]

Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5173 :

Don't call col_set_str() on a string returned from val_to_str() (which may be
ep_ allocated).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34045 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

sfisher [Thu, 2 Sep 2010 17:11:48 +0000 (17:11 +0000)]

Fix typo in comment: datat -> data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34044 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 2 Sep 2010 15:39:15 +0000 (15:39 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34043 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 2 Sep 2010 15:38:04 +0000 (15:38 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34042 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 2 Sep 2010 06:34:04 +0000 (06:34 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34041 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Thu, 2 Sep 2010 06:22:12 +0000 (06:22 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34040 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Wed, 1 Sep 2010 20:54:41 +0000 (20:54 +0000)]

Ensure we always print the heading when dumping PSML and CSV.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34039 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 1 Sep 2010 19:42:59 +0000 (19:42 +0000)]

1.4 version does not display the t.38 graph.
(init/remove tap_listener missing)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34038 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

guy [Wed, 1 Sep 2010 17:49:27 +0000 (17:49 +0000)]

Expand and update comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34037 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Wed, 1 Sep 2010 12:39:29 +0000 (12:39 +0000)]

From Jaap Keuter:
Fix Wireshark don't show mgcp calls in "Telephony" => "VoIP calls"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5167

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34036 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 31 Aug 2010 20:03:46 +0000 (20:03 +0000)]

From Pascal Quantin:
Patch that allows the dissection of the Feature Group Indicators bit string. I tested it with our UE and it works fine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34035 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Tue, 31 Aug 2010 18:28:59 +0000 (18:28 +0000)]

A GString has it's own length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34034 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Tue, 31 Aug 2010 15:02:03 +0000 (15:02 +0000)]

Support space in list of hidden columns.

This fixes bug 5163.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34033 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 31 Aug 2010 10:50:54 +0000 (10:50 +0000)]

Add stub code for future dissection of featureGroupIndicators.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34032 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Tue, 31 Aug 2010 10:24:08 +0000 (10:24 +0000)]

Update the header length after dissecting the header.

This fixes bug 5162.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34031 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Tue, 31 Aug 2010 07:53:51 +0000 (07:53 +0000)]

Ensure we always update the display filter when changing profile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34030 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Tue, 31 Aug 2010 05:48:12 +0000 (05:48 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34029 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

wmeier [Mon, 30 Aug 2010 23:58:19 +0000 (23:58 +0000)]

Add #include <stdio.h> for fprintf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34028 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 30 Aug 2010 20:30:20 +0000 (20:30 +0000)]

Remove the depricated GtkItemFactory code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34027 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 30 Aug 2010 19:49:57 +0000 (19:49 +0000)]

Switch to GTK UIManager.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34026 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Mon, 30 Aug 2010 19:14:54 +0000 (19:14 +0000)]

Include stdio.h. Fixup indent some.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34025 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Mon, 30 Aug 2010 17:05:37 +0000 (17:05 +0000)]

Fix the crash reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5157 :

If get_unicode_or_ascii_string() returns a NULL pointer, return a pointer to an
empty string back to our caller.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34018 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Mon, 30 Aug 2010 16:10:01 +0000 (16:10 +0000)]

Remove some unnecessary includes: a lot of things don't need globals.h and register.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34017 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

morriss [Mon, 30 Aug 2010 15:33:32 +0000 (15:33 +0000)]

Use the top-level isprint.h instead of redefining isprint ourselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34016 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 30 Aug 2010 14:32:38 +0000 (14:32 +0000)]

Remove a redundant callback.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34015 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 30 Aug 2010 14:23:25 +0000 (14:23 +0000)]

Convert to GTKUIManager

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34014 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

etxrab [Mon, 30 Aug 2010 14:22:49 +0000 (14:22 +0000)]

Doxygen fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34013 f5534014-38df-0310-8fa8-9805f1628bb7

commit | commitdiff | tree

stig [Mon, 30 Aug 2010 09:31:52 +0000 (09:31 +0000)]

Call dfilter_macro_uat->post_update_cb instead of using cfile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34012 f5534014-38df-0310-8fa8-9805f1628bb7

git mirror of the wireshark svn

RSS Atom