14 years ago From Graeme Lunt
etxrab [Sun, 4 Sep 2005 20:30:31 +0000 (20:30 +0000)]
 From Graeme Lunt

 I attach my RTSE dissector (in tar file) which requires the included ROS dissector, as well as a patch to the latest pres.{cnf,asn}. The ROS dissector uses a new field in the SESSION_DATA_STRUCTURE to pass the ROS operation to the sub-dissector, though this is also set by other dissectors (RTSE uses it in X.410 mode).

 Note that X.400 P1 in X.410 mode doesn't use ROS, so it is useful not to explicitly include ROS in my X411 dissector. However, the inclusion of a ROS dissector won't effect any dissectors that currently implement their own ROS.

 I also include dissectors for:

 X.411  (P1)  X.400 OSI Message Transfer Service
 X.420  (P22)  X.400 OSI Information Object
 STANAG 4406 (P772) STANAG 4406 Military Message Extensions (to P22)

 These rely on the RTSE and ROS dissectors.

Withs some changes to remove various warnings and errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15680 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Graeme Lunt
etxrab [Sun, 4 Sep 2005 16:22:12 +0000 (16:22 +0000)]
From Graeme Lunt

I attach my RTSE dissector (in tar file) which requires the included ROS dissector, as well as a patch to the latest pres.{cnf,asn}. The ROS dissector uses a new field in the SESSION_DATA_STRUCTURE to pass the ROS operation to the sub-dissector, though this is also set by other dissectors (RTSE uses it in X.410 mode).

Note that X.400 P1 in X.410 mode doesn't use ROS, so it is useful not to explicitly include ROS in my X411 dissector. However, the inclusion of a ROS dissector won't effect any dissectors that currently implement their own ROS.

I also include dissectors for:

X.411  (P1)  X.400 OSI Message Transfer Service
X.420  (P22)  X.400 OSI Information Object
STANAG 4406 (P772) STANAG 4406 Military Message Extensions (to P22)

These rely on the RTSE and ROS dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15679 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Graeme Lunt:
etxrab [Sun, 4 Sep 2005 09:00:01 +0000 (09:00 +0000)]
From Graeme Lunt:
Basically the changes are:
a) [pres] make the find_oid_by_[pres_]ctx_id (I changed the name to make it more specific) non-static so it can be called from other dissectors (see acse.cnf changes). I also call it from RTSE and ROS dissectors
b) [acse] remove (#ifdef NOT_NEEDED) the oid lookup table and any reference to acse_handle - as these are no longer needed
c) [acse] register the acse dissector on
with some modifications: -#ifdef:ed code removed
- renamed aco -> pco

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15678 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake Objekt Key a HEX string.
etxrab [Sun, 4 Sep 2005 08:53:04 +0000 (08:53 +0000)]
Make Objekt Key a HEX string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15677 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake usage messages fit within 80 characters.
guy [Sat, 3 Sep 2005 18:51:55 +0000 (18:51 +0000)]
Make usage messages fit within 80 characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15676 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAs with Ethereal, so with Tethereal; we're not a GNU program, don't say
guy [Sat, 3 Sep 2005 18:31:45 +0000 (18:31 +0000)]
As with Ethereal, so with Tethereal; we're not a GNU program, don't say
we are.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15675 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse the "svnversion" variable, exported by version_info.c, to print the
guy [Sat, 3 Sep 2005 18:21:48 +0000 (18:21 +0000)]
Use the "svnversion" variable, exported by version_info.c, to print the
version number from SVN for non-release builds, just as Tethereal does.
Fixes bug 408.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15674 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn RTnet, make sure we don't pass a null handle to call_dissector(). Add
gerald [Fri, 2 Sep 2005 19:54:16 +0000 (19:54 +0000)]
In RTnet, make sure we don't pass a null handle to call_dissector().  Add
an entry about this to the release notes.  Fixes a recent buildbot crash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15673 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo.
gerald [Fri, 2 Sep 2005 19:50:01 +0000 (19:50 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15672 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agodon't crash if the file_set dialog is opened and a "none fileset" file is already...
ulfl [Fri, 2 Sep 2005 19:08:25 +0000 (19:08 +0000)]
don't crash if the file_set dialog is opened and a "none fileset" file is already loaded. This bug was introduced by me after the 0.10.12 release

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15671 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agotext2pcap can add fake SCTP headers.
guy [Fri, 2 Sep 2005 16:50:51 +0000 (16:50 +0000)]
text2pcap can add fake SCTP headers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15670 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoanother switch that should be a value_string
sahlberg [Fri, 2 Sep 2005 09:28:30 +0000 (09:28 +0000)]
another switch that should be a value_string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15669 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomake two thigs that should be value_strings value_strings
sahlberg [Fri, 2 Sep 2005 09:16:50 +0000 (09:16 +0000)]
make two thigs that should be value_strings value_strings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15668 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoA PDU dissector called by tcp_dissect_pdus() can't return anything.
guy [Fri, 2 Sep 2005 08:19:15 +0000 (08:19 +0000)]
A PDU dissector called by tcp_dissect_pdus() can't return anything.

A PDU length routine called by tcp_dissect_pdus() should use the offset
passed to it as the offset of the beginning of the PDU.

In the heuristic GIOP dissector, if we're running over TCP, and accept
the packet, call "dissect_giop_tcp()" so that we handle multiple PDUs
within the segment or PDUs split across segments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15667 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Steve Karg
etxrab [Fri, 2 Sep 2005 05:49:25 +0000 (05:49 +0000)]
From Steve Karg

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15666 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom ouli:
etxrab [Fri, 2 Sep 2005 05:46:10 +0000 (05:46 +0000)]
From ouli:
- Add version 2 CancelLocation decoding

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15665 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRegenerate dissectors with the current asn2eth.
guy [Fri, 2 Sep 2005 05:43:49 +0000 (05:43 +0000)]
Regenerate dissectors with the current asn2eth.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15664 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIt looks like there might not always be a body, check if there is.
etxrab [Thu, 1 Sep 2005 19:44:26 +0000 (19:44 +0000)]
It looks like there might not always be a body, check if there is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15663 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNormalize our hf_id checks and make sure our hf_ids are valid before we
gerald [Thu, 1 Sep 2005 19:35:23 +0000 (19:35 +0000)]
Normalize our hf_id checks and make sure our hf_ids are valid before we
try to use them.  This should fix bugs 399 and 401.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15662 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRe-assemble GIOP over TCP.
etxrab [Thu, 1 Sep 2005 19:31:48 +0000 (19:31 +0000)]
Re-assemble GIOP over TCP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15661 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoconvert to g_snprintf()
sahlberg [Thu, 1 Sep 2005 19:05:00 +0000 (19:05 +0000)]
convert to g_snprintf()

also make range_convert_range() return an emem allocated string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15660 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a no-longer-used #define.
guy [Thu, 1 Sep 2005 18:03:02 +0000 (18:03 +0000)]
Get rid of a no-longer-used #define.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15659 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse "proto_item_append_text()" rather than filling up an allocated
guy [Thu, 1 Sep 2005 11:34:10 +0000 (11:34 +0000)]
Use "proto_item_append_text()" rather than filling up an allocated
buffer.  This fixes one place where the "NLPID(s):" wasn't being put
into the protocol tree item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15658 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago128 bytes isn't much room for the stack; revert to using an on-the-stack
guy [Thu, 1 Sep 2005 11:32:14 +0000 (11:32 +0000)]
128 bytes isn't much room for the stack; revert to using an on-the-stack
buffer (the buffer in question is temporary, so it doesn't need to
survive after inet_ntop() returns), which should fix some compile errors
on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15657 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofilter expression can contain GUID in XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX form now
kukosa [Thu, 1 Sep 2005 10:52:33 +0000 (10:52 +0000)]
filter expression can contain GUID in XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX form now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15656 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse "proto_tree_append_text()" rather than appending to an ep_alloced
guy [Thu, 1 Sep 2005 10:38:41 +0000 (10:38 +0000)]
Use "proto_tree_append_text()" rather than appending to an ep_alloced
buffer (that buffer wasn't getting cleared for each item).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15655 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a trailing comma.
guy [Thu, 1 Sep 2005 09:56:23 +0000 (09:56 +0000)]
Get rid of a trailing comma.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15654 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoreplace one sprintf with g_snprintf and move one array off the stack and into emem...
sahlberg [Thu, 1 Sep 2005 09:40:55 +0000 (09:40 +0000)]
replace one sprintf with g_snprintf  and move one array off the stack and into emem allocated memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15653 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agohmmm i though i removed some sprintf in the previous commit apparently not.
sahlberg [Thu, 1 Sep 2005 09:29:21 +0000 (09:29 +0000)]
hmmm i though i removed some sprintf in the previous commit   apparently not.

remove all sprintf and replace with g_snprintf()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15652 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoconvert one sprintf into g_snprintf()
sahlberg [Thu, 1 Sep 2005 09:03:29 +0000 (09:03 +0000)]
convert one sprintf into g_snprintf()

at the same time, make proto_construct_dfilter_string() return an emem allocated string.
This fixes a tiny memleak in print.c that never freed the string returned by this function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15651 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoreplace one ifdeffed out sprintf with g_snprintf() so that it doesnt show up in a...
sahlberg [Thu, 1 Sep 2005 08:39:52 +0000 (08:39 +0000)]
replace one ifdeffed out sprintf with g_snprintf() so that it doesnt show up in a 'grep sprintf *.c' any more

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15650 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Tomer Shani
etxrab [Thu, 1 Sep 2005 05:44:40 +0000 (05:44 +0000)]
Add Tomer Shani

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15649 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tomer Shani:
etxrab [Thu, 1 Sep 2005 05:41:59 +0000 (05:41 +0000)]
From Tomer Shani:
Patch which will enable saving payload in raw (binary) format in addition to the existing au format.

We have found it very useful to be able to extract the RTP data for use with other tools (especially when dealing with proprietary/uncommon coders).


rtp_packet_save_payload: no longer transforms packet to linear coding, payload is saved in raw format
copy_file: will perform the needed transcoding and save to needed format (au or raw)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15648 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Martin Mathieson
etxrab [Thu, 1 Sep 2005 05:34:52 +0000 (05:34 +0000)]
From Martin Mathieson

These small patches:

- add RTSP header 'RDTFeatureLevel  as a proper field
- show feature level in RDT stream setup info
- tidy up RDT info column text

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15647 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix probable copy and paste error, as the xml dissector should be named xml and not...
ulfl [Wed, 31 Aug 2005 23:52:40 +0000 (23:52 +0000)]
fix probable copy and paste error, as the xml dissector should be named xml and not mate

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15646 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf we set one or more time references and then changed the time display
gerald [Wed, 31 Aug 2005 21:38:08 +0000 (21:38 +0000)]
If we set one or more time references and then changed the time display
format, our time-formatted columns would display a time value instead of
"*REF*".  Don't to that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15645 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoParlay re-generated with the updated idl2eth generator.
etxrab [Wed, 31 Aug 2005 20:25:48 +0000 (20:25 +0000)]
Parlay re-generated with the updated idl2eth generator.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15644 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpadte to call Data dissector from PRES based on OID in Presentation Context,
etxrab [Wed, 31 Aug 2005 20:20:56 +0000 (20:20 +0000)]
Upadte to call Data dissector from PRES based on OID in Presentation Context,
based on the code in ACSE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15643 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a Makefile.
guy [Wed, 31 Aug 2005 20:02:06 +0000 (20:02 +0000)]
Add a Makefile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15642 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGive it an RCS ID.
guy [Wed, 31 Aug 2005 19:51:53 +0000 (19:51 +0000)]
Give it an RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15641 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoudvm: initialise a variable
etxrab [Wed, 31 Aug 2005 19:51:24 +0000 (19:51 +0000)]
udvm: initialise a variable
sigcomp: implement RFC 4077

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15640 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGive it an RCS ID.
guy [Wed, 31 Aug 2005 19:51:16 +0000 (19:51 +0000)]
Give it an RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15639 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoKeep the list of possible "-z" arguments sorted, so we can display them
guy [Wed, 31 Aug 2005 19:43:37 +0000 (19:43 +0000)]
Keep the list of possible "-z" arguments sorted, so we can display them
in sorted order (to make it a bit easier to find the one you're
interested in).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15638 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo.
guy [Wed, 31 Aug 2005 18:49:14 +0000 (18:49 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15637 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- more standard way for FastStart item dissection
kukosa [Wed, 31 Aug 2005 15:03:12 +0000 (15:03 +0000)]
- more standard way for FastStart item dissection
- protocol names fixed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15636 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agointernal length field for constrained SEQUNCE/SET OF was not hidden
kukosa [Wed, 31 Aug 2005 14:53:15 +0000 (14:53 +0000)]
internal length field for constrained SEQUNCE/SET OF was not hidden

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15635 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- OID names table extended
kukosa [Wed, 31 Aug 2005 14:32:29 +0000 (14:32 +0000)]
- OID names table extended
- NAME and ABBREV attributes can be used in #.FIELD_ATTR
- following constraint format is supported (1..10, ..., 11..MAX)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15634 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake ses_vals extern. Required to get it linked on Mac OS X.
tuexen [Wed, 31 Aug 2005 13:52:43 +0000 (13:52 +0000)]
Make ses_vals extern. Required to get it linked on Mac OS X.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15633 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some g_string_printf[a]() and replace with g_snprintf()
sahlberg [Wed, 31 Aug 2005 08:49:10 +0000 (08:49 +0000)]
remove some g_string_printf[a]() and replace with g_snprintf()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15632 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange g_string_sprintf[a]() to g_snprintf() and emem allocated memory.
sahlberg [Wed, 31 Aug 2005 08:09:00 +0000 (08:09 +0000)]
change g_string_sprintf[a]() to g_snprintf() and emem allocated memory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15631 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDecode CmnInform fixes bug 376.
etxrab [Wed, 31 Aug 2005 05:46:20 +0000 (05:46 +0000)]
Decode CmnInform fixes bug 376.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15630 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopropset svn:keywords and svn:eol-style
jmayer [Tue, 30 Aug 2005 20:21:11 +0000 (20:21 +0000)]
propset svn:keywords and svn:eol-style

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15629 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd an item about the packet list scroll bar.
gerald [Tue, 30 Aug 2005 19:52:38 +0000 (19:52 +0000)]
Add an item about the packet list scroll bar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15628 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd timestamp enhancements to the changes section, do some editing with the existing...
ulfl [Tue, 30 Aug 2005 19:43:38 +0000 (19:43 +0000)]
add timestamp enhancements to the changes section, do some editing with the existing entries

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15627 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBreak out of an infinite loop. Fixes bugs 392 - 395. Add a UNIX Makefile
gerald [Tue, 30 Aug 2005 19:43:32 +0000 (19:43 +0000)]
Break out of an infinite loop.  Fixes bugs 392 - 395.  Add a UNIX Makefile
for generation of the PRES dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15626 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agominor workflow enhancement, generate the HTML files before the pdf's and alike.
ulfl [Tue, 30 Aug 2005 19:42:05 +0000 (19:42 +0000)]
minor workflow enhancement, generate the HTML files before the pdf's and alike.

while working with the docbook sources, the html versions are a lot easier to look at than the pdf's. At least the Adobe Reader will lock the pdf file, so one has to close it to generate a next version, it's ugly to work with.

the html files can be viewed with e.g. Firefox while a new version is already generated, a simple reload will do the update then ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15625 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofrom Jaap Keuter:
ulfl [Tue, 30 Aug 2005 19:35:20 +0000 (19:35 +0000)]
from Jaap Keuter:

There were so many little things in chapter 2 that I had to get to it and
weed them all out. Its mainly capitalizations, some wording, and the
addition of GnuWin32 references.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15624 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for slightly modified libpcap file format with nanosecond resolution...
ulfl [Tue, 30 Aug 2005 09:43:47 +0000 (09:43 +0000)]
Add support for slightly modified libpcap file format with nanosecond resolution (currently supported by Ethereal only). Support for both read and write was added.

The file format stays the same as the common libpcap format, only the lower part of the timestamp field uses nanoseconds instead of microseconds.

This file format uses the libpcap magic number 0xa1b23c4d.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15623 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove some g_string_printf[a]() and replace it with g_snprintf() to ememified buffers
sahlberg [Tue, 30 Aug 2005 09:38:06 +0000 (09:38 +0000)]
remove some g_string_printf[a]() and replace it with g_snprintf() to ememified buffers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15622 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove a bunch of sprintf that should be perfectly safe but for the principle of it
sahlberg [Tue, 30 Aug 2005 09:25:44 +0000 (09:25 +0000)]
remove a bunch of sprintf  that should be perfectly safe  but for the principle of it

replace with g_snprintf()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15621 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoreplace some g_string_sprintf() with g_snprintf()
sahlberg [Tue, 30 Aug 2005 09:05:44 +0000 (09:05 +0000)]
replace some g_string_sprintf() with g_snprintf()

remove one static 1kb char array and make it emem ep allocated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15620 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agomove an array off the stack into emem allocated memory
sahlberg [Tue, 30 Aug 2005 08:47:25 +0000 (08:47 +0000)]
move an array off the stack into emem allocated memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15619 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange g_string_sprintf() into g_snprintf()
sahlberg [Tue, 30 Aug 2005 08:41:18 +0000 (08:41 +0000)]
change g_string_sprintf() into g_snprintf()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15618 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agochange one g_string_sprintf() into g_snprintf() and move one array of characters...
sahlberg [Tue, 30 Aug 2005 08:23:50 +0000 (08:23 +0000)]
change one g_string_sprintf() into g_snprintf()  and move one array of characters from the stack into emem allocated memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15617 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoremove a variable that is never used and thus two also completely redundant g_free...
sahlberg [Tue, 30 Aug 2005 08:06:16 +0000 (08:06 +0000)]
remove a variable that is never used and thus two also completely redundant g_free() calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15616 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoreplace some (safe) g_string_sprintf with g_snprintf()
sahlberg [Tue, 30 Aug 2005 07:54:15 +0000 (07:54 +0000)]
replace some (safe) g_string_sprintf  with g_snprintf()
(so we dont have that many different string handling functions to memorize their usage of and can standardize on a single one )

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15615 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMapDialougePDU.cnf
etxrab [Mon, 29 Aug 2005 20:07:06 +0000 (20:07 +0000)]
Fix a typo.

- Add  OID(s)

Fix export of a value string and change names to the ones used in the protocol spec.

Replace PRES dissector with an asn2eth generated one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15614 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo 'BER_UNI_TAG_TeletexString'
etxrab [Mon, 29 Aug 2005 16:51:58 +0000 (16:51 +0000)]
Fix a typo 'BER_UNI_TAG_TeletexString'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15613 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange the field description to match the field name.
jmayer [Mon, 29 Aug 2005 15:00:24 +0000 (15:00 +0000)]
Change the field description to match the field name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15612 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a tool to check the hf_ values.
jmayer [Mon, 29 Aug 2005 14:15:32 +0000 (14:15 +0000)]
Add a tool to check the hf_ values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15611 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoavoid few warnings
kukosa [Mon, 29 Aug 2005 13:00:53 +0000 (13:00 +0000)]
avoid few warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15610 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- fix of bug made with too fast release
kukosa [Mon, 29 Aug 2005 11:37:08 +0000 (11:37 +0000)]
- fix of bug made with too fast release

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15609 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- put real value insted of only text into tree for choice extensions
kukosa [Mon, 29 Aug 2005 10:43:33 +0000 (10:43 +0000)]
- put real value insted of only text into tree for choice extensions
- sort alphabet for restricted character strings
- different handling of PER internal fields (only hide them)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15608 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn the SEQUENCE OF dissector helper
sahlberg [Mon, 29 Aug 2005 08:24:15 +0000 (08:24 +0000)]
In the SEQUENCE OF dissector helper

Only count the number of items in the SEQUENCE OF   IFF we have the full TVB containing the entire blob.
Dont count the items if the tvb is "short" since then this would just lead to a [short frame]  before a single item in the SEQUENCE OF has been dissected.

Do we really need to count the items and create a FT_UINT field with the number of items at all?
Then count the items as we are calling the subdissectors and
append the '# item[s]' text to the FT_NONE items after we finished the loop?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15607 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of the old file header definition.
guy [Mon, 29 Aug 2005 01:18:27 +0000 (01:18 +0000)]
Get rid of the old file header definition.

Set the time stamp resolution based on whether the number of ticks per
second is > 1 million or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15606 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMerge packet-afs-register-info.h, packet-afs-defs.h and packet-afs-macros.h
jmayer [Mon, 29 Aug 2005 00:02:50 +0000 (00:02 +0000)]
Merge packet-afs-register-info.h, packet-afs-defs.h and packet-afs-macros.h
into packet-afs.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15605 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoproperties: svn-keywords -> svn:keywords
jmayer [Sun, 28 Aug 2005 23:28:16 +0000 (23:28 +0000)]
properties: svn-keywords -> svn:keywords

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15604 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Bill Meier:
guy [Sun, 28 Aug 2005 23:11:53 +0000 (23:11 +0000)]
From Bill Meier:

1. Use the new (good work!) 'nanosec' precision only for gig pods;
2. Rework 'struct netxray_hdr' to make it (somewhat) easier
   to maintain and revise:
   a. Declare known hdr fields such as 'captype' instead
      of using offsets in 'xxx placeholder' fields.
   d. Define 'unknown' hdr fields using placeholder names
      based upon hex-offset in the netxray header record.
      (This isn't perfect, but I hope it will make things
       more manageable).
3. Update hdr field info (based upon examination of various
   capture files):
   a. Define a hdr field which appears to be 'time-zone'
      [offset in hours from UTC] for the machine doing
      the capture.
      (Maybe this field can eventually be used for Ethereal
       to display the (local) time as it was at the time
       of the capture).
   b. Describe certain hdr fields as being "file offsets"
      (altho the exact use is still unclear).

Update some comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15603 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEthereal requires 64-bit integrer support; do the time stamp
guy [Sun, 28 Aug 2005 22:52:05 +0000 (22:52 +0000)]
Ethereal requires 64-bit integrer support; do the time stamp
calculations with integers, which avoids some floating-point inaccuracy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15602 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the RSVP entry.
gerald [Sun, 28 Aug 2005 20:15:57 +0000 (20:15 +0000)]
Update the RSVP entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15601 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCorrect an eariler infinite loop fix. Fixes bug 382.
gerald [Sun, 28 Aug 2005 20:15:08 +0000 (20:15 +0000)]
Correct an eariler infinite loop fix.  Fixes bug 382.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15600 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some length checks. Fixes bugs 381, 384, and 386.
gerald [Sun, 28 Aug 2005 19:59:50 +0000 (19:59 +0000)]
Add some length checks.  Fixes bugs 381, 384, and 386.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15599 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a no-longer-true comment.
guy [Sun, 28 Aug 2005 19:55:44 +0000 (19:55 +0000)]
Get rid of a no-longer-true comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15598 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Graeme Lunt:
etxrab [Sun, 28 Aug 2005 19:50:36 +0000 (19:50 +0000)]
From Graeme Lunt:

b) dissect_ber_set() to report missing fields and handle untagged CHOICEs
c) dissect_ber_choice() to handle untagged CHOICEs (within the CHOICE)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15597 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut back a subtraction of 1 millisecond that was lost.
guy [Sun, 28 Aug 2005 19:28:04 +0000 (19:28 +0000)]
Put back a subtraction of 1 millisecond that was lost.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15596 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhen creating subset tvbuffs, set the length to the minimum of the
guy [Sun, 28 Aug 2005 17:57:30 +0000 (17:57 +0000)]
When creating subset tvbuffs, set the length to the minimum of the
desired reported length and the remaining length, so we don't throw an
exception at tvbuff creation time if we don't have all the desired data
- we want to throw the exception at dissection time, so we can dissect
the data we do have.

Use "tvb_ensure_bytes_exist()" to force exceptions to be thrown.

When "dissect_unknown_ber()" is called from "call_ber_oid_callback()",
we're handing it a newly-created tvbuff, so the offset in that tvbuff
should be zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15595 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate the Makefile with GNM.
etxrab [Sun, 28 Aug 2005 15:02:38 +0000 (15:02 +0000)]
Update the Makefile with GNM.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15594 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCo ordidnate CMIP abd GNM.
etxrab [Sun, 28 Aug 2005 15:01:49 +0000 (15:01 +0000)]
Co ordidnate CMIP abd GNM.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15593 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd dissection of ITU M.3100 GNM (GENERIC NETWORK INFORMATION MODEL).
etxrab [Sun, 28 Aug 2005 14:56:03 +0000 (14:56 +0000)]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15592 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExport "bytestring_to_str()", and use it when adding the link-layer
guy [Sun, 28 Aug 2005 06:44:06 +0000 (06:44 +0000)]
Export "bytestring_to_str()", and use it when adding the link-layer
address for the ND_OPT_TARGET_LINKADDR ICMPv6 packet type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15591 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn at least some captures, some Kerberos packets contain just a Ticket
guy [Sun, 28 Aug 2005 06:41:49 +0000 (06:41 +0000)]
In at least some captures, some Kerberos packets contain just a Ticket
structure.  Handle that.

Don't muck with the columns, or put a top-level Kerberos protocol item
into the protocol tree, until we decide that we really have a Kerberos

Do, however, clear the Info column if we're dissecting the Kerberos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15590 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIn at least some captures, some Kerberos packets contain just a Ticket
guy [Sun, 28 Aug 2005 06:40:59 +0000 (06:40 +0000)]
In at least some captures, some Kerberos packets contain just a Ticket
structure.  Handle that.

Don't muck with the columns, or put a top-level Kerberos protocol item
into the protocol tree, until we decide that we really have a Kerberos

Do, however, clear the Info column if we're dissecting the Kerberos

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15589 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut the units after the values for signal and noise, as that's a bit
guy [Sun, 28 Aug 2005 06:38:30 +0000 (06:38 +0000)]
Put the units after the values for signal and noise, as that's a bit
more natural.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15588 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 03:13:30 +0000 (03:13 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15587 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 03:09:58 +0000 (03:09 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15586 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 03:05:53 +0000 (03:05 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15585 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 03:01:37 +0000 (03:01 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15584 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 02:56:24 +0000 (02:56 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15583 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 02:28:48 +0000 (02:28 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15582 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd missing value_string termination
sahlberg [Sun, 28 Aug 2005 02:24:01 +0000 (02:24 +0000)]
add missing value_string termination

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15581 f5534014-38df-0310-8fa8-9805f1628bb7