obnox/wireshark/wip.git
15 years agousing distributed help text files, instead of "#include" built in texts
ulfl [Mon, 22 Dec 2003 08:12:10 +0000 (08:12 +0000)]
using distributed help text files, instead of "#include" built in texts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9408 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPatch from Guy: using distributed help text files,
ulfl [Mon, 22 Dec 2003 08:01:01 +0000 (08:01 +0000)]
Patch from Guy: using distributed help text files,
instead of "#include" built in texts
(and some other minor changes)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9407 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agodistribute the text files in help dir
ulfl [Mon, 22 Dec 2003 07:57:43 +0000 (07:57 +0000)]
distribute the text files in help dir

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9406 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWe need to do the "if the first fragment we see has no more fragments
guy [Mon, 22 Dec 2003 02:25:03 +0000 (02:25 +0000)]
We need to do the "if the first fragment we see has no more fragments
after it, treat it as the only fragment" stuff for
"fragment_add_seq_next()" as well, so we handle non-fragmented packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9405 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a typo.
guy [Mon, 22 Dec 2003 02:06:27 +0000 (02:06 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9404 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't call "nds_defrag()" for positive ACK packets.
guy [Mon, 22 Dec 2003 02:04:18 +0000 (02:04 +0000)]
Don't call "nds_defrag()" for positive ACK packets.

Put in some comments noting problems with NDS reassembly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9403 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoPull the code to do reassembly of the request/response line, entity
guy [Mon, 22 Dec 2003 00:57:34 +0000 (00:57 +0000)]
Pull the code to do reassembly of the request/response line, entity
headers, and body into a separate routine, for use by other dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9402 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix unconditional handoff to subdissector introduced with the common reassembly
obiot [Sun, 21 Dec 2003 22:56:13 +0000 (22:56 +0000)]
Fix unconditional handoff to subdissector introduced with the common reassembly
code.

Add the "Reassembled in" header field, and show it if the packet has been
reassembled, but not in the given packet. This also allows to use the "Jump to
the corresponding frame" feature in Ethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9401 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf we don't have any packets, or don't have any filtered packets, don't
guy [Sun, 21 Dec 2003 22:32:07 +0000 (22:32 +0000)]
If we don't have any packets, or don't have any filtered packets, don't
even show the averages over the empty sets in question.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9400 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoArrays indexed by a 1-octet unsigned value, if we don't know which
guy [Sun, 21 Dec 2003 22:24:41 +0000 (22:24 +0000)]
Arrays indexed by a 1-octet unsigned value, if we don't know which
values are permitted, must have 256 elements, not 255 elements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9399 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago"sizeof(array)" is the size of the array in bytes, not the number of
guy [Sun, 21 Dec 2003 22:21:45 +0000 (22:21 +0000)]
"sizeof(array)" is the size of the array in bytes, not the number of
elements in the array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9398 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIn the MLUM-is-defined code path, "idx" is set - the only issue is if
guy [Sun, 21 Dec 2003 21:41:10 +0000 (21:41 +0000)]
In the MLUM-is-defined code path, "idx" is set - the only issue is if
MLUM isn't defined (which it isn't, by default).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9397 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd, for \xXX, the same sanity check (that 0xXX fits in a single byte)
guy [Sun, 21 Dec 2003 21:04:56 +0000 (21:04 +0000)]
Add, for \xXX, the same sanity check (that 0xXX fits in a single byte)
that we have for \0OOO.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9396 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a sprintf to non-malloc()ed memory by using g_strdup_printf() and g_free().
obiot [Sun, 21 Dec 2003 18:12:33 +0000 (18:12 +0000)]
Fix a sprintf to non-malloc()ed memory by using g_strdup_printf() and g_free().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9395 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: static declaration for ... follows non-static
jmayer [Sun, 21 Dec 2003 12:21:37 +0000 (12:21 +0000)]
warning: static declaration for ... follows non-static

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9394 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved some MSVC warnings (moved pcap.h before glib.h)
ulfl [Sun, 21 Dec 2003 12:19:39 +0000 (12:19 +0000)]
removed some MSVC warnings (moved pcap.h before glib.h)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9393 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved MSVC warning (uninitialized value)
ulfl [Sun, 21 Dec 2003 12:08:35 +0000 (12:08 +0000)]
removed MSVC warning (uninitialized value)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9392 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: overflow in implicit constant conversion
jmayer [Sun, 21 Dec 2003 12:07:09 +0000 (12:07 +0000)]
warning: overflow in implicit constant conversion

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9391 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: ISO C does not allow extra ; outside of a function
jmayer [Sun, 21 Dec 2003 11:40:45 +0000 (11:40 +0000)]
warning: ISO C does not allow extra ; outside of a function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9390 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdated to Dec 12 2003
jmayer [Sun, 21 Dec 2003 11:38:59 +0000 (11:38 +0000)]
Updated to Dec 12 2003

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9389 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agolibpcap.c:1777: warning: implicit declaration of function htons
jmayer [Sun, 21 Dec 2003 06:02:06 +0000 (06:02 +0000)]
libpcap.c:1777: warning: implicit declaration of function htons

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9388 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: ISO C does not allow extra ; outside of a function
jmayer [Sun, 21 Dec 2003 05:51:34 +0000 (05:51 +0000)]
warning: ISO C does not allow extra ; outside of a function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9387 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: ISO C does not allow extra ; outside of a function
jmayer [Sun, 21 Dec 2003 05:29:26 +0000 (05:29 +0000)]
warning: ISO C does not allow extra ; outside of a function

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9386 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: no newline at end of file
jmayer [Sun, 21 Dec 2003 04:40:14 +0000 (04:40 +0000)]
warning: no newline at end of file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9385 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agowarning: comma at end of enumerator list
jmayer [Sun, 21 Dec 2003 04:38:41 +0000 (04:38 +0000)]
warning: comma at end of enumerator list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9384 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompiling with -pedantic:
jmayer [Sun, 21 Dec 2003 04:31:58 +0000 (04:31 +0000)]
Compiling with -pedantic:
warning: comma at end of enumerator list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9383 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSoulSeek is not yet in
jmayer [Sun, 21 Dec 2003 04:27:04 +0000 (04:27 +0000)]
SoulSeek is not yet in

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9382 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoNo more FAQ.include
jmayer [Sun, 21 Dec 2003 04:25:57 +0000 (04:25 +0000)]
No more FAQ.include

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9381 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompiling with -pedantic:
jmayer [Sun, 21 Dec 2003 04:20:02 +0000 (04:20 +0000)]
Compiling with -pedantic:
packet-v5ua.c:1044:139: warning: C++ style comments are not allowed in ISO C90

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9380 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompiling with -pedantic:
jmayer [Sun, 21 Dec 2003 03:58:29 +0000 (03:58 +0000)]
Compiling with -pedantic:
packet-rmi.h:67: warning: comma at end of enumerator list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9379 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompiling with -pedantic:
jmayer [Sun, 21 Dec 2003 03:53:33 +0000 (03:53 +0000)]
Compiling with -pedantic:
moduleinfo.h:16:24: warning: no newline at end of file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9378 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompiling with -pedantic:
jmayer [Sun, 21 Dec 2003 03:48:27 +0000 (03:48 +0000)]
Compiling with -pedantic:
packet-irda.c:453:1: warning: C++ style comments are not allowed in ISO C90
packet-irda.c:453:1: warning: (this will be reported only once per input file)
(+ several more // disabling debug output)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9377 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompiling with -pendantic:
jmayer [Sun, 21 Dec 2003 03:44:00 +0000 (03:44 +0000)]
Compiling with -pendantic:
../../packet-giop.h:579: warning: comma at end of enumerator list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9376 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate FAQ to December 12 2003
jmayer [Sun, 21 Dec 2003 03:20:35 +0000 (03:20 +0000)]
Update FAQ to December 12 2003

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9375 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoThe include file is generated elsewhere
jmayer [Sun, 21 Dec 2003 03:17:54 +0000 (03:17 +0000)]
The include file is generated elsewhere

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9374 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoThe FAQ is now located in help/
jmayer [Sun, 21 Dec 2003 03:06:49 +0000 (03:06 +0000)]
The FAQ is now located in help/

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9373 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoManuf updates
jmayer [Sun, 21 Dec 2003 02:54:48 +0000 (02:54 +0000)]
Manuf updates

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9372 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved some MSVC warnings (added type casts)
ulfl [Sun, 21 Dec 2003 00:16:54 +0000 (00:16 +0000)]
removed some MSVC warnings (added type casts)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9371 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoremoved some MSVC warnings (added type casts)
ulfl [Sat, 20 Dec 2003 23:50:50 +0000 (23:50 +0000)]
removed some MSVC warnings (added type casts)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9370 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove display filter into filtered packets frame.
obiot [Sat, 20 Dec 2003 12:03:35 +0000 (12:03 +0000)]
Move display filter into filtered packets frame.

Fix NaN when a capture and/or a filter don't have any matching packets
so the average packet size is obtained by dividing by zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9369 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoNot all C compilers allow declarations in the middle of executable
guy [Sat, 20 Dec 2003 09:09:10 +0000 (09:09 +0000)]
Not all C compilers allow declarations in the middle of executable
code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9368 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDo the special "if the first fragment we see is also the final fragment,
guy [Sat, 20 Dec 2003 03:21:20 +0000 (03:21 +0000)]
Do the special "if the first fragment we see is also the final fragment,
treat it as a reassembled frame" hack *only* for 802.11, as that's the
only protocol we know of that requires it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9367 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Roland:
guy [Fri, 19 Dec 2003 23:41:55 +0000 (23:41 +0000)]
From Lars Roland:

use the common display filter dialog infrastructure in the MGCP
service response time tap;

add common infrastructure for updating the titles of tap dialogs
when the capture file name changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9366 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Roland: fix a typo.
guy [Fri, 19 Dec 2003 23:25:05 +0000 (23:25 +0000)]
From Lars Roland: fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9365 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom David Fort: support for decoding MLD v2 report messages.
guy [Fri, 19 Dec 2003 23:20:53 +0000 (23:20 +0000)]
From David Fort: support for decoding MLD v2 report messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9364 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom David Fort: update some comments now that RFC 3658 is out, and fix
guy [Fri, 19 Dec 2003 23:13:42 +0000 (23:13 +0000)]
From David Fort: update some comments now that RFC 3658 is out, and fix
a typo in the AUTHORS file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9363 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd an hf[] entry for the OPT_FRAG_OFF field of the OPT_FRAGMENT option
guy [Fri, 19 Dec 2003 22:46:16 +0000 (22:46 +0000)]
Add an hf[] entry for the OPT_FRAG_OFF field of the OPT_FRAGMENT option
(the hf_ variable for it existed, but there was no hf[] entry, so it
didn't get initialized).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9362 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't store the result of "tvb_reported_length()" into a "guint8" - it
guy [Fri, 19 Dec 2003 22:31:40 +0000 (22:31 +0000)]
Don't store the result of "tvb_reported_length()" into a "guint8" - it
could be more than 255 (even if that "shouldn't happen").

Don't use "frags != 0" as an indication that the message was fragmented
- that can't handle bogus packets with a zero fragment count.  Have an
explicit variable for that.

Check that "sm_data_len" isn't 0 before attempting dissection or
reassembly.

Check that "frag" and "frags" aren't zero before attempting reassembly
(arguably, we should report both of those as errors).

Use "process_reassembled_data()" to do the bulk of the work for
reassembly - it handles the case where a "fragmented" packet has only
one fragment.  This fixes a crash that occurred when only the last
fragment was seen, although there's an underlying problem there, namely
that the hack tha "fragment_add_seq_check()" does to handle some
problems with some 802.11 captures causes it to consider a packet where
the first fragment seen is also the last fragment as a one-fragment
packet; we probably need to do that *only* for 802.11.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9361 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd some additional sanity checking.
guy [Fri, 19 Dec 2003 22:23:05 +0000 (22:23 +0000)]
Add some additional sanity checking.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9360 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd debug logging to the MMSE dissector.
obiot [Fri, 19 Dec 2003 20:26:59 +0000 (20:26 +0000)]
Add debug logging to the MMSE dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9359 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd extra debug logging. Fix typo in debug log explanation.
obiot [Fri, 19 Dec 2003 20:16:04 +0000 (20:16 +0000)]
Add extra debug logging. Fix typo in debug log explanation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9358 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Peter Fales: count IPX-over-ARCNET packets in "capture_arcnet()".
guy [Fri, 19 Dec 2003 19:09:49 +0000 (19:09 +0000)]
From Peter Fales: count IPX-over-ARCNET packets in "capture_arcnet()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9357 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoNote that "uchar", "u_char", "u_short", "u_int", and "u_long" are also
guy [Fri, 19 Dec 2003 19:08:00 +0000 (19:08 +0000)]
Note that "uchar", "u_char", "u_short", "u_int", and "u_long" are also
forbidden.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9356 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't use "u_char", use "guchar" for characters and "guint8" for 8-bit
guy [Fri, 19 Dec 2003 19:03:13 +0000 (19:03 +0000)]
Don't use "u_char", use "guchar" for characters and "guint8" for 8-bit
unsigned integers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9355 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRemove \n from value-strings.
gram [Fri, 19 Dec 2003 16:42:27 +0000 (16:42 +0000)]
Remove \n from value-strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9354 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPrint values for ANY_MATCHES and ANY_CONTAINS so that the dftest
gram [Fri, 19 Dec 2003 04:40:24 +0000 (04:40 +0000)]
Print values for ANY_MATCHES and ANY_CONTAINS so that the dftest
executable works properly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9353 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe GNU ADNS library requires whatever libraries are needed for socket
guy [Fri, 19 Dec 2003 01:36:01 +0000 (01:36 +0000)]
The GNU ADNS library requires whatever libraries are needed for socket
calls.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9352 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAs noted by Peter Fales, the offset in "capture_arcnet()" should be 4 if
guy [Fri, 19 Dec 2003 01:24:09 +0000 (01:24 +0000)]
As noted by Peter Fales, the offset in "capture_arcnet()" should be 4 if
the extra offset field is present and 2 if it's absent, not the other
way around.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9351 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support for a link-layer type value of 143 as DOCSIS in libpcap
guy [Thu, 18 Dec 2003 23:50:44 +0000 (23:50 +0000)]
Add support for a link-layer type value of 143 as DOCSIS in libpcap
captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9350 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTop-of-tree and top-of-0.8-branch libpcap support limited filtering on
guy [Thu, 18 Dec 2003 21:18:34 +0000 (21:18 +0000)]
Top-of-tree and top-of-0.8-branch libpcap support limited filtering on
DLT_LINUX_IRDA (empty expression and "link[M:N]" expressions), so don't
special-case IRDA adapters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9349 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoA small patch from Kai Krueger <kai@kruegernetz.de> to ensure that we
sharpe [Thu, 18 Dec 2003 20:36:45 +0000 (20:36 +0000)]
A small patch from Kai Krueger <kai@kruegernetz.de> to ensure that we
keep the file name around long enough to use it when saving highlighted
data etc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9348 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd more files.
guy [Thu, 18 Dec 2003 20:35:40 +0000 (20:35 +0000)]
Add more files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9347 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jan Kiszka: add a comment explaining what the IrDA plugin does.
guy [Thu, 18 Dec 2003 20:34:43 +0000 (20:34 +0000)]
From Jan Kiszka: add a comment explaining what the IrDA plugin does.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9346 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jan Kiszka: IrDA support.
guy [Thu, 18 Dec 2003 19:07:14 +0000 (19:07 +0000)]
From Jan Kiszka: IrDA support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9345 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Ronnie Sahlberg: if the GSSAPI token is empty, don't dissect it.
guy [Thu, 18 Dec 2003 18:18:50 +0000 (18:18 +0000)]
From Ronnie Sahlberg: if the GSSAPI token is empty, don't dissect it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9344 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd support of the "matches" operator to FT_BYTES and FT_ETHER. I don't think
obiot [Thu, 18 Dec 2003 13:02:19 +0000 (13:02 +0000)]
Add support of the "matches" operator to FT_BYTES and FT_ETHER. I don't think
it would make sense to add PCRE support for byte arrays containing an integer
or an IP address.

Avoid lengthy pointer constructs in cmp_matches().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9343 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWildPackets' EtherHelp appears to write EtherPeek-compatible files,
guy [Thu, 18 Dec 2003 03:43:40 +0000 (03:43 +0000)]
WildPackets' EtherHelp appears to write EtherPeek-compatible files,
except that the 0x80 bit is turned on in the file version number field.
Turn that bit off before processing that field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9342 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago"pcap_compile_nopcap()" has a different signature in recent NetBSD
guy [Thu, 18 Dec 2003 02:46:45 +0000 (02:46 +0000)]
"pcap_compile_nopcap()" has a different signature in recent NetBSD
libpcap than in tcpdump.org libpcap; it's been deprecated for that
reason.  "pcap_open_dead()" has been in libpcap since 0.6, so only for
0.5[.x] will you have "pcap_compile_nopcap()" but not "pcap_open_dead()"
- for now, we use "pcap_open_dead()" rather than
"pcap_compile_nopcap()", and don't do the check for capture filters in
systems with libpcaps that lack "pcap_open_dead()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9341 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMallocate buffers for the strings gotten by "get_encoded_strval()" and
guy [Thu, 18 Dec 2003 02:07:26 +0000 (02:07 +0000)]
Mallocate buffers for the strings gotten by "get_encoded_strval()" and
"get_encoded_strval()", rather than filling in a fixed-size buffer, so
that we don't overflow the buffer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9340 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix some typoes.
guy [Thu, 18 Dec 2003 01:47:42 +0000 (01:47 +0000)]
Fix some typoes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9339 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake packet offsets, and lengths, "guint".
guy [Thu, 18 Dec 2003 00:43:48 +0000 (00:43 +0000)]
Make packet offsets, and lengths, "guint".

Put in some sanity checking to make sure we don't go completely crazy if
an offset goes past the length (we should check as the offset is
advanced, but...).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9338 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake "ctlfn" a "guint8", as it holds a single-byte value.
guy [Thu, 18 Dec 2003 00:28:39 +0000 (00:28 +0000)]
Make "ctlfn" a "guint8", as it holds a single-byte value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9337 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUse a value_string table for the Status field.
guy [Thu, 18 Dec 2003 00:25:24 +0000 (00:25 +0000)]
Use a value_string table for the Status field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9336 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe "cmd" members of "smb_saved_info_t" and "smb_info_t" structures
guy [Thu, 18 Dec 2003 00:18:55 +0000 (00:18 +0000)]
The "cmd" members of "smb_saved_info_t" and "smb_info_t" structures
always contain an SMB command code (SMB requests and responses both have
command codes, so there's no "unknown" out-of-band value); make it a
"guint8".

Make the argument to "decode_smb_name()" a "guint8" as an SMB command
code is passed to it ("guint8" and "unsigned char" are the same types on
all platforms we're likely to deal with, so it's a cosmetic change, not
a semantic one).

Put in an extra "GPOINTER_TO_UINT()" call before casting
"si->sip->extra_info" to "guint16", to squelch compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9335 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake packet offsets "gint"s rather than "guint8"s.
guy [Wed, 17 Dec 2003 23:54:44 +0000 (23:54 +0000)]
Make packet offsets "gint"s rather than "guint8"s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9334 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved some more MSVC warnings (type casting), GTK2 specific
ulfl [Wed, 17 Dec 2003 23:41:10 +0000 (23:41 +0000)]
removed some more MSVC warnings (type casting), GTK2 specific

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9333 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved some more MSVC warnings (type casting)
ulfl [Wed, 17 Dec 2003 23:35:29 +0000 (23:35 +0000)]
removed some more MSVC warnings (type casting)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9332 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate the "matches" explanation as it now also works for protocol fields
obiot [Wed, 17 Dec 2003 23:24:49 +0000 (23:24 +0000)]
Update the "matches" explanation as it now also works for protocol fields
(FT_TVBUFF). Thanks libpcre for allowing pattern matching in binary data!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9331 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of unused registered header fields. Some white-space changes.
obiot [Wed, 17 Dec 2003 22:43:21 +0000 (22:43 +0000)]
Get rid of unused registered header fields. Some white-space changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9330 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd protocols to the header fields for which the "matches" operator can be
obiot [Wed, 17 Dec 2003 22:42:02 +0000 (22:42 +0000)]
Add protocols to the header fields for which the "matches" operator can be
appliedi (PCRE). In fact, all FT_TVBUFF fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9329 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOnly dissect the key in TKEY RRs if it's present (i.e., has a non-zero
guy [Wed, 17 Dec 2003 22:30:42 +0000 (22:30 +0000)]
Only dissect the key in TKEY RRs if it's present (i.e., has a non-zero
length) - zero-length keys "shouldn't happen", but what the heck....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9328 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Lars Roland: have common code to handle display filter dialogs in
guy [Wed, 17 Dec 2003 22:13:08 +0000 (22:13 +0000)]
From Lars Roland: have common code to handle display filter dialogs in
taps, and use that in the H.225 taps.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9327 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved some more MSVC warnings (type casting)
ulfl [Wed, 17 Dec 2003 22:11:43 +0000 (22:11 +0000)]
removed some more MSVC warnings (type casting)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9326 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agorenamed some defines SERVICE_xy to SVCCTL_SERVICE_xy to avoid
ulfl [Wed, 17 Dec 2003 21:34:44 +0000 (21:34 +0000)]
renamed some defines SERVICE_xy to SVCCTL_SERVICE_xy to avoid
"duplicate definition" warnings with win32's winsvc.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9325 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSet "print_args" regardless of whether we're printing the packet detail
guy [Wed, 17 Dec 2003 21:11:25 +0000 (21:11 +0000)]
Set "print_args" regardless of whether we're printing the packet detail
or not - it's used if we're printing the hex data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9324 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Anders Broman: add a preference setting for the RTSP TCP port.
guy [Wed, 17 Dec 2003 21:03:15 +0000 (21:03 +0000)]
From Anders Broman: add a preference setting for the RTSP TCP port.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9323 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThere's no need for the "content_type_exist" variable - we can just
guy [Wed, 17 Dec 2003 20:52:38 +0000 (20:52 +0000)]
There's no need for the "content_type_exist" variable - we can just
check whether "media_type_str" is null.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9322 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Anders Broman:
guy [Wed, 17 Dec 2003 20:39:31 +0000 (20:39 +0000)]
From Anders Broman:

check that there *is* a content type string before using it;

get rid of some incomplete code for multipart/mixed (it set some
variables but didn't use them);

add some incomplete code for handling parameters to Content-Type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9321 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of an unused value_string table and unused #defines.
guy [Wed, 17 Dec 2003 20:30:56 +0000 (20:30 +0000)]
Get rid of an unused value_string table and unused #defines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9320 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoremoved some MSVC warnings (casting gdouble to gint, which is ok)
ulfl [Wed, 17 Dec 2003 20:28:49 +0000 (20:28 +0000)]
removed some MSVC warnings (casting gdouble to gint, which is ok)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9319 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoadded missing rule for v5ua plugin
ulfl [Wed, 17 Dec 2003 18:05:27 +0000 (18:05 +0000)]
added missing rule for v5ua plugin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9318 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFor unknown key IDs, show the algorithm symbolically if possible.
guy [Wed, 17 Dec 2003 08:59:15 +0000 (08:59 +0000)]
For unknown key IDs, show the algorithm symbolically if possible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9317 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate a comment.
guy [Wed, 17 Dec 2003 08:51:36 +0000 (08:51 +0000)]
Update a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9316 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGive the key and other lengths and data names that match the names in
guy [Wed, 17 Dec 2003 08:40:56 +0000 (08:40 +0000)]
Give the key and other lengths and data names that match the names in
RFC 2930.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9315 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPut the key and other lengths into the protocol tree for TKEY RRs.
guy [Wed, 17 Dec 2003 08:34:07 +0000 (08:34 +0000)]
Put the key and other lengths into the protocol tree for TKEY RRs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9314 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoPass "attr_info" to "rd_value_to_str()" - don't look it up again in
guy [Wed, 17 Dec 2003 07:05:22 +0000 (07:05 +0000)]
Pass "attr_info" to "rd_value_to_str()" - don't look it up again in
"rd_value_to_str()".

Handle a null return from "find_radius_attr_info()".

We don't have to reserve a value type of 0 for "not found in the table"
- a null return from "find_radius_attr_info()" indicates that.

Hoist the code to make the top-level item for an AVP above the check for
an EAP message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9313 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake Makefile.am and Makefile.nmake match those for other plugins.
guy [Wed, 17 Dec 2003 07:02:12 +0000 (07:02 +0000)]
Make Makefile.am and Makefile.nmake match those for other plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9312 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Christoph Neusch: V5UA support.
guy [Wed, 17 Dec 2003 05:16:21 +0000 (05:16 +0000)]
From Christoph Neusch: V5UA support.

From Anders Broman: patches to various makefiles and configure scripts
to build the V5UA dissector, and patches to make it compile.

From me: .cvsignore file, and NSIS patches.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9311 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix more "CPPLAGS" typoes.
guy [Wed, 17 Dec 2003 02:41:04 +0000 (02:41 +0000)]
Fix more "CPPLAGS" typoes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9310 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Albert Chin: fix for the following:
guy [Wed, 17 Dec 2003 02:36:56 +0000 (02:36 +0000)]
From Albert Chin: fix for the following:

The PCRE test in acinclude.m4 and epan/acinclude.m4 don't work
if PCRE exists in a non-system directory.  The problem is that
LDFLAGS and LIBS are set incorrectly.  LIBS shouldn't contain -L
arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9309 f5534014-38df-0310-8fa8-9805f1628bb7