obnox/wireshark/wip.git
11 years agotranslate some german to english
ulfl [Sun, 9 Sep 2007 14:58:02 +0000 (14:58 +0000)]
translate some german to english

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22832 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agostart an experiment to provide MS Visual Studio 2005 solution / project files for...
ulfl [Sun, 9 Sep 2007 13:59:58 +0000 (13:59 +0000)]
start an experiment to provide MS Visual Studio 2005 solution / project files for a lot easier debugging. They still use the underlying Makefile.nmake files for the actual build process.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22831 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agodon't try to put a ## comment after the touch call, this will end up in a few strange...
ulfl [Sun, 9 Sep 2007 13:09:14 +0000 (13:09 +0000)]
don't try to put a ## comment after the touch call, this will end up in a few strange new files generated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22830 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoremove unused #else
ulfl [Sun, 9 Sep 2007 13:05:32 +0000 (13:05 +0000)]
remove unused #else

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22829 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago- Slightly improved dissection of Cisco's fragmented ISAKMP.
jmayer [Sat, 8 Sep 2007 13:22:27 +0000 (13:22 +0000)]
- Slightly improved dissection of Cisco's fragmented ISAKMP.
- Corrected misdetection of CISCO-UNITY VID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22828 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange the long protocol name dissectors for various DFS protocols to
guy [Fri, 7 Sep 2007 22:11:01 +0000 (22:11 +0000)]
Change the long protocol name dissectors for various DFS protocols to
indicate that they're for DFS; update comments as well.

Rename packet-dcerpc-afs4int.c to packet-dcerpc-fileexp.c, and change
the short and filter names for the protocol, and the names for the
filterable fields, to reflect the fact that it's for the File Exporter
protocol in DFS.  ("AFS 4" = DCE DFS.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22827 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIf the whole packet was not captured (e.g., due to the snapshot length), do not attem...
morriss [Fri, 7 Sep 2007 21:46:31 +0000 (21:46 +0000)]
If the whole packet was not captured (e.g., due to the snapshot length), do not attempt to verify the checksum of the packet.  Rather, inform the user that we didn't/couldn't verify the checksum.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22826 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Todd J Martin:
stig [Fri, 7 Sep 2007 19:05:55 +0000 (19:05 +0000)]
From Todd J Martin:
The attached patch to packet-bfd.c adds the following enhancements to BFD
decoding:
- The Authentication Section is now decoded.  All of the authentication methods
are supported.  Verification of checksums is not implemented.
- BFD flags are now shown in a tree
- Added support for the M flag
- Added a display filter for the message length
- For the Desired Min TX Interval, Required Min RX Interval, and Required Min
Echo RX Interval fields, the time value is now printed in both milliseconds and
microseconds.  (Previously, only milliseconds was being shown.)  The PDU
represents the time in microseconds, but most implementations deal in
milliseconds.
- Added a warning to flag the packet if the Authentication bit is set, but the
full Authentication Section is not present.
- Added descriptions for most of the fields
- Fix the name of the protocol.  BFD stands for Bidirectional Forwarding
Detection and not Bi-directional Fault Detection.
- Register the protocol on the UDP multihop port (4784).
- Change the filter name for the protocol from bfdcontrol to bfd since all of
the other display filters started with bfd.

Removed unused hf_bfd_auth_checksum.
Modified printing of the ':' at the end of the Authentication tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22825 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoReplace remaining non-printable characters that looked like spaces with real spaces.
martinm [Fri, 7 Sep 2007 15:58:24 +0000 (15:58 +0000)]
Replace remaining non-printable characters that looked like spaces with real spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22824 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCrap - missed this one!
martinm [Fri, 7 Sep 2007 15:24:43 +0000 (15:24 +0000)]
Crap - missed this one!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22823 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoArgh! Used the wrong length modifier for size_t.
stig [Fri, 7 Sep 2007 15:21:08 +0000 (15:21 +0000)]
Argh!  Used the wrong length modifier for size_t.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22822 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHm. Not so clean on all compilers...
stig [Fri, 7 Sep 2007 15:04:31 +0000 (15:04 +0000)]
Hm.  Not so clean on all compilers...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22821 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed compiler warnings.
stig [Fri, 7 Sep 2007 14:02:32 +0000 (14:02 +0000)]
Fixed compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22820 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoSmall cleanup:
martinm [Fri, 7 Sep 2007 13:53:49 +0000 (13:53 +0000)]
Small cleanup:
- remove unprintable chars (pasted from formatted spec doc?)
- use _U_ for unsused function argument
- remove accidental(?) assignment in function parameter
- make indentation consistent by removing the (few) tabs in the file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22819 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoTry Stephen Croll's workaround.
martinm [Fri, 7 Sep 2007 09:56:19 +0000 (09:56 +0000)]
Try Stephen Croll's workaround.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22818 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMoved packet-imf.c and packet-tnef.c from ASN_DISSECTOR_SRC to CLEAN_DISSECTOR_SRC...
stig [Thu, 6 Sep 2007 23:32:46 +0000 (23:32 +0000)]
Moved packet-imf.c and packet-tnef.c from ASN_DISSECTOR_SRC to CLEAN_DISSECTOR_SRC, as they are not generated from ASN1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22817 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCorrected some types, instead of adding a cast (from r21142).
stig [Thu, 6 Sep 2007 22:29:04 +0000 (22:29 +0000)]
Corrected some types, instead of adding a cast (from r21142).
Reindented file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22816 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed a warning: 'j' may be used uninitialized in this function.
stig [Thu, 6 Sep 2007 22:26:09 +0000 (22:26 +0000)]
Fixed a warning: 'j' may be used uninitialized in this function.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22815 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCount the number of TSNs gap-acked in a SACK. Warn the user (with an Expert info...
morriss [Thu, 6 Sep 2007 21:57:56 +0000 (21:57 +0000)]
Count the number of TSNs gap-acked in a SACK.  Warn the user (with an Expert info) if the number is greater than, say, 100.  Also reindent large portions of the sack dissector function to make it readable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22814 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange it back...
etxrab [Thu, 6 Sep 2007 21:33:57 +0000 (21:33 +0000)]
Change it back...
Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22813 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd A11 RRQ-CVSE-Active Start Airlink Record-Subtype 108 is expressed to Subnet.
etxrab [Thu, 6 Sep 2007 21:25:41 +0000 (21:25 +0000)]
Add A11 RRQ-CVSE-Active Start Airlink Record-Subtype 108 is expressed to Subnet.

Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22812 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix problems found by Beyond Security:
gerald [Thu, 6 Sep 2007 18:26:04 +0000 (18:26 +0000)]
Fix problems found by Beyond Security:

Instead of overflowing an unsigned int when determining the number of
items in a range, use a signed int and check for a negative value.  Make
sure our offset increments as we step through each item.  This should
avoid large/inifinite loops.

Fix the size of hf_dnp3_al_range_stop32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22811 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix a comment.
guy [Thu, 6 Sep 2007 16:57:41 +0000 (16:57 +0000)]
Fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22810 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd .c.obj:: inference rule (to cause "batch compile")
guy [Thu, 6 Sep 2007 16:55:03 +0000 (16:55 +0000)]
Add .c.obj:: inference rule (to cause "batch compile")

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22809 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemove debug code and a "lost" line.
etxrab [Thu, 6 Sep 2007 16:28:08 +0000 (16:28 +0000)]
Remove debug code and a "lost" line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22808 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of get_ber_last_reated_item() and fix dissection of wIN-TriggerList.
etxrab [Thu, 6 Sep 2007 16:27:17 +0000 (16:27 +0000)]
Get rid of get_ber_last_reated_item() and fix dissection of wIN-TriggerList.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22807 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix the unsigned errors. Not sure about the other windows errors yet...
martinm [Thu, 6 Sep 2007 14:14:09 +0000 (14:14 +0000)]
Fix the unsigned errors. Not sure about the other windows errors yet...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22806 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded ipprotostr to libwireshark.def
stig [Thu, 6 Sep 2007 14:02:35 +0000 (14:02 +0000)]
Added ipprotostr to libwireshark.def

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22805 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoEnable esc key for SCTP Associations window.
wmeier [Thu, 6 Sep 2007 12:46:29 +0000 (12:46 +0000)]
Enable esc key for SCTP Associations window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22804 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd default svn:ignore files to wimaxasncp plugin.
stig [Thu, 6 Sep 2007 10:53:42 +0000 (10:53 +0000)]
Add default svn:ignore files to wimaxasncp plugin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22803 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoMap "wimax" -> "wimaxasncp"
martinm [Thu, 6 Sep 2007 10:50:17 +0000 (10:50 +0000)]
Map "wimax" -> "wimaxasncp"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22802 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoBuild WiMAX ASN Control Plane dissector plugin
martinm [Thu, 6 Sep 2007 10:14:49 +0000 (10:14 +0000)]
Build WiMAX ASN Control Plane dissector plugin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22801 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd wimaxasncp plugin folder contents (other changes will follow)
martinm [Thu, 6 Sep 2007 10:05:41 +0000 (10:05 +0000)]
Add wimaxasncp plugin folder contents (other changes will follow)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22800 f5534014-38df-0310-8fa8-9805f1628bb7

11 years ago- "quote" source dir of packaging_zip1 and packaging_zip2, so it also works with...
ulfl [Wed, 5 Sep 2007 23:09:39 +0000 (23:09 +0000)]
- "quote" source dir of packaging_zip1 and packaging_zip2, so it also works with spaces in this path

- epan now depends on zlib and wiretap, add dependencies accordingly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22799 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoremove comment which compiler version works - they all work
ulfl [Wed, 5 Sep 2007 23:03:58 +0000 (23:03 +0000)]
remove comment which compiler version works - they all work

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22798 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix indentation.
guy [Wed, 5 Sep 2007 22:43:51 +0000 (22:43 +0000)]
Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22797 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix the asn1 code for WIN-TriggerList and systemMyTypeCode plus
etxrab [Wed, 5 Sep 2007 22:24:40 +0000 (22:24 +0000)]
Fix the asn1 code for WIN-TriggerList and systemMyTypeCode plus
a copy-paste error in the hf fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22796 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoPrevent Gtk-Critical msg when invoking "+Expression" from Filter Toolbar in main...
wmeier [Wed, 5 Sep 2007 14:59:37 +0000 (14:59 +0000)]
Prevent Gtk-Critical msg when invoking "+Expression" from Filter Toolbar in main window;
Fixes bug reported by Toralf Förster

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22795 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCheck object_identifier_id before use.
stig [Wed, 5 Sep 2007 07:35:59 +0000 (07:35 +0000)]
Check object_identifier_id before use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22794 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Munenori Ohuchi:
jake [Wed, 5 Sep 2007 06:59:24 +0000 (06:59 +0000)]
From Munenori Ohuchi:
packet-netflow.c is lack of the capability to decode ipv6 address related fields in netflow v9.

This patch enables dissecting the following fields:
 Type 27 IPV6_SRC_ADDR,
 Type 28 IPV6_DST_ADDR,
 Type 29 IPV6_SRC_MASK,
 Type 30 IPV6_DST_MASK and
 Type 62 IPV6_NEXT_HOP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22793 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoInclude expert.h and while at it change to use -X and -T options for asn2wrs.
etxrab [Wed, 5 Sep 2007 05:48:44 +0000 (05:48 +0000)]
Include expert.h and while at it change to use -X and -T options for asn2wrs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22792 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agostart prettifying nfsv4
sahlberg [Wed, 5 Sep 2007 00:29:31 +0000 (00:29 +0000)]
start prettifying nfsv4

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22791 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoon unix, we dont have size_t until we have imported all the other
sahlberg [Tue, 4 Sep 2007 23:35:29 +0000 (23:35 +0000)]
on unix, we dont have size_t until we have imported all the other
includes    which breaks emem.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22790 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agowe dont have g_hash_table_new_full() on gtk1
sahlberg [Tue, 4 Sep 2007 23:27:34 +0000 (23:27 +0000)]
we dont have g_hash_table_new_full() on gtk1
use g_hash_table_new() on gtk1 and leak memory instead

this should actually a be using an se_tree instead of hashtables

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22789 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoDon't call get_interface_descriptive_name() on a NULL iface: fixes a segfault when...
morriss [Tue, 4 Sep 2007 22:13:26 +0000 (22:13 +0000)]
Don't call get_interface_descriptive_name() on a NULL iface: fixes a segfault when doing Statistics->Summary when you didn't capture anything (but rather read in a file)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22788 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed compiler warnings to get the buildbot going.
stig [Tue, 4 Sep 2007 21:49:14 +0000 (21:49 +0000)]
Fixed compiler warnings to get the buildbot going.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22787 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRewrote handling of parameters to get rid of "funky" oid strings.
stig [Tue, 4 Sep 2007 21:46:41 +0000 (21:46 +0000)]
Rewrote handling of parameters to get rid of "funky" oid strings.
Added expert info for unknown binding-parameters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22786 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agovalue_tvb=out_tvb, remove unused variables.
etxrab [Tue, 4 Sep 2007 19:36:07 +0000 (19:36 +0000)]
value_tvb=out_tvb, remove unused variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22785 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet correct value for bitstrings.
etxrab [Tue, 4 Sep 2007 16:57:07 +0000 (16:57 +0000)]
Get correct value for bitstrings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22784 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoANSI MAP systemMyTypeCode should be OPTIONAL
etxrab [Tue, 4 Sep 2007 16:55:48 +0000 (16:55 +0000)]
ANSI MAP systemMyTypeCode should be OPTIONAL
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1820

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22783 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoenable esc for new/edit/delete dialogs; remove some redundant code;
wmeier [Tue, 4 Sep 2007 12:37:19 +0000 (12:37 +0000)]
enable esc for new/edit/delete dialogs; remove some redundant code;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22782 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Munenori Ohuchi:
jake [Tue, 4 Sep 2007 06:55:52 +0000 (06:55 +0000)]
From Munenori Ohuchi:
This patch adds a new feature to dissect HSRPv2 packets.

One of the main features of HSRPv2 can enable using HSRP on IPv6. In order to
achieve this new feature, HSRPv2 packet format is totally different from
HSRPv1. HSRPv2 introduces new TLV formats.

This patch can decode these new formats of HSPRv2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22781 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Stas Maximov:
etxrab [Tue, 4 Sep 2007 05:22:43 +0000 (05:22 +0000)]
From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22780 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWireshark packet-gtp.c error in decoding IMEI.
etxrab [Mon, 3 Sep 2007 16:42:28 +0000 (16:42 +0000)]
Wireshark packet-gtp.c error in decoding IMEI.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1536

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22779 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIncorrectly decoded IMSI in RANAP prot./id-CommonID procedure
etxrab [Mon, 3 Sep 2007 16:40:51 +0000 (16:40 +0000)]
Incorrectly decoded IMSI in RANAP prot./id-CommonID procedure
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1713

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22778 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoBSSGP.TLLI is not recognized properly in filter
etxrab [Mon, 3 Sep 2007 16:39:07 +0000 (16:39 +0000)]
BSSGP.TLLI is not recognized properly in filter
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22777 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoguint8, not gchar, is the appropriate type for a byte.
guy [Mon, 3 Sep 2007 06:44:54 +0000 (06:44 +0000)]
guint8, not gchar, is the appropriate type for a byte.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22776 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 1816:
jake [Mon, 3 Sep 2007 05:56:48 +0000 (05:56 +0000)]
Fix for bug 1816:
Add status value to LSSU info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22775 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agodefault window_cancel_butoon_cb is not appropriate since a specific cancel cb is...
wmeier [Mon, 3 Sep 2007 00:17:47 +0000 (00:17 +0000)]
default window_cancel_butoon_cb  is not appropriate since a specific cancel cb is specified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22774 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agotvb_reported_length() returns a gint, so assign its value to a gint.
guy [Sun, 2 Sep 2007 23:51:51 +0000 (23:51 +0000)]
tvb_reported_length() returns a gint, so assign its value to a gint.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22773 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix my previous patch to enable esc on window
wmeier [Sun, 2 Sep 2007 23:37:40 +0000 (23:37 +0000)]
Fix my previous patch to enable esc on window

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22772 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFor bug 1685, check for the errors reported on at least some platforms
guy [Sun, 2 Sep 2007 23:32:43 +0000 (23:32 +0000)]
For bug 1685, check for the errors reported on at least some platforms
when an interface goes down or goes away, and, in that case, just report
that, rather than reporting a more technical error and indicating that
the error should be reported to the Wireshark developers.

Line-break the "please report this to the Wireshark developers" error
differently (so that it doesn't look weird if the dialog box line-wraps
it).

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22771 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThe actual length of the PPPoE payload is returned by
guy [Sun, 2 Sep 2007 22:49:56 +0000 (22:49 +0000)]
The actual length of the PPPoE payload is returned by
tvb_reported_length_remaining(), not by tvb_length_remaining() -
tvb_length_remaining() shows only the amount of *captured* data
remaining, but the capture might have been done with a snapshot length
that cut the packet data short.

The payload length from the PPPoE header could legitimately be different
from the actual length of the PPPoE payload if there's not enough PPPoE
payload to avoid padding at the E(thernet) level.  Only complain if
there shouldn't have been any padding.

Report an "expert" warning if the payload length looks wrong.

Update a comment to reflect current reality (as of many many years ago,
when we went all-tvbuff).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22770 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoVerify existence of required downloaded library packages during make after Makefile...
wmeier [Sun, 2 Sep 2007 20:53:15 +0000 (20:53 +0000)]
Verify existence of required downloaded library packages during make after Makefile.nmake updated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22769 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix indentation.
guy [Sun, 2 Sep 2007 20:37:39 +0000 (20:37 +0000)]
Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22768 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agomacro_name_chk: return valid error string for fail return when empty macro name field;
wmeier [Sun, 2 Sep 2007 12:37:24 +0000 (12:37 +0000)]
macro_name_chk: return valid error string for fail return when empty macro name field;
fixes bug #1813

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22767 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Steve Karg:
jake [Sat, 1 Sep 2007 11:47:59 +0000 (11:47 +0000)]
From Steve Karg:
Fix for bug 1807. This patch corrects the decoding of the NotificationParameters.
I fuzz tested with these and other captures (Pass > 100).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22766 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThis patch solves two issue with the NetScreen wiretap routine:
sake [Sat, 1 Sep 2007 11:14:01 +0000 (11:14 +0000)]
This patch solves two issue with the NetScreen wiretap routine:
- It accepts the "/" character in interface names
- It accepts EOF as delimiter for the last packet (when there is no more emptyline)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22765 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoShow unsigned quantities with %u, not %d.
guy [Fri, 31 Aug 2007 23:56:07 +0000 (23:56 +0000)]
Show unsigned quantities with %u, not %d.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22764 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoEnable <esc> to cancel window; remove some redundant code
wmeier [Fri, 31 Aug 2007 23:22:45 +0000 (23:22 +0000)]
Enable <esc> to cancel window; remove some redundant code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22763 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoWhen doing TCP_SEQ analysis, if the packet is a SYN, then it's
sake [Fri, 31 Aug 2007 15:06:27 +0000 (15:06 +0000)]
When doing TCP_SEQ analysis, if the packet is a SYN, then it's
not a lost packet but the tcp ports are being reused. This is often
seen in load-balanced environments where client ports are preserved
on the server-side.

We only want to report port reusage once, so the SYN/ACK is excluded
from TCP_SEQ analysis.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22762 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoThis patch fixes the following two errors that appear when
sake [Fri, 31 Aug 2007 14:14:17 +0000 (14:14 +0000)]
This patch fixes the following two errors that appear when
configure is run with "--without-plugins"

cc1: warnings being treated as errors
about_dlg.c: In function ‘about_wireshark_cb’:
about_dlg.c:426: warning: unused variable ‘plugins_page’
make[2]: *** [about_dlg.o] Error 1

editcap.c: In function ‘main’:
editcap.c:663: error: ‘check_ts’ undeclared (first use in this function)
editcap.c:663: error: (Each undeclared identifier is reported only once
editcap.c:663: error: for each function it appears in.)
make[2]: *** [editcap.o] Error 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22761 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix for bug 1244:
jake [Fri, 31 Aug 2007 05:37:43 +0000 (05:37 +0000)]
Fix for bug 1244:
hf_isup_event_ind contains incorrect fieldbase.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22760 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofix length calculation for 802.11 packets - the 802.11 dissector will strip off the...
ulfl [Thu, 30 Aug 2007 19:50:56 +0000 (19:50 +0000)]
fix length calculation for 802.11 packets - the 802.11 dissector will strip off the 4 byte FCS at the end of a packet (while the Ethernet dissector does not).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22759 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agofix dissect_per_bit_string() for unaligned PER, values ar still not correctly displayed.
etxrab [Thu, 30 Aug 2007 19:44:22 +0000 (19:44 +0000)]
fix dissect_per_bit_string() for unaligned PER, values ar still not correctly displayed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22758 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoClean up "setuid-root.pl" when we do "make distclean".
guy [Thu, 30 Aug 2007 19:34:20 +0000 (19:34 +0000)]
Clean up "setuid-root.pl" when we do "make distclean".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22757 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded capture_wlancap to libwireshark.def
stig [Thu, 30 Aug 2007 19:11:36 +0000 (19:11 +0000)]
Added capture_wlancap to libwireshark.def

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22756 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoIt seems like capture_stats is working as a correctly implemented pcap_stats.
stig [Thu, 30 Aug 2007 17:36:38 +0000 (17:36 +0000)]
It seems like capture_stats is working as a correctly implemented pcap_stats.
Update the Packets count in Capture Interfaces according to this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22755 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoHuh. Fetch setuid-root.pl.in from srcdir instead.
stig [Thu, 30 Aug 2007 15:44:59 +0000 (15:44 +0000)]
Huh.  Fetch setuid-root.pl.in from srcdir instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22754 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded setuid-root.pl.in to EXSTRA_DIST
stig [Thu, 30 Aug 2007 12:06:18 +0000 (12:06 +0000)]
Added setuid-root.pl.in to EXSTRA_DIST

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22753 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAnd include packet-wlancap.h
stig [Thu, 30 Aug 2007 11:52:30 +0000 (11:52 +0000)]
And include packet-wlancap.h

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22752 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed a brace placement to enable the default case
stig [Thu, 30 Aug 2007 11:37:49 +0000 (11:37 +0000)]
Fixed a brace placement to enable the default case

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22751 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoCount IEEE 802.11 WLAN AVS packets.
stig [Thu, 30 Aug 2007 11:28:27 +0000 (11:28 +0000)]
Count IEEE 802.11 WLAN AVS packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22750 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoTest to see if packet is actually a request by verifying the one byte function code...
gmorris [Thu, 30 Aug 2007 10:33:24 +0000 (10:33 +0000)]
Test to see if packet is actually a request by verifying the one byte function code is a non-zero value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22749 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoUpdate to reflect new iteration verb 0x6e.
gmorris [Thu, 30 Aug 2007 10:26:20 +0000 (10:26 +0000)]
Update to reflect new iteration verb 0x6e.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22748 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFix attribute *Print Checkpoint"
gmorris [Thu, 30 Aug 2007 10:23:58 +0000 (10:23 +0000)]
Fix attribute *Print Checkpoint"
Fix Printer State Reasons in extended error codes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22747 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd eDirectory iteration verb 0x6e.
gmorris [Thu, 30 Aug 2007 10:18:29 +0000 (10:18 +0000)]
Add eDirectory iteration verb 0x6e.
Fix eDirectory timestamps to display correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22746 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdded #include <sys/types.h>
stig [Thu, 30 Aug 2007 09:28:41 +0000 (09:28 +0000)]
Added #include <sys/types.h>

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22745 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFixed a typo: setuid-root.in -> setuid-root.pl.in
stig [Thu, 30 Aug 2007 08:50:05 +0000 (08:50 +0000)]
Fixed a typo: setuid-root.in -> setuid-root.pl.in
Added setuid-root.pl to svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22744 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Chris Maynard:
etxrab [Thu, 30 Aug 2007 05:30:28 +0000 (05:30 +0000)]
From Chris Maynard:
Incorrect display filter field naming convention.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22743 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Chris Maynard:
etxrab [Thu, 30 Aug 2007 05:22:25 +0000 (05:22 +0000)]
From Chris Maynard:
Incorrect display filter field naming convention.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22742 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Chris Maynard:
etxrab [Thu, 30 Aug 2007 05:05:45 +0000 (05:05 +0000)]
From Chris Maynard:
Incorrect display filter field naming convention.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22741 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Chris Maynard:
etxrab [Thu, 30 Aug 2007 05:02:33 +0000 (05:02 +0000)]
From Chris Maynard:
Incorrect display filter field naming convention.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22740 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Chris Maynard:
etxrab [Thu, 30 Aug 2007 04:58:11 +0000 (04:58 +0000)]
From Chris Maynard:
Incorrect display filter field naming convention.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22739 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoFrom Chris Maynard:
etxrab [Thu, 30 Aug 2007 04:49:04 +0000 (04:49 +0000)]
From Chris Maynard:
Incorrect display filter field naming convention.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22738 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoRemeove file not to be included.
etxrab [Thu, 30 Aug 2007 04:35:58 +0000 (04:35 +0000)]
Remeove file not to be  included.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22737 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoAdd the setuid script missing from my last checkin.
gerald [Thu, 30 Aug 2007 04:16:11 +0000 (04:16 +0000)]
Add the setuid script missing from my last checkin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22736 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoGet rid of tab after backslash, to eliminate warning.
guy [Thu, 30 Aug 2007 02:32:55 +0000 (02:32 +0000)]
Get rid of tab after backslash, to eliminate warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22735 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoupdate to latest draft:
ulfl [Thu, 30 Aug 2007 02:14:36 +0000 (02:14 +0000)]
update to latest draft:
- add PDSyncData block with Version 1.2
- add IOXBlockReq/s ids 0x116, 0x117, 0x8116 and 0x8117

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22734 f5534014-38df-0310-8fa8-9805f1628bb7

11 years agoChange the "--enable-setuid-install" option to install dumpcap and TShark
gerald [Thu, 30 Aug 2007 00:24:40 +0000 (00:24 +0000)]
Change the "--enable-setuid-install" option to install dumpcap and TShark
setuid instead of Wireshark.  Remove the "DANGEROUS" notices, but leave it
disabled by default.  Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining.  Add a "setuid-root" script that
can be used to switch dumpcap and TShark's setuid-ness on and off for
development and testing.  Update the release notes and README.packaging.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22733 f5534014-38df-0310-8fa8-9805f1628bb7