obnox/wireshark/wip.git
14 years agoAdd a few more optional compiler warnings and some (commented out)
jmayer [Sat, 7 Nov 2009 10:08:36 +0000 (10:08 +0000)]
Add a few more optional compiler warnings and some (commented out)
ideas for linker flags.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30853 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agocmake will now honor -Werror if configured (default: on)
jmayer [Sat, 7 Nov 2009 10:07:00 +0000 (10:07 +0000)]
cmake will now honor -Werror if configured (default: on)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30852 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAvoid possible NULL pointer dereference
krj [Sat, 7 Nov 2009 08:07:12 +0000 (08:07 +0000)]
Avoid possible NULL pointer dereference

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30851 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake more PNGs 90 DPI.
gerald [Sat, 7 Nov 2009 00:45:03 +0000 (00:45 +0000)]
Make more PNGs 90 DPI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30850 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake all of the PNGs 90 DPI.
gerald [Sat, 7 Nov 2009 00:40:04 +0000 (00:40 +0000)]
Make all of the PNGs 90 DPI.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30849 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a warning in a table (which results in an error in Fop 0.95). Reformat
gerald [Fri, 6 Nov 2009 23:57:01 +0000 (23:57 +0000)]
Fix a warning in a table (which results in an error in Fop 0.95). Reformat
it slightly while we're at it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30848 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4209:
dimeg [Fri, 6 Nov 2009 21:20:17 +0000 (21:20 +0000)]
Fix for bug 4209:
After reading a SysID group, current_offset was off by 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30847 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd some null pointer checks. This is a blind attempt to fix bug 4155.
gerald [Fri, 6 Nov 2009 18:08:59 +0000 (18:08 +0000)]
Add some null pointer checks. This is a blind attempt to fix bug 4155.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30846 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove packet-umts_mac.c from DISSECTOR_INCLUDES
krj [Fri, 6 Nov 2009 14:56:28 +0000 (14:56 +0000)]
Remove packet-umts_mac.c from DISSECTOR_INCLUDES

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30845 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a couple of more dissectors to the CMake based buildsystem
krj [Fri, 6 Nov 2009 14:56:19 +0000 (14:56 +0000)]
Add a couple of more dissectors to the CMake based buildsystem

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30844 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tobias Witek:
etxrab [Fri, 6 Nov 2009 12:09:12 +0000 (12:09 +0000)]
From Tobias Witek:
Enables correct RRC decoding from RLC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30843 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd parentheses to satisfy the compiler.
jake [Fri, 6 Nov 2009 07:08:40 +0000 (07:08 +0000)]
Add parentheses to satisfy the compiler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30842 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a document reference
jmayer [Fri, 6 Nov 2009 06:14:19 +0000 (06:14 +0000)]
Add a document reference

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30841 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Owen Kirby:
jake [Thu, 5 Nov 2009 22:39:00 +0000 (22:39 +0000)]
From Owen Kirby:
We've discovered a number of bugs in the 6LoWPAN dissector,
and have fixed them in the following patch. The fixed bugs include:
  - Incorrect UDP Checksum calculation.
  - Incorrect link-local prefix when decompressing IPHC headers.
  - Incorrect parsing of the UDP port numbers when not 8-byte aligned.
  - Overflow of the datagram offset field when reassembling fragmented packets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30840 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDraw little wireless icons for AirPcap adapters.
gerald [Thu, 5 Nov 2009 22:23:41 +0000 (22:23 +0000)]
Draw little wireless icons for AirPcap adapters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30839 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Tobias Witek:
etxrab [Thu, 5 Nov 2009 21:54:06 +0000 (21:54 +0000)]
From Tobias Witek:
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30838 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect Source-ToTarget-TransparentContainer in the intra LTE case.
etxrab [Thu, 5 Nov 2009 20:34:56 +0000 (20:34 +0000)]
Dissect Source-ToTarget-TransparentContainer in the intra LTE case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30837 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake each level color and the light gradient color in the statusbar match.
gerald [Thu, 5 Nov 2009 19:45:51 +0000 (19:45 +0000)]
Make each level color and the light gradient color in the statusbar match.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30836 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSimplified printing of bits in packet bytes view.
stig [Thu, 5 Nov 2009 15:40:44 +0000 (15:40 +0000)]
Simplified printing of bits in packet bytes view.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30835 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Bahaa Naamneh via bug 4207:
stig [Thu, 5 Nov 2009 13:21:03 +0000 (13:21 +0000)]
From Bahaa Naamneh via bug 4207:
Adjusts the positioning of the autocomplete popup window in a way it gets
displayed exactly under the editable box.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30834 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRestore text_end_1 vs. text_start_2 handling.
stig [Thu, 5 Nov 2009 10:26:43 +0000 (10:26 +0000)]
Restore text_end_1 vs. text_start_2 handling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30833 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIntroduce packet bytes bit view.
stig [Thu, 5 Nov 2009 10:16:49 +0000 (10:16 +0000)]
Introduce packet bytes bit view.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30832 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSelect the previous byte in the packet bytes hex view when clicking in
stig [Thu, 5 Nov 2009 10:11:45 +0000 (10:11 +0000)]
Select the previous byte in the packet bytes hex view when clicking in
the column just behind the first half and the last half.

This behavior is more user friendly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30831 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix value strings in packet boundary lookup table
krj [Thu, 5 Nov 2009 07:36:02 +0000 (07:36 +0000)]
Fix value strings in packet boundary lookup table

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30830 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the property list.
jake [Thu, 5 Nov 2009 06:59:27 +0000 (06:59 +0000)]
Fix the property list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30829 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLighten the chat and none icons as suggested by Stig.
gerald [Thu, 5 Nov 2009 01:15:50 +0000 (01:15 +0000)]
Lighten the chat and none icons as suggested by Stig.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30828 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jason Rusmisel via bug 4199: Increase the maximum number of
gerald [Thu, 5 Nov 2009 01:01:01 +0000 (01:01 +0000)]
From Jason Rusmisel via bug 4199: Increase the maximum number of
template fields we handle from 20 to 30.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30827 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the expert_error border.
gerald [Wed, 4 Nov 2009 22:35:23 +0000 (22:35 +0000)]
Fix the expert_error border.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30826 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a convenience routine to convert pixbuf data generated by
gerald [Wed, 4 Nov 2009 21:16:38 +0000 (21:16 +0000)]
Add a convenience routine to convert pixbuf data generated by
gdk-pixbuf-csource to a GtkImage. Use it to load the expert indicator
images. Add prettier indicator images. The "chat" indicator is more blue
in order to differentiate it from the "none" indicator; make the chat
text background more blue to match.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30825 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake sure we have a handle for the dissector.
etxrab [Wed, 4 Nov 2009 17:13:01 +0000 (17:13 +0000)]
Make sure we have a handle for the dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30824 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck if we have a handle for "v110".
etxrab [Wed, 4 Nov 2009 16:40:52 +0000 (16:40 +0000)]
Check if we have a handle for "v110".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30823 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRegister by name.
etxrab [Wed, 4 Nov 2009 16:39:52 +0000 (16:39 +0000)]
Register by name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30822 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agotvb_format_text() always returns a non NULL pointer so don't check return value for...
krj [Wed, 4 Nov 2009 16:08:47 +0000 (16:08 +0000)]
tvb_format_text() always returns a non NULL pointer so don't check return value for NULL pointer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30821 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pascal Quantin:
etxrab [Wed, 4 Nov 2009 13:49:19 +0000 (13:49 +0000)]
From   Pascal Quantin:
 [NAS EPS] Expert Info error triggered when decoding a Security Mode Complete message
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4203

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30820 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a couple of value_stringS to match BT 2.1
krj [Wed, 4 Nov 2009 12:49:19 +0000 (12:49 +0000)]
Fix a couple of value_stringS to match BT 2.1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30819 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlso apply rev 30817 to command complete events
krj [Wed, 4 Nov 2009 12:31:39 +0000 (12:31 +0000)]
Also apply rev 30817 to command complete events

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30818 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAppend the opcode (that lead us to the command status) to the info column
krj [Wed, 4 Nov 2009 12:25:01 +0000 (12:25 +0000)]
Append the opcode (that lead us to the command status) to the info column

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30817 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agogit-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30816 f5534014-38df-0310...
anonsvn [Wed, 4 Nov 2009 12:19:03 +0000 (12:19 +0000)]
git-svn-id: anonsvn.wireshark.org/wireshark/trunk@30816 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded offset fix from bug 4202, error introduced in r30770.
stig [Wed, 4 Nov 2009 11:41:05 +0000 (11:41 +0000)]
Added offset fix from bug 4202, error introduced in r30770.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30815 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix printing of tuple values
jmayer [Wed, 4 Nov 2009 08:49:38 +0000 (08:49 +0000)]
Fix printing of tuple values

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30814 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Robert Hogan:
jake [Wed, 4 Nov 2009 06:58:42 +0000 (06:58 +0000)]
From Robert Hogan:
Not incrementing tvb offset in two places in tn3270 dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30813 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGet rid of a few more simple dialogs.
gerald [Wed, 4 Nov 2009 00:47:47 +0000 (00:47 +0000)]
Get rid of a few more simple dialogs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30812 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoadd "reserved for profiles" comments
ulfl [Wed, 4 Nov 2009 00:07:54 +0000 (00:07 +0000)]
add "reserved for profiles" comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30811 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the ability to push temporary (and highlighted) messages onto the
gerald [Wed, 4 Nov 2009 00:02:52 +0000 (00:02 +0000)]
Add the ability to push temporary (and highlighted) messages onto the
statusbar. This lets us notify the user about something significant
without having to pop up an annoying window. Replace a few dialogs with
statusbar messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30810 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jason Rusmisel:
jake [Tue, 3 Nov 2009 23:01:03 +0000 (23:01 +0000)]
From Jason Rusmisel:
The netflow implementation has a bug where the code exists to extract four
fields from a packet, however, the decoder for these fields has not been
registered in proto_register_netflow in the hf_register_info array.
The fix is to include decoders for the fields in the proto_register_netflow.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30809 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Benjamin Meyer:
etxrab [Tue, 3 Nov 2009 20:11:19 +0000 (20:11 +0000)]
From Benjamin Meyer:
UserData in Profinet ProcessAlarm declared as UserStructIdentifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4195

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30808 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate 3GPP AVP:s
etxrab [Tue, 3 Nov 2009 17:29:12 +0000 (17:29 +0000)]
Update 3GPP AVP:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30807 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoShow how many NACKs appeared in status message root.
martinm [Tue, 3 Nov 2009 16:39:01 +0000 (16:39 +0000)]
Show how many NACKs appeared in status message root.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30806 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pascal Quantin:
etxrab [Tue, 3 Nov 2009 12:44:17 +0000 (12:44 +0000)]
From   Pascal Quantin:
 I just realized that I forgot to change one line to get a proper decoding of IMEI

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30805 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matthias FRANK:
etxrab [Tue, 3 Nov 2009 12:30:59 +0000 (12:30 +0000)]
From   Matthias FRANK:
PROFIDrive parameter requests not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4193

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30804 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pascal Quantin:
etxrab [Tue, 3 Nov 2009 12:16:25 +0000 (12:16 +0000)]
From   Pascal Quantin:
Small fixes for Attach Request message decoding
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4198

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30803 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Pascal Quantin :
etxrab [Mon, 2 Nov 2009 22:37:34 +0000 (22:37 +0000)]
From Pascal Quantin :
[NAS EPS] Incorrect decoding of UE Network Capability IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4196

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30802 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Matthias FRANK:
etxrab [Mon, 2 Nov 2009 18:09:46 +0000 (18:09 +0000)]
From Matthias FRANK:
PROFISafe F-Parameter record not decoded in PROFINET dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4192
From me remove check_col();

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30801 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved two unneeded includes.
stig [Sun, 1 Nov 2009 22:05:07 +0000 (22:05 +0000)]
Removed two unneeded includes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30800 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix Layer 3 Message Contents(?)
etxrab [Sun, 1 Nov 2009 20:00:08 +0000 (20:00 +0000)]
Fix Layer 3 Message Contents(?)
At least the trace at http://openbsc.gnumonks.org/trac/attachment/wiki/OpenBSCWithSCCP/bssmap_clean.pcap dissects correctly now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30799 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded some type renames.
stig [Sun, 1 Nov 2009 19:16:57 +0000 (19:16 +0000)]
Added some type renames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30798 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Holger Freyther:
etxrab [Sun, 1 Nov 2009 19:11:13 +0000 (19:11 +0000)]
From Holger Freyther:
GSM BSSMAP ChanType permitted indicator extension bit decoded wrongly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4185

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30797 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded a UAT table to describe enterprise specific-trap types.
stig [Sun, 1 Nov 2009 18:45:43 +0000 (18:45 +0000)]
Added a UAT table to describe enterprise specific-trap types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30796 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to 3GPP TS 25.331 V8.8.0 (2009-09)
etxrab [Sun, 1 Nov 2009 16:56:49 +0000 (16:56 +0000)]
Update to 3GPP TS 25.331 V8.8.0 (2009-09)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30795 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2009-11-01]
gerald [Sun, 1 Nov 2009 16:03:28 +0000 (16:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-11-01]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30792 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to TS 36.423 V9.0.0 (2009-09)
etxrab [Sun, 1 Nov 2009 11:55:18 +0000 (11:55 +0000)]
Update to TS 36.423 V9.0.0 (2009-09)
No actual code change so no need to regenerate.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30791 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Markus Koetter:
jake [Sun, 1 Nov 2009 11:52:32 +0000 (11:52 +0000)]
From Markus Koetter:
Wireshark fails dissecting dce rpc bind acks, if the bind request had more than 1 ctx.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30790 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jesper Dangaard Brouer:
jake [Sun, 1 Nov 2009 11:00:00 +0000 (11:00 +0000)]
From Jesper Dangaard Brouer:
This patch set improves packet loss detection in for MPEG2 Transport Streams
(RFC 2250 / ISO/IEC 13818-1).
1. Improve loss detection by counting skipped TS frames (currently we only
detect a drop). (only store the info globally)
2. Introduce an analysis tree and record/count the info per TS frame.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30789 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Dissect Target-ToSource-TransparentContainer.
etxrab [Sun, 1 Nov 2009 10:52:17 +0000 (10:52 +0000)]
- Dissect Target-ToSource-TransparentContainer.
- Update to 3GPP TS 25.413 V8.4.0 (2009-09).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30788 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDissect ToTargetRNC-Container.
etxrab [Sat, 31 Oct 2009 23:21:08 +0000 (23:21 +0000)]
Dissect ToTargetRNC-Container.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30787 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4076:
jake [Sat, 31 Oct 2009 20:55:33 +0000 (20:55 +0000)]
Fix for bug 4076:
Have the option to continue dissection of data even with failed FCS check.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30786 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe first field of a MAC Control frame isn't the "pause" field, it's the
guy [Sat, 31 Oct 2009 19:44:17 +0000 (19:44 +0000)]
The first field of a MAC Control frame isn't the "pause" field, it's the
opcode; an opcode of 0x0001 means PAUSE.  Dissect the opcode field even
if it's not a PAUSE frame.

The second field of a PAUSE frame isn't the "quanta" field, it's the
pause_time field; it's in *units* of quanta.

Don't fetch fields until we need them (so we don't throw an exception if
they're missing until we actually look at them).

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30785 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoVerify bytes exist before doing heuristics check;
wmeier [Sat, 31 Oct 2009 16:22:50 +0000 (16:22 +0000)]
Verify bytes exist before doing heuristics check;
Registering the dissector publicly doesn't seem to be needed;
Fix a typo in a comment and also some indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30784 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom mehturt:
jake [Sat, 31 Oct 2009 16:11:24 +0000 (16:11 +0000)]
From mehturt:
The following patch adds decoding of "trick mode" fields in MPEG PES packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30783 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRegister dissectors in proto_reg_handoff (not proto_register) in the standard manner;
wmeier [Sat, 31 Oct 2009 14:43:05 +0000 (14:43 +0000)]
Register dissectors in proto_reg_handoff (not proto_register) in the standard manner;
Use col_add_fstr instead of col_clear/col_append-fstr.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30782 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove incorrect comment which refered to a non existant header file
krj [Sat, 31 Oct 2009 13:06:15 +0000 (13:06 +0000)]
Remove incorrect comment which refered to a non existant header file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30781 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPopulate protocol column before digging into the buffer (we might throw an exception...
krj [Sat, 31 Oct 2009 13:03:12 +0000 (13:03 +0000)]
Populate protocol column before digging into the buffer (we might throw an exception while doing that)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30780 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake jmirror handle static
krj [Sat, 31 Oct 2009 12:54:07 +0000 (12:54 +0000)]
Make jmirror handle static

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30779 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd JMirror dissector
krj [Sat, 31 Oct 2009 12:40:53 +0000 (12:40 +0000)]
Add JMirror dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30778 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Wayne Brassem:
jake [Sat, 31 Oct 2009 12:04:42 +0000 (12:04 +0000)]
From Wayne Brassem:
I have built and tested a new Wireshark dissector which decodes a mirrored
packet that has an additional prepended UDP header attached to it.  The packet
format was designed by Juniper Networks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30777 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoassert() doesn't throw an exception, it just immediately crashes the
guy [Sat, 31 Oct 2009 08:31:21 +0000 (08:31 +0000)]
assert() doesn't throw an exception, it just immediately crashes the
app, and DISSECTOR_ASSERT() throws an exception, but claims the problem
is a dissector bug, not a malformed packet.  Presumably the error in
question is the result of a malformed packet, so throw
ReportedBoundsError to indicate that (it's not really the *right*
exception, but the right exception doesn't exist).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30776 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Márton Németh:
jake [Fri, 30 Oct 2009 22:46:30 +0000 (22:46 +0000)]
From Márton Németh:
When an unknown requests arrives try to parse it using the usual request format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30775 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Márton Németh:
jake [Fri, 30 Oct 2009 22:24:23 +0000 (22:24 +0000)]
From Márton Németh:
Add support for USB HUB class-specific requests as specified in USB 2.0 Chapter 11 Hub Specification.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30774 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPrepare for c-ares 1.6.1 release.
jake [Fri, 30 Oct 2009 21:57:43 +0000 (21:57 +0000)]
Prepare for c-ares 1.6.1 release.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30773 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove debug code
etxrab [Fri, 30 Oct 2009 16:25:11 +0000 (16:25 +0000)]
Remove debug code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30772 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- Bitrate must be FT_UINT64
etxrab [Fri, 30 Oct 2009 16:15:27 +0000 (16:15 +0000)]
- Bitrate must be FT_UINT64
- Dissect HandoverCommand

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30771 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago- In new_octet_aligned_subset_bits() the length check must be on octet not bits.
etxrab [Fri, 30 Oct 2009 16:09:32 +0000 (16:09 +0000)]
- In new_octet_aligned_subset_bits() the length check must be on octet not bits.
- try to make the code a bit more readable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30770 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSequence number should be displayed in DEC, not HEX!
martinm [Fri, 30 Oct 2009 15:56:43 +0000 (15:56 +0000)]
Sequence number should be displayed in DEC, not HEX!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30769 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCorrected name used for STANAG 4406.
stig [Fri, 30 Oct 2009 10:55:43 +0000 (10:55 +0000)]
Corrected name used for STANAG 4406.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30768 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoApply r30376 to asn1 template files.
stig [Fri, 30 Oct 2009 10:21:35 +0000 (10:21 +0000)]
Apply r30376 to asn1 template files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30767 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded SNMP to "Decode ASN.1 file as" list.
stig [Fri, 30 Oct 2009 10:05:28 +0000 (10:05 +0000)]
Added SNMP to "Decode ASN.1 file as" list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30766 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd instructions for the cmake files.
jake [Fri, 30 Oct 2009 07:11:41 +0000 (07:11 +0000)]
Add instructions for the cmake files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30765 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle padded RTCP packets ending with SDES correctly as well.
jake [Thu, 29 Oct 2009 22:14:54 +0000 (22:14 +0000)]
Handle padded RTCP packets ending with SDES correctly as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30764 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Marton Nemeth via bug 4181:
stig [Thu, 29 Oct 2009 21:51:20 +0000 (21:51 +0000)]
From Marton Nemeth via bug 4181:
Take the USB descriptor length from packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30763 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Marton Nemeth via bug 4173:
stig [Thu, 29 Oct 2009 21:42:16 +0000 (21:42 +0000)]
From Marton Nemeth via bug 4173:
Parse USB HID class-specific requests.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30762 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Marton Nemeth via bug 4173:
stig [Thu, 29 Oct 2009 21:32:21 +0000 (21:32 +0000)]
From Marton Nemeth via bug 4173:
Move bmRequestType field constants to header file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30761 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTidy up info column output showing partial NACK.
martinm [Thu, 29 Oct 2009 19:06:10 +0000 (19:06 +0000)]
Tidy up info column output showing partial NACK.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30760 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Gerasimos Dimitriadis:
etxrab [Thu, 29 Oct 2009 18:13:17 +0000 (18:13 +0000)]
From Gerasimos Dimitriadis:
DTAP: Update of Reject Cause IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4179

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30759 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixed 'Delta timestamp to previous captured frame' calculation in
stig [Thu, 29 Oct 2009 13:27:05 +0000 (13:27 +0000)]
Fixed 'Delta timestamp to previous captured frame' calculation in
old packet list.  This bug was introduced in r30052.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30758 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Eric Sesterhenn via bug 4175:
stig [Thu, 29 Oct 2009 11:23:04 +0000 (11:23 +0000)]
From Eric Sesterhenn via bug 4175:
Fixed fp leakage in error path.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30757 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Eric Sesterhenn via bug 4175:
stig [Thu, 29 Oct 2009 11:20:33 +0000 (11:20 +0000)]
From Eric Sesterhenn via bug 4175:
Fixed cfmt->cfield and cfmt leakage in the error path.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30756 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Eric Sesterhenn via bug 4175:
stig [Thu, 29 Oct 2009 11:16:22 +0000 (11:16 +0000)]
From Eric Sesterhenn via bug 4175:
Use g_strdup to allocate filename.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30755 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a typo
etxrab [Thu, 29 Oct 2009 08:02:34 +0000 (08:02 +0000)]
Fix a typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30754 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoNew version is 1.3.2
jmayer [Thu, 29 Oct 2009 07:04:34 +0000 (07:04 +0000)]
New version is 1.3.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30753 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExport ToTargetRNC-Container.
etxrab [Thu, 29 Oct 2009 06:45:42 +0000 (06:45 +0000)]
Export ToTargetRNC-Container.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30752 f5534014-38df-0310-8fa8-9805f1628bb7