20 years agoNote that one can probably symbolically request that nettl log incoming
guy [Sat, 19 Feb 2000 08:50:11 +0000 (08:50 +0000)]
Note that one can probably symbolically request that nettl log incoming
and outgoing PDUs, rather than specifying a numerical mask with pduin
and pduout (0x30000000).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1649 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIf we see a file with an unknown network type, report the type in a
guy [Sat, 19 Feb 2000 08:06:27 +0000 (08:06 +0000)]
If we see a file with an unknown network type, report the type in a
"g_message()" message, as other capture-file readers do.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1648 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse WTAP_ERR_UNSUPPORTED_ENCAP for all attempts to open or read a
guy [Sat, 19 Feb 2000 08:00:08 +0000 (08:00 +0000)]
Use WTAP_ERR_UNSUPPORTED_ENCAP for all attempts to open or read a
capture file for an unsupported link-layer encapsulation type (as the
nettl reader does), and report it correctly if it occurs on an open or
read attempt rather than a save attempt.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1647 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoNote that the read filter specified with the "-R" flag applies only to a
guy [Sat, 19 Feb 2000 00:18:45 +0000 (00:18 +0000)]
Note that the read filter specified with the "-R" flag applies only to a
file read in as a result of a "-r" flag specified on the command line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1646 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMove the notes on nettl support above the notes on libpcap; the notes on
guy [Fri, 18 Feb 2000 19:13:27 +0000 (19:13 +0000)]
Move the notes on nettl support above the notes on libpcap; the notes on
libpcap are somewhat long, and if somebody doesn't look at the table of
contents, but just scrolls through the file, they may get bored and give
up before they get to the notes on nettl.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1645 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRenamed init_dissect_x25() to reinit_x25_hashtable() and actually used it !
oabad [Fri, 18 Feb 2000 13:41:26 +0000 (13:41 +0000)]
Renamed init_dissect_x25() to reinit_x25_hashtable() and actually used it !

This function is used to re-initialize the hash table used by the X.25
dissector to record the upper layer protocol used by each VC. The hash
table should be re-initialized each time we read / start a new capture.

I moved the definition of the function from packet.h to packet-x25.h, and
added calls to reinit_x25_hashtable() in read_cap_file (file.c) and
do_capture (capture.c).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1644 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd comments about nettl support.
oabad [Fri, 18 Feb 2000 09:15:22 +0000 (09:15 +0000)]
Add comments about nettl support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1643 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd support for raw IP nettl captures.
oabad [Thu, 17 Feb 2000 21:08:15 +0000 (21:08 +0000)]
Add support for raw IP nettl captures.
Update the nettl section in wiretap/README, and give sample commands to
make captures on HP-UX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1642 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd GTK+-1.2.7 fixes to gtkclist.c, w/o removing our speed enhancements.
gram [Thu, 17 Feb 2000 18:27:04 +0000 (18:27 +0000)]
Add GTK+-1.2.7 fixes to gtkclist.c, w/o removing our speed enhancements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1641 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAllow for non-"struct timeval" ts's in phdr just like we did
gram [Wed, 16 Feb 2000 01:38:56 +0000 (01:38 +0000)]
Allow for non-"struct timeval" ts's in phdr just like we did
in capture.c. Copy the members of the struct instead of the entire struct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1640 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix NetBIOS name types as per my understanding and the MS Knowledge base
sharpe [Wed, 16 Feb 2000 00:44:45 +0000 (00:44 +0000)]
Fix NetBIOS name types as per my understanding and the MS Knowledge base
article ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1639 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoBuild/packaging fix. We have to include an install-exec-hook target
gram [Tue, 15 Feb 2000 21:17:57 +0000 (21:17 +0000)]
Build/packaging fix. We have to include an install-exec-hook target
for non-setuid builds, simply because of the way automake works. Automake
makes install-exec-hook a dependency of install-exec-am because it sees it
in Makefile.am, without taking into account the ifdef.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1638 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCreate a header file for every packet-*.c file. Prune the packet.h file.
gram [Tue, 15 Feb 2000 21:06:58 +0000 (21:06 +0000)]
Create a header file for every packet-*.c file. Prune the packet.h file.
This change allows you to add a new packet-*.c file and not cause a
recompilation of everything that #include's packet.h

Add the plugin_api.[ch] files ot the plugins/Makefile.am packaging list.

Add #define YY_NO_UNPUT 1 to the lex source so that the yyunput symbol
is not defined, squelching a compiler complaint when compiling the generated
C file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1637 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix from Dietmar Petras to the BOOTP dissector - entries for BOOTP
guy [Mon, 14 Feb 2000 18:15:29 +0000 (18:15 +0000)]
Fix from Dietmar Petras to the BOOTP dissector - entries for BOOTP
options 62 and 63 were missing, and the table from which they were
missing was an array indexed by the option number, so options 62 and
above were decoded incorrectly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1636 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of redundant include of <stdio.h> - one is enough.
guy [Mon, 14 Feb 2000 04:57:30 +0000 (04:57 +0000)]
Get rid of redundant include of <stdio.h> - one is enough.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1635 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn "display_flags()", panic if the size handed to it is neither 1, 2,
guy [Mon, 14 Feb 2000 04:22:22 +0000 (04:22 +0000)]
In "display_flags()", panic if the size handed to it is neither 1, 2,
nor 4, as we currently don't handle that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1634 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoProtocol abbreviations should be all lower case, as they're used in
guy [Mon, 14 Feb 2000 04:21:04 +0000 (04:21 +0000)]
Protocol abbreviations should be all lower case, as they're used in
filter expressions, and names in those expressions are currently
case-sensitive, and obliging people to type "Mailslot" to filter for
SMB mailslot packets is overkill.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1633 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoProtocol abbreviations should be all lower case, as they're used in
guy [Mon, 14 Feb 2000 04:18:57 +0000 (04:18 +0000)]
Protocol abbreviations should be all lower case, as they're used in
filter expressions, and names in those expressions are currently
case-sensitive, and obliging people to type "Lanman" to filter for
Lanman packets is overkill.

Get rid of the comment saying that the routines for mailslot and pipe
dissecting should perhaps be migrated to another file, as this and
"packet-smb-mailslot.c" are the other files to which they were migrated.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1632 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse "SMB", not "Smb"; it stands for "Server Message Block".
guy [Mon, 14 Feb 2000 04:11:06 +0000 (04:11 +0000)]
Use "SMB", not "Smb"; it stands for "Server Message Block".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1631 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix the comment at the beginning of the file.
guy [Mon, 14 Feb 2000 04:05:53 +0000 (04:05 +0000)]
Fix the comment at the beginning of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1630 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoJeff Foster's SMB Mailslot and Netlogin dissectors; he split
guy [Mon, 14 Feb 2000 04:02:21 +0000 (04:02 +0000)]
Jeff Foster's SMB Mailslot and Netlogin dissectors; he split
"packet-smb.c" up into several files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1629 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoWhen exiting Ethereal, don't just unlink any temporary capture file,
guy [Sun, 13 Feb 2000 10:36:06 +0000 (10:36 +0000)]
When exiting Ethereal, don't just unlink any temporary capture file,
call "close_cap_file()", which will unlink the current capture file if
it's a temporary file - but will do so after closing it; certain OSes
whose names begin with "W" don't let you remove a file if it's currently
open, so if you exit Ethereal, without closing the capture first, after
doing a capture on one of those OSes, the temporary file won't be

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1628 f5534014-38df-0310-8fa8-9805f1628bb7

20 years ago"proto_add_item_subtree()" returns a value; its wrapper should return
guy [Sat, 12 Feb 2000 11:24:24 +0000 (11:24 +0000)]
"proto_add_item_subtree()" returns a value; its wrapper should return
the value that the real function returns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1627 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSquelch a complaint from Visual C++ 6.0 (the code was OK beforehand, at
guy [Sat, 12 Feb 2000 11:22:26 +0000 (11:22 +0000)]
Squelch a complaint from Visual C++ 6.0 (the code was OK beforehand, at
least as I remember the ANSI C standard, but I guess they're warning you
that you might've intended to return the return value of a function but
forgot to put a parameter list after the function name).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1626 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of the check for NetBSD in the Wiretap "configure.in"; we
guy [Sat, 12 Feb 2000 08:54:32 +0000 (08:54 +0000)]
Get rid of the check for NetBSD in the Wiretap "configure.in"; we
eliminated the check in the top-level "configure.in", and leaving it in
the Wiretap one means that, on NetBSD, Ethereal gets built with zlib
support if zlib is present, but Wiretap doesn't - now they both get
built with zlib support.  Thanks to Itojun for catching this one.

Put into the Wiretap "configure.in" code to note that, if the test for
"gzgets()" in zlib fails, we're disabling compressed capture file
support, as is done in the top-level "configure.in".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1625 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate the Win32 Nmakefiles to reflect the move of the color code into
guy [Sat, 12 Feb 2000 08:44:43 +0000 (08:44 +0000)]
Update the Win32 Nmakefiles to reflect the move of the color code into
the "gtk" directory and the split of that code into "colors.c" and

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1624 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove some unnecessary includes from "gtk/color_dlg.c" and
guy [Sat, 12 Feb 2000 08:42:28 +0000 (08:42 +0000)]
Remove some unnecessary includes from "gtk/color_dlg.c" and
"gtk/colors.c", and make "gtk/color_dlg.c" include "gtk/color_dlg.h" to
make sure compilation checks the declaration of the routines with their

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1623 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSplit the color manipulation stuff into "color_dlg.[ch]", containing the
guy [Sat, 12 Feb 2000 08:31:49 +0000 (08:31 +0000)]
Split the color manipulation stuff into "color_dlg.[ch]", containing the
dialog boxes for editing color filtes, and "colors.[ch]", containing the
toolkit-dependent code to manipulate colors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1622 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe color stuff is almost completely toolkit-dependent (this isn't just
guy [Sat, 12 Feb 2000 08:15:31 +0000 (08:15 +0000)]
The color stuff is almost completely toolkit-dependent (this isn't just
the color-selection and color-filter-editing GUI stuff; different
toolkits, and different windows systems, have their own notions of color
objects - they may have nothing in common other than the notion that
colors have red, green, and blue values); move it all to the "gtk"
subdirectory for now, and, as we discover stuff stuff that can be made
platform-independent, drag it up to the top-level directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1621 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMove the declarations of the routines in "gtk/file_dlg.c" out of
guy [Sat, 12 Feb 2000 06:58:42 +0000 (06:58 +0000)]
Move the declarations of the routines in "gtk/file_dlg.c" out of
"gtk/main.h" and into a new "gtk/file_dlg.h" file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1620 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake the routines internal to the filter-editing dialog box static.
guy [Sat, 12 Feb 2000 06:46:54 +0000 (06:46 +0000)]
Make the routines internal to the filter-editing dialog box static.

Declare the one routine exported by "gtk/filter_prefs.c" in
"gtk/filter_prefs.h" rather than in "gtk/main.h".  Declare
"E_FILT_TE_PTR_KEY" there, as well, rather than in "prefs_dlg.h", as the
filter-editing dialog box is no longer a preference tab.

Don't include "prefs_dlg.h" unless the stuff declared therein is of

Fix "gtk/find_dlg.c" to fire up the filter-editing dialog box, not the
no-longer-extant preferences tab for filters, if the "Filter:" button is

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1619 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix from Nick Amato for a typo - "Link", in "Link State", shouldn't have
guy [Fri, 11 Feb 2000 22:35:49 +0000 (22:35 +0000)]
Fix from Nick Amato for a typo - "Link", in "Link State", shouldn't have
an "e" in it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1618 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSay "Tethereal", rather than "Ethereal", in messages from Tethereal.
guy [Fri, 11 Feb 2000 06:53:31 +0000 (06:53 +0000)]
Say "Tethereal", rather than "Ethereal", in messages from Tethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1617 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd Peter Kjellerstedt <peter.kjellerstedt@axis.com>'s patches
gram [Fri, 11 Feb 2000 03:17:58 +0000 (03:17 +0000)]
Add Peter Kjellerstedt <peter.kjellerstedt@axis.com>'s patches
to add Axis ethernet vendor ID, use libtoolize in autogen.sh, and
provide the very dangerous option of installing ethereal setuid.

I've added a "DANGEROUS" comment to the description of the
--enable-setuid-install option which displays in "./configure --help".

Removed generated files tha old libltdl/.cvsignore brought to my
attention by Peter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1616 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSean Walmsley <sean.p.walmsley@Hydro.ON.CA> caught a typo in Makefile.am.
gerald [Thu, 10 Feb 2000 22:54:50 +0000 (22:54 +0000)]
Sean Walmsley <sean.p.walmsley@Hydro.ON.CA> caught a typo in Makefile.am.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1615 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange LT_LIB_EXT to ".so" for non-Win32 platforms.
gram [Wed, 9 Feb 2000 19:37:47 +0000 (19:37 +0000)]
Change LT_LIB_EXT to ".so" for non-Win32 platforms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1614 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoInitialize *p_pi solely to get rid of compiler warning.
gram [Wed, 9 Feb 2000 19:32:28 +0000 (19:32 +0000)]
Initialize *p_pi solely to get rid of compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1613 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIntegrate Ed Meaney's <emeaney@altiga.com> changes for using libpcap
gram [Wed, 9 Feb 2000 19:18:42 +0000 (19:18 +0000)]
Integrate Ed Meaney's <emeaney@altiga.com> changes for using libpcap
from WinDump with Ethereal. We now have packet capturing on Win32. :)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1612 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe time protocol is a simple request-response protocol, and doesn't end
guy [Wed, 9 Feb 2000 19:09:02 +0000 (19:09 +0000)]
The time protocol is a simple request-response protocol, and doesn't end
up involving two ports neither of which is the official port; remove the
comment saying a dynamic call is added, as the code wasn't adding such a

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1611 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoI forgot to add Dietmar's new file, packet-time.c.
gram [Wed, 9 Feb 2000 17:17:00 +0000 (17:17 +0000)]
I forgot to add Dietmar's new file, packet-time.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1610 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDietmar Petras provided:
gram [Wed, 9 Feb 2000 17:15:59 +0000 (17:15 +0000)]
Dietmar Petras provided:

* fix a bug in packet-tftp.c dissecting TFTP Option Acknowledgement
  packets. The is no Block-Id in TFTP Option Acknowledgements, as it is
  in TFTP Acknowledgements.
* Extension of manuf by ethernet addresses from ELSA (my company), a german
  vendor of ISDN routers, cable modems, etc.
* New dissector for Time Protocol [RFC 0868]. That protocol works on port
  37 of UDP and TCP. The implementation in this patch only dissects the
  more usual UDP version. It could print the time in a more fashion way,
  but thats for a later version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1609 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate Makefiles for win32. Move local configuration to config.nmake,
gram [Wed, 9 Feb 2000 00:41:57 +0000 (00:41 +0000)]
Update Makefiles for win32. Move local configuration to config.nmake,
have top-level Makefile.nmake call Makefile.nmake's in subdirectories.
Build plugins, and build generated source (lex, yacc). The only thing we
can't build is register.c; I need to re-work the top-level Makefile.nmake
because it lists object files, not C files, which make-reg-dotc needs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1608 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn debian/changelog :
oabad [Tue, 8 Feb 2000 19:41:50 +0000 (19:41 +0000)]
In debian/changelog :
Changes from Frederic Peters to avoid conflicts with official debian
packages (I used a version scheme attributed to non-maintainer uploads).

In debian/control :
Add missing build dependencies (only useful for debian build daemons).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1607 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange "unsigned gint64" to "guint64", and add GPL header to plugin_api.[ch]
gram [Mon, 7 Feb 2000 17:23:53 +0000 (17:23 +0000)]
Change "unsigned gint64" to "guint64", and add GPL header to plugin_api.[ch]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1606 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCode changes, but not Makefile changes, for enabling plugins for Win32.
gram [Mon, 7 Feb 2000 17:08:27 +0000 (17:08 +0000)]
Code changes, but not Makefile changes, for enabling plugins for Win32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1605 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoNote the document that specified the PIDs for VTP and DRiP that go along
guy [Sat, 5 Feb 2000 09:34:33 +0000 (09:34 +0000)]
Note the document that specified the PIDs for VTP and DRiP that go along
with Cisco's "wacky proprietary protocols atop LLC/SNAP" OUI, and put in
"#if 0"ed out code for Cisco's DRiP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1604 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDissector for Cisco's Virtual Trunking Protocol.
guy [Sat, 5 Feb 2000 09:19:06 +0000 (09:19 +0000)]
Dissector for Cisco's Virtual Trunking Protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1603 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAllow filtering on 24-bit integral fields.
guy [Sat, 5 Feb 2000 06:07:16 +0000 (06:07 +0000)]
Allow filtering on 24-bit integral fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1602 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCisco Group Management Protocol dissector.
guy [Sat, 5 Feb 2000 05:54:17 +0000 (05:54 +0000)]
Cisco Group Management Protocol dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1601 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn init_plugins() :
oabad [Thu, 3 Feb 2000 21:31:03 +0000 (21:31 +0000)]
In init_plugins() :
If std_plug_dir AND local_plug_dir don't exist, the code doesn't scan
PLUGIN_DIR. Reported by Eric Lassauge.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1600 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange from Ed Meaney - when doing a "Save" or "Save As" that saves all
guy [Thu, 3 Feb 2000 06:35:27 +0000 (06:35 +0000)]
Change from Ed Meaney - when doing a "Save" or "Save As" that saves all
packets and doesn't change the capture file format, i.e. that's done by
a raw copy, read the file in binary.  (XXX - does "creat()", on Win32,
open the file in ASCII or binary mode?  If ASCII, we may have to use

open(fname, O_CREAT|O_TRUNC|O_WRONLY|O_BINARY, 0644)

rather than

creat(fname, 0644)

so that the output file is written in binary as well.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1599 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange from Ed Meaney - write capture files in binary, rather than ASCII
guy [Thu, 3 Feb 2000 06:31:30 +0000 (06:31 +0000)]
Change from Ed Meaney - write capture files in binary, rather than ASCII
("w" and "wb" are the same on UNIX, but not on Win32).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1598 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange from Ed Meaney - write capture files in binary, rather than ASCII
guy [Thu, 3 Feb 2000 06:30:47 +0000 (06:30 +0000)]
Change from Ed Meaney - write capture files in binary, rather than ASCII
("w" and "wb" are the same on UNIX, but not on Win32).

Also, give Gilbert credit for the Win32 changes he's made.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1597 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn dissect_ipopt_timestamp() :
oabad [Wed, 2 Feb 2000 22:07:38 +0000 (22:07 +0000)]
In dissect_ipopt_timestamp() :
Correct a bug reported by Paul Ionescu when dissecting a timestamp IP
option. The offsets where not correct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1596 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAlso listen for GDK_INPUT_EXCEPTION on the sync pipe. On Solaris 2.6
gram [Wed, 2 Feb 2000 18:38:52 +0000 (18:38 +0000)]
Also listen for GDK_INPUT_EXCEPTION on the sync pipe. On Solaris 2.6
this is needed to get the last message from the pipe.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1595 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a note about many Linux libpcaps turning promiscuous mode off only
guy [Tue, 1 Feb 2000 21:52:22 +0000 (21:52 +0000)]
Add a note about many Linux libpcaps turning promiscuous mode off only
when the program using libpcap exits, and perhaps not doing so even
then, and indicating how to check whether an interface is in promiscuous
mode and how to take it out of promiscuous mode if it is in promiscuous

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1593 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoNote that capture filters don't work on Linux loopback devices with the
guy [Tue, 1 Feb 2000 21:21:47 +0000 (21:21 +0000)]
Note that capture filters don't work on Linux loopback devices with the
current version of libpcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1592 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMove to version 0.8.3.
gram [Tue, 1 Feb 2000 14:12:20 +0000 (14:12 +0000)]
Move to version 0.8.3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1591 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove libltdl sources.
gram [Tue, 1 Feb 2000 14:03:47 +0000 (14:03 +0000)]
Remove libltdl sources.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1590 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDissect packets to or from port 162 as SNMP packets - that's the port to
guy [Tue, 1 Feb 2000 04:13:47 +0000 (04:13 +0000)]
Dissect packets to or from port 162 as SNMP packets - that's the port to
which SNMP traps are sent.  Thanks and a tip of the Hatlo Hat to Craig
Rodrigues for discovering this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1589 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn init_plugins(), before scanning PLUGIN_DIR :
oabad [Mon, 31 Jan 2000 19:50:58 +0000 (19:50 +0000)]
In init_plugins(), before scanning PLUGIN_DIR :
do a "stat" on PLUGIN_DIR, /usr/lib/ethereal/plugins/0.8 and
/usr/local/lib/ethereal/plugins/0.8 and compare st_dev and st_ino to be
sure that PLUGIN_DIR is different from the others (and not a symlink which
would cause a "plugin found in multiple directories" warning).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1588 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a semicolon in a win32 block of code.
gram [Mon, 31 Jan 2000 19:34:25 +0000 (19:34 +0000)]
Add a semicolon in a win32 block of code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1587 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded support for clicking capture window's close box to stop capture
nneul [Sun, 30 Jan 2000 17:10:29 +0000 (17:10 +0000)]
added support for clicking capture window's close box to stop capture

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1586 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdded ethereal_static extra target in Makefile.am. Did not add the updates
nneul [Sun, 30 Jan 2000 16:57:20 +0000 (16:57 +0000)]
Added ethereal_static extra target in Makefile.am. Did not add the updates
to configure.in. This should allow someone to do 'make ethereal_static' and
get a staticly built copy of ethereal w/o plugin support on platforms that
support -Wl,-static for static linking.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1585 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDissect the user data of an incoming CALL REQUEST/INCOMING CALL packet
guy [Sun, 30 Jan 2000 05:58:02 +0000 (05:58 +0000)]
Dissect the user data of an incoming CALL REQUEST/INCOMING CALL packet
as per X.224 and X.264.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1584 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a bunch of additional NLPIDs from ISO 9577.
guy [Sun, 30 Jan 2000 05:50:02 +0000 (05:50 +0000)]
Add a bunch of additional NLPIDs from ISO 9577.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1583 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoJust pass the return value of "getuid()" directly on to "getpwuid()";
guy [Sat, 29 Jan 2000 20:04:23 +0000 (20:04 +0000)]
Just pass the return value of "getuid()" directly on to "getpwuid()";
don't stuff it into a variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1582 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix #ifndef line whose symbol had been omitted.
guy [Sat, 29 Jan 2000 19:08:12 +0000 (19:08 +0000)]
Fix #ifndef line whose symbol had been omitted.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1581 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't put "get_home_dir()" inside #ifdef HAVE_LIBPCAP/#endif.
guy [Sat, 29 Jan 2000 19:06:59 +0000 (19:06 +0000)]
Don't put "get_home_dir()" inside #ifdef HAVE_LIBPCAP/#endif.

On UNIX, if "$HOME" isn't set, try getting the user ID and the password
entry for that user ID, and, if that succeeds, get the home directory
from the password entry, otherwise use "/tmp".  On NT, it may be
possible to do something similar (get the user name, and append that to
"C:\winnt\profiles\"); I'm not sure whether there's anything that can be
done on Windows 9x.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1580 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove instances of getenv("HOME") and provide a get_home_dir() function
gram [Sat, 29 Jan 2000 16:41:28 +0000 (16:41 +0000)]
Remove instances of getenv("HOME") and provide a get_home_dir() function
which provides a default value if "HOME" is not set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1579 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoI forgot to toggle the data_out_file "semaphore" (well, we us it like one)
gram [Sat, 29 Jan 2000 13:30:08 +0000 (13:30 +0000)]
I forgot to toggle the data_out_file "semaphore" (well, we us it like one)
at the end of follow_read_stream(), which causes a segfault if you change
the TCP Follow screen to EBCDIC, and then go back and select a TCP packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1578 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe user data in an X.25 call request packet is - at least for IP and,
guy [Sat, 29 Jan 2000 09:19:02 +0000 (09:19 +0000)]
The user data in an X.25 call request packet is - at least for IP and,
if I correctly read the Windows NT DDK documentation on WAN drivers, for
PPP as well - an ISO NLPID, so use the "nlpid.h" values where they

Currently doesn't treat NLPID_PPP as PPP, but if we get a PPP-over-X.25
capture, we may find that it should do so.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1577 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSupport for NetXray 3.03 (the program version, not file version) PPP
gram [Sat, 29 Jan 2000 05:10:06 +0000 (05:10 +0000)]
Support for NetXray 3.03 (the program version, not file version) PPP
traces. The trace we got from Tom Poe (tomp@intrex.net) contains PPP
data which NetXRay has transformed into looking like Ethernet frames.
The hardware addresses are the bytes for the ASCII reprsentation of
"SRC" and "DEST", with null pad bytes at the end. Interesting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1576 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a bug in the extraction of the sequence number.
gram [Sat, 29 Jan 2000 04:47:34 +0000 (04:47 +0000)]
Fix a bug in the extraction of the sequence number.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1575 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIf a file is opened, and then closed, the File|Open option doesn't
gram [Thu, 27 Jan 2000 09:53:50 +0000 (09:53 +0000)]
If a file is opened, and then closed, the File|Open option doesn't
show up any more (nor does the Capture option). Fixed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1574 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoTFTP Option Extension (RFC 2347) support, from Craig Newell.
guy [Thu, 27 Jan 2000 07:09:45 +0000 (07:09 +0000)]
TFTP Option Extension (RFC 2347) support, from Craig Newell.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1573 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn case the "ts" field of a libpcap per-packet header isn't a "struct
guy [Wed, 26 Jan 2000 23:09:21 +0000 (23:09 +0000)]
In case the "ts" field of a libpcap per-packet header isn't a "struct
timeval" (if, say, it's a "struct bpf_timeval", with member sizes wired
to 32 bits, as it appears to be in SuSE 6.3 and will, I think, be in the
0.5 release of libpcap), copy the members of that field to the "ts"
field of the Wiretap per-packet header (which also lets us make it not a
"struct timeval" as well).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1572 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAlways declare, and define, "file_seek()" to return a "long", as it's
guy [Wed, 26 Jan 2000 19:22:04 +0000 (19:22 +0000)]
Always declare, and define, "file_seek()" to return a "long", as it's
supposed to look like "ftell()".

If you don't have zlib, just define "file_seek" as an alias for "fseek",
rather than defining it as a routine.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1571 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCorrected a SEGFAULT in v2 readdir reply, v3 readdir reply, and v3 readdirplus
girlich [Wed, 26 Jan 2000 09:52:42 +0000 (09:52 +0000)]
Corrected a SEGFAULT in v2 readdir reply, v3 readdir reply, and v3 readdirplus
reply. It came in with the new dissect_rpc_string() with gives the string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1570 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a debian subdirectory and the files needed to generate a debian package.
oabad [Wed, 26 Jan 2000 07:00:26 +0000 (07:00 +0000)]
Add a debian subdirectory and the files needed to generate a debian package.
The files were created by Frederic Peters <fpeters@debian.org>, the maintainer
of the ethereal debian package.
I just modified `rules' to use autogen.sh when building from a CVS tree.
Building a debian package is now very easy :
- in debian/changelog : change the version number (and replace my name with
- dpkg-buildpackage -rfakeroot -us -uc

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1569 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoInitialize per-dissection data structures before doing a capture, as
guy [Wed, 26 Jan 2000 05:30:02 +0000 (05:30 +0000)]
Initialize per-dissection data structures before doing a capture, as
well as before reading a capture file - if the user didn't specify that
the capture should be saved to a file, it'll be dissected as it arrives.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1568 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn "dissect_clnp()", fill in "clnp" before looking at it.
guy [Wed, 26 Jan 2000 05:04:29 +0000 (05:04 +0000)]
In "dissect_clnp()", fill in "clnp" before looking at it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1567 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn Win32, treat both '/' and '\' as pathname separators.
guy [Wed, 26 Jan 2000 04:56:14 +0000 (04:56 +0000)]
In Win32, treat both '/' and '\' as pathname separators.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1566 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCredit fix, and fix for building editcap.1 with build dir != $(srcdir)
gram [Wed, 26 Jan 2000 03:42:28 +0000 (03:42 +0000)]
Credit fix, and fix for building editcap.1 with build dir != $(srcdir)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1564 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoItojun did part of the BSD zlib fix.
guy [Wed, 26 Jan 2000 02:35:54 +0000 (02:35 +0000)]
Itojun did part of the BSD zlib fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1563 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMove version to 0.8.2, add Win32 to list of platforms in README.
gram [Wed, 26 Jan 2000 02:31:35 +0000 (02:31 +0000)]
Move version to 0.8.2, add Win32 to list of platforms in README.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1562 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix the File|Open menu problem for builds w/o pcap (aka, win32 builds).
gram [Tue, 25 Jan 2000 17:57:31 +0000 (17:57 +0000)]
Fix the File|Open menu problem for builds w/o pcap (aka, win32 builds).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1561 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd O_BINARY flag to open() for win32.
gram [Tue, 25 Jan 2000 17:51:11 +0000 (17:51 +0000)]
Add O_BINARY flag to open() for win32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1560 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd an include of "../menu.h" to fix a win32 build break.
gram [Tue, 25 Jan 2000 17:32:52 +0000 (17:32 +0000)]
Add an include of "../menu.h" to fix a win32 build break.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1559 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoEnable File|Open menu item when Ethereal is started with no "-r" option.
gram [Tue, 25 Jan 2000 13:44:39 +0000 (13:44 +0000)]
Enable File|Open menu item when Ethereal is started with no "-r" option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1558 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdded additional manpages and binaries to RPM package. I don't
gram [Tue, 25 Jan 2000 11:14:48 +0000 (11:14 +0000)]
Added additional manpages and binaries to RPM package. I don't
know if my changes work, or if anyone actually uses the spec file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1557 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoparse multiple COMMUNITIES value.
itojun [Tue, 25 Jan 2000 09:24:42 +0000 (09:24 +0000)]
parse multiple COMMUNITIES value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1556 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoProvide a "get_dirname()" routine, that takes a pathname and returns
guy [Tue, 25 Jan 2000 05:48:47 +0000 (05:48 +0000)]
Provide a "get_dirname()" routine, that takes a pathname and returns
either a pointer to the directory part of the pathname (after stomping
on the pathname separator with a '\0', so don't use this on pathnames
you plan to use afterwards), or NULL if the pathname contains no
directory part, and make it handle Win32 pathnames on Win32 systems.

Use it to get the containing directory of the currently open file, so
that the "chdir()" stuff we do to cause the "File:Open" dialog box to
show you files in the directory in which you last looked works on Win32

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1555 f5534014-38df-0310-8fa8-9805f1628bb7

20 years ago"gztell()" is also affected by the libz mess on platforms where "off_t"
guy [Tue, 25 Jan 2000 04:49:55 +0000 (04:49 +0000)]
"gztell()" is also affected by the libz mess on platforms where "off_t"
is bigger than a "long"; this is itojun's fix for that, turning
"file_tell()" into a wrapper function in "file_wrappers.c", just like

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1554 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse "get_basename()" rather than finding the last component of "argv[0]"
guy [Tue, 25 Jan 2000 04:44:33 +0000 (04:44 +0000)]
Use "get_basename()" rather than finding the last component of "argv[0]"
by hand.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1553 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoEncapsulate the code to take a pointer to a pathname and return a
guy [Tue, 25 Jan 2000 04:31:17 +0000 (04:31 +0000)]
Encapsulate the code to take a pointer to a pathname and return a
pointer to the name of the file to which it refers (i.e., to the last
component of the pathname) in a "get_basename()" routine, and have the
code in "file.c" call it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1552 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIf we open a file, and immediately try to open another file while the first
gerald [Tue, 25 Jan 2000 03:48:16 +0000 (03:48 +0000)]
If we open a file, and immediately try to open another file while the first
one is loading, we dump core.  Add the "Open..." menu item to the list of
items that we disable while a file is loading.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1551 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoTry to work around the undraw_cursor() bug in GTK+ 1.2.3 - 1.2.6. Setting
gerald [Tue, 25 Jan 2000 03:45:45 +0000 (03:45 +0000)]
Try to work around the undraw_cursor() bug in GTK+ 1.2.3 - 1.2.6.  Setting
the text widget scroll bar adjustment to 0.0 appears to fix things (on my
system, at least).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1550 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate with URLs for the Win32 port on both sides of the Atlantic, and
guy [Tue, 25 Jan 2000 02:11:30 +0000 (02:11 +0000)]
Update with URLs for the Win32 port on both sides of the Atlantic, and
with notes about possible problems with the latest version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1549 f5534014-38df-0310-8fa8-9805f1628bb7

20 years ago"If there aren't any packets to select" means "if there aren't any
guy [Tue, 25 Jan 2000 01:05:06 +0000 (01:05 +0000)]
"If there aren't any packets to select" means "if there aren't any
packets displayed", not just "if there aren't any packets" - there may
be packets but no displayed packets if the display filter didn't find
any packets.

NULL out the pointers to the first and last displayed packet when
closing a capture file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1548 f5534014-38df-0310-8fa8-9805f1628bb7