jmayer [Thu, 3 Jun 2004 16:35:57 +0000 (16:35 +0000)]
monthly update
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11093
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 3 Jun 2004 16:29:39 +0000 (16:29 +0000)]
From Lars Roland: Add have_tap_listeners() and rtp_payload_type_vals
to libethereal.def.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11092
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Jun 2004 14:57:23 +0000 (14:57 +0000)]
enable chm file generation for doxygen,
move chm filename setting to module specific config file
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11091
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Jun 2004 14:54:26 +0000 (14:54 +0000)]
add details for doxygen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11090
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 08:35:44 +0000 (08:35 +0000)]
From Tomas Kukosa: unnecessary types are excluded with NO_EMIT
directive.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11089
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 08:33:29 +0000 (08:33 +0000)]
From Tomas Kukosa:
- limits for dissect_per_constrained_integer() are passed as unsigned
if possible
- new directive NO_EMIT in conformation file - avoids emitting
function body (or vals or both) into packet-xxxx-fn.c file
- new directive USER_DEFINED in conformation file - emitting of
function body (or vals or both) in the packet-xxxx-fn.c file is
replaced with external declaration
- support for SET OF type for BER
- flag WITH_VALS is default for EXPORTS, USER_DEFINED, NO_EMIT
directives
- the _U_ attribute is used for pinfo parameters
- the offset parameters and return codes are changed from guint32 to
int
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11088
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 08:04:07 +0000 (08:04 +0000)]
From Yaniv Kaul: add SOCKS v4a support.
Clean up handling of null-terminated strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11087
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 07:37:49 +0000 (07:37 +0000)]
From Graeme Hewson:
Remove reference to negative slice lengths.
Clean and polish.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11086
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 07:36:25 +0000 (07:36 +0000)]
From Graeme Hewson:
Use gint32 instead of guint32 for node data.
Fix up some other signed-vs-unsigned issues in the display filter
parser and lexical analyzer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11085
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 07:34:49 +0000 (07:34 +0000)]
From Graeme Hewson:
Fix assertion failure when absolute value of negative slice
offset > field length.
Remove code for handling negative slice lengths.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11084
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 07:33:46 +0000 (07:33 +0000)]
From Graeme Hewson:
Check slice lengths as well as offsets. Disallow negative/zero
lengths.
Range on RHS of display filter expression wasn't being checked in
every case.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11083
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 07:17:24 +0000 (07:17 +0000)]
From Graeme Hewson:
Use gint32 instead of guint32 and strtol() instead of strtoul()
for signed integers.
Pathological slice specifications could cause Flex default rule
to be invoked, echoing characters to stdout.
Example: frame[0foo]==1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11082
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 04:19:38 +0000 (04:19 +0000)]
From Devin Heitmueller: improve decoding of outgoing and incoming
message blocks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11081
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 04:13:24 +0000 (04:13 +0000)]
From Mike Frisch:
- fixed tree display of NFSv4 change_info type;
- add OPEN4_RESULT_LOCKTYPE_POSIX to OPEN result (reply) flags;
- fixed open_delegation4 dissector;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11080
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 02:14:50 +0000 (02:14 +0000)]
Make the definition of "register_tap_menu_item()" match its declaration.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11079
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Jun 2004 02:14:14 +0000 (02:14 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11078
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Jun 2004 22:13:04 +0000 (22:13 +0000)]
add details for doxygen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11077
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Jun 2004 20:14:51 +0000 (20:14 +0000)]
add details for doxygen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11076
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 2 Jun 2004 18:49:40 +0000 (18:49 +0000)]
If, when rotating capture files, the attempt to close the current file
fails, set "rb_data.pdh" to NULL, so we know it's not open (if
"wtap_dump_close()" fails, the wtap_dumper_t is still closed - and the
file descriptor for it is probably closed, too, as, if "close()" fails,
the FD is probably closed; the Single UNIX Specification Version 3 says
the state of the FD is unspecified, but in practice most OSes probably
still close it).
If we try to close the current file, first check to make sure it's open,
i.e. that "rb_data.pdh" is non-null. (Or perhaps we should avoid trying
to close it if the open *or* the most recent attempt to rotate the
capture files failed.)
Note that if "wtap_dump_close()" fails we might not need to close the
underlying file descriptor (and, even if we do, there's no guarantee
that attempt won't also fail and leave the FD still open - which is why
I suspect that a failed "close()" leaves the FD closed on most OSes).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11075
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Jun 2004 18:44:10 +0000 (18:44 +0000)]
add details for doxygen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11074
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Jun 2004 07:12:11 +0000 (07:12 +0000)]
move "extern GtkWidget *main_display_filter_widget" from
various stats files to gtkglobals.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11073
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 2 Jun 2004 07:01:04 +0000 (07:01 +0000)]
Get rid of the #if 0'ed out "rtp_payload_type_vals[]" table - we should
be using the one from libethereal.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11072
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 2 Jun 2004 06:50:28 +0000 (06:50 +0000)]
From Mike Frisch:
add support for NFSv4 RELEASE_LOCKOWNER and ILLEGAL operations;
minor modification to the NFSv4 NULLPROC dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11071
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Jun 2004 06:44:40 +0000 (06:44 +0000)]
fix a doxygen comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11070
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 2 Jun 2004 06:35:57 +0000 (06:35 +0000)]
From Yaniv Kaul: HKP is HTTP-based and runs on port 11371.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11069
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 2 Jun 2004 06:30:15 +0000 (06:30 +0000)]
From Magnus Hansson: add more information to the Info column.
Use "tvb_format_stringzpad()" to put a zero-padded string into the
protocol tree and Info column, so that we 1) don't use a fixed-length
buffer that we might overflow and 2) we handle non-printable bytes in
the string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11068
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 23:08:00 +0000 (23:08 +0000)]
Don't define data variables in header files included by more than one
file - that keeps the variable from being shared, and also produces
compiler warnings if the variable isn't used by all the files that
include the header in question.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11067
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 23:00:24 +0000 (23:00 +0000)]
Make the definition of "add_hostlist_table_data()" match its
declaration.
Give the address and port arguments to "add_hostlist_table_data()"
appropriate names and Doxygen comments (they're not a source address and
port, they're just an address and port), and do the same for the address
and port members of a "hostlist_talker_t".
Get rid of extra unnecessary variables in "add_hostlist_table_data()".
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11066
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 22:12:37 +0000 (22:12 +0000)]
bugfix: don't double define rtp_payload_type_vals
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11065
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 22:00:22 +0000 (22:00 +0000)]
minor bugfix from previous check in
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11064
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 1 Jun 2004 21:56:44 +0000 (21:56 +0000)]
From Thomas Anders: MGCP sub-parameter dissection
Anders Broman: BICC,SIP-T dissection
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11063
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 21:56:04 +0000 (21:56 +0000)]
add details for doxygen, various code cleanups as a result of this
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11062
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 1 Jun 2004 21:45:40 +0000 (21:45 +0000)]
Revert previous checkin made by mistake *sigh
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11061
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 1 Jun 2004 21:40:41 +0000 (21:40 +0000)]
From Thomas Anders dissects the RTP Payload Type (if media protocol is RTP/AVP)
with its descriptive name rather than the raw value string,
much like packet-rtp.c does already.
To avoid duplicate definitions, the existing rtp_payload_type_vals[] definition is moved
from packet-rtp.c and gtk/rtp_stream_dlg.c to rtp_pt.h.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11060
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 21:29:50 +0000 (21:29 +0000)]
Make the definition of "add_ett_table_data()" match its declaration.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11059
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 20:37:09 +0000 (20:37 +0000)]
minor bugfix from previous check in
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11058
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 20:28:05 +0000 (20:28 +0000)]
add details for doxygen, various code cleanups as a result of this
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11057
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 18:58:04 +0000 (18:58 +0000)]
Fix a typo.
Clean up white space.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11056
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 18:43:30 +0000 (18:43 +0000)]
Interpret the sampling mode values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11055
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 18:39:13 +0000 (18:39 +0000)]
As Motonori Shindo nodes, the sampling rate and mode in a Netflow V5
header is 2 bits of sampling mode and 14 bits of sample rate, not 16
bits of sample rate.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11054
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 17:37:10 +0000 (17:37 +0000)]
various code cleanups
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11053
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 1 Jun 2004 17:33:37 +0000 (17:33 +0000)]
add details for doxygen, various code cleanups as a result of this
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11052
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 01:03:49 +0000 (01:03 +0000)]
From Yaniv Kaul: PCT support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11051
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 1 Jun 2004 01:01:31 +0000 (01:01 +0000)]
Eliminate a no-longer-used routine.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11050
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 1 Jun 2004 00:15:38 +0000 (00:15 +0000)]
It really helps when you change the default from gtk1 -> gtk2 in the top
level configure.in to mirror that change in wiretap. Otherwise people who
have both versions of glib/gtk installed may see crashes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11049
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 31 May 2004 19:35:53 +0000 (19:35 +0000)]
Add dissection of application PoC1 data
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11048
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 31 May 2004 19:31:14 +0000 (19:31 +0000)]
From Thomas Anders fix some memory leaks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11047
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 15:47:34 +0000 (15:47 +0000)]
add details for doxygen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11046
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 13:42:58 +0000 (13:42 +0000)]
add details for doxygen
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11045
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 13:42:17 +0000 (13:42 +0000)]
split doxygen.cfg into common Ethereal things and module specifics
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11044
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 13:35:49 +0000 (13:35 +0000)]
bugfix: don't try to destroy a dialog twice
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11043
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 12:06:28 +0000 (12:06 +0000)]
directly use the file selection dialog instead of using an additional custom dialog
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11042
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 11:22:58 +0000 (11:22 +0000)]
some more dialog redesign and code cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11041
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 31 May 2004 09:53:21 +0000 (09:53 +0000)]
Add a routine that indicates where there are any tap listeners
registered (not whether there are any tap *filters* registered).
Do dissection in Tethereal iff:
we're printing information about each packet;
we're using a read filter on the packets;
there are any tap listeners registered (even if there are no tap
filters registered - not all taps use filters).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11040
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 31 May 2004 09:23:14 +0000 (09:23 +0000)]
interface options preference dialog: remove confusing second interface clist,
fix a bug making garbage of user supplied interface description
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11039
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 31 May 2004 08:41:32 +0000 (08:41 +0000)]
Make "-q" suppress packet printing when you're reading a capture file
and not writing to another capture file, for use with "-z" options.
Note that "-z proto" *doesn't* print statistics at the end - it modifies
the packet summary output.
Note that on at least some BSDs the "status" character is set to "off"
by default, so you have to set it explicitly in order to be able to ^T
an application such as Tethereal.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11038
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 31 May 2004 07:52:27 +0000 (07:52 +0000)]
Move the packet counting, dissecting, and filtering out of the "write
packet" and "print packet" callbacks into a common routine, so that we
don't count packets twice if we're counting and dissecting.
Print the packet count with ^T iff we're not updating a displayed packet
count as packets arrive, regardless of whether we're printing packet
information, saving packets to a file, or both (tcpdump prints it
regardless of whether it's printing packet information or saving packets
to a file).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11037
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 31 May 2004 02:42:39 +0000 (02:42 +0000)]
The "key" argument to "write_recent_geom()" is required (as it's called
through a pointer), but isn't used - mark it as unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11036
f5534014-38df-0310-8fa8-
9805f1628bb7
obiot [Mon, 31 May 2004 01:24:03 +0000 (01:24 +0000)]
Add support for Exif decoding (initial framework).
Still lots of work to do here :)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11035
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 30 May 2004 18:27:52 +0000 (18:27 +0000)]
sort saved preference settings by appearance in dialog
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11034
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 30 May 2004 17:58:35 +0000 (17:58 +0000)]
From Thomas Anders patch adds sub parameter dissection to the MGCP plugin
(plugins/mgcp/packet-mgcp.c), initially for the ConnectionParameters(P),
and updates/adds some specification references.
This patch makes the sub parameter values filterable as numbers and
may allow for improved MGCP statistics in the future.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11033
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 30 May 2004 11:54:37 +0000 (11:54 +0000)]
save window position/size/maximized state into recent file
(only help dialog for now)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11032
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 May 2004 06:55:52 +0000 (06:55 +0000)]
When we create a tvbuff for a security blob, set its reported length to
the reported length of the blob, not the amount of data available from
the blob.
Use "tvb_strneql()" when checking for strings, so that we don't throw an
exception if there's less data in the tvbuff than there are bytes in the
string, we just say "not equal".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11031
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 May 2004 04:41:25 +0000 (04:41 +0000)]
From Nathan Alger: update the VSA attributes for Juniper and
Juniper/Unisphere routers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11030
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 29 May 2004 04:34:51 +0000 (04:34 +0000)]
Squelch a compiler warning by removing a "/*" from the middle of a
comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11029
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 29 May 2004 01:00:59 +0000 (01:00 +0000)]
check in Thomas Anders patch to SNMP to allow ethereal to dissect
properly COUNTER64 objects that are not spanning a full 64 bit on the wire
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11028
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 28 May 2004 20:59:56 +0000 (20:59 +0000)]
connectionless cancel PDU's don't have a dg_server_accepting_cancels field
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11027
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 23:09:09 +0000 (23:09 +0000)]
enable postcript printing if selected in prefs,
correctly remove temporary file on close dialog
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11026
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 21:55:59 +0000 (21:55 +0000)]
bugfixes: fixed printing on win32,
and convert none printable characters, so printing will work on binary output as well
(like in the GUI output)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11025
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 21:52:07 +0000 (21:52 +0000)]
win_printer is gboolean, not an int
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11024
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 21:48:10 +0000 (21:48 +0000)]
added a small comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11023
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 27 May 2004 21:42:54 +0000 (21:42 +0000)]
Tag the "has_child" argument to "prefs_tree_page_add()" as unused when
building with GTK+ 2.x or later, as it's only needed and only used for
1.2[.x].
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11022
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 19:59:50 +0000 (19:59 +0000)]
use gtk_window_set_default_size() instead of WIDGET_SET_SIZE() for the dialogs,
as WIDGET_SET_SIZE() will prevent the user from shrinking the dialog,
and gtk_window_set_default_size() will not
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11021
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 27 May 2004 18:12:58 +0000 (18:12 +0000)]
Get rid of an unused variable.
Mark as unused a required argument that's unused.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11020
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 17:26:46 +0000 (17:26 +0000)]
added a small comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11019
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 17:08:50 +0000 (17:08 +0000)]
bugfix: don't try to destroy a window, when it's already being destroyed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11018
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 16:50:16 +0000 (16:50 +0000)]
a lot of code cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11017
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 16:48:36 +0000 (16:48 +0000)]
bugfix: don't try to destroy a window, when it's already being destroyed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11016
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 16:43:01 +0000 (16:43 +0000)]
added some tooltips
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11015
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 27 May 2004 16:41:33 +0000 (16:41 +0000)]
Don't point to the manpage for the list of authors, it's in the about dialog now
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11014
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 27 May 2004 08:33:22 +0000 (08:33 +0000)]
the isns timestamp is in fact a 64 bit integer and not a 32 bit integer.
declaring it properly will make ethereal dissect it properly as well
instead of crashing
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11013
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 27 May 2004 08:22:04 +0000 (08:22 +0000)]
make KRB_SAFE more consistent with the other PDUs by removing the SAFE expansion.
cosmetic: Put the application type on the kerberos subtree
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11012
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 26 May 2004 21:23:20 +0000 (21:23 +0000)]
Don't compile in "follow_save_as_destroy_cb()" for GTK+ 2.4 and later,
as it's not used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11011
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Wed, 26 May 2004 12:08:15 +0000 (12:08 +0000)]
Make gtk2 the default. Use --disable-gtk2 to use glib1/gtk1 instead
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11010
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Wed, 26 May 2004 11:37:36 +0000 (11:37 +0000)]
Change C++ style comments
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11009
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 26 May 2004 11:25:20 +0000 (11:25 +0000)]
in dissect_ber_bitstring32()
It is not neccessary that the encoded bitstring is actually encoded as 4 bytes.
Make sure, that if the bistring is encoded in less than 4 bytes that we
still do the right thing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11008
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 26 May 2004 11:04:15 +0000 (11:04 +0000)]
remove the SAFE_BODY expansion to make KRB5_MSG_SAFE look more consistent
with the other application dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11007
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Wed, 26 May 2004 10:41:14 +0000 (10:41 +0000)]
Run libtoolize after aclocal.m4 has been generated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11006
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 26 May 2004 08:53:45 +0000 (08:53 +0000)]
implementation of the KRB_SAFE application
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11005
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 26 May 2004 04:21:49 +0000 (04:21 +0000)]
Get rid of some declarations of routines that no longer exist.
Fix up some declarations of other routines to match the definitions of
those routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11004
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 26 May 2004 03:49:24 +0000 (03:49 +0000)]
more code cleanup from dialog things:
changed window_xy (dialog) function calling in a lot of gtk files
cleanup of file selection code
cleanup in dlg_utils/file_dlg/ui_util
Please report any problems!!!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11003
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 26 May 2004 02:33:37 +0000 (02:33 +0000)]
Don't capitalize "Filter" in "Display Filter" in the "Find" dialog box,
just as we don't capitalize "value" in "Hex value" in the same set of
radio buttons.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11002
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 May 2004 21:27:02 +0000 (21:27 +0000)]
The function pointer in a "per_choice_t" or a "per_sequence_t" is to a
function that returns "int", not "guint32"; declare one such function as
such, and note that the function it calls should perhaps also use "int"
for packet-offset arguments and return values (or, rather, that the code
that generated it should generate functions that do so).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11001
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 May 2004 21:24:03 +0000 (21:24 +0000)]
The function pointer in a "per_choice_t" or a "per_sequence_t" is to a
function that returns "int", not "guint32"; re-generate "packet-h235.c",
from the new "asn2eth.py", to define those functions to return "int".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11000
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 May 2004 21:23:09 +0000 (21:23 +0000)]
The function pointer in a "per_choice_t" or a "per_sequence_t" is to a
function that returns "int", not "guint32"; define those functions to
return "int".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10999
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 May 2004 21:08:33 +0000 (21:08 +0000)]
Declare the "value_string" tables as "extern", to avoid problems when
building a shared libethereal on some platforms.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10998
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 May 2004 21:07:43 +0000 (21:07 +0000)]
"NOT_DECODED_YET()" was replaced by "PER_NOT_DECODED_YET()" and
"BER_NOT_DECODED_YET()"; use the right one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10997
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 25 May 2004 21:06:54 +0000 (21:06 +0000)]
Replace some Windows dash/hyphen character with a "-" in some comments.
Make the header files declare the "value_string" arrays as "extern", so
as to prevent problems on some platforms when building a shared
libethereal.
Note that, at least currently, we have separate "PER_NOT_DECODED_YET()"
and "BER_NOT_DECODED_YET()" macros, rather than a common
"NOT_DECODED_YET()" macro.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10996
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 25 May 2004 19:48:40 +0000 (19:48 +0000)]
fix the timestamp problem in h225
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10995
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 25 May 2004 10:17:34 +0000 (10:17 +0000)]
get rid of some compiler warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10994
f5534014-38df-0310-8fa8-
9805f1628bb7