ulfl [Mon, 11 Apr 2005 18:57:19 +0000 (18:57 +0000)]
various capture code cleanup and fixes:
display filename in statusbar while capturing
print_usage banner fixed
cf_cb_live_capture_prepare no longer needed
rename sync_pipe_do_capture -> sync_pipe_start
bugfix: sync_pipe_input_wait_for_start replaced by former implementation
fix cleanup of old file in capture_input_new_file
fix a tempfile detection bug (named file showed up as tempfile after capture)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14053
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 11 Apr 2005 18:39:31 +0000 (18:39 +0000)]
fix some error handling
fflush new output file (to have at least the pcap header on disk) before sending the corresponding message to the capture parent
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14052
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 11 Apr 2005 08:43:51 +0000 (08:43 +0000)]
Major speed improvement for filtering and dissection.
It should not dump core as far as all my tests are concerned and Menu_Statistics/ProtocolHierStats work
It needs more testing and there might still be cases where it will crash that will need to be fixed but I feel it will be worth it since it will decrease the time to filter very large capture files dramatically.
Real significant performance boost for very large captures.
(If we cant fix all the problems we can just revert this patch)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14051
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 11 Apr 2005 01:57:00 +0000 (01:57 +0000)]
Add a note about testing to the "Robustness" section.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14050
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 11 Apr 2005 00:10:50 +0000 (00:10 +0000)]
add some missing menu items, describe changes in the -b ring buffer command line parameter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14049
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 10 Apr 2005 23:17:05 +0000 (23:17 +0000)]
Remove debugging printf()s.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14048
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 23:13:35 +0000 (23:13 +0000)]
disable /View/Resize Columns menu item, if no packets available
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14047
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 10 Apr 2005 23:12:48 +0000 (23:12 +0000)]
Add an option to Editcap that adds various types of errors to the capture
file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14046
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 21:03:31 +0000 (21:03 +0000)]
bugfix: call to cf_cb_live_capture_..._started with correct parameter
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14045
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 19:36:56 +0000 (19:36 +0000)]
fix statusbar messages by splitting into update and fixed messages between capture and main
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14044
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 17:36:36 +0000 (17:36 +0000)]
bugfix: hide panes if a non "Update" capture had no packets captured (hopefully it's working correct now...)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14043
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 17:18:45 +0000 (17:18 +0000)]
bugfix: call cf_cb_live_capture_finished *if* some packets were captured
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14042
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 17:08:32 +0000 (17:08 +0000)]
fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14041
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 16:43:22 +0000 (16:43 +0000)]
Win32 only bugfix: as using TerminateProcess is the brute force way and sometimes clipped packets in the middle, now using a pipe called signal_pipe from the parent to the child for this.
On unix we're using kill() for this, which simply signals the child, but this isn't available on win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14040
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 15:35:41 +0000 (15:35 +0000)]
bugfix: when no packets were captured, don't call cf_cb_live_capture_finished after closing the capture file
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14039
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 14:29:12 +0000 (14:29 +0000)]
refactoring of the capture startup (while the capture parent waits for the child to start)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14038
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 10 Apr 2005 13:43:07 +0000 (13:43 +0000)]
fix descriptive texts, so they fit into the window
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14037
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Apr 2005 08:55:56 +0000 (08:55 +0000)]
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14036
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Apr 2005 08:51:46 +0000 (08:51 +0000)]
Clean up white space, and tweak a comment slightly ("message" in the
error message case referred to the error message text, not the message
on the pipe).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14035
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Apr 2005 08:31:27 +0000 (08:31 +0000)]
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14034
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Apr 2005 08:28:08 +0000 (08:28 +0000)]
Make it slightly clearer that the bitwise AND operator evaluates to a
Boolean value that's true if any of the bits in question are set and
false if none of them are, not to an integer or slice value with the
only the bits set in both values set.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14033
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 9 Apr 2005 01:28:23 +0000 (01:28 +0000)]
KRB_ERROR can be returned and it is not encapsulated
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14032
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 8 Apr 2005 20:28:24 +0000 (20:28 +0000)]
Fix brokenness from previous patch.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14031
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 8 Apr 2005 19:14:05 +0000 (19:14 +0000)]
Add a length check.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14030
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 8 Apr 2005 19:09:46 +0000 (19:09 +0000)]
Add a length check, fix up some comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14029
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 8 Apr 2005 11:25:18 +0000 (11:25 +0000)]
From Martin M
updates to MGCP
checked in per Anders B request hope it compiles
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14028
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 8 Apr 2005 10:28:44 +0000 (10:28 +0000)]
From Neil Kettle
Fix two potential buffer overflow bugs in fc els
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14027
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 7 Apr 2005 12:00:03 +0000 (12:00 +0000)]
From Didier:
optimization for COLUMNS to make ethereal faster when filtering
optimization to make the slow find_protocol_by_id() fast.
(idea from Didier, implementation modified by me to be less intrusive)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14026
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 7 Apr 2005 10:04:50 +0000 (10:04 +0000)]
updating Mark C Browns information
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14025
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 7 Apr 2005 09:44:58 +0000 (09:44 +0000)]
make the ip ip field we use as the reassembly key a bit more
"unique" by mixing in the source and destination address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14024
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 7 Apr 2005 09:14:35 +0000 (09:14 +0000)]
From Francisco Alcoba
Very cool ASCII art version of viop graphs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14023
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 7 Apr 2005 08:32:49 +0000 (08:32 +0000)]
From Greg Morris
Fix the breakage from my previous patch
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14022
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 6 Apr 2005 21:28:02 +0000 (21:28 +0000)]
add Ilya Konstantinov
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14021
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 6 Apr 2005 21:24:00 +0000 (21:24 +0000)]
from Ilya Konstantinov: fixed a bug as DND wasn't working with GNOME, I've also added a comment how GNOME handles these things
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14020
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 5 Apr 2005 20:20:21 +0000 (20:20 +0000)]
use proto_item_appent_text() instead of proto_item_append_string() since the hf field is not neccessarily a FT_STRING value always.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14019
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 5 Apr 2005 14:40:59 +0000 (14:40 +0000)]
Try not to call proto_tree_add_text() with negative lengths in error messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14018
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 5 Apr 2005 08:14:58 +0000 (08:14 +0000)]
From Francisco Alcoba
patch for viop analysis to fix the breakage from the tap reordering patch
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14017
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2005 21:44:53 +0000 (21:44 +0000)]
Add length checks so that we don't overflow buffers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14016
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 4 Apr 2005 20:12:18 +0000 (20:12 +0000)]
From Lars Ruoff
Make it possible to tap 4 PDUs from one frame
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14015
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2005 18:10:42 +0000 (18:10 +0000)]
Don't generate a "dissector bug" warning in cases where a dissector calls
proto_tree_add_*(tree, tvb, offset, 0, ...);
and "offset" is greater than the length remaining in the tvbuff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14014
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 4 Apr 2005 07:40:07 +0000 (07:40 +0000)]
From Cvetan Ivanov
Updates to Q931, SM and ISUP
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14013
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 4 Apr 2005 05:56:57 +0000 (05:56 +0000)]
the definition of tcp address structure changed between version 3 and version 4
make version 4 dissect tcp addr structure properly
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14012
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 4 Apr 2005 05:10:45 +0000 (05:10 +0000)]
From Kenny Shumard
Update for IAX2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14011
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 4 Apr 2005 04:51:47 +0000 (04:51 +0000)]
From Martin Mathieson
small update for SIP request/response matching.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14010
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 4 Apr 2005 04:14:41 +0000 (04:14 +0000)]
the netware dissector is the only dissector that accesses fvalue_ functions directly.
this made it crash for some packets when the filter speedup patch was enabled, since some of these finfo nodes did no longer exist.
as far as i can tell the only other instances of fvalue_ usage is from some tap based functions but all those do take care to make sure that the fields being accessed are all part of a filter, and will thus never be optimized away.
The patch does two things
1, refactor the code but do not change the logic to reduce the number of places where the external fvalue_ functions are called from.
2, add code to force the tree to be visible (and thus change the code) so that the speedup patch will not optimize these fiuelds away.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14009
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Apr 2005 03:01:40 +0000 (03:01 +0000)]
Add a couple of length checks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14008
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 3 Apr 2005 12:05:05 +0000 (12:05 +0000)]
Fix up the table of encapsulation type strings to match the new set of
encapsulation types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14007
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 3 Apr 2005 11:00:49 +0000 (11:00 +0000)]
Make editcap use wtap_read(); that eliminates the last user of
wtap_loop(), so eliminate wtap_loop().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14006
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 2 Apr 2005 18:51:38 +0000 (18:51 +0000)]
From Tim Endean:
1) Return errors.
2) Return rejects.
Numerous other bugs fixed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14005
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 2 Apr 2005 18:50:57 +0000 (18:50 +0000)]
From Tim Endean:
1) Return errors.
2) Return rejects.
Numerous other bugs fixed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14004
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 1 Apr 2005 21:23:40 +0000 (21:23 +0000)]
from Jeremy Jouglet
some GTP updates and some tips for those using cygwin
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14003
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 1 Apr 2005 21:04:55 +0000 (21:04 +0000)]
update for padbyte on old juniper boxens
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14002
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 1 Apr 2005 20:55:33 +0000 (20:55 +0000)]
from Lars R
TAP order of caller update
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14001
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 1 Apr 2005 11:12:32 +0000 (11:12 +0000)]
tiny bugfix for gsmmap
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14000
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 1 Apr 2005 10:17:05 +0000 (10:17 +0000)]
From Mark C Brown NETTL updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13999
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 10:04:32 +0000 (10:04 +0000)]
Give it an RCS ID.
Set the svn:keywords and svn:eol-style properties to the standard values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13998
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 1 Apr 2005 09:48:34 +0000 (09:48 +0000)]
From Giles Scott
New protocol ARUBA ADP
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13997
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 09:43:19 +0000 (09:43 +0000)]
From Charlie Lenahan: support for some HP switch protocol.
Fix some damage to the AUTHORS file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13996
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 09:20:39 +0000 (09:20 +0000)]
Get rid of an unused variable.
Include "packet-gsm_map.h", not "packet-gsm_map.c".
Check in the regenerated CAMEL dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13995
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 09:19:29 +0000 (09:19 +0000)]
"get_conv_info()" doesn't use the tvbuff passed to it, so don't pass it
one.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13994
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 09:08:27 +0000 (09:08 +0000)]
Rename "register_ethereal_tap()" to "register_tap_listener_cmd_arg()" as
it's used to register a callback for a tap listener invoked if the
specified command line argument is specified to the "-z" flag.
Move it, along with routines to:
look up a "-z" argument in the table constructed by
"register_tap_listener_cmd_arg()" and either save the full
argument to "-z" and the corresponding listener if it's found or
return a failure indication if it isn't;
list the available tap listeners;
call the "init" routines for the tap listeners saved in the
table above;
and have Ethereal and Tethereal use those routines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13993
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 08:47:42 +0000 (08:47 +0000)]
Edits, update to current "all GTK+ stuff is common" state.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13992
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 05:45:08 +0000 (05:45 +0000)]
Don't assume only one "-z" argument will be given on the command line;
add information for each tap to a list, and set up all the taps in the
list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13991
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 1 Apr 2005 04:19:28 +0000 (04:19 +0000)]
Give the RFC number for IGMPv3.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13990
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 31 Mar 2005 23:48:08 +0000 (23:48 +0000)]
Fix a couple of "proto_tree_add_text()" calls to pass the right arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13989
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 31 Mar 2005 22:04:59 +0000 (22:04 +0000)]
Add a link to a more recent Apple page describing DSI.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13988
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 31 Mar 2005 18:51:14 +0000 (18:51 +0000)]
Included packet-gsm_map.h and removed unpack_digits as it now is exported from gsm_map, as it isn't used
yet no need to regenerate the dissector now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13987
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 31 Mar 2005 18:41:44 +0000 (18:41 +0000)]
From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13986
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 31 Mar 2005 18:39:45 +0000 (18:39 +0000)]
From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13985
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 31 Mar 2005 18:34:25 +0000 (18:34 +0000)]
From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13984
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 31 Mar 2005 07:59:43 +0000 (07:59 +0000)]
shaftnet.org/~pizza/software/capturefrm.txt is currently not
available; add an archive.org URL for it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13983
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 31 Mar 2005 04:50:48 +0000 (04:50 +0000)]
Further IE dissection updates.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13982
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 30 Mar 2005 19:10:26 +0000 (19:10 +0000)]
Small bug fix
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13981
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 30 Mar 2005 19:09:48 +0000 (19:09 +0000)]
Improve some debug messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13980
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 30 Mar 2005 19:08:39 +0000 (19:08 +0000)]
Update and small bugfix
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13979
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Wed, 30 Mar 2005 16:16:07 +0000 (16:16 +0000)]
Fix the handling of the length parameter in the DATA chunk.
This is a quick fix. A systematic follows...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13978
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 30 Mar 2005 13:37:27 +0000 (13:37 +0000)]
From Ulf Lamping:
Fix a "off by one" error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13977
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 30 Mar 2005 09:18:25 +0000 (09:18 +0000)]
From Tim
small bugfix for packet-ber.c if packet is malformed, prevent dereferenceing a null pointer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13976
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 30 Mar 2005 01:06:12 +0000 (01:06 +0000)]
Make it a bit clearer that what "-w" writes is raw binary packet data,
not the result of dissecting that data.
Note that "-F" applies to the output of "-w", that "-S" says "dissect
and print even if you're doing '-w'", and that "-T" applies to the
dissected output, not the "-w" output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13975
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 29 Mar 2005 22:23:09 +0000 (22:23 +0000)]
Add a tvb_ensure_bytes_exist() and fix a few other offset-related bugs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13974
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2005 20:58:03 +0000 (20:58 +0000)]
From Martin Mathieson:
- bump up SDP_MAX_PAYLOAD_TYPES to 20 (I have an mgcp capture where a media
gateway responded with 12 media types, resulting in a crash). Probably more
care needs to be taken while parsing the list of media types though...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13973
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 29 Mar 2005 20:56:42 +0000 (20:56 +0000)]
From Martin Mathieson :
- allow dissector to show "MGCP/SDP" in the Protocol column, at least when
the 'Display the number of MGCP messages' preference is switched off
- when displaying the command verb, show in the tree the full verb name as
well as the 4-letter code
- show the links to response and request messages as being [generated]
- fixed some indentation problems
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13972
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 29 Mar 2005 19:52:04 +0000 (19:52 +0000)]
Remove a g_assert() left over from debugging.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13971
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 29 Mar 2005 16:11:11 +0000 (16:11 +0000)]
Use an offset of 0 in PER_NOT_DECODED_YET() so that we don't generate a
dissector bug error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13970
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 29 Mar 2005 16:02:02 +0000 (16:02 +0000)]
Fix a compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13969
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 29 Mar 2005 15:38:11 +0000 (15:38 +0000)]
Add a tvb_ensure_bytes_exist().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13968
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 29 Mar 2005 14:56:09 +0000 (14:56 +0000)]
README.developer says:
"PROTOABBREV A name for the protocol for use in filter expressions;
it should contain only lower-case letters, digits, and
hyphens."
In proto_register_protocol(), generate a warning if PROTOABBREV contains
invalid characters. Along with the list above, allow underscores and
periods. Fix up whitespace.
Lower-case PROTOABBREV in several dissectors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13967
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 29 Mar 2005 12:36:40 +0000 (12:36 +0000)]
from Sid
updates to FTAM
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13966
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 29 Mar 2005 12:27:13 +0000 (12:27 +0000)]
from Sid
bugfix for ACSE
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13965
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 29 Mar 2005 10:58:08 +0000 (10:58 +0000)]
from Lars Ruoff
rtp analysis optimization
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13964
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 28 Mar 2005 22:35:35 +0000 (22:35 +0000)]
Add a tvb_ensure_bytes_exist().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13963
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 21:35:21 +0000 (21:35 +0000)]
some minor changes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13962
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 21:05:53 +0000 (21:05 +0000)]
bugfixes: bring non real-time captures back to former behaviour, other minor fixes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13961
f5534014-38df-0310-8fa8-
9805f1628bb7
ashokn [Mon, 28 Mar 2005 19:32:39 +0000 (19:32 +0000)]
Minor change to Call-ID dissector to set up object line.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13960
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 28 Mar 2005 19:19:19 +0000 (19:19 +0000)]
Pass a NULL instead of an empty string in the value_string/true_false_string
field of hf_rtp_payload_type. This should fix the "values output" test failures
in the FreeBSD builder.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13959
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 18:08:31 +0000 (18:08 +0000)]
bugfix: don't call tvb_length_remaining() if tvb is NULL
but what to do instead?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13958
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 18:04:09 +0000 (18:04 +0000)]
various (minor) capture code cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13957
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 16:14:34 +0000 (16:14 +0000)]
fix Solaris build (I've removed O_BINARY)
rename sync_mode to real_time_mode, as we using sync_mode all the time now, so the name is misleading
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13956
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 28 Mar 2005 15:55:47 +0000 (15:55 +0000)]
In tvb_get_string(), throw an exception if our length is less than zero.
Add a message block length check to the AIM dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13955
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 15:31:13 +0000 (15:31 +0000)]
remove capture_child flag from capture_opts as it's no longer required
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13954
f5534014-38df-0310-8fa8-
9805f1628bb7