guy [Mon, 19 Jun 2000 08:33:50 +0000 (08:33 +0000)]
Make the "isis_hello.source_id" an FT_BYTES field rather than an
FT_ETHER field; the ISIS spec doesn't say it's necessarily a 6-byte
Ethernet address (and, if it's FT_BYTES, you can test it in a filter
much the same way you test an Ethernet address).
Make "isis_hello.lan_id" an FT_BYTES field rather than an FT_STRING
field - it's an array of bytes, not a character string.
Don't require that "system ID" fields be 6 octets; use the size value
from the ISIS PDU header. (This means that PDUs containing "system ID"
fields can't be described as C structures; dissect them by stepping the
offset instead.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2080
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 19 Jun 2000 04:49:36 +0000 (04:49 +0000)]
ISIS is ISO standard 10589, not 10598.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2079
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 18 Jun 2000 22:12:14 +0000 (22:12 +0000)]
Get rid of string overrun.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2078
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 17 Jun 2000 05:56:22 +0000 (05:56 +0000)]
Instead of calling "snmp_set_full_objid()" to cause OIDs to be displayed
symbolically as full sequences, call "snmp_set_suffix_only(2)" to cause
them to be displayed symbolically as a module name and a name within
that module, as that might make it easier to find the RFC or whatever
that describes the object in question.
Don't just statically call it, though, on Linux, as that causes binaries
built on Red Hat releases prior to 6.2 to fail to run on 6.2, due to the
UCD SNMP 4.1.1 library used in RH 6.2 not being 100% binary-compatible
with the UCD SNMP libraries used in those prior releases. Instead, on
Linux, try to "dlopen()" the "libsnmp.so" library and, if that succeeds,
try to find "snmp_set_suffix_only()" in that library - if that succeeds,
call it, otherwise try to find "ds_set_int()" in that library and, if
*that* succeeds, call it with the arguments that, in UCD SNMP 4.1.1, the
"snmp_set_suffix_only()" macro passes to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2077
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 17 Jun 2000 03:05:02 +0000 (03:05 +0000)]
Add braces to squelch a warning from GCC 2.8.1 on Solaris 7/x86.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2076
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 16 Jun 2000 15:05:26 +0000 (15:05 +0000)]
Small patch for the win32 makefile that improves the dependencies and
prints out exactly which executable is being linked.
From Graham Bloice <graham.bloice@trihedral.com>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2075
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 15 Jun 2000 08:02:43 +0000 (08:02 +0000)]
Changes from Graham Bloice to support "Update list of packets in real
time" during captures on Win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2074
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 15 Jun 2000 07:49:25 +0000 (07:49 +0000)]
Patch from Joerg Mayer:
Make "tethereal -h" look as similar to "ethereal -h" as
possible. The ethereal help was the "better" of the two.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2073
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 15 Jun 2000 06:18:32 +0000 (06:18 +0000)]
Patch from Joerg Mayer to fix a problem reading Sniffer files:
Differentiate between LAPB and LAPD sync sniffer traces.
Personally I think there must be a better way to find out which
protocol is in the trace but I currently lack the time to look
at the remaining frame info.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2072
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 15 Jun 2000 06:13:08 +0000 (06:13 +0000)]
Patch from Joerg Mayer to fix a problem reading Sniffer files:
When trying to decode a sample trace from the NG offline sniffer
installation, one trace resulted in a "corrupted" error. The
reason was, that the file was a version 2 file format. That
format used type 8 for header purposes while version 4 uses it
for FRAME4.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2071
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 15 Jun 2000 04:23:06 +0000 (04:23 +0000)]
Mark Clayton's patch to add support for capturing on ATM interfaces on
Linux (call the until-now-unused "capture_clip()" routine for each
packet).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2070
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 15 Jun 2000 04:09:22 +0000 (04:09 +0000)]
Fix typos in some printf formats - "+%d", not "%+d"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2069
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 15 Jun 2000 03:49:00 +0000 (03:49 +0000)]
Convert IPX-and-friend dissectors in packet-ipx.c to use
tvbuffs.
In doing so, I realied that my recommendation for using
tvb_new_subset(pi.compat_top_tvb, -1, -1) was incorrect, because
some dissectors (ethernet!) change pi.len and pi.cap_len. So, I have
to take those two variables into account instead of using -1 and -1.
So, I provide a macro called tvb_create_from_top(offset), where
offset is the name of your offset variable. It is a wrapper around
tvb_new_subset().
I converted the lines that followed my suggestion to use
tvb_create_from_top().
In proto.c I added
proto_tree_add_debug_text(proto_tree*, const char*, ...)
It's much like proto_tree_add_text(), except that it takes no offset
or length; it's soley for temporarily putting debug text into the
proto_tree while debugging a dissector. In making sure that its
use is temporary, the funciton also prints the debug string to stdout
to remind the programmer that the debug code needs to be removed
before shipping the code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2068
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 14 Jun 2000 19:53:37 +0000 (19:53 +0000)]
Added a passel-o-codes from Gaetan Soltesz <gaetan@cisco.com>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2067
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 14 Jun 2000 07:16:07 +0000 (07:16 +0000)]
When building under Win32, "boolean" appears to be defined in a fashion
that causes "packet-x11.c" to fail to compile due to it defining its own
function named "boolean", so we rename the "packet-x11.c" "boolean()"
function to "add_boolean()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2066
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 14 Jun 2000 00:24:39 +0000 (00:24 +0000)]
In "stringCopy()", make the character temporary unsigned, so that it
doesn't get sign-extended before being handed to "isgraph()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2065
f5534014-38df-0310-8fa8-
9805f1628bb7
itojun [Tue, 13 Jun 2000 10:37:24 +0000 (10:37 +0000)]
tos_str is no longer used. it was superseded by iptos_vals.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2064
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 12 Jun 2000 19:19:54 +0000 (19:19 +0000)]
Initialize 'int next_offset' to 0 instead of NULL.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2063
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Mon, 12 Jun 2000 10:01:54 +0000 (10:01 +0000)]
Convert the DDTP dissector to use tvbuffs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2062
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 12 Jun 2000 09:32:06 +0000 (09:32 +0000)]
Don't include <X11/Xlib.h> to get AllPlanes defined; that causes the
build to fail on Win32 systems. It's defined (at least in the X11R6 on
my FreeBSD 3.4 system) as "((unsigned long)~0L)", which presumably means
"set all the bits" - which means "set all 32 bits" in the "value_string"
table where it appears, as the value member of an entry in such a table
is a "guint32", so just use 0xFFFFFFFF.
Get rid of other unneeded #includes as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2061
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 12 Jun 2000 08:47:34 +0000 (08:47 +0000)]
Use "dissect_rpc_list()" to dissect NFS READDIR/READDIRPLUS reply lists
and portmapper DUMP reply lists, rather than duplicating what
"dissect_rpc_list()" does.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2060
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 12 Jun 2000 08:28:13 +0000 (08:28 +0000)]
Partial tvbuffification of the X11 dissector; we construct a tvbuff from
the top-level "compatibility" tvbuff, so that we don't blow up if we get
short frames *or* misinterpret data due to, for example, trying to treat
the initial client->server message in a connection as an X11 request, or
interpreting the middle of a multi-frame request (e.g., a big PutImage)
as if it contained requests. (I have a capture file on which the
non-tvbuffified code crashed.)
Attempt to dissect requests until we reach the end of the frame, even if
that would take us past the end of the captured data in the frame before
we reach the end of the frame; the tvbuff code will throw an exception
if we go past the end of the captured data, which means it'll put a
"Short frame" indication into the protocol tree, which is what we want
(the frame *is* short, because the capture length was too short).
Define functions taking no arguments with a "(void)" argument list, so
that the compiler knows that they must not be passed any arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2059
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 12 Jun 2000 02:38:13 +0000 (02:38 +0000)]
Add "packet-syslog.c".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2058
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 12 Jun 2000 02:30:35 +0000 (02:30 +0000)]
Christophe Tronche's X11 dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2057
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 11 Jun 2000 15:54:03 +0000 (15:54 +0000)]
Add syslog support to randpkt.
Fix problems revealed by randpkt, add OS-specific info.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2056
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 11 Jun 2000 07:49:36 +0000 (07:49 +0000)]
Search for the GDK library in $(GTK_DIR)\gdk rather than in
$(GTK_DIR)\gdk\win32 - the latest GTK+ packages for Win32 don't put it
in a "win32" subdirectory.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2055
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 11 Jun 2000 05:19:21 +0000 (05:19 +0000)]
Add syslog message dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2054
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Sat, 10 Jun 2000 18:08:17 +0000 (18:08 +0000)]
DDTP has been assigned port 1052 for both client and server by the IANA.
I updated the dissector_add() calls to reflect this change.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2053
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 9 Jun 2000 21:15:46 +0000 (21:15 +0000)]
Mark 2 local functions as 'static'.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2052
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 8 Jun 2000 19:07:13 +0000 (19:07 +0000)]
Changed long registration name for L2TP to spelled-out name, without
a redundant "P".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2051
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 8 Jun 2000 03:14:46 +0000 (03:14 +0000)]
The last bit of news for 0.8.9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2049
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 8 Jun 2000 03:12:52 +0000 (03:12 +0000)]
Let people know that this document is useful for both compiling
and using Ethereal on Win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2048
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 8 Jun 2000 03:09:32 +0000 (03:09 +0000)]
Document the fact that we can now read compressed Sniffer files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2047
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 8 Jun 2000 03:03:43 +0000 (03:03 +0000)]
Document how to create a tvbuff inside a dissector-table-called dissector,
using packet-cops.c as an example.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2046
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 7 Jun 2000 22:58:20 +0000 (22:58 +0000)]
Mention Heikki as the COPS author.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2045
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 7 Jun 2000 22:57:45 +0000 (22:57 +0000)]
Add COPS dissector (with a few fixes for compiling on Win32).
I put the header file info in packet-cops.c since no one else uses it.
Fix the version number and plugin directory in config.h.win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2044
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 7 Jun 2000 11:37:08 +0000 (11:37 +0000)]
Fix L2TP so that dissect_ppp() is called.
Convert L2TP dissector to use tvbuffs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2043
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 7 Jun 2000 02:37:06 +0000 (02:37 +0000)]
Move to version 0.8.9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2042
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 6 Jun 2000 16:21:26 +0000 (16:21 +0000)]
Fix list of deliverables (add wtap-int.h)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2041
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 5 Jun 2000 18:59:12 +0000 (18:59 +0000)]
Add news for 0.8.9.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2040
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 5 Jun 2000 03:21:03 +0000 (03:21 +0000)]
Change dissect_ah() so that dissect_ip() doesn't have to make a
special case for it. dissect_ah() is registered with the "ip.proto"
handoff table, and dissect_ah() calls the next dissector using this
same "ip.proto" handoff table.
The old dissect_ah() is kept as dissect_ah_old() since dissect_ipv6()
still uses it. I need to convert some more functions before I can
get rid of dissect_ah_old().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2039
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Mon, 5 Jun 2000 03:09:21 +0000 (03:09 +0000)]
Add gtk_set_locale() as recommended by
"Kaoru.Kusunoki" <kusunoki@mbox.kyoto-inet.or.jp>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2038
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 2 Jun 2000 16:43:46 +0000 (16:43 +0000)]
Show ICMP sequence number as two bytes, not as integer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2037
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 2 Jun 2000 13:24:12 +0000 (13:24 +0000)]
Correctly handle Resv Tear Confirm message.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2036
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 2 Jun 2000 03:35:39 +0000 (03:35 +0000)]
Add a "Enable name resolution" check box to the File Open dialogue.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2035
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 31 May 2000 18:32:15 +0000 (18:32 +0000)]
Fix plugin function table so that plugins work on Win32.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2034
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 31 May 2000 17:10:10 +0000 (17:10 +0000)]
Get rid of the only uses of proto_tree_add_item_old() and
proto_tree_add_item_hidden_old(), and get rid of the functions as well.
Also remove a static function in proto.c that is no longer used
(it was used by proto_tree_add_item()).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2033
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 31 May 2000 16:49:42 +0000 (16:49 +0000)]
Correct the URL for Dante.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2032
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 31 May 2000 05:09:07 +0000 (05:09 +0000)]
Add routines for adding items to a protocol tree that take arguments of
a particular type, rather than taking a varargs list, along the lines of
the "proto_tree_add_XXX_format()" routines.
Replace most calls to "proto_tree_add_item()" and
"proto_tree_add_item_hidden()" with calls to those routines.
Rename "proto_tree_add_item()" and "proto_tree_add_item_hidden()" to
"proto_tree_add_item_old()" and "proto_tree_add_item_hidden_old()", and
add new "proto_tree_add_item()" and "proto_tree_add_item_hidden()"
routines that don't take the item to be added as an argument - instead,
they fetch the argument from the packet whose tvbuff was handed to them,
from the offset handed to them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2031
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 31 May 2000 03:58:56 +0000 (03:58 +0000)]
Convert LAPD and V.120 dissector to use tvbuff. Convert xdlc dissector-helper,
too.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2030
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 30 May 2000 09:52:30 +0000 (09:52 +0000)]
Define "proto_tree" and "proto_item" as "GNode" rather than "struct
GNode"; the latter, as Andreas Sikkema noted, gets warnings from some
C++ compilers, but the former doesn't.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2029
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 30 May 2000 03:35:55 +0000 (03:35 +0000)]
Give the IPX dissector dissector hash tables for the IPX type and socket
number, and have the protocols encapsulated inside IPX register
themselves with that table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2028
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 30 May 2000 03:09:11 +0000 (03:09 +0000)]
#include netinet/in.h (for ntohs() macro), if available.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2027
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Mon, 29 May 2000 22:35:11 +0000 (22:35 +0000)]
1 - Use "tvb_reported_length()" in the X.25 dissector.
2 - Consistantly display LCN in decimal (they used to be displayed in
decimal in the packet list, and in hexadecimal in the tree view).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2026
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 29 May 2000 20:42:55 +0000 (20:42 +0000)]
Graham Bloice's Win32 Makefile changes to build in batch mode (gets rid
of multiple compile lines in the output of the build, speeds the build
up).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2025
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 29 May 2000 20:11:41 +0000 (20:11 +0000)]
Graham Bloice's Win32 Makefile changes to build in batch mode (gets rid
of multiple compile lines in the output of the build, speeds the build
up).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2024
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 29 May 2000 08:57:42 +0000 (08:57 +0000)]
Add "tvb_reported_length()" to get the "reported length" of a tvbuff
(i.e., the amount of data that was in the packet, even if not all of it
was captured), for use when dissecting packets containing data that
fills the packet (we want the dissector to try to dissect all of it; if
it runs past the end of the captured data, we want it to throw an
exception so that we'll put a "Short Frame" note in the protocol tree).
This means we always want a tvbuff to have a real reported length value,
so we make it an unsigned integer, and don't bother checking it for -1,
as it should never be -1.
If the reported length passed in to "tvb_set_subset()" is -1, set the
reported length to the reported length of the tvbuff of which the new
tvbuff will be a subset minus the offset in that tvbuff of the subset,
so that "-1" means "what's left of the packet after we chop off the
header". This is necessary in order to ensure that all tvbuffs have a
real reported length value.
Have "dissect_packet()" set the reported length of the top-level tvbuff
to the reported length of the frame, so that we start out with a tvbuff
with a real reported length value.
Have "tvb_offset_exists()" return FALSE if the offset is past the end of
the tvbuff.
If the offset passed to it is postitive, have "compute_offset_length()"
check for that it's not more than one byte past the end of the tvbuff -
if it's just past the end, we don't want the check to fail, as we don't
want attempts to create a subset tvbuff containing zero bytes to fail;
that would be done if a captured packet was all header and no payload,
and we'd want the dissector of the payload, not the dissector of the
header, to throw an exception, as the problem isn't with the protocol
for the header, it's with the protocol for the payload.
Convert the ATM dissector, the SSCOP dissector, the Q.2931 dissector,
and the Q.931 dissector to use tvbuffs.
Make the LAPD dissector set up a tvbuff for the Q.931 dissector (it's
not converted yet).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2023
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 28 May 2000 22:59:18 +0000 (22:59 +0000)]
Give the Appletalk DDP dissector a dissector hash table, and have the
protocols encapsulated inside DDP register themselves with that table.
Pull the EIGRP dissector into its own file, as suggested by Paul
Ionescu; it's not an IP-specific protocol.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2022
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 28 May 2000 22:02:17 +0000 (22:02 +0000)]
In the FDDI and LLC dissectors, extract fields as we use them, so that
we don't get an exception (and thus a "Short Frame" or "Malformed
Frame" entry) until we get to a field that isn't in the frame.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2021
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 28 May 2000 21:21:23 +0000 (21:21 +0000)]
Use "tvb_get_ntoh24()" to extract the OUI from a SNAP header, rather
than extracting each byte with "tvb_get_guint8()" and then putting them
together.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2020
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Sun, 28 May 2000 17:04:47 +0000 (17:04 +0000)]
Changed my mail address to oabad@cybercable.fr (dhis.net is too
unreliable).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2019
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Sun, 28 May 2000 06:26:10 +0000 (06:26 +0000)]
Properly register hf_x25_dbit and hf_ex25_dbit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2018
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 27 May 2000 17:51:15 +0000 (17:51 +0000)]
Fix some typos in strings.
Remove some of the comments from the "README.developer" sample whose
purpose was tutorial rather than explanatory, or that don't apply.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2017
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Sat, 27 May 2000 15:46:02 +0000 (15:46 +0000)]
Use tvb_length() instead of END_OF_FRAME.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2016
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Sat, 27 May 2000 15:21:31 +0000 (15:21 +0000)]
Mention Stefan Raab as author of Mobile IP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2015
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Sat, 27 May 2000 13:54:17 +0000 (13:54 +0000)]
Add Mobile IP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2014
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Sat, 27 May 2000 13:53:26 +0000 (13:53 +0000)]
Add Mobile IP dissector. Converted to use tvbuff.
I'm going to make one more change to get rid of use of END_OF_FRAME, but
that will be later.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2013
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 26 May 2000 22:08:16 +0000 (22:08 +0000)]
Support for SCTP in the capture dialog, from Michael Tuexen.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2012
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 26 May 2000 21:54:59 +0000 (21:54 +0000)]
Initial SCTP support (showing it by name from "ipprotostr()") from
Michael Tuexen.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2011
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 26 May 2000 07:47:47 +0000 (07:47 +0000)]
Incorporate the GTK+ 1.2.8 version of "gtkclist.c" (which includes all
the speedups ours included, and some others).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2010
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 26 May 2000 07:32:56 +0000 (07:32 +0000)]
Don't duplicate the "gtk_radio_button_new_with_label()" and
"gtk_check_button_new_with_label()" code, just call those routines and
then fix up the label, as suggested by Dermot Musgrove on the gtk
mailing list.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2009
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 26 May 2000 05:52:55 +0000 (05:52 +0000)]
Get rid of some now-unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2008
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 25 May 2000 21:34:58 +0000 (21:34 +0000)]
Convert X.25 dissector to use tvbuffs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2007
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 25 May 2000 18:32:06 +0000 (18:32 +0000)]
replaced pinfo->current with pinfo->current_proto
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2006
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 25 May 2000 15:11:11 +0000 (15:11 +0000)]
Set pinfo->current_proto
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2005
f5534014-38df-0310-8fa8-
9805f1628bb7
oabad [Thu, 25 May 2000 14:57:34 +0000 (14:57 +0000)]
Removed : col_add_fstr(pinfo->fd, COL_RES_DL_SRC, "0x%02X", byte0);
because it overrides the "DTE" or "DCE" value which was added before.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2004
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 25 May 2000 14:55:22 +0000 (14:55 +0000)]
Convert dissect_clip() to use tvbuffs. Very trivial change.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2003
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 25 May 2000 09:00:24 +0000 (09:00 +0000)]
Support for reading compressed Sniffer files, from Tim Farley, Joerg
Mayer, and yours truly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2002
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 25 May 2000 08:45:54 +0000 (08:45 +0000)]
Convert LAPB dissector to use tvbuffs, and to get pseudo_header from
packet_info struct.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2001
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 25 May 2000 08:38:54 +0000 (08:38 +0000)]
Assorted enhancements from Mark Burton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2000
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 25 May 2000 08:32:13 +0000 (08:32 +0000)]
Assorted padding fixes from Mark Burton.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1999
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 25 May 2000 07:42:26 +0000 (07:42 +0000)]
Convert dissect_ppp() and friends to use tvbuffs.
(the ip_tcp_options stuff is still non-tvbuff until I convert ip and tcp).
Add preliminary fix for Linux ISDN ippp devices (similar watch was posted
to ethereal-users, but did not use tvbuffs).
Change packet-raw.c to call capture_ppp()/dissect_ppp() in the case
where the frame starts with FF:03. We had been calling
capture_ip()/dissect_ip() at byte offset 4, but I think this is for
historical reasons of packet-raw.c and packet-ip.c existing before
packet-ppp.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1998
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 24 May 2000 07:52:31 +0000 (07:52 +0000)]
Display the fragment offset in decimal (as the IPv4 dissector does)
rather than hex.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1997
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 24 May 2000 07:51:10 +0000 (07:51 +0000)]
Patch from Scott Howard to show the IP fragment offset as a byte offset
rather than an 8-byte offset.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1996
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 24 May 2000 05:59:50 +0000 (05:59 +0000)]
Update a comment to reflect that only UCD SNMP 4.1.1 has
"snmp_set_full_objid()" as a macro rather than a function - 4.1.2 has it
as a function again.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1995
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 22 May 2000 18:09:36 +0000 (18:09 +0000)]
EIGRP over Appletalk and EIGRP over IPX support, from Paul Ionescu.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1994
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 22 May 2000 17:59:53 +0000 (17:59 +0000)]
Support for ISAKMP XAUTH authentication, from Yaniv Kaul.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1993
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 22 May 2000 17:56:01 +0000 (17:56 +0000)]
Get rid of the comment before "cfgattrident2str()" explaining why it's
there - it's now called from within "packet-isakmp.c", so there's no
need to explain "this isn't used yet, but it will be in the future"; the
future has arrived....
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1992
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 21 May 2000 19:59:02 +0000 (19:59 +0000)]
Parsing attributes in Config mode, and support for a Hybrid mode
authentication draft, from Yaniv Kaul.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1991
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 20 May 2000 20:52:27 +0000 (20:52 +0000)]
Use "rm -f", not "rm", to remove "plugin_api.obj", so that if
"plugin_api.obj" doesn't exist, it just drives on rather than giving an
error.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1990
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 19 May 2000 23:07:04 +0000 (23:07 +0000)]
Add wtap-int.h. Move definitions relevant to the internal workins of wiretap
to that file, leave public definitions in wtap.h.
Rename "union pseudo_header" to "union wtap_pseudo_header".
Make the wtap_pseudo_header pointer available in packet_info struct.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1989
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 19 May 2000 22:37:57 +0000 (22:37 +0000)]
Move the closes of the save file FD around:
"capture()" should ensure that it's closed before returning, but
it was only getting closed by "wtap_dump_close()" on success, so
close the raw FD on failure (no "wtap_dump" stream is opened on
failure, so we just close the raw FD);
in a "update the display as packets arrive" capture, we should
close the FD in the parent as soon as the fork is done, before
even testing whether the fork succeeded (and we might as well do
the same with the write side of the sync pipe).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1988
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 19 May 2000 21:47:38 +0000 (21:47 +0000)]
Convert dissect_raw() to use tvbuff's.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1987
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 19 May 2000 19:53:48 +0000 (19:53 +0000)]
Close capture file descriptor.
From Mark Burton <markb@ordern.com>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1986
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 19 May 2000 19:48:01 +0000 (19:48 +0000)]
Detect CISCO and NOVELL type IPX packets.
From Paul Ionescu <ipaul@romsys.ro>
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1985
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 19 May 2000 08:18:17 +0000 (08:18 +0000)]
In Wiretap, a file stream handle is a "FILE_T", not a "FILE_T *" (a
"FILE_T" is either a "gzFile" or a "FILE *", depending on whether zlib
support is enabled or not). Fix various function declarations and
definitions.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1984
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 19 May 2000 07:00:04 +0000 (07:00 +0000)]
The only packets that look like SMUX packets *are* SMUX packets (unlike
SNMP, where we let the ATM code tell the SNMP dissector to call it
"ILMI"), so don't pass a protocol name string into "dissect_smux_pdu()",
just have "dissect_smux_pdu()" call it "SMUX".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1983
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 19 May 2000 05:33:32 +0000 (05:33 +0000)]
"wtap.h" doesn't need to include "ascend.h" or "toshiba.h".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1982
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 19 May 2000 05:29:44 +0000 (05:29 +0000)]
Make "packet-clip.c", "packet-raw.c", "packet-ppp.c", "packet-tr.c",
"packet-eth.c", and "packet-fddi.c" include the include files that
declare the functions they export, so that the declarationss in the
header files will be checked against the definitions in the source
files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1981
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 19 May 2000 05:18:26 +0000 (05:18 +0000)]
Make "packet-null.c" include "packet-null.h", so that the declarations
in "packet-null.h" will be checked against the definitions in
"packet-null.c".
Fix the declaration of "dissect_null()" in "packet-null.h", so that said
checks don't complain.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1980
f5534014-38df-0310-8fa8-
9805f1628bb7